deslop 0.1.0

A static analyzer that spots low-context and AI-assisted code patterns across naming, concurrency, security, performance, and test quality.
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80

use crate::analysis::{ParsedFile, ParsedFunction};
use crate::model::{Finding, Severity};

pub(super) fn test_quality_findings(file: &ParsedFile, function: &ParsedFunction) -> Vec<Finding> {
    if !file.is_test_file {
        return Vec::new();
    }

    let Some(summary) = &function.test_summary else {
        return Vec::new();
    };

    let mut findings = Vec::new();

    if summary.assertion_like_calls == 0 && summary.skip_calls == 0 && summary.production_calls > 0 {
        findings.push(Finding {
            rule_id: "test_without_assertion_signal".to_string(),
            severity: Severity::Warning,
            path: file.path.clone(),
            function_name: Some(function.fingerprint.name.clone()),
            start_line: function.fingerprint.start_line,
            end_line: function.fingerprint.end_line,
            message: format!(
                "test {} exercises code without an obvious assertion signal",
                function.fingerprint.name
            ),
            evidence: vec![
                format!("production calls observed: {}", summary.production_calls),
                "no t.Fatal/assert/require-style assertion calls were observed".to_string(),
            ],
        });
    }

    if summary.assertion_like_calls > 0
        && summary.error_assertion_calls == 0
        && summary.production_calls > 0
        && summary.skip_calls == 0
    {
        findings.push(Finding {
            rule_id: "happy_path_only_test".to_string(),
            severity: Severity::Info,
            path: file.path.clone(),
            function_name: Some(function.fingerprint.name.clone()),
            start_line: function.fingerprint.start_line,
            end_line: function.fingerprint.end_line,
            message: format!(
                "test {} appears to cover only success expectations",
                function.fingerprint.name
            ),
            evidence: vec![
                format!("assertion-like calls observed: {}", summary.assertion_like_calls),
                "no negative-path or error assertion signals were observed".to_string(),
            ],
        });
    }

    if summary.has_todo_marker
        || summary.skip_calls > 0 && summary.production_calls == 0
        || summary.assertion_like_calls == 0 && summary.production_calls == 0 && function.fingerprint.line_count <= 6
    {
        findings.push(Finding {
            rule_id: "placeholder_test_body".to_string(),
            severity: Severity::Info,
            path: file.path.clone(),
            function_name: Some(function.fingerprint.name.clone()),
            start_line: function.fingerprint.start_line,
            end_line: function.fingerprint.end_line,
            message: format!(
                "test {} looks like a placeholder rather than a validating test",
                function.fingerprint.name
            ),
            evidence: vec![
                format!("skip calls observed: {}", summary.skip_calls),
                format!("production calls observed: {}", summary.production_calls),
            ],
        });
    }

    findings
}