delta-funnel 0.2.1

Lightweight, fast Delta Lake to SQL Server loads with DataFusion SQL and native TDS
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
//! Lazy native async file-read scheduling boundary.
//!
//! The scheduler is demand-driven: each `next_file` call admits at most one
//! file after async read permits are acquired. It does not prebuild per-file
//! futures or buffer completed output internally.

use std::collections::VecDeque;
use std::future::Future;
use std::marker::PhantomData;
use std::pin::Pin;
use std::sync::Arc;

use crate::DeltaFunnelError;

use super::scheduling::{DeltaProviderAsyncFileReadPermit, DeltaProviderAsyncPartitionReadLimiter};

/// Native async scheduler output buffer capacity.
///
/// The internal scheduler is demand-driven and has no completed-output buffer.
/// The DataFusion stream adapter documents its own handoff capacity.
#[allow(dead_code)]
pub(crate) const DELTA_PROVIDER_ASYNC_SCHEDULER_OUTPUT_CAPACITY: usize = 0;

/// Future returned by a native async file reader.
#[allow(dead_code)]
pub(crate) type DeltaProviderAsyncFileReadFuture<Output> =
    Pin<Box<dyn Future<Output = Result<Output, DeltaFunnelError>> + Send>>;

type DeltaProviderAsyncTaskAdmissionFilter<Task> = Arc<dyn Fn(&Task) -> bool + Send + Sync>;

/// Native async file reader used by the lazy scheduler.
#[allow(dead_code)]
pub(crate) trait DeltaProviderAsyncFileReader<Task, Output>: Send + Sync {
    /// Starts one file read after the scheduler has acquired read permits.
    ///
    /// Implementations may return a completed file result or a stream-like file
    /// handle. The returned future should only advance the file read far enough
    /// to produce the `Output` boundary.
    fn start_file_read(
        &self,
        task: Task,
        permit: DeltaProviderAsyncFileReadPermit,
    ) -> DeltaProviderAsyncFileReadFuture<Output>;
}

/// Configuration for one execution partition's native async read scheduler.
#[allow(dead_code)]
pub(crate) struct DeltaProviderAsyncPartitionReadSchedulerConfig<Task, Output, Reader>
where
    Reader: DeltaProviderAsyncFileReader<Task, Output> + ?Sized,
{
    /// Planned file tasks for one DataFusion execution partition.
    pub(crate) file_tasks: Vec<Task>,
    /// Reader backend used for native async file work.
    pub(crate) reader: Arc<Reader>,
    /// Partition-local limiter view for this execution partition.
    pub(crate) partition_limiter: DeltaProviderAsyncPartitionReadLimiter,
    task_admission_filter: DeltaProviderAsyncTaskAdmissionFilter<Task>,
    _output: PhantomData<Output>,
}

#[allow(dead_code)]
impl<Task, Output, Reader> DeltaProviderAsyncPartitionReadSchedulerConfig<Task, Output, Reader>
where
    Reader: DeltaProviderAsyncFileReader<Task, Output> + ?Sized,
{
    /// Builds scheduler configuration from planned file tasks and backend state.
    pub(crate) fn new(
        file_tasks: Vec<Task>,
        reader: Arc<Reader>,
        partition_limiter: DeltaProviderAsyncPartitionReadLimiter,
    ) -> Self {
        Self {
            file_tasks,
            reader,
            partition_limiter,
            task_admission_filter: Arc::new(|_| true),
            _output: PhantomData,
        }
    }

    /// Adds a file-task admission predicate evaluated before a task starts.
    pub(crate) fn with_task_admission_filter(
        mut self,
        task_admission_filter: DeltaProviderAsyncTaskAdmissionFilter<Task>,
    ) -> Self {
        self.task_admission_filter = task_admission_filter;
        self
    }
}

/// Lazy native async scheduler for one DataFusion execution partition.
#[allow(dead_code)]
pub(crate) struct DeltaProviderAsyncPartitionReadScheduler<Task, Output, Reader>
where
    Reader: DeltaProviderAsyncFileReader<Task, Output> + ?Sized,
{
    file_tasks: VecDeque<Task>,
    reader: Arc<Reader>,
    partition_limiter: DeltaProviderAsyncPartitionReadLimiter,
    task_admission_filter: DeltaProviderAsyncTaskAdmissionFilter<Task>,
    admitted_file_tasks: usize,
    _output: PhantomData<Output>,
}

#[allow(dead_code)]
impl<Task, Output, Reader> DeltaProviderAsyncPartitionReadScheduler<Task, Output, Reader>
where
    Task: Send + 'static,
    Output: 'static,
    Reader: DeltaProviderAsyncFileReader<Task, Output> + ?Sized + 'static,
{
    /// Builds a lazy native async scheduler for one execution partition.
    pub(crate) fn new(
        config: DeltaProviderAsyncPartitionReadSchedulerConfig<Task, Output, Reader>,
    ) -> Self {
        Self {
            file_tasks: VecDeque::from(config.file_tasks),
            reader: config.reader,
            partition_limiter: config.partition_limiter,
            task_admission_filter: config.task_admission_filter,
            admitted_file_tasks: 0,
            _output: PhantomData,
        }
    }

    /// Returns the next completed file-read output.
    ///
    /// This method acquires permits before popping the next task and creating a
    /// read future. Dropping this future cancels the current admission attempt
    /// or in-flight file read and releases any acquired permits.
    pub(crate) async fn next_file(&mut self) -> Option<Result<Output, DeltaFunnelError>> {
        self.discard_rejected_front_tasks();
        self.file_tasks.front()?;

        let permit = match self.partition_limiter.acquire_file_permit().await {
            Ok(permit) => permit,
            Err(error) => return Some(Err(error)),
        };
        let task = self.file_tasks.pop_front()?;
        self.admitted_file_tasks = self.admitted_file_tasks.saturating_add(1);

        Some(self.reader.start_file_read(task, permit).await)
    }

    /// Schedules one future file for bounded prefetch without borrowing the scheduler.
    ///
    /// This is used only by the bounded prefetch stream adapter. Calling this
    /// method removes one task from the pending queue and returns a future. The
    /// returned future starts opening that file only when it is polled: permits
    /// are acquired inside the future before reader work starts. Dropping the
    /// future cancels setup and releases any permit already acquired.
    pub(crate) fn schedule_prefetch_file(
        &mut self,
    ) -> Option<DeltaProviderAsyncFileReadFuture<Output>> {
        let task = self.pop_next_admitted_task()?;
        let reader = Arc::clone(&self.reader);
        let partition_limiter = self.partition_limiter.clone();

        Some(Box::pin(async move {
            let permit = partition_limiter.acquire_file_permit().await?;

            reader.start_file_read(task, permit).await
        }))
    }

    /// Planned file tasks not yet admitted to a read future.
    pub(crate) fn remaining_file_tasks(&self) -> usize {
        self.file_tasks.len()
    }

    /// File tasks admitted to a read future.
    ///
    /// Lazy reads acquire a permit before admission. Prefetch reads admit the
    /// task first and acquire the permit later when the returned future is
    /// polled.
    pub(crate) fn admitted_file_tasks(&self) -> usize {
        self.admitted_file_tasks
    }

    /// Internal completed-output buffer capacity for this scheduler.
    pub(crate) fn output_capacity(&self) -> usize {
        DELTA_PROVIDER_ASYNC_SCHEDULER_OUTPUT_CAPACITY
    }

    fn pop_next_admitted_task(&mut self) -> Option<Task> {
        loop {
            let task = self.file_tasks.pop_front()?;
            if (self.task_admission_filter)(&task) {
                self.admitted_file_tasks = self.admitted_file_tasks.saturating_add(1);
                return Some(task);
            }
        }
    }

    fn discard_rejected_front_tasks(&mut self) {
        while self
            .file_tasks
            .front()
            .is_some_and(|task| !(self.task_admission_filter)(task))
        {
            self.file_tasks.pop_front();
        }
    }
}

#[cfg(test)]
mod tests {
    use std::sync::Arc;
    use std::sync::atomic::{AtomicUsize, Ordering};

    use super::{
        DELTA_PROVIDER_ASYNC_SCHEDULER_OUTPUT_CAPACITY, DeltaProviderAsyncFileReadFuture,
        DeltaProviderAsyncFileReader, DeltaProviderAsyncPartitionReadScheduler,
        DeltaProviderAsyncPartitionReadSchedulerConfig,
    };
    use crate::DeltaFunnelError;
    use crate::query_engine::datafusion::execution::scheduling::{
        DeltaProviderAsyncFileReadPermit, DeltaProviderAsyncReadLimiter,
        DeltaProviderReaderBackend, DeltaProviderScanExecutionOptions,
    };

    #[derive(Clone, Copy)]
    struct FakeFileTask {
        id: usize,
    }

    struct CountingAsyncFileReader {
        futures_created: Arc<AtomicUsize>,
        reads_started: Arc<AtomicUsize>,
    }

    impl CountingAsyncFileReader {
        fn new() -> Self {
            Self {
                futures_created: Arc::new(AtomicUsize::new(0)),
                reads_started: Arc::new(AtomicUsize::new(0)),
            }
        }

        fn futures_created(&self) -> usize {
            self.futures_created.load(Ordering::SeqCst)
        }

        fn reads_started(&self) -> usize {
            self.reads_started.load(Ordering::SeqCst)
        }
    }

    impl DeltaProviderAsyncFileReader<FakeFileTask, usize> for CountingAsyncFileReader {
        fn start_file_read(
            &self,
            task: FakeFileTask,
            permit: DeltaProviderAsyncFileReadPermit,
        ) -> DeltaProviderAsyncFileReadFuture<usize> {
            self.futures_created.fetch_add(1, Ordering::SeqCst);
            let reads_started = Arc::clone(&self.reads_started);
            Box::pin(async move {
                let _permit = permit;
                reads_started.fetch_add(1, Ordering::SeqCst);
                Ok(task.id)
            })
        }
    }

    struct PendingAsyncFileReader {
        futures_created: Arc<AtomicUsize>,
        reads_started: Arc<AtomicUsize>,
    }

    impl PendingAsyncFileReader {
        fn new() -> Self {
            Self {
                futures_created: Arc::new(AtomicUsize::new(0)),
                reads_started: Arc::new(AtomicUsize::new(0)),
            }
        }

        fn futures_created(&self) -> usize {
            self.futures_created.load(Ordering::SeqCst)
        }

        fn reads_started(&self) -> usize {
            self.reads_started.load(Ordering::SeqCst)
        }
    }

    impl DeltaProviderAsyncFileReader<FakeFileTask, usize> for PendingAsyncFileReader {
        fn start_file_read(
            &self,
            _task: FakeFileTask,
            permit: DeltaProviderAsyncFileReadPermit,
        ) -> DeltaProviderAsyncFileReadFuture<usize> {
            self.futures_created.fetch_add(1, Ordering::SeqCst);
            let reads_started = Arc::clone(&self.reads_started);
            Box::pin(async move {
                let _permit = permit;
                reads_started.fetch_add(1, Ordering::SeqCst);
                std::future::pending::<Result<usize, DeltaFunnelError>>().await
            })
        }
    }

    #[tokio::test]
    async fn scheduler_has_no_internal_output_buffer() -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                reader,
                partition,
            ),
        );

        assert_eq!(scheduler.output_capacity(), 0);
        assert_eq!(DELTA_PROVIDER_ASYNC_SCHEDULER_OUTPUT_CAPACITY, 0);

        Ok(())
    }

    #[tokio::test]
    async fn scheduler_does_not_create_file_future_before_polling()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                Arc::clone(&reader),
                partition,
            ),
        );

        let next = Box::pin(scheduler.next_file());

        assert_eq!(reader.futures_created(), 0);
        assert_eq!(reader.reads_started(), 0);

        drop(next);

        assert_eq!(scheduler.admitted_file_tasks(), 0);
        assert_eq!(scheduler.remaining_file_tasks(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn scheduler_creates_one_file_future_per_downstream_demand()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![
                    FakeFileTask { id: 1 },
                    FakeFileTask { id: 2 },
                    FakeFileTask { id: 3 },
                ],
                Arc::clone(&reader),
                partition,
            ),
        );

        assert_eq!(scheduler.remaining_file_tasks(), 3);
        assert_eq!(scheduler.admitted_file_tasks(), 0);
        assert_eq!(reader.futures_created(), 0);

        let first = scheduler
            .next_file()
            .await
            .ok_or("expected first file output")??;

        assert_eq!(first, 1);
        assert_eq!(scheduler.remaining_file_tasks(), 2);
        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn slow_downstream_demand_bounds_admitted_work() -> Result<(), Box<dyn std::error::Error>>
    {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![
                    FakeFileTask { id: 1 },
                    FakeFileTask { id: 2 },
                    FakeFileTask { id: 3 },
                ],
                Arc::clone(&reader),
                partition,
            ),
        );

        let first = scheduler
            .next_file()
            .await
            .ok_or("expected first file output")??;

        assert_eq!(first, 1);
        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 2);
        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        tokio::task::yield_now().await;

        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 2);
        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn scheduler_does_not_admit_file_work_before_permits()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter = DeltaProviderAsyncReadLimiter::new(
            DeltaProviderScanExecutionOptions::try_new_with_reader_backend(
                DeltaProviderReaderBackend::NativeAsync,
                1,
                1,
            )?,
            1,
        );
        let partition = limiter.partition_limiter(0)?;
        let held_permit = partition.acquire_file_permit().await?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                Arc::clone(&reader),
                partition,
            ),
        );
        let mut next = Box::pin(scheduler.next_file());

        tokio::select! {
            output = &mut next => {
                return Err(format!("file read should wait for permits: {output:?}").into());
            }
            () = tokio::task::yield_now() => {}
        }

        assert_eq!(reader.futures_created(), 0);
        assert_eq!(reader.reads_started(), 0);
        assert_eq!(limiter.active_file_reads(), 1);

        drop(next);
        drop(held_permit);

        assert_eq!(scheduler.admitted_file_tasks(), 0);
        assert_eq!(scheduler.remaining_file_tasks(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn scheduler_admission_filter_skips_rejected_tasks_before_permits()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter = DeltaProviderAsyncReadLimiter::new(
            DeltaProviderScanExecutionOptions::try_new_with_reader_backend(
                DeltaProviderReaderBackend::NativeAsync,
                1,
                1,
            )?,
            1,
        );
        let partition = limiter.partition_limiter(0)?;
        let held_permit = partition.acquire_file_permit().await?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                Arc::clone(&reader),
                partition,
            )
            .with_task_admission_filter(Arc::new(|task: &FakeFileTask| task.id != 1)),
        );

        let next = scheduler.next_file().await;

        assert!(next.is_none());
        assert_eq!(reader.futures_created(), 0);
        assert_eq!(reader.reads_started(), 0);
        assert_eq!(scheduler.admitted_file_tasks(), 0);
        assert_eq!(scheduler.remaining_file_tasks(), 0);
        assert_eq!(limiter.active_file_reads(), 1);

        drop(held_permit);

        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn dropping_in_flight_scheduler_future_releases_permits()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(PendingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                Arc::clone(&reader),
                partition,
            ),
        );
        let mut next = Box::pin(scheduler.next_file());

        tokio::select! {
            output = &mut next => {
                return Err(format!("pending file read should not complete: {output:?}").into());
            }
            () = tokio::task::yield_now() => {}
        }

        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 1);

        drop(next);

        assert_eq!(limiter.active_file_reads(), 0);
        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn cancellation_stops_future_file_scheduling_without_draining_prefetch()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(PendingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }, FakeFileTask { id: 2 }],
                Arc::clone(&reader),
                partition,
            ),
        );
        let mut next = Box::pin(scheduler.next_file());

        tokio::select! {
            output = &mut next => {
                return Err(format!("pending file read should not complete: {output:?}").into());
            }
            () = tokio::task::yield_now() => {}
        }

        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 1);

        drop(next);
        tokio::task::yield_now().await;

        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 1);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn prefetch_file_future_is_cancellable_before_polling()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(CountingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }, FakeFileTask { id: 2 }],
                Arc::clone(&reader),
                partition,
            ),
        );

        let prefetched = scheduler
            .schedule_prefetch_file()
            .ok_or("expected prefetched file future")?;

        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 1);
        assert_eq!(reader.futures_created(), 0);
        assert_eq!(reader.reads_started(), 0);
        assert_eq!(limiter.active_file_reads(), 0);

        drop(prefetched);

        assert_eq!(reader.futures_created(), 0);
        assert_eq!(reader.reads_started(), 0);
        assert_eq!(limiter.active_file_reads(), 0);

        Ok(())
    }

    #[tokio::test]
    async fn dropping_in_flight_prefetch_future_releases_permits()
    -> Result<(), Box<dyn std::error::Error>> {
        let limiter =
            DeltaProviderAsyncReadLimiter::new(DeltaProviderScanExecutionOptions::default(), 1);
        let partition = limiter.partition_limiter(0)?;
        let reader = Arc::new(PendingAsyncFileReader::new());
        let mut scheduler = DeltaProviderAsyncPartitionReadScheduler::new(
            DeltaProviderAsyncPartitionReadSchedulerConfig::new(
                vec![FakeFileTask { id: 1 }],
                Arc::clone(&reader),
                partition,
            ),
        );
        let mut prefetched = scheduler
            .schedule_prefetch_file()
            .ok_or("expected prefetched file future")?;

        tokio::select! {
            output = &mut prefetched => {
                return Err(format!("pending prefetch should not complete: {output:?}").into());
            }
            () = tokio::task::yield_now() => {}
        }

        assert_eq!(reader.futures_created(), 1);
        assert_eq!(reader.reads_started(), 1);
        assert_eq!(limiter.active_file_reads(), 1);

        drop(prefetched);

        assert_eq!(limiter.active_file_reads(), 0);
        assert_eq!(scheduler.admitted_file_tasks(), 1);
        assert_eq!(scheduler.remaining_file_tasks(), 0);

        Ok(())
    }

    #[test]
    fn async_scheduler_source_avoids_blocking_runtime_patterns() {
        let source = include_str!("async_scheduler.rs");
        let forbidden_patterns = [
            concat!("Cond", "var"),
            concat!("Mut", "ex"),
            concat!("block", "_", "on"),
            concat!("Handle", "::", "block", "_", "on"),
            concat!("Runtime", "::", "new"),
            concat!("spawn", "_", "blocking"),
        ];

        for pattern in forbidden_patterns {
            assert!(
                !source.contains(pattern),
                "async scheduler source must not contain {pattern}"
            );
        }
    }

    #[test]
    fn async_limiter_dependency_is_direct_production_dependency()
    -> Result<(), Box<dyn std::error::Error>> {
        let manifest = include_str!("../../../../Cargo.toml");
        let dependency_line = direct_dependency_line(manifest, "tokio")
            .ok_or("expected tokio direct dependency in production dependencies")?;

        assert!(dependency_line.contains("features"));
        assert!(dependency_line.contains("\"sync\""));

        Ok(())
    }

    fn direct_dependency_line<'a>(manifest: &'a str, dependency: &str) -> Option<&'a str> {
        let mut in_dependency_section = false;

        for line in manifest.lines() {
            let trimmed = line.trim();
            if trimmed.starts_with('[') && trimmed.ends_with(']') {
                in_dependency_section = trimmed == "[dependencies]";
                continue;
            }
            if !in_dependency_section {
                continue;
            }
            if trimmed.starts_with(&format!("{dependency} =")) {
                return Some(trimmed);
            }
        }

        None
    }
}