1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
//! Integration tests for coordinate conversion error handling.
//!
//! This module tests that functions properly handle coordinate conversion errors
//! when dealing with extreme values, NaN, infinity, etc.
use delaunay::prelude::geometry::*;
// =============================================================================
// GEOMETRIC PREDICATES ERROR TESTS
// =============================================================================
#[test]
fn test_insphere_with_nan_coordinates() {
// Test 3D insphere with NaN coordinates
let points = vec![
Point::new([1.0, 0.0, 0.0]),
Point::new([0.0, 1.0, 0.0]),
Point::new([0.0, 0.0, 1.0]),
Point::new([f64::NAN, 0.5, 0.5]), // Point with NaN
];
let test_point = Point::new([0.5, 0.5, 0.5]);
// The function should return an error due to NaN coordinate
let result = insphere(&points, test_point);
match result {
Err(CoordinateConversionError::NonFiniteValue { .. }) => {
// Expected error type
}
other => panic!("Expected CoordinateConversionError::NonFiniteValue, got: {other:?}"),
}
}
#[test]
fn test_insphere_with_infinity_coordinates() {
// Test 3D insphere with infinity coordinates
let points = vec![
Point::new([1.0, 0.0, 0.0]),
Point::new([0.0, 1.0, 0.0]),
Point::new([0.0, 0.0, 1.0]),
Point::new([f64::INFINITY, 0.5, 0.5]), // Point with positive infinity
];
let test_point = Point::new([0.5, 0.5, 0.5]);
// The function should return an error due to infinity coordinate
let result = insphere(&points, test_point);
match result {
Err(CoordinateConversionError::NonFiniteValue { .. }) => {
// Expected error type
}
other => panic!("Expected CoordinateConversionError::NonFiniteValue, got: {other:?}"),
}
}
#[test]
fn test_insphere_2d_with_nan_coordinates() {
// Test 2D insphere with NaN coordinates (using 2D triangle)
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([f64::NAN, 1.0]), // Point with NaN
];
let test_point = Point::new([0.5, 0.5]);
// The function should return an error due to NaN coordinate
let result = insphere(&points, test_point);
match result {
Err(CoordinateConversionError::NonFiniteValue { .. }) => {
// Expected error type
}
other => panic!("Expected CoordinateConversionError::NonFiniteValue, got: {other:?}"),
}
}
#[test]
fn test_simplex_orientation_with_infinity_coordinates() {
// Test simplex orientation with infinity coordinates
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([f64::NEG_INFINITY, 1.0]), // Point with negative infinity
];
// The function should return an error due to infinity coordinate
let result = simplex_orientation(&points);
match result {
Err(CoordinateConversionError::NonFiniteValue { .. }) => {
// Expected error type
}
other => panic!("Expected CoordinateConversionError::NonFiniteValue, got: {other:?}"),
}
}
// =============================================================================
// UTILITY FUNCTIONS ERROR TESTS
// =============================================================================
#[test]
fn test_circumcenter_with_nan_coordinates() {
// Test circumcenter with NaN coordinates
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([f64::NAN, 1.0]), // Point with NaN
];
// The function should return an error due to NaN coordinate
let result = circumcenter(&points);
match result {
Err(CircumcenterError::CoordinateConversion(
CoordinateConversionError::NonFiniteValue { .. },
)) => {
// Expected error type
}
other => panic!(
"Expected CoordinateConversionError::NonFiniteValue wrapped in CircumcenterError, got: {other:?}"
),
}
}
#[test]
fn test_circumradius_with_infinity_coordinates() {
// Test circumradius with infinity coordinates
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([0.0, f64::INFINITY]), // Point with positive infinity
];
// The function should return an error due to infinity coordinate
let result = circumradius(&points);
match result {
Err(CircumcenterError::CoordinateConversion(
CoordinateConversionError::NonFiniteValue { .. },
)) => {
// Expected error type
}
other => panic!(
"Expected CoordinateConversionError::NonFiniteValue wrapped in CircumcenterError, got: {other:?}"
),
}
}
#[test]
fn test_hypot_distance_with_mixed_problematic_coordinates() {
// Test distance calculation using hypot with mixed NaN and infinity
let point1_coords: [f64; 2] = [f64::NAN, 1.0];
let point2_coords: [f64; 2] = [1.0, f64::INFINITY];
// Calculate difference vector
let diff_coords = [
point1_coords[0] - point2_coords[0],
point1_coords[1] - point2_coords[1],
];
// The hypot function should handle problematic coordinates properly
// Since hypot returns T directly (not a Result), we expect it to return NaN or infinity
let result = hypot(&diff_coords);
// Verify that the result contains non-finite values
assert!(
!result.is_finite(),
"Expected non-finite result from hypot with NaN/infinity coordinates"
);
}
#[test]
fn test_hypot_with_nan_values() {
// Test hypot with NaN values
let result = hypot(&[f64::NAN, 1.0]);
// hypot returns T directly, so we check that the result is NaN
assert!(
result.is_nan(),
"Expected NaN result from hypot with NaN input"
);
}
#[test]
fn test_hypot_with_infinity_values() {
// Test hypot with infinity values
let result = hypot(&[f64::INFINITY, 1.0]);
// With our new safe conversion, hypot falls back to general algorithm when conversion fails
// The result should still be infinity due to the general algorithm handling infinity properly
assert!(
result.is_infinite() || result.is_nan(),
"Expected infinite or NaN result from hypot with infinity input"
);
}
// =============================================================================
// ROBUST PREDICATES ERROR TESTS
// =============================================================================
#[test]
fn test_robust_insphere_with_nan() {
// Test robust insphere with NaN coordinates
let points = vec![
Point::new([1.0, 0.0, 0.0]),
Point::new([0.0, 1.0, 0.0]),
Point::new([0.0, 0.0, 1.0]),
Point::new([f64::NAN, 0.5, 0.5]), // Point with NaN
];
let test_point = Point::new([0.5, 0.5, 0.5]);
let result = robust_insphere(&points, &test_point);
assert!(
matches!(
result,
Err(CoordinateConversionError::NonFiniteValue { .. })
),
"Expected CoordinateConversionError::NonFiniteValue, got: {result:?}"
);
}
#[test]
fn test_robust_insphere_with_infinity() {
// Test robust insphere with infinity coordinates
let points = vec![
Point::new([1.0, 0.0, 0.0]),
Point::new([0.0, 1.0, 0.0]),
Point::new([0.0, 0.0, 1.0]),
Point::new([f64::NEG_INFINITY, 0.5, 0.5]), // Point with negative infinity
];
let test_point = Point::new([0.5, 0.5, 0.5]);
let result = robust_insphere(&points, &test_point);
assert!(
matches!(
result,
Err(CoordinateConversionError::NonFiniteValue { .. })
),
"Expected CoordinateConversionError::NonFiniteValue, got: {result:?}"
);
}
// =============================================================================
// ERROR MESSAGE VERIFICATION TESTS
// =============================================================================
#[test]
fn test_error_message_contains_context() {
// Test that error messages contain useful context information
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([f64::NAN, 1.0]), // Point with NaN at coordinate index 0
];
let result = circumcenter(&points);
if let Err(error) = result {
let error_msg = error.to_string();
// Error message should contain useful context
assert!(error_msg.contains("NaN") || error_msg.contains("non-finite"));
// Should identify the problematic value type
assert!(error_msg.contains("coordinate") || error_msg.contains("value"));
} else {
panic!("Expected an error, but got Ok");
}
}
#[test]
fn test_infinity_error_message_contains_context() {
// Test that infinity error messages contain useful context using insphere_distance
// which uses hypot internally and should handle problematic coordinates
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([0.0, 1.0]), // Valid triangle
];
let test_point = Point::new([f64::INFINITY, 1.0]); // Point with infinity
let result = insphere_distance(&points, test_point);
if let Err(error) = result {
let error_msg = error.to_string();
// Error message should contain useful context about infinity or non-finite values
assert!(
error_msg.contains("inf")
|| error_msg.contains("infinite")
|| error_msg.contains("non-finite")
);
} else {
// For this test, we might get Ok since hypot can handle infinity
// In that case, we just verify the function doesn't crash
}
}
// =============================================================================
// EDGE CASE TESTS
// =============================================================================
#[test]
fn test_subnormal_values_handling() {
// Test that subnormal values are handled correctly (should not error)
let subnormal = f64::MIN_POSITIVE / 2.0;
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([subnormal, 1.0]), // Subnormal value
];
// Subnormal values should be handled without error (they're finite)
let result = circumcenter(&points);
match result {
Ok(_) => {
// Expected - subnormal values should be processed normally
}
Err(error) => panic!("Subnormal values should not cause errors: {error:?}"),
}
}
#[test]
fn test_zero_and_negative_zero() {
// Test that positive and negative zero are handled correctly
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([-0.0, 1.0]), // Negative zero
];
// Both positive and negative zero should be processed normally
let result = circumcenter(&points);
match result {
Ok(_) => {
// Expected - zero values should be processed normally
}
Err(error) => panic!("Zero values should not cause errors: {error:?}"),
}
}
#[test]
#[expect(clippy::match_same_arms)]
fn test_very_large_finite_values() {
// Test that very large but finite values are handled correctly
// Use a large value that won't overflow when squared (f64::MAX would become infinity when squared)
let large_value = 1e100; // Large but safe value
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([large_value, 1.0]), // Very large but finite value
];
// Large finite values should be handled without error as long as they don't overflow in calculations
let result = circumcenter(&points);
match result {
Ok(_) => {
// Expected - finite values should be processed normally
}
Err(CircumcenterError::CoordinateConversion(
CoordinateConversionError::NonFiniteValue { .. },
)) => {
// If the large value causes overflow during calculations (like squaring),
// this error is acceptable and expected
}
Err(other_error) => panic!("Unexpected error with large finite values: {other_error:?}"),
}
}
#[test]
fn test_very_small_finite_values() {
// Test that very small but finite values are handled correctly
let points = vec![
Point::new([0.0, 0.0]),
Point::new([1.0, 0.0]),
Point::new([f64::MIN_POSITIVE, 1.0]), // Very small but finite value
];
// Small finite values should be handled without error
let result = circumcenter(&points);
match result {
Ok(_) => {
// Expected - finite values should be processed normally
}
Err(error) => panic!("Small finite values should not cause errors: {error:?}"),
}
}