delanocreds 0.2.1

Delegatable Anonymous Credentials (Delano Creds) in pure Rust.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
use std::fmt::Display;
use std::ops::Deref;

use bls12_381_plus::elliptic_curve::bigint;
use bls12_381_plus::elliptic_curve::ops::MulByGenerator;
use bls12_381_plus::ff::Field;
use bls12_381_plus::group::prime::PrimeCurveAffine;
use bls12_381_plus::group::Curve;
use bls12_381_plus::group::GroupEncoding;
use bls12_381_plus::G1Affine;
use bls12_381_plus::{G1Projective, Scalar};
use rand::rngs::ThreadRng;
use secrecy::{ExposeSecret, Secret};
use sha2::{Digest, Sha256};

use crate::error;
use crate::error::Error;
use crate::keypair::NymProof;
use crate::utils::try_decompress_g1;
use crate::utils::try_into_scalar;

/// Alias for Challenge Scalar
pub type Challenge = Scalar;

/// A Scalar Nonce, number used once. It can be serialized and deserialized to and from bytes
/// as it does not have a compressed form.
#[derive(PartialEq, Eq, Debug, Clone)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct Nonce(pub(crate) Scalar);

/// Create a new [Nonce] with any arbitrary length type that implements AsRef<[u8]> by hashing it
/// into a 32 byte digest and converting it into a Scalar
impl Nonce {
    /// Hash the given bytes into a [Nonce]
    pub fn new(bytes: impl AsRef<[u8]>) -> Self {
        let chash = Sha256::digest(bytes);
        Self(Scalar::from(bigint::U256::from_be_slice(&chash)))
    }
}

impl Default for Nonce {
    fn default() -> Self {
        Self(Scalar::random(ThreadRng::default()))
    }
}

/// Attempts to convert from [u8; 32] directly into a Nonce
impl TryFrom<[u8; 32]> for Nonce {
    type Error = Error;

    fn try_from(bytes: [u8; 32]) -> Result<Self, Self::Error> {
        let maybe_coverted = Scalar::from_be_bytes(&bytes);
        if maybe_coverted.is_some().into() {
            Ok(Self(maybe_coverted.unwrap()))
        } else {
            Err(Error::NonceConversionError)
        }
    }
}

/// Converts from a &[u8, 32] directly into a Nonce
impl TryFrom<&[u8; 32]> for Nonce {
    type Error = Error;

    fn try_from(bytes: &[u8; 32]) -> Result<Self, Self::Error> {
        let maybe_coverted = Scalar::from_be_bytes(bytes);
        if maybe_coverted.is_some().into() {
            Ok(Self(maybe_coverted.unwrap()))
        } else {
            Err(Error::NonceConversionError)
        }
    }
}

/// Creates a new [Nonce] from a hash of the given Vec<u8>
impl From<Vec<u8>> for Nonce {
    fn from(bytes: Vec<u8>) -> Self {
        Self::new(bytes.as_slice())
    }
}

/// Creates a new [Nonce] from a hash of the given &[u8]
impl From<&Vec<u8>> for Nonce {
    fn from(bytes: &Vec<u8>) -> Self {
        Self::new(bytes.as_slice())
    }
}

impl From<&[u8]> for Nonce {
    fn from(bytes: &[u8]) -> Self {
        Self::new(bytes)
    }
}

impl Deref for Nonce {
    type Target = Scalar;

    fn deref(&self) -> &Self::Target {
        &self.0
    }
}

impl PartialEq<bls12_381_plus::Scalar> for &Nonce {
    fn eq(&self, other: &bls12_381_plus::Scalar) -> bool {
        self.0 == Scalar::from(*other)
    }
}

impl From<Option<&[u8]>> for Nonce {
    fn from(bytes: Option<&[u8]>) -> Self {
        match bytes {
            Some(bytes) => Self::new(bytes),
            None => Self::default(),
        }
    }
}

impl From<Nonce> for Vec<u8> {
    fn from(nonce: Nonce) -> Self {
        nonce.0.to_be_bytes().to_vec()
    }
}

impl From<&Nonce> for Vec<u8> {
    fn from(nonce: &Nonce) -> Self {
        nonce.0.to_be_bytes().to_vec()
    }
}

impl From<Nonce> for [u8; 32] {
    fn from(nonce: Nonce) -> Self {
        nonce.0.to_be_bytes()
    }
}

impl From<&Nonce> for [u8; 32] {
    fn from(nonce: &Nonce) -> Self {
        nonce.0.to_be_bytes()
    }
}

// These functions were in the original implementation but are unused in this Implementation
// Keeping them here unused under a 'zkp' flag for potential future use as needed
#[cfg(feature = "zkp")]
use anyhow::Result;
#[cfg(feature = "zkp")]
use bls12_381_plus::G2Affine;
#[cfg(feature = "zkp")]
use bls12_381_plus::G2Projective;

/// The Challenge State is a struct that contains the name of the challenge,
/// the generator, the statement, and the hash of the announcement
///
/// # Arguments
///
/// * `name` - The name of the challenge
/// * `g` - The generator
/// * `statement` - The statement
/// * `hash` - The hash of the announcement
#[derive(Clone, Debug)]
pub struct ChallengeState<T: PrimeCurveAffine> {
    pub name: String,
    pub g: T,
    pub statement: Vec<T>,
    pub hash: [u8; 32],
}

impl<T: PrimeCurveAffine + GroupEncoding> ChallengeState<T> {
    /// Creates a new [ChallengeState]
    pub fn new(statement: Vec<T>, announcement: impl AsRef<[u8]>) -> Self {
        Self {
            name: crate::config::CHALLENGE_STATE_NAME.to_string(),
            g: <T as PrimeCurveAffine>::generator(),
            statement,
            hash: Sha256::digest(announcement).into(),
        }
    }
}

// pub type Response = Vec<Scalar>;

/// Schnorr proof (non-interactive using Fiat Shamir heuristic) of the statement
/// ZK(x, m_1....m_n; h = g^x and h_1^m_1...h_n^m_n) and generalized version
pub mod zkp_schnorr_fiat_shamir {

    #[cfg(feature = "zkp")]
    use super::*;

    /// The code below is from the original implementation of the Schnorr proof (non-interactive using FS heuristic) of the statement ZK(x ; h = g^x)
    /// Enbles only with feature zkp
    #[cfg(feature = "zkp")]
    pub fn challenge<T: PrimeCurveAffine + GroupEncoding<Repr = impl AsRef<[u8]>>>(
        state: &ChallengeState<T>,
    ) -> Scalar {
        // transform the state into a byte array
        let mut state_bytes = Vec::new();
        state_bytes.extend_from_slice(state.name.as_bytes());
        state_bytes.extend_from_slice(state.g.to_bytes().as_ref());

        for stmt in &state.statement {
            state_bytes.extend_from_slice(stmt.to_bytes().as_ref());
        }

        state_bytes.extend_from_slice(&state.hash);

        let digest = Sha256::digest(&state_bytes);

        bigint::U256::from_be_slice(&digest).into()
    }

    /// Schnorr proof (non-interactive using FS heuristic)
    #[cfg(feature = "zkp")]
    pub fn non_interact_prove(
        stms: &Vec<G2Affine>,
        secret_wit: &Vec<Secret<Scalar>>,
    ) -> Result<(Vec<Scalar>, Challenge)> {
        // match on the statement

        let w_list = (0..stms.len())
            .map(|_| Scalar::random(ThreadRng::default()))
            .collect::<Vec<Scalar>>();

        // wit_list = [w_list[i] * g for i in range(len(w_list))]
        let witness_list = w_list
            .iter()
            .map(G2Projective::mul_by_generator)
            .collect::<Vec<G2Projective>>();

        // sum all w_list items into announcement
        let announcement = witness_list
            .iter()
            .fold(G2Projective::IDENTITY, |acc, x| acc + x);

        let state = ChallengeState::new(stms.to_vec(), &announcement.to_bytes());

        // Generate challenge.
        // let c = Scalar::reduce(bigint::U384::from(Self::challenge(&state)));
        let c = self::challenge(&state);

        // r = [(w_list[i] - c * secret_wit[i]) % o for i in range(len(secret_wit))]
        let r = (0..secret_wit.len())
            .map(|i| {
                let a = w_list[i];
                let b = c * secret_wit[i].expose_secret();
                // let mut r = BigNum::frombytes(&(a - b).to_bytes());
                a - b
                // Scalar::reduce(r)
            })
            .collect::<Vec<Scalar>>();

        Ok((r, c))
    }

    /// Verify the statement ZK(x ; h = g^x)
    #[cfg(feature = "zkp")]
    pub fn non_interact_verify(stms: &[G2Affine], proof_list: &(Vec<Scalar>, Challenge)) -> bool {
        let (r, c) = proof_list;

        // W_list = [r[i] * g + c * stm[i] for i in range(len(r))]
        let w_list = (0..r.len())
            .map(|i| G2Projective::mul_by_generator(&r[i]) + c * stms[i])
            .collect::<Vec<G2Projective>>();
        // sum all w_list items into announcement
        let announcement = w_list.iter().fold(G2Projective::IDENTITY, |acc, x| acc + x);

        let state = ChallengeState::new(stms.to_vec(), &announcement.to_bytes());
        let hash = self::challenge(&state);
        hash == *c
    }
}

/// Schnorr (interactive) proof of the statement ZK(x ; h = g^x)
pub trait Schnorr {
    fn new() -> Self;

    /// Create a Schnorr challenge
    fn challenge<T: PrimeCurveAffine + GroupEncoding<Repr = impl AsRef<[u8]>> + Display>(
        state: &ChallengeState<T>,
    ) -> Scalar {
        let mut state_bytes = Vec::new();
        state_bytes.extend_from_slice(state.name.as_bytes());
        state_bytes.extend_from_slice(state.g.to_bytes().as_ref());

        for stmt in &state.statement {
            state_bytes.extend_from_slice(stmt.to_bytes().as_ref());
        }

        state_bytes.extend_from_slice(&state.hash);

        let digest = Sha256::digest(&state_bytes);

        Scalar::from(bigint::U256::from_be_slice(&digest))
    }

    /// Create a Schnorr response to our own challenge
    fn response(
        challenge: &Scalar,
        announce_randomness: &Scalar,
        stm: &G1Affine,
        secret_wit: &Secret<Scalar>,
    ) -> Scalar {
        assert!(G1Projective::mul_by_generator(secret_wit.expose_secret()).to_affine() == *stm);
        Scalar::from(*announce_randomness + Scalar::from(*challenge) * secret_wit.expose_secret())
    }
}

pub struct ZKPSchnorr {}

// use defaults
impl Schnorr for ZKPSchnorr {
    fn new() -> Self {
        Self {}
    }
}

#[cfg(feature = "zkp")]
impl ZKPSchnorr {
    /// Verify the statement ZK(x ; h = g^x)
    pub fn verify(
        challenge: &Challenge,
        announce_element: &G1Projective,
        stm: &G1Projective,
        response: &Scalar,
    ) -> bool {
        let left_side = G1Projective::mul_by_generator(response);
        let right_side = announce_element + challenge * stm;
        left_side == right_side
    }

    /// Create a Schnorr announcement
    pub fn announce() -> (G1Projective, Scalar) {
        let w_random = Scalar::random(ThreadRng::default());
        let w_element = G1Projective::mul_by_generator(&w_random);
        (w_element, w_random)
    }
}

/// Damgard Transform containing a [Pedersen] commitment
#[derive(Clone, PartialEq, Eq, Debug, Default)]
pub struct DamgardTransform {
    pub pedersen: Pedersen,
}

/// DamgardTransform Compressed
#[derive(Clone, PartialEq, Eq, Debug)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct DamgardTransformCompressed {
    pub pedersen: PedersenCompressed,
}

impl From<DamgardTransform> for DamgardTransformCompressed {
    fn from(damgard: DamgardTransform) -> Self {
        Self {
            pedersen: damgard.pedersen.into(),
        }
    }
}

impl TryFrom<DamgardTransformCompressed> for DamgardTransform {
    type Error = error::Error;

    fn try_from(damgard_compressed: DamgardTransformCompressed) -> Result<Self, Self::Error> {
        Ok(Self {
            pedersen: Pedersen::try_from(damgard_compressed.pedersen)?,
        })
    }
}

impl DamgardTransform {
    /// Create a Damgard Transform challenge announcement
    /// Takes an optional randomness (nonce) to use for the announcement
    pub fn announce(&self, nonce: &Nonce) -> (PedersenCommit, PedersenOpen) {
        let w_random = Scalar::random(ThreadRng::default());
        let w_element = G1Projective::mul_by_generator(&w_random).to_affine();
        let (pedersen_commit, mut pedersen_open) = self.pedersen.commit(nonce, w_random);
        pedersen_open.element(w_element);
        (pedersen_commit, pedersen_open)
    }

    /// Verify the given [NymProof] is valid
    ///
    /// # Example:
    ///
    /// assert!(DamgardTransform::verify(their_proof)
    pub fn verify(nym_proof: &NymProof, nonce: Option<&Nonce>) -> bool {
        if let Some(nonce) = nonce {
            if nym_proof.pedersen_open.open_randomness != *nonce {
                return false;
            }
        }
        let left_side = G1Projective::mul_by_generator(&nym_proof.response);
        let right_side = nym_proof.pedersen_open.announce_element.as_ref().unwrap()
            + nym_proof.challenge * nym_proof.public_key;
        let decommit = nym_proof
            .damgard
            .pedersen
            .decommit(&nym_proof.pedersen_open, &nym_proof.pedersen_commit.into());

        (left_side == right_side) && decommit
    }
}

/// Implementation of Schnorr trait for DamgardTransform that has the same functions as ZKP_Schnorr
impl Schnorr for DamgardTransform {
    fn new() -> Self {
        let pedersen = Pedersen::new();
        Self { pedersen }
    }
}

/// Pedersen commitment containing [G1Projective] public key of the random secret trapdoor `d`
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct Pedersen {
    pub h: G1Projective,
    // trapdoor: Scalar,
}

/// Pedersen Compressed
#[derive(Clone, Debug, Eq, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct PedersenCompressed {
    h: Vec<u8>,
}

impl PedersenCompressed {
    pub fn h(&self) -> Vec<u8> {
        self.h.clone()
    }
}

impl From<Vec<u8>> for PedersenCompressed {
    fn from(h: Vec<u8>) -> Self {
        Self { h }
    }
}

impl From<Pedersen> for PedersenCompressed {
    fn from(pedersen: Pedersen) -> Self {
        Self {
            h: pedersen.h.to_compressed().to_vec(),
        }
    }
}

impl TryFrom<PedersenCompressed> for Pedersen {
    type Error = error::Error;

    fn try_from(pedersen_compressed: PedersenCompressed) -> Result<Self, Self::Error> {
        try_decompress_g1(pedersen_compressed.h).map(|h| Pedersen { h: h.into() })
    }
}

pub type PedersenCommit = G1Affine;

/// Pedersen Open information: Randomness used to open the commitment, randomness used to announce the secret, and the announcement element
#[derive(Clone, Debug, Eq, PartialEq)]
pub struct PedersenOpen {
    /// Randomness used to open the commitment
    pub open_randomness: Nonce,
    /// Randomness used to announce the secret
    pub announce_randomness: Scalar,
    /// Announcement element
    pub announce_element: Option<G1Affine>,
}

/// Only serialize the compressed version of the PedersenOpen
#[derive(Clone, Debug, Eq, PartialEq)]
#[cfg_attr(feature = "serde", derive(serde::Serialize, serde::Deserialize))]
pub struct PedersenOpenCompressed {
    pub open_randomness: Vec<u8>,
    pub announce_randomness: Vec<u8>,
    pub announce_element: Option<Vec<u8>>,
}

/// From [PedersenOpen] to [PedersenOpenCompressed]
impl From<PedersenOpen> for PedersenOpenCompressed {
    fn from(pedersen_open: PedersenOpen) -> Self {
        let announce_element = pedersen_open
            .announce_element
            .map(|elem| elem.to_compressed().to_vec());
        Self {
            open_randomness: pedersen_open.open_randomness.into(),
            announce_randomness: pedersen_open.announce_randomness.into(),
            announce_element,
        }
    }
}

/// PedersenOpenCompressed: From<delanocreds::zkp::PedersenOpen>
impl From<&PedersenOpen> for PedersenOpenCompressed {
    fn from(pedersen_open: &PedersenOpen) -> Self {
        let announce_element = pedersen_open
            .announce_element
            .as_ref()
            .map(|elem| elem.to_compressed().to_vec());
        Self {
            open_randomness: pedersen_open.open_randomness.clone().into(),
            announce_randomness: pedersen_open.announce_randomness.into(),
            announce_element,
        }
    }
}

/// TryFrom [PedersenOpenCompressed] to [PedersenOpen]
impl std::convert::TryFrom<PedersenOpenCompressed> for PedersenOpen {
    type Error = error::Error;

    fn try_from(pedersen_open_compressed: PedersenOpenCompressed) -> Result<Self, Self::Error> {
        let announce_element = pedersen_open_compressed
            .announce_element
            .map(|elem| {
                let mut bytes = [0u8; G1Affine::COMPRESSED_BYTES];
                bytes.copy_from_slice(&elem);
                let maybe_g1 = G1Affine::from_compressed(&bytes);
                if maybe_g1.is_none().into() {
                    return Err(Self::Error::InvalidG1Point);
                }

                Ok(maybe_g1.expect("G1Affine is Some"))
            })
            .transpose()?;
        Ok(Self {
            open_randomness: Nonce(try_into_scalar(pedersen_open_compressed.open_randomness)?),
            announce_randomness: try_into_scalar(pedersen_open_compressed.announce_randomness)?,
            announce_element,
        })
    }
}

impl PedersenOpen {
    /// Sets the announce element for the PedersenOpen
    pub fn element(&mut self, elem: G1Affine) {
        self.announce_element = Some(elem);
    }
}
impl Default for Pedersen {
    fn default() -> Self {
        Self::new()
    }
}
impl Pedersen {
    pub fn new() -> Self {
        // h is the statement. d is the trapdoor. g is the generator. h = d*g
        let d = Secret::new(Scalar::random(ThreadRng::default())); // trapdoor
        let h = G1Projective::mul_by_generator(d.expose_secret());
        Pedersen { h: h.into() }
    }

    /// Create a Pedersen commit
    /// Takes an optional randomness (nonce) to use for the announcement which can be used by the
    /// verifier to prevent replay attacks
    ///
    /// The nonce can be compared against the Pedersen open randomness to verify that a replay
    /// attach isn't reusing a previously generated proof
    pub fn commit(&self, nonce: &Nonce, msg: Scalar) -> (PedersenCommit, PedersenOpen) {
        let r: Scalar = **nonce;
        let pedersen_commit = r * self.h + G1Projective::mul_by_generator(&msg);
        let pedersen_open = PedersenOpen {
            open_randomness: nonce.clone(),
            announce_randomness: msg,
            announce_element: None,
        };

        (pedersen_commit.into(), pedersen_open)
    }

    /// Decrypts/Decommits the message
    pub fn decommit(&self, pedersen_open: &PedersenOpen, pedersen_commit: &PedersenCommit) -> bool {
        let c2 = self.h * (*pedersen_open.open_randomness)
            + G1Projective::mul_by_generator(&pedersen_open.announce_randomness);
        &c2.to_affine() == pedersen_commit
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    #[cfg(feature = "zkp")]
    fn test_non_interact_prove() {
        let nonce: Nonce = Nonce::default();
        // 1. Setup
        // 2. Prove
        // 3. Verify
        let secret_x = Secret::new(Scalar::random(ThreadRng::default()));
        let public_h = G2Projective::mul_by_generator(secret_x.expose_secret());

        // create a vec of secrets for iter 0 to 5
        let secrets = (0..5)
            .map(|_| Secret::new(Scalar::random(ThreadRng::default())))
            .collect::<Vec<Secret<Scalar>>>();

        // create stm for len of secrets, sec[i * g_2]
        let stm = secrets
            .iter()
            .map(|s| G2Projective::mul_by_generator(s.expose_secret()).to_affine())
            .collect();

        let proof_list /* (r, c) */ = zkp_schnorr_fiat_shamir::non_interact_prove(&stm, &secrets).unwrap();
        // let proof = (r, c);
        let result = zkp_schnorr_fiat_shamir::non_interact_verify(&stm, &proof_list);
        assert!(result);

        // create a proof for statement
        let proof_single =
            zkp_schnorr_fiat_shamir::non_interact_prove(&vec![public_h.into()], &vec![secret_x])
                .unwrap();
        let result_single =
            zkp_schnorr_fiat_shamir::non_interact_verify(&[public_h.into()], &proof_single);
        assert!(result_single);
    }

    #[test]
    #[cfg(feature = "zkp")]
    fn test_interact_prove() {
        // Create a random statement for testing
        let secret_x = Secret::new(Scalar::random(ThreadRng::default()));
        let stm = G1Projective::mul_by_generator(secret_x.expose_secret()).to_affine();

        let announce = ZKPSchnorr::announce();

        let state = ChallengeState::new(vec![stm], &announce.0.to_bytes());

        let challenge = ZKPSchnorr::challenge(&state);

        // prover creates a respoonse (or proof)
        let response = ZKPSchnorr::response(&challenge, &announce.1, &stm, &secret_x);

        assert!(ZKPSchnorr::verify(
            &challenge,
            &announce.0,
            &stm.into(),
            &response
        ));
    }

    #[test]
    fn test_damgard_transform() {
        let nonce: Nonce = Nonce::default();
        let damgard = DamgardTransform::new();

        // create a statement. A statement is a secret and a commitment to that secret.
        // A commitment is a generator raised to the power of the secret.
        let secret = Secret::new(Scalar::random(ThreadRng::default())); // x
                                                                        // h
        let statement = G1Projective::mul_by_generator(secret.expose_secret()).to_affine();

        let (pedersen_commit, pedersen_open) = damgard.announce(&nonce);

        let state = ChallengeState::new(vec![statement], &pedersen_commit.to_bytes());

        let challenge = DamgardTransform::challenge(&state); // uses triat default

        let response = DamgardTransform::response(
            &challenge,
            &pedersen_open.announce_randomness,
            &statement,
            &secret,
        );

        let proof_nym = NymProof {
            challenge,
            pedersen_open,
            pedersen_commit,
            public_key: statement.into(),
            response,
            damgard,
        };

        assert!(DamgardTransform::verify(&proof_nym, Some(&nonce)));
    }

    #[test]
    fn test_roundtrip_nonce() {
        // test roundtrip Scalar to 32 bytes and back, first
        let b = [42u8; 32];
        let scalar = Scalar::from_be_bytes(&b).expect("bytes to be canonical");
        let bytes = scalar.to_be_bytes();
        let scalar2 = Scalar::from_be_bytes(&bytes).expect("bytes to be canonical");
        assert_eq!(scalar, scalar2);

        let nonce = Nonce::try_from(&b).expect("bytes to be canonical");
        let bytes: [u8; 32] = nonce.clone().try_into().expect("nonce to be 32 bytes");
        let nonce2 = Nonce::try_from(bytes).expect("bytes to be canonical");
        assert_eq!(nonce, nonce2);

        // test to/from Vec<u8>
        let nonce = Nonce::new(b);
        let bytes: Vec<u8> = nonce.clone().into();
        let nonce2 = Nonce(try_into_scalar(bytes).unwrap());
        assert_eq!(nonce, nonce2);
    }

    // test roundtrip From<DamgardTransform> for DamgardTransformCompressed and back
    #[test]
    fn test_roundtrip_damgard_transform() {
        let damgard = DamgardTransform::new();
        let damgard_compressed = DamgardTransformCompressed::from(damgard.clone());
        let damgard2 =
            DamgardTransform::try_from(damgard_compressed).expect("compressed to be canonical");
        assert_eq!(damgard, damgard2);
    }
}