1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
use std::{
convert::{TryFrom, TryInto},
mem,
ops::Range,
sync::Arc,
};
use crate::{Arg, Bool, DecodeError, FormatSliceElement, Table};
use byteorder::{ReadBytesExt, LE};
use defmt_parser::{get_max_bitfield_range, Fragment, Parameter, Type};
/// List of format strings; used when decoding a `FormatSlice` (`{:[?]}`) argument
#[derive(Debug)]
enum FormatList<'t> {
/// Build the list; used when decoding the first element
Build { formats: Vec<&'t str> },
/// Use the list; used when decoding the rest of elements
Use {
formats: Vec<&'t str>,
cursor: usize,
},
}
pub(crate) struct Decoder<'t, 'b> {
table: &'t Table,
pub bytes: &'b [u8],
format_list: Option<FormatList<'t>>,
// below an enum tags must be included
below_enum: bool,
pub bools_tbd: Vec<Arc<Bool>>,
}
const MAX_NUM_BOOL_FLAGS: usize = 8;
impl<'t, 'b> Decoder<'t, 'b> {
pub fn new(table: &'t Table, bytes: &'b [u8]) -> Self {
Self {
table,
bytes,
format_list: None,
bools_tbd: Vec::new(),
below_enum: false,
}
}
/// Reads a byte of packed bools and unpacks them into `args` at the given indices.
pub fn read_and_unpack_bools(&mut self) -> Result<(), DecodeError> {
let bool_flags = self.bytes.read_u8()?;
let mut flag_index = self.bools_tbd.len();
for bool in self.bools_tbd.iter() {
flag_index -= 1;
// read out the leftmost unread bit and turn it into a boolean
let flag_mask = 1 << flag_index;
let nth_flag = (bool_flags & flag_mask) != 0;
bool.set(nth_flag);
}
self.bools_tbd.clear();
Ok(())
}
/// Sort and deduplicate `params` so that they can be interpreted correctly during decoding
fn prepare_params(&self, params: &mut Vec<Parameter>) {
// deduplicate bitfields by merging them by index
merge_bitfields(params);
// sort & dedup to ensure that format string args can be addressed by index too
params.sort_by(|a, b| a.index.cmp(&b.index));
params.dedup_by(|a, b| a.index == b.index);
}
/// Gets a format string from
/// - the `FormatList`, if it's in `Use` mode, or
/// - from `bytes` and `table` if the `FormatList` is in `Build` mode or was not provided
fn get_format(&mut self) -> Result<&'t str, DecodeError> {
if let Some(FormatList::Use { formats, cursor }) = self.format_list.as_mut() {
if let Some(format) = formats.get(*cursor) {
*cursor += 1;
return Ok(format);
}
}
let index = read_leb128(&mut self.bytes)?;
let format = self
.table
.get_without_level(index as usize)
.map_err(|_| DecodeError::Malformed)?;
if let Some(FormatList::Build { formats }) = self.format_list.as_mut() {
if !self.below_enum {
formats.push(format)
}
}
Ok(format)
}
fn get_variant(&mut self, format: &'t str) -> Result<&'t str, DecodeError> {
assert!(format.contains('|'));
// NOTE nesting of enums, like "A|B(C|D)" is not possible; indirection is
// required: "A|B({:?})" where "{:?}" -> "C|D"
let num_variants = format.chars().filter(|c| *c == '|').count();
let discriminant: usize = if u8::try_from(num_variants).is_ok() {
self.bytes.read_u8()?.into()
} else if u16::try_from(num_variants).is_ok() {
self.bytes.read_u16::<LE>()?.into()
} else if u32::try_from(num_variants).is_ok() {
self.bytes
.read_u32::<LE>()?
.try_into()
.map_err(|_| DecodeError::Malformed)?
} else if u64::try_from(num_variants).is_ok() {
self.bytes
.read_u64::<LE>()?
.try_into()
.map_err(|_| DecodeError::Malformed)?
} else {
return Err(DecodeError::Malformed);
};
format
.split('|')
.nth(discriminant)
.ok_or(DecodeError::Malformed)
}
fn decode_format_slice(
&mut self,
num_elements: usize,
) -> Result<Vec<FormatSliceElement<'t>>, DecodeError> {
if num_elements == 0 {
return Ok(vec![]);
}
let format = self.get_format()?;
// let variant_format = if
let is_enum = format.contains('|');
let below_enum = self.below_enum;
if is_enum {
self.below_enum = true;
}
let mut elements = Vec::with_capacity(num_elements);
let mut formats = vec![];
let mut cursor = 0;
for i in 0..num_elements {
let is_first = i == 0;
let format = if is_enum {
self.get_variant(format)?
} else {
format
};
let args = if let Some(list) = &mut self.format_list {
match list {
FormatList::Use { .. } => self.decode_format(format)?,
FormatList::Build { formats } => {
if is_first {
cursor = formats.len();
self.decode_format(format)?
} else {
let formats = formats.clone();
let old = mem::replace(
&mut self.format_list,
Some(FormatList::Use { formats, cursor }),
);
let args = self.decode_format(format)?;
self.format_list = old;
args
}
}
}
} else if is_first {
let mut old =
mem::replace(&mut self.format_list, Some(FormatList::Build { formats }));
let args = self.decode_format(format)?;
mem::swap(&mut self.format_list, &mut old);
formats = match old {
Some(FormatList::Build { formats, .. }) => formats,
_ => unreachable!(),
};
args
} else {
let formats = formats.clone();
let old = mem::replace(
&mut self.format_list,
Some(FormatList::Use { formats, cursor: 0 }),
);
let args = self.decode_format(format)?;
self.format_list = old;
args
};
elements.push(FormatSliceElement { format, args });
}
if is_enum {
self.below_enum = below_enum;
}
Ok(elements)
}
/// Decodes arguments from the stream, according to `format`.
pub fn decode_format(&mut self, format: &str) -> Result<Vec<Arg<'t>>, DecodeError> {
let mut args = vec![]; // will contain the deserialized arguments on return
let mut params = defmt_parser::parse(format, defmt_parser::ParserMode::ForwardsCompatible)
.map_err(|_| DecodeError::Malformed)?
.iter()
.filter_map(|frag| match frag {
Fragment::Parameter(param) => Some(param.clone()),
Fragment::Literal(_) => None,
})
.collect::<Vec<_>>();
self.prepare_params(&mut params);
for param in ¶ms {
match ¶m.ty {
Type::I8 => args.push(Arg::Ixx(self.bytes.read_i8()? as i128)),
Type::I16 => args.push(Arg::Ixx(self.bytes.read_i16::<LE>()? as i128)),
Type::I32 => args.push(Arg::Ixx(self.bytes.read_i32::<LE>()? as i128)),
Type::I64 => args.push(Arg::Ixx(self.bytes.read_i64::<LE>()? as i128)),
Type::I128 => args.push(Arg::Ixx(self.bytes.read_i128::<LE>()?)),
// Signed isize is encoded in zigzag-encoding.
Type::Isize => args.push(Arg::Ixx(
zigzag_decode(read_leb128(&mut self.bytes)?) as i128
)),
Type::U8 => args.push(Arg::Uxx(self.bytes.read_u8()? as u128)),
Type::U16 => args.push(Arg::Uxx(self.bytes.read_u16::<LE>()? as u128)),
Type::U24 => {
let data_low = self.bytes.read_u8()?;
let data_high = self.bytes.read_u16::<LE>()?;
let data = data_low as u128 | (data_high as u128) << 8;
args.push(Arg::Uxx(data as u128));
}
Type::U32 => args.push(Arg::Uxx(self.bytes.read_u32::<LE>()? as u128)),
Type::U64 => args.push(Arg::Uxx(self.bytes.read_u64::<LE>()? as u128)),
Type::U128 => args.push(Arg::Uxx(self.bytes.read_u128::<LE>()? as u128)),
Type::Usize => args.push(Arg::Uxx(read_leb128(&mut self.bytes)? as u128)),
Type::F32 => args.push(Arg::F32(f32::from_bits(self.bytes.read_u32::<LE>()?))),
Type::F64 => args.push(Arg::F64(f64::from_bits(self.bytes.read_u64::<LE>()?))),
Type::Bool => {
let arc = Arc::new(Bool::FALSE);
args.push(Arg::Bool(arc.clone()));
self.bools_tbd.push(arc.clone());
if self.bools_tbd.len() == MAX_NUM_BOOL_FLAGS {
// reached end of compression block: sprinkle values into args
self.read_and_unpack_bools()?;
}
}
Type::FormatSlice => {
let num_elements = read_leb128(&mut self.bytes)? as usize;
let elements = self.decode_format_slice(num_elements)?;
args.push(Arg::FormatSlice { elements });
}
Type::Format => {
let format = self.get_format()?;
if format.contains('|') {
// enum
let variant = self.get_variant(format)?;
let below_enum = self.below_enum;
self.below_enum = true;
let inner_args = self.decode_format(variant)?;
self.below_enum = below_enum;
args.push(Arg::Format {
format: variant,
args: inner_args,
});
} else {
let inner_args = self.decode_format(format)?;
args.push(Arg::Format {
format,
args: inner_args,
});
}
}
Type::BitField(range) => {
let mut data: u128;
let lowest_byte = range.start / 8;
let highest_byte = (range.end - 1) / 8; // -1, because `range` is range-exclusive
let size_after_truncation = highest_byte - lowest_byte + 1; // in octets
data = match size_after_truncation {
1 => self.bytes.read_u8()? as u128,
2 => self.bytes.read_u16::<LE>()? as u128,
3 => self.bytes.read_u24::<LE>()? as u128,
4 => self.bytes.read_u32::<LE>()? as u128,
5..=8 => self.bytes.read_u64::<LE>()? as u128,
9..=16 => self.bytes.read_u128::<LE>()? as u128,
_ => unreachable!(),
};
data <<= lowest_byte * 8;
args.push(Arg::Uxx(data));
}
Type::Str => {
let str_len = read_leb128(&mut self.bytes)? as usize;
let mut arg_str_bytes = vec![];
// note: went for the suboptimal but simple solution; optimize if necessary
for _ in 0..str_len {
arg_str_bytes.push(self.bytes.read_u8()?);
}
// convert to utf8 (no copy)
let arg_str =
String::from_utf8(arg_str_bytes).map_err(|_| DecodeError::Malformed)?;
args.push(Arg::Str(arg_str));
}
Type::IStr => {
let str_index = read_leb128(&mut self.bytes)? as usize;
let string = self
.table
.get_without_level(str_index as usize)
.map_err(|_| DecodeError::Malformed)?;
args.push(Arg::IStr(string));
}
Type::U8Slice => {
// only supports byte slices
let num_elements = read_leb128(&mut self.bytes)? as usize;
let mut arg_slice = vec![];
// note: went for the suboptimal but simple solution; optimize if necessary
for _ in 0..num_elements {
arg_slice.push(self.bytes.read_u8()?);
}
args.push(Arg::Slice(arg_slice.to_vec()));
}
Type::U8Array(len) => {
let mut arg_slice = vec![];
// note: went for the suboptimal but simple solution; optimize if necessary
for _ in 0..*len {
arg_slice.push(self.bytes.read_u8()?);
}
args.push(Arg::Slice(arg_slice.to_vec()));
}
Type::FormatArray(len) => {
let elements = self.decode_format_slice(*len)?;
args.push(Arg::FormatSlice { elements });
}
Type::Char => {
let data = self.bytes.read_u32::<LE>()?;
let c = std::char::from_u32(data).ok_or(DecodeError::Malformed)?;
args.push(Arg::Char(c));
}
Type::Debug | Type::Display => {
// UTF-8 stream without a prefix length, terminated with `0xFF`.
let end = self
.bytes
.iter()
.position(|b| *b == 0xff)
.ok_or(DecodeError::UnexpectedEof)?;
let data = core::str::from_utf8(&self.bytes[..end])
.map_err(|_| DecodeError::Malformed)?;
self.bytes = &self.bytes[end + 1..];
args.push(Arg::Preformatted(data.into()));
}
}
}
Ok(args)
}
}
/// Note that this will not change the Bitfield params in place, i.e. if `params` was sorted before
/// a call to this function, it won't be afterwards.
fn merge_bitfields(params: &mut Vec<Parameter>) {
if params.is_empty() {
return;
}
let mut merged_bitfields = Vec::new();
let max_index: usize = *params.iter().map(|param| ¶m.index).max().unwrap();
for index in 0..=max_index {
let mut bitfields_with_index = params
.iter()
.filter(
|param| matches!((param.index, ¶m.ty), (i, Type::BitField(_)) if i == index),
)
.peekable();
if bitfields_with_index.peek().is_some() {
let (smallest, largest) = get_max_bitfield_range(bitfields_with_index).unwrap();
// create new merged bitfield for this index
merged_bitfields.push(Parameter {
index,
ty: Type::BitField(Range {
start: smallest,
end: largest,
}),
hint: None, // don't care
});
// remove old bitfields with this index
// TODO refactor when `drain_filter()` is stable
let mut i = 0;
while i != params.len() {
match ¶ms[i].ty {
Type::BitField(_) => {
if params[i].index == index {
params.remove(i);
} else {
i += 1; // we haven't removed a bitfield -> move i forward
}
}
_ => {
i += 1; // we haven't removed a bitfield -> move i forward
}
}
}
}
}
// add merged bitfields to unsorted params
params.append(&mut merged_bitfields);
}
pub fn read_leb128(bytes: &mut &[u8]) -> Result<u64, DecodeError> {
match leb128::read::unsigned(bytes) {
Ok(val) => Ok(val),
Err(leb128::read::Error::Overflow) => Err(DecodeError::Malformed),
Err(leb128::read::Error::IoError(io)) => Err(io.into()),
}
}
fn zigzag_decode(unsigned: u64) -> i64 {
(unsigned >> 1) as i64 ^ -((unsigned & 1) as i64)
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn merge_bitfields_simple() {
let mut params = vec![
Parameter {
index: 0,
ty: Type::BitField(0..3),
hint: None,
},
Parameter {
index: 0,
ty: Type::BitField(4..7),
hint: None,
},
];
merge_bitfields(&mut params);
assert_eq!(
params,
vec![Parameter {
index: 0,
ty: Type::BitField(0..7),
hint: None,
}]
);
}
#[test]
fn merge_bitfields_overlap() {
let mut params = vec![
Parameter {
index: 0,
ty: Type::BitField(1..3),
hint: None,
},
Parameter {
index: 0,
ty: Type::BitField(2..5),
hint: None,
},
];
merge_bitfields(&mut params);
assert_eq!(
params,
vec![Parameter {
index: 0,
ty: Type::BitField(1..5),
hint: None,
}]
);
}
#[test]
fn merge_bitfields_multiple_indices() {
let mut params = vec![
Parameter {
index: 0,
ty: Type::BitField(0..3),
hint: None,
},
Parameter {
index: 1,
ty: Type::BitField(1..3),
hint: None,
},
Parameter {
index: 1,
ty: Type::BitField(4..5),
hint: None,
},
];
merge_bitfields(&mut params);
assert_eq!(
params,
vec![
Parameter {
index: 0,
ty: Type::BitField(0..3),
hint: None,
},
Parameter {
index: 1,
ty: Type::BitField(1..5),
hint: None,
}
]
);
}
#[test]
fn merge_bitfields_overlap_non_consecutive_indices() {
let mut params = vec![
Parameter {
index: 0,
ty: Type::BitField(0..3),
hint: None,
},
Parameter {
index: 1,
ty: Type::U8,
hint: None,
},
Parameter {
index: 2,
ty: Type::BitField(1..4),
hint: None,
},
Parameter {
index: 2,
ty: Type::BitField(4..5),
hint: None,
},
];
merge_bitfields(&mut params);
// note: current implementation appends merged bitfields to the end. this is not a must
assert_eq!(
params,
vec![
Parameter {
index: 1,
ty: Type::U8,
hint: None,
},
Parameter {
index: 0,
ty: Type::BitField(0..3),
hint: None,
},
Parameter {
index: 2,
ty: Type::BitField(1..5),
hint: None,
}
]
);
}
}