decy-oracle 2.1.0

CITL (Compiler-in-the-Loop) oracle for C-to-Rust transpilation pattern mining
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
//! Pattern retirement policy for oracle hygiene
//!
//! Prunes obsolete patterns that are rarely used or superseded.
//! Implements Kaizen principle - continuous improvement.
//!
//! # References
//! - training-oracle-spec.md §3.3.3: Pattern Retirement Policy (Kaizen Enhancement)
//! - Gemini Review: "define a Retirement Policy for patterns"

use serde::{Deserialize, Serialize};
use std::time::SystemTime;

/// Retirement decision for a pattern
#[derive(Debug, Clone, PartialEq)]
pub enum RetirementDecision {
    /// Keep the pattern active
    Keep,
    /// Retire the pattern with reason
    Retire(RetirementReason),
    /// Archive the pattern (keep for analysis, don't use for suggestions)
    Archive(RetirementReason),
}

impl RetirementDecision {
    /// Check if pattern should be removed from active use
    pub fn should_remove(&self) -> bool {
        matches!(
            self,
            RetirementDecision::Retire(_) | RetirementDecision::Archive(_)
        )
    }

    /// Get the reason if retiring
    pub fn reason(&self) -> Option<&RetirementReason> {
        match self {
            RetirementDecision::Retire(r) | RetirementDecision::Archive(r) => Some(r),
            RetirementDecision::Keep => None,
        }
    }
}

/// Reason for retiring a pattern
#[derive(Debug, Clone, PartialEq, Serialize, Deserialize)]
pub enum RetirementReason {
    /// Pattern rarely used (< threshold uses in evaluation window)
    LowUsage {
        uses: usize,
        threshold: usize,
        window_days: u32,
    },
    /// Pattern has high failure rate
    HighFailureRate { success_rate: f32, threshold: f32 },
    /// Pattern superseded by better alternative
    Superseded {
        better_pattern_id: String,
        improvement: f32,
    },
    /// Manually deprecated by maintainer
    ManualDeprecation { reason: String },
}

impl std::fmt::Display for RetirementReason {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            RetirementReason::LowUsage {
                uses,
                threshold,
                window_days,
            } => {
                write!(
                    f,
                    "Low usage: {} uses in {} days (threshold: {})",
                    uses, window_days, threshold
                )
            }
            RetirementReason::HighFailureRate {
                success_rate,
                threshold,
            } => {
                write!(
                    f,
                    "High failure rate: {:.1}% (threshold: {:.1}%)",
                    success_rate * 100.0,
                    threshold * 100.0
                )
            }
            RetirementReason::Superseded {
                better_pattern_id,
                improvement,
            } => {
                write!(
                    f,
                    "Superseded by {} (+{:.1}% success)",
                    better_pattern_id,
                    improvement * 100.0
                )
            }
            RetirementReason::ManualDeprecation { reason } => {
                write!(f, "Manually deprecated: {}", reason)
            }
        }
    }
}

/// Usage statistics for a pattern
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct PatternStats {
    /// Pattern identifier
    pub pattern_id: String,
    /// Error code this pattern addresses
    pub error_code: String,
    /// Total number of times pattern was used
    pub total_uses: usize,
    /// Uses within the evaluation window
    pub uses_in_window: usize,
    /// Successful applications
    pub successes: usize,
    /// Failed applications
    pub failures: usize,
    /// Timestamp of last use
    pub last_used: Option<SystemTime>,
    /// ID of a better pattern if one exists
    pub superseded_by: Option<String>,
}

impl PatternStats {
    /// Create new pattern stats
    pub fn new(pattern_id: impl Into<String>, error_code: impl Into<String>) -> Self {
        Self {
            pattern_id: pattern_id.into(),
            error_code: error_code.into(),
            total_uses: 0,
            uses_in_window: 0,
            successes: 0,
            failures: 0,
            last_used: None,
            superseded_by: None,
        }
    }

    /// Record a use of the pattern
    pub fn record_use(&mut self, success: bool) {
        self.total_uses += 1;
        self.uses_in_window += 1;
        self.last_used = Some(SystemTime::now());

        if success {
            self.successes += 1;
        } else {
            self.failures += 1;
        }
    }

    /// Get success rate
    pub fn success_rate(&self) -> f32 {
        let total = self.successes + self.failures;
        if total == 0 {
            0.0
        } else {
            self.successes as f32 / total as f32
        }
    }

    /// Reset window usage (called at window boundary)
    pub fn reset_window(&mut self) {
        self.uses_in_window = 0;
    }

    /// Mark as superseded by another pattern
    pub fn mark_superseded(&mut self, better_pattern_id: impl Into<String>) {
        self.superseded_by = Some(better_pattern_id.into());
    }
}

/// Configuration for pattern retirement policy
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct RetirementConfig {
    /// Minimum uses to keep pattern (default: 5)
    pub min_usage_threshold: usize,
    /// Minimum success rate to keep pattern (default: 0.3)
    pub min_success_rate: f32,
    /// Evaluation window in days (default: 30)
    pub evaluation_window_days: u32,
    /// Improvement threshold to consider pattern superseded (default: 0.1)
    pub supersede_improvement_threshold: f32,
    /// Whether to archive instead of delete
    pub archive_instead_of_delete: bool,
}

impl Default for RetirementConfig {
    fn default() -> Self {
        Self {
            min_usage_threshold: 5,
            min_success_rate: 0.3,
            evaluation_window_days: 30,
            supersede_improvement_threshold: 0.1,
            archive_instead_of_delete: true,
        }
    }
}

/// Pattern retirement policy
pub struct PatternRetirementPolicy {
    config: RetirementConfig,
}

impl PatternRetirementPolicy {
    /// Create new policy with default configuration
    pub fn new() -> Self {
        Self {
            config: RetirementConfig::default(),
        }
    }

    /// Create policy with custom configuration
    pub fn with_config(config: RetirementConfig) -> Self {
        Self { config }
    }

    /// Get configuration
    pub fn config(&self) -> &RetirementConfig {
        &self.config
    }

    /// Evaluate whether a pattern should be retired
    pub fn evaluate(&self, stats: &PatternStats) -> RetirementDecision {
        // Criterion 1: Low usage
        if stats.uses_in_window < self.config.min_usage_threshold {
            let reason = RetirementReason::LowUsage {
                uses: stats.uses_in_window,
                threshold: self.config.min_usage_threshold,
                window_days: self.config.evaluation_window_days,
            };
            return if self.config.archive_instead_of_delete {
                RetirementDecision::Archive(reason)
            } else {
                RetirementDecision::Retire(reason)
            };
        }

        // Criterion 2: High failure rate
        if stats.success_rate() < self.config.min_success_rate && stats.total_uses >= 5 {
            let reason = RetirementReason::HighFailureRate {
                success_rate: stats.success_rate(),
                threshold: self.config.min_success_rate,
            };
            return if self.config.archive_instead_of_delete {
                RetirementDecision::Archive(reason)
            } else {
                RetirementDecision::Retire(reason)
            };
        }

        // Criterion 3: Superseded by better pattern
        if let Some(ref better_id) = stats.superseded_by {
            let reason = RetirementReason::Superseded {
                better_pattern_id: better_id.clone(),
                improvement: self.config.supersede_improvement_threshold,
            };
            return RetirementDecision::Archive(reason);
        }

        RetirementDecision::Keep
    }

    /// Evaluate multiple patterns and return retirement decisions
    pub fn evaluate_batch(&self, stats_list: &[PatternStats]) -> Vec<(String, RetirementDecision)> {
        stats_list
            .iter()
            .map(|stats| (stats.pattern_id.clone(), self.evaluate(stats)))
            .collect()
    }

    /// Find patterns that should be retired
    pub fn find_retireable<'a>(&self, stats_list: &'a [PatternStats]) -> Vec<&'a PatternStats> {
        stats_list
            .iter()
            .filter(|stats| self.evaluate(stats).should_remove())
            .collect()
    }
}

impl Default for PatternRetirementPolicy {
    fn default() -> Self {
        Self::new()
    }
}

/// Results of a retirement sweep
#[derive(Debug, Clone, Default, Serialize, Deserialize)]
pub struct RetirementSweepResult {
    /// Total patterns evaluated
    pub total_evaluated: usize,
    /// Patterns kept
    pub kept: usize,
    /// Patterns retired due to low usage
    pub retired_low_usage: usize,
    /// Patterns retired due to high failure rate
    pub retired_high_failure: usize,
    /// Patterns retired due to being superseded
    pub retired_superseded: usize,
    /// Patterns archived (instead of deleted)
    pub archived: usize,
    /// Pattern IDs that were retired
    pub retired_ids: Vec<String>,
}

impl RetirementSweepResult {
    /// Create new empty result
    pub fn new() -> Self {
        Self::default()
    }

    /// Record a decision
    pub fn record(&mut self, pattern_id: &str, decision: &RetirementDecision) {
        self.total_evaluated += 1;
        match decision {
            RetirementDecision::Keep => {
                self.kept += 1;
            }
            RetirementDecision::Retire(reason) | RetirementDecision::Archive(reason) => {
                self.retired_ids.push(pattern_id.to_string());
                if matches!(decision, RetirementDecision::Archive(_)) {
                    self.archived += 1;
                }
                match reason {
                    RetirementReason::LowUsage { .. } => self.retired_low_usage += 1,
                    RetirementReason::HighFailureRate { .. } => self.retired_high_failure += 1,
                    RetirementReason::Superseded { .. } => self.retired_superseded += 1,
                    RetirementReason::ManualDeprecation { .. } => {}
                }
            }
        }
    }

    /// Get total retired count
    pub fn total_retired(&self) -> usize {
        self.retired_low_usage + self.retired_high_failure + self.retired_superseded
    }

    /// Get retirement rate
    pub fn retirement_rate(&self) -> f32 {
        if self.total_evaluated == 0 {
            0.0
        } else {
            self.total_retired() as f32 / self.total_evaluated as f32
        }
    }
}

/// Run a retirement sweep on pattern statistics
pub fn run_retirement_sweep(
    stats_list: &[PatternStats],
    policy: &PatternRetirementPolicy,
) -> RetirementSweepResult {
    let mut result = RetirementSweepResult::new();

    for stats in stats_list {
        let decision = policy.evaluate(stats);
        result.record(&stats.pattern_id, &decision);
    }

    result
}

#[cfg(test)]
mod tests {
    use super::*;

    // ============================================================================
    // RetirementReason Tests
    // ============================================================================

    #[test]
    fn test_retirement_reason_display_low_usage() {
        let reason = RetirementReason::LowUsage {
            uses: 2,
            threshold: 5,
            window_days: 30,
        };
        let display = format!("{}", reason);
        assert!(display.contains("Low usage"));
        assert!(display.contains("2 uses"));
    }

    #[test]
    fn test_retirement_reason_display_high_failure() {
        let reason = RetirementReason::HighFailureRate {
            success_rate: 0.2,
            threshold: 0.3,
        };
        let display = format!("{}", reason);
        assert!(display.contains("High failure rate"));
        assert!(display.contains("20.0%"));
    }

    #[test]
    fn test_retirement_reason_display_superseded() {
        let reason = RetirementReason::Superseded {
            better_pattern_id: "pattern-123".into(),
            improvement: 0.15,
        };
        let display = format!("{}", reason);
        assert!(display.contains("Superseded"));
        assert!(display.contains("pattern-123"));
    }

    // ============================================================================
    // RetirementDecision Tests
    // ============================================================================

    #[test]
    fn test_retirement_decision_should_remove() {
        assert!(!RetirementDecision::Keep.should_remove());
        assert!(RetirementDecision::Retire(RetirementReason::LowUsage {
            uses: 0,
            threshold: 5,
            window_days: 30
        })
        .should_remove());
        assert!(RetirementDecision::Archive(RetirementReason::LowUsage {
            uses: 0,
            threshold: 5,
            window_days: 30
        })
        .should_remove());
    }

    #[test]
    fn test_retirement_decision_reason() {
        assert!(RetirementDecision::Keep.reason().is_none());

        let reason = RetirementReason::LowUsage {
            uses: 0,
            threshold: 5,
            window_days: 30,
        };
        let decision = RetirementDecision::Retire(reason.clone());
        assert!(decision.reason().is_some());
    }

    // ============================================================================
    // PatternStats Tests
    // ============================================================================

    #[test]
    fn test_pattern_stats_new() {
        let stats = PatternStats::new("pat-1", "E0382");
        assert_eq!(stats.pattern_id, "pat-1");
        assert_eq!(stats.error_code, "E0382");
        assert_eq!(stats.total_uses, 0);
        assert_eq!(stats.success_rate(), 0.0);
    }

    #[test]
    fn test_pattern_stats_record_use() {
        let mut stats = PatternStats::new("pat-1", "E0382");

        stats.record_use(true);
        stats.record_use(true);
        stats.record_use(false);

        assert_eq!(stats.total_uses, 3);
        assert_eq!(stats.successes, 2);
        assert_eq!(stats.failures, 1);
        assert!((stats.success_rate() - 0.666).abs() < 0.01);
    }

    #[test]
    fn test_pattern_stats_reset_window() {
        let mut stats = PatternStats::new("pat-1", "E0382");
        stats.record_use(true);
        stats.record_use(true);

        assert_eq!(stats.uses_in_window, 2);
        stats.reset_window();
        assert_eq!(stats.uses_in_window, 0);
        assert_eq!(stats.total_uses, 2); // Total unchanged
    }

    #[test]
    fn test_pattern_stats_mark_superseded() {
        let mut stats = PatternStats::new("pat-1", "E0382");
        assert!(stats.superseded_by.is_none());

        stats.mark_superseded("pat-2");
        assert_eq!(stats.superseded_by, Some("pat-2".into()));
    }

    // ============================================================================
    // RetirementConfig Tests
    // ============================================================================

    #[test]
    fn test_retirement_config_default() {
        let config = RetirementConfig::default();
        assert_eq!(config.min_usage_threshold, 5);
        assert!((config.min_success_rate - 0.3).abs() < f32::EPSILON);
        assert_eq!(config.evaluation_window_days, 30);
        assert!(config.archive_instead_of_delete);
    }

    // ============================================================================
    // PatternRetirementPolicy Tests
    // ============================================================================

    #[test]
    fn test_policy_keeps_active_pattern() {
        let policy = PatternRetirementPolicy::new();
        let mut stats = PatternStats::new("pat-1", "E0382");

        // Add enough uses with good success rate
        for _ in 0..10 {
            stats.record_use(true);
        }

        let decision = policy.evaluate(&stats);
        assert_eq!(decision, RetirementDecision::Keep);
    }

    #[test]
    fn test_policy_retires_low_usage() {
        let policy = PatternRetirementPolicy::new();
        let mut stats = PatternStats::new("pat-1", "E0382");

        // Only 2 uses (below threshold of 5)
        stats.record_use(true);
        stats.record_use(true);

        let decision = policy.evaluate(&stats);
        assert!(decision.should_remove());
        assert!(matches!(
            decision.reason(),
            Some(RetirementReason::LowUsage { .. })
        ));
    }

    #[test]
    fn test_policy_retires_high_failure() {
        let policy = PatternRetirementPolicy::new();
        let mut stats = PatternStats::new("pat-1", "E0382");

        // 10 uses, 20% success rate (below threshold of 30%)
        stats.record_use(true);
        stats.record_use(true);
        for _ in 0..8 {
            stats.record_use(false);
        }
        // Force uses_in_window to be above threshold
        stats.uses_in_window = 10;

        let decision = policy.evaluate(&stats);
        assert!(decision.should_remove());
        assert!(matches!(
            decision.reason(),
            Some(RetirementReason::HighFailureRate { .. })
        ));
    }

    #[test]
    fn test_policy_retires_superseded() {
        let policy = PatternRetirementPolicy::new();
        let mut stats = PatternStats::new("pat-1", "E0382");

        // Good stats but superseded
        for _ in 0..10 {
            stats.record_use(true);
        }
        stats.mark_superseded("pat-2");

        let decision = policy.evaluate(&stats);
        assert!(decision.should_remove());
        assert!(matches!(
            decision.reason(),
            Some(RetirementReason::Superseded { .. })
        ));
    }

    #[test]
    fn test_policy_evaluate_batch() {
        let policy = PatternRetirementPolicy::new();

        let mut stats1 = PatternStats::new("pat-1", "E0382");
        for _ in 0..10 {
            stats1.record_use(true);
        }

        let mut stats2 = PatternStats::new("pat-2", "E0382");
        stats2.record_use(true);

        let batch = vec![stats1, stats2];
        let decisions = policy.evaluate_batch(&batch);

        assert_eq!(decisions.len(), 2);
        assert_eq!(decisions[0].1, RetirementDecision::Keep);
        assert!(decisions[1].1.should_remove());
    }

    #[test]
    fn test_policy_find_retireable() {
        let policy = PatternRetirementPolicy::new();

        let mut stats1 = PatternStats::new("pat-1", "E0382");
        for _ in 0..10 {
            stats1.record_use(true);
        }

        let mut stats2 = PatternStats::new("pat-2", "E0382");
        stats2.record_use(true);

        let batch = vec![stats1, stats2];
        let retireable = policy.find_retireable(&batch);

        assert_eq!(retireable.len(), 1);
        assert_eq!(retireable[0].pattern_id, "pat-2");
    }

    // ============================================================================
    // RetirementSweepResult Tests
    // ============================================================================

    #[test]
    fn test_sweep_result_new() {
        let result = RetirementSweepResult::new();
        assert_eq!(result.total_evaluated, 0);
        assert_eq!(result.kept, 0);
    }

    #[test]
    fn test_sweep_result_record() {
        let mut result = RetirementSweepResult::new();

        result.record("pat-1", &RetirementDecision::Keep);
        result.record(
            "pat-2",
            &RetirementDecision::Retire(RetirementReason::LowUsage {
                uses: 0,
                threshold: 5,
                window_days: 30,
            }),
        );
        result.record(
            "pat-3",
            &RetirementDecision::Archive(RetirementReason::HighFailureRate {
                success_rate: 0.1,
                threshold: 0.3,
            }),
        );

        assert_eq!(result.total_evaluated, 3);
        assert_eq!(result.kept, 1);
        assert_eq!(result.retired_low_usage, 1);
        assert_eq!(result.retired_high_failure, 1);
        assert_eq!(result.archived, 1);
        assert_eq!(result.retired_ids.len(), 2);
    }

    #[test]
    fn test_sweep_result_total_retired() {
        let mut result = RetirementSweepResult::new();
        result.retired_low_usage = 3;
        result.retired_high_failure = 2;
        result.retired_superseded = 1;

        assert_eq!(result.total_retired(), 6);
    }

    #[test]
    fn test_sweep_result_retirement_rate() {
        let mut result = RetirementSweepResult::new();
        result.total_evaluated = 10;
        result.retired_low_usage = 2;
        result.retired_high_failure = 1;

        assert!((result.retirement_rate() - 0.3).abs() < 0.01);
    }

    // ============================================================================
    // run_retirement_sweep Tests
    // ============================================================================

    #[test]
    fn test_run_retirement_sweep() {
        let policy = PatternRetirementPolicy::new();

        let mut stats1 = PatternStats::new("pat-1", "E0382");
        for _ in 0..10 {
            stats1.record_use(true);
        }

        let mut stats2 = PatternStats::new("pat-2", "E0382");
        stats2.record_use(true);

        let mut stats3 = PatternStats::new("pat-3", "E0382");
        for _ in 0..10 {
            stats3.record_use(false);
        }
        stats3.uses_in_window = 10;

        let batch = vec![stats1, stats2, stats3];
        let result = run_retirement_sweep(&batch, &policy);

        assert_eq!(result.total_evaluated, 3);
        assert_eq!(result.kept, 1);
        assert_eq!(result.total_retired(), 2);
    }

    // ============================================================================
    // Spec Compliance Tests
    // ============================================================================

    #[test]
    fn test_spec_low_usage_threshold() {
        // Spec: Retire patterns with < 5 uses in 30 days
        let config = RetirementConfig::default();
        assert_eq!(config.min_usage_threshold, 5);
        assert_eq!(config.evaluation_window_days, 30);
    }

    #[test]
    fn test_spec_high_failure_threshold() {
        // Spec: Retire patterns with success_rate < 0.3
        let config = RetirementConfig::default();
        assert!((config.min_success_rate - 0.3).abs() < f32::EPSILON);
    }

    #[test]
    fn test_spec_superseded_archived() {
        // Spec: Superseded patterns should be archived (not deleted)
        let policy = PatternRetirementPolicy::new();
        let mut stats = PatternStats::new("pat-1", "E0382");

        for _ in 0..10 {
            stats.record_use(true);
        }
        stats.mark_superseded("pat-2");

        let decision = policy.evaluate(&stats);
        assert!(matches!(decision, RetirementDecision::Archive(_)));
    }

    // ============================================================================
    // COVERAGE: ManualDeprecation Display, with_config, config(), Retire branches
    // ============================================================================

    #[test]
    fn test_manual_deprecation_display() {
        let reason = RetirementReason::ManualDeprecation {
            reason: "API changed".to_string(),
        };
        let display = format!("{}", reason);
        assert!(
            display.contains("Manually deprecated"),
            "Got: {}",
            display
        );
        assert!(display.contains("API changed"), "Got: {}", display);
    }

    #[test]
    fn test_policy_with_config() {
        let config = RetirementConfig {
            min_usage_threshold: 10,
            min_success_rate: 0.5,
            evaluation_window_days: 60,
            supersede_improvement_threshold: 0.2,
            archive_instead_of_delete: false,
        };
        let policy = PatternRetirementPolicy::with_config(config);
        assert_eq!(policy.config().min_usage_threshold, 10);
        assert_eq!(policy.config().evaluation_window_days, 60);
        assert!(!policy.config().archive_instead_of_delete);
    }

    #[test]
    fn test_policy_config_accessor() {
        let policy = PatternRetirementPolicy::new();
        let config = policy.config();
        assert_eq!(config.min_usage_threshold, 5);
        assert!((config.min_success_rate - 0.3).abs() < 0.01);
        assert!(config.archive_instead_of_delete);
    }

    #[test]
    fn test_policy_default_impl() {
        let policy = PatternRetirementPolicy::default();
        assert_eq!(policy.config().min_usage_threshold, 5);
    }

    #[test]
    fn test_evaluate_low_usage_retire_not_archive() {
        let config = RetirementConfig {
            archive_instead_of_delete: false,
            ..Default::default()
        };
        let policy = PatternRetirementPolicy::with_config(config);
        let stats = PatternStats::new("pat-1", "E0382");
        // 0 uses in window < threshold 5 → Retire (not Archive)
        let decision = policy.evaluate(&stats);
        assert!(
            matches!(decision, RetirementDecision::Retire(RetirementReason::LowUsage { .. })),
            "Expected Retire(LowUsage), got: {:?}",
            decision
        );
    }

    #[test]
    fn test_evaluate_high_failure_retire_not_archive() {
        let config = RetirementConfig {
            archive_instead_of_delete: false,
            ..Default::default()
        };
        let policy = PatternRetirementPolicy::with_config(config);
        let mut stats = PatternStats::new("pat-1", "E0382");
        // Need >= 5 total uses and success_rate < 0.3
        for _ in 0..5 {
            stats.record_use(true);
        }
        stats.uses_in_window = 10; // above threshold
        stats.successes = 1;
        stats.failures = 9;
        stats.total_uses = 10;
        let decision = policy.evaluate(&stats);
        assert!(
            matches!(decision, RetirementDecision::Retire(RetirementReason::HighFailureRate { .. })),
            "Expected Retire(HighFailureRate), got: {:?}",
            decision
        );
    }

    #[test]
    fn test_sweep_result_manual_deprecation() {
        let mut result = RetirementSweepResult::default();
        let decision = RetirementDecision::Retire(RetirementReason::ManualDeprecation {
            reason: "Obsolete".to_string(),
        });
        result.record("pat-1", &decision);
        assert_eq!(result.total_evaluated, 1);
        assert_eq!(result.retired_ids.len(), 1);
        assert_eq!(result.retired_ids[0], "pat-1");
        // ManualDeprecation doesn't increment specific counters
        assert_eq!(result.retired_low_usage, 0);
        assert_eq!(result.retired_high_failure, 0);
        assert_eq!(result.retired_superseded, 0);
    }

    #[test]
    fn test_sweep_result_retirement_rate_zero() {
        let result = RetirementSweepResult::default();
        assert_eq!(result.retirement_rate(), 0.0);
    }

    #[test]
    fn test_sweep_result_record_superseded() {
        let mut result = RetirementSweepResult::default();
        let decision = RetirementDecision::Archive(RetirementReason::Superseded {
            better_pattern_id: "pat-new".to_string(),
            improvement: 0.15,
        });
        result.record("pat-old", &decision);
        assert_eq!(result.total_evaluated, 1);
        assert_eq!(result.retired_superseded, 1);
        assert_eq!(result.archived, 1);
        assert_eq!(result.retired_ids.len(), 1);
    }

    #[test]
    fn test_sweep_result_record_archive_low_usage() {
        let mut result = RetirementSweepResult::default();
        let decision = RetirementDecision::Archive(RetirementReason::LowUsage {
            uses: 1,
            threshold: 5,
            window_days: 30,
        });
        result.record("pat-stale", &decision);
        assert_eq!(result.retired_low_usage, 1);
        assert_eq!(result.archived, 1);
    }
}