declutter-diff 0.1.3

Review AI-generated diffs with comments, tests, imports, logging and formatting toggled in and out
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67

use declutter::classify::classify;
use declutter::lang::{Lang, parsable};
use declutter::review::{ChangeStatus, Detection, FileChange, FileReview};

#[test]
fn swift_the_grammar_cannot_parse_is_stood_in_for_without_moving_any_byte() {
    let cases = [
        (
            "outcome.setValue(.success(()))",
            "outcome.setValue(.success([]))",
        ),
        (
            "continuation.resume(returning: ())",
            "continuation.resume(returning: [])",
        ),
        ("self.value = value ?? ()", "self.value = value ?? []"),
        (
            "if await session.status != .idle {",
            "if       session.status != .idle {",
        ),
        (
            "} else if await !isBackground {",
            "} else if       !isBackground {",
        ),
        (
            "nonisolated(unsafe) var ref: Ref?",
            "nonisolated         var ref: Ref?",
        ),
        // Left alone: calls, declarations, function types, ordinary awaits.
        (
            "func reset() -> () { start() }",
            "func reset() -> () { start() }",
        ),
        ("let done: () -> Void = {}", "let done: () -> Void = {}"),
        ("let v = await load()", "let v = await load()"),
        ("verify(await fetch())", "verify(await fetch())"),
    ];
    for (src, expected) in cases {
        let text = parsable(Lang::Swift, src);
        assert_eq!(text, expected, "{src}");
        assert_eq!(text.len(), src.len());
    }
}

#[test]
fn files_using_those_constructs_parse_cleanly() {
    let src = "func run() async {\n    // Wait for the link.\n    if await session.isReady == false {\n        continuation.resume(returning: ())\n    }\n    outcome.setValue(.success(()))\n}\n";

    let classified = classify(Lang::Swift, src).expect("parses");
    assert_eq!(classified.error_line, None);
    assert_eq!(classified.comments.len(), 1);
}

#[test]
fn a_partial_parse_says_where_it_went_wrong() {
    let file = FileReview::new(FileChange {
        path: "Broken.swift".into(),
        old_path: None,
        status: ChangeStatus::Modified,
        old: Some("let a = 1\n".into()),
        new: Some("let a = 1\nlet b = 2\nfunc broken( {\n".into()),
        binary: false,
    });

    assert_eq!(file.detection, Detection::Partial(Lang::Swift, 3));
    assert_eq!(file.tag(), "Swift, partial parse near line 3");
}