debtmap 0.19.0

Code complexity and technical debt analyzer
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
//! Integration tests for batch file analysis using the traverse pattern.
//!
//! These tests verify the parallel analysis functionality and error accumulation
//! behavior across multiple files and scenarios.

use debtmap::analyzers::batch::{analyze_files_effect, validate_and_analyze_files, validate_files};
use debtmap::config::{BatchAnalysisConfig, DebtmapConfig, ParallelConfig};
use debtmap::effects::{run_effect, run_validation};
use std::fs;
use std::path::PathBuf;
use tempfile::TempDir;

/// Helper to create a temp directory with test files.
fn create_test_project(files: &[(&str, &str)]) -> (TempDir, Vec<PathBuf>) {
    let temp_dir = TempDir::new().expect("Failed to create temp directory");
    let mut paths = Vec::with_capacity(files.len());

    for (name, content) in files {
        let file_path = temp_dir.path().join(name);
        if let Some(parent) = file_path.parent() {
            fs::create_dir_all(parent).expect("Failed to create parent directory");
        }
        fs::write(&file_path, content).expect("Failed to write test file");
        paths.push(file_path);
    }

    (temp_dir, paths)
}

// ============================================================================
// Parallel Analysis Tests
// ============================================================================

#[test]
fn test_parallel_analysis_multiple_files() {
    let files: Vec<(&str, &str)> = vec![
        ("file_a.rs", "fn a() { let x = 1; }"),
        ("file_b.rs", "fn b() { let y = 2; }"),
        ("file_c.rs", "fn c() { let z = 3; }"),
        ("file_d.rs", "fn d() { let w = 4; }"),
        ("file_e.rs", "fn e() { let v = 5; }"),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig::default()),
        ..Default::default()
    };

    let effect = analyze_files_effect(paths.clone());
    let results = run_effect(effect, config).expect("Analysis should succeed");

    assert_eq!(results.len(), 5, "Should analyze all 5 files");
    for (result, path) in results.iter().zip(paths.iter()) {
        assert_eq!(result.path, *path);
    }
}

#[test]
fn test_parallel_analysis_with_timing() {
    let files: Vec<(&str, &str)> = vec![
        ("mod1.rs", "fn func1() { let a = 1 + 2; }"),
        ("mod2.rs", "fn func2() { let b = 3 + 4; }"),
        ("mod3.rs", "fn func3() { let c = 5 + 6; }"),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig::default().with_timing()),
        ..Default::default()
    };

    let effect = analyze_files_effect(paths);
    let results = run_effect(effect, config).expect("Analysis should succeed");

    // All results should have timing information
    for result in &results {
        assert!(
            result.analysis_time.is_some(),
            "Each result should have timing info"
        );
    }
}

#[test]
fn test_parallel_vs_sequential_produces_same_results() {
    let files: Vec<(&str, &str)> = vec![
        ("src/lib.rs", "pub fn add(a: i32, b: i32) -> i32 { a + b }"),
        (
            "src/util.rs",
            "pub fn multiply(a: i32, b: i32) -> i32 { a * b }",
        ),
        ("src/helper.rs", "pub fn negate(x: i32) -> i32 { -x }"),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    // Run with parallel processing
    let parallel_config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig {
            parallelism: ParallelConfig::default(),
            fail_fast: false,
            collect_timing: false,
        }),
        ..Default::default()
    };

    let parallel_results =
        run_effect(analyze_files_effect(paths.clone()), parallel_config).expect("Parallel failed");

    // Run with sequential processing
    let sequential_config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig {
            parallelism: ParallelConfig::sequential(),
            fail_fast: false,
            collect_timing: false,
        }),
        ..Default::default()
    };

    let sequential_results =
        run_effect(analyze_files_effect(paths), sequential_config).expect("Sequential failed");

    // Results should be equivalent (order may differ)
    assert_eq!(
        parallel_results.len(),
        sequential_results.len(),
        "Same number of results"
    );

    // Sort by path for comparison
    let mut parallel_sorted: Vec<_> = parallel_results.iter().collect();
    let mut sequential_sorted: Vec<_> = sequential_results.iter().collect();
    parallel_sorted.sort_by_key(|r| &r.path);
    sequential_sorted.sort_by_key(|r| &r.path);

    for (p, s) in parallel_sorted.iter().zip(sequential_sorted.iter()) {
        assert_eq!(p.path, s.path, "Paths should match");
        assert_eq!(
            p.metrics.complexity.functions.len(),
            s.metrics.complexity.functions.len(),
            "Function count should match for {}",
            p.path.display()
        );
    }
}

#[test]
fn test_parallel_analysis_large_batch() {
    // Create 25 files to test batch processing
    let files: Vec<(String, String)> = (0..25)
        .map(|i| {
            let name = format!("file_{}.rs", i);
            let content = format!("fn func_{}() {{ let x = {}; }}", i, i * 10);
            (name, content)
        })
        .collect();

    let files_refs: Vec<(&str, &str)> = files
        .iter()
        .map(|(n, c)| (n.as_str(), c.as_str()))
        .collect();
    let (_temp_dir, paths) = create_test_project(&files_refs);

    let config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig {
            parallelism: ParallelConfig {
                enabled: true,
                max_concurrency: None,
                batch_size: Some(10), // Process in batches of 10
            },
            fail_fast: false,
            collect_timing: false,
        }),
        ..Default::default()
    };

    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");

    assert_eq!(results.len(), 25, "Should analyze all 25 files");
}

// ============================================================================
// Validation and Error Accumulation Tests
// ============================================================================

#[test]
fn test_validation_accumulates_all_errors() {
    let files: Vec<(&str, &str)> = vec![("valid.rs", "fn valid() {}")];
    let (temp_dir, _) = create_test_project(&files);

    // Mix valid and invalid paths
    let paths = vec![
        temp_dir.path().join("valid.rs"),
        PathBuf::from("/nonexistent/file_1.rs"),
        PathBuf::from("/nonexistent/file_2.rs"),
        PathBuf::from("/nonexistent/file_3.rs"),
    ];

    let result = validate_files(&paths);

    match result {
        stillwater::Validation::Failure(errors) => {
            let errors_vec: Vec<_> = errors.into_iter().collect();
            // Should have exactly 3 errors (for the 3 nonexistent files)
            assert_eq!(
                errors_vec.len(),
                3,
                "Should accumulate all 3 errors, not fail at first"
            );
        }
        stillwater::Validation::Success(_) => {
            panic!("Expected failure due to nonexistent files");
        }
    }
}

#[test]
fn test_validation_syntax_errors_accumulate() {
    let files: Vec<(&str, &str)> = vec![
        ("valid.rs", "fn valid() {}"),
        ("invalid1.rs", "fn broken( { }"), // Missing paren
        ("invalid2.rs", "struct { }"),     // Missing name
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let result = validate_files(&paths);

    match result {
        stillwater::Validation::Failure(errors) => {
            let errors_vec: Vec<_> = errors.into_iter().collect();
            // Should have 2 syntax errors
            assert_eq!(errors_vec.len(), 2, "Should accumulate both syntax errors");
        }
        stillwater::Validation::Success(_) => {
            panic!("Expected failure due to syntax errors");
        }
    }
}

#[test]
fn test_validate_and_analyze_success() {
    let files: Vec<(&str, &str)> = vec![
        ("module_a.rs", "pub fn a() -> i32 { 1 }"),
        ("module_b.rs", "pub fn b() -> i32 { 2 }"),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let result = run_validation(validate_and_analyze_files(&paths));

    assert!(result.is_ok(), "Should succeed for valid files");
    let results = result.unwrap();
    assert_eq!(results.len(), 2);
}

#[test]
fn test_validate_and_analyze_mixed() {
    let files: Vec<(&str, &str)> = vec![("valid.rs", "fn ok() {}")];
    let (temp_dir, _) = create_test_project(&files);

    let paths = vec![
        temp_dir.path().join("valid.rs"),
        PathBuf::from("/nonexistent/missing.rs"),
    ];

    let result = run_validation(validate_and_analyze_files(&paths));

    // Should fail because one file doesn't exist
    assert!(result.is_err(), "Should fail when any file is invalid");
}

// ============================================================================
// Complex File Analysis Tests
// ============================================================================

#[test]
fn test_analysis_detects_complexity() {
    let content = r#"
pub fn complex_function(data: &[i32], threshold: i32) -> Vec<i32> {
    let mut results = Vec::new();
    for &value in data {
        if value > threshold {
            if value % 2 == 0 {
                results.push(value * 2);
            } else {
                results.push(value * 3);
            }
        } else if value == threshold {
            results.push(value);
        } else {
            results.push(value / 2);
        }
    }
    results
}
"#;

    let files: Vec<(&str, &str)> = vec![("complex.rs", content)];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");

    assert_eq!(results.len(), 1);
    let result = &results[0];

    // Should detect the complex function
    assert!(
        !result.metrics.complexity.functions.is_empty(),
        "Should find functions"
    );

    // The complex_function should have notable complexity
    let complex_fn = result
        .metrics
        .complexity
        .functions
        .iter()
        .find(|f| f.name == "complex_function");

    assert!(complex_fn.is_some(), "Should find complex_function");
    let func = complex_fn.unwrap();

    // Should have measurable cyclomatic complexity (multiple branches)
    assert!(
        func.cyclomatic > 1,
        "Complex function should have cyclomatic > 1"
    );
}

#[test]
fn test_analysis_multiple_languages() {
    let files: Vec<(&str, &str)> = vec![
        ("lib.rs", "pub fn rust_fn() { let x = 1; }"),
        ("script.py", "def python_fn():\n    x = 1"),
        ("app.js", "function jsFn() { let x = 1; }"),
        (
            "main.go",
            "package main\n\nfunc goFn() { println(\"hello\") }",
        ),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");

    assert_eq!(results.len(), 4, "Should analyze all 4 files");

    // Each file should have at least one function detected
    for result in &results {
        // Note: Python and JS may have different detection capabilities
        // This test ensures they don't crash during analysis
        assert!(
            result.metrics.complexity.functions.is_empty()
                || !result.metrics.complexity.functions.is_empty(),
            "Should complete analysis without error"
        );
    }
}

#[test]
fn test_analysis_go_file() {
    let files = vec![(
        "service.go",
        r#"package service

import "context"

func Serve(ctx context.Context, ok bool) error {
    if ok {
        return nil
    }
    return nil
}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let metrics = &results[0].metrics;

    assert_eq!(metrics.language, debtmap::core::Language::Go);
    assert_eq!(metrics.dependencies[0].name, "context");
    assert_eq!(metrics.complexity.functions[0].name, "Serve");
    assert!(metrics.complexity.functions[0].cyclomatic > 1);
}

#[test]
fn test_go_same_package_cross_file_calls_resolve() {
    let files = vec![
        (
            "service/handler.go",
            r#"package service

func Serve() {
    helper()
}
"#,
        ),
        (
            "service/helper.go",
            r#"package service

func helper() {}
"#,
        ),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = results
        .iter()
        .flat_map(|result| result.metrics.complexity.functions.iter())
        .find(|function| function.name == "Serve")
        .unwrap();
    let helper = results
        .iter()
        .flat_map(|result| result.metrics.complexity.functions.iter())
        .find(|function| function.name == "helper")
        .unwrap();

    assert_eq!(serve.downstream_callees, Some(vec!["helper".to_string()]));
    assert_eq!(helper.upstream_callers, Some(vec!["Serve".to_string()]));
}

#[test]
fn test_go_external_calls_do_not_resolve_as_internal_edges() {
    let files = vec![(
        "service/handler.go",
        r#"package service

import "fmt"

func Serve() {
    fmt.Println("hello")
}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = &results[0].metrics.complexity.functions[0];

    assert_eq!(serve.call_dependencies, None);
    assert_eq!(serve.downstream_callees, None);
}

#[test]
fn test_go_test_package_does_not_resolve_to_internal_package() {
    let files = vec![
        (
            "service/handler.go",
            r#"package service

func helper() {}
"#,
        ),
        (
            "service/handler_test.go",
            r#"package service_test

func TestServe() {
    helper()
}
"#,
        ),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let test_fn = results
        .iter()
        .flat_map(|result| result.metrics.complexity.functions.iter())
        .find(|function| function.name == "TestServe")
        .unwrap();

    assert_eq!(test_fn.call_dependencies, None);
    assert_eq!(test_fn.downstream_callees, None);
}

#[test]
fn test_go_selector_calls_resolve_to_inferred_receiver_type() {
    let files = vec![(
        "service/handler.go",
        r#"package service

type Service struct{}
type Logger struct{}

func Serve() {
    svc := &Service{}
    svc.Handle()
}

func (s *Service) Handle() {}
func (l *Logger) Handle() {}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Serve")
        .unwrap();
    let service_handle = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Service.Handle")
        .unwrap();
    let logger_handle = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Logger.Handle")
        .unwrap();

    assert_eq!(
        serve.downstream_callees,
        Some(vec!["Service.Handle".to_string()])
    );
    assert_eq!(
        service_handle.upstream_callers,
        Some(vec!["Serve".to_string()])
    );
    assert_eq!(logger_handle.upstream_callers, None);
}

#[test]
fn test_go_direct_receiver_method_calls_resolve_to_same_type() {
    let files = vec![(
        "service/handler.go",
        r#"package service

type Handler struct{}
type Other struct{}

func (h *Handler) Serve() {
    h.validate()
}

func (h *Handler) validate() {}
func (o *Other) validate() {}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Handler.Serve")
        .unwrap();
    let other_validate = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Other.validate")
        .unwrap();

    assert_eq!(
        serve.downstream_callees,
        Some(vec!["Handler.validate".to_string()])
    );
    assert_eq!(other_validate.upstream_callers, None);
}

#[test]
fn test_go_constructor_assignment_resolves_receiver_method_call() {
    let files = vec![(
        "service/handler.go",
        r#"package service

type Service struct{}

func Serve() {
    svc := NewService()
    svc.Handle()
}

func NewService() *Service {
    return &Service{}
}

func (s *Service) Handle() {}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Serve")
        .unwrap();
    let service_handle = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Service.Handle")
        .unwrap();

    assert_eq!(
        serve.downstream_callees,
        Some(vec!["NewService".to_string(), "Service.Handle".to_string()])
    );
    assert_eq!(
        service_handle.upstream_callers,
        Some(vec!["Serve".to_string()])
    );
}

#[test]
fn test_go_unknown_selector_calls_do_not_resolve_by_method_name() {
    let files = vec![(
        "service/handler.go",
        r#"package service

type Service struct{}

func Serve(handler interface{ Handle() }) {
    handler.Handle()
}

func (s *Service) Handle() {}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let serve = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Serve")
        .unwrap();
    let service_handle = results[0]
        .metrics
        .complexity
        .functions
        .iter()
        .find(|function| function.name == "Service.Handle")
        .unwrap();

    assert_eq!(serve.downstream_callees, None);
    assert_eq!(service_handle.upstream_callers, None);
}

#[test]
fn test_go_module_import_calls_resolve_to_local_package() {
    let files = vec![
        (
            "cmd/app/main.go",
            r#"package main

import "example.com/app/internal/mathx"

func main() {
    mathx.Add()
}
"#,
        ),
        (
            "internal/mathx/math.go",
            r#"package mathx

func Add() {}
"#,
        ),
    ];
    let (temp_dir, paths) = create_test_project(&files);
    fs::write(temp_dir.path().join("go.mod"), "module example.com/app\n").unwrap();

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let main_fn = find_go_function(&results, "main.go", "main");
    let add_fn = find_go_function(&results, "math.go", "Add");

    assert_eq!(main_fn.downstream_callees, Some(vec!["Add".to_string()]));
    assert_eq!(add_fn.upstream_callers, Some(vec!["main".to_string()]));
}

#[test]
fn test_go_module_alias_import_calls_resolve() {
    let files = vec![
        (
            "cmd/app/main.go",
            r#"package main

import util "example.com/app/pkg/mathx"

func main() {
    util.Add()
}
"#,
        ),
        (
            "pkg/mathx/math.go",
            r#"package mathx

func Add() {}
"#,
        ),
    ];
    let (temp_dir, paths) = create_test_project(&files);
    fs::write(temp_dir.path().join("go.mod"), "module example.com/app\n").unwrap();

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let main_fn = find_go_function(&results, "main.go", "main");
    let add_fn = find_go_function(&results, "math.go", "Add");

    assert_eq!(main_fn.downstream_callees, Some(vec!["Add".to_string()]));
    assert_eq!(add_fn.upstream_callers, Some(vec!["main".to_string()]));
}

#[test]
fn test_go_external_module_imports_stay_unresolved() {
    let files = vec![(
        "cmd/app/main.go",
        r#"package main

import (
    "fmt"
    ext "github.com/acme/lib"
)

func main() {
    fmt.Println("hello")
    ext.Run()
}
"#,
    )];
    let (temp_dir, paths) = create_test_project(&files);
    fs::write(temp_dir.path().join("go.mod"), "module example.com/app\n").unwrap();

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let main_fn = find_go_function(&results, "main.go", "main");

    assert_eq!(main_fn.call_dependencies, None);
    assert_eq!(main_fn.downstream_callees, None);
}

#[test]
fn test_go_duplicate_package_names_resolve_by_import_path() {
    let files = vec![
        (
            "cmd/app/main.go",
            r#"package main

import auth "example.com/app/internal/auth"

func main() {
    auth.Run()
}
"#,
        ),
        (
            "internal/auth/auth.go",
            r#"package auth

func Run() {}
"#,
        ),
        (
            "pkg/auth/auth.go",
            r#"package auth

func Run() {}
"#,
        ),
    ];
    let (temp_dir, paths) = create_test_project(&files);
    fs::write(temp_dir.path().join("go.mod"), "module example.com/app\n").unwrap();

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let main_fn = find_go_function(&results, "main.go", "main");
    let internal_run = find_go_function(&results, "internal/auth/auth.go", "Run");
    let pkg_run = find_go_function(&results, "pkg/auth/auth.go", "Run");

    assert_eq!(main_fn.downstream_callees, Some(vec!["Run".to_string()]));
    assert_eq!(
        internal_run.upstream_callers,
        Some(vec!["main".to_string()])
    );
    assert_eq!(pkg_run.upstream_callers, None);
}

#[test]
fn test_go_dot_import_is_explicitly_ignored() {
    let files = vec![
        (
            "cmd/app/main.go",
            r#"package main

import . "example.com/app/internal/mathx"

func main() {
    Add()
}
"#,
        ),
        (
            "internal/mathx/math.go",
            r#"package mathx

func Add() {}
"#,
        ),
    ];
    let (temp_dir, paths) = create_test_project(&files);
    fs::write(temp_dir.path().join("go.mod"), "module example.com/app\n").unwrap();

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let main_fn = find_go_function(&results, "main.go", "main");
    let add_fn = find_go_function(&results, "math.go", "Add");

    assert_eq!(main_fn.downstream_callees, None);
    assert_eq!(add_fn.upstream_callers, None);
}

#[test]
fn test_go_generic_instantiated_calls_resolve() {
    let files = vec![(
        "collections.go",
        r#"package collections

func Run(xs []int) []string {
    return Map[int, string](xs, format)
}

func Map[T any, U any](items []T, f func(T) U) []U {
    return nil
}

func format(item int) string {
    return ""
}
"#,
    )];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results = run_effect(analyze_files_effect(paths), config).expect("Analysis should succeed");
    let run = find_go_function(&results, "collections.go", "Run");
    let map = find_go_function(&results, "collections.go", "Map");

    assert_eq!(run.downstream_callees, Some(vec!["Map".to_string()]));
    assert_eq!(map.upstream_callers, Some(vec!["Run".to_string()]));
}

fn find_go_function<'a>(
    results: &'a [debtmap::analyzers::batch::FileAnalysisResult],
    file_suffix: &str,
    name: &str,
) -> &'a debtmap::core::FunctionMetrics {
    results
        .iter()
        .flat_map(|result| result.metrics.complexity.functions.iter())
        .find(|function| function.file.ends_with(file_suffix) && function.name == name)
        .unwrap()
}

// ============================================================================
// Edge Cases
// ============================================================================

#[test]
fn test_empty_file_analysis() {
    let files: Vec<(&str, &str)> = vec![("empty.rs", "")];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results =
        run_effect(analyze_files_effect(paths), config).expect("Should handle empty file");

    assert_eq!(results.len(), 1);
    assert!(
        results[0].metrics.complexity.functions.is_empty(),
        "Empty file should have no functions"
    );
}

#[test]
fn test_single_file_analysis() {
    let files: Vec<(&str, &str)> = vec![("single.rs", "fn single() {}")];
    let (_temp_dir, paths) = create_test_project(&files);

    // Single file should work with parallel config (falls back to sequential)
    let config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig::default()),
        ..Default::default()
    };

    let results = run_effect(analyze_files_effect(paths), config).expect("Single file should work");
    assert_eq!(results.len(), 1);
}

#[test]
fn test_deeply_nested_directory_structure() {
    let files: Vec<(&str, &str)> = vec![
        ("src/mod1/submod/file.rs", "fn deep1() {}"),
        ("src/mod2/submod/deeper/file.rs", "fn deep2() {}"),
        ("lib/utils/helpers/file.rs", "fn deep3() {}"),
    ];
    let (_temp_dir, paths) = create_test_project(&files);

    let config = DebtmapConfig::default();
    let results =
        run_effect(analyze_files_effect(paths), config).expect("Should handle nested directories");

    assert_eq!(results.len(), 3);
}

// ============================================================================
// Performance Characteristics Tests
// ============================================================================

#[test]
fn test_parallel_analysis_maintains_all_results() {
    // Create files with different content to ensure independent analysis
    let files: Vec<(String, String)> = (0..10)
        .map(|i| {
            let name = format!("module_{}.rs", i);
            let content = format!(
                r#"
pub fn function_{}(x: i32) -> i32 {{
    if x > {} {{
        x * 2
    }} else {{
        x + 1
    }}
}}
"#,
                i, i
            );
            (name, content)
        })
        .collect();

    let files_refs: Vec<(&str, &str)> = files
        .iter()
        .map(|(n, c)| (n.as_str(), c.as_str()))
        .collect();
    let (_temp_dir, paths) = create_test_project(&files_refs);

    let config = DebtmapConfig {
        batch_analysis: Some(BatchAnalysisConfig::default()),
        ..Default::default()
    };

    let results = run_effect(analyze_files_effect(paths.clone()), config)
        .expect("Parallel analysis should succeed");

    // Verify all results are present
    assert_eq!(results.len(), 10);

    // Verify each file was analyzed (check paths are unique)
    let result_paths: std::collections::HashSet<_> =
        results.iter().map(|r| r.path.clone()).collect();
    assert_eq!(
        result_paths.len(),
        10,
        "All results should have unique paths"
    );

    // Verify paths match input
    for path in &paths {
        assert!(
            result_paths.contains(path),
            "Result should contain path: {}",
            path.display()
        );
    }
}