debtmap 0.16.6

Code complexity and technical debt analyzer
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
//! Effect type aliases and helpers for debtmap analysis.
//!
//! This module provides type aliases that integrate stillwater's effect system
//! with debtmap's environment and error types. Using these aliases:
//!
//! - Reduces boilerplate in function signatures
//! - Centralizes the environment and error types
//! - Makes it easy to refactor if types change
//!
//! # Effect vs Validation
//!
//! - **Effect**: Represents a computation that may perform I/O and may fail.
//!   Use for operations like reading files or loading coverage data.
//!
//! - **Validation**: Represents a validation check that accumulates ALL errors
//!   instead of failing at the first one. Use for configuration validation,
//!   input checking, and anywhere you want comprehensive error reporting.
//!
//! # Reader Pattern (Spec 199)
//!
//! This module also provides **Reader pattern** helpers using stillwater 0.15's
//! zero-cost `ask`, `asks`, and `local` primitives. The Reader pattern eliminates
//! config parameter threading by making configuration available through the
//! environment.
//!
//! # Stillwater 0.15 Features
//!
//! Stillwater 0.15 introduces additional effect types that can be used in debtmap:
//!
//! - **Writer Effect**: Accumulate logs/metrics alongside computation without
//!   threading state. Available via `stillwater::effect::writer::{WriterEffect, tell, tell_one}`.
//! - **Sink Effect**: Stream output with O(1) memory for large reports.
//!   Available via `stillwater::effect::sink::{emit, emit_many}`.
//! - **Bracket Builder**: Cleaner resource management syntax via
//!   `stillwater::effect::bracket::Bracket`.
//!
//! ## Reader Pattern Benefits
//!
//! **Before (parameter threading):**
//! ```rust,ignore
//! fn analyze(ast: &Ast, config: &Config) -> Metrics {
//!     calculate_complexity(ast, &config.thresholds)
//! }
//! ```
//!
//! **After (Reader pattern):**
//! ```rust,ignore
//! use debtmap::effects::asks_config;
//!
//! fn analyze_effect<Env>(ast: Ast) -> impl Effect<...>
//! where Env: AnalysisEnv + Clone + Send + Sync
//! {
//!     asks_config(move |config| calculate_complexity(&ast, &config.thresholds))
//! }
//! ```
//!
//! ## Available Reader Helpers
//!
//! - [`asks_config`]: Access the full config via closure
//! - [`asks_thresholds`]: Access thresholds config section
//! - [`asks_scoring`]: Access scoring weights config section
//! - [`asks_entropy`]: Access entropy config section
//! - [`local_with_config`]: Run effect with modified config (temporary override)
//!
//! # Example: Using Effects
//!
//! ```rust,ignore
//! use debtmap::effects::AnalysisEffect;
//! use debtmap::env::AnalysisEnv;
//! use stillwater::Effect;
//!
//! fn read_source(path: PathBuf) -> AnalysisEffect<String> {
//!     Effect::from_fn(move |env: &dyn AnalysisEnv| {
//!         env.file_system()
//!             .read_to_string(&path)
//!             .map_err(Into::into)
//!     })
//! }
//! ```
//!
//! # Example: Using Validation
//!
//! ```rust,ignore
//! use debtmap::effects::{AnalysisValidation, validation_success, validation_failure};
//!
//! fn validate_thresholds(complexity: u32, lines: usize) -> AnalysisValidation<()> {
//!     let v1 = if complexity <= 50 {
//!         validation_success(())
//!     } else {
//!         validation_failure(AnalysisError::validation("Complexity too high"))
//!     };
//!
//!     let v2 = if lines <= 1000 {
//!         validation_success(())
//!     } else {
//!         validation_failure(AnalysisError::validation("File too long"))
//!     };
//!
//!     // Combine validations - collects ALL errors
//!     v1.and(v2)
//! }
//! ```
//!
//! # Example: Using Reader Pattern
//!
//! ```rust,ignore
//! use debtmap::effects::{asks_config, asks_thresholds, local_with_config};
//! use debtmap::env::AnalysisEnv;
//! use stillwater::Effect;
//!
//! // Query config via closure
//! fn get_complexity_threshold<Env>() -> impl Effect<Output = Option<u32>, Error = AnalysisError, Env = Env>
//! where
//!     Env: AnalysisEnv + Clone + Send + Sync,
//! {
//!     asks_config(|config| config.thresholds.as_ref().and_then(|t| t.complexity))
//! }
//!
//! // Use temporary config override
//! fn analyze_strict<Env>(path: PathBuf) -> impl Effect<...>
//! where
//!     Env: AnalysisEnv + Clone + Send + Sync,
//! {
//!     local_with_config(
//!         |config| {
//!             let mut strict = config.clone();
//!             // Apply stricter thresholds
//!             strict
//!         },
//!         analyze_file_effect(path)
//!     )
//! }
//! ```

use crate::config::DebtmapConfig;
use crate::env::{AnalysisEnv, RealEnv};
use crate::errors::{errors_to_anyhow, AnalysisError};
use stillwater::effect::prelude::*;
use stillwater::{BoxedEffect, NonEmptyVec, Validation};

/// Error collection type for validation accumulation.
///
/// This type holds multiple errors during validation, enabling comprehensive
/// error reporting instead of failing at the first error.
pub type AnalysisErrors = NonEmptyVec<AnalysisError>;

/// Effect type for debtmap analysis operations.
///
/// This type alias parameterizes stillwater's Effect with:
/// - Success type `T` (the computation result)
/// - Error type `AnalysisError` (our unified error type)
/// - Environment type `RealEnv` (production I/O capabilities)
///
/// # Usage
///
/// ```rust,ignore
/// fn analyze_file(path: PathBuf) -> AnalysisEffect<FileMetrics> {
///     Effect::from_fn(move |env| {
///         let content = env.file_system().read_to_string(&path)?;
///         let metrics = compute_metrics(&content);
///         Ok(metrics)
///     })
/// }
/// ```
pub type AnalysisEffect<T> = BoxedEffect<T, AnalysisError, RealEnv>;

/// Validation type for debtmap validations.
///
/// This type alias uses stillwater's Validation with:
/// - Success type `T` (the validated value)
/// - Error type `NonEmptyVec<AnalysisError>` (accumulated errors)
///
/// Unlike Result, Validation accumulates ALL errors instead of short-circuiting
/// at the first failure. This is useful for:
/// - Configuration validation (report all issues at once)
/// - Input validation (show all problems to the user)
/// - Analysis validation (collect all findings)
///
/// # Usage
///
/// ```rust
/// use debtmap::effects::{AnalysisValidation, validation_success, validation_failure};
/// use debtmap::errors::AnalysisError;
///
/// fn validate_name(name: &str) -> AnalysisValidation<String> {
///     if name.is_empty() {
///         validation_failure(AnalysisError::validation("Name cannot be empty"))
///     } else {
///         validation_success(name.to_string())
///     }
/// }
/// ```
pub type AnalysisValidation<T> = Validation<T, AnalysisErrors>;

/// Create a successful validation result.
///
/// # Example
///
/// ```rust
/// use debtmap::effects::validation_success;
///
/// let v: debtmap::effects::AnalysisValidation<i32> = validation_success(42);
/// assert!(v.is_success());
/// ```
pub fn validation_success<T>(value: T) -> AnalysisValidation<T> {
    Validation::Success(value)
}

/// Create a failed validation result with a single error.
///
/// # Example
///
/// ```rust
/// use debtmap::effects::validation_failure;
/// use debtmap::errors::AnalysisError;
///
/// let v: debtmap::effects::AnalysisValidation<i32> =
///     validation_failure(AnalysisError::validation("Invalid input"));
/// assert!(v.is_failure());
/// ```
pub fn validation_failure<T>(error: AnalysisError) -> AnalysisValidation<T> {
    Validation::Failure(NonEmptyVec::new(error, Vec::new()))
}

/// Create a failed validation result with multiple errors.
///
/// # Panics
///
/// Panics if the errors vector is empty. Use `validation_failure` for
/// single errors or ensure the vector is non-empty.
///
/// # Example
///
/// ```rust
/// use debtmap::effects::validation_failures;
/// use debtmap::errors::AnalysisError;
///
/// let errors = vec![
///     AnalysisError::validation("Error 1"),
///     AnalysisError::validation("Error 2"),
/// ];
/// let v: debtmap::effects::AnalysisValidation<i32> = validation_failures(errors);
/// ```
pub fn validation_failures<T>(errors: Vec<AnalysisError>) -> AnalysisValidation<T> {
    let nev =
        NonEmptyVec::from_vec(errors).expect("validation_failures requires at least one error");
    Validation::Failure(nev)
}

/// Create an effect from a pure value (no I/O).
///
/// This is useful for wrapping pure computations in the effect system.
///
/// # Example
///
/// ```rust,ignore
/// let effect = effect_pure(42);
/// assert_eq!(effect.run(&env).unwrap(), 42);
/// ```
pub fn effect_pure<T: Send + 'static>(value: T) -> AnalysisEffect<T> {
    pure(value).boxed()
}

/// Create an effect from an error.
///
/// This is useful for creating failing effects without needing I/O.
///
/// # Example
///
/// ```rust,ignore
/// let effect: AnalysisEffect<i32> = effect_fail(AnalysisError::validation("bad input"));
/// assert!(effect.run(&env).is_err());
/// ```
pub fn effect_fail<T: Send + 'static>(error: AnalysisError) -> AnalysisEffect<T> {
    fail(error).boxed()
}

/// Create an effect from a synchronous function.
///
/// The function receives the environment and should return a Result.
///
/// # Example
///
/// ```rust,ignore
/// fn read_config() -> AnalysisEffect<Config> {
///     effect_from_fn(|env| {
///         let content = env.file_system().read_to_string(Path::new("config.toml"))?;
///         parse_config(&content).map_err(Into::into)
///     })
/// }
/// ```
pub fn effect_from_fn<T, F>(f: F) -> AnalysisEffect<T>
where
    T: Send + 'static,
    F: FnOnce(&RealEnv) -> Result<T, AnalysisError> + Send + 'static,
{
    from_fn(f).boxed()
}

/// Run an effect and convert the result to anyhow::Result for backwards compatibility.
///
/// This function bridges the new effect system with existing code that uses
/// anyhow::Result. Use this at the boundaries of your code where you need
/// to integrate with existing APIs.
///
/// Note: This uses tokio's block_on to run the async effect synchronously.
/// For better performance in async contexts, use `run_effect_async` instead.
///
/// # Example
///
/// ```rust,ignore
/// // Old code using anyhow
/// fn old_api() -> anyhow::Result<Metrics> {
///     let config = DebtmapConfig::default();
///     run_effect(analyze_effect(), config)
/// }
/// ```
pub fn run_effect<T: Send + 'static>(
    effect: AnalysisEffect<T>,
    config: DebtmapConfig,
) -> anyhow::Result<T> {
    let env = RealEnv::new(config);
    // Use tokio runtime to block on the async effect
    let rt = tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()
        .map_err(|e| anyhow::anyhow!("Failed to create tokio runtime: {}", e))?;
    rt.block_on(effect.run(&env)).map_err(Into::into)
}

/// Run an effect with a custom environment.
///
/// This is useful when you have an existing environment or need custom
/// I/O implementations.
///
/// Note: This uses tokio's block_on to run the async effect synchronously.
pub fn run_effect_with_env<T: Send + 'static, E: AnalysisEnv + Sync + 'static>(
    effect: BoxedEffect<T, AnalysisError, E>,
    env: &E,
) -> anyhow::Result<T> {
    let rt = tokio::runtime::Builder::new_current_thread()
        .enable_all()
        .build()
        .map_err(|e| anyhow::anyhow!("Failed to create tokio runtime: {}", e))?;
    rt.block_on(effect.run(env)).map_err(Into::into)
}

/// Run an effect asynchronously.
///
/// This is the preferred method when you're already in an async context.
pub async fn run_effect_async<T: Send + 'static>(
    effect: AnalysisEffect<T>,
    config: DebtmapConfig,
) -> anyhow::Result<T> {
    let env = RealEnv::new(config);
    effect.run(&env).await.map_err(Into::into)
}

/// Convert a Validation result to anyhow::Result for backwards compatibility.
///
/// If the validation failed with multiple errors, they are formatted as a list.
///
/// # Example
///
/// ```rust
/// use debtmap::effects::{run_validation, validation_success, validation_failure};
/// use debtmap::errors::AnalysisError;
///
/// let success = validation_success(42);
/// assert_eq!(run_validation(success).unwrap(), 42);
///
/// let failure: debtmap::effects::AnalysisValidation<i32> =
///     validation_failure(AnalysisError::validation("bad input"));
/// assert!(run_validation(failure).is_err());
/// ```
pub fn run_validation<T>(validation: AnalysisValidation<T>) -> anyhow::Result<T> {
    match validation {
        Validation::Success(value) => Ok(value),
        Validation::Failure(errors) => Err(errors_to_anyhow(errors.into_vec())),
    }
}

/// Combine multiple validations, accumulating all errors.
///
/// This is the core of error accumulation - if any validation fails,
/// all errors are collected. If all succeed, the results are collected.
///
/// # Example
///
/// ```rust
/// use debtmap::effects::{combine_validations, validation_success, validation_failure};
/// use debtmap::errors::AnalysisError;
///
/// let validations = vec![
///     validation_success(1),
///     validation_failure(AnalysisError::validation("error 1")),
///     validation_success(3),
///     validation_failure(AnalysisError::validation("error 2")),
/// ];
///
/// let result = combine_validations(validations);
/// // Result contains BOTH errors, not just the first one
/// ```
pub fn combine_validations<T>(validations: Vec<AnalysisValidation<T>>) -> AnalysisValidation<Vec<T>>
where
    T: Clone,
{
    let mut successes = Vec::new();
    let mut failures: Vec<AnalysisError> = Vec::new();

    for v in validations {
        match v {
            Validation::Success(value) => successes.push(value),
            Validation::Failure(errors) => {
                for err in errors {
                    failures.push(err);
                }
            }
        }
    }

    if failures.is_empty() {
        Validation::Success(successes)
    } else {
        Validation::Failure(NonEmptyVec::from_vec(failures).expect("failures cannot be empty here"))
    }
}

/// Map a function over a validation's success value.
///
/// If the validation is successful, applies the function.
/// If it failed, passes through the errors unchanged.
pub fn validation_map<T, U, F>(validation: AnalysisValidation<T>, f: F) -> AnalysisValidation<U>
where
    F: FnOnce(T) -> U,
{
    match validation {
        Validation::Success(value) => Validation::Success(f(value)),
        Validation::Failure(errors) => Validation::Failure(errors),
    }
}

// =============================================================================
// Reader Pattern Helpers (Spec 199)
// =============================================================================
//
// These helpers use stillwater 0.11.0's zero-cost Reader primitives to provide
// config access without parameter threading.

use crate::config::{EntropyConfig, ScoringWeights, ThresholdsConfig};
use stillwater::Effect;

use std::sync::Arc;

/// A wrapper type that makes a shared function callable via `Fn` traits.
///
/// This wrapper holds an `Arc<F>` and implements `Fn` by cloning the `Arc`
/// on each call, allowing the function to be called multiple times.
#[derive(Clone)]
pub struct SharedFn<F>(Arc<F>);

impl<F> SharedFn<F> {
    fn new(f: F) -> Self {
        Self(Arc::new(f))
    }
}

/// Query config through closure - the core Reader pattern primitive.
///
/// This function creates an effect that queries the environment's config
/// using a provided closure. The closure receives a reference to the
/// [`DebtmapConfig`] and returns any value.
///
/// Uses `Arc` internally to allow the closure to be called multiple times.
///
/// # Type Parameters
///
/// - `U`: The return type of the query
/// - `Env`: The environment type (must implement [`AnalysisEnv`])
/// - `F`: The query function type
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::asks_config;
///
/// // Get ignore patterns from config
/// fn get_ignore_patterns<Env>() -> impl Effect<Output = Vec<String>, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     asks_config(|config| config.get_ignore_patterns())
/// }
///
/// // Get complexity threshold
/// fn get_complexity_threshold<Env>() -> impl Effect<Output = Option<u32>, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     asks_config(|config| config.thresholds.as_ref().and_then(|t| t.complexity))
/// }
/// ```
pub fn asks_config<U, Env, F>(f: F) -> impl Effect<Output = U, Error = AnalysisError, Env = Env>
where
    U: Send + 'static,
    Env: AnalysisEnv + Clone + Send + Sync + 'static,
    F: Fn(&DebtmapConfig) -> U + Send + Sync + 'static,
{
    let shared = SharedFn::new(f);
    stillwater::asks(move |env: &Env| (shared.0)(env.config()))
}

/// Query thresholds config section.
///
/// Convenience helper for accessing the thresholds configuration.
/// Returns `None` if thresholds are not configured.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::asks_thresholds;
///
/// fn get_max_file_length<Env>() -> impl Effect<Output = Option<usize>, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     asks_thresholds(|thresholds| thresholds.and_then(|t| t.max_file_length))
/// }
/// ```
pub fn asks_thresholds<U, Env, F>(f: F) -> impl Effect<Output = U, Error = AnalysisError, Env = Env>
where
    U: Send + 'static,
    Env: AnalysisEnv + Clone + Send + Sync + 'static,
    F: Fn(Option<&ThresholdsConfig>) -> U + Send + Sync + 'static,
{
    let shared = SharedFn::new(f);
    stillwater::asks(move |env: &Env| (shared.0)(env.config().thresholds.as_ref()))
}

/// Query scoring weights config section.
///
/// Convenience helper for accessing the scoring weights configuration.
/// Returns `None` if scoring weights are not configured.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::asks_scoring;
///
/// fn get_coverage_weight<Env>() -> impl Effect<Output = f64, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     asks_scoring(|scoring| scoring.map(|s| s.coverage).unwrap_or(0.5))
/// }
/// ```
pub fn asks_scoring<U, Env, F>(f: F) -> impl Effect<Output = U, Error = AnalysisError, Env = Env>
where
    U: Send + 'static,
    Env: AnalysisEnv + Clone + Send + Sync + 'static,
    F: Fn(Option<&ScoringWeights>) -> U + Send + Sync + 'static,
{
    let shared = SharedFn::new(f);
    stillwater::asks(move |env: &Env| (shared.0)(env.config().scoring.as_ref()))
}

/// Query entropy config section.
///
/// Convenience helper for accessing the entropy configuration.
/// Returns `None` if entropy config is not set.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::asks_entropy;
///
/// fn is_entropy_enabled<Env>() -> impl Effect<Output = bool, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     asks_entropy(|entropy| entropy.map(|e| e.enabled).unwrap_or(true))
/// }
/// ```
pub fn asks_entropy<U, Env, F>(f: F) -> impl Effect<Output = U, Error = AnalysisError, Env = Env>
where
    U: Send + 'static,
    Env: AnalysisEnv + Clone + Send + Sync + 'static,
    F: Fn(Option<&EntropyConfig>) -> U + Send + Sync + 'static,
{
    let shared = SharedFn::new(f);
    stillwater::asks(move |env: &Env| (shared.0)(env.config().entropy.as_ref()))
}

/// Run an effect with a temporarily modified config.
///
/// This is the Reader pattern's `local` operation - it allows running an
/// inner effect with a modified environment. The modification is only
/// visible to the inner effect; after it completes, the original
/// environment is restored.
///
/// This is useful for:
/// - **Strict mode**: Running analysis with stricter thresholds
/// - **Custom thresholds**: Temporarily overriding specific settings
/// - **Feature flags**: Temporarily enabling/disabling features
///
/// # Type Parameters
///
/// - `Inner`: The inner effect type
/// - `F`: The environment transformation function
/// - `Env`: The environment type
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::local_with_config;
///
/// // Run analysis in strict mode (lower complexity threshold)
/// fn analyze_strict<Env>(
///     path: PathBuf,
/// ) -> impl Effect<Output = FileAnalysis, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     local_with_config(
///         |config| {
///             let mut strict = config.clone();
///             if let Some(ref mut thresholds) = strict.thresholds {
///                 // Reduce complexity threshold by half
///                 if let Some(complexity) = thresholds.complexity {
///                     thresholds.complexity = Some(complexity / 2);
///                 }
///             }
///             strict
///         },
///         analyze_file_effect(path)
///     )
/// }
///
/// // Temporarily disable entropy-based scoring
/// fn analyze_without_entropy<Env>(
///     inner: impl Effect<Output = T, Error = AnalysisError, Env = Env>
/// ) -> impl Effect<Output = T, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     local_with_config(
///         |config| {
///             let mut modified = config.clone();
///             if let Some(ref mut entropy) = modified.entropy {
///                 entropy.enabled = false;
///             }
///             modified
///         },
///         inner
///     )
/// }
/// ```
pub fn local_with_config<Inner, F, Env>(
    f: F,
    inner: Inner,
) -> impl Effect<Output = Inner::Output, Error = Inner::Error, Env = Env>
where
    Env: AnalysisEnv + Clone + Send + Sync + 'static,
    F: Fn(&DebtmapConfig) -> DebtmapConfig + Send + Sync + 'static,
    Inner: Effect<Env = Env>,
{
    let shared = SharedFn::new(f);
    stillwater::local(
        move |env: &Env| {
            let new_config = (shared.0)(env.config());
            env.clone().with_config(new_config)
        },
        inner,
    )
}

/// Query the entire environment.
///
/// This is a low-level helper that returns a clone of the entire environment.
/// Prefer using [`asks_config`] or the specific query helpers when you only
/// need config access.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::ask_env;
///
/// fn get_full_env<Env>() -> impl Effect<Output = Env, Error = AnalysisError, Env = Env>
/// where
///     Env: AnalysisEnv + Clone + Send + Sync,
/// {
///     ask_env()
/// }
/// ```
pub fn ask_env<Env>() -> stillwater::effect::reader::Ask<AnalysisError, Env>
where
    Env: Clone + Send + Sync + 'static,
{
    stillwater::ask::<AnalysisError, Env>()
}

// =============================================================================
// Retry Pattern Helpers (Spec 205)
// =============================================================================
//
// These helpers enable automatic retry of transient failures with configurable
// backoff strategies.

use crate::config::RetryConfig;
use log::{error, info, warn};
use std::time::Instant;

/// Wrap an effect with retry logic using the configured policy.
///
/// This combinator automatically retries the effect when it fails with
/// a retryable error, using the configured retry strategy and delays.
///
/// # Arguments
///
/// * `effect_factory` - A function that creates the effect to retry.
///   Called each time a retry is needed.
/// * `retry_config` - Configuration for retry behavior.
///
/// # Retryable Errors
///
/// Only errors where `error.is_retryable()` returns `true` will trigger
/// a retry. Non-retryable errors (parse errors, validation errors, etc.)
/// cause immediate failure.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::{with_retry, AnalysisEffect};
/// use debtmap::config::RetryConfig;
/// use debtmap::io::effects::read_file_effect;
///
/// fn read_file_resilient(path: PathBuf) -> AnalysisEffect<String> {
///     let config = RetryConfig::default();
///     with_retry(
///         move || read_file_effect(path.clone()),
///         config,
///     )
/// }
/// ```
///
/// # Logging
///
/// Retry attempts are logged at WARN level for visibility:
/// ```text
/// WARN Retrying operation (attempt 2/3): I/O error: Resource busy
/// ```
// debtmap:ignore[testing] - I/O orchestration function; pure logic (should_retry, delay_for_attempt, is_retryable) tested separately
pub fn with_retry<T, F>(effect_factory: F, retry_config: RetryConfig) -> AnalysisEffect<T>
where
    T: Send + 'static,
    F: Fn() -> AnalysisEffect<T> + Send + Sync + 'static,
{
    from_async(move |env: &RealEnv| {
        let env = env.clone();
        let config = retry_config.clone();
        let factory = SharedFn::new(effect_factory);

        async move {
            let start = Instant::now();
            let mut attempt = 0u32;
            let mut last_error: Option<AnalysisError> = None;

            loop {
                let effect = (factory.0)();
                match effect.run(&env).await {
                    Ok(value) => {
                        if attempt > 0 {
                            info!("Operation succeeded after {} retry attempt(s)", attempt);
                        }
                        return Ok(value);
                    }
                    Err(e) => {
                        let elapsed = start.elapsed();

                        // Check if error is retryable and we should try again
                        if e.is_retryable() && config.should_retry(attempt, elapsed) {
                            attempt += 1;
                            warn!(
                                "Retrying operation (attempt {}/{}): {}",
                                attempt, config.max_retries, e
                            );

                            // Sleep before retry
                            let delay = config.delay_for_attempt(attempt);
                            tokio::time::sleep(delay).await;

                            let _ = last_error.insert(e);
                        } else {
                            // Not retryable or exhausted retries
                            if attempt > 0 {
                                error!(
                                    "Operation failed after {} retry attempt(s): {}",
                                    attempt, e
                                );
                            }
                            return Err(e);
                        }
                    }
                }
            }
        }
    })
    .boxed()
}

/// Wrap an effect with retry logic, using the retry config from environment.
///
/// This is a convenience function that reads the retry configuration from
/// the environment's config. If no retry config is set, uses defaults.
///
/// # Example
///
/// ```rust,ignore
/// use debtmap::effects::with_retry_from_env;
/// use debtmap::io::effects::read_file_effect;
///
/// fn read_file_resilient(path: PathBuf) -> AnalysisEffect<String> {
///     with_retry_from_env(move || read_file_effect(path.clone()))
/// }
/// ```
pub fn with_retry_from_env<T, F>(effect_factory: F) -> AnalysisEffect<T>
where
    T: Send + 'static,
    F: Fn() -> AnalysisEffect<T> + Send + Sync + Clone + 'static,
{
    from_async(move |env: &RealEnv| {
        let env = env.clone();
        let factory = effect_factory.clone();

        async move {
            let config = env.config().retry.clone().unwrap_or_default();

            // If retries are disabled, just run the effect directly
            if !config.enabled {
                return factory().run(&env).await;
            }

            let start = Instant::now();
            let mut attempt = 0u32;

            loop {
                let effect = factory();
                match effect.run(&env).await {
                    Ok(value) => {
                        if attempt > 0 {
                            info!("Operation succeeded after {} retry attempt(s)", attempt);
                        }
                        return Ok(value);
                    }
                    Err(e) => {
                        let elapsed = start.elapsed();

                        if e.is_retryable() && config.should_retry(attempt, elapsed) {
                            attempt += 1;
                            warn!(
                                "Retrying operation (attempt {}/{}): {}",
                                attempt, config.max_retries, e
                            );

                            let delay = config.delay_for_attempt(attempt);
                            tokio::time::sleep(delay).await;
                        } else {
                            if attempt > 0 {
                                error!(
                                    "Operation failed after {} retry attempt(s): {}",
                                    attempt, e
                                );
                            }
                            return Err(e);
                        }
                    }
                }
            }
        }
    })
    .boxed()
}

/// Check if retries are enabled in the given config.
///
/// Returns `true` if the retry config is present and enabled.
pub fn is_retry_enabled(config: &DebtmapConfig) -> bool {
    config.retry.as_ref().map(|r| r.enabled).unwrap_or(true) // Default is enabled
}

/// Get the effective retry config from a DebtmapConfig.
///
/// Returns the configured retry settings or defaults if not set.
pub fn get_retry_config(config: &DebtmapConfig) -> RetryConfig {
    config.retry.clone().unwrap_or_default()
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_validation_success() {
        let v: AnalysisValidation<i32> = validation_success(42);
        assert!(v.is_success());
        match v {
            Validation::Success(n) => assert_eq!(n, 42),
            Validation::Failure(_) => panic!("Expected success"),
        }
    }

    #[test]
    fn test_validation_failure() {
        let v: AnalysisValidation<i32> =
            validation_failure(AnalysisError::validation("test error"));
        assert!(v.is_failure());
    }

    #[test]
    fn test_validation_failures() {
        let errors = vec![
            AnalysisError::validation("error 1"),
            AnalysisError::validation("error 2"),
        ];
        let v: AnalysisValidation<i32> = validation_failures(errors);
        assert!(v.is_failure());
        match v {
            Validation::Failure(nev) => {
                let vec: Vec<_> = nev.into_iter().collect();
                assert_eq!(vec.len(), 2);
            }
            _ => panic!("Expected failure"),
        }
    }

    #[test]
    fn test_run_validation_success() {
        let v = validation_success(42);
        let result = run_validation(v);
        assert_eq!(result.unwrap(), 42);
    }

    #[test]
    fn test_run_validation_failure() {
        let v: AnalysisValidation<i32> =
            validation_failure(AnalysisError::validation("test error"));
        let result = run_validation(v);
        assert!(result.is_err());
        assert!(result.unwrap_err().to_string().contains("test error"));
    }

    #[test]
    fn test_combine_validations_all_success() {
        let validations = vec![
            validation_success(1),
            validation_success(2),
            validation_success(3),
        ];
        let result = combine_validations(validations);
        match result {
            Validation::Success(values) => assert_eq!(values, vec![1, 2, 3]),
            _ => panic!("Expected success"),
        }
    }

    #[test]
    fn test_combine_validations_accumulates_errors() {
        let validations = vec![
            validation_success(1),
            validation_failure(AnalysisError::validation("error 1")),
            validation_success(3),
            validation_failure(AnalysisError::validation("error 2")),
        ];
        let result: AnalysisValidation<Vec<i32>> = combine_validations(validations);
        match result {
            Validation::Failure(errors) => {
                let vec: Vec<_> = errors.into_iter().collect();
                assert_eq!(vec.len(), 2);
            }
            _ => panic!("Expected failure with accumulated errors"),
        }
    }

    #[test]
    fn test_validation_map_success() {
        let v = validation_success(21);
        let v2 = validation_map(v, |n| n * 2);
        match v2 {
            Validation::Success(n) => assert_eq!(n, 42),
            _ => panic!("Expected success"),
        }
    }

    #[test]
    fn test_validation_map_failure() {
        let v: AnalysisValidation<i32> = validation_failure(AnalysisError::validation("error"));
        let v2: AnalysisValidation<i32> = validation_map(v, |n| n * 2);
        assert!(v2.is_failure());
    }

    #[test]
    fn test_effect_pure() {
        let effect = effect_pure(42);
        let result = run_effect(effect, DebtmapConfig::default());
        assert_eq!(result.unwrap(), 42);
    }

    #[test]
    fn test_effect_fail() {
        let effect: AnalysisEffect<i32> = effect_fail(AnalysisError::validation("test"));
        let result = run_effect(effect, DebtmapConfig::default());
        assert!(result.is_err());
    }

    #[test]
    fn test_run_effect() {
        let effect = effect_pure(42);
        let result = run_effect(effect, DebtmapConfig::default());
        assert_eq!(result.unwrap(), 42);
    }

    // =========================================================================
    // Reader Pattern Tests (Spec 199)
    // =========================================================================

    #[tokio::test]
    async fn test_asks_config_returns_config_value() {
        use crate::config::IgnoreConfig;

        let config = DebtmapConfig {
            ignore: Some(IgnoreConfig {
                patterns: vec!["test/**".to_string()],
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        // Create effect that queries config
        let effect = asks_config::<Vec<String>, RealEnv, _>(|config| config.get_ignore_patterns());

        let patterns = effect.run(&env).await.unwrap();
        assert_eq!(patterns, vec!["test/**".to_string()]);
    }

    #[tokio::test]
    async fn test_asks_config_with_default_config() {
        let env = RealEnv::default();

        // Query ignore patterns from default config
        let effect = asks_config::<Vec<String>, RealEnv, _>(|config| config.get_ignore_patterns());

        let patterns = effect.run(&env).await.unwrap();
        assert!(patterns.is_empty()); // Default config has no ignore patterns
    }

    #[tokio::test]
    async fn test_asks_thresholds_with_thresholds() {
        use crate::config::ThresholdsConfig;

        let config = DebtmapConfig {
            thresholds: Some(ThresholdsConfig {
                complexity: Some(15),
                max_file_length: Some(500),
                ..Default::default()
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        let effect = asks_thresholds::<Option<u32>, RealEnv, _>(|thresholds| {
            thresholds.and_then(|t| t.complexity)
        });

        let complexity = effect.run(&env).await.unwrap();
        assert_eq!(complexity, Some(15));
    }

    #[tokio::test]
    async fn test_asks_thresholds_without_thresholds() {
        let env = RealEnv::default();

        let effect = asks_thresholds::<Option<u32>, RealEnv, _>(|thresholds| {
            thresholds.and_then(|t| t.complexity)
        });

        let complexity = effect.run(&env).await.unwrap();
        assert_eq!(complexity, None);
    }

    #[tokio::test]
    async fn test_asks_scoring_with_weights() {
        let config = DebtmapConfig {
            scoring: Some(ScoringWeights {
                coverage: 0.6,
                complexity: 0.3,
                dependency: 0.1,
                ..Default::default()
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        let effect =
            asks_scoring::<f64, RealEnv, _>(|scoring| scoring.map(|s| s.coverage).unwrap_or(0.5));

        let coverage = effect.run(&env).await.unwrap();
        assert!((coverage - 0.6).abs() < 0.001);
    }

    #[tokio::test]
    async fn test_asks_entropy_enabled() {
        let config = DebtmapConfig {
            entropy: Some(EntropyConfig {
                enabled: false,
                ..Default::default()
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        let effect =
            asks_entropy::<bool, RealEnv, _>(|entropy| entropy.map(|e| e.enabled).unwrap_or(true));

        let enabled = effect.run(&env).await.unwrap();
        assert!(!enabled);
    }

    #[tokio::test]
    async fn test_local_with_config_modifies_config() {
        use crate::config::IgnoreConfig;

        let original_config = DebtmapConfig {
            ignore: Some(IgnoreConfig {
                patterns: vec!["original/**".to_string()],
            }),
            ..Default::default()
        };
        let env = RealEnv::new(original_config);

        // Inner effect that queries config
        let inner = asks_config::<Vec<String>, RealEnv, _>(|config| config.get_ignore_patterns());

        // Wrap with local that modifies config
        let effect = local_with_config(
            |_config| DebtmapConfig {
                ignore: Some(IgnoreConfig {
                    patterns: vec!["modified/**".to_string()],
                }),
                ..Default::default()
            },
            inner,
        );

        let patterns = effect.run(&env).await.unwrap();
        assert_eq!(patterns, vec!["modified/**".to_string()]);
    }

    #[tokio::test]
    async fn test_local_with_config_restores_after() {
        use crate::config::IgnoreConfig;

        let original_config = DebtmapConfig {
            ignore: Some(IgnoreConfig {
                patterns: vec!["original/**".to_string()],
            }),
            ..Default::default()
        };
        let env = RealEnv::new(original_config.clone());

        // Run with modified config
        let inner = asks_config::<Vec<String>, RealEnv, _>(|config| config.get_ignore_patterns());
        let modified_effect = local_with_config(
            |_| DebtmapConfig {
                ignore: Some(IgnoreConfig {
                    patterns: vec!["modified/**".to_string()],
                }),
                ..Default::default()
            },
            inner,
        );
        let _ = modified_effect.run(&env).await.unwrap();

        // Original env should be unchanged (run a new query)
        let check_effect =
            asks_config::<Vec<String>, RealEnv, _>(|config| config.get_ignore_patterns());
        let patterns = check_effect.run(&env).await.unwrap();
        assert_eq!(patterns, vec!["original/**".to_string()]);
    }

    #[tokio::test]
    async fn test_ask_env_returns_cloned_env() {
        let config = DebtmapConfig::default();
        let env = RealEnv::new(config);

        let effect = ask_env::<RealEnv>();

        let cloned_env = effect.run(&env).await.unwrap();
        // Both should have the same config
        assert_eq!(
            format!("{:?}", cloned_env.config()),
            format!("{:?}", env.config())
        );
    }

    #[tokio::test]
    async fn test_reader_pattern_composition() {
        use stillwater::EffectExt;

        let config = DebtmapConfig {
            scoring: Some(ScoringWeights {
                coverage: 0.6,
                complexity: 0.4,
                dependency: 0.0,
                ..Default::default()
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        // Compose multiple Reader queries
        let coverage_effect =
            asks_scoring::<f64, RealEnv, _>(|scoring| scoring.map(|s| s.coverage).unwrap_or(0.5));

        let complexity_effect = asks_scoring::<f64, RealEnv, _>(|scoring| {
            scoring.map(|s| s.complexity).unwrap_or(0.35)
        });

        // Use and_then to compose effects
        let combined =
            coverage_effect.and_then(move |cov| complexity_effect.map(move |comp| cov + comp));

        let sum = combined.run(&env).await.unwrap();
        assert!((sum - 1.0).abs() < 0.001); // 0.6 + 0.4 = 1.0
    }

    // =========================================================================
    // Retry Pattern Tests (Spec 205)
    // =========================================================================

    use std::sync::atomic::{AtomicUsize, Ordering};

    #[tokio::test]
    async fn test_with_retry_succeeds_first_attempt() {
        let config = RetryConfig::default();
        let env = RealEnv::default();

        let effect = with_retry(|| effect_pure(42), config);
        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), 42);
    }

    #[tokio::test]
    async fn test_with_retry_succeeds_after_transient_failure() {
        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 10, // Short delay for tests
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        // Counter to track attempts
        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect = with_retry(
            move || {
                let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
                if count < 2 {
                    // Fail with retryable error for first 2 attempts
                    effect_fail(AnalysisError::io("Resource busy"))
                } else {
                    // Succeed on third attempt
                    effect_pure("success".to_string())
                }
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success");
        // Should have made 3 attempts (indices 0, 1, 2)
        assert_eq!(attempt_count.load(Ordering::SeqCst), 3);
    }

    #[tokio::test]
    async fn test_with_retry_fails_on_permanent_error() {
        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 10,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect: AnalysisEffect<String> = with_retry(
            move || {
                attempt_clone.fetch_add(1, Ordering::SeqCst);
                // Parse errors are not retryable
                effect_fail(AnalysisError::parse("Syntax error"))
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_err());
        // Should have only made 1 attempt (immediate failure, no retry)
        assert_eq!(attempt_count.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_with_retry_exhausts_retries() {
        let config = RetryConfig {
            max_retries: 2,
            base_delay_ms: 10,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect: AnalysisEffect<String> = with_retry(
            move || {
                attempt_clone.fetch_add(1, Ordering::SeqCst);
                // Always fail with retryable error
                effect_fail(AnalysisError::io("Resource busy"))
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_err());
        // Initial attempt + 2 retries = 3 total attempts
        assert_eq!(attempt_count.load(Ordering::SeqCst), 3);
    }

    #[tokio::test]
    async fn test_with_retry_disabled() {
        let config = RetryConfig::disabled();
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect: AnalysisEffect<String> = with_retry(
            move || {
                attempt_clone.fetch_add(1, Ordering::SeqCst);
                effect_fail(AnalysisError::io("Resource busy"))
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_err());
        // With retries disabled, should only try once
        assert_eq!(attempt_count.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_with_retry_from_env_uses_config() {
        let config = DebtmapConfig {
            retry: Some(RetryConfig {
                enabled: true,
                max_retries: 2,
                base_delay_ms: 10,
                jitter_factor: 0.0,
                ..Default::default()
            }),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let factory = move || {
            let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
            if count < 1 {
                effect_fail(AnalysisError::io("Resource busy"))
            } else {
                effect_pure("success".to_string())
            }
        };

        let effect = with_retry_from_env(factory);
        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success");
        // Should have made 2 attempts
        assert_eq!(attempt_count.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn test_with_retry_from_env_disabled() {
        let config = DebtmapConfig {
            retry: Some(RetryConfig::disabled()),
            ..Default::default()
        };
        let env = RealEnv::new(config);

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let factory = move || {
            attempt_clone.fetch_add(1, Ordering::SeqCst);
            effect_fail::<String>(AnalysisError::io("Resource busy"))
        };

        let effect = with_retry_from_env(factory);
        let result = effect.run(&env).await;

        assert!(result.is_err());
        assert_eq!(attempt_count.load(Ordering::SeqCst), 1);
    }

    #[test]
    fn test_is_retry_enabled_default() {
        let config = DebtmapConfig::default();
        assert!(is_retry_enabled(&config));
    }

    #[test]
    fn test_is_retry_enabled_explicit_true() {
        let config = DebtmapConfig {
            retry: Some(RetryConfig {
                enabled: true,
                ..Default::default()
            }),
            ..Default::default()
        };
        assert!(is_retry_enabled(&config));
    }

    #[test]
    fn test_is_retry_enabled_explicit_false() {
        let config = DebtmapConfig {
            retry: Some(RetryConfig::disabled()),
            ..Default::default()
        };
        assert!(!is_retry_enabled(&config));
    }

    #[test]
    fn test_get_retry_config_default() {
        let config = DebtmapConfig::default();
        let retry_config = get_retry_config(&config);

        assert!(retry_config.enabled);
        assert_eq!(retry_config.max_retries, 3);
    }

    #[test]
    fn test_get_retry_config_custom() {
        let config = DebtmapConfig {
            retry: Some(RetryConfig {
                enabled: true,
                max_retries: 5,
                base_delay_ms: 200,
                ..Default::default()
            }),
            ..Default::default()
        };
        let retry_config = get_retry_config(&config);

        assert!(retry_config.enabled);
        assert_eq!(retry_config.max_retries, 5);
        assert_eq!(retry_config.base_delay_ms, 200);
    }

    #[tokio::test]
    async fn test_with_retry_stops_on_timeout() {
        // Configure with high max_retries but very short timeout
        // This exercises the timeout path in should_retry
        let config = RetryConfig {
            max_retries: 100,
            base_delay_ms: 50,
            timeout_seconds: 0,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect: AnalysisEffect<String> = with_retry(
            move || {
                attempt_clone.fetch_add(1, Ordering::SeqCst);
                effect_fail(AnalysisError::io("Resource busy"))
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_err());
        // With timeout of 0 seconds, should fail immediately after first attempt
        // since elapsed time will exceed the 0-second timeout
        assert_eq!(attempt_count.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_with_retry_with_constant_strategy() {
        use crate::config::retry::RetryStrategy;

        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 5,
            strategy: RetryStrategy::Constant,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect = with_retry(
            move || {
                let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
                if count < 2 {
                    effect_fail(AnalysisError::io("Resource busy"))
                } else {
                    effect_pure("success with constant strategy".to_string())
                }
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success with constant strategy");
        assert_eq!(attempt_count.load(Ordering::SeqCst), 3);
    }

    #[tokio::test]
    async fn test_with_retry_with_linear_strategy() {
        use crate::config::retry::RetryStrategy;

        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 5,
            strategy: RetryStrategy::Linear,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect = with_retry(
            move || {
                let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
                if count < 1 {
                    effect_fail(AnalysisError::io("Resource busy"))
                } else {
                    effect_pure("success with linear strategy".to_string())
                }
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success with linear strategy");
        assert_eq!(attempt_count.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn test_with_retry_with_fibonacci_strategy() {
        use crate::config::retry::RetryStrategy;

        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 5,
            strategy: RetryStrategy::Fibonacci,
            jitter_factor: 0.0,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect = with_retry(
            move || {
                let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
                if count < 1 {
                    effect_fail(AnalysisError::io("Resource busy"))
                } else {
                    effect_pure("success with fibonacci strategy".to_string())
                }
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success with fibonacci strategy");
        assert_eq!(attempt_count.load(Ordering::SeqCst), 2);
    }

    #[tokio::test]
    async fn test_with_retry_with_jitter() {
        let config = RetryConfig {
            max_retries: 3,
            base_delay_ms: 5,
            jitter_factor: 0.5,
            ..Default::default()
        };
        let env = RealEnv::default();

        let attempt_count = Arc::new(AtomicUsize::new(0));
        let attempt_clone = attempt_count.clone();

        let effect = with_retry(
            move || {
                let count = attempt_clone.fetch_add(1, Ordering::SeqCst);
                if count < 1 {
                    effect_fail(AnalysisError::io("Resource busy"))
                } else {
                    effect_pure("success with jitter".to_string())
                }
            },
            config,
        );

        let result = effect.run(&env).await;

        assert!(result.is_ok());
        assert_eq!(result.unwrap(), "success with jitter");
        assert_eq!(attempt_count.load(Ordering::SeqCst), 2);
    }
}