ddex-builder 0.4.5

Deterministic DDEX XML builder with smart normalization
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
use crate::presets::DdexVersion;
use crate::versions::ConversionOptions;
use indexmap::IndexMap;
use quick_xml::events::{BytesEnd, BytesStart, Event};
use quick_xml::{Reader, Writer};
use std::io::Cursor;

/// Result of version conversion operation
#[derive(Debug, Clone)]
pub enum ConversionResult {
    /// Successful conversion
    Success {
        /// Converted XML content
        xml: String,
        /// Conversion report with warnings
        report: ConversionReport,
    },
    /// Conversion failed
    Failure {
        /// Error description
        error: String,
        /// Partial conversion report
        report: ConversionReport,
    },
}

/// Report of conversion process between DDEX versions
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct ConversionReport {
    /// Source DDEX version
    pub from_version: DdexVersion,
    /// Target DDEX version
    pub to_version: DdexVersion,
    /// List of conversion warnings
    pub warnings: Vec<ConversionWarning>,
    /// Number of elements successfully converted
    pub elements_converted: usize,
    /// Number of elements dropped (not supported in target version)
    pub elements_dropped: usize,
    /// Number of elements added (required in target version)
    pub elements_added: usize,
}

/// Type of conversion warning
#[derive(Debug, Clone, Copy, serde::Serialize, serde::Deserialize)]
pub enum ConversionWarningType {
    /// Element was renamed in target version
    ElementRenamed,
    /// Element not supported in target version
    ElementDropped,
    /// Element added with default value
    ElementAdded,
    /// Validation rules changed between versions
    ValidationChanged,
    /// Namespace changes required
    NamespaceChanged,
    /// Format migration performed
    FormatMigrated,
}

/// Warning generated during conversion
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
pub struct ConversionWarning {
    /// Type of warning
    pub warning_type: ConversionWarningType,
    /// Warning description
    pub message: String,
    /// Element affected if applicable
    pub element: Option<String>,
}

/// Handles conversion between different DDEX versions
pub struct VersionConverter {
    conversion_rules: IndexMap<(DdexVersion, DdexVersion), ConversionRules>,
}

#[derive(Debug, Clone)]
struct ConversionRules {
    element_mappings: IndexMap<String, ElementMapping>,
    namespace_mapping: NamespaceMapping,
    _field_migrations: Vec<FieldMigration>,
    _validation_changes: Vec<ValidationChange>,
}

#[derive(Debug, Clone)]
#[allow(dead_code)]
enum ElementMapping {
    Direct(String),
    Renamed(String),
    /// These variants may be used in future versions
    Split {
        into: Vec<String>,
        splitter: fn(&str) -> Vec<String>,
    },
    /// These variants may be used in future versions
    Merge {
        from: Vec<String>,
        merger: fn(Vec<&str>) -> String,
    },
    Deprecated {
        replacement: Option<String>,
        warning: String,
    },
    New {
        default_value: Option<String>,
    },
}

#[derive(Debug, Clone)]
#[allow(dead_code)]
struct NamespaceMapping {
    from: String,
    to: String,
    schema_version_from: String,
    schema_version_to: String,
}

#[allow(dead_code)]
#[derive(Debug, Clone)]
struct FieldMigration {
    element: String,
    field: String,
    migration_type: MigrationType,
}

#[allow(dead_code)]
#[derive(Debug, Clone)]
enum MigrationType {
    FormatChange {
        from_pattern: String,
        to_pattern: String,
    },
    ValueMapping(IndexMap<String, String>),
    ValidationChange {
        old_rules: Vec<String>,
        new_rules: Vec<String>,
    },
}

#[allow(dead_code)]
#[derive(Debug, Clone)]
struct ValidationChange {
    element: String,
    change_type: ValidationChangeType,
}

#[allow(dead_code)]
#[derive(Debug, Clone)]
enum ValidationChangeType {
    RequiredAdded(String),
    RequiredRemoved(String),
    OptionalAdded(String),
    OptionalRemoved(String),
    FormatChanged {
        field: String,
        old_format: String,
        new_format: String,
    },
}

impl VersionConverter {
    /// Create a new version converter
    pub fn new() -> Self {
        let mut converter = Self {
            conversion_rules: IndexMap::new(),
        };
        converter.initialize_conversion_rules();
        converter
    }

    fn initialize_conversion_rules(&mut self) {
        self.add_382_to_42_rules();
        self.add_42_to_43_rules();
        self.add_43_to_42_rules();
        self.add_42_to_382_rules();
    }

    fn add_382_to_42_rules(&mut self) {
        let mut element_mappings = IndexMap::new();

        element_mappings.insert(
            "SoundRecording".to_string(),
            ElementMapping::Direct("SoundRecording".to_string()),
        );

        element_mappings.insert(
            "TechnicalSoundRecordingDetails".to_string(),
            ElementMapping::Renamed("TechnicalDetails".to_string()),
        );

        element_mappings.insert(
            "CommercialModelType".to_string(),
            ElementMapping::New {
                default_value: Some("SubscriptionModel".to_string()),
            },
        );

        element_mappings.insert(
            "Territory".to_string(),
            ElementMapping::Direct("Territory".to_string()),
        );

        let rules = ConversionRules {
            element_mappings,
            namespace_mapping: NamespaceMapping {
                from: "http://ddex.net/xml/ern/382".to_string(),
                to: "http://ddex.net/xml/ern/42".to_string(),
                schema_version_from: "ern/382".to_string(),
                schema_version_to: "ern/42".to_string(),
            },
            _field_migrations: vec![FieldMigration {
                element: "Duration".to_string(),
                field: "value".to_string(),
                migration_type: MigrationType::FormatChange {
                    from_pattern: r"^PT\d+S$".to_string(),
                    to_pattern: r"^PT(\d+H)?(\d+M)?\d+(\.\d+)?S$".to_string(),
                },
            }],
            _validation_changes: vec![
                ValidationChange {
                    element: "SoundRecording".to_string(),
                    change_type: ValidationChangeType::OptionalAdded("HashSum".to_string()),
                },
                ValidationChange {
                    element: "TechnicalDetails".to_string(),
                    change_type: ValidationChangeType::OptionalAdded("BitRate".to_string()),
                },
            ],
        };

        self.conversion_rules
            .insert((DdexVersion::Ern382, DdexVersion::Ern42), rules);
    }

    fn add_42_to_43_rules(&mut self) {
        let mut element_mappings = IndexMap::new();

        element_mappings.insert(
            "SoundRecording".to_string(),
            ElementMapping::Direct("SoundRecording".to_string()),
        );

        element_mappings.insert(
            "VideoResource".to_string(),
            ElementMapping::New {
                default_value: None,
            },
        );

        element_mappings.insert(
            "HashSum".to_string(),
            ElementMapping::Direct("HashSum".to_string()),
        );

        let rules = ConversionRules {
            element_mappings,
            namespace_mapping: NamespaceMapping {
                from: "http://ddex.net/xml/ern/42".to_string(),
                to: "http://ddex.net/xml/ern/43".to_string(),
                schema_version_from: "ern/42".to_string(),
                schema_version_to: "ern/43".to_string(),
            },
            _field_migrations: vec![FieldMigration {
                element: "ISRC".to_string(),
                field: "value".to_string(),
                migration_type: MigrationType::ValidationChange {
                    old_rules: vec![r"^[A-Z]{2}[A-Z0-9]{3}\d{7}$".to_string()],
                    new_rules: vec![r"^[A-Z]{2}-?[A-Z0-9]{3}-?\d{2}-?\d{5}$".to_string()],
                },
            }],
            _validation_changes: vec![
                ValidationChange {
                    element: "SoundRecording".to_string(),
                    change_type: ValidationChangeType::RequiredAdded("ProprietaryId".to_string()),
                },
                ValidationChange {
                    element: "VideoResource".to_string(),
                    change_type: ValidationChangeType::OptionalAdded("Duration".to_string()),
                },
            ],
        };

        self.conversion_rules
            .insert((DdexVersion::Ern42, DdexVersion::Ern43), rules);
    }

    fn add_43_to_42_rules(&mut self) {
        let mut element_mappings = IndexMap::new();

        element_mappings.insert(
            "SoundRecording".to_string(),
            ElementMapping::Direct("SoundRecording".to_string()),
        );

        element_mappings.insert(
            "VideoResource".to_string(),
            ElementMapping::Deprecated {
                replacement: None,
                warning: "VideoResource not supported in ERN 4.2, will be omitted".to_string(),
            },
        );

        element_mappings.insert(
            "HashSum".to_string(),
            ElementMapping::Direct("HashSum".to_string()),
        );

        let rules = ConversionRules {
            element_mappings,
            namespace_mapping: NamespaceMapping {
                from: "http://ddex.net/xml/ern/43".to_string(),
                to: "http://ddex.net/xml/ern/42".to_string(),
                schema_version_from: "ern/43".to_string(),
                schema_version_to: "ern/42".to_string(),
            },
            _field_migrations: vec![],
            _validation_changes: vec![ValidationChange {
                element: "SoundRecording".to_string(),
                change_type: ValidationChangeType::RequiredRemoved("ProprietaryId".to_string()),
            }],
        };

        self.conversion_rules
            .insert((DdexVersion::Ern43, DdexVersion::Ern42), rules);
    }

    fn add_42_to_382_rules(&mut self) {
        let mut element_mappings = IndexMap::new();

        element_mappings.insert(
            "SoundRecording".to_string(),
            ElementMapping::Direct("SoundRecording".to_string()),
        );

        element_mappings.insert(
            "TechnicalDetails".to_string(),
            ElementMapping::Renamed("TechnicalSoundRecordingDetails".to_string()),
        );

        element_mappings.insert(
            "CommercialModelType".to_string(),
            ElementMapping::Deprecated {
                replacement: None,
                warning: "CommercialModelType not supported in ERN 3.8.2, will be omitted"
                    .to_string(),
            },
        );

        let rules = ConversionRules {
            element_mappings,
            namespace_mapping: NamespaceMapping {
                from: "http://ddex.net/xml/ern/42".to_string(),
                to: "http://ddex.net/xml/ern/382".to_string(),
                schema_version_from: "ern/42".to_string(),
                schema_version_to: "ern/382".to_string(),
            },
            _field_migrations: vec![],
            _validation_changes: vec![ValidationChange {
                element: "SoundRecording".to_string(),
                change_type: ValidationChangeType::OptionalRemoved("HashSum".to_string()),
            }],
        };

        self.conversion_rules
            .insert((DdexVersion::Ern42, DdexVersion::Ern382), rules);
    }

    /// Convert DDEX content between versions
    ///
    /// # Arguments
    /// * `xml_content` - Source XML content
    /// * `from_version` - Source DDEX version
    /// * `to_version` - Target DDEX version
    /// * `options` - Optional conversion configuration
    pub fn convert(
        &self,
        xml_content: &str,
        from_version: DdexVersion,
        to_version: DdexVersion,
        options: Option<ConversionOptions>,
    ) -> ConversionResult {
        let options = options.unwrap_or_default();
        let mut report = ConversionReport {
            from_version,
            to_version,
            warnings: Vec::new(),
            elements_converted: 0,
            elements_dropped: 0,
            elements_added: 0,
        };

        if from_version == to_version {
            return ConversionResult::Success {
                xml: xml_content.to_string(),
                report,
            };
        }

        let conversion_path = self.find_conversion_path(from_version, to_version);
        match conversion_path {
            Some(path) => self.execute_conversion_path(xml_content, &path, options, &mut report),
            None => ConversionResult::Failure {
                error: format!(
                    "No conversion path found from {:?} to {:?}",
                    from_version, to_version
                ),
                report,
            },
        }
    }

    fn find_conversion_path(&self, from: DdexVersion, to: DdexVersion) -> Option<Vec<DdexVersion>> {
        if let Some(_) = self.conversion_rules.get(&(from, to)) {
            return Some(vec![from, to]);
        }

        // Check for multi-step conversions
        match (from, to) {
            (DdexVersion::Ern382, DdexVersion::Ern43) => Some(vec![
                DdexVersion::Ern382,
                DdexVersion::Ern42,
                DdexVersion::Ern43,
            ]),
            (DdexVersion::Ern43, DdexVersion::Ern382) => Some(vec![
                DdexVersion::Ern43,
                DdexVersion::Ern42,
                DdexVersion::Ern382,
            ]),
            _ => None,
        }
    }

    fn execute_conversion_path(
        &self,
        xml_content: &str,
        path: &[DdexVersion],
        options: ConversionOptions,
        report: &mut ConversionReport,
    ) -> ConversionResult {
        let mut current_xml = xml_content.to_string();

        for window in path.windows(2) {
            let from = window[0];
            let to = window[1];

            match self.convert_single_step(&current_xml, from, to, &options, report) {
                ConversionResult::Success {
                    xml,
                    report: step_report,
                } => {
                    current_xml = xml;
                    report.warnings.extend(step_report.warnings);
                    report.elements_converted += step_report.elements_converted;
                    report.elements_dropped += step_report.elements_dropped;
                    report.elements_added += step_report.elements_added;
                }
                ConversionResult::Failure { error, .. } => {
                    return ConversionResult::Failure {
                        error,
                        report: report.clone(),
                    };
                }
            }
        }

        ConversionResult::Success {
            xml: current_xml,
            report: report.clone(),
        }
    }

    fn convert_single_step(
        &self,
        xml_content: &str,
        from: DdexVersion,
        to: DdexVersion,
        options: &ConversionOptions,
        report: &mut ConversionReport,
    ) -> ConversionResult {
        let rules = match self.conversion_rules.get(&(from, to)) {
            Some(rules) => rules,
            None => {
                return ConversionResult::Failure {
                    error: format!("No direct conversion rules from {:?} to {:?}", from, to),
                    report: report.clone(),
                }
            }
        };

        match self.transform_xml(xml_content, rules, options) {
            Ok((transformed_xml, conversion_warnings)) => {
                report.warnings.extend(conversion_warnings);
                ConversionResult::Success {
                    xml: transformed_xml,
                    report: report.clone(),
                }
            }
            Err(error) => ConversionResult::Failure {
                error: error.to_string(),
                report: report.clone(),
            },
        }
    }

    fn transform_xml(
        &self,
        xml_content: &str,
        rules: &ConversionRules,
        options: &ConversionOptions,
    ) -> Result<(String, Vec<ConversionWarning>), Box<dyn std::error::Error>> {
        let mut reader = Reader::from_str(xml_content);
        let mut writer = Writer::new(Cursor::new(Vec::new()));
        let mut warnings = Vec::new();
        let mut buf = Vec::new();
        let mut elements_stack = Vec::new();
        let mut skip_element = false;
        let mut skip_depth = 0;

        loop {
            match reader.read_event_into(&mut buf) {
                Ok(Event::Start(ref e)) => {
                    let element_name = String::from_utf8_lossy(e.name().as_ref()).to_string();
                    elements_stack.push(element_name.clone());

                    if skip_element {
                        skip_depth += 1;
                        continue;
                    }

                    match rules.element_mappings.get(&element_name) {
                        Some(ElementMapping::Direct(new_name)) => {
                            let mut new_element = BytesStart::new(new_name);
                            for attr in e.attributes() {
                                if let Ok(attr) = attr {
                                    new_element.push_attribute(attr);
                                }
                            }
                            self.update_namespace_attributes(
                                &mut new_element,
                                &rules.namespace_mapping,
                            );
                            writer.write_event(Event::Start(new_element))?;
                        }
                        Some(ElementMapping::Renamed(new_name)) => {
                            let mut new_element = BytesStart::new(new_name);
                            for attr in e.attributes() {
                                if let Ok(attr) = attr {
                                    new_element.push_attribute(attr);
                                }
                            }
                            self.update_namespace_attributes(
                                &mut new_element,
                                &rules.namespace_mapping,
                            );
                            writer.write_event(Event::Start(new_element))?;
                            warnings.push(ConversionWarning {
                                warning_type: ConversionWarningType::ElementRenamed,
                                message: format!(
                                    "Element '{}' renamed to '{}'",
                                    element_name, new_name
                                ),
                                element: Some(element_name),
                            });
                        }
                        Some(ElementMapping::Deprecated {
                            replacement: _,
                            warning,
                        }) => {
                            skip_element = true;
                            skip_depth = 1;
                            warnings.push(ConversionWarning {
                                warning_type: ConversionWarningType::ElementDropped,
                                message: warning.clone(),
                                element: Some(element_name),
                            });
                        }
                        Some(ElementMapping::New { .. }) => {
                            writer.write_event(Event::Start(e.clone()))?;
                        }
                        _ => {
                            let mut cloned_element = e.clone();
                            self.update_namespace_attributes(
                                &mut cloned_element,
                                &rules.namespace_mapping,
                            );
                            writer.write_event(Event::Start(cloned_element))?;
                        }
                    }
                }
                Ok(Event::End(ref e)) => {
                    elements_stack.pop();

                    if skip_element {
                        skip_depth -= 1;
                        if skip_depth == 0 {
                            skip_element = false;
                        }
                        continue;
                    }

                    let element_name = String::from_utf8_lossy(e.name().as_ref()).to_string();
                    match rules.element_mappings.get(&element_name) {
                        Some(ElementMapping::Direct(new_name)) => {
                            writer.write_event(Event::End(BytesEnd::new(new_name)))?;
                        }
                        Some(ElementMapping::Renamed(new_name)) => {
                            writer.write_event(Event::End(BytesEnd::new(new_name)))?;
                        }
                        Some(ElementMapping::Deprecated { .. }) => {
                            // Skip deprecated elements
                        }
                        _ => {
                            writer.write_event(Event::End(e.clone()))?;
                        }
                    }
                }
                Ok(Event::Text(ref e)) => {
                    if !skip_element {
                        writer.write_event(Event::Text(e.clone()))?;
                    }
                }
                Ok(Event::Comment(ref e)) => {
                    if !skip_element && options.preserve_comments {
                        writer.write_event(Event::Comment(e.clone()))?;
                    }
                }
                Ok(Event::CData(ref e)) => {
                    if !skip_element {
                        writer.write_event(Event::CData(e.clone()))?;
                    }
                }
                Ok(Event::Decl(ref e)) => {
                    writer.write_event(Event::Decl(e.clone()))?;
                }
                Ok(Event::PI(ref e)) => {
                    if !skip_element {
                        writer.write_event(Event::PI(e.clone()))?;
                    }
                }
                Ok(Event::DocType(ref e)) => {
                    writer.write_event(Event::DocType(e.clone()))?;
                }
                Ok(Event::Empty(ref e)) => {
                    if !skip_element {
                        writer.write_event(Event::Empty(e.clone()))?;
                    }
                }
                Ok(Event::Eof) => break,
                Err(e) => return Err(format!("Error parsing XML: {}", e).into()),
            }
            buf.clear();
        }

        let result = writer.into_inner().into_inner();
        let transformed_xml = String::from_utf8(result)?;
        Ok((transformed_xml, warnings))
    }

    fn update_namespace_attributes(
        &self,
        element: &mut BytesStart,
        namespace_mapping: &NamespaceMapping,
    ) {
        // Update xmlns attributes to new namespace
        let mut attrs_to_update = Vec::new();

        for (i, attr_result) in element.attributes().enumerate() {
            if let Ok(attr) = attr_result {
                let key = String::from_utf8_lossy(attr.key.as_ref());
                let value = String::from_utf8_lossy(&attr.value);

                if key == "xmlns" && value == namespace_mapping.from {
                    attrs_to_update.push((i, "xmlns".to_string(), namespace_mapping.to.clone()));
                } else if key.starts_with("xmlns:") && value == namespace_mapping.from {
                    attrs_to_update.push((i, key.to_string(), namespace_mapping.to.clone()));
                }
            }
        }

        // Apply namespace updates
        for (_, key, new_value) in attrs_to_update {
            element.extend_attributes(std::iter::once((key.as_str(), new_value.as_str())));
        }
    }

    /// Get list of supported version conversions
    pub fn get_supported_conversions(&self) -> Vec<(DdexVersion, DdexVersion)> {
        self.conversion_rules.keys().cloned().collect()
    }

    /// Check if conversion between versions is supported
    pub fn can_convert(&self, from: DdexVersion, to: DdexVersion) -> bool {
        self.find_conversion_path(from, to).is_some()
    }
}

impl Default for VersionConverter {
    fn default() -> Self {
        Self::new()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_converter_initialization() {
        let converter = VersionConverter::new();
        assert!(!converter.conversion_rules.is_empty());
    }

    #[test]
    fn test_direct_conversion_path() {
        let converter = VersionConverter::new();
        let path = converter.find_conversion_path(DdexVersion::Ern382, DdexVersion::Ern42);
        assert_eq!(path, Some(vec![DdexVersion::Ern382, DdexVersion::Ern42]));
    }

    #[test]
    fn test_multi_step_conversion_path() {
        let converter = VersionConverter::new();
        let path = converter.find_conversion_path(DdexVersion::Ern382, DdexVersion::Ern43);
        assert_eq!(
            path,
            Some(vec![
                DdexVersion::Ern382,
                DdexVersion::Ern42,
                DdexVersion::Ern43
            ])
        );
    }

    #[test]
    fn test_same_version_conversion() {
        let converter = VersionConverter::new();
        let xml = r#"<?xml version="1.0" encoding="UTF-8"?><test>content</test>"#;
        let result = converter.convert(xml, DdexVersion::Ern42, DdexVersion::Ern42, None);

        match result {
            ConversionResult::Success {
                xml: result_xml, ..
            } => {
                assert_eq!(result_xml, xml);
            }
            _ => panic!("Expected successful conversion for same version"),
        }
    }

    #[test]
    fn test_supported_conversions() {
        let converter = VersionConverter::new();
        let conversions = converter.get_supported_conversions();
        assert!(conversions.contains(&(DdexVersion::Ern382, DdexVersion::Ern42)));
        assert!(conversions.contains(&(DdexVersion::Ern42, DdexVersion::Ern43)));
        assert!(conversions.contains(&(DdexVersion::Ern43, DdexVersion::Ern42)));
        assert!(conversions.contains(&(DdexVersion::Ern42, DdexVersion::Ern382)));
    }
}