1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
//! What background work carries and owes: the buffer collect in flight, the row count,
//! and the answers a worker sends however it ends.
use std::path::PathBuf;
use std::sync::{Arc, mpsc::Sender};
use polars::datatypes::AnyValue;
use polars::prelude::LazyFrame;
use crate::widgets::datatable::DataTableState;
use crate::{AppEvent, logging};
/// The buffer collect in flight: what it will fill, and for which data.
///
/// The first frame after a load sets `visible_rows` and asks for a recollect while the
/// pre-frame collect is still running; on an object store that restarted the same
/// row-group download. A collect that already covers the view is left to land instead,
/// provided nothing has moved underneath it: its job must still be current, and the
/// data the one it was spawned for (`len_generation` changes with every change to
/// `lf`, so a filter applied while it runs plans a fresh collect).
///
/// The payload of [`Job::Rows`]. Whether anyone waits on it is the job's keys: a
/// load-ahead starts with nobody waiting, and a scroll that finds its rows already on
/// the way waits on it from then.
#[derive(Debug, Clone, Copy)]
pub(crate) struct InflightCollect {
/// When the request went out, and how many of the dataset's files it will read, for
/// the Last page measurement. `files` is `None` where Polars was handed the whole
/// scan and reads what it decides to.
pub(crate) began: std::time::Instant,
pub(crate) files: Option<usize>,
pub(crate) dataset: u64,
/// The columns it reads ([`Self::columns_of`]). A new column order is the same
/// frame read through another projection, so these rows do not serve it.
pub(crate) columns: u64,
pub(crate) start: usize,
pub(crate) end: usize,
}
impl InflightCollect {
/// The columns a read of `state` projects, as a hash: kept `Copy`.
pub(crate) fn columns_of(state: &DataTableState) -> u64 {
use std::hash::{Hash, Hasher};
let mut hasher = std::collections::hash_map::DefaultHasher::new();
state.get_column_order().hash(&mut hasher);
hasher.finish()
}
/// A read of rows `start..end` of no data in particular, for tests.
#[cfg(test)]
pub(crate) fn for_tests(start: usize, end: usize) -> Self {
Self {
began: std::time::Instant::now(),
files: None,
dataset: 0,
columns: 0,
start,
end,
}
}
pub(crate) fn covers(&self, state: &DataTableState) -> bool {
// The view ends at the data when there is less than a screen of it.
let bound = state.num_rows_if_valid().unwrap_or(usize::MAX);
let view_end = (state.start_row() + state.visible_rows).min(bound);
// A row group being stitched on to the buffer covers the view with it.
let (mut start, mut end) = (self.start, self.end);
let (held_start, held_end) = (state.buffered_start(), state.buffered_end());
if state.stitches_buffer() && (start == held_end || end == held_start) {
start = start.min(held_start);
end = end.max(held_end);
}
self.dataset == state.len_generation()
&& self.columns == Self::columns_of(state)
&& start <= state.start_row()
&& view_end <= end
}
}
/// The exact row count of a frame, to run off the UI thread: the footer sum for a
/// pristine local Parquet hive directory or remote dataset of many files, otherwise
/// `len()`. Carries the `len_generation` it was spawned under, so a result for data since
/// changed is dropped.
pub(crate) struct LenCount {
pub(crate) len_generation: u64,
pub(crate) count_dir: Option<PathBuf>,
pub(crate) files: Option<crate::widgets::datatable::FileCounter>,
/// The view's own count, from a source that runs the view (a SQLite table).
pub(crate) counter: Option<crate::pushdown::Counter>,
pub(crate) lf: LazyFrame,
pub(crate) streaming: bool,
/// The open's meter. Counting a local directory re-reads every footer, which costs
/// what the open's own pass cost and is tallied with it.
pub(crate) meter: Arc<crate::measurements::Meter>,
/// What a count of footers has read of how many, for the footer's progress line;
/// cancelled, the count stops (Esc).
pub(crate) progress: Arc<crate::schema_union::FooterProgress>,
}
/// A count, and for a remote dataset of many files the row groups it was summed from.
pub(crate) struct Counted {
pub(crate) rows: usize,
file_row_groups: Option<Vec<Vec<usize>>>,
}
impl From<usize> for Counted {
fn from(rows: usize) -> Self {
Counted {
rows,
file_row_groups: None,
}
}
}
impl LenCount {
pub(crate) fn for_state(state: &DataTableState) -> Self {
Self {
len_generation: state.len_generation(),
count_dir: state.parquet_count_dir(),
files: state.remote_files_counter(),
counter: state.source_counter(),
meter: state.measurements().clone(),
lf: state.lf_clone(),
streaming: state.polars_streaming_enabled(),
// A store's footers are round trips, many waited on at once; a disk's are
// read, a wave at a time.
progress: Arc::new(if state.is_remote_source() {
crate::schema_union::FooterProgress::counting()
} else {
crate::schema_union::FooterProgress::default()
}),
}
}
/// Whether this count reads only footers, and so can run beside a buffer read
/// rather than waiting for it.
pub(crate) fn reads_footers(&self) -> bool {
self.files.is_some() || self.count_dir.is_some()
}
/// Count the rows. Blocks; `Err` when the count could not be taken.
pub(crate) fn run(&self) -> Result<Counted, ()> {
let kind = if self.reads_footers() {
"footers"
} else {
"scan"
};
let began = std::time::Instant::now();
log::debug!(target: "datui", "row count {} ({kind}): started", self.len_generation);
let counted = self.count();
match &counted {
Ok(counted) => log::debug!(
target: "datui",
"row count {} ({kind}): {} rows in {:.1?}",
self.len_generation,
counted.rows,
began.elapsed()
),
Err(()) => log::debug!(
target: "datui",
"row count {} ({kind}): failed after {:.1?}",
self.len_generation,
began.elapsed()
),
}
counted
}
fn count(&self) -> Result<Counted, ()> {
if let Some(counter) = &self.counter {
return counter()
.map(Counted::from)
.map_err(|e| log::warn!(target: "datui", "row count failed: {e}"));
}
// A dataset's footers, many at once. Should one not read, the scan counts itself;
// a count that was stopped does not.
if let Some(count) = &self.files {
match count(&self.progress) {
Ok(groups) => {
return Ok(Counted {
rows: groups.iter().flatten().sum(),
file_row_groups: Some(groups),
});
}
Err(_) if self.progress.is_cancelled() => return Err(()),
Err(_) => {}
}
}
match &self.count_dir {
Some(dir) => crate::dataset_files::LocalFiles::new(dir)
.count_rows(&self.meter, &self.progress)
.map(Counted::from)
.map_err(|e| log::warn!(target: "datui", "row count failed: {e:#}")),
None => {
match crate::statistics::collect_lazy(
crate::widgets::datatable::row_count_lf(&self.lf),
self.streaming,
) {
Ok(df) => Ok(match df.get(0) {
Some(col) => match col.first() {
Some(AnyValue::UInt64(n)) => *n as usize,
_ => 0,
},
None => 0,
}
.into()),
Err(e) => {
log::warn!(target: "datui", "row count failed: {e}");
Err(())
}
}
}
}
}
/// The count once a buffer collect of `requested` rows from `start` has returned
/// `returned` of them. A short read that began inside the data — at its top, or
/// finding at least a row — ran off its end, which names the total without a pass
/// over it. A full read, or a slice deep in a frame that found nothing and may lie
/// past the data entirely, leaves the count to `run`.
pub(crate) fn after_collect(
&self,
start: usize,
returned: usize,
requested: usize,
) -> Result<Counted, ()> {
if returned < requested && (start == 0 || returned > 0) {
Ok((start + returned).into())
} else {
self.run()
}
}
/// Report the count. A failure leaves the total provisional and allows a retry on a
/// later interaction; the buffer paint is unaffected either way.
fn send(&self, counted: Result<Counted, ()>, tx: &Sender<AppEvent>) {
let _ = tx.send(match counted {
Ok(counted) => AppEvent::BackgroundLenReady {
len_generation: self.len_generation,
num_rows: counted.rows,
file_row_groups: counted.file_row_groups,
},
Err(()) => AppEvent::BackgroundLenFailed {
len_generation: self.len_generation,
},
});
}
}
/// A count that has been started, and so owes `len_count_inflight` an answer.
///
/// Answered however its worker ends. A count that panics, or a collect it rides in that
/// fails or panics before reaching it, reports itself failed: unanswered, the marker
/// would stand for the session, with a spinner where the row count goes and `End`
/// waiting on nothing.
pub(crate) struct OwedCount {
job: Option<LenCount>,
tx: Sender<AppEvent>,
}
impl OwedCount {
pub(crate) fn new(job: LenCount, tx: Sender<AppEvent>) -> Self {
Self { job: Some(job), tx }
}
/// Count with `count` and report it, a panic as a failure.
pub(crate) fn answer(mut self, count: impl FnOnce(&LenCount) -> Result<Counted, ()>) {
if let Some(job) = self.job.take() {
let counted = logging::catch_panic(|| count(&job)).unwrap_or(Err(()));
job.send(counted, &self.tx);
}
}
}
impl Drop for OwedCount {
fn drop(&mut self) {
if let Some(job) = self.job.take() {
job.send(Err(()), &self.tx);
}
}
}
/// The answer a home-screen worker owes whatever marks it in flight, sent in its place
/// if the worker panics before sending its own. Unanswered, the marker stands for the
/// session: a listing that says "Looking..." over nothing, a search that never ends,
/// a root never probed again.
///
/// Not a [`jobs::Jobs`] job: these are keyed by place and `home_generation`, take no
/// lease and hold no keys. The panic itself is left to the hook, which logs it and has
/// `flash_background_panic` say so.
pub(crate) struct OwedAnswer {
pub(crate) tx: Sender<AppEvent>,
pub(crate) instead: Option<AppEvent>,
#[cfg(test)]
pub(crate) dies: bool,
}
impl OwedAnswer {
/// Run the worker, which sends its own answer.
pub(crate) fn run(mut self, work: impl FnOnce()) {
#[cfg(test)]
if self.dies {
panic!("worker died");
}
work();
self.instead = None;
}
}
impl Drop for OwedAnswer {
fn drop(&mut self) {
if let Some(instead) = self.instead.take() {
let _ = self.tx.send(instead);
}
}
}
/// What an open writes to the cache for home to read back (the recent, the shape):
/// written off the UI thread with nothing waiting on it, and counted here so the home
/// listing reads after it.
///
/// Without the count a `q` straight after an open could list the cache before the
/// recent was in it, and nothing lists it again until the user moves.
#[derive(Clone, Default)]
pub(crate) struct CacheWrites(Arc<(std::sync::Mutex<usize>, std::sync::Condvar)>);
impl CacheWrites {
/// The longest a listing waits: past the history lock's own timeout, so a write
/// that gives up has done so first.
const SETTLE: std::time::Duration = std::time::Duration::from_secs(5);
/// Write on a thread of its own, counted until it ends, panic or not.
pub(crate) fn spawn(&self, write: impl FnOnce() + Send + 'static) {
*self.0.0.lock().unwrap_or_else(|e| e.into_inner()) += 1;
let done = WriteDone(self.clone());
std::thread::spawn(move || {
let _done = done;
write();
});
}
/// Wait until no counted write is in flight, or [`Self::SETTLE`] passes. Called on a
/// worker, never the UI thread.
pub(crate) fn settle(&self) {
let (count, ended) = &*self.0;
let count = count.lock().unwrap_or_else(|e| e.into_inner());
let _ = ended.wait_timeout_while(count, Self::SETTLE, |n| *n > 0);
}
}
impl std::fmt::Debug for CacheWrites {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
f.write_str("CacheWrites")
}
}
struct WriteDone(CacheWrites);
impl Drop for WriteDone {
fn drop(&mut self) {
let (count, ended) = &*(self.0).0;
*count.lock().unwrap_or_else(|e| e.into_inner()) -= 1;
ended.notify_all();
}
}
#[cfg(test)]
mod cache_writes_tests {
use super::CacheWrites;
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Arc, mpsc};
#[test]
fn settle_waits_for_a_write_in_flight() {
let writes = CacheWrites::default();
let (go, wait) = mpsc::channel::<()>();
let written = Arc::new(AtomicBool::new(false));
let flag = written.clone();
writes.spawn(move || {
let _ = wait.recv();
flag.store(true, Ordering::SeqCst);
});
let settled = {
let writes = writes.clone();
std::thread::spawn(move || writes.settle())
};
std::thread::sleep(std::time::Duration::from_millis(50));
assert!(!settled.is_finished(), "settled while the write was held");
go.send(()).unwrap();
settled.join().unwrap();
assert!(written.load(Ordering::SeqCst));
}
#[test]
fn a_write_that_panics_still_ends() {
let writes = CacheWrites::default();
writes.spawn(|| panic!("write died"));
let started = std::time::Instant::now();
writes.settle();
assert!(started.elapsed() < CacheWrites::SETTLE);
}
}