dalo 1.11.1

Your team's agent skills, versioned like code. Review, pin, and sync skills, instructions, and hooks into every agent.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
//! Structurally owned provider hook sidecars with compare-and-swap updates.

use std::collections::BTreeMap;
use std::fs;
use std::io::Write;
use std::path::{Path, PathBuf};

use serde::{Deserialize, Serialize};
use serde_json::Value;
use sha2::{Digest, Sha256};
use tempfile::NamedTempFile;

use crate::error::{DaloError, DaloResult};
use crate::hook::{HookProvider, NativeHookProjection};
use crate::store::StorePaths;

const SIDECAR_STATE_SCHEMA_VERSION: u32 = 1;

/// Planned or completed sidecar operation.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize)]
#[serde(rename_all = "snake_case")]
pub enum HookSidecarAction {
    /// A missing native file will be created.
    Create,
    /// Existing owned entries will be replaced structurally.
    Update,
    /// Native content already equals the desired projection.
    Noop,
    /// The last Dalo-owned entries will be removed.
    Remove,
}

impl std::fmt::Display for HookSidecarAction {
    fn fmt(&self, formatter: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        formatter.write_str(match self {
            Self::Create => "create",
            Self::Update => "update",
            Self::Noop => "noop",
            Self::Remove => "remove",
        })
    }
}

/// Exact read-only operation plan used unchanged by dry-run and apply.
#[derive(Debug, Clone, Serialize)]
pub struct HookSidecarPlan {
    /// Provider receiving the projection.
    pub provider: HookProvider,
    /// Native settings or hooks file.
    pub path: PathBuf,
    /// Planned operation.
    pub action: HookSidecarAction,
    /// Projection contract fingerprint.
    pub projection_fingerprint: String,
    /// Hash observed while planning, used for compare-and-swap.
    pub observed_hash: String,
    /// Number of portable hooks represented.
    pub portable_hooks: usize,
    /// Whether application is suppressed.
    pub dry_run: bool,
    #[serde(skip)]
    desired_bytes: Option<Vec<u8>>,
    #[serde(skip)]
    observed_bytes: Option<Vec<u8>>,
    #[serde(skip)]
    created_file: bool,
    #[serde(skip)]
    owned_hooks: BTreeMap<String, Vec<Value>>,
}

#[derive(Debug, Clone, Default, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
struct HookSidecarStateFile {
    schema_version: u32,
    entries: Vec<HookSidecarState>,
}

#[derive(Debug, Clone, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
struct HookSidecarState {
    provider: HookProvider,
    path: PathBuf,
    projection_fingerprint: String,
    applied_file_hash: String,
    created_file: bool,
    owned_hooks: BTreeMap<String, Vec<Value>>,
}

/// Build the exact reconcile plan without changing provider or store state.
pub fn plan_sidecar(
    paths: &StorePaths,
    provider: HookProvider,
    path: &Path,
    projection: &NativeHookProjection,
) -> DaloResult<HookSidecarPlan> {
    if projection.provider != provider {
        return Err(DaloError::InvalidArgument {
            reason: "hook projection provider does not match sidecar provider".to_owned(),
        });
    }
    let state = read_state(paths)?;
    let previous = state
        .entries
        .iter()
        .find(|entry| entry.provider == provider && entry.path == path);
    let observed_bytes = match fs::read(path) {
        Ok(bytes) => Some(bytes),
        Err(error) if error.kind() == std::io::ErrorKind::NotFound => None,
        Err(error) => return Err(error.into()),
    };
    let observed_hash = hash_optional(observed_bytes.as_deref());
    let mut root = match observed_bytes.as_deref() {
        Some(bytes) => {
            serde_json::from_slice::<Value>(bytes).map_err(|error| DaloError::StateError {
                reason: format!(
                    "malformed {provider:?} hook sidecar `{}`: {error}",
                    path.display()
                ),
            })?
        }
        None => Value::Object(serde_json::Map::new()),
    };
    if !root.is_object() {
        return Err(DaloError::StateError {
            reason: format!(
                "native {provider:?} hook sidecar `{}` must contain a JSON object",
                path.display()
            ),
        });
    }
    if let Some(previous) = previous {
        remove_owned_groups(&mut root, &previous.owned_hooks, path)?;
    } else if contains_untracked_dalo_dispatcher(&root) {
        return Err(DaloError::StateError {
            reason: format!(
                "native hook conflict in `{}`: Dalo dispatcher entries exist without ownership state",
                path.display()
            ),
        });
    }
    append_owned_groups(&mut root, &projection.hooks)?;
    let preserve_unowned = previous.is_none() && projection.hooks.is_empty();
    let desired_bytes = if preserve_unowned {
        observed_bytes.clone()
    } else if root.as_object().is_some_and(|object| object.is_empty()) {
        if previous.is_some_and(|entry| !entry.created_file) {
            // The file existed before Dalo adopted it. State does not retain
            // its exact bytes, so restore the safe empty JSON object rather
            // than deleting a user-owned sidecar.
            Some(b"{}".to_vec())
        } else {
            None
        }
    } else {
        let mut bytes = serde_json::to_vec_pretty(&root)?;
        bytes.push(b'\n');
        Some(bytes)
    };
    let action = if desired_bytes == observed_bytes {
        HookSidecarAction::Noop
    } else if desired_bytes.is_none() {
        HookSidecarAction::Remove
    } else if observed_bytes.is_none() {
        HookSidecarAction::Create
    } else {
        HookSidecarAction::Update
    };
    let created_file = previous.is_some_and(|entry| entry.created_file) || observed_bytes.is_none();
    Ok(HookSidecarPlan {
        provider,
        path: path.to_path_buf(),
        action,
        projection_fingerprint: projection.fingerprint.clone(),
        observed_hash,
        portable_hooks: projection.portable_hooks,
        dry_run: true,
        desired_bytes,
        observed_bytes,
        created_file,
        owned_hooks: projection.hooks.clone(),
    })
}

/// Apply the exact plan with native-file CAS and rollback if state persistence fails.
pub fn apply_sidecar(
    paths: &StorePaths,
    projection: &NativeHookProjection,
    mut plan: HookSidecarPlan,
    dry_run: bool,
) -> DaloResult<HookSidecarPlan> {
    plan.dry_run = dry_run;
    if dry_run {
        return Ok(plan);
    }
    fs::create_dir_all(&paths.hooks_dir)?;
    let manifest_path = paths
        .hooks_dir
        .join("projections")
        .join(format!("{}.json", projection.fingerprint));
    if !manifest_path.exists() {
        let mut manifest = serde_json::to_vec_pretty(&projection.dispatcher_manifest)?;
        manifest.push(b'\n');
        write_atomic(&manifest_path, &manifest)?;
    }
    let current = match fs::read(&plan.path) {
        Ok(bytes) => Some(bytes),
        Err(error) if error.kind() == std::io::ErrorKind::NotFound => None,
        Err(error) => return Err(error.into()),
    };
    if hash_optional(current.as_deref()) != plan.observed_hash {
        return Err(DaloError::StateError {
            reason: format!(
                "concurrent edit detected for native hook sidecar `{}`; refusing to overwrite",
                plan.path.display()
            ),
        });
    }
    if plan.action != HookSidecarAction::Noop {
        write_or_remove(&plan.path, plan.desired_bytes.as_deref())?;
    }
    let applied_hash = hash_optional(plan.desired_bytes.as_deref());
    let mut state = match read_state(paths) {
        Ok(state) => state,
        Err(error) => {
            write_or_remove(&plan.path, plan.observed_bytes.as_deref())?;
            return Err(error);
        }
    };
    state
        .entries
        .retain(|entry| !(entry.provider == plan.provider && entry.path == plan.path));
    if !plan.owned_hooks.is_empty() {
        state.entries.push(HookSidecarState {
            provider: plan.provider,
            path: plan.path.clone(),
            projection_fingerprint: plan.projection_fingerprint.clone(),
            applied_file_hash: applied_hash,
            created_file: plan.created_file,
            owned_hooks: plan.owned_hooks.clone(),
        });
        state.entries.sort_by(|left, right| {
            format!("{:?}", left.provider)
                .cmp(&format!("{:?}", right.provider))
                .then(left.path.cmp(&right.path))
        });
    }
    if let Err(error) = write_state(paths, &state) {
        write_or_remove(&plan.path, plan.observed_bytes.as_deref())?;
        return Err(error);
    }
    Ok(plan)
}

fn read_state(paths: &StorePaths) -> DaloResult<HookSidecarStateFile> {
    match fs::read(&paths.hook_state_file) {
        Ok(bytes) => {
            let state: HookSidecarStateFile =
                serde_json::from_slice(&bytes).map_err(|error| DaloError::StateError {
                    reason: format!("malformed hook ownership state: {error}"),
                })?;
            if state.schema_version != SIDECAR_STATE_SCHEMA_VERSION {
                return Err(DaloError::StateError {
                    reason: format!(
                        "unsupported hook ownership schema {} (supported: {})",
                        state.schema_version, SIDECAR_STATE_SCHEMA_VERSION
                    ),
                });
            }
            Ok(state)
        }
        Err(error) if error.kind() == std::io::ErrorKind::NotFound => Ok(HookSidecarStateFile {
            schema_version: SIDECAR_STATE_SCHEMA_VERSION,
            entries: Vec::new(),
        }),
        Err(error) => Err(error.into()),
    }
}

fn write_state(paths: &StorePaths, state: &HookSidecarStateFile) -> DaloResult<()> {
    let mut bytes = serde_json::to_vec_pretty(state)?;
    bytes.push(b'\n');
    write_atomic(&paths.hook_state_file, &bytes)
}

fn remove_owned_groups(
    root: &mut Value,
    owned: &BTreeMap<String, Vec<Value>>,
    path: &Path,
) -> DaloResult<()> {
    let Some(root_object) = root.as_object_mut() else {
        unreachable!("caller validates root object");
    };
    let Some(hooks) = root_object.get_mut("hooks").and_then(Value::as_object_mut) else {
        return Err(native_drift(path, "owned hooks section is missing"));
    };
    for (event, groups) in owned {
        let Some(native_groups) = hooks.get_mut(event).and_then(Value::as_array_mut) else {
            return Err(native_drift(
                path,
                &format!("owned event `{event}` is missing"),
            ));
        };
        for group in groups {
            let matches = native_groups
                .iter()
                .enumerate()
                .filter_map(|(index, candidate)| (candidate == group).then_some(index))
                .collect::<Vec<_>>();
            if matches.len() != 1 {
                return Err(native_drift(
                    path,
                    &format!("owned event `{event}` was externally changed"),
                ));
            }
            native_groups.remove(matches[0]);
        }
    }
    hooks.retain(|_, groups| groups.as_array().is_none_or(|groups| !groups.is_empty()));
    if hooks.is_empty() {
        root_object.remove("hooks");
    }
    Ok(())
}

fn append_owned_groups(root: &mut Value, owned: &BTreeMap<String, Vec<Value>>) -> DaloResult<()> {
    if owned.is_empty() {
        return Ok(());
    }
    let root_object = root.as_object_mut().expect("caller validates root object");
    let hooks = root_object
        .entry("hooks")
        .or_insert_with(|| Value::Object(serde_json::Map::new()))
        .as_object_mut()
        .ok_or_else(|| DaloError::StateError {
            reason: "native `hooks` key exists but is not a JSON object".to_owned(),
        })?;
    for (event, groups) in owned {
        let native_groups = hooks
            .entry(event)
            .or_insert_with(|| Value::Array(Vec::new()))
            .as_array_mut()
            .ok_or_else(|| DaloError::StateError {
                reason: format!("native hook event `{event}` exists but is not an array"),
            })?;
        native_groups.extend(groups.iter().cloned());
    }
    Ok(())
}

fn contains_untracked_dalo_dispatcher(root: &Value) -> bool {
    serde_json::to_string(root).is_ok_and(|content| {
        content.contains("--projection") && content.contains("dispatch") && content.contains("hook")
    })
}

fn native_drift(path: &Path, detail: &str) -> DaloError {
    DaloError::StateError {
        reason: format!(
            "native hook drift in `{}`: {detail}; refusing implicit overwrite",
            path.display()
        ),
    }
}

fn hash_optional(bytes: Option<&[u8]>) -> String {
    match bytes {
        Some(bytes) => Sha256::digest(bytes)
            .iter()
            .map(|byte| format!("{byte:02x}"))
            .collect(),
        None => "missing".to_owned(),
    }
}

fn write_or_remove(path: &Path, bytes: Option<&[u8]>) -> DaloResult<()> {
    match bytes {
        Some(bytes) => write_atomic(path, bytes),
        None => match fs::remove_file(path) {
            Ok(()) => {
                sync_parent(path)?;
                Ok(())
            }
            Err(error) if error.kind() == std::io::ErrorKind::NotFound => Ok(()),
            Err(error) => Err(error.into()),
        },
    }
}

fn write_atomic(path: &Path, bytes: &[u8]) -> DaloResult<()> {
    let parent = path.parent().ok_or_else(|| DaloError::InvalidArgument {
        reason: format!("sidecar path `{}` has no parent", path.display()),
    })?;
    fs::create_dir_all(parent)?;
    let mut temporary = NamedTempFile::new_in(parent)?;
    temporary.write_all(bytes)?;
    temporary.flush()?;
    temporary.as_file().sync_all()?;
    temporary.persist(path).map_err(|error| error.error)?;
    fs::File::open(parent)?.sync_all()?;
    Ok(())
}

fn sync_parent(path: &Path) -> DaloResult<()> {
    if let Some(parent) = path.parent() {
        fs::File::open(parent)?.sync_all()?;
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use serde_json::json;

    fn fixture() -> (tempfile::TempDir, StorePaths) {
        let temp = tempfile::tempdir().unwrap();
        let root = temp.path().join("store");
        crate::store::init_store(root.clone(), false).unwrap();
        (temp, StorePaths::new(root))
    }

    fn projection(provider: HookProvider, fingerprint: &str, marker: &str) -> NativeHookProjection {
        let mut hooks = BTreeMap::new();
        if !marker.is_empty() {
            hooks.insert(
                "PreToolUse".to_owned(),
                vec![json!({
                    "matcher": "^(?:Bash)$",
                    "hooks": [{
                        "type": "command",
                        "command": "/dalo",
                        "args": ["hook", "dispatch", "--projection", marker]
                    }]
                })],
            );
        }
        NativeHookProjection {
            provider,
            provider_version: provider.baseline().to_owned(),
            fingerprint: fingerprint.to_owned(),
            portable_hooks: usize::from(!marker.is_empty()),
            hooks,
            dispatcher_manifest: json!({"schema_version": 1, "hooks": []}),
        }
    }

    #[test]
    fn create_update_and_uninstall_remove_a_dalo_created_sidecar() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("codex/hooks.json");
        let desired = projection(HookProvider::Codex, &"11".repeat(32), "one");
        let dry_run = apply_sidecar(
            &paths,
            &desired,
            plan_sidecar(&paths, HookProvider::Codex, &sidecar, &desired).unwrap(),
            true,
        )
        .unwrap();
        assert_eq!(dry_run.action, HookSidecarAction::Create);
        assert!(!sidecar.exists());

        let created = apply_sidecar(
            &paths,
            &desired,
            plan_sidecar(&paths, HookProvider::Codex, &sidecar, &desired).unwrap(),
            false,
        )
        .unwrap();
        assert_eq!(created.action, HookSidecarAction::Create);
        let initial = fs::read(&sidecar).unwrap();
        let noop = plan_sidecar(&paths, HookProvider::Codex, &sidecar, &desired).unwrap();
        assert_eq!(noop.action, HookSidecarAction::Noop);

        let updated = projection(HookProvider::Codex, &"22".repeat(32), "two");
        apply_sidecar(
            &paths,
            &updated,
            plan_sidecar(&paths, HookProvider::Codex, &sidecar, &updated).unwrap(),
            false,
        )
        .unwrap();

        let empty = projection(HookProvider::Codex, &"33".repeat(32), "");
        let removed = apply_sidecar(
            &paths,
            &empty,
            plan_sidecar(&paths, HookProvider::Codex, &sidecar, &empty).unwrap(),
            false,
        )
        .unwrap();
        assert_eq!(removed.action, HookSidecarAction::Remove);
        assert!(!sidecar.exists());
        assert!(!initial.is_empty());
    }

    #[test]
    fn empty_projection_preserves_an_unowned_empty_sidecar() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("claude/settings.json");
        fs::create_dir_all(sidecar.parent().unwrap()).unwrap();
        fs::write(&sidecar, "{}").unwrap();
        let empty = projection(HookProvider::Claude, &"11".repeat(32), "");

        let plan = plan_sidecar(&paths, HookProvider::Claude, &sidecar, &empty).unwrap();
        assert_eq!(plan.action, HookSidecarAction::Noop);

        apply_sidecar(&paths, &empty, plan, false).unwrap();
        assert_eq!(fs::read_to_string(&sidecar).unwrap(), "{}");
    }

    #[test]
    fn adopted_empty_sidecar_is_restored_after_the_last_hook_is_removed() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("claude/settings.json");
        fs::create_dir_all(sidecar.parent().unwrap()).unwrap();
        fs::write(&sidecar, "{}").unwrap();
        let first = projection(HookProvider::Claude, &"11".repeat(32), "one");
        apply_sidecar(
            &paths,
            &first,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &first).unwrap(),
            false,
        )
        .unwrap();

        let updated = projection(HookProvider::Claude, &"22".repeat(32), "two");
        apply_sidecar(
            &paths,
            &updated,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &updated).unwrap(),
            false,
        )
        .unwrap();

        let empty = projection(HookProvider::Claude, &"33".repeat(32), "");
        let removed = apply_sidecar(
            &paths,
            &empty,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &empty).unwrap(),
            false,
        )
        .unwrap();

        assert_eq!(removed.action, HookSidecarAction::Update);
        assert_eq!(fs::read_to_string(&sidecar).unwrap(), "{}");
    }

    #[test]
    fn update_preserves_foreign_settings_and_new_concurrent_edits() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("claude/settings.json");
        fs::create_dir_all(sidecar.parent().unwrap()).unwrap();
        fs::write(
            &sidecar,
            br#"{"permissions":{"allow":["Read"]},"hooks":{"Stop":[{"hooks":[{"type":"command","command":"foreign"}]}]}}"#,
        )
        .unwrap();
        let first = projection(HookProvider::Claude, &"11".repeat(32), "one");
        apply_sidecar(
            &paths,
            &first,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &first).unwrap(),
            false,
        )
        .unwrap();

        let mut externally_edited: Value =
            serde_json::from_slice(&fs::read(&sidecar).unwrap()).unwrap();
        externally_edited["theme"] = json!("dark");
        fs::write(
            &sidecar,
            serde_json::to_vec_pretty(&externally_edited).unwrap(),
        )
        .unwrap();
        let second = projection(HookProvider::Claude, &"22".repeat(32), "two");
        apply_sidecar(
            &paths,
            &second,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &second).unwrap(),
            false,
        )
        .unwrap();
        let result: Value = serde_json::from_slice(&fs::read(&sidecar).unwrap()).unwrap();
        assert_eq!(result["permissions"]["allow"][0], "Read");
        assert_eq!(result["theme"], "dark");
        assert_eq!(result["hooks"]["Stop"][0]["hooks"][0]["command"], "foreign");
        assert_eq!(
            result["hooks"]["PreToolUse"][0]["hooks"][0]["args"][3],
            "two"
        );
    }

    #[test]
    fn malformed_sidecar_owned_drift_and_untracked_dispatcher_block() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("settings.json");
        fs::write(&sidecar, "not json").unwrap();
        let desired = projection(HookProvider::Claude, &"11".repeat(32), "one");
        assert!(plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).is_err());

        fs::write(
            &sidecar,
            br#"{"hooks":{"PreToolUse":[{"hooks":[{"command":"dalo hook dispatch --projection orphan"}]}]}}"#,
        )
        .unwrap();
        assert!(plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).is_err());

        fs::remove_file(&sidecar).unwrap();
        apply_sidecar(
            &paths,
            &desired,
            plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).unwrap(),
            false,
        )
        .unwrap();
        let mut changed: Value = serde_json::from_slice(&fs::read(&sidecar).unwrap()).unwrap();
        changed["hooks"]["PreToolUse"][0]["matcher"] = json!("changed");
        fs::write(&sidecar, serde_json::to_vec(&changed).unwrap()).unwrap();
        assert!(plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).is_err());
    }

    #[test]
    fn compare_and_swap_rejects_a_post_plan_edit() {
        let (temp, paths) = fixture();
        let sidecar = temp.path().join("settings.json");
        fs::write(&sidecar, "{}").unwrap();
        let desired = projection(HookProvider::Claude, &"11".repeat(32), "one");
        let plan = plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).unwrap();
        fs::write(&sidecar, r#"{"external":true}"#).unwrap();
        assert!(apply_sidecar(&paths, &desired, plan, false).is_err());
        assert_eq!(
            fs::read_to_string(&sidecar).unwrap(),
            r#"{"external":true}"#
        );
    }

    #[test]
    fn state_write_failure_rolls_native_file_back() {
        let (temp, mut paths) = fixture();
        let sidecar = temp.path().join("settings.json");
        fs::write(&sidecar, r#"{"foreign":true}"#).unwrap();
        let desired = projection(HookProvider::Claude, &"11".repeat(32), "one");
        let plan = plan_sidecar(&paths, HookProvider::Claude, &sidecar, &desired).unwrap();
        let original = fs::read(&sidecar).unwrap();
        paths.hook_state_file = temp.path().join("state-as-directory");
        fs::create_dir(&paths.hook_state_file).unwrap();

        assert!(apply_sidecar(&paths, &desired, plan, false).is_err());
        assert_eq!(fs::read(&sidecar).unwrap(), original);
    }

    #[test]
    fn one_provider_conflict_does_not_corrupt_the_other_projection() {
        let (temp, paths) = fixture();
        let codex_path = temp.path().join("codex/hooks.json");
        let claude_path = temp.path().join("claude/settings.json");
        let codex = projection(HookProvider::Codex, &"11".repeat(32), "codex");
        apply_sidecar(
            &paths,
            &codex,
            plan_sidecar(&paths, HookProvider::Codex, &codex_path, &codex).unwrap(),
            false,
        )
        .unwrap();
        let codex_bytes = fs::read(&codex_path).unwrap();

        fs::create_dir_all(claude_path.parent().unwrap()).unwrap();
        fs::write(&claude_path, "malformed").unwrap();
        let claude = projection(HookProvider::Claude, &"22".repeat(32), "claude");
        assert!(plan_sidecar(&paths, HookProvider::Claude, &claude_path, &claude).is_err());
        assert_eq!(fs::read(&codex_path).unwrap(), codex_bytes);
        assert_eq!(fs::read_to_string(&claude_path).unwrap(), "malformed");
    }
}