dag-ml-core 0.2.1

Core graph, phase, OOF and deterministic control contracts for dag-ml.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
1654
1655
1656
1657
1658
1659
1660
1661
1662
1663
1664
1665
1666
1667
1668
1669
1670
1671
1672
1673
1674
1675
1676
1677
1678
1679
1680
1681
1682
1683
1684
1685
1686
1687
1688
1689
1690
1691
1692
1693
1694
1695
1696
1697
1698
1699
1700
1701
1702
1703
1704
1705
1706
1707
1708
1709
1710
1711
1712
1713
1714
1715
1716
1717
1718
1719
1720
1721
1722
1723
1724
1725
1726
1727
1728
1729
1730
1731
1732
1733
1734
1735
1736
1737
1738
1739
1740
1741
1742
1743
1744
1745
1746
1747
1748
1749
1750
1751
1752
1753
1754
1755
1756
1757
1758
1759
1760
1761
1762
1763
1764
1765
1766
1767
1768
1769
1770
1771
1772
1773
1774
1775
1776
1777
1778
1779
1780
1781
1782
1783
1784
1785
1786
1787
1788
1789
1790
1791
1792
1793
1794
1795
1796
1797
1798
1799
1800
1801
1802
1803
1804
1805
1806
1807
1808
1809
1810
1811
1812
1813
1814
1815
1816
1817
1818
1819
1820
1821
1822
1823
1824
1825
1826
1827
1828
1829
1830
1831
1832
1833
1834
1835
1836
1837
1838
1839
1840
1841
1842
1843
1844
1845
1846
1847
1848
1849
1850
1851
1852
1853
1854
1855
1856
1857
1858
1859
1860
1861
1862
1863
1864
1865
1866
1867
1868
1869
1870
1871
1872
1873
1874
1875
1876
1877
1878
1879
1880
1881
1882
1883
1884
1885
1886
1887
1888
1889
1890
1891
1892
1893
1894
1895
1896
1897
1898
1899
1900
1901
1902
1903
1904
1905
1906
1907
1908
1909
1910
1911
1912
1913
1914
1915
1916
1917
1918
1919
1920
1921
1922
1923
1924
1925
1926
1927
1928
1929
1930
1931
1932
1933
1934
1935
1936
1937
1938
1939
1940
1941
1942
1943
1944
1945
1946
1947
1948
1949
1950
1951
1952
1953
1954
1955
1956
1957
1958
1959
1960
1961
1962
1963
1964
1965
1966
1967
1968
1969
1970
1971
1972
1973
1974
1975
1976
1977
1978
1979
1980
1981
1982
1983
1984
1985
1986
1987
1988
1989
1990
1991
1992
1993
1994
1995
1996
1997
1998
1999
2000
2001
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
2013
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
2025
2026
2027
2028
2029
2030
2031
2032
2033
2034
2035
2036
2037
2038
2039
2040
2041
2042
2043
2044
2045
2046
2047
2048
2049
2050
2051
2052
2053
2054
2055
2056
2057
2058
2059
2060
2061
2062
2063
2064
2065
2066
2067
2068
2069
2070
2071
2072
2073
2074
2075
2076
2077
2078
2079
2080
2081
2082
2083
2084
2085
2086
2087
2088
2089
2090
2091
2092
2093
2094
2095
2096
2097
2098
2099
2100
2101
2102
2103
2104
2105
2106
2107
2108
2109
2110
2111
2112
2113
2114
2115
2116
2117
2118
2119
2120
2121
2122
2123
2124
2125
2126
2127
2128
2129
2130
2131
2132
2133
2134
2135
2136
2137
2138
2139
2140
2141
2142
2143
2144
2145
2146
2147
2148
2149
2150
2151
2152
2153
2154
2155
2156
2157
2158
2159
2160
2161
2162
2163
2164
2165
2166
2167
2168
2169
2170
2171
2172
2173
2174
2175
2176
2177
2178
2179
2180
2181
2182
2183
2184
2185
2186
2187
2188
2189
2190
2191
2192
2193
2194
2195
2196
2197
2198
2199
2200
2201
2202
2203
2204
2205
2206
2207
2208
2209
2210
2211
2212
2213
2214
2215
2216
2217
2218
2219
2220
2221
2222
2223
2224
2225
2226
2227
2228
2229
2230
2231
2232
2233
2234
2235
2236
2237
2238
2239
2240
2241
2242
2243
2244
2245
2246
2247
2248
2249
2250
2251
2252
2253
2254
2255
2256
2257
2258
2259
2260
2261
2262
2263
2264
2265
2266
2267
2268
2269
2270
2271
2272
2273
2274
2275
2276
2277
2278
2279
2280
2281
2282
2283
2284
2285
2286
2287
2288
2289
2290
2291
2292
2293
2294
2295
2296
2297
2298
2299
2300
2301
2302
2303
2304
2305
2306
2307
2308
2309
2310
2311
2312
2313
2314
2315
2316
2317
2318
2319
2320
2321
2322
2323
2324
2325
2326
2327
2328
2329
2330
2331
2332
2333
2334
2335
2336
2337
2338
2339
2340
2341
2342
2343
2344
2345
2346
2347
2348
2349
2350
2351
2352
2353
2354
2355
2356
2357
2358
2359
2360
2361
2362
2363
2364
2365
2366
2367
2368
2369
2370
2371
2372
2373
2374
2375
2376
2377
2378
2379
2380
2381
2382
2383
2384
2385
2386
2387
2388
2389
2390
2391
2392
2393
2394
2395
2396
2397
2398
2399
2400
2401
2402
2403
2404
2405
2406
2407
2408
2409
2410
2411
2412
2413
2414
2415
2416
2417
2418
2419
2420
2421
2422
2423
2424
2425
2426
2427
2428
2429
2430
2431
2432
2433
2434
2435
2436
2437
2438
2439
2440
2441
2442
2443
2444
2445
2446
2447
2448
2449
2450
2451
2452
2453
2454
2455
2456
2457
2458
2459
2460
2461
2462
use std::cell::RefCell;
use std::collections::{BTreeMap, BTreeSet};

use serde::{Deserialize, Serialize};

use crate::error::{DagMlError, Result};
use crate::ids::{ControllerId, FoldId, NodeId, RunId, VariantId};
use crate::phase::Phase;
use crate::policy::FitInfluencePolicy;
use crate::relation::{EntityUnitLevel, SampleRelationSet};
use crate::runtime::{
    DataMaterializationRequest, DataProviderViewSpec, DataViewRequest, HandleKind, HandleRef,
    RuntimeDataProvider,
};

pub const EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION: u32 = 1;
pub const MODEL_INPUT_SPEC_SCHEMA_VERSION: u32 = 1;
pub const MODEL_INPUT_SPEC_SCHEMA_ID: &str =
    "https://github.com/GBeurier/dag-ml/schemas/model_input_spec.v1.schema.json";
pub const DATA_PLAN_SCHEMA_VERSION: u32 = 1;
pub const DATA_PLAN_SCHEMA_ID: &str =
    "https://github.com/GBeurier/dag-ml/schemas/data_plan.v1.schema.json";

fn default_external_data_plan_envelope_schema_version() -> u32 {
    EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION
}

fn default_model_input_spec_schema_version() -> u32 {
    MODEL_INPUT_SPEC_SCHEMA_VERSION
}

fn default_data_plan_schema_version() -> u32 {
    DATA_PLAN_SCHEMA_VERSION
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum DataRequestPartition {
    FoldTrain,
    FoldValidation,
    FullTrain,
    Predict,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum ModelInputFusionMode {
    SingleSource,
    ConcatenateFeatures,
    StackSamples,
    DictBySource,
    Custom,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum BranchViewMode {
    Separation,
    BySource,
    ByMetadata,
    ByTag,
    ByFilter,
}

#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
pub struct DataViewSelector {
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub source_ids: Vec<String>,
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub metadata: BTreeMap<String, serde_json::Value>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub tags: Vec<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub filter: Option<serde_json::Value>,
}

impl DataViewSelector {
    pub fn validate(&self, label: &str) -> Result<()> {
        if self.source_ids.is_empty()
            && self.metadata.is_empty()
            && self.tags.is_empty()
            && self.filter.is_none()
        {
            return Err(DagMlError::CampaignValidation(format!(
                "{label} selector must constrain source_ids, metadata, tags or filter"
            )));
        }
        validate_string_list_entries(&format!("{label} selector source_ids"), &self.source_ids)?;
        validate_unique_strings(&format!("{label} selector source_ids"), &self.source_ids)?;
        validate_string_list_entries(&format!("{label} selector tags"), &self.tags)?;
        validate_unique_strings(&format!("{label} selector tags"), &self.tags)?;
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "{label} selector contains an empty metadata key"
                )));
            }
        }
        if matches!(self.filter, Some(serde_json::Value::Null)) {
            return Err(DagMlError::CampaignValidation(format!(
                "{label} selector filter must not be null"
            )));
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub struct BranchViewPlan {
    pub view_id: String,
    pub branch_id: String,
    pub mode: BranchViewMode,
    pub selector: DataViewSelector,
    #[serde(default)]
    pub allow_overlap: bool,
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl BranchViewPlan {
    pub fn validate(&self) -> Result<()> {
        validate_non_empty("branch view plan view_id", &self.view_id)?;
        validate_non_empty("branch view plan branch_id", &self.branch_id)?;
        self.selector
            .validate(&format!("branch view `{}`", self.view_id))?;
        match self.mode {
            BranchViewMode::BySource if self.selector.source_ids.is_empty() => {
                return Err(DagMlError::CampaignValidation(format!(
                    "branch view `{}` mode=by_source requires source_ids",
                    self.view_id
                )));
            }
            BranchViewMode::ByMetadata if self.selector.metadata.is_empty() => {
                return Err(DagMlError::CampaignValidation(format!(
                    "branch view `{}` mode=by_metadata requires metadata",
                    self.view_id
                )));
            }
            BranchViewMode::ByTag if self.selector.tags.is_empty() => {
                return Err(DagMlError::CampaignValidation(format!(
                    "branch view `{}` mode=by_tag requires tags",
                    self.view_id
                )));
            }
            BranchViewMode::ByFilter if self.selector.filter.is_none() => {
                return Err(DagMlError::CampaignValidation(format!(
                    "branch view `{}` mode=by_filter requires filter",
                    self.view_id
                )));
            }
            _ => {}
        }
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "branch view `{}` metadata contains an empty key",
                    self.view_id
                )));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Copy, Debug, Default, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum CombinationMode {
    #[default]
    Cartesian,
    Zip,
    MatchBy,
    SampleK,
    ReferenceBroadcast,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum RepresentationMissingSourcePolicy {
    Strict,
    Warn,
    DropIncomplete,
    ImputeDeclared,
    Mask,
    PartialModel,
    Pad,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum RepresentationCardinality {
    OneToOne,
    OneToMany,
    ManyToOne,
    ManyToMany,
    BoundedMany,
}

#[derive(Clone, Debug, Default, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct CombinationPlan {
    pub mode: CombinationMode,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub component_source_ids: Vec<String>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub component_unit_ids: Vec<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub match_key: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub reference_source_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub seed: Option<u64>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub cap: Option<usize>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub budget: Option<usize>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub missing_source_policy: Option<RepresentationMissingSourcePolicy>,
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl CombinationPlan {
    pub fn validate(&self) -> Result<()> {
        validate_string_list_entries(
            "combination plan component_source_ids",
            &self.component_source_ids,
        )?;
        validate_unique_strings(
            "combination plan component_source_ids",
            &self.component_source_ids,
        )?;
        validate_string_list_entries(
            "combination plan component_unit_ids",
            &self.component_unit_ids,
        )?;
        validate_unique_strings(
            "combination plan component_unit_ids",
            &self.component_unit_ids,
        )?;
        validate_optional_non_empty("combination plan match_key", &self.match_key)?;
        validate_optional_non_empty(
            "combination plan reference_source_id",
            &self.reference_source_id,
        )?;
        if self.cap == Some(0) {
            return Err(DagMlError::CampaignValidation(
                "combination plan cap must be positive when present".to_string(),
            ));
        }
        if self.budget == Some(0) {
            return Err(DagMlError::CampaignValidation(
                "combination plan budget must be positive when present".to_string(),
            ));
        }
        match self.mode {
            CombinationMode::Cartesian => {
                if self.component_source_ids.len() < 2 {
                    return Err(DagMlError::CampaignValidation(
                        "cartesian combination requires at least two component_source_ids"
                            .to_string(),
                    ));
                }
            }
            CombinationMode::Zip => {
                if self.component_source_ids.len() < 2 {
                    return Err(DagMlError::CampaignValidation(
                        "zip combination requires at least two component_source_ids".to_string(),
                    ));
                }
            }
            CombinationMode::MatchBy => {
                if self.match_key.is_none() {
                    return Err(DagMlError::CampaignValidation(
                        "match_by combination requires match_key".to_string(),
                    ));
                }
            }
            CombinationMode::SampleK => {
                if self.seed.is_none() {
                    return Err(DagMlError::CampaignValidation(
                        "sample_k combination requires seed".to_string(),
                    ));
                }
                if self.cap.is_none() {
                    return Err(DagMlError::CampaignValidation(
                        "sample_k combination requires cap".to_string(),
                    ));
                }
            }
            CombinationMode::ReferenceBroadcast => {
                let Some(reference) = &self.reference_source_id else {
                    return Err(DagMlError::CampaignValidation(
                        "reference_broadcast combination requires reference_source_id".to_string(),
                    ));
                };
                if !self.component_source_ids.is_empty()
                    && !self
                        .component_source_ids
                        .iter()
                        .any(|source| source == reference)
                {
                    return Err(DagMlError::CampaignValidation(format!(
                        "reference_broadcast reference_source_id `{reference}` is not in component_source_ids"
                    )));
                }
            }
        }
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "combination plan metadata contains an empty key".to_string(),
                ));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(tag = "kind", rename_all = "snake_case", deny_unknown_fields)]
pub enum RepresentationPlan {
    Aggregate(AggregateRepresentation),
    CartesianProduct(CartesianProductRepresentation),
    MonteCarloCartesian(MonteCarloCartesianRepresentation),
    StackFixed(StackFixedRepresentation),
    StackPaddedMasked(StackPaddedMaskedRepresentation),
}

impl RepresentationPlan {
    pub fn validate(&self) -> Result<()> {
        match self {
            Self::Aggregate(plan) => plan.validate(),
            Self::CartesianProduct(plan) => plan.validate(),
            Self::MonteCarloCartesian(plan) => plan.validate(),
            Self::StackFixed(plan) => plan.validate(),
            Self::StackPaddedMasked(plan) => plan.validate(),
        }
    }

    pub fn output_unit_level(&self) -> EntityUnitLevel {
        match self {
            Self::Aggregate(plan) => plan.output_unit_level,
            Self::CartesianProduct(plan) => plan.output_unit_level,
            Self::MonteCarloCartesian(plan) => plan.output_unit_level,
            Self::StackFixed(plan) => plan.output_unit_level,
            Self::StackPaddedMasked(plan) => plan.output_unit_level,
        }
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct AggregateRepresentation {
    pub input_unit_level: EntityUnitLevel,
    pub output_unit_level: EntityUnitLevel,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub reducer_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub method: Option<String>,
    pub cardinality: RepresentationCardinality,
}

impl AggregateRepresentation {
    pub fn validate(&self) -> Result<()> {
        validate_optional_non_empty("aggregate representation reducer_id", &self.reducer_id)?;
        validate_optional_non_empty("aggregate representation method", &self.method)?;
        if self.cardinality != RepresentationCardinality::ManyToOne {
            return Err(DagMlError::CampaignValidation(
                "aggregate representation cardinality must be many_to_one".to_string(),
            ));
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct CartesianProductRepresentation {
    pub combination_plan: CombinationPlan,
    pub output_unit_level: EntityUnitLevel,
    pub cardinality: RepresentationCardinality,
    #[serde(default = "default_true")]
    pub preserve_provenance: bool,
}

impl CartesianProductRepresentation {
    pub fn validate(&self) -> Result<()> {
        self.combination_plan.validate()?;
        if self.combination_plan.mode != CombinationMode::Cartesian {
            return Err(DagMlError::CampaignValidation(
                "cartesian_product representation requires combination_plan.mode=cartesian"
                    .to_string(),
            ));
        }
        validate_combo_like_output("cartesian_product", self.output_unit_level)?;
        if self.cardinality != RepresentationCardinality::ManyToMany {
            return Err(DagMlError::CampaignValidation(
                "cartesian_product representation cardinality must be many_to_many".to_string(),
            ));
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct MonteCarloCartesianRepresentation {
    pub combination_plan: CombinationPlan,
    pub output_unit_level: EntityUnitLevel,
    pub cardinality: RepresentationCardinality,
    #[serde(default = "default_true")]
    pub preserve_provenance: bool,
}

impl MonteCarloCartesianRepresentation {
    pub fn validate(&self) -> Result<()> {
        self.combination_plan.validate()?;
        if self.combination_plan.mode != CombinationMode::SampleK {
            return Err(DagMlError::CampaignValidation(
                "monte_carlo_cartesian representation requires combination_plan.mode=sample_k"
                    .to_string(),
            ));
        }
        validate_combo_like_output("monte_carlo_cartesian", self.output_unit_level)?;
        if self.cardinality != RepresentationCardinality::BoundedMany {
            return Err(DagMlError::CampaignValidation(
                "monte_carlo_cartesian representation cardinality must be bounded_many".to_string(),
            ));
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct StackFixedRepresentation {
    pub output_unit_level: EntityUnitLevel,
    pub cardinality: RepresentationCardinality,
    pub expected_cardinality: usize,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub component_source_ids: Vec<String>,
}

impl StackFixedRepresentation {
    pub fn validate(&self) -> Result<()> {
        if self.expected_cardinality == 0 {
            return Err(DagMlError::CampaignValidation(
                "stack_fixed representation expected_cardinality must be positive".to_string(),
            ));
        }
        if self.cardinality != RepresentationCardinality::OneToMany {
            return Err(DagMlError::CampaignValidation(
                "stack_fixed representation cardinality must be one_to_many".to_string(),
            ));
        }
        validate_string_list_entries(
            "stack_fixed representation component_source_ids",
            &self.component_source_ids,
        )?;
        validate_unique_strings(
            "stack_fixed representation component_source_ids",
            &self.component_source_ids,
        )
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct StackPaddedMaskedRepresentation {
    pub output_unit_level: EntityUnitLevel,
    pub cardinality: RepresentationCardinality,
    pub expected_cardinality: usize,
    pub missing_source_policy: RepresentationMissingSourcePolicy,
    #[serde(default = "default_true")]
    pub requires_missing_masks: bool,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub component_source_ids: Vec<String>,
}

impl StackPaddedMaskedRepresentation {
    pub fn validate(&self) -> Result<()> {
        if self.expected_cardinality == 0 {
            return Err(DagMlError::CampaignValidation(
                "stack_padded_masked representation expected_cardinality must be positive"
                    .to_string(),
            ));
        }
        if self.cardinality != RepresentationCardinality::BoundedMany {
            return Err(DagMlError::CampaignValidation(
                "stack_padded_masked representation cardinality must be bounded_many".to_string(),
            ));
        }
        if !matches!(
            self.missing_source_policy,
            RepresentationMissingSourcePolicy::Mask | RepresentationMissingSourcePolicy::Pad
        ) {
            return Err(DagMlError::CampaignValidation(
                "stack_padded_masked representation requires missing_source_policy=mask or pad"
                    .to_string(),
            ));
        }
        if !self.requires_missing_masks {
            return Err(DagMlError::CampaignValidation(
                "stack_padded_masked representation requires missing-mask controller support"
                    .to_string(),
            ));
        }
        validate_string_list_entries(
            "stack_padded_masked representation component_source_ids",
            &self.component_source_ids,
        )?;
        validate_unique_strings(
            "stack_padded_masked representation component_source_ids",
            &self.component_source_ids,
        )
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct RepresentationSampleObservationMapping {
    pub physical_sample_id: String,
    pub source_id: String,
    pub observation_ids: Vec<String>,
}

impl RepresentationSampleObservationMapping {
    pub fn validate(&self) -> Result<()> {
        validate_non_empty(
            "representation sample observation mapping physical_sample_id",
            &self.physical_sample_id,
        )?;
        validate_non_empty(
            "representation sample observation mapping source_id",
            &self.source_id,
        )?;
        validate_non_empty_list(
            "representation sample observation mapping observation_ids",
            &self.observation_ids,
        )?;
        validate_unique_strings(
            "representation sample observation mapping observation_ids",
            &self.observation_ids,
        )
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct RepresentationComboSelectionRecord {
    pub combo_unit_id: String,
    pub physical_sample_id: String,
    pub component_observation_ids: Vec<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub seed: Option<u64>,
}

impl RepresentationComboSelectionRecord {
    pub fn validate(&self) -> Result<()> {
        validate_non_empty(
            "representation combo selection combo_unit_id",
            &self.combo_unit_id,
        )?;
        validate_non_empty(
            "representation combo selection physical_sample_id",
            &self.physical_sample_id,
        )?;
        validate_non_empty_list(
            "representation combo selection component_observation_ids",
            &self.component_observation_ids,
        )?;
        validate_unique_strings(
            "representation combo selection component_observation_ids",
            &self.component_observation_ids,
        )
    }
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum RepresentationCompatibilitySeverity {
    Info,
    Warning,
    Error,
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum RepresentationCompatibilityOutcome {
    Compatible,
    CompatibleWithFallback,
    Incompatible,
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct RepresentationCompatibilityReport {
    pub policy: RepresentationMissingSourcePolicy,
    pub outcome: RepresentationCompatibilityOutcome,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub fallback_used: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub warning_severity: Option<RepresentationCompatibilitySeverity>,
    #[serde(default)]
    pub affected_source_count: u64,
    #[serde(default)]
    pub affected_repetition_count: u64,
    #[serde(default)]
    pub affected_sample_count: u64,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub train_relation_fingerprint: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub predict_relation_fingerprint: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub train_unit_count: Option<u64>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub predict_unit_count: Option<u64>,
    #[serde(default)]
    pub fixed_width_required: bool,
    #[serde(default)]
    pub final_reducer_stabilizes_output: bool,
    #[serde(default)]
    pub cartesian_combo_count_changed: bool,
    #[serde(default)]
    pub late_fusion_branch_delta: bool,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub messages: Vec<String>,
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl RepresentationCompatibilityReport {
    pub fn validate(&self) -> Result<()> {
        validate_optional_non_empty(
            "representation compatibility fallback_used",
            &self.fallback_used,
        )?;
        if let Some(fingerprint) = &self.train_relation_fingerprint {
            validate_fingerprint("representation compatibility train relation", fingerprint)?;
        }
        if let Some(fingerprint) = &self.predict_relation_fingerprint {
            validate_fingerprint("representation compatibility predict relation", fingerprint)?;
        }
        validate_string_list_entries("representation compatibility messages", &self.messages)?;
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility metadata contains an empty key".to_string(),
                ));
            }
        }

        let affected_total = self
            .affected_source_count
            .saturating_add(self.affected_repetition_count)
            .saturating_add(self.affected_sample_count);
        let relation_fingerprint_changed = matches!(
            (
                self.train_relation_fingerprint.as_deref(),
                self.predict_relation_fingerprint.as_deref()
            ),
            (Some(train), Some(predict)) if train != predict
        );
        let unit_count_changed = matches!(
            (self.train_unit_count, self.predict_unit_count),
            (Some(train), Some(predict)) if train != predict
        );
        if affected_total == 0 {
            if relation_fingerprint_changed {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility relation fingerprint mismatch requires affected units"
                        .to_string(),
                ));
            }
            if unit_count_changed {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility unit count mismatch requires affected units"
                        .to_string(),
                ));
            }
            if self.outcome == RepresentationCompatibilityOutcome::CompatibleWithFallback {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility cannot use fallback when no units are affected"
                        .to_string(),
                ));
            }
            if self.warning_severity.is_some() {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility warning_severity requires affected units"
                        .to_string(),
                ));
            }
        } else if self.policy == RepresentationMissingSourcePolicy::Strict {
            if self.outcome != RepresentationCompatibilityOutcome::Incompatible {
                return Err(DagMlError::CampaignValidation(
                    "strict representation compatibility with affected units must be incompatible"
                        .to_string(),
                ));
            }
            if self.fallback_used.is_some() {
                return Err(DagMlError::CampaignValidation(
                    "strict representation compatibility cannot declare fallback_used".to_string(),
                ));
            }
        } else {
            if self.warning_severity.is_none() {
                return Err(DagMlError::CampaignValidation(
                    "non-strict representation compatibility with affected units requires warning_severity"
                        .to_string(),
                ));
            }
            if self.outcome == RepresentationCompatibilityOutcome::Compatible {
                return Err(DagMlError::CampaignValidation(
                    "representation compatibility with affected units cannot be compatible"
                        .to_string(),
                ));
            }
            if self.outcome == RepresentationCompatibilityOutcome::CompatibleWithFallback
                && self.fallback_used.is_none()
            {
                return Err(DagMlError::CampaignValidation(
                    "compatible_with_fallback representation compatibility requires fallback_used"
                        .to_string(),
                ));
            }
        }

        if self.outcome == RepresentationCompatibilityOutcome::Incompatible
            && self.fallback_used.is_some()
        {
            return Err(DagMlError::CampaignValidation(
                "incompatible representation compatibility cannot declare fallback_used"
                    .to_string(),
            ));
        }

        if self.fixed_width_required && unit_count_changed && !self.allows_fixed_width_fallback() {
            if self.outcome == RepresentationCompatibilityOutcome::Incompatible {
                return Ok(());
            }
            return Err(DagMlError::CampaignValidation(
                "fixed-width representation compatibility mismatch requires mask or pad policy/fallback"
                    .to_string(),
            ));
        }
        if self.cartesian_combo_count_changed && !self.final_reducer_stabilizes_output {
            if self.outcome == RepresentationCompatibilityOutcome::Incompatible {
                return Ok(());
            }
            return Err(DagMlError::CampaignValidation(
                "cartesian representation combo count may vary only when final reducer stabilizes output"
                    .to_string(),
            ));
        }
        if self.late_fusion_branch_delta && !self.allows_late_fusion_delta() {
            if self.outcome == RepresentationCompatibilityOutcome::Incompatible {
                return Ok(());
            }
            return Err(DagMlError::CampaignValidation(
                "late-fusion source deltas require an explicit drop/impute/mask/partial-model/pad policy or fallback"
                    .to_string(),
            ));
        }
        Ok(())
    }

    fn allows_fixed_width_fallback(&self) -> bool {
        matches!(
            self.policy,
            RepresentationMissingSourcePolicy::Mask | RepresentationMissingSourcePolicy::Pad
        ) || self
            .fallback_used
            .as_deref()
            .is_some_and(|fallback| matches!(fallback, "mask" | "pad"))
    }

    fn allows_late_fusion_delta(&self) -> bool {
        matches!(
            self.policy,
            RepresentationMissingSourcePolicy::DropIncomplete
                | RepresentationMissingSourcePolicy::ImputeDeclared
                | RepresentationMissingSourcePolicy::Mask
                | RepresentationMissingSourcePolicy::PartialModel
                | RepresentationMissingSourcePolicy::Pad
        ) || self.fallback_used.as_deref().is_some_and(|fallback| {
            matches!(
                fallback,
                "drop_incomplete" | "impute_declared" | "mask" | "partial_model" | "pad"
            )
        })
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct RepresentationReplayManifest {
    pub manifest_id: String,
    pub representation_plan: RepresentationPlan,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub combination_plan: Option<CombinationPlan>,
    pub output_unit_level: EntityUnitLevel,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub output_representation: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub relation_fingerprint: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub feature_schema_fingerprint: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub final_reduction_id: Option<String>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub sample_observation_mapping: Vec<RepresentationSampleObservationMapping>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub combo_selection: Vec<RepresentationComboSelectionRecord>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub qc_policy_refs: Vec<String>,
    #[serde(default, skip_serializing_if = "Vec::is_empty")]
    pub outlier_policy_refs: Vec<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub missing_source_policy: Option<RepresentationMissingSourcePolicy>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub missing_repetition_policy: Option<RepresentationMissingSourcePolicy>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub prediction_representation: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub final_output_unit_level: Option<EntityUnitLevel>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub train_compatibility: Option<RepresentationCompatibilityReport>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub predict_compatibility: Option<RepresentationCompatibilityReport>,
    #[serde(default, skip_serializing_if = "BTreeMap::is_empty")]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl RepresentationReplayManifest {
    pub fn validate(&self) -> Result<()> {
        validate_non_empty("representation replay manifest_id", &self.manifest_id)?;
        self.representation_plan.validate()?;
        if let Some(combination_plan) = &self.combination_plan {
            combination_plan.validate()?;
        }
        if self.output_unit_level != self.representation_plan.output_unit_level() {
            return Err(DagMlError::CampaignValidation(
                "representation replay output_unit_level must match representation_plan"
                    .to_string(),
            ));
        }
        validate_optional_non_empty(
            "representation replay output_representation",
            &self.output_representation,
        )?;
        validate_optional_non_empty(
            "representation replay final_reduction_id",
            &self.final_reduction_id,
        )?;
        validate_string_list_entries("representation replay qc_policy_refs", &self.qc_policy_refs)?;
        validate_unique_strings("representation replay qc_policy_refs", &self.qc_policy_refs)?;
        validate_string_list_entries(
            "representation replay outlier_policy_refs",
            &self.outlier_policy_refs,
        )?;
        validate_unique_strings(
            "representation replay outlier_policy_refs",
            &self.outlier_policy_refs,
        )?;
        validate_optional_non_empty(
            "representation replay prediction_representation",
            &self.prediction_representation,
        )?;
        let mut sample_source_pairs = BTreeSet::new();
        for mapping in &self.sample_observation_mapping {
            mapping.validate()?;
            if !sample_source_pairs.insert((
                mapping.physical_sample_id.as_str(),
                mapping.source_id.as_str(),
            )) {
                return Err(DagMlError::CampaignValidation(format!(
                    "representation replay sample_observation_mapping contains duplicate physical_sample_id/source_id `{}`/`{}`",
                    mapping.physical_sample_id, mapping.source_id
                )));
            }
        }
        let mut combo_unit_ids = BTreeSet::new();
        for record in &self.combo_selection {
            record.validate()?;
            if !combo_unit_ids.insert(record.combo_unit_id.as_str()) {
                return Err(DagMlError::CampaignValidation(format!(
                    "representation replay combo_selection contains duplicate combo_unit_id `{}`",
                    record.combo_unit_id
                )));
            }
        }
        if let Some(report) = &self.train_compatibility {
            report.validate()?;
        }
        if let Some(report) = &self.predict_compatibility {
            report.validate()?;
        }
        if let Some(fingerprint) = &self.relation_fingerprint {
            validate_fingerprint("representation replay relation", fingerprint)?;
        }
        if let Some(fingerprint) = &self.feature_schema_fingerprint {
            validate_fingerprint("representation replay feature schema", fingerprint)?;
        }
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "representation replay metadata contains an empty key".to_string(),
                ));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct ModelInputFusionPolicy {
    pub mode: ModelInputFusionMode,
    #[serde(default)]
    pub alignment: Option<String>,
    #[serde(default)]
    pub adapter_id: Option<String>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub representation_plan: Option<RepresentationPlan>,
    #[serde(default)]
    pub params: BTreeMap<String, serde_json::Value>,
}

impl ModelInputFusionPolicy {
    pub fn validate(&self) -> Result<()> {
        if self
            .alignment
            .as_ref()
            .is_some_and(|alignment| alignment.trim().is_empty())
        {
            return Err(DagMlError::CampaignValidation(
                "model input fusion policy has empty alignment".to_string(),
            ));
        }
        if self
            .adapter_id
            .as_ref()
            .is_some_and(|adapter_id| adapter_id.trim().is_empty())
        {
            return Err(DagMlError::CampaignValidation(
                "model input fusion policy has empty adapter_id".to_string(),
            ));
        }
        if self.mode == ModelInputFusionMode::Custom && self.adapter_id.is_none() {
            return Err(DagMlError::CampaignValidation(
                "custom model input fusion policy requires adapter_id".to_string(),
            ));
        }
        if let Some(representation_plan) = &self.representation_plan {
            representation_plan.validate()?;
        }
        for key in self.params.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "model input fusion policy contains an empty param key".to_string(),
                ));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct ModelInputPortSpec {
    pub name: String,
    pub accepted_representations: Vec<String>,
    pub accepted_types: Vec<String>,
    #[serde(default)]
    pub rank: Option<u32>,
    #[serde(default)]
    pub multi_source: bool,
    #[serde(default)]
    pub optional: bool,
    #[serde(default)]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl ModelInputPortSpec {
    pub fn validate(&self) -> Result<()> {
        validate_non_empty("model input port name", &self.name)?;
        validate_non_empty_list(
            "model input port accepted_representations",
            &self.accepted_representations,
        )?;
        validate_non_empty_list("model input port accepted_types", &self.accepted_types)?;
        validate_unique_strings(
            "model input port accepted_representations",
            &self.accepted_representations,
        )?;
        validate_unique_strings("model input port accepted_types", &self.accepted_types)?;
        if self.rank.is_some_and(|rank| rank > 16) {
            return Err(DagMlError::CampaignValidation(format!(
                "model input port `{}` rank must be <= 16",
                self.name
            )));
        }
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "model input port `{}` contains an empty metadata key",
                    self.name
                )));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct ModelInputSpec {
    #[serde(default = "default_model_input_spec_schema_version")]
    pub schema_version: u32,
    pub ports: Vec<ModelInputPortSpec>,
    #[serde(default)]
    pub default_fusion: Option<ModelInputFusionPolicy>,
    #[serde(default, skip_serializing_if = "Option::is_none")]
    pub fit_influence_policy: Option<FitInfluencePolicy>,
    #[serde(default)]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl ModelInputSpec {
    pub fn validate(&self) -> Result<()> {
        if self.schema_version != MODEL_INPUT_SPEC_SCHEMA_VERSION {
            return Err(DagMlError::CampaignValidation(format!(
                "model input spec uses unsupported schema_version {}, expected {}",
                self.schema_version, MODEL_INPUT_SPEC_SCHEMA_VERSION
            )));
        }
        if self.ports.is_empty() {
            return Err(DagMlError::CampaignValidation(
                "model input spec must declare at least one port".to_string(),
            ));
        }
        let mut names = BTreeSet::new();
        for port in &self.ports {
            port.validate()?;
            if !names.insert(port.name.as_str()) {
                return Err(DagMlError::CampaignValidation(format!(
                    "model input spec contains duplicate port `{}`",
                    port.name
                )));
            }
        }
        if let Some(default_fusion) = &self.default_fusion {
            default_fusion.validate()?;
        }
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "model input spec contains an empty metadata key".to_string(),
                ));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Copy, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")]
pub enum DataPlanStepKind {
    Materialize,
    Adapt,
    Align,
    Join,
    Collate,
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct DataPlanStep {
    pub kind: DataPlanStepKind,
    #[serde(default)]
    pub inputs: Vec<String>,
    pub output: String,
    #[serde(default)]
    pub adapter_id: Option<String>,
    #[serde(default)]
    pub params: BTreeMap<String, serde_json::Value>,
}

impl DataPlanStep {
    pub fn validate(&self, previous_outputs: &BTreeSet<String>) -> Result<()> {
        validate_non_empty("data plan step output", &self.output)?;
        if self.kind != DataPlanStepKind::Materialize && self.inputs.is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data plan step `{}` requires at least one input",
                self.output
            )));
        }
        for (index, input) in self.inputs.iter().enumerate() {
            validate_non_empty("data plan step input", input)?;
            if self.kind != DataPlanStepKind::Materialize && !previous_outputs.contains(input) {
                return Err(DagMlError::CampaignValidation(format!(
                    "data plan step `{}` input #{index} references `{input}` before it is produced",
                    self.output
                )));
            }
        }
        if self
            .adapter_id
            .as_ref()
            .is_some_and(|adapter_id| adapter_id.trim().is_empty())
        {
            return Err(DagMlError::CampaignValidation(format!(
                "data plan step `{}` has empty adapter_id",
                self.output
            )));
        }
        for key in self.params.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "data plan step `{}` contains an empty param key",
                    self.output
                )));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
#[serde(deny_unknown_fields)]
pub struct DataPlan {
    #[serde(default = "default_data_plan_schema_version")]
    pub schema_version: u32,
    pub id: String,
    pub steps: Vec<DataPlanStep>,
    pub output_ports: BTreeMap<String, String>,
    #[serde(default)]
    pub warnings: Vec<String>,
    #[serde(default)]
    pub requires_user_choice: Vec<String>,
    #[serde(default)]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl DataPlan {
    pub fn validate(&self) -> Result<()> {
        if self.schema_version != DATA_PLAN_SCHEMA_VERSION {
            return Err(DagMlError::CampaignValidation(format!(
                "data plan uses unsupported schema_version {}, expected {}",
                self.schema_version, DATA_PLAN_SCHEMA_VERSION
            )));
        }
        validate_non_empty("data plan id", &self.id)?;
        if self.steps.is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data plan `{}` must contain at least one step",
                self.id
            )));
        }
        let mut outputs = BTreeSet::new();
        for step in &self.steps {
            step.validate(&outputs)?;
            if !outputs.insert(step.output.clone()) {
                return Err(DagMlError::CampaignValidation(format!(
                    "data plan `{}` contains duplicate step output `{}`",
                    self.id, step.output
                )));
            }
        }
        if self.output_ports.is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data plan `{}` must declare at least one output port",
                self.id
            )));
        }
        for (port_name, output) in &self.output_ports {
            validate_non_empty("data plan output port", port_name)?;
            validate_non_empty("data plan output reference", output)?;
            if !outputs.contains(output) {
                return Err(DagMlError::CampaignValidation(format!(
                    "data plan `{}` output port `{port_name}` references unknown output `{output}`",
                    self.id
                )));
            }
        }
        validate_string_list_entries("data plan warnings", &self.warnings)?;
        validate_string_list_entries("data plan requires_user_choice", &self.requires_user_choice)?;
        for key in self.metadata.keys() {
            if key.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "data plan `{}` contains an empty metadata key",
                    self.id
                )));
            }
        }
        Ok(())
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
pub struct DataViewPolicy {
    #[serde(default = "default_fit_partition")]
    pub fit_partition: DataRequestPartition,
    #[serde(default = "default_predict_partition")]
    pub predict_partition: DataRequestPartition,
    #[serde(default)]
    pub include_augmented_train: bool,
    #[serde(default)]
    pub include_augmented_validation: bool,
    #[serde(default)]
    pub include_excluded: bool,
    #[serde(default = "default_true")]
    pub require_sample_ids: bool,
    #[serde(default, skip_serializing_if = "BTreeSet::is_empty")]
    pub unsafe_flags: BTreeSet<String>,
}

impl Default for DataViewPolicy {
    fn default() -> Self {
        Self {
            fit_partition: DataRequestPartition::FoldTrain,
            predict_partition: DataRequestPartition::FoldValidation,
            include_augmented_train: true,
            include_augmented_validation: false,
            include_excluded: false,
            require_sample_ids: true,
            unsafe_flags: BTreeSet::new(),
        }
    }
}

impl DataViewPolicy {
    pub const ALLOW_FIT_CV_FULL_TRAIN_VIEW: &'static str = "allow_fit_cv_full_train_view";
    pub const ALLOW_FIT_CV_VALIDATION_VIEW: &'static str = "allow_fit_cv_validation_view";
    pub const ALLOW_AUGMENTED_VALIDATION_VIEW: &'static str = "allow_augmented_validation_view";
    pub const ALLOW_EXCLUDED_ROWS: &'static str = "allow_excluded_rows";

    pub fn validate(&self) -> Result<()> {
        for unsafe_flag in &self.unsafe_flags {
            if unsafe_flag.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(
                    "data view policy contains an empty unsafe flag".to_string(),
                ));
            }
        }
        match self.fit_partition {
            DataRequestPartition::FoldTrain => {}
            DataRequestPartition::FullTrain
                if self
                    .unsafe_flags
                    .contains(Self::ALLOW_FIT_CV_FULL_TRAIN_VIEW) => {}
            DataRequestPartition::FoldValidation
                if self
                    .unsafe_flags
                    .contains(Self::ALLOW_FIT_CV_VALIDATION_VIEW) => {}
            DataRequestPartition::FullTrain => {
                return Err(DagMlError::CampaignValidation(
                    "data view policy fit_partition=full_train would leak validation rows during FIT_CV; add explicit unsafe flag allow_fit_cv_full_train_view".to_string(),
                ));
            }
            DataRequestPartition::FoldValidation => {
                return Err(DagMlError::CampaignValidation(
                    "data view policy fit_partition=fold_validation would train on validation rows during FIT_CV; add explicit unsafe flag allow_fit_cv_validation_view".to_string(),
                ));
            }
            DataRequestPartition::Predict => {
                return Err(DagMlError::CampaignValidation(
                    "data view policy fit_partition=predict is not valid for FIT_CV".to_string(),
                ));
            }
        }
        match self.predict_partition {
            DataRequestPartition::FoldValidation | DataRequestPartition::Predict => {}
            DataRequestPartition::FoldTrain | DataRequestPartition::FullTrain => {
                return Err(DagMlError::CampaignValidation(format!(
                    "data view policy predict_partition={:?} is not valid for validation/predict views",
                    self.predict_partition
                )));
            }
        }
        if self.include_augmented_validation
            && !self
                .unsafe_flags
                .contains(Self::ALLOW_AUGMENTED_VALIDATION_VIEW)
        {
            return Err(DagMlError::CampaignValidation(
                "data view policy include_augmented_validation=true can leak augmented validation/test rows; add explicit unsafe flag allow_augmented_validation_view".to_string(),
            ));
        }
        if self.include_excluded && !self.unsafe_flags.contains(Self::ALLOW_EXCLUDED_ROWS) {
            return Err(DagMlError::CampaignValidation(
                "data view policy include_excluded=true requires explicit unsafe flag allow_excluded_rows".to_string(),
            ));
        }
        Ok(())
    }
}

fn default_fit_partition() -> DataRequestPartition {
    DataRequestPartition::FoldTrain
}

fn default_predict_partition() -> DataRequestPartition {
    DataRequestPartition::FoldValidation
}

fn default_true() -> bool {
    true
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
pub struct DataBinding {
    pub node_id: NodeId,
    pub input_name: String,
    pub request_id: String,
    pub schema_fingerprint: String,
    pub plan_fingerprint: String,
    #[serde(default)]
    pub relation_fingerprint: Option<String>,
    pub output_representation: String,
    #[serde(default)]
    pub feature_set_id: Option<String>,
    #[serde(default)]
    pub source_ids: Vec<String>,
    #[serde(default)]
    pub require_relations: bool,
    #[serde(default)]
    pub view_policy: DataViewPolicy,
    #[serde(default)]
    pub metadata: BTreeMap<String, serde_json::Value>,
}

impl DataBinding {
    pub fn validate(&self) -> Result<()> {
        self.view_policy.validate()?;
        if self.input_name.trim().is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding for `{}` has empty input_name",
                self.node_id
            )));
        }
        if self.request_id.trim().is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` has empty request_id",
                self.input_name, self.node_id
            )));
        }
        validate_fingerprint("schema", &self.schema_fingerprint)?;
        validate_fingerprint("plan", &self.plan_fingerprint)?;
        if let Some(relation_fingerprint) = &self.relation_fingerprint {
            validate_fingerprint("relation", relation_fingerprint)?;
        } else if self.require_relations {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` requires relations but has no relation_fingerprint",
                self.input_name, self.node_id
            )));
        }
        if self.output_representation.trim().is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` has empty output_representation",
                self.input_name, self.node_id
            )));
        }
        if let Some(feature_set_id) = &self.feature_set_id {
            if feature_set_id.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "data binding `{}` on `{}` has empty feature_set_id",
                    self.input_name, self.node_id
                )));
            }
        }
        for source_id in &self.source_ids {
            if source_id.trim().is_empty() {
                return Err(DagMlError::CampaignValidation(format!(
                    "data binding `{}` on `{}` has empty source id",
                    self.input_name, self.node_id
                )));
            }
        }
        Ok(())
    }

    pub fn feature_set_id(&self) -> &str {
        self.feature_set_id.as_deref().unwrap_or(&self.input_name)
    }

    pub fn validate_envelope(&self, envelope: &ExternalDataPlanEnvelope) -> Result<()> {
        self.validate()?;
        envelope.validate()?;
        if self.schema_fingerprint != envelope.schema_fingerprint {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` schema fingerprint mismatch",
                self.input_name, self.node_id
            )));
        }
        if self.plan_fingerprint != envelope.plan_fingerprint {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` plan fingerprint mismatch",
                self.input_name, self.node_id
            )));
        }
        if self.relation_fingerprint != envelope.relation_fingerprint {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` relation fingerprint mismatch",
                self.input_name, self.node_id
            )));
        }
        if self.require_relations && envelope.coordinator_relations.is_none() {
            return Err(DagMlError::CampaignValidation(format!(
                "data binding `{}` on `{}` requires coordinator relations",
                self.input_name, self.node_id
            )));
        }
        Ok(())
    }
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub struct ExternalDataPlanEnvelope {
    #[serde(default = "default_external_data_plan_envelope_schema_version")]
    pub schema_version: u32,
    pub schema_fingerprint: String,
    pub plan_fingerprint: String,
    #[serde(default)]
    pub relation_fingerprint: Option<String>,
    #[serde(default)]
    pub coordinator_relations: Option<SampleRelationSet>,
}

impl ExternalDataPlanEnvelope {
    pub fn validate(&self) -> Result<()> {
        if self.schema_version != EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION {
            return Err(DagMlError::CampaignValidation(format!(
                "external data-plan envelope uses unsupported schema_version {}, expected {}",
                self.schema_version, EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION
            )));
        }
        validate_fingerprint("schema", &self.schema_fingerprint)?;
        validate_fingerprint("plan", &self.plan_fingerprint)?;
        if let Some(relation_fingerprint) = &self.relation_fingerprint {
            validate_fingerprint("relation", relation_fingerprint)?;
            if self.coordinator_relations.is_none() {
                return Err(DagMlError::CampaignValidation(
                    "relation_fingerprint requires coordinator_relations".to_string(),
                ));
            }
        }
        if let Some(relations) = &self.coordinator_relations {
            relations.validate()?;
        }
        Ok(())
    }
}

pub fn validate_data_binding_envelope(
    binding: &DataBinding,
    envelope: &ExternalDataPlanEnvelope,
) -> Result<()> {
    binding.validate_envelope(envelope)
}

#[derive(Clone, Debug, Eq, PartialEq, Ord, PartialOrd, Serialize, Deserialize)]
struct DataEnvelopeKey {
    schema_fingerprint: String,
    plan_fingerprint: String,
    relation_fingerprint: Option<String>,
}

impl DataEnvelopeKey {
    fn from_binding(binding: &DataBinding) -> Self {
        Self {
            schema_fingerprint: binding.schema_fingerprint.clone(),
            plan_fingerprint: binding.plan_fingerprint.clone(),
            relation_fingerprint: binding.relation_fingerprint.clone(),
        }
    }

    fn from_envelope(envelope: &ExternalDataPlanEnvelope) -> Self {
        Self {
            schema_fingerprint: envelope.schema_fingerprint.clone(),
            plan_fingerprint: envelope.plan_fingerprint.clone(),
            relation_fingerprint: envelope.relation_fingerprint.clone(),
        }
    }
}

#[derive(Clone, Debug, Eq, PartialEq, Serialize, Deserialize)]
pub struct DataHandleRecord {
    pub handle: HandleRef,
    pub run_id: RunId,
    pub node_id: NodeId,
    pub input_name: String,
    pub phase: Phase,
    pub variant_id: Option<VariantId>,
    pub fold_id: Option<FoldId>,
    pub request_id: String,
    pub schema_fingerprint: String,
    pub plan_fingerprint: String,
    pub relation_fingerprint: Option<String>,
    pub output_representation: String,
    #[serde(default)]
    pub feature_set_id: Option<String>,
    #[serde(default)]
    pub source_ids: Vec<String>,
    pub relation_record_count: Option<usize>,
}

#[derive(Clone, Debug, PartialEq, Serialize, Deserialize)]
pub struct DataViewHandleRecord {
    pub handle: HandleRef,
    pub parent_handle: HandleRef,
    pub run_id: RunId,
    pub node_id: NodeId,
    pub input_name: String,
    pub phase: Phase,
    pub variant_id: Option<VariantId>,
    pub fold_id: Option<FoldId>,
    pub request_id: String,
    pub feature_set_id: String,
    pub view: DataProviderViewSpec,
}

#[derive(Debug)]
pub struct InMemoryDataProvider {
    owner_controller: ControllerId,
    envelopes: BTreeMap<DataEnvelopeKey, ExternalDataPlanEnvelope>,
    next_handle: RefCell<u64>,
    records: RefCell<BTreeMap<u64, DataHandleRecord>>,
    view_records: RefCell<BTreeMap<u64, DataViewHandleRecord>>,
}

impl InMemoryDataProvider {
    pub fn new(owner_controller: ControllerId) -> Self {
        Self {
            owner_controller,
            envelopes: BTreeMap::new(),
            next_handle: RefCell::new(1),
            records: RefCell::new(BTreeMap::new()),
            view_records: RefCell::new(BTreeMap::new()),
        }
    }

    pub fn with_envelope(
        owner_controller: ControllerId,
        envelope: ExternalDataPlanEnvelope,
    ) -> Result<Self> {
        let mut provider = Self::new(owner_controller);
        provider.register_envelope(envelope)?;
        Ok(provider)
    }

    pub fn register_envelope(&mut self, envelope: ExternalDataPlanEnvelope) -> Result<()> {
        envelope.validate()?;
        let key = DataEnvelopeKey::from_envelope(&envelope);
        if let Some(existing) = self.envelopes.get(&key) {
            if existing == &envelope {
                return Ok(());
            }
            return Err(DagMlError::RuntimeValidation(
                "duplicate external data-plan envelope with different payload".to_string(),
            ));
        }
        self.envelopes.insert(key, envelope);
        Ok(())
    }

    pub fn handle_record(&self, handle: u64) -> Option<DataHandleRecord> {
        self.records.borrow().get(&handle).cloned()
    }

    pub fn handle_records(&self) -> Vec<DataHandleRecord> {
        self.records.borrow().values().cloned().collect()
    }

    pub fn view_record(&self, handle: u64) -> Option<DataViewHandleRecord> {
        self.view_records.borrow().get(&handle).cloned()
    }

    pub fn view_records(&self) -> Vec<DataViewHandleRecord> {
        self.view_records.borrow().values().cloned().collect()
    }

    fn next_handle(&self) -> u64 {
        let mut next = self.next_handle.borrow_mut();
        let handle = *next;
        *next += 1;
        handle
    }
}

impl RuntimeDataProvider for InMemoryDataProvider {
    fn materialize(&self, request: &DataMaterializationRequest) -> Result<HandleRef> {
        if request.node_id != request.binding.node_id {
            return Err(DagMlError::RuntimeValidation(format!(
                "data materialization request node `{}` does not match binding node `{}`",
                request.node_id, request.binding.node_id
            )));
        }
        if request.input_name != request.binding.input_name {
            return Err(DagMlError::RuntimeValidation(format!(
                "data materialization request input `{}` does not match binding input `{}`",
                request.input_name, request.binding.input_name
            )));
        }
        let envelope = self
            .envelopes
            .get(&DataEnvelopeKey::from_binding(&request.binding))
            .ok_or_else(|| {
                DagMlError::RuntimeValidation(format!(
                    "no external data-plan envelope registered for binding `{}` on `{}`",
                    request.binding.input_name, request.binding.node_id
                ))
            })?;
        request.binding.validate_envelope(envelope)?;

        let handle = HandleRef {
            handle: self.next_handle(),
            kind: HandleKind::Data,
            owner_controller: self.owner_controller.clone(),
        };
        let record = DataHandleRecord {
            handle: handle.clone(),
            run_id: request.run_id.clone(),
            node_id: request.node_id.clone(),
            input_name: request.input_name.clone(),
            phase: request.phase,
            variant_id: request.variant_id.clone(),
            fold_id: request.fold_id.clone(),
            request_id: request.binding.request_id.clone(),
            schema_fingerprint: request.binding.schema_fingerprint.clone(),
            plan_fingerprint: request.binding.plan_fingerprint.clone(),
            relation_fingerprint: request.binding.relation_fingerprint.clone(),
            output_representation: request.binding.output_representation.clone(),
            feature_set_id: request.binding.feature_set_id.clone(),
            source_ids: request.binding.source_ids.clone(),
            relation_record_count: envelope
                .coordinator_relations
                .as_ref()
                .map(|relations| relations.records.len()),
        };
        self.records.borrow_mut().insert(handle.handle, record);
        Ok(handle)
    }

    fn make_view(&self, request: &DataViewRequest) -> Result<HandleRef> {
        request.view.validate()?;
        if request.node_id != request.binding.node_id {
            return Err(DagMlError::RuntimeValidation(format!(
                "data view request node `{}` does not match binding node `{}`",
                request.node_id, request.binding.node_id
            )));
        }
        if request.input_name != request.binding.input_name {
            return Err(DagMlError::RuntimeValidation(format!(
                "data view request input `{}` does not match binding input `{}`",
                request.input_name, request.binding.input_name
            )));
        }
        if request.data_handle.kind != HandleKind::Data {
            return Err(DagMlError::RuntimeValidation(format!(
                "data view request for `{}` on `{}` received non-data parent handle",
                request.input_name, request.node_id
            )));
        }
        let parent = self
            .records
            .borrow()
            .get(&request.data_handle.handle)
            .cloned()
            .ok_or_else(|| {
                DagMlError::RuntimeValidation(format!(
                    "unknown data handle `{}` for view request `{}` on `{}`",
                    request.data_handle.handle, request.input_name, request.node_id
                ))
            })?;
        if parent.handle != request.data_handle {
            return Err(DagMlError::RuntimeValidation(format!(
                "data view request parent handle `{}` does not match provider record",
                request.data_handle.handle
            )));
        }
        request.binding.validate()?;
        let handle = HandleRef {
            handle: self.next_handle(),
            kind: HandleKind::DataView,
            owner_controller: self.owner_controller.clone(),
        };
        let record = DataViewHandleRecord {
            handle: handle.clone(),
            parent_handle: request.data_handle.clone(),
            run_id: request.run_id.clone(),
            node_id: request.node_id.clone(),
            input_name: request.input_name.clone(),
            phase: request.phase,
            variant_id: request.variant_id.clone(),
            fold_id: request.fold_id.clone(),
            request_id: request.binding.request_id.clone(),
            feature_set_id: request.binding.feature_set_id().to_string(),
            view: request.view.clone(),
        };
        self.view_records.borrow_mut().insert(handle.handle, record);
        Ok(handle)
    }

    fn coordinator_relations(&self, binding: &DataBinding) -> Result<Option<SampleRelationSet>> {
        let envelope = self
            .envelopes
            .get(&DataEnvelopeKey::from_binding(binding))
            .ok_or_else(|| {
                DagMlError::RuntimeValidation(format!(
                    "no external data-plan envelope registered for binding `{}` on `{}`",
                    binding.input_name, binding.node_id
                ))
            })?;
        binding.validate_envelope(envelope)?;
        Ok(envelope.coordinator_relations.clone())
    }
}

fn validate_fingerprint(label: &str, value: &str) -> Result<()> {
    if value.len() != 64 || !value.bytes().all(|byte| byte.is_ascii_hexdigit()) {
        return Err(DagMlError::CampaignValidation(format!(
            "{label} fingerprint must be a 64-character hex digest"
        )));
    }
    Ok(())
}

fn validate_non_empty(label: &str, value: &str) -> Result<()> {
    if value.trim().is_empty() {
        return Err(DagMlError::CampaignValidation(format!(
            "{label} must be a non-empty string"
        )));
    }
    Ok(())
}

fn validate_optional_non_empty(label: &str, value: &Option<String>) -> Result<()> {
    if let Some(value) = value {
        validate_non_empty(label, value)?;
    }
    Ok(())
}

fn validate_combo_like_output(label: &str, unit_level: EntityUnitLevel) -> Result<()> {
    if matches!(
        unit_level,
        EntityUnitLevel::Combo | EntityUnitLevel::Observation
    ) {
        return Ok(());
    }
    Err(DagMlError::CampaignValidation(format!(
        "{label} representation output_unit_level must be combo or observation"
    )))
}

fn validate_non_empty_list(label: &str, values: &[String]) -> Result<()> {
    if values.is_empty() {
        return Err(DagMlError::CampaignValidation(format!(
            "{label} must be a non-empty list"
        )));
    }
    validate_string_list_entries(label, values)
}

fn validate_string_list_entries(label: &str, values: &[String]) -> Result<()> {
    for (index, value) in values.iter().enumerate() {
        if value.trim().is_empty() {
            return Err(DagMlError::CampaignValidation(format!(
                "{label}[{index}] must be a non-empty string"
            )));
        }
    }
    Ok(())
}

fn validate_unique_strings(label: &str, values: &[String]) -> Result<()> {
    let mut seen = BTreeSet::new();
    for value in values {
        if !seen.insert(value.as_str()) {
            return Err(DagMlError::CampaignValidation(format!(
                "{label} contains duplicate value `{value}`"
            )));
        }
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::ids::NodeId;
    use crate::runtime::DataMaterializationRequest;

    fn binding() -> DataBinding {
        DataBinding {
            node_id: NodeId::new("model:base").unwrap(),
            input_name: "x".to_string(),
            request_id: "nir-to-tabular".to_string(),
            schema_fingerprint: "f97b37872fa22134b508f98fd8e207e5b776b52594fb8f6f5c3e15bee212246b"
                .to_string(),
            plan_fingerprint: "7c5431d85574b3f337022fa5d25971d5b5cf445b90331b49938f573ff6901e4d"
                .to_string(),
            relation_fingerprint: Some(
                "a3a7e329df35db9f2883a17b8611b7fae6dcaa031875e3ec2c9be1b9e29cbe10".to_string(),
            ),
            output_representation: "tabular_numeric".to_string(),
            feature_set_id: Some("x".to_string()),
            source_ids: vec!["nir".to_string()],
            require_relations: true,
            view_policy: DataViewPolicy::default(),
            metadata: BTreeMap::new(),
        }
    }

    #[test]
    fn validates_data_binding_contract() {
        let binding = binding();
        binding.validate().unwrap();
        assert_eq!(binding.feature_set_id(), "x");
    }

    #[test]
    fn published_model_input_and_data_plan_schemas_declare_current_contract() {
        let model_input_schema: serde_json::Value = serde_json::from_str(include_str!(
            "../../../docs/contracts/model_input_spec.schema.json"
        ))
        .unwrap();
        assert_eq!(model_input_schema["$id"], MODEL_INPUT_SPEC_SCHEMA_ID);
        assert_eq!(
            model_input_schema["properties"]["schema_version"]["const"].as_u64(),
            Some(MODEL_INPUT_SPEC_SCHEMA_VERSION as u64)
        );
        assert!(model_input_schema["$defs"]["input_port"]["required"]
            .as_array()
            .unwrap()
            .iter()
            .any(|field| field.as_str() == Some("accepted_representations")));
        assert!(model_input_schema["$defs"]["fusion_policy"]["properties"]
            .as_object()
            .unwrap()
            .contains_key("representation_plan"));
        assert!(model_input_schema["$defs"]
            .as_object()
            .unwrap()
            .contains_key("combination_plan"));
        assert!(model_input_schema["$defs"]
            .as_object()
            .unwrap()
            .contains_key("representation_plan"));

        let data_plan_schema: serde_json::Value = serde_json::from_str(include_str!(
            "../../../docs/contracts/data_plan.schema.json"
        ))
        .unwrap();
        assert_eq!(data_plan_schema["$id"], DATA_PLAN_SCHEMA_ID);
        assert_eq!(
            data_plan_schema["properties"]["schema_version"]["const"].as_u64(),
            Some(DATA_PLAN_SCHEMA_VERSION as u64)
        );
        assert!(data_plan_schema["$defs"]["data_plan_step_kind"]["enum"]
            .as_array()
            .unwrap()
            .iter()
            .any(|kind| kind.as_str() == Some("collate")));
    }

    #[test]
    fn validates_model_input_and_data_plan_fixtures() {
        let model_input: ModelInputSpec = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/model_input_spec_tabular_regressor.json"
        ))
        .unwrap();
        model_input.validate().unwrap();
        assert_eq!(model_input.ports[0].rank, Some(2));
        assert!(model_input.ports[0].multi_source);

        let data_plan: DataPlan = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/data_plan_tabular_fusion.json"
        ))
        .unwrap();
        data_plan.validate().unwrap();
        assert_eq!(data_plan.output_ports.get("x").unwrap(), "x_collated");
    }

    #[test]
    fn data_plan_rejects_forward_step_references() {
        let data_plan = DataPlan {
            schema_version: DATA_PLAN_SCHEMA_VERSION,
            id: "data-plan:bad".to_string(),
            steps: vec![DataPlanStep {
                kind: DataPlanStepKind::Adapt,
                inputs: vec!["missing".to_string()],
                output: "adapted".to_string(),
                adapter_id: Some("adapter:adapt".to_string()),
                params: BTreeMap::new(),
            }],
            output_ports: BTreeMap::from([("x".to_string(), "adapted".to_string())]),
            warnings: Vec::new(),
            requires_user_choice: Vec::new(),
            metadata: BTreeMap::new(),
        };

        let error = data_plan.validate().unwrap_err().to_string();
        assert!(error.contains("before it is produced"));
    }

    #[test]
    fn data_view_policy_rejects_unsafe_fit_and_validation_augmentation_by_default() {
        let mut full_train_binding = binding();
        full_train_binding.view_policy.fit_partition = DataRequestPartition::FullTrain;
        let full_train_error = full_train_binding.validate().unwrap_err().to_string();
        assert!(
            full_train_error.contains("fit_partition=full_train"),
            "unexpected full-train error: {full_train_error}"
        );

        let mut augmented_validation_binding = binding();
        augmented_validation_binding
            .view_policy
            .include_augmented_validation = true;
        let augmented_error = augmented_validation_binding
            .validate()
            .unwrap_err()
            .to_string();
        assert!(
            augmented_error.contains("include_augmented_validation=true"),
            "unexpected augmented-validation error: {augmented_error}"
        );

        let mut excluded_binding = binding();
        excluded_binding.view_policy.include_excluded = true;
        let excluded_error = excluded_binding.validate().unwrap_err().to_string();
        assert!(
            excluded_error.contains("include_excluded=true"),
            "unexpected excluded-row error: {excluded_error}"
        );
    }

    #[test]
    fn data_view_policy_requires_explicit_unsafe_flags_for_debug_views() {
        let mut binding = binding();
        binding.view_policy.fit_partition = DataRequestPartition::FullTrain;
        binding.view_policy.include_augmented_validation = true;
        binding.view_policy.include_excluded = true;
        binding.view_policy.unsafe_flags = BTreeSet::from([
            DataViewPolicy::ALLOW_FIT_CV_FULL_TRAIN_VIEW.to_string(),
            DataViewPolicy::ALLOW_AUGMENTED_VALIDATION_VIEW.to_string(),
            DataViewPolicy::ALLOW_EXCLUDED_ROWS.to_string(),
        ]);

        binding.validate().unwrap();
    }

    #[test]
    fn validates_external_data_envelope_subset() {
        let envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_sample12.json"
        ))
        .unwrap();

        assert_eq!(
            envelope.schema_version,
            EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION
        );
        binding().validate_envelope(&envelope).unwrap();
    }

    #[test]
    fn validates_multisource_repetition_envelope_fixture() {
        let envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_multisource_repetitions.json"
        ))
        .unwrap();

        envelope.validate().unwrap();
        let relations = envelope.coordinator_relations.as_ref().unwrap();
        assert_eq!(relations.records.len(), 8);
        let source_counts = relations.records.iter().fold(
            BTreeMap::<String, usize>::new(),
            |mut counts, record| {
                if record.unit_level == EntityUnitLevel::Observation {
                    *counts
                        .entry(record.source_id.clone().expect("source_id"))
                        .or_default() += 1;
                }
                counts
            },
        );
        assert_eq!(source_counts["A"], 2);
        assert_eq!(source_counts["B"], 3);
        assert_eq!(source_counts["C"], 2);
        let combo = relations
            .records
            .iter()
            .find(|record| record.unit_level == EntityUnitLevel::Combo)
            .expect("relation-backed combo row");
        assert_eq!(combo.sample_id.as_str(), "sample:1");
        assert_eq!(
            combo.origin_sample_id.as_ref().unwrap().as_str(),
            combo.sample_id.as_str()
        );
        assert_eq!(combo.component_observation_ids.len(), 3);
        for source_id in ["A", "B", "C"] {
            assert!(combo
                .component_observation_ids
                .iter()
                .any(|observation_id| observation_id.as_str().contains(source_id)));
        }
        assert_eq!(
            relations
                .sample_for_observation(
                    &crate::ids::ObservationId::new("obs.s1.combo.A0.B0.C0").unwrap()
                )
                .unwrap()
                .as_str(),
            "sample:1"
        );
    }

    #[test]
    fn published_external_data_envelope_schema_declares_current_version() {
        let schema: serde_json::Value = serde_json::from_str(include_str!(
            "../../../docs/contracts/coordinator_data_plan_envelope.schema.json"
        ))
        .unwrap();

        assert_eq!(
            schema["properties"]["schema_version"]["const"].as_u64(),
            Some(EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION as u64)
        );
        assert!(schema["required"]
            .as_array()
            .unwrap()
            .iter()
            .any(|field| field.as_str() == Some("schema_version")));
    }

    #[test]
    fn refuses_unsupported_external_data_envelope_schema_version() {
        let mut envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_sample12.json"
        ))
        .unwrap();
        envelope.schema_version = EXTERNAL_DATA_PLAN_ENVELOPE_SCHEMA_VERSION + 1;

        assert!(binding().validate_envelope(&envelope).is_err());
    }

    #[test]
    fn refuses_envelope_fingerprint_mismatch() {
        let mut envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_sample12.json"
        ))
        .unwrap();
        envelope.plan_fingerprint = "0".repeat(64);

        assert!(binding().validate_envelope(&envelope).is_err());
    }

    #[test]
    fn in_memory_provider_materializes_validated_data_handles() {
        let envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_sample12.json"
        ))
        .unwrap();
        let provider = InMemoryDataProvider::with_envelope(
            ControllerId::new("controller:data.provider").unwrap(),
            envelope,
        )
        .unwrap();

        let handle = provider
            .materialize(&DataMaterializationRequest {
                run_id: RunId::new("run:data").unwrap(),
                node_id: NodeId::new("model:base").unwrap(),
                input_name: "x".to_string(),
                phase: Phase::FitCv,
                variant_id: Some(VariantId::new("variant:base").unwrap()),
                fold_id: Some(FoldId::new("fold:0").unwrap()),
                binding: binding(),
            })
            .unwrap();

        let record = provider.handle_record(handle.handle).unwrap();
        assert_eq!(record.input_name, "x");
        assert_eq!(record.relation_record_count, Some(4));
        assert_eq!(provider.handle_records().len(), 1);
    }

    #[test]
    fn in_memory_provider_registration_is_idempotent_for_same_envelope() {
        let envelope: ExternalDataPlanEnvelope = serde_json::from_str(include_str!(
            "../../../examples/fixtures/data/coordinator_data_plan_envelope_sample12.json"
        ))
        .unwrap();
        let mut provider =
            InMemoryDataProvider::new(ControllerId::new("controller:data.provider").unwrap());

        provider.register_envelope(envelope.clone()).unwrap();
        provider.register_envelope(envelope).unwrap();
    }

    #[test]
    fn in_memory_provider_refuses_unknown_envelope() {
        let provider =
            InMemoryDataProvider::new(ControllerId::new("controller:data.provider").unwrap());

        assert!(provider
            .materialize(&DataMaterializationRequest {
                run_id: RunId::new("run:data").unwrap(),
                node_id: NodeId::new("model:base").unwrap(),
                input_name: "x".to_string(),
                phase: Phase::FitCv,
                variant_id: None,
                fold_id: None,
                binding: binding(),
            })
            .is_err());
    }

    fn cartesian_combination() -> CombinationPlan {
        CombinationPlan {
            mode: CombinationMode::Cartesian,
            component_source_ids: vec!["source:a".to_string(), "source:b".to_string()],
            component_unit_ids: Vec::new(),
            match_key: None,
            reference_source_id: None,
            seed: None,
            cap: None,
            budget: Some(32),
            missing_source_policy: Some(RepresentationMissingSourcePolicy::Strict),
            metadata: BTreeMap::new(),
        }
    }

    fn compatibility_report() -> RepresentationCompatibilityReport {
        RepresentationCompatibilityReport {
            policy: RepresentationMissingSourcePolicy::Mask,
            outcome: RepresentationCompatibilityOutcome::CompatibleWithFallback,
            fallback_used: Some("mask".to_string()),
            warning_severity: Some(RepresentationCompatibilitySeverity::Warning),
            affected_source_count: 1,
            affected_repetition_count: 2,
            affected_sample_count: 3,
            train_relation_fingerprint: Some("c".repeat(64)),
            predict_relation_fingerprint: Some("d".repeat(64)),
            train_unit_count: Some(6),
            predict_unit_count: Some(4),
            fixed_width_required: true,
            final_reducer_stabilizes_output: true,
            cartesian_combo_count_changed: true,
            late_fusion_branch_delta: true,
            messages: vec!["mask fallback applied for missing source".to_string()],
            metadata: BTreeMap::new(),
        }
    }

    #[derive(serde::Deserialize)]
    #[serde(deny_unknown_fields)]
    struct D9GoldenFixture {
        schema_version: u32,
        golden_scenarios: Vec<D9GoldenScenario>,
    }

    #[derive(serde::Deserialize)]
    #[serde(deny_unknown_fields)]
    struct D9GoldenScenario {
        scenario_id: String,
        flow: Vec<String>,
        mock_phase_path: Vec<String>,
        representation_replay_manifest: RepresentationReplayManifest,
        assertions: Vec<String>,
    }

    #[test]
    fn d9_golden_multisource_repetition_manifests_validate() {
        let fixture: D9GoldenFixture = serde_json::from_str(include_str!(
            "../../../examples/fixtures/runtime/d9_golden_multisource_scenarios.json"
        ))
        .unwrap();
        assert_eq!(fixture.schema_version, 1);
        assert_eq!(fixture.golden_scenarios.len(), 7);

        let mut scenario_ids = BTreeSet::new();
        let mut has_same_repetition_replay = false;
        let mut has_changed_repetition_replay = false;
        let mut has_combo_meta_fit_influence = false;
        for scenario in &fixture.golden_scenarios {
            assert!(
                scenario_ids.insert(scenario.scenario_id.as_str()),
                "duplicate D9 scenario {}",
                scenario.scenario_id
            );
            assert!(!scenario.flow.is_empty());
            assert_eq!(scenario.mock_phase_path, ["fit_cv", "refit", "predict"]);
            assert!(!scenario.assertions.is_empty());

            let manifest = &scenario.representation_replay_manifest;
            manifest.validate().unwrap();
            assert_eq!(
                manifest.final_output_unit_level,
                Some(EntityUnitLevel::PhysicalSample),
                "{} must publish sample-level outputs",
                scenario.scenario_id
            );
            if manifest.output_unit_level == EntityUnitLevel::Combo {
                assert!(
                    manifest.final_reduction_id.is_some(),
                    "{} must declare combo-to-sample reduction",
                    scenario.scenario_id
                );
                assert!(
                    !manifest.combo_selection.is_empty(),
                    "{} must retain relation-backed combo identities",
                    scenario.scenario_id
                );
            }

            if let (Some(train), Some(predict)) = (
                &manifest.train_compatibility,
                &manifest.predict_compatibility,
            ) {
                has_same_repetition_replay |= train.train_unit_count == predict.predict_unit_count
                    && train.train_relation_fingerprint == predict.predict_relation_fingerprint;
                has_changed_repetition_replay |= train.train_unit_count
                    != predict.predict_unit_count
                    || train.train_relation_fingerprint != predict.predict_relation_fingerprint;
            }

            if scenario.scenario_id == "d9.combo_meta_post.relation_backed_adapters" {
                has_combo_meta_fit_influence = manifest
                    .metadata
                    .get("fit_influence_policy")
                    .is_some_and(|value| value == "equal_sample_influence");
            }
        }

        assert!(scenario_ids.contains("d9.per_source_aggregate.source_models.sample_reducer"));
        assert!(scenario_ids.contains("d9.late_fusion_by_source.prediction_join.meta_model"));
        assert!(scenario_ids.contains("d9.cartesian_full.model.combo_to_sample_reducer"));
        assert!(scenario_ids.contains("d9.cartesian_mc.deterministic_replay"));
        assert!(scenario_ids.contains("d9.stack_fixed.strict_cardinality"));
        assert!(scenario_ids.contains("d9.stack_padded_masked.missing_repetition"));
        assert!(scenario_ids.contains("d9.combo_meta_post.relation_backed_adapters"));
        assert!(has_same_repetition_replay);
        assert!(has_changed_repetition_replay);
        assert!(has_combo_meta_fit_influence);
    }

    #[test]
    fn representation_plan_validates_cartesian_and_monte_carlo_contracts() {
        let cartesian = RepresentationPlan::CartesianProduct(CartesianProductRepresentation {
            combination_plan: cartesian_combination(),
            output_unit_level: EntityUnitLevel::Combo,
            cardinality: RepresentationCardinality::ManyToMany,
            preserve_provenance: true,
        });
        cartesian.validate().unwrap();

        let monte_carlo =
            RepresentationPlan::MonteCarloCartesian(MonteCarloCartesianRepresentation {
                combination_plan: CombinationPlan {
                    mode: CombinationMode::SampleK,
                    component_source_ids: vec!["source:a".to_string(), "source:b".to_string()],
                    component_unit_ids: Vec::new(),
                    match_key: None,
                    reference_source_id: None,
                    seed: Some(42),
                    cap: Some(8),
                    budget: None,
                    missing_source_policy: Some(RepresentationMissingSourcePolicy::Warn),
                    metadata: BTreeMap::new(),
                },
                output_unit_level: EntityUnitLevel::Observation,
                cardinality: RepresentationCardinality::BoundedMany,
                preserve_provenance: true,
            });
        monte_carlo.validate().unwrap();

        let mut bad = cartesian_combination();
        bad.mode = CombinationMode::SampleK;
        bad.seed = Some(7);
        bad.cap = Some(0);
        assert!(bad.validate().is_err());
    }

    #[test]
    fn stack_representations_validate_cardinality_and_mask_policy() {
        let fixed = RepresentationPlan::StackFixed(StackFixedRepresentation {
            output_unit_level: EntityUnitLevel::SourceSample,
            cardinality: RepresentationCardinality::OneToMany,
            expected_cardinality: 3,
            component_source_ids: vec!["source:a".to_string(), "source:b".to_string()],
        });
        fixed.validate().unwrap();

        let padded = RepresentationPlan::StackPaddedMasked(StackPaddedMaskedRepresentation {
            output_unit_level: EntityUnitLevel::SourceSample,
            cardinality: RepresentationCardinality::BoundedMany,
            expected_cardinality: 4,
            missing_source_policy: RepresentationMissingSourcePolicy::Mask,
            requires_missing_masks: true,
            component_source_ids: vec!["source:a".to_string()],
        });
        padded.validate().unwrap();

        let bad = RepresentationPlan::StackPaddedMasked(StackPaddedMaskedRepresentation {
            output_unit_level: EntityUnitLevel::SourceSample,
            cardinality: RepresentationCardinality::BoundedMany,
            expected_cardinality: 4,
            missing_source_policy: RepresentationMissingSourcePolicy::ImputeDeclared,
            requires_missing_masks: false,
            component_source_ids: Vec::new(),
        });
        assert!(bad.validate().is_err());
    }

    #[test]
    fn representation_compatibility_report_enforces_missingness_policy() {
        compatibility_report().validate().unwrap();

        let strict = RepresentationCompatibilityReport {
            policy: RepresentationMissingSourcePolicy::Strict,
            outcome: RepresentationCompatibilityOutcome::Incompatible,
            fallback_used: None,
            warning_severity: None,
            affected_source_count: 1,
            affected_repetition_count: 0,
            affected_sample_count: 1,
            train_relation_fingerprint: None,
            predict_relation_fingerprint: None,
            train_unit_count: None,
            predict_unit_count: None,
            fixed_width_required: false,
            final_reducer_stabilizes_output: false,
            cartesian_combo_count_changed: false,
            late_fusion_branch_delta: false,
            messages: Vec::new(),
            metadata: BTreeMap::new(),
        };
        strict.validate().unwrap();

        let mut bad_non_strict = compatibility_report();
        bad_non_strict.fallback_used = None;
        assert!(bad_non_strict.validate().is_err());

        let mut bad_fixed_width = compatibility_report();
        bad_fixed_width.policy = RepresentationMissingSourcePolicy::ImputeDeclared;
        bad_fixed_width.fallback_used = Some("impute_declared".to_string());
        assert!(bad_fixed_width.validate().is_err());

        let mut bad_cartesian = compatibility_report();
        bad_cartesian.final_reducer_stabilizes_output = false;
        assert!(bad_cartesian.validate().is_err());

        let bad_relation_drift = RepresentationCompatibilityReport {
            policy: RepresentationMissingSourcePolicy::Strict,
            outcome: RepresentationCompatibilityOutcome::Compatible,
            fallback_used: None,
            warning_severity: None,
            affected_source_count: 0,
            affected_repetition_count: 0,
            affected_sample_count: 0,
            train_relation_fingerprint: Some("a".repeat(64)),
            predict_relation_fingerprint: Some("b".repeat(64)),
            train_unit_count: Some(3),
            predict_unit_count: Some(3),
            fixed_width_required: false,
            final_reducer_stabilizes_output: true,
            cartesian_combo_count_changed: false,
            late_fusion_branch_delta: false,
            messages: Vec::new(),
            metadata: BTreeMap::new(),
        };
        let error = bad_relation_drift.validate().unwrap_err().to_string();
        assert!(
            error.contains("relation fingerprint mismatch requires affected units"),
            "unexpected D9 relation drift error: {error}"
        );

        let mut bad_unit_drift = bad_relation_drift;
        bad_unit_drift.predict_relation_fingerprint =
            bad_unit_drift.train_relation_fingerprint.clone();
        bad_unit_drift.predict_unit_count = Some(2);
        let error = bad_unit_drift.validate().unwrap_err().to_string();
        assert!(
            error.contains("unit count mismatch requires affected units"),
            "unexpected D9 unit-count drift error: {error}"
        );
    }

    #[test]
    fn representation_replay_manifest_round_trips_and_validates() {
        let plan = RepresentationPlan::CartesianProduct(CartesianProductRepresentation {
            combination_plan: cartesian_combination(),
            output_unit_level: EntityUnitLevel::Combo,
            cardinality: RepresentationCardinality::ManyToMany,
            preserve_provenance: true,
        });
        let manifest = RepresentationReplayManifest {
            manifest_id: "repr:combo.ab".to_string(),
            representation_plan: plan,
            combination_plan: Some(cartesian_combination()),
            output_unit_level: EntityUnitLevel::Combo,
            output_representation: Some("combo_observation".to_string()),
            relation_fingerprint: Some("a".repeat(64)),
            feature_schema_fingerprint: Some("b".repeat(64)),
            final_reduction_id: Some("reduction:combo_to_sample".to_string()),
            sample_observation_mapping: vec![
                RepresentationSampleObservationMapping {
                    physical_sample_id: "sample:1".to_string(),
                    source_id: "source:a".to_string(),
                    observation_ids: vec!["obs:a.1".to_string(), "obs:a.2".to_string()],
                },
                RepresentationSampleObservationMapping {
                    physical_sample_id: "sample:1".to_string(),
                    source_id: "source:b".to_string(),
                    observation_ids: vec!["obs:b.1".to_string()],
                },
            ],
            combo_selection: vec![RepresentationComboSelectionRecord {
                combo_unit_id: "combo:sample1:a1:b1".to_string(),
                physical_sample_id: "sample:1".to_string(),
                component_observation_ids: vec!["obs:a.1".to_string(), "obs:b.1".to_string()],
                seed: Some(42),
            }],
            qc_policy_refs: vec!["qc:default".to_string()],
            outlier_policy_refs: vec!["outlier:none".to_string()],
            missing_source_policy: Some(RepresentationMissingSourcePolicy::Strict),
            missing_repetition_policy: Some(RepresentationMissingSourcePolicy::Warn),
            prediction_representation: Some("sample_prediction".to_string()),
            final_output_unit_level: Some(EntityUnitLevel::PhysicalSample),
            train_compatibility: Some(RepresentationCompatibilityReport {
                policy: RepresentationMissingSourcePolicy::Strict,
                outcome: RepresentationCompatibilityOutcome::Compatible,
                fallback_used: None,
                warning_severity: None,
                affected_source_count: 0,
                affected_repetition_count: 0,
                affected_sample_count: 0,
                train_relation_fingerprint: Some("a".repeat(64)),
                predict_relation_fingerprint: None,
                train_unit_count: Some(1),
                predict_unit_count: Some(1),
                fixed_width_required: false,
                final_reducer_stabilizes_output: true,
                cartesian_combo_count_changed: false,
                late_fusion_branch_delta: false,
                messages: Vec::new(),
                metadata: BTreeMap::new(),
            }),
            predict_compatibility: Some(compatibility_report()),
            metadata: BTreeMap::new(),
        };

        manifest.validate().unwrap();
        let encoded = serde_json::to_string(&manifest).unwrap();
        let decoded: RepresentationReplayManifest = serde_json::from_str(&encoded).unwrap();
        assert_eq!(decoded, manifest);
    }
}