1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
use std::sync::Arc;
use d_engine_proto::common::EntryPayload;
// Re-export LeaderInfo from proto (application layer use)
pub use d_engine_proto::common::LeaderInfo;
use d_engine_proto::server::election::VotedFor;
use tokio::sync::mpsc;
use tokio::sync::watch;
use tokio::time::sleep_until;
use tracing::debug;
use tracing::error;
use tracing::info;
use tracing::trace;
use tracing::warn;
use super::NewCommitData;
use super::RaftContext;
use super::RaftCoreHandlers;
use super::RaftEvent;
use super::RaftRole;
use super::RaftStorageHandles;
use super::RoleEvent;
#[cfg(test)]
use super::raft_event_to_test_event;
use crate::Membership;
use crate::NetworkError;
use crate::RaftLog;
use crate::RaftNodeConfig;
use crate::Result;
use crate::TypeConfig;
use crate::alias::MOF;
use crate::alias::TROF;
pub struct Raft<T>
where
T: TypeConfig,
{
pub node_id: u32,
pub role: RaftRole<T>,
pub ctx: RaftContext<T>,
// Network & Storage events
event_tx: mpsc::Sender<RaftEvent>,
event_rx: mpsc::Receiver<RaftEvent>,
// Client commands (drain-driven)
cmd_tx: mpsc::UnboundedSender<super::ClientCmd>,
cmd_rx: mpsc::UnboundedReceiver<super::ClientCmd>,
// Timer
role_tx: mpsc::UnboundedSender<RoleEvent>,
role_rx: mpsc::UnboundedReceiver<RoleEvent>,
// For business logic to apply logs into state machine
new_commit_listener: Vec<mpsc::UnboundedSender<NewCommitData>>,
// Leader change notification
// Uses watch::Sender for efficient multi-subscriber pattern
leader_change_listener: Option<watch::Sender<Option<LeaderInfo>>>,
// Shutdown signal
shutdown_signal: watch::Receiver<()>,
// For unit test
#[cfg(test)]
test_role_transition_listener: Vec<mpsc::UnboundedSender<i32>>,
#[cfg(test)]
test_raft_event_listener: Vec<mpsc::UnboundedSender<super::TestEvent>>,
}
pub struct SignalParams {
pub(crate) role_tx: mpsc::UnboundedSender<RoleEvent>,
pub(crate) role_rx: mpsc::UnboundedReceiver<RoleEvent>,
pub(crate) event_tx: mpsc::Sender<RaftEvent>,
pub(crate) event_rx: mpsc::Receiver<RaftEvent>,
pub(crate) cmd_tx: mpsc::UnboundedSender<super::ClientCmd>,
pub(crate) cmd_rx: mpsc::UnboundedReceiver<super::ClientCmd>,
pub(crate) shutdown_signal: watch::Receiver<()>,
}
impl SignalParams {
/// Creates a new SignalParams with the provided channels.
///
/// This is the only way to construct SignalParams from outside d-engine-core,
/// ensuring controlled initialization of the internal communication channels.
pub fn new(
role_tx: mpsc::UnboundedSender<RoleEvent>,
role_rx: mpsc::UnboundedReceiver<RoleEvent>,
event_tx: mpsc::Sender<RaftEvent>,
event_rx: mpsc::Receiver<RaftEvent>,
cmd_tx: mpsc::UnboundedSender<super::ClientCmd>,
cmd_rx: mpsc::UnboundedReceiver<super::ClientCmd>,
shutdown_signal: watch::Receiver<()>,
) -> Self {
Self {
role_tx,
role_rx,
event_tx,
event_rx,
cmd_tx,
cmd_rx,
shutdown_signal,
}
}
}
impl<T> Raft<T>
where
T: TypeConfig,
{
#[allow(clippy::too_many_arguments)]
pub fn new(
node_id: u32,
role: RaftRole<T>,
storage: RaftStorageHandles<T>,
transport: TROF<T>,
handlers: RaftCoreHandlers<T>,
membership: Arc<MOF<T>>,
signal_params: SignalParams,
node_config: Arc<RaftNodeConfig>,
) -> Self {
let ctx = Self::build_context(
node_id,
storage,
transport,
membership,
handlers,
node_config.clone(),
);
Raft {
node_id,
ctx,
role,
event_tx: signal_params.event_tx,
event_rx: signal_params.event_rx,
cmd_tx: signal_params.cmd_tx,
cmd_rx: signal_params.cmd_rx,
role_tx: signal_params.role_tx,
role_rx: signal_params.role_rx,
new_commit_listener: Vec::new(),
shutdown_signal: signal_params.shutdown_signal,
leader_change_listener: None,
#[cfg(test)]
test_role_transition_listener: Vec::new(),
#[cfg(test)]
test_raft_event_listener: Vec::new(),
}
}
/// Register a listener for leader election events.
///
/// The listener will receive LeaderInfo updates:
/// - Some(LeaderInfo) when a leader is elected
/// - None when no leader exists (during election)
///
/// # Performance
/// Event-driven notification (no polling), multi-subscriber support via watch channel
pub fn register_leader_change_listener(
&mut self,
tx: watch::Sender<Option<LeaderInfo>>,
) {
self.leader_change_listener = Some(tx);
}
/// Notify all leader change listeners.
///
/// Called internally when role transitions occur.
/// Uses send_if_modified to avoid redundant notifications.
fn notify_leader_change(
&self,
leader_id: Option<u32>,
term: u64,
) {
if let Some(tx) = &self.leader_change_listener {
tx.send_if_modified(|current| {
let new_info = leader_id.map(|id| LeaderInfo {
leader_id: id,
term,
});
if *current != new_info {
*current = new_info;
true
} else {
false
}
});
}
}
fn build_context(
id: u32,
storage: RaftStorageHandles<T>,
transport: TROF<T>,
membership: Arc<MOF<T>>,
handlers: RaftCoreHandlers<T>,
node_config: Arc<RaftNodeConfig>,
) -> RaftContext<T> {
RaftContext {
node_id: id,
storage,
transport: Arc::new(transport),
membership,
handlers,
node_config,
}
}
pub async fn join_cluster(&self) -> Result<()> {
self.role.join_cluster(&self.ctx).await
}
pub async fn run(&mut self) -> Result<()> {
// Add snapshot handler before main loop
if self.ctx.node_config.is_learner() {
info!(
"Node({}) is learner and needs to fetch initial snapshot.",
self.node_id
);
if let Err(e) = self.role.fetch_initial_snapshot(&self.ctx).await {
warn!(
"Initial snapshot failed: {:?}.
================================================
Leader has not generate snapshot yet. New node
will sync with Leader via append entries requests.
================================================
",
e
);
println!(
"
================================================
Leader has not generate snapshot yet. New node
will sync with Leader via append entries requests
================================================
"
);
}
}
info!("Node is running");
if self.role.is_timer_expired() {
self.role.reset_timer();
}
loop {
// Note: next_deadline wil be reset in each role's tick function
let tick = sleep_until(self.role.next_deadline());
tokio::select! {
// Use biased to ensure branch order
biased;
// P0: shutdown received;
_ = self.shutdown_signal.changed() => {
info!("[Raft:{}] shutdown signal received.", self.node_id);
return Ok(());
}
// P1: Tick: start Heartbeat(replication) or start Election
_ = tick => {
trace!("receive tick");
let role_tx = &self.role_tx;
let event_tx = &self.event_tx;
if let Err(e) = self.role.tick(role_tx, event_tx, &self.ctx).await {
error!("tick failed: {:?}", e);
} else {
trace!("tick success");
}
}
// P2: Role events
Some(role_event) = self.role_rx.recv() => {
debug!(%self.node_id, ?role_event, "receive role event");
if let Err(e) = self.handle_role_event(role_event).await {
error!(%self.node_id, ?e, "handle_role_event error");
}
}
// P3: Client commands (drain-driven batch with RPC merge)
Some(first_cmd) = self.cmd_rx.recv() => {
trace!(%self.node_id, "receive first client command");
// Push first command and drain rest (direct push for zero-copy)
self.role.push_client_cmd(first_cmd, &self.ctx);
// Drain all pending commands from channel (max_batch_size limit)
let max_batch = self.ctx.node_config.raft.batching.max_batch_size;
let mut count = 1;
while count < max_batch {
match self.cmd_rx.try_recv() {
Ok(cmd) => {
self.role.push_client_cmd(cmd, &self.ctx);
count += 1;
}
Err(_) => break,
}
}
trace!("Drained {} client commands", count);
// Flush buffers if thresholds reached
if let Err(e) = self.role.flush_cmd_buffers(&self.ctx, &self.role_tx).await {
error!(%self.node_id, ?e, "flush_cmd_buffers error");
return Err(e);
}
}
// P4: Other events
Some(raft_event) = self.event_rx.recv() => {
trace!(%self.node_id, ?raft_event, "receive raft event");
#[cfg(test)]
let event = raft_event_to_test_event(&raft_event);
if let Err(e) = self.role.handle_raft_event(raft_event, &self.ctx, self.role_tx.clone()).await {
error!(%self.node_id, ?e, "handle_raft_event error");
// Fatal errors from SM Worker will be caught here and propagated
return Err(e);
}
#[cfg(test)]
self.notify_raft_event(event);
}
}
}
}
/// `handle_role_event` will be responsbile to process role trasnsition and
/// role state events.
pub async fn handle_role_event(
&mut self,
role_event: RoleEvent,
) -> Result<()> {
// All inbound and outbound raft event
match role_event {
RoleEvent::BecomeFollower(leader_id_option) => {
// Drain read buffer when stepping down from Leader; skip otherwise.
let _ = self.role.drain_read_buffer();
debug!("BecomeFollower");
self.role = self.role.become_follower()?;
// Reset vote when stepping down (new term, no vote yet)
self.role.state_mut().reset_voted_for()?;
// Notify leader change listeners
let current_term = self.role.current_term();
self.notify_leader_change(leader_id_option, current_term);
#[cfg(test)]
self.notify_role_transition();
//TODO: update membership
}
RoleEvent::BecomeCandidate => {
// Drain read buffer when stepping down from Leader; skip otherwise.
let _ = self.role.drain_read_buffer();
debug!("BecomeCandidate");
self.role = self.role.become_candidate()?;
// No leader during candidate state
let current_term = self.role.current_term();
self.notify_leader_change(None, current_term);
#[cfg(test)]
self.notify_role_transition();
}
RoleEvent::BecomeLeader => {
debug!("BecomeLeader");
self.role = self.role.become_leader()?;
// Mark vote as committed (candidate → leader transition)
let current_term = self.role.current_term();
let _ = self.role.state_mut().update_voted_for(VotedFor {
voted_for_id: self.node_id,
voted_for_term: current_term,
committed: true,
})?;
let peer_ids = self.ctx.membership().get_peers_id_with_condition(|_| true).await;
self.role.init_peers_next_index_and_match_index(
self.ctx.raft_log().last_entry_id(),
peer_ids,
)?;
// Initialize cluster metadata cache for hot path optimization
self.role.state_mut().init_cluster_metadata(&self.ctx.membership()).await?;
//async action
if !self
.role
.verify_leadership_persistent(
vec![EntryPayload::noop()],
&self.ctx,
&self.role_tx,
)
.await
.unwrap_or(false)
{
warn!(
"Verify leadership in new term failed. Now the node is going to step back to Follower..."
);
self.role_tx.send(RoleEvent::BecomeFollower(None)).map_err(|e| {
let error_str = format!("{e:?}");
error!("Failed to send: {}", error_str);
NetworkError::SingalSendFailed(error_str)
})?;
} else {
// Track no-op index for linearizable read optimization (best-effort)
if let Err(e) = self.role.on_noop_committed(&self.ctx) {
warn!(
?e,
"Failed to track no-op commit index after leadership verification"
);
} else {
// Notify leader change listeners: this node is now leader
self.notify_leader_change(Some(self.node_id), current_term);
}
}
#[cfg(test)]
self.notify_role_transition();
}
RoleEvent::BecomeLearner => {
// Drain read buffer when stepping down from Leader; skip otherwise.
let _ = self.role.drain_read_buffer();
debug!("BecomeLearner");
self.role = self.role.become_learner()?;
// Learner has no leader initially
let current_term = self.role.current_term();
self.notify_leader_change(None, current_term);
#[cfg(test)]
self.notify_role_transition();
}
RoleEvent::NotifyNewCommitIndex(mut new_commit_data) => {
// Drain all pending NotifyNewCommitIndex events (max_batch_size limit)
// This batches multiple committed entries into a single notification
let max_batch = self.ctx.node_config.raft.batching.max_batch_size;
let mut count = 1;
while count < max_batch {
match self.role_rx.try_recv() {
Ok(RoleEvent::NotifyNewCommitIndex(next)) => {
// Only keep the largest commit_index
if next.new_commit_index > new_commit_data.new_commit_index {
new_commit_data = next;
}
count += 1;
}
Ok(other) => {
self.role_tx.send(other).map_err(|e| {
let error_str = format!("{e:?}");
error!("Failed to resend role event: {}", error_str);
crate::Error::Fatal(error_str)
})?;
break;
}
Err(_) => break,
}
}
debug!(
"[{}] NotifyNewCommitIndex drained: {} events, max_commit_index={}",
self.node_id, count, new_commit_data.new_commit_index
);
self.notify_new_commit(new_commit_data);
}
RoleEvent::LeaderDiscovered(leader_id, term) => {
debug!("LeaderDiscovered: leader_id={}, term={}", leader_id, term);
// Notify leader change listeners - no state transition
// Note: mpsc channels do not deduplicate; consumers handle dedup if needed
self.notify_leader_change(Some(leader_id), term);
}
RoleEvent::ReprocessEvent(raft_event) => {
info!("Replay the RaftEvent: {:?}", &raft_event);
self.event_tx.send(*raft_event).await.map_err(|e| {
let error_str = format!("{e:?}");
error!("Failed to send: {}", error_str);
NetworkError::SingalSendFailed(error_str)
})?;
}
};
Ok(())
}
pub fn register_new_commit_listener(
&mut self,
tx: mpsc::UnboundedSender<NewCommitData>,
) {
self.new_commit_listener.push(tx);
}
pub fn notify_new_commit(
&self,
new_commit_data: NewCommitData,
) {
debug!(?new_commit_data, "notify_new_commit",);
for tx in &self.new_commit_listener {
if let Err(e) = tx.send(new_commit_data.clone()) {
error!("notify_new_commit failed: {:?}", e);
}
}
}
#[cfg(test)]
pub fn register_role_transition_listener(
&mut self,
tx: mpsc::UnboundedSender<i32>,
) {
self.test_role_transition_listener.push(tx);
}
#[cfg(test)]
pub fn notify_role_transition(&self) {
let new_role_i32 = self.role.as_i32();
for tx in &self.test_role_transition_listener {
tx.send(new_role_i32).expect("should succeed");
}
}
#[cfg(test)]
pub fn register_raft_event_listener(
&mut self,
tx: mpsc::UnboundedSender<super::TestEvent>,
) {
self.test_raft_event_listener.push(tx);
}
#[cfg(test)]
pub fn notify_raft_event(
&self,
event: super::TestEvent,
) {
debug!("unit test:: notify new raft event: {:?}", &event);
for tx in &self.test_raft_event_listener {
assert!(tx.send(event.clone()).is_ok(), "should succeed");
}
}
#[cfg(test)]
pub fn set_role(
&mut self,
role: RaftRole<T>,
) {
self.role = role
}
/// Returns a cloned event sender for external use.
///
/// This provides controlled access to send validated RaftEvents to the Raft core.
/// Events sent through this sender are still processed through the normal validation
/// pipeline in the main event loop.
///
/// # Security Note
/// While this provides access to the event channel, all events are still validated
/// by the Raft state machine before being applied. The event handler in `handle_raft_event`
/// performs necessary checks based on current term, role, and state.
pub fn event_sender(&self) -> mpsc::Sender<RaftEvent> {
self.event_tx.clone()
}
pub fn cmd_sender(&self) -> mpsc::UnboundedSender<super::ClientCmd> {
self.cmd_tx.clone()
}
/// Returns a cloned role event sender for internal use.
///
/// # Warning
/// This is primarily for internal components that need to trigger role transitions.
/// External callers should not use this unless they understand the Raft protocol deeply.
#[doc(hidden)]
pub fn role_event_sender(&self) -> mpsc::UnboundedSender<RoleEvent> {
self.role_tx.clone()
}
}
impl<T> Drop for Raft<T>
where
T: TypeConfig,
{
fn drop(&mut self) {
info!("Raft been dropped.");
if let Err(e) = self
.ctx
.raft_log()
.save_hard_state(&self.role.state().shared_state().hard_state)
{
error!(?e, "State storage persist node hard state failed.");
}
info!("Graceful shutdown node state ...");
}
}