cypherlite-storage 1.2.1

Storage engine with WAL, B+Tree indexing, and ACID transactions for CypherLite
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
// PageManager: file format, page allocation, Free Space Map

use std::fs::{File, OpenOptions};
use std::io::{Read, Seek, SeekFrom, Write};
use std::path::PathBuf;

use cypherlite_core::{CypherLiteError, DatabaseConfig, PageId, Result};

use super::{DatabaseHeader, FORMAT_VERSION, FSM_PAGE_ID, MAGIC, PAGE_SIZE};

/// Manages the on-disk database file: page allocation, FSM, and raw I/O.
pub struct PageManager {
    file: File,
    header: DatabaseHeader,
    path: PathBuf,
    /// In-memory hint for the next likely free page ID.
    /// Avoids scanning already-used FSM bytes from the start on every allocation.
    next_free_hint: u32,
}

impl PageManager {
    /// Create a new database file with initial header and FSM pages.
    pub fn create_database(config: &DatabaseConfig) -> Result<Self> {
        let mut file = OpenOptions::new()
            .read(true)
            .write(true)
            .create_new(true)
            .open(&config.path)?;

        let header = DatabaseHeader::new();
        let header_page = header.to_page();
        file.write_all(&header_page)?;

        // Write empty FSM page (page 1) - all bits 0 = all pages free
        // But mark pages 0 and 1 as used (header + FSM)
        let mut fsm_page = [0u8; PAGE_SIZE];
        // Mark page 0 (header) and page 1 (FSM) as used
        fsm_page[0] = 0b0000_0011; // bits 0 and 1 set
        file.write_all(&fsm_page)?;

        file.sync_all()?;

        Ok(Self {
            file,
            header,
            path: config.path.clone(),
            next_free_hint: super::FIRST_DATA_PAGE,
        })
    }

    /// Open an existing database file, validating magic and version.
    pub fn open_database(config: &DatabaseConfig) -> Result<Self> {
        let mut file = OpenOptions::new()
            .read(true)
            .write(true)
            .open(&config.path)?;

        let mut header_buf = [0u8; PAGE_SIZE];
        file.read_exact(&mut header_buf)?;

        let header = DatabaseHeader::from_page(&header_buf);

        // REQ-PAGE-007: Validate magic number
        if header.magic != MAGIC {
            return Err(CypherLiteError::InvalidMagicNumber);
        }

        // REQ-PAGE-008: Validate version (accept older versions for auto-migration)
        if header.version == 0 || header.version > FORMAT_VERSION {
            return Err(CypherLiteError::UnsupportedVersion {
                found: header.version,
                supported: FORMAT_VERSION,
            });
        }

        // Auto-migrate old headers to current FORMAT_VERSION
        let mut header = header;
        if header.version < FORMAT_VERSION {
            // W-004: v1->v2 migration
            if header.version < 2 {
                header.version_store_root_page = 0;
            }
            // AA-T3: v2->v3 migration: feature_flags defaults to temporal-core
            // (from_page already sets this for version < 3)
            // GG-003: v3->v4 migration: subgraph fields default to 0
            // (from_page already sets subgraph_root_page=0, next_subgraph_id=0 for version < 4)
            header.version = FORMAT_VERSION;
        }

        // AA-T4: Feature compatibility check
        let compiled = super::DatabaseHeader::compiled_feature_flags();
        let db_flags = header.feature_flags;
        // If the database requires features we don't have compiled in, reject
        if (db_flags & !compiled) != 0 {
            return Err(CypherLiteError::FeatureIncompatible {
                db_flags,
                compiled_flags: compiled,
            });
        }

        Ok(Self {
            file,
            header,
            path: config.path.clone(),
            next_free_hint: super::FIRST_DATA_PAGE,
        })
    }

    /// Allocate a new page by finding the first free bit in the FSM.
    /// REQ-PAGE-004: Find first free bit in FSM.
    /// REQ-S-003: Uses next_free_hint to skip already-used pages.
    pub fn allocate_page(&mut self) -> Result<PageId> {
        let mut fsm_buf = [0u8; PAGE_SIZE];
        self.read_page_raw(FSM_PAGE_ID, &mut fsm_buf)?;

        let start_byte = (self.next_free_hint / 8) as usize;

        // Phase 1: Scan from hint position
        if let Some(page_id) = Self::find_free_page(&fsm_buf, start_byte) {
            return self.complete_allocation(&mut fsm_buf, page_id);
        }

        // Phase 2: Wrap around - scan from 0 if hint was past the start
        if start_byte > 0 {
            if let Some(page_id) = Self::find_free_page(&fsm_buf, 0) {
                return self.complete_allocation(&mut fsm_buf, page_id);
            }
        }

        Err(CypherLiteError::OutOfSpace)
    }

    /// Scan FSM bitmap from `start_byte` for the first free bit.
    fn find_free_page(fsm_buf: &[u8; PAGE_SIZE], start_byte: usize) -> Option<u32> {
        for (offset, byte_val) in fsm_buf[start_byte..].iter().enumerate() {
            if *byte_val != 0xFF {
                let byte_idx = start_byte + offset;
                for bit in 0..8u32 {
                    if (*byte_val & (1 << bit)) == 0 {
                        return Some((byte_idx as u32) * 8 + bit);
                    }
                }
            }
        }
        None
    }

    /// Mark a page as used in the FSM, update header and file size, advance hint.
    fn complete_allocation(
        &mut self,
        fsm_buf: &mut [u8; PAGE_SIZE],
        page_id: u32,
    ) -> Result<PageId> {
        let byte_idx = page_id as usize / 8;
        let bit_idx = page_id % 8;
        fsm_buf[byte_idx] |= 1 << bit_idx;
        self.write_page_raw(FSM_PAGE_ID, fsm_buf)?;

        // Advance hint to next position
        self.next_free_hint = page_id + 1;

        // Update page count if needed
        if page_id >= self.header.page_count {
            self.header.page_count = page_id + 1;
            self.flush_header()?;
        }

        // Ensure the file is large enough
        let required_size = (page_id as u64 + 1) * PAGE_SIZE as u64;
        let current_size = self.file.seek(SeekFrom::End(0))?;
        if current_size < required_size {
            self.file
                .seek(SeekFrom::Start(page_id as u64 * PAGE_SIZE as u64))?;
            self.file.write_all(&[0u8; PAGE_SIZE])?;
        }

        Ok(PageId(page_id))
    }

    /// Deallocate a page by clearing its bit in the FSM.
    /// REQ-PAGE-005: Clear bit in FSM when page freed.
    pub fn deallocate_page(&mut self, page_id: PageId) -> Result<()> {
        let mut fsm_buf = [0u8; PAGE_SIZE];
        self.read_page_raw(FSM_PAGE_ID, &mut fsm_buf)?;

        let byte_idx = page_id.0 as usize / 8;
        let bit_idx = page_id.0 % 8;
        fsm_buf[byte_idx] &= !(1 << bit_idx);

        self.write_page_raw(FSM_PAGE_ID, &fsm_buf)?;

        // Update hint if freed page is earlier than current hint
        if page_id.0 < self.next_free_hint {
            self.next_free_hint = page_id.0;
        }

        Ok(())
    }

    /// Read a raw 4KB page from the database file.
    pub fn read_page(&mut self, page_id: PageId) -> Result<[u8; PAGE_SIZE]> {
        let mut buf = [0u8; PAGE_SIZE];
        self.read_page_raw(page_id.0, &mut buf)?;
        Ok(buf)
    }

    /// Write a raw 4KB page to the database file.
    pub fn write_page(&mut self, page_id: PageId, data: &[u8; PAGE_SIZE]) -> Result<()> {
        self.write_page_raw(page_id.0, data)
    }

    /// Flush the database header (page 0) to disk.
    pub fn flush_header(&mut self) -> Result<()> {
        let page = self.header.to_page();
        self.write_page_raw(0, &page)?;
        Ok(())
    }

    /// Returns a reference to the current database header.
    pub fn header(&self) -> &DatabaseHeader {
        &self.header
    }

    /// Returns a mutable reference to the current database header.
    pub fn header_mut(&mut self) -> &mut DatabaseHeader {
        &mut self.header
    }

    /// Returns the database file path.
    pub fn path(&self) -> &PathBuf {
        &self.path
    }

    /// Sync all data to disk.
    pub fn sync(&mut self) -> Result<()> {
        self.file.sync_all()?;
        Ok(())
    }

    // Internal: read raw page by numeric ID
    fn read_page_raw(&mut self, page_id: u32, buf: &mut [u8; PAGE_SIZE]) -> Result<()> {
        let offset = page_id as u64 * PAGE_SIZE as u64;
        self.file.seek(SeekFrom::Start(offset))?;
        self.file.read_exact(buf)?;
        Ok(())
    }

    // Internal: write raw page by numeric ID
    fn write_page_raw(&mut self, page_id: u32, data: &[u8; PAGE_SIZE]) -> Result<()> {
        let offset = page_id as u64 * PAGE_SIZE as u64;
        self.file.seek(SeekFrom::Start(offset))?;
        self.file.write_all(data)?;
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::page::{DatabaseHeader, FIRST_DATA_PAGE};
    use tempfile::tempdir;

    fn test_config(dir: &std::path::Path) -> DatabaseConfig {
        DatabaseConfig {
            path: dir.join("test.cyl"),
            ..Default::default()
        }
    }

    // REQ-PAGE-002: Create database with header page at page 0
    #[test]
    fn test_create_database_writes_header() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let pm = PageManager::create_database(&config).expect("create");
        assert_eq!(pm.header().magic, MAGIC);
        assert_eq!(pm.header().version, FORMAT_VERSION);
        assert_eq!(pm.header().page_count, FIRST_DATA_PAGE);
    }

    // REQ-PAGE-002: File contains header and FSM pages
    #[test]
    fn test_create_database_file_size() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let _pm = PageManager::create_database(&config).expect("create");
        let file_size = std::fs::metadata(&config.path).expect("metadata").len();
        // Should contain at least header page + FSM page = 2 * 4096
        assert_eq!(file_size, 2 * PAGE_SIZE as u64);
    }

    // REQ-PAGE-007: Opening file with wrong magic -> InvalidMagicNumber
    #[test]
    fn test_open_invalid_magic_number() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());

        // Write garbage header
        let mut file = File::create(&config.path).expect("create");
        let mut bad_page = [0u8; PAGE_SIZE];
        bad_page[0..4].copy_from_slice(&0xDEAD_BEEFu32.to_le_bytes());
        file.write_all(&bad_page).expect("write");
        file.write_all(&[0u8; PAGE_SIZE]).expect("write fsm");
        drop(file);

        let result = PageManager::open_database(&config);
        assert!(matches!(result, Err(CypherLiteError::InvalidMagicNumber)));
    }

    // REQ-PAGE-008: Opening file with unsupported version -> UnsupportedVersion
    #[test]
    fn test_open_unsupported_version() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());

        let mut hdr = DatabaseHeader::new();
        hdr.version = 99;
        let mut file = File::create(&config.path).expect("create");
        file.write_all(&hdr.to_page()).expect("write");
        file.write_all(&[0u8; PAGE_SIZE]).expect("write fsm");
        drop(file);

        let result = PageManager::open_database(&config);
        assert!(matches!(
            result,
            Err(CypherLiteError::UnsupportedVersion {
                found: 99,
                supported
            }) if supported == FORMAT_VERSION
        ));
    }

    // REQ-PAGE-007 + REQ-PAGE-002: Open valid database succeeds
    #[test]
    fn test_open_valid_database() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        drop(PageManager::create_database(&config).expect("create"));
        let pm = PageManager::open_database(&config).expect("open");
        assert_eq!(pm.header().magic, MAGIC);
    }

    // REQ-PAGE-004: Allocate page finds first free bit in FSM
    #[test]
    fn test_allocate_page_returns_first_free() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        // Pages 0 and 1 are used. First free should be page 2.
        let page = pm.allocate_page().expect("alloc");
        assert_eq!(page, PageId(2));

        let page2 = pm.allocate_page().expect("alloc");
        assert_eq!(page2, PageId(3));
    }

    // REQ-PAGE-005: Deallocate page clears FSM bit
    #[test]
    fn test_deallocate_and_reallocate() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        let p1 = pm.allocate_page().expect("alloc");
        let p2 = pm.allocate_page().expect("alloc");
        assert_eq!(p1, PageId(2));
        assert_eq!(p2, PageId(3));

        // Free p1
        pm.deallocate_page(p1).expect("dealloc");

        // Next allocation should reuse p1's slot (page 2)
        let p3 = pm.allocate_page().expect("alloc");
        assert_eq!(p3, PageId(2));
    }

    // REQ-PAGE-001: Read/write in 4KB fixed pages
    #[test]
    fn test_read_write_page_roundtrip() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        let page_id = pm.allocate_page().expect("alloc");

        let mut data = [0u8; PAGE_SIZE];
        data[0] = 0xAB;
        data[4095] = 0xCD;
        pm.write_page(page_id, &data).expect("write");

        let read_back = pm.read_page(page_id).expect("read");
        assert_eq!(read_back[0], 0xAB);
        assert_eq!(read_back[4095], 0xCD);
    }

    // Multiple allocations
    #[test]
    fn test_allocate_multiple_pages() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        let mut pages = vec![];
        for i in 0..10 {
            let p = pm.allocate_page().expect("alloc");
            assert_eq!(p, PageId(FIRST_DATA_PAGE + i));
            pages.push(p);
        }
        assert_eq!(pages.len(), 10);
    }

    // REQ-PAGE-003: FSM bitmap marks header and FSM as used
    #[test]
    fn test_fsm_initial_state() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        let fsm = pm.read_page(PageId(FSM_PAGE_ID)).expect("read fsm");
        // Bits 0 and 1 should be set (header + FSM)
        assert_eq!(fsm[0] & 0b11, 0b11);
        // Bit 2 should be clear (first data page is free)
        assert_eq!(fsm[0] & 0b100, 0);
    }

    #[test]
    fn test_flush_header_persists() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        {
            let mut pm = PageManager::create_database(&config).expect("create");
            pm.header_mut().next_node_id = 42;
            pm.flush_header().expect("flush");
        }
        let pm = PageManager::open_database(&config).expect("open");
        assert_eq!(pm.header().next_node_id, 42);
    }

    // AA-T3: Open v2 database auto-migrates to v3
    #[test]
    fn test_open_v2_database_migrates_to_v3() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());

        // Write a v2 header manually (raw bytes, not via DatabaseHeader)
        let mut file = File::create(&config.path).expect("create");
        // Manually write v2 format (no feature_flags at bytes 44-47)
        let mut page = [0u8; PAGE_SIZE];
        page[0..4].copy_from_slice(&MAGIC.to_le_bytes());
        page[4..8].copy_from_slice(&2u32.to_le_bytes());
        page[8..12].copy_from_slice(&FIRST_DATA_PAGE.to_le_bytes());
        page[20..28].copy_from_slice(&1u64.to_le_bytes());
        page[28..36].copy_from_slice(&1u64.to_le_bytes());
        file.write_all(&page).expect("write header");
        file.write_all(&[0u8; PAGE_SIZE]).expect("write fsm");
        drop(file);

        let pm = PageManager::open_database(&config).expect("open v2");
        assert_eq!(pm.header().version, FORMAT_VERSION);
        // Auto-migrated feature_flags should have temporal-core
        assert!(pm.header().feature_flags & DatabaseHeader::FLAG_TEMPORAL_CORE != 0);
    }

    // AA-T4: Database with feature flags not compiled in is rejected
    #[test]
    fn test_open_database_with_unsupported_features() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());

        // Write a v3 header with a feature flag we don't have compiled
        let mut page = [0u8; PAGE_SIZE];
        page[0..4].copy_from_slice(&MAGIC.to_le_bytes());
        page[4..8].copy_from_slice(&FORMAT_VERSION.to_le_bytes());
        page[8..12].copy_from_slice(&FIRST_DATA_PAGE.to_le_bytes());
        page[20..28].copy_from_slice(&1u64.to_le_bytes());
        page[28..36].copy_from_slice(&1u64.to_le_bytes());
        // Set a high bit that no current compilation supports
        let bogus_flags = 0x8000_0000u32;
        page[44..48].copy_from_slice(&bogus_flags.to_le_bytes());

        let mut file = File::create(&config.path).expect("create");
        file.write_all(&page).expect("write header");
        file.write_all(&[0u8; PAGE_SIZE]).expect("write fsm");
        drop(file);

        let result = PageManager::open_database(&config);
        assert!(matches!(
            result,
            Err(CypherLiteError::FeatureIncompatible { .. })
        ));
    }

    // AA-T3: New database gets current FORMAT_VERSION with feature flags
    #[test]
    fn test_new_database_has_current_format_version_header() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let pm = PageManager::create_database(&config).expect("create");
        assert_eq!(pm.header().version, FORMAT_VERSION);
        assert!(pm.header().feature_flags & DatabaseHeader::FLAG_TEMPORAL_CORE != 0);
    }

    // REQ-S-003: FSM next-free hint skips already-used pages
    #[test]
    fn test_hint_skips_used_pages() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        // Allocate 10 pages (pages 2..11)
        for _ in 0..10 {
            pm.allocate_page().expect("alloc");
        }

        // Free page 5
        pm.deallocate_page(PageId(5)).expect("dealloc");

        // Next allocation should find page 5 (the freed page)
        let reused = pm.allocate_page().expect("alloc");
        assert_eq!(reused, PageId(5));

        // Next allocation after that should be page 12 (first truly free page)
        let next = pm.allocate_page().expect("alloc");
        assert_eq!(next, PageId(12));
    }

    // REQ-S-003: Hint updates when earlier page is deallocated
    #[test]
    fn test_hint_update_on_dealloc() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        // Allocate pages 2, 3, 4, 5
        for _ in 0..4 {
            pm.allocate_page().expect("alloc");
        }

        // Free page 3 - hint should point to 3 (earlier than current hint)
        pm.deallocate_page(PageId(3)).expect("dealloc");

        // Verify next allocation reuses page 3
        let reused = pm.allocate_page().expect("alloc");
        assert_eq!(reused, PageId(3));

        // Now free page 2 and page 4
        pm.deallocate_page(PageId(2)).expect("dealloc");
        pm.deallocate_page(PageId(4)).expect("dealloc");

        // Should get page 2 first (earlier), then page 4
        let first = pm.allocate_page().expect("alloc");
        assert_eq!(first, PageId(2));

        let second = pm.allocate_page().expect("alloc");
        assert_eq!(second, PageId(4));
    }

    // REQ-S-003: Sequential allocation with hint produces correct IDs
    #[test]
    fn test_sequential_allocation_with_hint() {
        let dir = tempdir().expect("tempdir");
        let config = test_config(dir.path());
        let mut pm = PageManager::create_database(&config).expect("create");

        // Allocate 50 pages sequentially and verify all IDs
        for i in 0..50u32 {
            let page = pm.allocate_page().expect("alloc");
            assert_eq!(
                page,
                PageId(FIRST_DATA_PAGE + i),
                "Page {} should have ID {}",
                i,
                FIRST_DATA_PAGE + i
            );
        }
    }
}