csvpp 0.6.0

Compile csv++ source code to a target spreadsheet format
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
//! # `ModuleLoader`
//!
//! A multithreaded module loader that will resursively load the dependencies for a given
//! `Scope`.
//!
// TODO:
// * make it so that `---` is not required for dependent modules
use crate::{compiler_error, Error, Module, ModulePath, Result, Scope};
use log::debug;
use petgraph::{algo, graph};
use std::collections;
use std::path;
use std::sync;
use std::thread;

type ArcRwLock<T> = sync::Arc<sync::RwLock<T>>;

type LoadedModules = collections::HashMap<ModulePath, Module>;

type Attempted = ArcRwLock<collections::HashSet<ModulePath>>;
type Loaded = ArcRwLock<LoadedModules>;
type Failed = ArcRwLock<collections::HashMap<ModulePath, Error>>;

#[derive(Debug)]
pub(super) struct ModuleLoader {
    attempted: Attempted,
    failed: Failed,
    loaded: Loaded,
    loader_root: path::PathBuf,
    main_module: Module,
    is_dirty: bool,
    use_cache: bool,
}

// TODO: ideally this shouldn't take a $source_code and the calling part does the map_err
macro_rules! eval_ast {
    ($scope:expr, $functions_or_variables:ident, $source_code:expr) => {{
        for (name, ast) in $scope.$functions_or_variables.clone().into_iter() {
            $scope.$functions_or_variables.insert(
                name,
                ast.eval(&$scope, None)
                    .map_err(|e| $source_code.eval_error(e, None))?,
            );
        }
    }};
}

// TODO:
// * get rid of unwrap()s
// * see if I can reduce the clone()s
impl ModuleLoader {
    /// Recursively load the dependencies from the given `scope` while collecting any errors into
    /// `failed` and sucesses into `loaded`. The idea being that we want to show as many errors as
    /// possible to the user (otherwise it's annoying to have them fix and re-compile one-by-one),
    /// so we accumulate and keep going.  But in the end fail if there are any errors at all.
    pub(super) fn load_main<P: Into<path::PathBuf>>(
        main_module: Module,
        relative_to: P,
        use_cache: bool,
    ) -> Result<Module> {
        let mut module_loader = Self {
            attempted: sync::Arc::default(),
            failed: sync::Arc::default(),
            loaded: sync::Arc::default(),
            main_module,
            loader_root: relative_to.into(),
            is_dirty: false,
            use_cache,
        };
        let mut were_any_deps_dirty = false;

        // we need to do this in a loop because every time we reload dirty dependencies we're
        // pulling in changes to the source code, which could mean the author added a new `use ...`
        // in which case we need to load it
        loop {
            module_loader.load(&module_loader.main_module)?;
            module_loader = module_loader.propagate_dirty_flag()?;
            if module_loader.is_dirty {
                were_any_deps_dirty = true;
                module_loader.reload_dirty_modules()?;
            } else {
                break;
            }
        }

        module_loader.eval_dependencies()?;

        let mut main = module_loader.merge_direct_dependencies()?;
        main.is_dirty = were_any_deps_dirty;
        Ok(main)
    }

    /// Returns only the direct dependencies for this module graph.  For example if our Module A
    /// requires Module B which in turn requires Module C, we will only get vars & functions from
    /// Module B, not from Module C (or any other indirect dependencies)
    fn merge_direct_dependencies(self) -> Result<Module> {
        if self.has_failures() {
            Err(Error::ModuleLoadErrors(
                sync::Arc::try_unwrap(self.failed)
                    .expect("Unable to access failed")
                    .into_inner()?,
            ))
        } else {
            let mut loaded = self.loaded.write()?;
            let mut main_module = self.main_module;

            for req_path in &main_module.required_modules {
                main_module
                    .scope
                    .merge(&loaded.remove(req_path).unwrap().scope);
            }

            Ok(main_module)
        }
    }

    fn load_dependency_graph(&self) -> graph::Graph<ModulePath, ()> {
        let loaded = self.loaded.read().unwrap();
        debug!("Loaded dependency graph with {} dependencies", loaded.len());

        let mut dep_graph = graph::Graph::new();

        let main_node = dep_graph.add_node(self.main_module.module_path.clone());

        let mut loaded_nodes = collections::HashMap::new();
        loaded_nodes.insert(&self.main_module.module_path, main_node);

        // load all of the direct dependencies
        for p in &self.main_module.required_modules {
            let direct_dep_node = dep_graph.add_node(p.clone());
            loaded_nodes.insert(p, direct_dep_node);
            dep_graph.add_edge(main_node, direct_dep_node, ());
        }

        for (p, dep_mod) in loaded.iter() {
            // TODO: clean this up with a macro or something. or maybe wrap the petgraph into a
            // `UniqueGraph` of my own making
            let dep_node = loaded_nodes
                .get(p)
                .copied()
                .unwrap_or_else(|| dep_graph.add_node(p.clone()));
            loaded_nodes.insert(p, dep_node);

            for required_mod in &dep_mod.required_modules {
                let dep_dep_node = loaded_nodes
                    .get(required_mod)
                    .copied()
                    .unwrap_or_else(|| dep_graph.add_node(required_mod.clone()));
                loaded_nodes.insert(required_mod, dep_dep_node);

                dep_graph.add_edge(dep_node, dep_dep_node, ());
            }
        }

        debug!("Loaded dependency graph {dep_graph:?}");

        dep_graph
    }

    fn dirty_nodes(&self) -> collections::HashSet<ModulePath> {
        let loaded = self.loaded.read().unwrap();
        let dep_graph = self.load_dependency_graph();

        let mut dirty_nodes: collections::HashSet<ModulePath> = collections::HashSet::default();
        for node in dep_graph.node_indices().collect::<Vec<_>>() {
            let Some(module) = loaded.get(&dep_graph[node]) else {
                continue;
            };

            if module.is_dirty {
                for graph_path in algo::simple_paths::all_simple_paths::<Vec<_>, _>(
                    &dep_graph,
                    // just assume that the main module is at index 0
                    graph::NodeIndex::new(0),
                    node,
                    1,
                    None,
                ) {
                    for n in graph_path {
                        dirty_nodes.insert(dep_graph[n].clone());
                    }
                }
            }
        }

        dirty_nodes
    }

    fn propagate_dirty_flag(self) -> Result<Self> {
        let dirty_nodes = self.dirty_nodes();
        let mut loaded = sync::Arc::try_unwrap(self.loaded)
            .expect("Unable to access loaded")
            .into_inner()?;

        let is_dirty = !dirty_nodes.is_empty();

        for mp in dirty_nodes {
            if let Some(n) = loaded.get_mut(&mp) {
                n.is_dirty = true;
            }
        }

        Ok(Self {
            loaded: sync::Arc::new(sync::RwLock::new(loaded)),
            is_dirty,
            ..self
        })
    }

    fn reload_dirty_modules(&mut self) -> Result<()> {
        let loaded = self.loaded.read().unwrap();
        for (mp, module) in loaded.iter() {
            if module.is_dirty {
                self.loaded.write()?.insert(
                    mp.clone(),
                    Module::load_from_source_from_filename(
                        mp.clone(),
                        module.source_code.filename.clone(),
                    )?,
                );
            }
        }

        Ok(())
    }

    fn eval_dependencies(&mut self) -> Result<()> {
        let dep_graph = self.load_dependency_graph();
        let mut loaded = self.loaded.write()?;

        // now that we have a graph, use Tarjan's algo to give us a topological sort which will
        // represent the dependencies in the order they need to be resolved.
        let resolution_order = algo::tarjan_scc(&dep_graph)
            .into_iter()
            .flatten()
            .map(|p| dep_graph[p].clone());

        debug!("Resolving dependencies in order {resolution_order:?}");

        // we'll need a local copy of all the scopes as we modify `loaded`
        let mut scopes = collections::HashMap::<ModulePath, Scope>::new();
        for (mp, m) in loaded.iter() {
            scopes.insert(mp.clone(), m.scope.clone());
        }

        for mp_to_resolve in resolution_order {
            let Some(to_resolve) = loaded.get_mut(&mp_to_resolve) else {
                continue;
            };

            if !to_resolve.needs_eval {
                continue;
            }

            // let mut local_scope = to_resolve.scope.clone();
            for req_path in to_resolve.required_modules.iter().rev() {
                let Some(dep_scope) = scopes.get(req_path) else {
                    compiler_error(format!(
                        "Expected dependent module to have been loaded: {req_path}"
                    ))
                };

                to_resolve.scope.merge(dep_scope);
            }

            eval_ast!(to_resolve.scope, variables, to_resolve.source_code);
            eval_ast!(to_resolve.scope, functions, to_resolve.source_code);

            // now that we've evaled it that's the last step, write the csvpo file
            if self.use_cache {
                to_resolve.write_object_file()?;
            }

            scopes.insert(to_resolve.module_path.clone(), to_resolve.scope.clone());
        }

        Ok(())
    }

    fn has_failures(&self) -> bool {
        !self.failed.try_read().unwrap().is_empty()
    }

    fn load(&self, module: &Module) -> Result<()> {
        let mut to_attempt = collections::HashSet::new();
        // hold a lock while we reserve all of the dependencies we're going to resolve (by
        // preemptively marking them in `attempted`)
        {
            let mut attempted = self.attempted.write()?;
            for module_path in &module.required_modules {
                if attempted.contains(module_path) {
                    // another module has already loaded it
                    continue;
                }

                attempted.insert(module_path.clone());
                to_attempt.insert(module_path.clone());
            }
        }

        // now a thread for each module to load and they'll recurse back to this function if they
        // in turn have modules to load
        thread::scope(|s| {
            for module_path in to_attempt {
                s.spawn(|| self.load_module(module_path, &module.module_path));
            }
        });

        Ok(())
    }

    fn load_module(&self, module_path: ModulePath, relative_to: &ModulePath) -> Result<()> {
        let load_result = if self.use_cache {
            Module::load_from_cache(module_path.clone(), relative_to, &self.loader_root)
        } else {
            Module::load_from_source_relative(module_path.clone(), relative_to, &self.loader_root)
        };

        match load_result {
            Ok(loaded_module) => {
                // recursively load the newly loaded code section's dependencies (which are
                // transitive at this point)
                self.load(&loaded_module)?;
                self.loaded.write()?.insert(module_path, loaded_module);
            }
            Err(e) => {
                self.failed.write()?.insert(module_path, e);
            }
        }

        Ok(())
    }
}

#[cfg(test)]
#[allow(clippy::similar_names)]
mod tests {
    use super::*;
    use crate::ast::*;
    use crate::test_utils::*;
    use crate::*;

    #[test]
    fn load_main_empty() {
        assert!(ModuleLoader::load_main(build_module(), "", true).is_ok());
    }

    #[test]
    fn load_main_require_error() {
        let mut module = build_module();
        module.required_modules.push(ModulePath::new("bar"));

        assert!(ModuleLoader::load_main(module, "", true).is_err());
    }

    #[test]
    fn load_main_valid_files() {
        let mod1 = TestSourceCode::new(
            "csv",
            "
    a := 42
    ---
            ",
        );
        let mod2 = TestSourceCode::new(
            "csv",
            "
    b := 24
    ---
            ",
        );
        let main_module = Module {
            module_path: ModulePath::new("main"),
            required_modules: vec![(&mod1).into(), (&mod2).into()],
            ..build_module()
        };
        let main_module = ModuleLoader::load_main(main_module, "", true).unwrap();

        assert_eq!(
            main_module.scope.variables.get("a").unwrap(),
            &Ast::new(Node::var("a", VariableValue::Ast(42.into()))),
        );
        assert_eq!(
            main_module.scope.variables.get("b").unwrap(),
            &Ast::new(Node::var("b", VariableValue::Ast(24.into()))),
        );
    }

    #[test]
    fn load_main_in_directory() {
        let dep_mod = TestSourceCode::new_in_dir(
            "csv",
            "
    a := 42
    ---
            ",
        );
        let main_module = Module {
            module_path: ModulePath::new("main"),
            required_modules: vec![(&dep_mod).into()],
            ..build_module()
        };
        let main_module = ModuleLoader::load_main(main_module, "", true).unwrap();

        assert!(main_module.scope.variables.contains_key("a"));
    }

    #[test]
    fn load_main_double_load() {
        let mod1 = TestSourceCode::new(
            "csv",
            "
    a := 42
    ---
            ",
        );
        let mod1_path = ModulePath::from(&mod1);
        let mod2 = TestSourceCode::new(
            "csv",
            &format!(
                "
    use {mod1_path}
    b := 24
    ---
            "
            ),
        );

        let main_module = Module {
            module_path: ModulePath::new("main"),
            required_modules: vec![(&mod1).into(), (&mod2).into()],
            ..build_module()
        };
        assert!(ModuleLoader::load_main(main_module, "", true).is_ok());
    }

    #[test]
    fn load_main_variable_dependencies() {
        let mod_c_file = TestSourceCode::new(
            "csv",
            "
var_from_c := 420
---
    ",
        );
        let mod_c_path = ModulePath::from(&mod_c_file);

        let mod_b_file = TestSourceCode::new(
            "csv",
            &format!(
                "
use {mod_c_path}
var_from_b := var_from_c
---
"
            ),
        );
        let mod_b_path = ModulePath::from(&mod_b_file);

        let mod_a_file = TestSourceCode::new(
            "csv",
            &format!(
                "
use {mod_b_path}
var_from_a := var_from_b
---
"
            ),
        );
        let mod_a_path = ModulePath::from(&mod_a_file);

        let main_module = Module {
            module_path: ModulePath::new("foo"),
            required_modules: vec![mod_a_path],
            ..build_module()
        };
        let main_module = ModuleLoader::load_main(main_module, "", true).unwrap();

        assert_eq!(
            main_module.scope.variables.get("var_from_a").unwrap(),
            &Node::var("var_from_a", VariableValue::Ast(420.into())).into()
        );
        assert!(!main_module.scope.variables.contains_key("var_from_b"));
        assert!(!main_module.scope.variables.contains_key("var_from_c"));
    }

    #[test]
    fn load_main_function_dependencies() {
        let mod_b_file = TestSourceCode::new(
            "csv",
            "
var_from_b := 420
---
",
        );
        let mod_b_path = ModulePath::from(&mod_b_file);

        let mod_a_file = TestSourceCode::new(
            "csv",
            &format!(
                "
use {mod_b_path}

fn fn_from_a() var_from_b
---
",
            ),
        );
        let mod_a_path = ModulePath::from(&mod_a_file);

        let main_module = Module {
            module_path: ModulePath::new("foo"),
            required_modules: vec![mod_a_path],
            ..build_module()
        };
        let main_module = ModuleLoader::load_main(main_module, "", true).unwrap();

        assert_eq!(
            main_module.scope.functions.get("fn_from_a").unwrap(),
            &Ast::new(Node::fn_def("fn_from_a", &[], Node::Integer(420)))
        );
    }

    #[test]
    fn into_direct_dependencies_shadowing() {
        let mod_c_source_code = TestSourceCode::new(
            "csv",
            "
var_from_c := 420
---
    ",
        );
        let mod_c_path = ModulePath::from(&mod_c_source_code);

        let mod_b_source_code = TestSourceCode::new(
            "csv",
            &format!(
                "
use {mod_c_path}
var_from_b := var_from_c
---
"
            ),
        );
        let mod_b_path = ModulePath::from(&mod_b_source_code);

        let mod_a_source_code = TestSourceCode::new(
            "csv",
            &format!(
                "
use {mod_b_path}
var_from_a := var_from_b
---
"
            ),
        );
        let mod_a_path = ModulePath::from(&mod_a_source_code);

        let mut main_module = Module {
            module_path: ModulePath::new("foo"),
            required_modules: vec![mod_a_path],
            ..build_module()
        };
        main_module.scope.define_variable(
            "var_from_a",
            Ast::new(Node::var("var_from_a", VariableValue::Ast(1.into()))),
        );
        let main_module = ModuleLoader::load_main(main_module, "", true).unwrap();

        assert_eq!(
            main_module.scope.variables.get("var_from_a").unwrap(),
            &Node::var("var_from_a", VariableValue::Ast(1.into())).into()
        );
    }

    #[test]
    fn load_main_dependencies_cyclic() {
        // TODO
    }
}