cruise 0.1.35

use std::path::{Path, PathBuf};

use serde::{Deserialize, Serialize};

use crate::error::{CruiseError, Result};

/// Application-level configuration persisted at `~/.config/cruise/config.json`.
///
/// This is distinct from per-workflow YAML configs (which live in `~/.cruise/sessions/`).
///
/// ## Behaviour
/// - Missing file -> returns [`AppConfig::default()`].
/// - Invalid JSON or invalid field values -> returns a clear error (never silently clamped).
#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
#[serde(rename_all = "camelCase")]
pub struct AppConfig {
    /// Maximum number of sessions to execute concurrently in `run --all` mode.
    ///
    /// Must be >= 1. Defaults to `1` (preserves backward-compatible sequential behaviour).
    #[serde(alias = "run_all_parallelism")]
    pub run_all_parallelism: usize,
}

impl Default for AppConfig {
    fn default() -> Self {
        Self {
            run_all_parallelism: 1,
        }
    }
}

impl AppConfig {
    /// Return the canonical path to the app config file: `$HOME/.config/cruise/config.json`.
    ///
    /// # Errors
    ///
    /// Returns an error if the home directory cannot be determined.
    pub fn config_path() -> Result<PathBuf> {
        let home = home::home_dir()
            .ok_or_else(|| CruiseError::Other("cannot determine home directory".to_string()))?;
        Ok(home.join(".config").join("cruise").join("config.json"))
    }

    /// Load the app config using the canonical [`Self::config_path`].
    ///
    /// # Errors
    ///
    /// - Returns an error if the home directory cannot be determined.
    /// - Returns an error if the file exists but contains invalid JSON or invalid values.
    pub fn load() -> Result<Self> {
        let path = Self::config_path()?;
        Self::load_from(&path)
    }

    /// Load the app config from an explicit path (useful in tests and alternative config locations).
    ///
    /// - File absent -> returns [`AppConfig::default()`].
    /// - File present but invalid -> returns an error.
    ///
    /// # Errors
    ///
    /// Returns an error if the file exists but cannot be read or parsed, or if validation fails.
    pub fn load_from(path: &Path) -> Result<Self> {
        let content = match std::fs::read_to_string(path) {
            Ok(c) => c,
            Err(e) if e.kind() == std::io::ErrorKind::NotFound => return Ok(Self::default()),
            Err(e) => {
                return Err(CruiseError::Other(format!(
                    "failed to read config {}: {e}",
                    path.display()
                )));
            }
        };
        let config: Self = serde_json::from_str(&content).map_err(|e| {
            CruiseError::Other(format!("invalid config JSON in {}: {e}", path.display()))
        })?;
        config.validate()?;
        Ok(config)
    }

    /// Persist the app config to disk using the canonical [`Self::config_path`].
    ///
    /// # Errors
    ///
    /// Returns an error if the home directory cannot be determined or the file cannot be written.
    pub fn save(&self) -> Result<()> {
        let path = Self::config_path()?;
        self.save_to(&path)
    }

    /// Persist the app config to an explicit path.
    ///
    /// Creates parent directories as needed. The write uses a temp-file-then-rename pattern
    /// for atomicity on platforms that support it.
    ///
    /// # Errors
    ///
    /// Returns an error if the file cannot be written or if the config is invalid.
    pub fn save_to(&self, path: &Path) -> Result<()> {
        self.validate()?;
        if let Some(parent) = path.parent() {
            std::fs::create_dir_all(parent).map_err(|e| {
                CruiseError::Other(format!(
                    "failed to create config dir {}: {e}",
                    parent.display()
                ))
            })?;
        }
        // Write to a temp file in the same directory then rename for atomicity.
        let tmp_path = path.with_extension("json.tmp");
        let content = serde_json::to_string_pretty(self)
            .map_err(|e| CruiseError::Other(format!("failed to serialize config: {e}")))?;
        std::fs::write(&tmp_path, content).map_err(|e| {
            CruiseError::Other(format!(
                "failed to write config to {}: {e}",
                tmp_path.display()
            ))
        })?;
        if let Err(e) = std::fs::rename(&tmp_path, path) {
            let _ = std::fs::remove_file(&tmp_path);
            return Err(CruiseError::Other(format!(
                "failed to rename config file: {e}"
            )));
        }
        Ok(())
    }

    /// Validate the config, returning a clear error for any invalid field.
    ///
    /// `run_all_parallelism` must be >= 1. A value of `0` is never silently clamped.
    ///
    /// # Errors
    ///
    /// Returns [`CruiseError::Other`] if any field is invalid.
    pub fn validate(&self) -> Result<()> {
        if self.run_all_parallelism == 0 {
            return Err(CruiseError::Other(
                "run_all_parallelism must be >= 1 (got 0)".to_string(),
            ));
        }
        Ok(())
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use tempfile::TempDir;

    // -- Helpers --------------------------------------------------------------

    /// Write `content` to `<dir>/.config/cruise/config.json`, creating parent dirs.
    /// Returns the path to the written file.
    fn write_config_file(dir: &Path, content: &str) -> PathBuf {
        let config_dir = dir.join(".config").join("cruise");
        std::fs::create_dir_all(&config_dir).unwrap_or_else(|e| panic!("{e}"));
        let config_path = config_dir.join("config.json");
        std::fs::write(&config_path, content).unwrap_or_else(|e| panic!("{e}"));
        config_path
    }

    // -- AppConfig::default() --------------------------------------------------

    #[test]
    fn test_default_parallelism_is_one() {
        // Given/When: a default AppConfig
        let config = AppConfig::default();
        // Then: run_all_parallelism is 1 -- backward-compatible sequential behaviour
        assert_eq!(config.run_all_parallelism, 1);
    }

    // -- AppConfig::validate() ------------------------------------------------

    #[test]
    fn test_validate_accepts_parallelism_of_one() {
        // Given: minimum valid parallelism
        let config = AppConfig {
            run_all_parallelism: 1,
        };
        // When/Then: no error
        assert!(config.validate().is_ok(), "parallelism=1 should be valid");
    }

    #[test]
    fn test_validate_accepts_large_parallelism() {
        // Given: large valid parallelism
        let config = AppConfig {
            run_all_parallelism: 64,
        };
        // When/Then: no error
        assert!(config.validate().is_ok(), "parallelism=64 should be valid");
    }

    #[test]
    fn test_validate_rejects_zero_parallelism() {
        // Given: parallelism of 0 -- explicitly invalid
        let config = AppConfig {
            run_all_parallelism: 0,
        };
        // When: validate
        let result = config.validate();
        // Then: returns a clear error -- must NOT be silently clamped
        assert!(
            result.is_err(),
            "expected error for run_all_parallelism=0, got Ok"
        );
        let msg = match result {
            Err(e) => e.to_string(),
            Ok(()) => unreachable!("already asserted is_err above"),
        };
        assert!(
            msg.contains("parallelism") || msg.contains('0'),
            "error message should mention the invalid value, got: {msg}"
        );
    }

    // -- AppConfig::config_path() ----------------------------------------------

    #[test]
    fn test_config_path_ends_with_config_cruise_config_json() {
        // When: the canonical config path is resolved
        let path = AppConfig::config_path().unwrap_or_else(|e| panic!("expected Ok, got: {e}"));
        // Then: path contains .config/cruise/config.json (OS-independent check)
        let components: Vec<_> = path.components().collect();
        let path_str = path.to_string_lossy();
        assert!(
            path_str.contains("config.json"),
            "expected path to end with config.json, got: {path_str}"
        );
        assert!(
            components
                .windows(2)
                .any(|w| w[0].as_os_str() == "cruise" && w[1].as_os_str() == "config.json"),
            "expected cruise/config.json in path, got: {path_str}"
        );
    }

    // -- AppConfig::load_from() ------------------------------------------------

    #[test]
    fn test_load_from_returns_defaults_when_file_absent() {
        // Given: a path that does not exist
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let missing = tmp.path().join("nonexistent").join("config.json");
        // When: load_from
        let config =
            AppConfig::load_from(&missing).unwrap_or_else(|e| panic!("expected Ok, got: {e}"));
        // Then: returns defaults (not an error)
        assert_eq!(
            config,
            AppConfig::default(),
            "absent file should yield defaults"
        );
    }

    #[test]
    fn test_load_from_returns_error_for_invalid_json() {
        // Given: a config file with malformed JSON
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let config_path = write_config_file(tmp.path(), "not valid json at all");
        // When: load_from
        let result = AppConfig::load_from(&config_path);
        // Then: returns an error -- not silently ignored or defaulted
        assert!(result.is_err(), "expected error for invalid JSON, got Ok");
    }

    #[test]
    fn test_load_from_returns_error_for_empty_json_object() {
        // Given: {} is valid JSON but missing required fields -- depends on serde defaults
        // The expected behaviour is to fill in the default. An explicit {} should work.
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let config_path = write_config_file(tmp.path(), "{}");
        // When: load_from -- {} has no run_all_parallelism; serde may use field default
        // Then: should succeed (serde can apply field-level default) or error gracefully --
        //       never panic. Either outcome is acceptable; we just verify no panic.
        let _result = AppConfig::load_from(&config_path);
        // (no assertion on Ok/Err; just verifying the call completes safely)
    }

    #[test]
    fn test_load_from_returns_error_for_zero_parallelism_in_file() {
        // Given: a config file with run_all_parallelism = 0 -- explicitly invalid
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let config_path = write_config_file(tmp.path(), r#"{"run_all_parallelism": 0}"#);
        // When: load_from
        let result = AppConfig::load_from(&config_path);
        // Then: returns a clear error -- must NOT silently clamp to 1
        assert!(
            result.is_err(),
            "expected error for run_all_parallelism=0, got Ok"
        );
    }

    #[test]
    fn test_load_from_parses_valid_parallelism() {
        // Given: a valid config file with run_all_parallelism = 4
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let config_path = write_config_file(tmp.path(), r#"{"run_all_parallelism": 4}"#);
        // When: load_from
        let config =
            AppConfig::load_from(&config_path).unwrap_or_else(|e| panic!("expected Ok, got: {e}"));
        // Then: parallelism matches the file
        assert_eq!(config.run_all_parallelism, 4);
    }

    // -- AppConfig::save_to() + load_from() round-trip ------------------------

    #[test]
    fn test_save_to_then_load_from_round_trips_parallelism() {
        // Given: a non-default AppConfig
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let path = tmp.path().join("config.json");
        let original = AppConfig {
            run_all_parallelism: 8,
        };
        // When: save then load
        original
            .save_to(&path)
            .unwrap_or_else(|e| panic!("save failed: {e}"));
        let loaded = AppConfig::load_from(&path).unwrap_or_else(|e| panic!("load failed: {e}"));
        // Then: round-trip preserves the value exactly
        assert_eq!(loaded, original);
    }

    #[test]
    fn test_save_to_creates_parent_directories() {
        // Given: a deeply nested path whose parents do not yet exist
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let path = tmp.path().join("a").join("b").join("c").join("config.json");
        let config = AppConfig {
            run_all_parallelism: 2,
        };
        // When: save_to
        config
            .save_to(&path)
            .unwrap_or_else(|e| panic!("save failed: {e}"));
        // Then: the file now exists
        assert!(path.exists(), "config file should have been created");
    }

    #[test]
    fn test_save_to_overwrites_existing_file() {
        // Given: a file with one value already written
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let path = tmp.path().join("config.json");
        AppConfig {
            run_all_parallelism: 3,
        }
        .save_to(&path)
        .unwrap_or_else(|e| panic!("{e}"));
        // When: save a different value
        AppConfig {
            run_all_parallelism: 7,
        }
        .save_to(&path)
        .unwrap_or_else(|e| panic!("{e}"));
        // Then: the file contains the new value
        let loaded = AppConfig::load_from(&path).unwrap_or_else(|e| panic!("{e}"));
        assert_eq!(loaded.run_all_parallelism, 7);
    }

    #[test]
    fn test_save_to_does_not_persist_invalid_config() {
        // Given: a config that fails validation (parallelism = 0)
        let tmp = TempDir::new().unwrap_or_else(|e| panic!("{e:?}"));
        let path = tmp.path().join("config.json");
        let invalid = AppConfig {
            run_all_parallelism: 0,
        };
        // When: save_to
        let result = invalid.save_to(&path);
        // Then: returns an error; the file should not have been created (or is unusable)
        assert!(
            result.is_err(),
            "save_to should reject invalid config, got Ok"
        );
    }
}