crawlrs 0.2.0

crawlrs - Enterprise-grade web scraping and crawling platform built with Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
// Copyright (c) 2025-2026 Kirky.X🌠
// SPDX-License-Identifier: Apache-2.0

use crate::common::metrics_shim::gauge;
use crate::domain::models::Task;
use crate::domain::repositories::task_repository::TaskRepository;
use async_trait::async_trait;
use log::debug;
use std::sync::atomic::{AtomicU64, Ordering};
use std::sync::Arc;
use thiserror::Error;

/// 队列错误类型
#[derive(Error, Debug)]
pub enum QueueError {
    /// 仓库错误
    #[error("Repository error: {0}")]
    Repository(#[from] crate::domain::repositories::task_repository::RepositoryError),

    /// 队列为空
    #[error("Queue empty")]
    Empty,
}

/// 任务队列特质
#[async_trait]
pub trait TaskQueue: Send + Sync {
    /// 入队任务
    async fn enqueue(&self, task: Task) -> Result<Task, QueueError>;

    /// 出队任务
    async fn dequeue(&self, worker_id: crate::domain::id::Id) -> Result<Option<Task>, QueueError>;

    /// 完成任务
    async fn complete(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError>;
    /// 失败任务
    async fn fail(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError>;
    /// 取消任务
    async fn cancel(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError>;
}

/// PostgreSQL任务队列实现
pub struct PostgresTaskQueue {
    /// 任务仓库
    pub repository: Arc<dyn TaskRepository>,
    /// 近似队列深度计数器(enqueue +1, dequeue -1)
    ///
    /// 下限钳 0:crawl 子任务经 repository.create 直写入队(不走 queue.enqueue),
    /// worker 的 dequeue 扣减若无下限会回绕为 u64::MAX,后续 enqueue 的
    /// `old + 1` 在 debug 构建即溢出 panic,release 则静默输出垃圾指标。
    depth: AtomicU64,
}

impl PostgresTaskQueue {
    /// 创建新的PostgreSQL任务队列实例
    ///
    /// # 参数
    ///
    /// * `repository` - 任务仓库
    ///
    /// # 返回值
    ///
    /// 返回新的PostgreSQL任务队列实例
    pub fn new(repository: Arc<dyn TaskRepository>) -> Self {
        Self {
            repository,
            depth: AtomicU64::new(0),
        }
    }
}

#[async_trait]
impl TaskQueue for PostgresTaskQueue {
    /// 入队任务
    ///
    /// # 参数
    ///
    /// * `task` - 要入队的任务
    ///
    /// # 返回值
    ///
    /// * `Ok(Task)` - 入队成功的任务
    /// * `Err(QueueError)` - 入队失败
    async fn enqueue(&self, task: Task) -> Result<Task, QueueError> {
        let created = self.repository.create(&task).await?;
        let new_depth = self.depth.fetch_add(1, Ordering::Relaxed) + 1;
        gauge!("crawlrs_queue_depth", "queue_type" => "task").set(new_depth as f64);
        Ok(created)
    }

    /// 出队任务
    ///
    /// # 参数
    ///
    /// * `worker_id` - 工作者ID
    ///
    /// # 返回值
    ///
    /// * `Ok(Some(Task))` - 成功出队的任务
    /// * `Ok(None)` - 没有可出队的任务
    /// * `Err(QueueError)` - 出队失败
    async fn dequeue(&self, worker_id: crate::domain::id::Id) -> Result<Option<Task>, QueueError> {
        debug!("worker_id={}", worker_id);
        let task = self.repository.acquire_next(worker_id).await?;
        if task.is_some() {
            // 深度下限钳 0(CAS 循环容忍并发入队),防止负向漂移回绕
            let mut observed = self.depth.load(Ordering::Relaxed);
            loop {
                let next = observed.saturating_sub(1);
                match self.depth.compare_exchange_weak(
                    observed,
                    next,
                    Ordering::Relaxed,
                    Ordering::Relaxed,
                ) {
                    Ok(_) => break,
                    Err(now) => observed = now,
                }
            }
        }
        let current = self.depth.load(Ordering::Relaxed);
        gauge!("crawlrs_queue_depth", "queue_type" => "task").set(current as f64);
        debug!("has_task={:?}", task.is_some());
        Ok(task)
    }

    /// 完成任务
    ///
    /// # 参数
    ///
    /// * `task_id` - 任务ID
    ///
    /// # 返回值
    ///
    /// * `Ok()` - 成功
    /// * `Err(QueueError)` - 失败
    async fn complete(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        // 无锁身份(None):队列级 complete 仅允许终结未被认领的任务;
        // 持锁 worker 应直接走 repository.mark_completed(带 worker 身份守卫)
        self.repository.mark_completed(task_id, None).await?;
        Ok(())
    }

    /// 失败任务
    ///
    /// # 参数
    ///
    /// * `task_id` - 任务ID
    ///
    /// # 返回值
    ///
    /// * `Ok()` - 成功
    /// * `Err(QueueError)` - 失败
    async fn fail(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        // 无锁身份(None):语义同 complete
        self.repository.mark_failed(task_id, None).await?;
        Ok(())
    }

    /// 取消任务
    ///
    /// # 参数
    ///
    /// * `task_id` - 任务ID
    ///
    /// # 返回值
    ///
    /// * `Ok()` - 成功
    /// * `Err(QueueError)` - 失败
    async fn cancel(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        self.repository.mark_cancelled(task_id).await?;
        Ok(())
    }
}

#[async_trait]
impl<T: TaskQueue + ?Sized> TaskQueue for Arc<T> {
    async fn enqueue(&self, task: Task) -> Result<Task, QueueError> {
        (**self).enqueue(task).await
    }

    async fn dequeue(&self, worker_id: crate::domain::id::Id) -> Result<Option<Task>, QueueError> {
        (**self).dequeue(worker_id).await
    }

    async fn complete(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        (**self).complete(task_id).await
    }

    async fn fail(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        (**self).fail(task_id).await
    }

    async fn cancel(&self, task_id: crate::domain::id::Id) -> Result<(), QueueError> {
        (**self).cancel(task_id).await
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::domain::models::{Task, TaskType};
    use crate::domain::repositories::task_repository::{
        RepositoryError, TaskQueryParams, TaskRepository,
    };
    use async_trait::async_trait;
    use chrono::Duration as ChronoDuration;
    use std::collections::HashSet;
    use std::sync::atomic::{AtomicUsize, Ordering};
    use std::sync::Arc;

    /// Mock TaskRepository that records calls and returns configurable results.
    ///
    /// Each method increments a counter so tests can assert which repository
    /// method was invoked by which queue operation.
    struct MockTaskRepository {
        enqueue_calls: AtomicUsize,
        dequeue_calls: AtomicUsize,
        complete_calls: AtomicUsize,
        fail_calls: AtomicUsize,
        cancel_calls: AtomicUsize,
        /// Last task_id passed to mark_* methods.
        last_task_id: parking_lot::Mutex<Option<crate::domain::id::Id>>,
        /// Last worker_id passed to acquire_next.
        last_worker_id: parking_lot::Mutex<Option<crate::domain::id::Id>>,
        /// When true, repository methods return RepositoryError::Database.
        should_fail: bool,
        /// Task returned by acquire_next; None means empty queue.
        next_task: parking_lot::Mutex<Option<Task>>,
        /// Task returned by create (defaults to the input task).
        created_task: parking_lot::Mutex<Option<Task>>,
    }

    impl MockTaskRepository {
        fn new() -> Self {
            Self {
                enqueue_calls: AtomicUsize::new(0),
                dequeue_calls: AtomicUsize::new(0),
                complete_calls: AtomicUsize::new(0),
                fail_calls: AtomicUsize::new(0),
                cancel_calls: AtomicUsize::new(0),
                last_task_id: parking_lot::Mutex::new(None),
                last_worker_id: parking_lot::Mutex::new(None),
                should_fail: false,
                next_task: parking_lot::Mutex::new(None),
                created_task: parking_lot::Mutex::new(None),
            }
        }

        fn failing() -> Self {
            let mut mock = Self::new();
            mock.should_fail = true;
            mock
        }

        fn with_next_task(task: Task) -> Self {
            let mock = Self::new();
            *mock.next_task.lock() = Some(task);
            mock
        }
    }

    fn sample_task() -> Task {
        Task::new(
            crate::domain::id::Id::generate(),
            TaskType::Scrape,
            crate::domain::id::Id::generate(),
            crate::domain::id::Id::generate(),
            "https://example.com".to_string(),
            serde_json::json!({}),
        )
    }

    fn db_error() -> RepositoryError {
        RepositoryError::Database(anyhow::anyhow!("mock database failure"))
    }

    #[async_trait]
    impl TaskRepository for MockTaskRepository {
        async fn create(&self, task: &Task) -> Result<Task, RepositoryError> {
            self.enqueue_calls.fetch_add(1, Ordering::SeqCst);
            if self.should_fail {
                return Err(db_error());
            }
            // Return a clone of the input task by default, or the configured created_task.
            let created = self
                .created_task
                .lock()
                .clone()
                .unwrap_or_else(|| task.clone());
            Ok(created)
        }

        async fn find_by_id(
            &self,
            _id: crate::domain::id::Id,
        ) -> Result<Option<Task>, RepositoryError> {
            unreachable!("MockTaskRepository::find_by_id not invoked by PostgresTaskQueue tests")
        }

        async fn update(&self, _task: &Task) -> Result<Task, RepositoryError> {
            unreachable!("MockTaskRepository::update not invoked by PostgresTaskQueue tests")
        }

        async fn acquire_next(
            &self,
            worker_id: crate::domain::id::Id,
        ) -> Result<Option<Task>, RepositoryError> {
            self.dequeue_calls.fetch_add(1, Ordering::SeqCst);
            *self.last_worker_id.lock() = Some(worker_id);
            if self.should_fail {
                return Err(db_error());
            }
            Ok(self.next_task.lock().take())
        }

        async fn mark_completed(
            &self,
            task_id: crate::domain::id::Id,
            _lock_token: Option<crate::domain::id::Id>,
        ) -> Result<u64, RepositoryError> {
            self.complete_calls.fetch_add(1, Ordering::SeqCst);
            *self.last_task_id.lock() = Some(task_id);
            if self.should_fail {
                return Err(db_error());
            }
            Ok(1)
        }

        async fn mark_failed(
            &self,
            task_id: crate::domain::id::Id,
            _lock_token: Option<crate::domain::id::Id>,
        ) -> Result<u64, RepositoryError> {
            self.fail_calls.fetch_add(1, Ordering::SeqCst);
            *self.last_task_id.lock() = Some(task_id);
            if self.should_fail {
                return Err(db_error());
            }
            Ok(1)
        }

        async fn mark_cancelled(
            &self,
            task_id: crate::domain::id::Id,
        ) -> Result<u64, RepositoryError> {
            self.cancel_calls.fetch_add(1, Ordering::SeqCst);
            *self.last_task_id.lock() = Some(task_id);
            if self.should_fail {
                return Err(db_error());
            }
            Ok(1)
        }

        async fn exists_by_url(&self, _url: &str) -> Result<bool, RepositoryError> {
            unreachable!("MockTaskRepository::exists_by_url not invoked by PostgresTaskQueue tests")
        }

        async fn find_existing_urls(
            &self,
            _urls: &[String],
        ) -> Result<HashSet<String>, RepositoryError> {
            unreachable!(
                "MockTaskRepository::find_existing_urls not invoked by PostgresTaskQueue tests"
            )
        }

        async fn reset_stuck_tasks(
            &self,
            _timeout: ChronoDuration,
        ) -> Result<u64, RepositoryError> {
            unreachable!(
                "MockTaskRepository::reset_stuck_tasks not invoked by PostgresTaskQueue tests"
            )
        }

        async fn cancel_tasks_by_crawl_id(
            &self,
            _crawl_id: crate::domain::id::Id,
        ) -> Result<u64, RepositoryError> {
            unreachable!("MockTaskRepository::cancel_tasks_by_crawl_id not invoked by PostgresTaskQueue tests")
        }

        async fn expire_tasks(&self) -> Result<u64, RepositoryError> {
            unreachable!("MockTaskRepository::expire_tasks not invoked by PostgresTaskQueue tests")
        }

        async fn find_by_crawl_id(
            &self,
            _crawl_id: crate::domain::id::Id,
        ) -> Result<Vec<Task>, RepositoryError> {
            unreachable!(
                "MockTaskRepository::find_by_crawl_id not invoked by PostgresTaskQueue tests"
            )
        }

        async fn query_tasks(
            &self,
            _params: TaskQueryParams,
        ) -> Result<(Vec<Task>, u64), RepositoryError> {
            unreachable!("MockTaskRepository::query_tasks not invoked by PostgresTaskQueue tests")
        }

        async fn batch_cancel(
            &self,
            _task_ids: Vec<crate::domain::id::Id>,
            _team_id: crate::domain::id::Id,
            _force: bool,
        ) -> Result<
            (
                Vec<crate::domain::id::Id>,
                Vec<(crate::domain::id::Id, String)>,
            ),
            RepositoryError,
        > {
            unreachable!("MockTaskRepository::batch_cancel not invoked by PostgresTaskQueue tests")
        }

        async fn renew_lock(
            &self,
            _task_id: crate::domain::id::Id,
            _worker_id: crate::domain::id::Id,
            _extend_seconds: i64,
        ) -> Result<bool, RepositoryError> {
            Ok(true)
        }
    }

    fn make_queue(mock: Arc<dyn TaskRepository>) -> PostgresTaskQueue {
        PostgresTaskQueue::new(mock)
    }

    // PostgresTaskQueue::new

    #[test]
    fn test_new_stores_repository() {
        let mock: Arc<dyn TaskRepository> = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        // Verify the queue stores the same Arc<dyn TaskRepository> pointer.
        assert!(Arc::ptr_eq(&queue.repository, &mock));
    }

    // enqueue happy path

    #[tokio::test]
    async fn test_enqueue_returns_created_task() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let task = sample_task();
        let result = queue.enqueue(task.clone()).await;
        assert!(result.is_ok(), "enqueue should succeed");
        let created = result.unwrap();
        assert_eq!(created.id, task.id);
        assert_eq!(created.url, task.url);
        assert_eq!(mock.enqueue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_enqueue_propagates_repository_error() {
        let mock = Arc::new(MockTaskRepository::failing());
        let queue = make_queue(mock.clone());
        let task = sample_task();
        let result = queue.enqueue(task).await;
        let err = result.expect_err("should propagate repository error");
        match err {
            QueueError::Repository(_) => {}
            other => panic!("expected QueueError::Repository, got {:?}", other),
        }
        assert_eq!(mock.enqueue_calls.load(Ordering::SeqCst), 1);
    }

    // dequeue happy path and empty queue

    #[tokio::test]
    async fn test_dequeue_empty_returns_none() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let worker_id = crate::domain::id::Id::generate();
        let result = queue.dequeue(worker_id).await;
        assert!(result.is_ok(), "dequeue on empty queue should succeed");
        assert!(result.unwrap().is_none(), "empty queue should return None");
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_dequeue_returns_next_task() {
        let task = sample_task();
        let mock = Arc::new(MockTaskRepository::with_next_task(task.clone()));
        let queue = make_queue(mock.clone());
        let worker_id = crate::domain::id::Id::generate();
        let result = queue.dequeue(worker_id).await;
        let dequeued = result
            .expect("dequeue should succeed")
            .expect("task expected");
        assert_eq!(dequeued.id, task.id);
        // Verify the worker_id was forwarded to the repository.
        assert_eq!(*mock.last_worker_id.lock(), Some(worker_id));
    }

    #[tokio::test]
    async fn test_depth_counter_clamps_at_zero_for_repository_direct_enqueues() {
        // crawl 子任务经 repository.create 直写入队(不经 queue.enqueue),
        // worker 仍走 queue.dequeue 扣减深度。负向漂移必须钳在 0:
        // u64 回绕会让后续 enqueue 的 `old + 1` 在 debug 构建溢出 panic
        // (BDD acceptance 曾表现为 connection closed before message completed),
        // release 则静默输出垃圾 queue_depth 指标。
        let mock = Arc::new(MockTaskRepository::with_next_task(sample_task()));
        let queue = make_queue(mock.clone());
        // 零入队先出队:深度不得回绕
        queue
            .dequeue(crate::domain::id::Id::generate())
            .await
            .expect("dequeue should succeed");
        assert_eq!(queue.depth.load(Ordering::Relaxed), 0);
        // 回绕已钳制后,正常入队深度回到 1(而非 panic)
        queue
            .enqueue(sample_task())
            .await
            .expect("enqueue should succeed");
        assert_eq!(queue.depth.load(Ordering::Relaxed), 1);
    }

    #[tokio::test]
    async fn test_dequeue_propagates_repository_error() {
        let mock = Arc::new(MockTaskRepository::failing());
        let queue = make_queue(mock.clone());
        let result = queue.dequeue(crate::domain::id::Id::generate()).await;
        let err = result.expect_err("should propagate repository error");
        match err {
            QueueError::Repository(_) => {}
            other => panic!("expected QueueError::Repository, got {:?}", other),
        }
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    // Test logger for covering debug! macro in dequeue

    use crate::test_utils::ensure_debug_logger;

    // debug! coverage tests

    #[tokio::test]
    async fn test_dequeue_logs_debug_with_task() {
        ensure_debug_logger();
        let task = sample_task();
        let mock = Arc::new(MockTaskRepository::with_next_task(task.clone()));
        let queue = make_queue(mock.clone());
        let worker_id = crate::domain::id::Id::generate();
        let result = queue.dequeue(worker_id).await;
        assert!(result.is_ok());
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_dequeue_logs_debug_empty_queue() {
        ensure_debug_logger();
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let worker_id = crate::domain::id::Id::generate();
        let result = queue.dequeue(worker_id).await;
        assert!(result.is_ok());
        assert!(result.unwrap().is_none());
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    // complete / fail / cancel happy paths

    #[tokio::test]
    async fn test_complete_calls_repository_and_returns_ok() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let task_id = crate::domain::id::Id::generate();
        queue
            .complete(task_id)
            .await
            .expect("complete should succeed");
        assert_eq!(mock.complete_calls.load(Ordering::SeqCst), 1);
        assert_eq!(*mock.last_task_id.lock(), Some(task_id));
    }

    #[tokio::test]
    async fn test_fail_calls_repository_and_returns_ok() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let task_id = crate::domain::id::Id::generate();
        queue.fail(task_id).await.expect("fail should succeed");
        assert_eq!(mock.fail_calls.load(Ordering::SeqCst), 1);
        assert_eq!(*mock.last_task_id.lock(), Some(task_id));
    }

    #[tokio::test]
    async fn test_cancel_calls_repository_and_returns_ok() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let task_id = crate::domain::id::Id::generate();
        queue.cancel(task_id).await.expect("cancel should succeed");
        assert_eq!(mock.cancel_calls.load(Ordering::SeqCst), 1);
        assert_eq!(*mock.last_task_id.lock(), Some(task_id));
    }

    // complete / fail / cancel error propagation

    #[tokio::test]
    async fn test_complete_propagates_repository_error() {
        let mock = Arc::new(MockTaskRepository::failing());
        let queue = make_queue(mock.clone());
        let result = queue.complete(crate::domain::id::Id::generate()).await;
        assert!(matches!(result, Err(QueueError::Repository(_))));
        assert_eq!(mock.complete_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_fail_propagates_repository_error() {
        let mock = Arc::new(MockTaskRepository::failing());
        let queue = make_queue(mock.clone());
        let result = queue.fail(crate::domain::id::Id::generate()).await;
        assert!(matches!(result, Err(QueueError::Repository(_))));
        assert_eq!(mock.fail_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_cancel_propagates_repository_error() {
        let mock = Arc::new(MockTaskRepository::failing());
        let queue = make_queue(mock.clone());
        let result = queue.cancel(crate::domain::id::Id::generate()).await;
        assert!(matches!(result, Err(QueueError::Repository(_))));
        assert_eq!(mock.cancel_calls.load(Ordering::SeqCst), 1);
    }

    // QueueError variants

    #[test]
    fn test_queue_error_repository_display() {
        let err = QueueError::Repository(db_error());
        let msg = err.to_string();
        assert!(msg.contains("Repository error"));
        assert!(msg.contains("mock database failure"));
    }

    #[test]
    fn test_queue_error_empty_display() {
        let err = QueueError::Empty;
        assert_eq!(err.to_string(), "Queue empty");
    }

    #[test]
    fn test_queue_error_repository_from_repository_error() {
        let repo_err = db_error();
        let queue_err: QueueError = repo_err.into();
        match queue_err {
            QueueError::Repository(_) => {}
            other => panic!("expected QueueError::Repository, got {:?}", other),
        }
    }

    // Arc<T> delegation impl

    #[tokio::test]
    async fn test_arc_delegation_enqueue() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<PostgresTaskQueue> = Arc::new(make_queue(mock.clone()));
        // Use the Arc<TaskQueue> impl: Arc<PostgresTaskQueue> delegates to TaskQueue.
        let task = sample_task();
        let result = queue.enqueue(task).await;
        assert!(result.is_ok());
        assert_eq!(mock.enqueue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_delegation_dequeue() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = Arc::new(make_queue(mock.clone()));
        let worker_id = crate::domain::id::Id::generate();
        let result = queue.dequeue(worker_id).await;
        assert!(result.is_ok());
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_delegation_complete() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = Arc::new(make_queue(mock.clone()));
        queue
            .complete(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert_eq!(mock.complete_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_delegation_fail() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = Arc::new(make_queue(mock.clone()));
        queue.fail(crate::domain::id::Id::generate()).await.unwrap();
        assert_eq!(mock.fail_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_delegation_cancel() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue = Arc::new(make_queue(mock.clone()));
        queue
            .cancel(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert_eq!(mock.cancel_calls.load(Ordering::SeqCst), 1);
    }

    // Integration: enqueue then dequeue

    #[tokio::test]
    async fn test_enqueue_then_dequeue_full_cycle() {
        // End-to-end: enqueue a task, then dequeue the configured next_task.
        let task = sample_task();
        let mock = Arc::new(MockTaskRepository::with_next_task(task.clone()));
        let queue = make_queue(mock.clone());

        // Dequeue first (the mock's next_task was pre-set).
        let dequeued = queue
            .dequeue(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert!(
            dequeued.is_some(),
            "configured next_task should be returned"
        );
        assert_eq!(dequeued.unwrap().id, task.id);

        // Second dequeue should return None (mock's next_task was taken).
        let second = queue
            .dequeue(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert!(second.is_none(), "second dequeue should return None");
    }

    #[tokio::test]
    async fn test_lifecycle_enqueue_complete_fail_cancel_independent() {
        // Verify each lifecycle method is independent and doesn't interfere.
        let mock = Arc::new(MockTaskRepository::new());
        let queue = make_queue(mock.clone());
        let id1 = crate::domain::id::Id::generate();
        let id2 = crate::domain::id::Id::generate();
        let id3 = crate::domain::id::Id::generate();

        queue.complete(id1).await.unwrap();
        queue.fail(id2).await.unwrap();
        queue.cancel(id3).await.unwrap();

        assert_eq!(mock.complete_calls.load(Ordering::SeqCst), 1);
        assert_eq!(mock.fail_calls.load(Ordering::SeqCst), 1);
        assert_eq!(mock.cancel_calls.load(Ordering::SeqCst), 1);
        // The last task_id recorded is the last call (cancel).
        assert_eq!(*mock.last_task_id.lock(), Some(id3));
    }

    // Arc<dyn TaskQueue> delegation tests
    // These tests cover the `impl<T: TaskQueue + ?Sized> TaskQueue for Arc<T>`
    // delegation methods (lines 148-164). Unlike `Arc<PostgresTaskQueue>` which
    // resolves to the direct impl via Deref, `Arc<dyn TaskQueue>` forces calls
    // through the generic Arc<T> impl because `dyn TaskQueue` is `?Sized`.

    #[tokio::test]
    async fn test_arc_dyn_delegation_enqueue() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<dyn TaskQueue> = Arc::new(make_queue(mock.clone()));
        let task = sample_task();
        let result = queue.enqueue(task).await;
        assert!(result.is_ok());
        assert_eq!(mock.enqueue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_dyn_delegation_dequeue() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<dyn TaskQueue> = Arc::new(make_queue(mock.clone()));
        let result = queue.dequeue(crate::domain::id::Id::generate()).await;
        assert!(result.is_ok());
        assert_eq!(mock.dequeue_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_dyn_delegation_complete() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<dyn TaskQueue> = Arc::new(make_queue(mock.clone()));
        queue
            .complete(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert_eq!(mock.complete_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_dyn_delegation_fail() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<dyn TaskQueue> = Arc::new(make_queue(mock.clone()));
        queue.fail(crate::domain::id::Id::generate()).await.unwrap();
        assert_eq!(mock.fail_calls.load(Ordering::SeqCst), 1);
    }

    #[tokio::test]
    async fn test_arc_dyn_delegation_cancel() {
        let mock = Arc::new(MockTaskRepository::new());
        let queue: Arc<dyn TaskQueue> = Arc::new(make_queue(mock.clone()));
        queue
            .cancel(crate::domain::id::Id::generate())
            .await
            .unwrap();
        assert_eq!(mock.cancel_calls.load(Ordering::SeqCst), 1);
    }
}