crawlrs 0.2.0

crawlrs - Enterprise-grade web scraping and crawling platform built with Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
// Copyright (c) 2025-2026 Kirky.X🌠
// SPDX-License-Identifier: Apache-2.0

//! API Key 签发 handler。
//!
//! ## 职责
//!
//! 接收 `POST /v1/admin/api-keys` 请求,调用 garrison `ApiKeyHandler::generate_with_namespace`
//! 签发新的 API Key(双段格式 `key_id.key_secret`),同时写入 crawlrs `api_keys` 表保留
//! `id`(api_key_id)/`team_id` 映射,供认证中间件反查。
//!
//! ## 设计
//!
//! - 明文 key 仅在响应中返回一次(CWE-916:garrison 不存明文 secret)
//! - garrison 管理哈希存储,crawlrs 的 `key_hash` 字段弃用(设为 `None`)
//! - crawlrs 的 `key` 字段存储 garrison `key_id`(公开标识,可安全记录到日志)
//! - 调用方必须持有 admin 权限(CWE-862 IDOR 防护)
//! - login_id = api_key_id 的 crate::domain::id::Id 字符串形式(约定,供中间件反向解析)
//!
//! ## Spec
//!
//! - 签发路径改调 garrison ApiKeyHandler

use crate::common::time_utils;
use crate::domain::auth::ScopePermission;
use crate::infrastructure::auth::get_garrison_dao;
use crate::infrastructure::database::entities::api_key::{ActiveModel, Entity};
use crate::infrastructure::database::entities::team::Entity as TeamEntity;
use crate::presentation::handlers::response_builder::{
    error_response, json_rejection_response, ApiResponse,
};
use crate::presentation::middleware::auth_middleware::AuthState;
use axum::{
    extract::Extension,
    http::{header, HeaderValue, StatusCode},
    response::{IntoResponse, Response},
    Json,
};
use chrono::Utc;
use dbnexus::sea_orm::EntityTrait;
use serde::{Deserialize, Serialize};
use std::sync::Arc;

/// garrison namespace,所有 crawlrs 签发的 API Key 都归属此 namespace。
const GARRISON_NAMESPACE: &str = "crawlrs";

/// 默认过期时间(30 天,秒)。
const DEFAULT_EXPIRES_IN_SECS: i64 = 30 * 24 * 60 * 60;

/// 最大过期时间(1 年,秒)。CWE-208:拒绝异常长 TTL 防止长期未轮换 key。
const MAX_EXPIRES_IN_SECS: i64 = 365 * 24 * 60 * 60;

/// 请求 scopes 数量上限。CWE-208:拒绝超大 scopes 数组导致 garrison 调用耗时增加。
const MAX_SCOPES_LEN: usize = 10;

/// crawlrs scope 字符串常量(请求体接收的 scope 值)。
const SCOPE_READ: &str = "read";
const SCOPE_WRITE: &str = "write";
const SCOPE_ADMIN: &str = "admin";

/// garrison 权限串前缀(与 `auth_bridge.rs::PERM_*` 一致)。
const PERM_PREFIX: &str = "crawlrs:";

/// `POST /v1/admin/api-keys` 请求体。
#[derive(Debug, Clone, Deserialize)]
pub struct CreateApiKeyRequest {
    /// API Key 归属的 team_id(必填,不能为 nil UUID)。
    pub team_id: crate::domain::id::Id,
    /// 作用域列表(必填,非空;元素仅允许 `"read"`/`"write"`/`"admin"`)。
    pub scopes: Vec<String>,
    /// 过期时间(秒,可选;缺省 30 天;必须 > 0 且 <= 1 年)。
    pub expires_in_secs: Option<i64>,
}

/// `POST /v1/admin/api-keys` 响应体。
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct CreateApiKeyResponse {
    /// 明文 API Key(双段格式 `key_id.key_secret`,仅此一次返回)。
    pub api_key: String,
    /// crawlrs 内部 API Key ID(UUID,对应 `api_keys.id`)。
    pub api_key_id: crate::domain::id::Id,
    /// 归属 team_id。
    pub team_id: crate::domain::id::Id,
    /// 作用域列表(与请求一致)。
    pub scopes: Vec<String>,
    /// 过期时间(RFC3339)。
    pub expires_at: String,
}

/// `POST /v1/admin/api-keys` handler。
///
/// 调用 garrison `ApiKeyHandler::generate_with_namespace` 签发新 API Key,
/// 同时在 crawlrs `api_keys` 表插入映射记录(`id`/`team_id`/`key`=`key_id`/`key_hash`=`None`)。
///
/// # 鉴权(单一防御点,CWE-862 IDOR 防护)
///
/// **本 handler 是 admin 权限校验的唯一防御点**。全局 `auth_middleware_inner`
/// 仅校验 API Key 有效性(garrison `check_api_key`),不强制 admin scope——
/// `scope_middleware` 虽存在但仅在测试 Router 中注册,未挂载到生产路由。
///
/// 调用方必须持有 `Admin` 权限(`auth_state.scope.has_permission(Admin)`),
/// 否则返回 403。后续若重构需保证此校验不被误删,否则即导致越权签发。
///
/// # 时序
///
/// `init_garrison_auth` 在 bootstrap 阶段注入 `GARRISON_DAO` 全局态,
/// 此 handler 在请求路径通过 `get_garrison_dao()` 读取(共享读锁,热路径无竞争)。
pub async fn create_api_key(
    Extension(auth_state): Extension<AuthState>,
    payload: Result<Json<CreateApiKeyRequest>, axum::extract::rejection::JsonRejection>,
) -> Response {
    // 提取器级拒绝(非法 JSON / 字段缺失)映射为统一包封,避免纯文本响应
    let Json(req) = match payload {
        Ok(parsed) => parsed,
        Err(ref rej) => return json_rejection_response(rej),
    };
    // 1. 鉴权:仅 admin 可签发新 key(CWE-862 IDOR 防护,单一防御点)
    if !auth_state.scope.has_permission(ScopePermission::Admin) {
        return error_response(
            StatusCode::FORBIDDEN,
            "Admin permission required to issue API keys",
        );
    }

    if let Err(msg) = validate_request(&req) {
        return error_response(StatusCode::BAD_REQUEST, msg);
    }

    // 3. team_id 存在性校验(DB schema 未声明外键约束,必须 handler 主动校验避免孤儿记录)
    let pool_for_check = auth_state.pool.clone();
    if let Err(e) = check_team_exists(&pool_for_check, req.team_id).await {
        log::warn!(
            "team_id existence check failed (team_id={}): {}",
            req.team_id,
            e
        );
        return error_response(
            StatusCode::INTERNAL_SERVER_ERROR,
            "Failed to validate team_id",
        );
    }

    // 4. 生成新 api_key_id(同时作为 garrison login_id 约定)
    let api_key_id = crate::domain::id::Id::generate();
    let expires_in_secs = req.expires_in_secs.unwrap_or(DEFAULT_EXPIRES_IN_SECS);
    let now = Utc::now();
    let expires_at = now + chrono::Duration::seconds(expires_in_secs);

    // 5. 映射 scopes 为 garrison 权限串(`"read"` → `"crawlrs:read"`,依此类推)
    let garrison_scopes = map_scopes_to_garrison_perms(&req.scopes);

    // 6-7. 获取 garrison DAO 并签发 API Key(明文 key 仅此一次可见)
    let plaintext_key = match issue_garrison_key(api_key_id, garrison_scopes, expires_in_secs).await
    {
        Ok(key) => key,
        Err(response) => return response,
    };

    // 8. 严格解析 garrison 返回的 `key_id.key_secret` 提取 key_id(公开标识,可安全记录)
    let garrison_key_id = match parse_garrison_key_id(&plaintext_key, api_key_id) {
        Ok(key_id) => key_id,
        Err(response) => return response,
    };

    // 9. 写入 crawlrs api_keys 表(id/team_id 映射,key_hash 弃用)
    match insert_api_key_mapping(&pool_for_check, api_key_id, req.team_id, garrison_key_id).await {
        Ok(()) => {
            let response = CreateApiKeyResponse {
                api_key: plaintext_key,
                api_key_id,
                team_id: req.team_id,
                scopes: req.scopes.clone(),
                expires_at: expires_at.to_rfc3339(),
            };
            created_api_key_response(response)
        }
        Err(e) => {
            log::error!(
                "Failed to insert api_key mapping (api_key_id={}, team_id={}): {}",
                api_key_id,
                req.team_id,
                e
            );
            error_response(
                StatusCode::INTERNAL_SERVER_ERROR,
                "Failed to persist API key mapping",
            )
        }
    }
}

/// 获取 garrison DAO 并签发 API Key。
///
/// DAO 未注入或签发失败时记录日志并返回已构建的 500 响应。
#[allow(clippy::result_large_err)]
async fn issue_garrison_key(
    api_key_id: crate::domain::id::Id,
    garrison_scopes: Vec<String>,
    expires_in_secs: i64,
) -> Result<String, Response> {
    let dao = match get_garrison_dao() {
        Some(d) => d,
        None => {
            log::error!(
                "garrison DAO not injected — call init_garrison_auth before serving requests"
            );
            return Err(error_response(
                StatusCode::INTERNAL_SERVER_ERROR,
                "Authentication service unavailable",
            ));
        }
    };

    let handler = garrison::protocol::apikey::ApiKeyHandler::new(dao);
    match handler
        .generate_with_namespace(
            api_key_id.to_string(),
            GARRISON_NAMESPACE,
            garrison_scopes,
            expires_in_secs,
        )
        .await
    {
        Ok(k) => Ok(k),
        Err(e) => {
            log::error!(
                "garrison ApiKeyHandler::generate_with_namespace failed: api_key_id={}, err={}",
                api_key_id,
                e
            );
            Err(error_response(
                StatusCode::INTERNAL_SERVER_ERROR,
                "Failed to issue API key",
            ))
        }
    }
}

/// 严格解析 garrison 返回的 `key_id.key_secret` 提取 `key_id`(公开标识,可安全记录)。
///
/// 原 `unwrap_or_else(|| plaintext_key.clone)` 在 garrison 返回异常格式
/// 时会把明文 secret 当作 key_id 写入 DB(CWE-916 违规)。改为严格校验:split_once 失败
/// 返回 500 错误且不写入 DB,并记录原始错误供排查。
#[allow(clippy::result_large_err)]
fn parse_garrison_key_id(
    plaintext_key: &str,
    api_key_id: crate::domain::id::Id,
) -> Result<String, Response> {
    match plaintext_key.split_once('.') {
        Some((k_id, _)) => Ok(k_id.to_string()),
        None => {
            log::error!(
                "garrison returned malformed key (no '.' separator): api_key_id={} (key length={})",
                api_key_id,
                plaintext_key.len()
            );
            Err(error_response(
                StatusCode::INTERNAL_SERVER_ERROR,
                "Authentication service returned malformed key",
            ))
        }
    }
}

/// 构造 201 响应:统一包封 + 禁用缓存头(响应含明文 API Key,CWE-525)。
fn created_api_key_response(response: CreateApiKeyResponse) -> Response {
    // Cache-Control: no-store(HTTP/1.1)+ Pragma: no-cache(HTTP/1.0 兼容)+ Expires: 0
    let mut resp = (StatusCode::CREATED, Json(ApiResponse::success(response))).into_response();
    resp.headers_mut()
        .insert(header::CACHE_CONTROL, HeaderValue::from_static("no-store"));
    resp.headers_mut()
        .insert(header::PRAGMA, HeaderValue::from_static("no-cache"));
    resp.headers_mut()
        .insert(header::EXPIRES, HeaderValue::from_static("0"));
    resp
}

/// 校验请求体。
///
/// # 规则
///
/// - `team_id` 不能为 nil UUID(CWE-862:所有 key 必须归属真实 team)
/// - `scopes` 非空,元素仅允许 `"read"`/`"write"`/`"admin"`,数量 <= `MAX_SCOPES_LEN`
///   (CWE-208:拒绝超大 scopes 数组导致 garrison 调用耗时增加)
/// - `expires_in_secs`(若提供)必须 > 0 且 <= 1 年(CWE-208:拒绝异常 TTL)
fn validate_request(req: &CreateApiKeyRequest) -> Result<(), String> {
    if req.team_id == crate::domain::id::Id::nil() {
        return Err("team_id must not be nil UUID".to_string());
    }
    if req.scopes.is_empty() {
        return Err("scopes must not be empty".to_string());
    }
    if req.scopes.len() > MAX_SCOPES_LEN {
        return Err(format!(
            "scopes length must not exceed {} (got {})",
            MAX_SCOPES_LEN,
            req.scopes.len()
        ));
    }
    for scope in &req.scopes {
        match scope.as_str() {
            SCOPE_READ | SCOPE_WRITE | SCOPE_ADMIN => {}
            other => {
                return Err(format!(
                    "invalid scope: {} (allowed: read/write/admin)",
                    other
                ));
            }
        }
    }
    if let Some(expires_in) = req.expires_in_secs {
        if expires_in <= 0 {
            return Err("expires_in_secs must be positive".to_string());
        }
        if expires_in > MAX_EXPIRES_IN_SECS {
            return Err(format!(
                "expires_in_secs must not exceed {} seconds (1 year)",
                MAX_EXPIRES_IN_SECS
            ));
        }
    }
    Ok(())
}

/// 校验 `team_id` 在 `teams` 表中存在。
///
/// # 背景
///
/// DB schema(`migrations/001_initial_schema.sql`)的 `api_keys.team_id` 列
/// **未声明** `FOREIGN KEY ... REFERENCES teams(id)` 约束,仅 `UUID NOT NULL`。
/// 故必须 handler 主动校验,否则会写入孤儿记录(破坏数据一致性)。
///
/// # 失败契约
///
/// - `Ok()`:team 存在
/// - `Err(dbnexus::sea_orm::DbErr)`:DB 查询失败(连接错误等),由调用方映射为 500
/// - `team_id` 不存在:返回 `Err(DbErr::RecordNotFound("team not found"))`(CWE-862 IDOR 防护)
async fn check_team_exists(
    pool: &Arc<dbnexus::DbPool>,
    team_id: crate::domain::id::Id,
) -> Result<(), dbnexus::sea_orm::DbErr> {
    let session = pool
        .get_session("admin")
        .await
        .map_err(|e| dbnexus::sea_orm::DbErr::Custom(format!("db session: {}", e)))?;
    let conn = session
        .connection()
        .map_err(|e| dbnexus::sea_orm::DbErr::Custom(format!("db conn: {}", e)))?;
    let row = TeamEntity::find_by_id(team_id).one(conn).await?;
    if row.is_some() {
        Ok(())
    } else {
        // 使用 RecordNotFound 而非 Custom,便于上层根据错误类型映射状态码
        Err(dbnexus::sea_orm::DbErr::RecordNotFound(format!(
            "team not found: {}",
            team_id
        )))
    }
}

/// 映射 crawlrs scope 字符串为 garrison 权限串。
///
/// # 输入约定
///
/// 调用前必须经 `validate_request` 校验,本函数对未知 scope 走 `unreachable!`
/// (确定性逻辑,不交给运行时判断)。
fn map_scopes_to_garrison_perms(scopes: &[String]) -> Vec<String> {
    scopes
        .iter()
        .map(|s| match s.as_str() {
            SCOPE_READ => format!("{}{}", PERM_PREFIX, SCOPE_READ),
            SCOPE_WRITE => format!("{}{}", PERM_PREFIX, SCOPE_WRITE),
            SCOPE_ADMIN => format!("{}{}", PERM_PREFIX, SCOPE_ADMIN),
            _ => unreachable!("validate_request guarantees the scope is valid"),
        })
        .collect()
}

/// 写入 `api_keys` 表(`id`/`team_id`/`key`=`garrison_key_id`/`key_hash`=`None`)。
///
/// # 失败契约(显性化)
///
/// 返回 `Err(dbnexus::sea_orm::DbErr)` 由调用方映射为 500,记录到 `log::error!`。
/// 常见失败场景:unique 冲突(极小概率,UUID 碰撞)/ DB 连接失败 / NOT NULL 约束。
///
async fn insert_api_key_mapping(
    pool: &Arc<dbnexus::DbPool>,
    api_key_id: crate::domain::id::Id,
    team_id: crate::domain::id::Id,
    garrison_key_id: String,
) -> Result<(), dbnexus::sea_orm::DbErr> {
    let session = pool
        .get_session("admin")
        .await
        .map_err(|e| dbnexus::sea_orm::DbErr::Custom(format!("db session: {}", e)))?;
    let conn = session
        .connection()
        .map_err(|e| dbnexus::sea_orm::DbErr::Custom(format!("db conn: {}", e)))?;
    let now = time_utils::to_db_datetime(Utc::now());
    let active = ActiveModel {
        id: dbnexus::sea_orm::ActiveValue::Set(api_key_id.into()),
        team_id: dbnexus::sea_orm::ActiveValue::Set(team_id.into()),
        key: dbnexus::sea_orm::ActiveValue::Set(garrison_key_id),
        // key_hash 弃用(garrison 自管 sha256(secret_hash))
        created_at: dbnexus::sea_orm::ActiveValue::Set(now),
        updated_at: dbnexus::sea_orm::ActiveValue::Set(None),
    };
    Entity::insert(active).exec(conn).await?;
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::common::test_helpers::{create_test_db_pool, skip_if_no_test_db};
    use crate::domain::auth::ApiKeyScope;
    use crate::infrastructure::auth::garrison_dao::{
        init_garrison_dao, reset_garrison_dao_for_test, set_garrison_dao,
    };
    use crate::infrastructure::database::entities::api_key::Entity as ApiKeyEntity;
    use crate::presentation::handlers::response_builder::ApiResponse;
    use axum::response::IntoResponse;
    use dbnexus::sea_orm::EntityTrait;

    // 测试辅助

    /// 构造一个 admin scope 的 AuthState(pool 指向测试 DB)。
    fn make_admin_auth_state() -> AuthState {
        let pool = create_test_db_pool();
        AuthState::new(
            pool,
            crate::domain::id::Id::generate(),
            crate::domain::id::Id::generate(),
            ApiKeyScope::full_access(),
        )
    }

    /// 构造一个非 admin scope 的 AuthState(read-only)。
    fn make_read_only_auth_state() -> AuthState {
        let pool = create_test_db_pool();
        AuthState::new(
            pool,
            crate::domain::id::Id::generate(),
            crate::domain::id::Id::generate(),
            ApiKeyScope::read_only(),
        )
    }

    /// 注入 garrison DAO 全局态(必须先调 `reset_garrison_dao_for_test()` 清理先前状态)。
    ///
    /// 原 `let _ = ...` 丢弃 `Result` 掩盖了「DAO 已注入」错误。
    /// 改为 panic 显性化失败——`Arc<dyn GarrisonDao>` 不实现 `Debug`,无法用 `.expect`,
    /// 故用 `if let Err(_) = ... { panic!(...) }` 模式。
    async fn inject_test_garrison_dao() {
        let dao = init_garrison_dao()
            .await
            .expect("init_garrison_dao must succeed in test");
        if set_garrison_dao(dao).is_err() {
            panic!(
                "set_garrison_dao failed: DAO already injected \
                 (call reset_garrison_dao_for_test() before inject)"
            );
        }
    }

    /// 在测试 DB 中创建 team 记录,满足 `check_team_exists` 校验。
    ///
    /// 原测试未创建 team 导致 `check_team_exists` 返回 `RecordNotFound`,
    /// handler 映射为 500 错误。此函数在调用 `create_api_key` 前预置 team。
    ///
    /// # Panics
    ///
    /// DB 写入失败时 panic(测试环境异常,不应静默)。
    async fn seed_team_in_db(pool: &Arc<dbnexus::DbPool>, team_id: crate::domain::id::Id) {
        use crate::infrastructure::database::entities::team::ActiveModel as TeamActiveModel;
        use dbnexus::sea_orm::ActiveValue;

        let session = pool
            .get_session("admin")
            .await
            .expect("get_session failed in seed_team_in_db");
        let conn = session
            .connection()
            .expect("connection failed in seed_team_in_db");
        let now = time_utils::to_db_datetime(Utc::now());
        let active = TeamActiveModel {
            id: ActiveValue::Set(team_id.into()),
            name: ActiveValue::Set(format!("test-team-{}", team_id)),
            allowed_countries: ActiveValue::Set(None),
            blocked_countries: ActiveValue::Set(None),
            ip_whitelist: ActiveValue::Set(None),
            domain_blacklist: ActiveValue::Set(None),
            enable_geo_restrictions: ActiveValue::Set(false),
            created_at: ActiveValue::Set(now),
            updated_at: ActiveValue::Set(now),
        };
        TeamEntity::insert(active)
            .exec(conn)
            .await
            .map(|_| ())
            // 并行测试共用同一数据库,其他测试可能已 seed 同一 team(固定 team_id),
            // 唯一约束冲突视为 seed 成功(幂等),其余错误仍然 panic。
            .or_else(|e| {
                let msg = e.to_string();
                if msg.contains("duplicate key") || msg.contains("23505") {
                    Ok(())
                } else {
                    Err(e)
                }
            })
            .expect("Failed to seed team in DB");
    }

    // ========== validate_request 测试 ==========

    #[test]
    fn test_validate_request_happy_path_minimal() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(3600),
        };
        assert!(validate_request(&req).is_ok());
    }

    #[test]
    fn test_validate_request_happy_path_all_scopes() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string(), "write".to_string(), "admin".to_string()],
            expires_in_secs: Some(86400),
        };
        assert!(validate_request(&req).is_ok());
    }

    #[test]
    fn test_validate_request_default_expires_ok() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["admin".to_string()],
            expires_in_secs: None,
        };
        assert!(validate_request(&req).is_ok());
    }

    #[test]
    fn test_validate_request_max_expires_ok() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(MAX_EXPIRES_IN_SECS),
        };
        assert!(validate_request(&req).is_ok());
    }

    #[test]
    fn test_validate_request_nil_team_id_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::nil(),
            scopes: vec!["read".to_string()],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("team_id"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_empty_scopes_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec![],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("scopes"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_invalid_scope_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["superuser".to_string()],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("invalid scope"), "err: {}", err);
        assert!(err.contains("superuser"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_mix_valid_invalid_scope_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string(), "delete".to_string()],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("delete"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_zero_expires_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(0),
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("positive"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_negative_expires_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(-1),
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("positive"), "err: {}", err);
    }

    #[test]
    fn test_validate_request_over_max_expires_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(MAX_EXPIRES_IN_SECS + 1),
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("1 year"), "err: {}", err);
    }

    /// scopes 数量超过 MAX_SCOPES_LEN 时必须被拒绝。
    #[test]
    fn test_validate_request_scopes_too_long_rejected() {
        // 构造 11 个 scope(超过 MAX_SCOPES_LEN=10)
        let oversized_scopes: Vec<String> =
            std::iter::repeat_n("read".to_string(), MAX_SCOPES_LEN + 1).collect();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: oversized_scopes,
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(
            err.contains("scopes length must not exceed"),
            "must reject oversized scopes, err: {}",
            err
        );
        assert!(err.contains(&MAX_SCOPES_LEN.to_string()));
    }

    /// 边界值测试:正好 MAX_SCOPES_LEN 个 scope 应通过校验。
    #[test]
    fn test_validate_request_scopes_at_limit_ok() {
        let scopes: Vec<String> = std::iter::repeat_n("read".to_string(), MAX_SCOPES_LEN).collect();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes,
            expires_in_secs: None,
        };
        assert!(
            validate_request(&req).is_ok(),
            "MAX_SCOPES_LEN boundary must pass"
        );
    }

    #[test]
    fn test_validate_request_empty_string_scope_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["".to_string()],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(err.contains("invalid scope"), "err: {}", err);
    }

    /// garrison 返回不含 '.' 的 malformed key 时,
    /// create_api_key 必须返回 500 且不写 DB(不将明文 secret 当 key_id 持久化)。
    ///
    /// 此测试为纯逻辑验证:通过 mock 替换 garrison ApiKeyHandler 不可行(garrison 类型不公开 mock trait),
    /// 故仅验证 split_once 解析逻辑的边界行为,确保 fallback 路径不会写入明文。
    #[test]
    fn test_garrison_key_parsing_rejects_no_separator() {
        // 模拟 garrison 返回的不含 '.' 的字符串
        let malformed_key = "no_separator_in_this_key_string";
        // 验证 split_once 解析失败
        assert!(malformed_key.split_once('.').is_none());
        // 修复后的 handler 在此场景返回 500 且不写 DB(已在 create_api_key 步骤 8 中实现)

        // 验证正常 garrison key(含 '.')能正确解析
        let normal_key = "abc123key_id.xyz456secret";
        let parsed = normal_key.split_once('.').map(|(k_id, _)| k_id.to_string());
        assert_eq!(parsed.as_deref(), Some("abc123key_id"));
    }

    #[test]
    fn test_validate_request_case_sensitive_scope_rejected() {
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["Read".to_string()],
            expires_in_secs: None,
        };
        let err = validate_request(&req).unwrap_err();
        assert!(
            err.contains("Read") || err.contains("invalid scope"),
            "err: {}",
            err
        );
    }

    #[test]
    fn test_validate_request_duplicate_scopes_ok() {
        // 重复 scope 不算错误(garrison 端去重,crawlrs 不强制唯一)
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string(), "read".to_string()],
            expires_in_secs: None,
        };
        assert!(validate_request(&req).is_ok());
    }

    // ========== map_scopes_to_garrison_perms 测试 ==========

    #[test]
    fn test_map_scopes_read_only() {
        let perms = map_scopes_to_garrison_perms(&["read".to_string()]);
        assert_eq!(perms, vec!["crawlrs:read".to_string()]);
    }

    #[test]
    fn test_map_scopes_write_only() {
        let perms = map_scopes_to_garrison_perms(&["write".to_string()]);
        assert_eq!(perms, vec!["crawlrs:write".to_string()]);
    }

    #[test]
    fn test_map_scopes_admin_only() {
        let perms = map_scopes_to_garrison_perms(&["admin".to_string()]);
        assert_eq!(perms, vec!["crawlrs:admin".to_string()]);
    }

    #[test]
    fn test_map_scopes_all_three() {
        let perms = map_scopes_to_garrison_perms(&[
            "read".to_string(),
            "write".to_string(),
            "admin".to_string(),
        ]);
        assert_eq!(
            perms,
            vec![
                "crawlrs:read".to_string(),
                "crawlrs:write".to_string(),
                "crawlrs:admin".to_string(),
            ]
        );
    }

    #[test]
    fn test_map_scopes_empty_input_returns_empty() {
        let perms = map_scopes_to_garrison_perms(&[]);
        assert!(perms.is_empty());
    }

    // ========== create_api_key 鉴权失败测试(不需要 garrison DAO / DB) ==========

    #[tokio::test]
    async fn test_create_api_key_non_admin_returns_403() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_read_only_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::FORBIDDEN);
    }

    #[tokio::test]
    async fn test_create_api_key_denied_scope_returns_403() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = AuthState::new(
            create_test_db_pool(),
            crate::domain::id::Id::generate(),
            crate::domain::id::Id::generate(),
            ApiKeyScope::denied(),
        );
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::FORBIDDEN);
    }

    #[tokio::test]
    async fn test_create_api_key_nil_team_id_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::nil(),
            scopes: vec!["read".to_string()],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_create_api_key_empty_scopes_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec![],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_create_api_key_invalid_scope_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["superuser".to_string()],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_create_api_key_zero_expires_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(0),
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_create_api_key_negative_expires_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(-100),
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    #[tokio::test]
    async fn test_create_api_key_over_max_expires_returns_400() {
        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(MAX_EXPIRES_IN_SECS + 1),
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::BAD_REQUEST);
    }

    // ========== create_api_key garrison DAO 未注入测试 ==========

    #[tokio::test]
    async fn test_create_api_key_dao_not_injected_returns_500() {
        // 不注入 DAO,验证返回 500(而非 panic)
        // 持有 TEST_MUTEX 到测试结束,避免其他测试注入 DAO 干扰本测试的"DAO 未注入"场景
        let _guard = crate::infrastructure::auth::garrison_dao::test_mutex()
            .lock()
            .await;
        reset_garrison_dao_for_test();

        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let req = CreateApiKeyRequest {
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_in_secs: None,
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::INTERNAL_SERVER_ERROR);
    }

    // ========== create_api_key 端到端测试(需要真实 DB + garrison DAO) ==========
    //
    // 以下测试需要 TEST_DATABASE_URL/DATABASE_URL 与 garrison sync_mode 多线程 runtime,
    // 跳过条件:无测试 DB。运行时使用 `multi_thread` flavor 驱动 garrison block_in_place。

    /// `key_hash` 字段已弃用(garrison 自管哈希),此测试验证新签发 key
    /// 的 `key_hash` 为 `None`,故需访问 deprecated 字段,加 `#[allow(deprecated)]`。
    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
    #[allow(deprecated)]
    async fn test_create_api_key_happy_path_admin_creates_key_for_any_team() {
        if skip_if_no_test_db() {
            return;
        }
        let _guard = crate::infrastructure::auth::garrison_dao::test_mutex()
            .lock()
            .await;
        reset_garrison_dao_for_test();
        inject_test_garrison_dao().await;

        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let target_team_id = crate::domain::id::Id::generate();
        // handler 步骤 3 的 `check_team_exists` 要求 team 存在,
        // 必须在调用 create_api_key 前预置 team 记录,否则返回 500。
        seed_team_in_db(&auth_state.pool, target_team_id).await;

        let req = CreateApiKeyRequest {
            team_id: target_team_id,
            scopes: vec!["read".to_string(), "write".to_string()],
            expires_in_secs: Some(3600),
        };

        let response = create_api_key(Extension(auth_state.clone()), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::CREATED);

        // 解析响应体
        let body = axum::body::to_bytes(response.into_body(), usize::MAX)
            .await
            .unwrap();
        let parsed: ApiResponse<CreateApiKeyResponse> = serde_json::from_slice(&body).unwrap();
        assert!(parsed.success);
        let data = parsed.data.unwrap();

        // 验证响应字段
        assert!(!data.api_key.is_empty(), "api_key must be non-empty");
        assert!(
            data.api_key.contains('.'),
            "api_key must be dual-segment format"
        );
        assert_eq!(data.team_id, target_team_id);
        assert_eq!(data.scopes, vec!["read".to_string(), "write".to_string()]);
        assert!(!data.expires_at.is_empty());

        // 验证 api_key_id 在 crawlrs api_keys 表中存在(且 team_id 匹配)
        let session = auth_state.pool.get_session("admin").await.unwrap();
        let conn = session.connection().unwrap();
        let row = ApiKeyEntity::find_by_id(data.api_key_id)
            .one(conn)
            .await
            .unwrap()
            .expect("api_key mapping must exist in DB after create");
        assert_eq!(target_team_id, row.team_id);
        assert_eq!(row.key, data.api_key.split_once('.').unwrap().0);

        reset_garrison_dao_for_test();
    }

    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
    async fn test_create_api_key_default_expires_used_when_none() {
        if skip_if_no_test_db() {
            return;
        }
        let _guard = crate::infrastructure::auth::garrison_dao::test_mutex()
            .lock()
            .await;
        reset_garrison_dao_for_test();
        inject_test_garrison_dao().await;

        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let target_team_id = crate::domain::id::Id::generate();
        seed_team_in_db(&auth_state.pool, target_team_id).await;
        let req = CreateApiKeyRequest {
            team_id: target_team_id,
            scopes: vec!["read".to_string()],
            expires_in_secs: None, // 测试默认值
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::CREATED);

        reset_garrison_dao_for_test();
    }

    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
    async fn test_create_api_key_admin_scope_single() {
        if skip_if_no_test_db() {
            return;
        }
        let _guard = crate::infrastructure::auth::garrison_dao::test_mutex()
            .lock()
            .await;
        reset_garrison_dao_for_test();
        inject_test_garrison_dao().await;

        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let target_team_id = crate::domain::id::Id::generate();
        seed_team_in_db(&auth_state.pool, target_team_id).await;
        let req = CreateApiKeyRequest {
            team_id: target_team_id,
            scopes: vec!["admin".to_string()],
            expires_in_secs: Some(86400),
        };

        let response = create_api_key(Extension(auth_state), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(response.status(), StatusCode::CREATED);

        reset_garrison_dao_for_test();
    }

    #[tokio::test(flavor = "multi_thread", worker_threads = 1)]
    async fn test_create_api_key_returns_distinct_keys_per_call() {
        if skip_if_no_test_db() {
            return;
        }
        let _guard = crate::infrastructure::auth::garrison_dao::test_mutex()
            .lock()
            .await;
        reset_garrison_dao_for_test();
        inject_test_garrison_dao().await;

        if skip_if_no_test_db() {
            return;
        }
        let auth_state = make_admin_auth_state();
        let target_team_id = crate::domain::id::Id::generate();
        seed_team_in_db(&auth_state.pool, target_team_id).await;
        let req = CreateApiKeyRequest {
            team_id: target_team_id,
            scopes: vec!["read".to_string()],
            expires_in_secs: Some(3600),
        };

        let resp1 = create_api_key(Extension(auth_state.clone()), Ok(Json(req.clone())))
            .await
            .into_response();
        let resp2 = create_api_key(Extension(auth_state.clone()), Ok(Json(req)))
            .await
            .into_response();

        assert_eq!(resp1.status(), StatusCode::CREATED);
        assert_eq!(resp2.status(), StatusCode::CREATED);

        // 解析两个响应,验证 api_key 不同
        let body1 = axum::body::to_bytes(resp1.into_body(), usize::MAX)
            .await
            .unwrap();
        let body2 = axum::body::to_bytes(resp2.into_body(), usize::MAX)
            .await
            .unwrap();
        let parsed1: ApiResponse<CreateApiKeyResponse> = serde_json::from_slice(&body1).unwrap();
        let parsed2: ApiResponse<CreateApiKeyResponse> = serde_json::from_slice(&body2).unwrap();
        assert_ne!(
            parsed1.data.unwrap().api_key,
            parsed2.data.unwrap().api_key,
            "consecutive generate calls must return distinct keys"
        );

        reset_garrison_dao_for_test();
    }

    // ========== 常量值测试(防止意外修改) ==========

    #[test]
    fn test_garrison_namespace_value() {
        assert_eq!(GARRISON_NAMESPACE, "crawlrs");
    }

    #[test]
    fn test_default_expires_in_secs_value() {
        assert_eq!(DEFAULT_EXPIRES_IN_SECS, 30 * 24 * 60 * 60);
    }

    #[test]
    fn test_max_expires_in_secs_value() {
        assert_eq!(MAX_EXPIRES_IN_SECS, 365 * 24 * 60 * 60);
    }

    #[test]
    fn test_scope_constants() {
        assert_eq!(SCOPE_READ, "read");
        assert_eq!(SCOPE_WRITE, "write");
        assert_eq!(SCOPE_ADMIN, "admin");
    }

    // ========== DTO 序列化测试 ==========

    #[test]
    fn test_create_api_key_request_deserialize_minimal() {
        let json = r#"{"team_id":"550e8400-e29b-41d4-a716-446655440000","scopes":["read"]}"#;
        let req: CreateApiKeyRequest = serde_json::from_str(json).unwrap();
        assert_eq!(
            req.team_id.to_string(),
            "550e8400-e29b-41d4-a716-446655440000"
        );
        assert_eq!(req.scopes, vec!["read".to_string()]);
        assert!(req.expires_in_secs.is_none());
    }

    #[test]
    fn test_create_api_key_request_deserialize_full() {
        let json = r#"{
            "team_id":"550e8400-e29b-41d4-a716-446655440000",
            "scopes":["read","write","admin"],
            "expires_in_secs":7200
        }"#;
        let req: CreateApiKeyRequest = serde_json::from_str(json).unwrap();
        assert_eq!(req.scopes.len(), 3);
        assert_eq!(req.expires_in_secs, Some(7200));
    }

    #[test]
    fn test_create_api_key_request_missing_team_id_fails() {
        let json = r#"{"scopes":["read"]}"#;
        let result: Result<CreateApiKeyRequest, _> = serde_json::from_str(json);
        assert!(result.is_err());
    }

    #[test]
    fn test_create_api_key_request_missing_scopes_fails() {
        let json = r#"{"team_id":"550e8400-e29b-41d4-a716-446655440000"}"#;
        let result: Result<CreateApiKeyRequest, _> = serde_json::from_str(json);
        assert!(result.is_err());
    }

    #[test]
    fn test_create_api_key_request_invalid_team_id_fails() {
        let json = r#"{"team_id":"not-a-uuid","scopes":["read"]}"#;
        let result: Result<CreateApiKeyRequest, _> = serde_json::from_str(json);
        assert!(result.is_err());
    }

    #[test]
    fn test_create_api_key_response_serialize() {
        let resp = CreateApiKeyResponse {
            api_key: "abc123.def456".to_string(),
            api_key_id: crate::domain::id::Id::generate(),
            team_id: crate::domain::id::Id::generate(),
            scopes: vec!["read".to_string()],
            expires_at: "2026-08-25T12:00:00Z".to_string(),
        };
        let json = serde_json::to_string(&resp).unwrap();
        let parsed: serde_json::Value = serde_json::from_str(&json).unwrap();
        assert_eq!(parsed["api_key"], "abc123.def456");
        assert!(parsed["api_key_id"].is_string());
        assert!(parsed["team_id"].is_string());
        assert_eq!(parsed["scopes"][0], "read");
        assert_eq!(parsed["expires_at"], "2026-08-25T12:00:00Z");
    }
}