crawlrs 0.2.0

crawlrs - Enterprise-grade web scraping and crawling platform built with Rust
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
// Copyright (c) 2025-2026 Kirky.X🌠
// SPDX-License-Identifier: Apache-2.0

//! Service for audit logging

use crate::common::error::CrawlRsError;
use crate::domain::auth::{ApiKeyScope, AuditDecision, AuditLogEntry};
use crate::domain::repositories::audit_log_repository::{AuditLogRepository, AuditRepositoryError};
use log::debug;
use std::sync::Arc;
use thiserror::Error;

// AuditLogBuilder 已拆分到独立文件(架构单一职责)
// 这里 re-export 保持外部 import 路径向后兼容:
// `crawlrs::domain::services::audit_service::AuditLogBuilder` 仍可用
pub use crate::domain::services::audit_log_builder::AuditLogBuilder;

#[derive(Debug, Error)]
pub enum AuditServiceError {
    #[error("Repository error: {0}")]
    RepositoryError(#[from] AuditRepositoryError),
}

impl From<AuditServiceError> for CrawlRsError {
    fn from(error: AuditServiceError) -> Self {
        match error {
            AuditServiceError::RepositoryError(repo_err) => match repo_err {
                AuditRepositoryError::DatabaseError(anyhow_err) => {
                    // platform 下尝试还原 DbErr(保留结构化信息);轻量面无 sea-orm,统一转字符串
                    #[cfg(any(feature = "platform", feature = "web-axum"))]
                    if let Some(db_err) = anyhow_err
                        .downcast_ref::<dbnexus::sea_orm::DbErr>()
                        .cloned()
                    {
                        return CrawlRsError::Database(db_err);
                    }
                    // 轻量面(platform 关)Database 变体为字符串载荷,保留 Database 语义;
                    // platform 下非 DbErr 的 anyhow 错误才落到 Other。
                    #[cfg(not(any(feature = "platform", feature = "web-axum")))]
                    return CrawlRsError::Database(anyhow_err.to_string());
                    #[cfg(any(feature = "platform", feature = "web-axum"))]
                    return CrawlRsError::Other(format!("Database error: {}", anyhow_err));
                }
                AuditRepositoryError::RateLimited { retry_after_secs } => {
                    let message = format!("Rate limited (retry_after={retry_after_secs:?})");
                    #[cfg(any(feature = "platform", feature = "web-axum"))]
                    return CrawlRsError::Database(dbnexus::sea_orm::DbErr::Custom(message));
                    #[cfg(not(any(feature = "platform", feature = "web-axum")))]
                    return CrawlRsError::Database(message);
                }
                AuditRepositoryError::VersionConflict { table, id } => {
                    let message = format!("Version conflict on table '{table}' for id {id}");
                    #[cfg(any(feature = "platform", feature = "web-axum"))]
                    return CrawlRsError::Database(dbnexus::sea_orm::DbErr::Custom(message));
                    #[cfg(not(any(feature = "platform", feature = "web-axum")))]
                    return CrawlRsError::Database(message);
                }
                AuditRepositoryError::NotFound => CrawlRsError::Other(repo_err.to_string()),
            },
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use std::net::Ipv4Addr;

    // AuditService tests

    use crate::domain::repositories::audit_log_repository::AuditLogRepository;
    use async_trait::async_trait;
    use std::sync::Mutex;

    /// Mock audit log repository that records all interactions.
    struct MockAuditLogRepository {
        /// All entries passed to create
        created: Mutex<Vec<AuditLogEntry>>,
        /// Entries to return from find_* methods
        find_results: Mutex<Vec<AuditLogEntry>>,
        /// Number of entries cleanup reports as deleted
        cleanup_count: u64,
        /// When true, all operations return an error
        fail_all: bool,
    }

    impl MockAuditLogRepository {
        fn new() -> Self {
            Self {
                created: Mutex::new(Vec::new()),
                find_results: Mutex::new(Vec::new()),
                cleanup_count: 0,
                fail_all: false,
            }
        }

        fn failing() -> Self {
            Self {
                created: Mutex::new(Vec::new()),
                find_results: Mutex::new(Vec::new()),
                cleanup_count: 0,
                fail_all: true,
            }
        }

        fn with_find_results(results: Vec<AuditLogEntry>) -> Self {
            Self {
                created: Mutex::new(Vec::new()),
                find_results: Mutex::new(results),
                cleanup_count: 0,
                fail_all: false,
            }
        }

        fn with_cleanup_count(count: u64) -> Self {
            Self {
                created: Mutex::new(Vec::new()),
                find_results: Mutex::new(Vec::new()),
                cleanup_count: count,
                fail_all: false,
            }
        }
    }

    impl Default for MockAuditLogRepository {
        fn default() -> Self {
            Self::new()
        }
    }

    #[async_trait]
    impl AuditLogRepository for MockAuditLogRepository {
        async fn create(
            &self,
            entry: &AuditLogEntry,
        ) -> Result<AuditLogEntry, AuditRepositoryError> {
            if self.fail_all {
                return Err(AuditRepositoryError::DatabaseError(
                    dbnexus::sea_orm::DbErr::Custom("mock create failure".to_string()).into(),
                ));
            }
            self.created
                .lock()
                .expect("created lock")
                .push(entry.clone());
            Ok(entry.clone())
        }

        async fn find_by_api_key_id(
            &self,
            _api_key_id: crate::domain::id::Id,
            _limit: u64,
            _offset: u64,
        ) -> Result<Vec<AuditLogEntry>, AuditRepositoryError> {
            if self.fail_all {
                return Err(AuditRepositoryError::DatabaseError(
                    dbnexus::sea_orm::DbErr::Custom("mock find failure".to_string()).into(),
                ));
            }
            Ok(self.find_results.lock().expect("find lock").clone())
        }

        async fn find_by_team_id(
            &self,
            _team_id: crate::domain::id::Id,
            _limit: u64,
            _offset: u64,
        ) -> Result<Vec<AuditLogEntry>, AuditRepositoryError> {
            if self.fail_all {
                return Err(AuditRepositoryError::DatabaseError(
                    dbnexus::sea_orm::DbErr::Custom("mock find failure".to_string()).into(),
                ));
            }
            Ok(self.find_results.lock().expect("find lock").clone())
        }

        async fn find_denied_for_key(
            &self,
            _api_key_id: crate::domain::id::Id,
            _limit: u64,
        ) -> Result<Vec<AuditLogEntry>, AuditRepositoryError> {
            if self.fail_all {
                return Err(AuditRepositoryError::DatabaseError(
                    dbnexus::sea_orm::DbErr::Custom("mock find failure".to_string()).into(),
                ));
            }
            Ok(self.find_results.lock().expect("find lock").clone())
        }

        async fn cleanup_old_logs(
            &self,
            _retention_days: i64,
        ) -> Result<u64, AuditRepositoryError> {
            if self.fail_all {
                return Err(AuditRepositoryError::DatabaseError(
                    dbnexus::sea_orm::DbErr::Custom("mock cleanup failure".to_string()).into(),
                ));
            }
            Ok(self.cleanup_count)
        }
    }

    fn sample_entry(action: &str, decision: AuditDecision) -> AuditLogEntry {
        AuditLogBuilder::new(action, decision)
            .with_api_key_id(crate::domain::id::Id::generate())
            .with_team_id(crate::domain::id::Id::generate())
            .build()
    }

    // AuditService::new / construction

    #[test]
    fn test_audit_service_new_constructs_service() {
        let repo: Arc<MockAuditLogRepository> = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        // Verify the service can be created; we exercise it via log below
        let _ = service.audit_repo.clone();
    }

    // AuditService::log

    #[tokio::test]
    async fn test_audit_service_log_success() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        let entry = sample_entry("search", AuditDecision::Allow);
        let result = service.log(entry.clone()).await;
        assert!(result.is_ok());
        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].requested_action, "search");
        assert_eq!(created[0].decision, AuditDecision::Allow);
    }

    #[tokio::test]
    async fn test_audit_service_log_repository_error_propagates() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let entry = sample_entry("search", AuditDecision::Allow);
        let result = service.log(entry).await;
        assert!(result.is_err());
        match result.unwrap_err() {
            AuditServiceError::RepositoryError(_) => {}
        }
    }

    // AuditService::log_allow

    #[tokio::test]
    async fn test_audit_service_log_allow_builds_allow_entry() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        let api_key_id = crate::domain::id::Id::generate();
        let team_id = crate::domain::id::Id::generate();
        let scope = ApiKeyScope::read_only();

        service
            .log_allow("scrape.create", api_key_id, team_id, scope.clone())
            .await
            .expect("log_allow should succeed");

        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].requested_action, "scrape.create");
        assert_eq!(created[0].decision, AuditDecision::Allow);
        assert_eq!(created[0].api_key_id, Some(api_key_id));
        assert_eq!(created[0].team_id, Some(team_id));
        assert_eq!(created[0].scope_used, Some(scope));
        // Allow entries have no denial reason
        assert!(created[0].denial_reason.is_none());
    }

    #[tokio::test]
    async fn test_audit_service_log_allow_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service
            .log_allow(
                "x",
                crate::domain::id::Id::generate(),
                crate::domain::id::Id::generate(),
                ApiKeyScope::default(),
            )
            .await;
        assert!(result.is_err());
    }

    // AuditService::log_deny

    #[tokio::test]
    async fn test_audit_service_log_deny_with_all_fields() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        let api_key_id = crate::domain::id::Id::generate();
        let team_id = crate::domain::id::Id::generate();
        let scope = ApiKeyScope::full_access();

        service
            .log_deny(
                "admin.delete",
                Some(api_key_id),
                Some(team_id),
                "insufficient scope",
                Some(scope.clone()),
            )
            .await
            .expect("log_deny should succeed");

        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].requested_action, "admin.delete");
        assert_eq!(created[0].decision, AuditDecision::Deny);
        assert_eq!(created[0].api_key_id, Some(api_key_id));
        assert_eq!(created[0].team_id, Some(team_id));
        assert_eq!(
            created[0].denial_reason.as_deref(),
            Some("insufficient scope")
        );
        assert_eq!(created[0].scope_used, Some(scope));
    }

    #[tokio::test]
    async fn test_audit_service_log_deny_with_none_fields_preserves_none() {
        // None 字段必须保留为 None(写入数据库 NULL),而非 unwrap_or_default
        // 转换为 nil UUID (`00000000-...`)。nil UUID 会被 find_by_api_key_id(nil_uuid) 误匹配,
        // 混淆真实 API key 的审计日志。
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());

        service
            .log_deny("anonymous.action", None, None, "auth required", None)
            .await
            .expect("log_deny should succeed");

        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].decision, AuditDecision::Deny);
        // None values must stay None (NULL in DB), not become nil UUID / default scope
        assert_eq!(created[0].api_key_id, None);
        assert_eq!(created[0].team_id, None);
        assert_eq!(created[0].scope_used, None);
        assert_eq!(created[0].denial_reason.as_deref(), Some("auth required"));
    }

    #[tokio::test]
    async fn test_audit_service_log_deny_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service
            .log_deny("x", None, None, "r".to_string(), None)
            .await;
        assert!(result.is_err());
    }

    // AuditService::get_logs_for_key

    #[tokio::test]
    async fn test_audit_service_get_logs_for_key_returns_results() {
        let entry1 = sample_entry("a1", AuditDecision::Allow);
        let entry2 = sample_entry("a2", AuditDecision::Deny);
        let repo = Arc::new(MockAuditLogRepository::with_find_results(vec![
            entry1.clone(),
            entry2.clone(),
        ]));
        let service = AuditService::new(repo);

        let results = service
            .get_logs_for_key(crate::domain::id::Id::generate(), 10, 0)
            .await
            .expect("get_logs_for_key should succeed");
        assert_eq!(results.len(), 2);
        assert_eq!(results[0].requested_action, "a1");
        assert_eq!(results[1].requested_action, "a2");
    }

    #[tokio::test]
    async fn test_audit_service_get_logs_for_key_empty() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo);
        let results = service
            .get_logs_for_key(crate::domain::id::Id::generate(), 10, 0)
            .await
            .expect("should succeed");
        assert!(results.is_empty());
    }

    #[tokio::test]
    async fn test_audit_service_get_logs_for_key_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service
            .get_logs_for_key(crate::domain::id::Id::generate(), 10, 0)
            .await;
        assert!(result.is_err());
    }

    // AuditService::get_logs_for_team

    #[tokio::test]
    async fn test_audit_service_get_logs_for_team_returns_results() {
        let entry = sample_entry("team_action", AuditDecision::Allow);
        let repo = Arc::new(MockAuditLogRepository::with_find_results(vec![
            entry.clone()
        ]));
        let service = AuditService::new(repo);

        let results = service
            .get_logs_for_team(crate::domain::id::Id::generate(), 50, 10)
            .await
            .expect("get_logs_for_team should succeed");
        assert_eq!(results.len(), 1);
        assert_eq!(results[0].requested_action, "team_action");
    }

    #[tokio::test]
    async fn test_audit_service_get_logs_for_team_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service
            .get_logs_for_team(crate::domain::id::Id::generate(), 50, 0)
            .await;
        assert!(result.is_err());
    }

    // AuditService::get_denied_requests

    #[tokio::test]
    async fn test_audit_service_get_denied_requests_returns_only_denied() {
        let denied1 = sample_entry("blocked1", AuditDecision::Deny);
        let denied2 = sample_entry("blocked2", AuditDecision::Deny);
        let repo = Arc::new(MockAuditLogRepository::with_find_results(vec![
            denied1.clone(),
            denied2.clone(),
        ]));
        let service = AuditService::new(repo);

        let results = service
            .get_denied_requests(crate::domain::id::Id::generate(), 100)
            .await
            .expect("get_denied_requests should succeed");
        assert_eq!(results.len(), 2);
        // All returned entries should be Deny decisions (mock returns what we gave it)
        assert!(results.iter().all(|r| r.decision == AuditDecision::Deny));
    }

    #[tokio::test]
    async fn test_audit_service_get_denied_requests_empty() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo);
        let results = service
            .get_denied_requests(crate::domain::id::Id::generate(), 100)
            .await
            .expect("should succeed");
        assert!(results.is_empty());
    }

    #[tokio::test]
    async fn test_audit_service_get_denied_requests_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service
            .get_denied_requests(crate::domain::id::Id::generate(), 100)
            .await;
        assert!(result.is_err());
    }

    // AuditService::cleanup_old_logs

    #[tokio::test]
    async fn test_audit_service_cleanup_old_logs_returns_count() {
        let repo = Arc::new(MockAuditLogRepository::with_cleanup_count(42));
        let service = AuditService::new(repo);
        let count = service
            .cleanup_old_logs(90)
            .await
            .expect("cleanup_old_logs should succeed");
        assert_eq!(count, 42);
    }

    #[tokio::test]
    async fn test_audit_service_cleanup_old_logs_zero() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo);
        let count = service.cleanup_old_logs(30).await.expect("should succeed");
        assert_eq!(count, 0);
    }

    #[tokio::test]
    async fn test_audit_service_cleanup_old_logs_repository_error() {
        let repo = Arc::new(MockAuditLogRepository::failing());
        let service = AuditService::new(repo);
        let result = service.cleanup_old_logs(30).await;
        assert!(result.is_err());
    }

    // AuditServiceTrait impl

    #[tokio::test]
    async fn test_audit_service_trait_log_delegates_to_log() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo.clone());
        let entry = sample_entry("trait_action", AuditDecision::Allow);

        // Use the trait method
        let result = AuditServiceTrait::log(&service, entry.clone()).await;
        assert!(result.is_ok());

        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].requested_action, "trait_action");
    }

    #[tokio::test]
    async fn test_audit_service_trait_log_allow() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo.clone());

        let result = AuditServiceTrait::log_allow(
            &service,
            "trait.allow".to_string(),
            crate::domain::id::Id::generate(),
            crate::domain::id::Id::generate(),
            ApiKeyScope::default(),
        )
        .await;
        assert!(result.is_ok());

        let created = repo.created.lock().expect("lock");
        assert_eq!(created[0].requested_action, "trait.allow");
        assert_eq!(created[0].decision, AuditDecision::Allow);
    }

    #[tokio::test]
    async fn test_audit_service_trait_log_deny() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo.clone());

        let result = AuditServiceTrait::log_deny(
            &service,
            "trait.deny".to_string(),
            None,
            None,
            "nope".to_string(),
            None,
        )
        .await;
        assert!(result.is_ok());

        let created = repo.created.lock().expect("lock");
        assert_eq!(created[0].requested_action, "trait.deny");
        assert_eq!(created[0].decision, AuditDecision::Deny);
        assert_eq!(created[0].denial_reason.as_deref(), Some("nope"));
    }

    #[tokio::test]
    async fn test_audit_service_trait_get_logs_for_key() {
        let entry = sample_entry("k", AuditDecision::Allow);
        let repo = Arc::new(MockAuditLogRepository::with_find_results(vec![entry]));
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo);

        let results =
            AuditServiceTrait::get_logs_for_key(&service, crate::domain::id::Id::generate(), 5, 0)
                .await
                .expect("trait get_logs_for_key should succeed");
        assert_eq!(results.len(), 1);
    }

    #[tokio::test]
    async fn test_audit_service_trait_get_logs_for_team() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo);

        let results =
            AuditServiceTrait::get_logs_for_team(&service, crate::domain::id::Id::generate(), 5, 0)
                .await
                .expect("trait get_logs_for_team should succeed");
        assert!(results.is_empty());
    }

    #[tokio::test]
    async fn test_audit_service_trait_get_denied_requests() {
        let repo = Arc::new(MockAuditLogRepository::new());
        let service: AuditService<MockAuditLogRepository> = AuditService::new(repo);

        let results =
            AuditServiceTrait::get_denied_requests(&service, crate::domain::id::Id::generate(), 5)
                .await
                .expect("trait get_denied_requests should succeed");
        assert!(results.is_empty());
    }

    // AuditServiceError From impls
    // 注意:AuditServiceError 已不再实现 From<dbnexus::sea_orm::DbErr>(分层违规)。
    // DbErr 必须先经 AuditRepositoryError::DatabaseError 包装,再 .into 为 AuditServiceError。

    #[test]
    fn test_audit_service_error_from_repository_db_error_to_app_error() {
        let repo_err = AuditRepositoryError::DatabaseError(
            dbnexus::sea_orm::DbErr::Custom("repo db failure".to_string()).into(),
        );
        let service_err: AuditServiceError = repo_err.into();
        let app_err: CrawlRsError = service_err.into();
        // DatabaseError variant of AuditRepositoryError should map to CrawlRsError::Database
        match app_err {
            CrawlRsError::Database(_) => {}
            other => panic!("expected CrawlRsError::Database, got {:?}", other),
        }
    }

    #[test]
    fn test_audit_service_error_from_repository_not_found_to_app_error_other() {
        let repo_err = AuditRepositoryError::NotFound;
        let service_err: AuditServiceError = repo_err.into();
        let app_err: CrawlRsError = service_err.into();
        // NotFound variant should map to CrawlRsError::Other (string)
        match app_err {
            CrawlRsError::Other(msg) => {
                assert!(msg.contains("Audit log not found"), "msg was: {}", msg);
            }
            other => panic!("expected CrawlRsError::Other, got {:?}", other),
        }
    }

    #[test]
    fn test_audit_service_error_display_repository() {
        let err = AuditServiceError::RepositoryError(AuditRepositoryError::NotFound);
        let msg = format!("{}", err);
        assert!(msg.contains("Repository error"));
        assert!(msg.contains("Audit log not found"));
    }

    #[test]
    fn test_audit_log_entry_getters_return_set_values() {
        let ip: std::net::IpAddr = Ipv4Addr::new(192, 168, 0, 1).into();
        let trace_id = crate::domain::id::Id::generate();
        let entry = AuditLogBuilder::new("action", AuditDecision::Allow)
            .with_ip_address(ip)
            .with_trace_id(trace_id)
            .with_user_agent("Agent/1.0")
            .with_request_path("/path")
            .with_request_method("POST")
            .build();

        assert_eq!(entry.ip_address(), Some(ip));
        assert_eq!(entry.trace_id(), Some(trace_id));
        assert_eq!(entry.user_agent(), Some("Agent/1.0"));
        assert_eq!(entry.request_path(), Some("/path"));
        assert_eq!(entry.request_method(), Some("POST"));
    }

    #[test]
    fn test_audit_log_entry_getters_return_none_when_unset() {
        let entry = AuditLogBuilder::new("action", AuditDecision::Allow).build();
        assert!(entry.ip_address().is_none());
        assert!(entry.trace_id().is_none());
        assert!(entry.user_agent().is_none());
        assert!(entry.request_path().is_none());
        assert!(entry.request_method().is_none());
    }

    // logger initialization to cover debug! macro argument lines

    use crate::test_utils::ensure_debug_logger;

    #[tokio::test]
    async fn test_audit_service_log_with_logger_covers_debug_macro_args() {
        ensure_debug_logger();
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        let entry = sample_entry("search", AuditDecision::Allow);
        let result = service.log(entry).await;
        assert!(result.is_ok());
        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
    }

    #[tokio::test]
    async fn test_audit_service_log_deny_with_logger_covers_debug_macro_args() {
        ensure_debug_logger();
        let repo = Arc::new(MockAuditLogRepository::new());
        let service = AuditService::new(repo.clone());
        let api_key_id = crate::domain::id::Id::generate();
        let team_id = crate::domain::id::Id::generate();
        let scope = ApiKeyScope::read_only();
        service
            .log_deny(
                "scrape.create".to_string(),
                Some(api_key_id),
                Some(team_id),
                "denied for test".to_string(),
                Some(scope),
            )
            .await
            .expect("log_deny should succeed");
        let created = repo.created.lock().expect("lock");
        assert_eq!(created.len(), 1);
        assert_eq!(created[0].decision, AuditDecision::Deny);
    }
}

/// Trait for AuditService - enables dependency injection
#[async_trait::async_trait]
pub trait AuditServiceTrait: Send + Sync {
    /// Create a new audit log entry
    async fn log(&self, entry: AuditLogEntry) -> Result<(), AuditServiceError>;

    /// Log an allow decision
    async fn log_allow(
        &self,
        action: String,
        api_key_id: crate::domain::id::Id,
        team_id: crate::domain::id::Id,
        scope: ApiKeyScope,
    ) -> Result<(), AuditServiceError>;

    /// Log a deny decision
    async fn log_deny(
        &self,
        action: String,
        api_key_id: Option<crate::domain::id::Id>,
        team_id: Option<crate::domain::id::Id>,
        reason: String,
        scope: Option<ApiKeyScope>,
    ) -> Result<(), AuditServiceError>;

    /// Get audit logs for an API Key
    async fn get_logs_for_key(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError>;

    /// Get audit logs for a team
    async fn get_logs_for_team(
        &self,
        team_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError>;

    /// Get denied requests for an API Key
    async fn get_denied_requests(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError>;
}

/// Service for managing audit logs
#[derive(Clone)]
pub struct AuditService<R: AuditLogRepository> {
    audit_repo: Arc<R>,
}

impl<R: AuditLogRepository> AuditService<R> {
    /// Create a new service
    pub fn new(audit_repo: Arc<R>) -> Self {
        Self { audit_repo }
    }

    /// Create a new audit log entry
    pub async fn log_internal(&self, entry: AuditLogEntry) -> Result<(), AuditServiceError> {
        debug!(
            "Creating audit log: action={}, decision={}",
            entry.requested_action, entry.decision
        );
        self.audit_repo
            .create(&entry)
            .await
            .map(|_| ())
            .map_err(Into::into)
    }

    /// Log an allow decision
    pub async fn log_allow_internal(
        &self,
        action: impl Into<String>,
        api_key_id: crate::domain::id::Id,
        team_id: crate::domain::id::Id,
        scope: ApiKeyScope,
    ) -> Result<(), AuditServiceError> {
        let entry = AuditLogBuilder::new(action, AuditDecision::Allow)
            .with_api_key_id(api_key_id)
            .with_team_id(team_id)
            .with_scope(scope)
            .build();

        self.log_internal(entry).await
    }

    /// Log a deny decision
    pub async fn log_deny_internal(
        &self,
        action: impl Into<String>,
        api_key_id: Option<crate::domain::id::Id>,
        team_id: Option<crate::domain::id::Id>,
        reason: impl Into<String>,
        scope: Option<ApiKeyScope>,
    ) -> Result<(), AuditServiceError> {
        // 用 maybe_with_* 保留 None 语义:未认证拒绝场景下 api_key_id/team_id 为 None,
        // 写入 NULL 而非 nil UUID,避免 find_by_api_key_id(nil_uuid) 误匹配。
        let entry = AuditLogBuilder::new(action, AuditDecision::Deny)
            .maybe_with_api_key_id(api_key_id)
            .maybe_with_team_id(team_id)
            .with_denial_reason(reason)
            .maybe_with_scope(scope)
            .build();

        self.log_internal(entry).await
    }

    /// Create a new audit log entry (public wrapper)
    pub async fn log(&self, entry: AuditLogEntry) -> Result<(), AuditServiceError> {
        self.log_internal(entry).await
    }

    /// Log an allow decision (public wrapper)
    pub async fn log_allow(
        &self,
        action: impl Into<String>,
        api_key_id: crate::domain::id::Id,
        team_id: crate::domain::id::Id,
        scope: ApiKeyScope,
    ) -> Result<(), AuditServiceError> {
        self.log_allow_internal(action, api_key_id, team_id, scope)
            .await
    }

    /// Log a deny decision (public wrapper)
    pub async fn log_deny(
        &self,
        action: impl Into<String>,
        api_key_id: Option<crate::domain::id::Id>,
        team_id: Option<crate::domain::id::Id>,
        reason: impl Into<String>,
        scope: Option<ApiKeyScope>,
    ) -> Result<(), AuditServiceError> {
        self.log_deny_internal(action, api_key_id, team_id, reason, scope)
            .await
    }

    /// Get audit logs for an API Key
    pub async fn get_logs_for_key(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_by_api_key_id(api_key_id, limit, offset)
            .await
            .map_err(Into::into)
    }

    /// Get audit logs for a team
    pub async fn get_logs_for_team(
        &self,
        team_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_by_team_id(team_id, limit, offset)
            .await
            .map_err(Into::into)
    }

    /// Get denied requests for an API Key
    pub async fn get_denied_requests(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_denied_for_key(api_key_id, limit)
            .await
            .map_err(Into::into)
    }

    /// Clean up old audit logs
    pub async fn cleanup_old_logs(&self, retention_days: i64) -> Result<u64, AuditServiceError> {
        self.audit_repo
            .cleanup_old_logs(retention_days)
            .await
            .map_err(Into::into)
    }
}

#[async_trait::async_trait]
impl<R: AuditLogRepository + 'static> AuditServiceTrait for AuditService<R> {
    async fn log(&self, entry: AuditLogEntry) -> Result<(), AuditServiceError> {
        self.log_internal(entry).await
    }

    async fn log_allow(
        &self,
        action: String,
        api_key_id: crate::domain::id::Id,
        team_id: crate::domain::id::Id,
        scope: ApiKeyScope,
    ) -> Result<(), AuditServiceError> {
        self.log_allow_internal(action, api_key_id, team_id, scope)
            .await
    }

    async fn log_deny(
        &self,
        action: String,
        api_key_id: Option<crate::domain::id::Id>,
        team_id: Option<crate::domain::id::Id>,
        reason: String,
        scope: Option<ApiKeyScope>,
    ) -> Result<(), AuditServiceError> {
        self.log_deny_internal(action, api_key_id, team_id, reason, scope)
            .await
    }

    async fn get_logs_for_key(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_by_api_key_id(api_key_id, limit, offset)
            .await
            .map_err(Into::into)
    }

    async fn get_logs_for_team(
        &self,
        team_id: crate::domain::id::Id,
        limit: u64,
        offset: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_by_team_id(team_id, limit, offset)
            .await
            .map_err(Into::into)
    }

    async fn get_denied_requests(
        &self,
        api_key_id: crate::domain::id::Id,
        limit: u64,
    ) -> Result<Vec<AuditLogEntry>, AuditServiceError> {
        self.audit_repo
            .find_denied_for_key(api_key_id, limit)
            .await
            .map_err(Into::into)
    }
}