cpp_ls 0.2.0

//! # `textDocument/documentSymbol` — the file's own structure
//!
//! The one handler whose query is deliberately **not** the cooked reading. Every other feature asks what a compiler
//! makes of the file; an outline asks what the file **is**, and the two answers differ in both directions:
//!
//! ```text
//! #if 0                                in the outline (the reader is editing it), never compiled
//! struct Never { int x; };
//! #endif
//! DECLARE_HANDLE(HWND);                not in the outline: the file writes a call, not a declaration
//! ```
//!
//! So the tree comes from the file's own declarations ([`cpp_code_analysis::FileSummary::outline`]) and the nesting
//! from their scopes — a class's members under the class, a namespace's contents under the namespace.
//!
//! # Two ranges per symbol, and the client needs both
//!
//! `range` is the **whole declaration** and `selection_range` is the **name**: a client folds or highlights with
//! the first and puts the cursor, the breadcrumb and the rename box on the second. The protocol requires the second
//! to be inside the first, which is a property of the facts rather than something this layer arranges — a
//! declaration's name is written inside it — but a fact read out of a *recovered* parse can have a range that does
//! not hold, so the pair is checked here and the name's range is used for both when it does not. A client that
//! rejected an outline because one entry's ranges disagreed would show nothing at all.
//!
//! # Freshness, which for this feature is the whole game
//!
//! An outline is refreshed as the user types, and a file's summary is dropped the moment it is edited. That is why
//! [`cpp_code_analysis::Session::outline`] falls back to the buffer's own parse: the alternative is a panel that
//! blinks empty between a keystroke and the next drain.

use cpp_code_analysis::{FileView, OutlineSymbol};
use lsp_types::{
    ClientCapabilities, DocumentSymbol, DocumentSymbolParams, DocumentSymbolResponse, OneOf,
    Position, Range, ServerCapabilities,
};
use tokio_util::sync::CancellationToken;

use super::RegisterCapabilities;
use crate::context::{RequestOutcome, ServerContextSnapshot, snapshot_query};
use crate::util::{symbol_kind, uri_to_file_path};

pub async fn on_document_symbol(
    context: ServerContextSnapshot,
    params: DocumentSymbolParams,
    cancel_token: CancellationToken,
) -> RequestOutcome<DocumentSymbolResponse> {
    let uri = params.text_document.uri;

    // Read in first, under the write lock: an outline of a file nobody has read would be an empty outline, which is
    // a wrong answer rather than a missing one.
    if let Some(path) = uri_to_file_path(&uri) {
        context.analysis().prepare(&path).await;
    }

    snapshot_query(context.analysis(), cancel_token, move |session| {
        let path = uri_to_file_path(&uri)?;
        // **The file's own text, not the reading a compiler takes of it.** An outline is about the file: a
        // declaration in a branch nobody takes belongs in it, and a type a macro declares does not — see
        // [`cpp_code_analysis::Session::outline`] for the measurement. This also makes the answer independent of
        // whether a rendering exists yet, which is the state a file is in between a keystroke and the next drain.
        let view = session.view_of_the_file(&path)?;
        let outline = session.outline(&view);

        Some(DocumentSymbolResponse::Nested(symbols(&view, &outline)))
    })
    .await
}

/// The outline, as the protocol's nested symbols.
///
/// A plain function rather than a closure in the handler, so that a test can build one from a view without a
/// client, a URI and a `params` value. The session does not appear because it is not needed: the facts have already
/// been read into the outline ([`Session::outline`]), and everything below is a conversion.
pub fn symbols(view: &FileView, outline: &[OutlineSymbol]) -> Vec<DocumentSymbol> {
    outline
        .iter()
        .map(|symbol| document_symbol(view, symbol))
        .collect()
}

fn document_symbol(view: &FileView, symbol: &OutlineSymbol) -> DocumentSymbol {
    let fact = &symbol.fact;
    // **Both ranges are the file's, and `declaration_range` is written to answer in the file's.**
    //
    // It reads the fact (the file's) and converts it into the reading before walking the tree, so what it returns is
    // already back in the file's coordinates — no placement step here. Placing it as well was measured and is wrong:
    // the widened range for `after_the_macro` came out `29..46`, which is line 4 column 0, and `file_range_of` read
    // those numbers as *rendering* offsets and answered `16..44` — line 2, the `BEFORE` line.
    let whole = range_in_file(view, declaration_range(view, fact));
    let name = range_in_file(view, fact.name_range);

    // **The protocol's one invariant about this pair**: `selection_range` is inside `range`. Asking for the name's
    // range twice when it is not keeps the entry (its kind and its nesting are still right) instead of handing a
    // client a symbol it may reject.
    let (range, selection_range) = match (whole, name) {
        (Some(whole), Some(name)) if name.start >= whole.start && name.end <= whole.end => {
            (whole, name)
        }
        (_, Some(name)) => (name, name),
        (Some(whole), None) => (whole, whole),
        (None, None) => (Range::default(), Range::default()),
    };

    // The schema this crate builds against still **requires** `deprecated`, and `tags` is the modern spelling of the
    // same idea — so the field is written once, empty, and the deprecation is allowed here rather than left as a
    // warning: leaving it out does not compile, and a server that has nothing to deprecate sets neither.
    #[allow(deprecated)]
    DocumentSymbol {
        name: fact.name.clone(),
        // What the label does not say: the scope a member was written in (`ns::Widget`).
        detail: fact.scope.clone(),
        kind: symbol_kind(fact.kind),
        tags: None,
        deprecated: None,
        range,
        selection_range,
        children: Some(
            symbol
                .children
                .iter()
                .map(|child| document_symbol(view, child))
                .collect(),
        ),
    }
}

/// **The range a client folds and draws a breadcrumb with** — the whole declaration, not just its declarator.
///
/// A binding records its **declarator**, which is right for the many consumers that ask "what does this name
/// declare" and wrong for this one: the protocol documents `DocumentSymbol.range` as the range *"enclosing this
/// symbol"*, and measured on
///
/// ```text
/// struct Widget {
///     int size;
///     int scaled(int factor) const;
/// };
/// ```
///
/// `size`'s declarator is `"size"` and `scaled`'s is `"int scaled(int factor) const"` — so the first folded nothing
/// at all while the second looked right.
///
/// The name's own node is found first and the declaration is asked of its **ancestors**, which is the only walk
/// whose answer does not depend on how the shapes nest. Every earlier version searched *downward* and each was wrong
/// for a different shape: an offset alone cannot tell "the declaration I am inside" from "an enclosing declaration
/// that contains me too", and a `template <…>` header puts those very far apart because it is a **sibling** of what
/// it applies to rather than its parent:
///
/// ```text
/// Syntax(Declaration)@0..648          `template <class Scenario>` and the function together
///   Syntax(TemplateDecl)@0..25        the header — and the name is NOT inside it
///   Syntax(DeclSpecifierSeq)@26..40   `constexpr void`
///   Syntax(InitDeclarator)@41..44     `f`
///   Syntax(CompoundStat)@…            the body
/// ```
///
/// Measured: `test_triviality_of_assignment` came back as `0:0..17:0` — the header through the function's `}` —
/// so selecting it in an editor highlighted the `template` line as well, which is what was reported.
///
/// The declaration is used only when it holds **exactly one** declarator. With two, `int a, b;`, the whole
/// declaration is the wrong answer for either name and the fact's declarator is the best available one.
fn declaration_range(
    view: &FileView,
    fact: &cpp_code_analysis::DeclFact,
) -> cpp_parser::SourceRange {
    let at = fact.name_range.start_offset;

    // **The fact's offset is the file's and the tree's are the rendering's**, so one has to be moved before they can
    // be compared. This is the defect that made a selection highlight the wrong place, and it is worth stating
    // plainly because both halves look right on their own:
    //
    // * `fact` comes from the analysis, which places its ranges **into the file** — `FileSummary::map_into_the_file`
    //   for a stored summary, and the same intent for a buffer — because that is what a client speaks;
    // * `view.root` is the parse of `view.source`, and when that is a rendering every offset in it is the
    //   rendering's.
    //
    // Measured on a file that includes a header defining `BEFORE` as five declarations and invokes it. The file is
    // twelve lines and the rendering is one, so the two agree only up to the invocation:
    //
    // ```text
    // fact.range.start = 29   →  line 4, column 0 of the FILE: `void after_the_macro() {`
    //                            offset 29 of the RENDERING: the middle of `after_the_macro`
    // ```
    //
    // Walking the tree at 29 therefore found the *name* and answered `"after_the_macro()"` where the declaration is
    // `void after_the_macro() { … }`, and for the next declaration it landed one byte into the identifier and
    // answered `"oid last_one() {…"`. So the offset is converted first, and a fact that cannot be converted keeps
    // its own range rather than being searched for at an offset that means something else.
    let Some(at) = view
        .reading_offset_of(cpp_code_analysis::file::coordinates::FileOffset::new(at))
        .map(|offset| offset.get())
    else {
        return fact.range;
    };

    let Some(name_node) = innermost_holding(&view.root, at) else {
        return fact.range;
    };
    let Some(declaration) = name_node.ancestors().find(|node| {
        cpp_parser::CppSyntaxKind::from(node.kind()) == cpp_parser::CppSyntaxKind::Declaration
    }) else {
        return fact.range;
    };

    let declarators = declaration
        .children()
        .filter(|inner| {
            matches!(
                cpp_parser::CppSyntaxKind::from(inner.kind()),
                cpp_parser::CppSyntaxKind::InitDeclarator | cpp_parser::CppSyntaxKind::Declarator
            )
        })
        .count();
    if declarators != 1 {
        return fact.range;
    }

    let start = declaration_start(&declaration);
    let mut end = usize::from(declaration.text_range().end());

    // **The body needs no separate search.** It was looked for as the declaration's next sibling — the shape a
    // definition once had — and every shape was measured against that loop: it answered `None` for all of them,
    // because a declaration that holds a body already ends at it. Recorded because the loop was here for several
    // revisions and the reason it could go is the measurement, not a hunch:
    //
    //     void plain() { }                    node=Declaration 53..83   body_after=None
    //     template <…> void templated() { }    node=Declaration 0..53    body_after=None
    //     WithCtor(int a) : value(a) { }       inside its declaration too
    //
    // So the only thing wrong with the end was the trivia it absorbed, below.

    // **Backed up over the trivia the declaration absorbed.** A `Declaration` that holds its body runs to the
    // whitespace **after** the body's `}`, so its own end lands on the blank line that follows the function —
    // measured on a three-line definition, the node ended at offset 83 while its `}` was at 81, and a client folded
    // one line too many: `plain` came out `5:0..9:0` where the function is `5:0..7:1`.
    //
    // So the end is the last **significant** token's, found inside the declaration rather than taken from its span.
    // `is_trivia` is the tree's own predicate — whitespace, newlines, line splices and comments — which is exactly
    // the set a body may absorb and a symbol's range must not claim. Collected first because the tree's own
    // iterators are forward-only.
    let significant_end = declaration
        .descendants_with_tokens()
        .filter_map(|element| element.into_token())
        .filter(|token| !cpp_parser::is_trivia(cpp_parser::CppTokenKind::from(token.kind())))
        .map(|token| usize::from(token.text_range().end()))
        .collect::<Vec<_>>()
        .into_iter()
        .next_back();
    if let Some(significant_end) = significant_end
        && significant_end < end
    {
        end = significant_end;
    }

    let range = cpp_parser::SourceRange::new(start, end.saturating_sub(start));

    // **Back into the file's coordinates**, because everything above this line walked the tree.
    //
    // `start` and `end` are offsets of `view.root`, and a view of a rendering has its own numbering — the caller
    // (`document_symbol`) draws positions in the file's, and so does the fact this is compared against below. The
    // conversion is the same `file_range_of` the caller would have had to use, done here so that the function's
    // contract is one coordinate system rather than two; measured before this, the range was answered in the
    // rendering's and came out on the `BEFORE` line.
    //
    // A range no span covers keeps the tree's numbers and is then refused by the containment test below, which is
    // the honest outcome: a range the file does not contain is not this declaration's.
    let range = view.file_range_of(range).unwrap_or(range);

    // Wider than the fact and still holding the name — otherwise the declarator is the honest answer.
    if range.start_offset <= fact.name_range.start_offset
        && range.end_offset() >= fact.name_range.end_offset()
    {
        range
    } else {
        fact.range
    }
}

/// **Where the declaration begins** — past a template head, when it has one.
///
/// Measured on the shapes a header is made of, with the reported case among them:
///
/// ```text
/// template <class T> void templated() { }    range began at `template`   ✗
/// template <class T> class C { };            range began at `template`   ✓ — but only because
///                                                                           the head is the whole node's start
/// template <class T> using A = T;            `using A = T;`             ✓
/// void plain() { }                           `void plain() { }`         ✓
/// class Outer { … };                         `class Outer { … };`       ✓
/// ```
///
/// So **the tree is not wrong about templates in general** — it is wrong about one thing, and this is the whole of
/// it: the head is the declaration's **first child**, so the declaration's own start includes it. A `using`, a
/// `concept` and a `typedef` are dispatched to their own rules that return before the declaration is built, which is
/// why they are unaffected; a class is written `template <class T> class C` and its name is inside the head's
/// reach anyway.
///
/// # Why this is a traversal fix and not a grammar change
///
/// Because a `Declaration` that contains its head **is a faithful record of what is written**: the head applies to
/// the declaration, the two are adjacent, and the tree is lossless about it. What was wrong was the question this
/// file asked of the tree — *"where does the declaration start"* read as *"where does this node start"*, and those
/// differ by exactly one child. The grammar change I first reached for (a second `Declaration` marker after the
/// head) would have made the tree **less** faithful to the file's own spelling in order to make one consumer's
/// arithmetic easier, and would have needed the marker closed on six exit paths.
///
/// The predicate is "the first child is a `TemplateDecl`" rather than "the node starts with `template`": a head
/// written inside a conditional is still one node, and asking the tree about its own children is asking about the
/// thing that is there rather than about the bytes.
fn declaration_start(declaration: &cpp_parser::CppSyntaxNode) -> usize {
    let mut children = declaration.children();
    let Some(first) = children.next() else {
        return usize::from(declaration.text_range().start());
    };
    if cpp_parser::CppSyntaxKind::from(first.kind()) != cpp_parser::CppSyntaxKind::TemplateDecl {
        return usize::from(declaration.text_range().start());
    }

    // The next child, which is the declaration itself: `children()` yields **nodes**, so the whitespace and any
    // comment between the head and what it heads are not in this list and need no filter.
    children
        .next()
        .map(|child| usize::from(child.text_range().start()))
        .unwrap_or_else(|| usize::from(declaration.text_range().start()))
}

/// **The deepest node containing `offset`** — the node the offset names rather than any of its ancestors.
fn innermost_holding(
    root: &cpp_parser::CppSyntaxNode,
    offset: usize,
) -> Option<cpp_parser::CppSyntaxNode> {
    let mut node = root.clone();
    while let Some(next) = node.children().find(|child| {
        let range = child.text_range();
        usize::from(range.start()) <= offset && offset < usize::from(range.end())
    }) {
        node = next;
    }
    Some(node)
}

/// A source range as a place in the file, through **the file's own** line index.
///
/// # Why this is not [`crate::util::position_at_offset`], which every other handler uses
///
/// Because an outline's offsets are not in the reading. `position_at_offset` takes a [`ReadingOffset`] and maps it
/// through `FileView::file_offset_of` — the rendering-to-file seam, for a span the parser produced. An outline is
/// built from the file's **own** declarations ([`cpp_code_analysis::FileSummary::outline`], or the buffer's own
/// parse), so its offsets are already file offsets, and putting them through that seam measures them against the
/// wrong document. Measured on the handshake fixture, where the rendering of `main.cpp` collapses two `#include`
/// lines and a false `#if OFF` branch: `Dead`'s range starts at file offset 45, `file_offset_of(45)` answers
/// **100**, and the symbol's range came out empty — a client draws a breadcrumb entry it cannot navigate to.
///
/// [`FileView::written_lines`] paired with [`FileView::written_text`] is the file's own index and text, and they are
/// the same pair `position_at_offset` uses once it has crossed the seam. When the view is of the file itself —
/// `written` is `None` — this is that same call.
fn range_in_file(view: &FileView, range: cpp_parser::SourceRange) -> Option<Range> {
    let text = view.written_text().unwrap_or(&view.source);
    let lines = view.written_lines();
    Some(Range::new(
        file_position(text, lines, range.start_offset)?,
        file_position(text, lines, range.end_offset())?,
    ))
}

/// One byte offset in `text`, as a client's position — **the file's** coordinates, through the file's own index.
///
/// These three lines are `crate::util::position_in`'s body. It is private because every other handler reaches it
/// through a seam that first takes a *reading* offset, and this is the one caller whose offsets are already the
/// file's — see [`range_in_file`].
fn file_position(text: &str, lines: &cpp_parser::LineIndex, offset: usize) -> Option<Position> {
    let (line, column) = lines.position_of(offset, text)?;
    let body = crate::util::line_body(text, lines, line)?;
    Some(Position::new(
        line as u32,
        crate::util::utf16_column(body, column),
    ))
}

pub struct DocumentSymbolCapabilities;

impl RegisterCapabilities for DocumentSymbolCapabilities {
    fn register_capabilities(server_capabilities: &mut ServerCapabilities, _: &ClientCapabilities) {
        server_capabilities.document_symbol_provider = Some(OneOf::Left(true));
    }
}

#[cfg(test)]
mod a_rendering_is_not_the_file {
    use super::*;

    /// **The file is twelve lines and its rendering is one**, so an unmapped offset lands on the wrong line.
    ///
    /// Reported as *"can you be professional about ranges and notice that because of macro expansion what we see is
    /// not the real thing"*. The two sources of an outline disagreed here: a stored summary is placed into the
    /// file's coordinates as it is built, and the fallback was not placed at all.
    #[test]
    fn a_declaration_after_a_macro_is_placed_in_the_file() {
        let text = "\
#include \"h.h\"

BEFORE

void after_the_macro() {
    return;
}

void last_one() {
    return;
}
";
        // **Two files**, the shape a real project has: the macro is defined in a header and invoked here.
        let files = cpp_code_analysis::MemoryFiles::new()
            .with_file("/p/a.cpp", text)
            .with_file(
                "/p/h.h",
                "#define BEFORE int a; int b; int c; int d; int e;\n",
            );
        let providers =
            cpp_code_analysis::SessionFiles::new(cpp_code_analysis::OpenDocuments::new(), files);
        let mut session = cpp_code_analysis::Session::with_config(
            "/p",
            providers,
            cpp_code_analysis::WatchFilter::new("/p"),
            cpp_code_analysis::CompilerConfig::default(),
        );
        let path = std::path::PathBuf::from("/p/a.cpp");
        session.load(&path);
        session.add_project_files([path.clone()]);
        session.index_everything();
        session.cook(&path);

        // The rendering really is collapsed, or this test would prove nothing about the mapping.
        let view = session.view(&path).expect("the file is cooked");
        assert!(
            view.source.matches('\n').count() < text.matches('\n').count(),
            "the fixture must make the rendering shorter than the file"
        );

        let symbols = symbols(&view, &session.outline(&view));

        let find = |name: &str| {
            symbols
                .iter()
                .find(|symbol| symbol.name == name)
                .unwrap_or_else(|| panic!("`{name}` is in the outline: {symbols:?}"))
        };

        // `void after_the_macro() {` .. `}` — lines 4 to 6 of the FILE, which is what a client draws in.
        let after = find("after_the_macro");
        assert_eq!(
            (
                after.range.start.line,
                after.range.start.character,
                after.range.end.line,
                after.range.end.character
            ),
            (4, 0, 6, 1),
            "a declaration after a macro is placed in the file, not in the rendering"
        );
        assert_eq!(find("last_one").range.start.line, 8);
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    /// **The two ranges, on the shapes that used to get them wrong.**
    ///
    /// Reported from an editor: *"our documentSymbol positions are almost always wrong"*. Two defects, and every
    /// symbol in a braced declaration had one or both:
    ///
    /// ```text
    /// namespace ns { … }   the range ran to the END OF THE FILE, because the trailing newline is a child of the
    ///                      body rather than of the declaration and the trim only looked at direct children
    /// int size;            the range was `"size"` — the declarator — with neither `int` nor `;`
    /// void f();            the range was `"f()"`, same reason
    /// ```
    ///
    /// A client folds, highlights and draws a breadcrumb from `range`, and the protocol documents it as *"the range
    /// enclosing this symbol"*. So a range ending at the file's last line swallows everything after the declaration,
    /// and a range that is only the name folds nothing at all.
    ///
    /// The expectations are written as the **text they select**, sliced out of the fixture, which is the only
    /// spelling a reader can check without counting columns — and the one that shows both defects at a glance.
    #[test]
    fn a_symbols_range_is_its_whole_declaration() {
        // CRLF and tabs on purpose: a real file written on Windows, which is where the newline defect showed.
        let text = "namespace ns {\r\n\tstruct Widget {\r\n\t\tint size;\r\n\t\tvoid f();\r\n\t};\r\n}\r\n";
        let (session, path) = a_session(text);
        let view = session
            .view_of_the_file(&path)
            .expect("a view of the file's own text");
        let outline = session.outline(&view);

        let selected = |range: Range| -> String {
            let lines: Vec<&str> = text.split("\r\n").collect();
            let from = lines[range.start.line as usize];
            let to = lines[range.end.line as usize];
            if range.start.line == range.end.line {
                from[range.start.character as usize..range.end.character as usize].to_string()
            } else {
                format!(
                    "{}…{}",
                    &from[range.start.character as usize..],
                    &to[..range.end.character as usize]
                )
            }
        };

        let symbols = symbols(&view, &outline);
        let ns = &symbols[0];
        assert_eq!(ns.name, "ns");
        assert_eq!(
            selected(ns.range),
            "namespace ns {…}",
            "a namespace ends at its own `}}`, not at the end of the file: {:?}",
            ns.range
        );
        assert_eq!(
            selected(ns.selection_range),
            "ns",
            "and the name is what a client selects"
        );

        // **The members**, which are the shapes whose range was only the name. The expected text carries the
        // fixture's own tab, because that is what the range really covers.
        let members = ns
            .children
            .as_ref()
            .expect("the class is inside the namespace");
        let widget = &members[0];
        assert_eq!(widget.name, "Widget");
        assert_eq!(
            selected(widget.range),
            "struct Widget {…\t}",
            "a class ends at its `}};`, indentation and all: {:?}",
            widget.range
        );

        let body = widget.children.as_ref().expect("its members");
        assert_eq!(body[0].name, "size");
        assert_eq!(
            selected(body[0].range),
            "int size;",
            "a variable's range is the declaration, type and `;` included: {:?}",
            body[0].range
        );
        assert_eq!(
            selected(body[0].selection_range),
            "size",
            "and its name is inside it, which the protocol requires"
        );

        assert_eq!(body[1].name, "f");
        assert_eq!(
            selected(body[1].range),
            "void f();",
            "and so is a member function's: {:?}",
            body[1].range
        );

        // **The pair's invariant**, on every symbol however deep: `selection_range` inside `range`. A client that
        // rejected an outline because one entry disagreed would show nothing at all.
        fn check(symbols: &[DocumentSymbol]) {
            for symbol in symbols {
                let inside = symbol.selection_range.start >= symbol.range.start
                    && symbol.selection_range.end <= symbol.range.end;
                assert!(
                    inside,
                    "`{}` selects {:?} which is not inside {:?}",
                    symbol.name, symbol.selection_range, symbol.range
                );
                if let Some(children) = &symbol.children {
                    check(children);
                }
            }
        }
        check(&symbols);

        // **A member's range is its own declaration, not the class's.** The walk that finds the enclosing
        // `Declaration` must take the innermost one; taking the first gave `size` the whole `struct Widget { … };`.
        assert_ne!(
            body[0].range, widget.range,
            "a member is not the class it is written in"
        );
        assert!(
            body[0].range.start >= widget.range.start && body[0].range.end <= widget.range.end,
            "and it is written inside it"
        );
    }

    /// **Two declarators keep their own ranges**, which the widening must not swallow.
    ///
    /// `int a = 1, b = 2;` declares two names under one type, so the type belongs to neither alone: attributing
    /// the whole declaration to both would make folding or highlighting one edit the other.
    #[test]
    fn a_shared_declaration_is_not_attributed_to_one_name() {
        let text = "int a = 1, b = 2;\n";
        let (session, path) = a_session(text);
        let view = session
            .view_of_the_file(&path)
            .expect("a view of the file's own text");
        let outline = session.outline(&view);
        let symbols = symbols(&view, &outline);

        let mut found: Vec<(String, Range)> = Vec::new();
        collect(&symbols, &mut found);
        assert_eq!(found.len(), 2, "two names: {found:?}");

        let line = "int a = 1, b = 2;";
        for (name, range) in &found {
            let selected = &line[range.start.character as usize..range.end.character as usize];
            assert!(
                !selected.starts_with("int"),
                "`{name}` must not claim the shared type: {selected:?}"
            );
        }
    }

    fn collect(symbols: &[DocumentSymbol], into: &mut Vec<(String, Range)>) {
        for symbol in symbols {
            into.push((symbol.name.clone(), symbol.range));
            if let Some(children) = &symbol.children {
                collect(children, into);
            }
        }
    }

    /// **Every symbol's range must enclose its own name** — the one property a client relies on.
    ///
    /// Reported while selecting `test_triviality_of_assignment` in an editor: the selection did not cover the
    /// symbol. The protocol's rule is that `selection_range` is **within** `range`, and the strongest check of it
    /// that does not depend on knowing what the range should be is this: the name's own span must fall inside the
    /// range that encloses it.
    ///
    /// The fixture is a header of the shape a real one has — variable templates at file scope, a class template
    /// with constraints, and a member defined out of line — because the shapes that fail are the ones with a
    /// declaration spread over several lines.
    #[test]
    fn every_symbols_range_encloses_its_name() {
        // The reported file's shape, with the line numbers of the report so the measurement can be read against it.
        let text = "\
template <class Scenario>
constexpr void test_triviality_of_assignment() {
    using Val = TrivialityTester<int, Scenario>;
    using E = ExpectedVoid<Val>;

    static_assert(is_trivially_assignable_v<E, const E&>
                  == (is_trivially_constructible_v<Val, const Val&> && is_trivially_assignable_v<Val, const Val&>
                      && is_trivially_destructible_v<Val>));
    static_assert(is_trivially_assignable_v<E, E&&>
                  == (is_trivially_constructible_v<Val, Val&&> && is_trivially_assignable_v<Val, Val&&>
                      && is_trivially_destructible_v<Val>));

    E e1{};
    E e2{};
    e1 = e2;
}

constexpr bool test_triviality_of_assignment_all() {
    test_triviality_of_assignment<TrivialityScenario1>();
    return true;
}
";
        let (session, path) = a_session(text);
        let view = session
            .view_of_the_file(&path)
            .expect("a view of the file's own text");
        let outline = session.outline(&view);
        let symbols = symbols(&view, &outline);

        let mut failures: Vec<String> = Vec::new();
        fn walk(symbols: &[DocumentSymbol], into: &mut Vec<String>) {
            for symbol in symbols {
                let inside = symbol.selection_range.start >= symbol.range.start
                    && symbol.selection_range.end <= symbol.range.end;
                if !inside {
                    into.push(format!(
                        "`{}`: selects {}:{}..{}:{} which is not inside {}:{}..{}:{}",
                        symbol.name,
                        symbol.selection_range.start.line,
                        symbol.selection_range.start.character,
                        symbol.selection_range.end.line,
                        symbol.selection_range.end.character,
                        symbol.range.start.line,
                        symbol.range.start.character,
                        symbol.range.end.line,
                        symbol.range.end.character,
                    ));
                }
                if let Some(children) = &symbol.children {
                    walk(children, into);
                }
            }
        }
        walk(&symbols, &mut failures);

        // **The measurement, printed**, because the expectation for a range has to be read against the file: the
        // report is that selecting a symbol highlights the wrong span, and only the numbers say which span.
        fn report(symbols: &[DocumentSymbol], depth: usize) {
            for symbol in symbols {
                eprintln!(
                    "{:indent$}{} range={}:{}..{}:{}  sel={}:{}..{}:{}",
                    "",
                    symbol.name,
                    symbol.range.start.line,
                    symbol.range.start.character,
                    symbol.range.end.line,
                    symbol.range.end.character,
                    symbol.selection_range.start.line,
                    symbol.selection_range.start.character,
                    symbol.selection_range.end.line,
                    symbol.selection_range.end.character,
                    indent = depth * 2
                );
                if let Some(children) = &symbol.children {
                    report(children, depth + 1);
                }
            }
        }
        report(&symbols, 0);

        assert!(
            failures.is_empty(),
            "every range must enclose the name it is about:\n{}",
            failures.join("\n")
        );
    }

    /// **A templated definition's range starts at the declaration, not at its `template` header.**
    ///
    /// Reported by selecting `test_triviality_of_assignment` in an editor's outline: the highlight covered the
    /// `template <class Scenario>` line as well. Measured, and this is the whole of it:
    ///
    /// ```text
    /// template <class Scenario>
    /// constexpr void test_triviality_of_assignment() { … }
    ///
    /// reported    range 0:0..17:0    `template <class Scenario>` through the function's `}`
    /// expected    range 1:0..15:1    `constexpr void … { … }`
    /// ```
    ///
    /// # The cause, which is one child
    ///
    /// The head is the declaration's **first child**, so the declaration's own start includes it:
    ///
    /// ```text
    /// Syntax(Declaration)@0..648        from `template` to the function's `}`
    ///   Syntax(TemplateDecl)@0..25      the head
    ///   Syntax(DeclSpecifierSeq)@26..40  `constexpr void`
    ///   Syntax(InitDeclarator)@41..44   `f`
    ///   Syntax(CompoundStat)@…          the body
    /// ```
    ///
    /// **The tree is not wrong about this** — the head applies to the declaration, they are adjacent, and the file
    /// is recorded losslessly. What was wrong was the question asked of it: *"where does the declaration start"*
    /// read as *"where does this node start"*, and those differ by exactly one child. See [`declaration_start`],
    /// which is where the difference is now made.
    #[test]
    fn a_templated_definitions_range_excludes_its_template_head() {
        let text = "\
template <class Scenario>
constexpr void test_triviality_of_assignment() {
    return;
}
";
        let (session, path) = a_session(text);
        let view = session
            .view_of_the_file(&path)
            .expect("a view of the file's own text");
        let outline = session.outline(&view);
        let symbols = symbols(&view, &outline);

        let function = symbols
            .iter()
            .find(|symbol| symbol.name == "test_triviality_of_assignment")
            .expect("the function is in the outline");
        assert_eq!(
            (
                function.range.start.line,
                function.range.start.character,
                function.range.end.line,
                function.range.end.character
            ),
            (1, 0, 3, 1),
            "the range is the declaration, `template` header excluded"
        );
    }

    /// **Every shape a declaration is written in**, so that a fix for one cannot quietly move another.
    ///
    /// The expectations are the line ranges of the fixture, written so that a reader can check them against it
    /// without counting columns — and they are what the measurement produced once the two defects were fixed:
    ///
    /// ```text
    /// template <class T> void f() { }        began at `template`   ✗ → the declaration's first child
    /// template <class T> using A = T;        already right
    /// template <class T> class C { };        already right
    /// class Outer { … };                     already right
    /// void plain() { }                       already right
    /// int field;                             already right
    /// ```
    ///
    /// So the defect was narrow and the guard is deliberately wide: **the last line is the one that catches an
    /// end that runs into the blank line after a function**, which is what `plain` and every definition did before
    /// the trim — `5:0..9:0` where the function is `5:0..7:1`.
    #[test]
    fn every_shape_of_declaration_reports_its_own_lines() {
        let text = "\
template <class T>
void templated() {
    return;
}

void plain() {
    return;
}

class Outer {
public:
    template <class T>
    void member_templated() {
        return;
    }
    void member_plain() {
        return;
    }
    int field;
};

template <class T>
class TemplatedClass {
    int inner;
};

template <class T>
using Alias = T;

template <class T>
T global_variable = T();

namespace ns {
    template <class T>
    void in_namespace() {
        return;
    }
}

class WithCtor {
public:
    WithCtor(int a)
        : value(a) {
    }
    int value;
};
";
        let (session, path) = a_session(text);
        let view = session
            .view_of_the_file(&path)
            .expect("a view of the file's own text");
        let outline = session.outline(&view);
        let symbols = symbols(&view, &outline);

        // Name → the lines the symbol covers, as `(first, last)`.
        let mut found: Vec<(String, u32, u32)> = Vec::new();
        fn collect(symbols: &[DocumentSymbol], into: &mut Vec<(String, u32, u32)>) {
            for symbol in symbols {
                into.push((
                    symbol.name.clone(),
                    symbol.range.start.line,
                    symbol.range.end.line,
                ));
                if let Some(children) = &symbol.children {
                    collect(children, into);
                }
            }
        }
        collect(&symbols, &mut found);

        // The lines each name is written on, found in the fixture rather than counted — and the expectations are
        // written as complete line ranges, because every attempt to derive them with arithmetic (`the next
        // declaration's line, less the blank line`) was wrong in a different way for each shape. The fixture is
        // numbered in its own doc comment above; these are those numbers.
        let numbers: Vec<(&str, u32, u32)> = vec![
            ("templated", 1, 3),
            ("plain", 5, 7),
            ("Outer", 9, 19),
            ("member_templated", 12, 14),
            ("member_plain", 15, 17),
            ("field", 18, 18),
            ("TemplatedClass", 22, 24),
            ("inner", 23, 23),
            ("Alias", 27, 27),
            ("global_variable", 30, 30),
            ("in_namespace", 34, 36),
            ("WithCtor", 39, 45),
            ("value", 44, 44),
        ];

        for (name, first, last) in numbers {
            let (found_first, found_last) = found
                .iter()
                .find(|(found, ..)| found == name)
                .map(|(_, first, last)| (*first, *last))
                .unwrap_or_else(|| panic!("`{name}` is in the outline: {found:?}"));
            assert_eq!(
                (found_first, found_last),
                (first, last),
                "`{name}` covers lines {first}..={last}"
            );
        }
    }

    /// **`range_in_file` gets a file offset and misplaces it** — the smallest possible statement of the defect.
    ///
    /// In this fixture the file offset **29** is exactly where line 4 begins: `#include "h.h"\n` is 15 bytes, `\n`
    /// is 16, `BEFORE\n` ends at 23, `\n` is 24, and `void after_the_macro() {` starts at 29. So the answer must be
    /// `4:0`, whatever the analysis layer does.
    #[test]
    fn an_offset_at_the_start_of_a_line_is_that_line() {
        let text = "line0\nline1\nline2\nline3\nvoid after_the_macro() {\n";
        let start_of_line_4 = 6 * 4;
        assert_eq!(
            &text[start_of_line_4..start_of_line_4 + 4],
            "void",
            "the fixture's offset arithmetic must be right before anything else is asserted"
        );

        let lines = cpp_parser::LineIndex::parse(text);
        let placed =
            file_position(text, &lines, start_of_line_4).expect("the offset is in the text");

        assert_eq!(
            (placed.line, placed.character),
            (4, 0),
            "an offset at the start of a line is column 0 of it"
        );
    }

    /// A workspace holding one file, so the outline comes from the file's own declarations.
    pub(super) fn a_session(
        text: &str,
    ) -> (
        cpp_code_analysis::Session<cpp_code_analysis::MemoryFiles>,
        std::path::PathBuf,
    ) {
        use cpp_code_analysis::{
            CompilerConfig, MemoryFiles, OpenDocuments, Session, SessionFiles, WatchFilter,
        };
        let files = MemoryFiles::new().with_file("/p/a.cpp", text);
        let providers = SessionFiles::new(OpenDocuments::new(), files);
        let mut session = Session::with_config(
            "/p",
            providers,
            WatchFilter::new("/p"),
            CompilerConfig::default(),
        );
        session.load("/p/a.cpp");
        (session, std::path::PathBuf::from("/p/a.cpp"))
    }
}