use super::{Check, CheckContext, DiagnosticCode};
pub struct OverrideNonexistent;
impl Check for OverrideNonexistent {
const CODES: &'static [DiagnosticCode] = &[DiagnosticCode::OverrideNonexistent];
fn check(context: &mut CheckContext<'_>) {
let classes: Vec<(String, Vec<String>)> = context
.summary
.declarations
.iter()
.filter(|fact| fact.kind == crate::DeclKind::Type)
.map(|fact| (fact.name.to_string(), fact.bases().to_vec()))
.collect();
let overriders: Vec<(String, Option<String>, String, cpp_parser::SourceRange)> = context
.summary
.declarations
.iter()
.filter(|fact| {
fact.kind == crate::DeclKind::Function
&& fact.modifiers.contains(crate::DeclModifiers::OVERRIDE)
&& !fact.is_a_destructor()
})
.map(|fact| {
(
fact.name.to_string(),
fact.scope.clone().map(|scope| scope.to_string()),
fact.name.to_string(),
fact.name_range,
)
})
.collect();
for (name, scope, _, name_range) in &overriders {
let Some(class) = scope.as_deref() else {
context.add_in_the_file(
DiagnosticCode::OverrideNonexistent,
*name_range,
name.clone(),
t!(
"`%{name}` says `override` outside a class definition — there is nothing it could override",
name = name
),
);
continue;
};
let Some((_, bases)) = classes.iter().find(|(declared, _)| declared == class) else {
continue;
};
if bases.is_empty() {
context.add_in_the_file(
DiagnosticCode::OverrideNonexistent,
*name_range,
name.clone(),
t!(
"`%{name}` says `override` but `%{class}` has no base class, so there is nothing to override",
name = name,
class = class
),
);
continue;
}
let mut declared_somewhere = false;
let mut could_not_read_a_base = false;
for base in bases {
match context.model.members_of(base) {
crate::Known::Yes(list) => {
if !list.unlisted.is_empty() {
could_not_read_a_base = true;
}
if list.members.iter().any(|member| member.fact.name == *name) {
declared_somewhere = true;
break;
}
}
_ => could_not_read_a_base = true,
}
}
if could_not_read_a_base || declared_somewhere {
continue;
}
context.add_in_the_file(
DiagnosticCode::OverrideNonexistent,
*name_range,
name.clone(),
t!(
"`%{name}` says `override` but no base of `%{class}` declares it — the program does not build",
name = name,
class = class
),
);
}
}
}