use super::{Check, CheckContext, DiagnosticCode};
pub struct UseOverride;
impl Check for UseOverride {
const CODES: &'static [DiagnosticCode] = &[DiagnosticCode::UseOverride];
fn check(context: &mut CheckContext<'_>) {
let declarations: Vec<(String, Vec<String>)> = context
.summary
.declarations
.iter()
.filter(|fact| fact.kind == crate::DeclKind::Type && !fact.bases.is_empty())
.map(|fact| (fact.name.clone(), fact.bases.clone()))
.collect();
let mut base_members: std::collections::BTreeMap<String, Vec<String>> =
std::collections::BTreeMap::new();
for (class, bases) in declarations {
let members: Vec<(String, String, usize)> = context
.summary
.declarations
.iter()
.filter(|fact| {
fact.kind == crate::DeclKind::Function
&& fact.scope.as_deref() == Some(class.as_str())
})
.filter_map(|fact| {
let written = context
.source
.get(fact.range.start_offset..fact.range.end_offset())?
.to_string();
Some((fact.name.clone(), written, fact.name_range.start_offset))
})
.collect();
for (name, written, offset) in members {
if written.contains("override") || written.contains("final") {
continue;
}
let mut overrides = false;
for base in &bases {
if !base_members.contains_key(base) {
let names = match context.model.members_of(base) {
crate::Known::Yes(list) => list
.members
.iter()
.map(|member| member.fact.name.clone())
.collect(),
_ => Vec::new(),
};
base_members.insert(base.clone(), names);
}
if base_members
.get(base)
.is_some_and(|names| names.iter().any(|declared| declared == &name))
{
overrides = true;
break;
}
}
if !overrides {
continue;
}
let range = cpp_parser::SourceRange::new(offset, name.len());
let _ = range;
context.add(
DiagnosticCode::UseOverride,
cpp_parser::SourceRange::new(offset, name.len()),
name.clone(),
t!(
"`%{name}` overrides a base's virtual and does not say so — write `override`, which turns a silent non-override into a compile error",
name = name
),
);
}
}
}
}