cpp-linter 2.0.0-rc9

Run clang-format and clang-tidy on a batch of files.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
use chrono::Utc;
use cpp_linter::{
    cli::LinesChangedOnly,
    rest_api::{COMMENT_MARKER, USER_OUTREACH},
    run::run_main,
};
use mockito::Matcher;
use serde_json::json;
use std::{env, io::Write, path::Path};
use tempfile::NamedTempFile;

mod common;
use common::{create_test_space, mock_server};

const SHA: &str = "8d68756375e0483c7ac2b4d6bbbece420dbbb495";
const REPO: &str = "cpp-linter/test-cpp-linter-action";
const PR: i64 = 27;
const TOKEN: &str = "123456";
const MOCK_ASSETS_PATH: &str = "tests/reviews_test_assets/";
const EVENT_PAYLOAD: &str = "{\"number\": 27}";

const RESET_RATE_LIMIT_HEADER: &str = "x-ratelimit-reset";
const REMAINING_RATE_LIMIT_HEADER: &str = "x-ratelimit-remaining";

struct TestParams {
    pub lines_changed_only: LinesChangedOnly,
    pub tidy_review: bool,
    pub format_review: bool,
    pub passive_reviews: bool,
    pub no_lgtm: bool,
    pub force_lgtm: bool,
    pub summary_only: bool,
    pub pr_state: String,
    pub pr_draft: bool,
    pub fail_dismissal: bool,
    pub fail_get_existing_reviews: bool,
    pub fail_posting: bool,
    pub bad_pr_info: bool,
    pub bad_existing_reviews: bool,
}

impl Default for TestParams {
    fn default() -> Self {
        Self {
            lines_changed_only: LinesChangedOnly::On,
            tidy_review: true,
            format_review: true,
            passive_reviews: false,
            no_lgtm: true,
            force_lgtm: false,
            summary_only: false,
            pr_state: "open".to_string(),
            pr_draft: false,
            fail_dismissal: false,
            fail_get_existing_reviews: false,
            fail_posting: false,
            bad_pr_info: false,
            bad_existing_reviews: false,
        }
    }
}

fn generate_tool_summary(review_enabled: bool, force_lgtm: bool, tool_name: &str) -> String {
    if !review_enabled {
        return String::new();
    }
    if force_lgtm {
        format!("No concerns reported by {}. Great job! :tada:", tool_name)
    } else {
        format!("Click here for the full {} patch", tool_name)
    }
}

async fn setup(lib_root: &Path, test_params: &TestParams) {
    env::remove_var("GITHUB_OUTPUT"); // avoid writing to GH_OUT in parallel-running tests
    env::set_var("GITHUB_EVENT_NAME", "pull_request");
    env::set_var("GITHUB_REPOSITORY", REPO);
    env::set_var("GITHUB_SHA", SHA);
    env::set_var("GITHUB_TOKEN", TOKEN);
    env::set_var("CI", "true");
    if test_params.summary_only {
        env::set_var("CPP_LINTER_PR_REVIEW_SUMMARY_ONLY", "true");
    }
    let mut event_payload_path = NamedTempFile::new_in("./").unwrap();
    event_payload_path
        .write_all(EVENT_PAYLOAD.as_bytes())
        .expect("Failed to create mock event payload.");
    env::set_var("GITHUB_EVENT_PATH", event_payload_path.path());
    let clang_version = env::var("CLANG_VERSION").unwrap_or("".to_string());
    let reset_timestamp = (Utc::now().timestamp() + 60).to_string();
    let asset_path = format!("{}/{MOCK_ASSETS_PATH}", lib_root.to_str().unwrap());

    let mut server = mock_server().await;
    env::set_var("GITHUB_API_URL", server.url());
    let mut mocks = vec![];

    let pr_endpoint = format!("/repos/{REPO}/pulls/{PR}");
    mocks.push(
        server
            .mock("GET", pr_endpoint.as_str())
            .match_header("Accept", "application/vnd.github.diff")
            .match_header("Authorization", format!("token {TOKEN}").as_str())
            .with_body_from_file(format!("{asset_path}pr_{PR}.diff"))
            .with_header(REMAINING_RATE_LIMIT_HEADER, "50")
            .with_header(RESET_RATE_LIMIT_HEADER, reset_timestamp.as_str())
            .create(),
    );
    mocks.push(
        server
            .mock("GET", pr_endpoint.as_str())
            .match_header("Accept", "application/vnd.github.raw+json")
            .match_header("Authorization", format!("token {TOKEN}").as_str())
            .with_body(if test_params.bad_pr_info {
                String::new()
            } else {
                json!({"state": test_params.pr_state, "draft": test_params.pr_draft}).to_string()
            })
            .with_header(REMAINING_RATE_LIMIT_HEADER, "50")
            .with_header(RESET_RATE_LIMIT_HEADER, reset_timestamp.as_str())
            .create(),
    );

    let reviews_endpoint = format!("/repos/{REPO}/pulls/{PR}/reviews");

    let mut mock = server
        .mock("GET", reviews_endpoint.as_str())
        .match_header("Accept", "application/vnd.github.raw+json")
        .match_header("Authorization", format!("token {TOKEN}").as_str())
        .match_body(Matcher::Any)
        .match_query(Matcher::UrlEncoded("page".to_string(), "1".to_string()))
        .with_header(REMAINING_RATE_LIMIT_HEADER, "50")
        .with_header(RESET_RATE_LIMIT_HEADER, reset_timestamp.as_str())
        .with_status(if test_params.fail_get_existing_reviews {
            403
        } else {
            200
        });
    if test_params.bad_existing_reviews {
        mock = mock.with_body(String::new()).create();
    } else {
        mock = mock
            .with_body_from_file(format!("{asset_path}pr_reviews.json"))
            .create()
    }
    mocks.push(mock);
    if !test_params.fail_get_existing_reviews && !test_params.bad_existing_reviews {
        mocks.push(
            server
                .mock(
                    "PUT",
                    format!("{reviews_endpoint}/1807607546/dismissals").as_str(),
                )
                .match_body(r#"{"event":"DISMISS","message":"outdated suggestion"}"#)
                .match_header("Authorization", format!("token {TOKEN}").as_str())
                .with_header(REMAINING_RATE_LIMIT_HEADER, "50")
                .with_header(RESET_RATE_LIMIT_HEADER, reset_timestamp.as_str())
                .with_status(if test_params.fail_dismissal { 403 } else { 200 })
                .create(),
        );
    }

    let lgtm_allowed = !test_params.force_lgtm || !test_params.no_lgtm;
    if lgtm_allowed
        && !test_params.pr_draft
        && test_params.pr_state == "open"
        && !test_params.bad_pr_info
    {
        let review_reaction = if test_params.passive_reviews {
            "COMMENT"
        } else if test_params.force_lgtm {
            "APPROVE"
        } else {
            "REQUEST_CHANGES"
        };
        let tidy_summary = generate_tool_summary(
            test_params.tidy_review,
            test_params.force_lgtm,
            "clang-tidy",
        );
        let format_summary = generate_tool_summary(
            test_params.format_review,
            test_params.force_lgtm,
            "clang-format",
        );
        let review_summary = format!(
            "{}## Cpp-linter Review.*{format_summary}.*{tidy_summary}.*{}",
            regex::escape(format!("{}", COMMENT_MARKER.escape_default()).as_str()),
            regex::escape(format!("{}", USER_OUTREACH.escape_default()).as_str()),
        );
        let expected_review_payload = format!(
            "\\{{\"event\":\"{review_reaction}\",\"body\":\"{review_summary}\",\"comments\":\\[{}\\]}}",
            if test_params.force_lgtm || test_params.summary_only {
                ""
            } else {
                ".+"
            }
        );
        mocks.push(
            server
                .mock("POST", reviews_endpoint.as_str())
                .match_body(Matcher::Regex(expected_review_payload))
                .match_header("Authorization", format!("token {TOKEN}").as_str())
                .with_header(REMAINING_RATE_LIMIT_HEADER, "50")
                .with_header(RESET_RATE_LIMIT_HEADER, reset_timestamp.as_str())
                .with_status(if test_params.fail_posting { 403 } else { 200 })
                .create(),
        );
    }

    let mut tool_ignore = "**/*.c".to_string();
    if test_params.force_lgtm {
        tool_ignore.push_str("|**/*.cpp|**/*.h");
    }
    let mut args = vec![
        "cpp-linter".to_string(),
        "-v=debug".to_string(),
        format!("-V={}", clang_version),
        format!("-l={}", test_params.lines_changed_only),
        format!("--ignore-tidy={}", tool_ignore),
        format!("--ignore-format={}", tool_ignore),
        format!("--tidy-review={}", test_params.tidy_review),
        format!("--format-review={}", test_params.format_review),
        format!("--passive-reviews={}", test_params.passive_reviews),
        format!("--no-lgtm={}", test_params.no_lgtm),
        "-p=build".to_string(),
        "-i=build".to_string(),
    ];
    if test_params.force_lgtm {
        if test_params.tidy_review {
            // only use a check that doesn't trigger concern on test assets
            args.push("--tidy-checks=-*,bugprone-infinite-loop".to_string());
        }
        if test_params.format_review {
            // explicitly disable formatting using `DisableFormat: true`
            args.push("--style={DisableFormat: true}".to_string());
        }
    } else {
        args.push("--style=file".to_string()); // use .clang-format file
    }
    let result = run_main(args).await;
    assert!(result.is_ok());
    for mock in mocks {
        mock.assert();
    }
}

async fn test_review(test_params: &TestParams) {
    let tmp_dir = create_test_space(true);
    let lib_root = env::current_dir().unwrap();
    env::set_current_dir(tmp_dir.path()).unwrap();
    setup(&lib_root, test_params).await;
    env::set_current_dir(lib_root.as_path()).unwrap();
    drop(tmp_dir);
}

#[tokio::test]
async fn all_lines() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn all_lines_tidy_only() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        format_review: false,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn all_lines_format_only() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        tidy_review: false,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn changed_lines() {
    test_review(&TestParams::default()).await;
}

#[tokio::test]
async fn all_lines_passive() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        passive_reviews: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn changed_lines_passive() {
    test_review(&TestParams {
        passive_reviews: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn summary_only() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        summary_only: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn lgtm() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        no_lgtm: false,
        force_lgtm: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn lgtm_passive() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        no_lgtm: false,
        force_lgtm: true,
        passive_reviews: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn no_lgtm() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        force_lgtm: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn is_draft() {
    test_review(&TestParams {
        pr_draft: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn is_closed() {
    test_review(&TestParams {
        pr_state: "closed".to_string(),
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn fail_posting() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        fail_posting: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn fail_dismissal() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        fail_dismissal: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn fail_get_existing_reviews() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        fail_get_existing_reviews: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn bad_existing_reviews() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        force_lgtm: true,
        bad_existing_reviews: true,
        ..Default::default()
    })
    .await;
}

#[tokio::test]
async fn bad_pr_info() {
    test_review(&TestParams {
        lines_changed_only: LinesChangedOnly::Off,
        force_lgtm: true,
        bad_pr_info: true,
        ..Default::default()
    })
    .await;
}