cora-code 0.17.0

CLI-first AI code review — BYOK, diff/scan/branch, pre-commit hooks
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
use anyhow::Result;
use colored::Colorize;

use crate::engine::{ReviewIssue, ReviewResponse, ScanResponse, Severity};
use crate::formatters::Formatter;

/// Pretty formatter with colored terminal output and severity icons.
pub struct PrettyFormatter;

#[allow(clippy::format_push_string)]
impl Formatter for PrettyFormatter {
    fn format_review(&self, response: &ReviewResponse) -> Result<String> {
        let mut output = String::new();

        // Header
        output.push_str(&format!(
            "{}\n\n",
            "╔══════════════════════════════════════════╗
║          Cora Code Review Results        ║
╚══════════════════════════════════════════╝"
                .cyan()
                .bold()
        ));

        if response.issues.is_empty() {
            output.push_str(&"✅ No issues found!".green().bold().to_string());
            if !response.summary.is_empty() {
                output.push_str(&format!("\n\n{}", response.summary.dimmed()));
            }
            return Ok(output);
        }

        // Summary line
        let crit = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Critical)
            .count();
        let maj = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Major)
            .count();
        let min = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Minor)
            .count();
        let inf = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Info)
            .count();

        output.push_str(&format!(
            "Found {} issue{}: {} {} {} {} {}\n\n",
            response.issues.len(),
            if response.issues.len() == 1 { "" } else { "s" },
            format!("{crit} critical").red(),
            format!("{maj} major").yellow(),
            format!("{min} minor").blue(),
            format!("{inf} info").white(),
            if response.should_block {
                format!("\n{}", "⚠ BLOCKED".red().bold())
            } else {
                String::new()
            },
        ));

        // Issues
        for (idx, issue) in response.issues.iter().enumerate() {
            output.push_str(&format_issue_pretty(issue, idx + 1));
            output.push('\n');
        }

        // Summary
        if !response.summary.is_empty() {
            output.push_str(&format!(
                "\n{}\n{}",
                "─".repeat(60).dimmed(),
                response.summary.white().bold()
            ));
        }

        // Footer watermark (only when issues found)
        output.push_str(&format!(
            "\n{}\n{}",
            "─".repeat(60).dimmed(),
            format!("Reviewed by Cora v{}", env!("CARGO_PKG_VERSION")).dimmed()
        ));

        Ok(output)
    }

    fn format_scan(&self, response: &ScanResponse) -> Result<String> {
        let mut output = String::new();

        output.push_str(&format!(
            "{}\n",
            "╔══════════════════════════════════════════╗
║        Cora Project Scan Results           ║
╚══════════════════════════════════════════╝"
                .cyan()
                .bold()
        ));

        output.push_str(&format!(
            "Scanned {} files ({} lines)\n\n",
            response.files_scanned, response.lines_scanned
        ));

        if response.issues.is_empty() {
            output.push_str(&"✅ No issues found!".green().bold().to_string());
            if !response.summary.is_empty() {
                output.push_str(&format!("\n\n{}", response.summary.dimmed()));
            }
            return Ok(output);
        }

        let crit = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Critical)
            .count();
        let maj = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Major)
            .count();
        let min = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Minor)
            .count();
        let inf = response
            .issues
            .iter()
            .filter(|i| i.severity == Severity::Info)
            .count();

        output.push_str(&format!(
            "Found {} issue{}: {} {} {} {} {}\n\n",
            response.issues.len(),
            if response.issues.len() == 1 { "" } else { "s" },
            format!("{crit} critical").red(),
            format!("{maj} major").yellow(),
            format!("{min} minor").blue(),
            format!("{inf} info").white(),
            if response.should_block {
                format!("\n{}", "⚠ BLOCKED".red().bold())
            } else {
                String::new()
            },
        ));

        for (idx, issue) in response.issues.iter().enumerate() {
            output.push_str(&format_issue_pretty(issue, idx + 1));
            output.push('\n');
        }

        if !response.summary.is_empty() {
            output.push_str(&format!(
                "\n{}\n{}",
                "─".repeat(60).dimmed(),
                response.summary.white().bold()
            ));
        }

        // Footer watermark (only when issues found)
        if !response.issues.is_empty() {
            output.push_str(&format!(
                "\n{}\n{}",
                "─".repeat(60).dimmed(),
                format!("Reviewed by Cora v{}", env!("CARGO_PKG_VERSION")).dimmed()
            ));
        }

        Ok(output)
    }
}

/// Format a single issue with colors and icons.
#[allow(clippy::format_push_string)]
fn format_issue_pretty(issue: &ReviewIssue, num: usize) -> String {
    let mut out = String::new();

    // Header: icon + severity + type
    let icon = issue.severity.icon();
    let sev_colored = match issue.severity {
        Severity::Critical => issue.severity.label().red().bold(),
        Severity::Major => issue.severity.label().yellow().bold(),
        Severity::Minor => issue.severity.label().blue().bold(),
        Severity::Info => issue.severity.label().white().bold(),
    };

    out.push_str(&format!("{icon} [{sev_colored}] "));
    if let Some(ref itype) = issue.issue_type {
        out.push_str(&format!("{itype}: "));
    }

    // File:line location
    let loc = match issue.line {
        Some(l) => format!("{}:{}", issue.file, l),
        None => issue.file.clone(),
    };
    out.push_str(&loc.white().bold().to_string());
    out.push('\n');

    // Title
    out.push_str(&format!(
        "  {} {}",
        format!("#{num}").dimmed(),
        issue.title.bold()
    ));
    // Rule id, usable in `cora-ignore:` / `ignore.rules` (#597).
    if let Some(ref id) = issue.rule_id {
        out.push_str(&format!(" {}", format!("(rule: {id})").dimmed()));
    }
    out.push('\n');

    // Body
    if !issue.body.is_empty() {
        for line in issue.body.lines().take(10) {
            out.push_str(&format!("    {}\n", line.dimmed()));
        }
    }

    // Suggested fix
    if let Some(ref fix) = issue.suggested_fix {
        if !fix.trim().is_empty() {
            out.push_str(&format!("  {}\n", "💡 Suggested fix:".green().bold()));
            out.push_str(&format!("    {fix}\n"));
        }
    }

    out
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::engine::{ReviewIssue, ScanResponse, Severity};

    fn sample_issue() -> ReviewIssue {
        ReviewIssue {
            rule_id: None,
            also_matches: Vec::new(),
            file: "src/main.rs".to_string(),
            line: Some(42),
            severity: Severity::Critical,
            issue_type: Some("security".to_string()),
            title: "SQL Injection".to_string(),
            body: "User input is concatenated directly into SQL query.".to_string(),
            suggested_fix: Some("Use parameterized queries.".to_string()),
        }
    }

    fn sample_response() -> ReviewResponse {
        ReviewResponse {
            issues: vec![sample_issue()],
            summary: "Found 1 critical issue.".to_string(),
            tokens_used: None,
            should_block: false,
        }
    }

    fn empty_response() -> ReviewResponse {
        ReviewResponse {
            issues: vec![],
            summary: String::new(),
            tokens_used: None,
            should_block: false,
        }
    }

    fn blocked_response() -> ReviewResponse {
        ReviewResponse {
            issues: vec![sample_issue()],
            summary: String::new(),
            tokens_used: None,
            should_block: true,
        }
    }

    fn sample_scan_response() -> ScanResponse {
        ScanResponse {
            issues: vec![sample_issue()],
            summary: "Scan done.".to_string(),
            files_scanned: 10,
            lines_scanned: 500,
            tokens_used: None,
            should_block: false,
        }
    }

    #[test]
    fn format_review_contains_file() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("src/main.rs"));
    }

    #[test]
    fn format_review_contains_title() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("SQL Injection"));
    }

    #[test]
    fn format_review_contains_header() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("Cora Code Review Results"));
    }

    #[test]
    fn format_review_empty_issues_shows_no_issues() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&empty_response()).unwrap();
        assert!(output.contains("No issues found"));
        // No watermark when no issues
        assert!(!output.contains("Reviewed by Cora"));
    }

    #[test]
    fn format_review_with_issues_has_watermark() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("Reviewed by Cora v"));
    }

    #[test]
    fn format_scan_with_issues_has_watermark() {
        let fmt = PrettyFormatter;
        let output = fmt.format_scan(&sample_scan_response()).unwrap();
        assert!(output.contains("Reviewed by Cora v"));
    }

    #[test]
    fn format_review_with_summary() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("Found 1 critical issue."));
    }

    #[test]
    fn format_review_blocked_shows_blocked() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&blocked_response()).unwrap();
        assert!(output.contains("BLOCKED"));
    }

    #[test]
    fn format_review_issue_count() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("1 issue"));
    }

    #[test]
    fn format_review_issue_type_displayed() {
        let fmt = PrettyFormatter;
        let output = fmt.format_review(&sample_response()).unwrap();
        assert!(output.contains("security"));
    }

    #[test]
    fn format_scan_contains_header() {
        let fmt = PrettyFormatter;
        let output = fmt.format_scan(&sample_scan_response()).unwrap();
        assert!(output.contains("Cora Project Scan Results"));
    }

    #[test]
    fn format_scan_contains_file_line_count() {
        let fmt = PrettyFormatter;
        let output = fmt.format_scan(&sample_scan_response()).unwrap();
        assert!(output.contains("10 files"));
        assert!(output.contains("500 lines"));
    }

    #[test]
    fn format_issue_pretty_no_line() {
        let issue = ReviewIssue {
            rule_id: None,
            also_matches: Vec::new(),
            file: "README.md".to_string(),
            line: None,
            severity: Severity::Info,
            issue_type: None,
            title: "Typo".to_string(),
            body: String::new(),
            suggested_fix: None,
        };
        let out = format_issue_pretty(&issue, 1);
        assert!(out.contains("README.md"));
        assert!(!out.contains("README.md:"));
    }

    #[test]
    fn format_issue_pretty_with_fix() {
        let out = format_issue_pretty(&sample_issue(), 1);
        assert!(out.contains("Suggested fix"));
        assert!(out.contains("parameterized"));
    }
}