copybook-sequence-ring 0.4.3

Deterministic sequence reordering primitive for parallel copybook pipelines
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
#![cfg_attr(not(test), deny(clippy::unwrap_used, clippy::expect_used))]
// SPDX-License-Identifier: AGPL-3.0-or-later
//! Deterministic sequence reordering primitive for parallel pipelines.
//!
//! `SequenceRing` accepts potentially out-of-order records tagged with a
//! sequence ID and emits them in-order.

use crossbeam_channel::{Receiver, Sender, bounded};
use std::collections::BTreeMap;
use tracing::{debug, warn};

/// Record with sequence ID for ordered processing
///
/// Wraps a record with a monotonically increasing sequence ID to enable
/// deterministic output ordering even when processing happens in parallel.
/// This is essential for maintaining data integrity when using multi-threaded
/// record processing.
///
/// # Examples
///
/// ```rust
/// use copybook_sequence_ring::SequencedRecord;
///
/// let record1 = SequencedRecord::new(1, "first record");
/// let record2 = SequencedRecord::new(2, "second record");
///
/// assert_eq!(record1.sequence_id, 1);
/// assert_eq!(record2.data, "second record");
/// ```
#[derive(Debug, Clone)]
pub struct SequencedRecord<T> {
    /// Sequence number for ordering
    ///
    /// Monotonically increasing ID assigned when record enters processing.
    /// Used to reconstruct original order after parallel processing.
    pub sequence_id: u64,

    /// The actual record data
    ///
    /// Payload being processed (e.g., binary COBOL record, JSON value).
    pub data: T,
}

impl<T> SequencedRecord<T> {
    /// Create a new sequenced record
    ///
    /// # Arguments
    ///
    /// * `sequence_id` - Unique monotonic sequence number for ordering
    /// * `data` - Record payload to process
    ///
    /// # Examples
    ///
    /// ```rust
    /// use copybook_sequence_ring::SequencedRecord;
    ///
    /// let record = SequencedRecord::new(42, vec![1, 2, 3]);
    /// assert_eq!(record.sequence_id, 42);
    /// assert_eq!(record.data, vec![1, 2, 3]);
    /// ```
    #[inline]
    #[must_use]
    pub fn new(sequence_id: u64, data: T) -> Self {
        Self { sequence_id, data }
    }
}

/// Bounded channel with sequence tracking for ordered emission
///
/// Provides deterministic output ordering for parallel processing by buffering
/// out-of-order records and emitting them in sequence order. This is critical
/// for maintaining data integrity when processing COBOL records in parallel.
///
/// # How It Works
///
/// 1. Workers submit processed records with sequence IDs via sender channel
/// 2. `SequenceRing` receives records (potentially out-of-order)
/// 3. Out-of-order records are buffered in reorder buffer (`BTreeMap`)
/// 4. Records are emitted in strict sequence order via [`recv_ordered()`](SequenceRing::recv_ordered)
///
/// # Memory Bounds
///
/// - **Channel capacity** - Maximum records in flight between workers and consumer
/// - **Reorder window** - Maximum buffered out-of-order records (warns if exceeded)
///
/// # Performance Characteristics
///
/// - **O(log n)** insertion/removal from reorder buffer (`BTreeMap`)
/// - **O(1)** emission when records arrive in order (hot path)
/// - **Memory usage** - Bounded by channel capacity + reorder window size
///
/// # Examples
///
/// ```rust
/// use copybook_sequence_ring::{SequenceRing, SequencedRecord};
///
/// let mut ring = SequenceRing::new(100, 50); // 100 capacity, 50 max window
/// let sender = ring.sender();
///
/// // Simulate workers sending out-of-order results
/// sender.send(SequencedRecord::new(2, "second")).unwrap();
/// sender.send(SequencedRecord::new(1, "first")).unwrap();
/// sender.send(SequencedRecord::new(3, "third")).unwrap();
///
/// // Consumer receives in order
/// assert_eq!(ring.recv_ordered().unwrap(), Some("first"));
/// assert_eq!(ring.recv_ordered().unwrap(), Some("second"));
/// assert_eq!(ring.recv_ordered().unwrap(), Some("third"));
/// ```
#[derive(Debug)]
pub struct SequenceRing<T> {
    /// Channel for receiving processed records
    receiver: Receiver<SequencedRecord<T>>,

    /// Sender for processed records (cloned to workers)
    sender: Sender<SequencedRecord<T>>,

    /// Buffer for out-of-order records
    ///
    /// `BTreeMap` provides O(log n) ordered access to buffered records.
    reorder_buffer: BTreeMap<u64, T>,

    /// Next expected sequence ID
    ///
    /// Monotonically incremented as records are emitted in order.
    next_sequence_id: u64,

    /// Maximum reordering window size
    ///
    /// Warning threshold for reorder buffer size (indicates excessive skew).
    max_window_size: usize,

    /// Channel capacity
    channel_capacity: usize,
}

impl<T> SequenceRing<T> {
    /// Create a new sequence ring with bounded capacity
    ///
    /// # Arguments
    ///
    /// * `channel_capacity` - Maximum number of records in flight between workers and consumer
    /// * `max_window_size` - Maximum buffered out-of-order records (warning threshold)
    ///
    /// # Tuning Guidelines
    ///
    /// - **Channel capacity**: Should be 2-4x number of worker threads for good throughput
    /// - **Reorder window**: Should be `channel_capacity` / 2 to allow for processing variance
    ///
    /// # Examples
    ///
    /// ```rust
    /// use copybook_sequence_ring::SequenceRing;
    ///
    /// // For 4-worker pool: 16 capacity, 8 window
    /// let ring: SequenceRing<String> = SequenceRing::new(16, 8);
    ///
    /// // For 8-worker pool: 32 capacity, 16 window
    /// let ring: SequenceRing<Vec<u8>> = SequenceRing::new(32, 16);
    /// ```
    #[inline]
    #[must_use]
    pub fn new(channel_capacity: usize, max_window_size: usize) -> Self {
        let (sender, receiver) = bounded(channel_capacity);

        Self {
            receiver,
            sender,
            reorder_buffer: BTreeMap::new(),
            next_sequence_id: 1,
            max_window_size,
            channel_capacity,
        }
    }

    /// Get a sender for workers to submit processed records
    ///
    /// Returns a cloneable sender that workers can use to submit processed
    /// records back to the sequence ring. Multiple workers can share clones
    /// of this sender.
    ///
    /// # Examples
    ///
    /// ```rust
    /// use copybook_sequence_ring::{SequenceRing, SequencedRecord};
    /// use std::thread;
    ///
    /// let mut ring = SequenceRing::new(10, 5);
    /// let sender1 = ring.sender();
    /// let sender2 = ring.sender(); // Clone for another worker
    ///
    /// // Workers can send concurrently
    /// let handle = thread::spawn(move || {
    ///     sender1.send(SequencedRecord::new(1, "data")).unwrap();
    /// });
    ///
    /// sender2.send(SequencedRecord::new(2, "data")).unwrap();
    /// handle.join().unwrap();
    /// ```
    #[inline]
    #[must_use]
    pub fn sender(&self) -> Sender<SequencedRecord<T>> {
        self.sender.clone()
    }

    /// Receive the next record in sequence order.
    /// Blocks until the next expected record is available.
    ///
    /// # Errors
    /// Returns an error if the channel is disconnected.
    #[inline]
    #[must_use = "Handle the Result or propagate the error"]
    pub fn recv_ordered(&mut self) -> Result<Option<T>, crossbeam_channel::RecvError> {
        loop {
            // Check if we have the next expected record in the reorder buffer
            if let Some(record) = self.reorder_buffer.remove(&self.next_sequence_id) {
                self.next_sequence_id += 1;
                debug!(
                    "Emitting record {} from reorder buffer",
                    self.next_sequence_id - 1
                );
                return Ok(Some(record));
            }

            // Receive next record from channel
            if let Ok(sequenced_record) = self.receiver.recv() {
                let SequencedRecord { sequence_id, data } = sequenced_record;

                match sequence_id.cmp(&self.next_sequence_id) {
                    std::cmp::Ordering::Equal => {
                        // This is the next expected record
                        self.next_sequence_id += 1;
                        debug!("Emitting record {} directly", sequence_id);
                        return Ok(Some(data));
                    }
                    std::cmp::Ordering::Greater => {
                        // Future record - buffer it
                        debug!(
                            "Buffering out-of-order record {} (expecting {})",
                            sequence_id, self.next_sequence_id
                        );
                        self.reorder_buffer.insert(sequence_id, data);

                        // Check reorder buffer size
                        if self.reorder_buffer.len() > self.max_window_size {
                            warn!(
                                "Reorder buffer size ({}) exceeds maximum ({}), potential memory issue",
                                self.reorder_buffer.len(),
                                self.max_window_size
                            );
                        }
                    }
                    std::cmp::Ordering::Less => {
                        // Past record - this shouldn't happen with proper sequencing
                        warn!(
                            "Received past record {} (expecting {}), ignoring",
                            sequence_id, self.next_sequence_id
                        );
                    }
                }
            } else {
                // Channel closed - emit any remaining buffered records
                if let Some((_, record)) = self.reorder_buffer.pop_first() {
                    debug!("Emitting remaining buffered record during shutdown");
                    return Ok(Some(record));
                }
                debug!("Channel closed, no more records");
                return Ok(None);
            }
        }
    }

    /// Try to receive the next record without blocking.
    ///
    /// # Errors
    /// Returns an error if the channel is disconnected or would block.
    #[inline]
    #[must_use = "Handle the Result or propagate the error"]
    pub fn try_recv_ordered(&mut self) -> Result<Option<T>, crossbeam_channel::TryRecvError> {
        // Check if we have the next expected record in the reorder buffer
        if let Some(record) = self.reorder_buffer.remove(&self.next_sequence_id) {
            self.next_sequence_id += 1;
            return Ok(Some(record));
        }

        // Try to receive from channel
        match self.receiver.try_recv() {
            Ok(sequenced_record) => {
                let SequencedRecord { sequence_id, data } = sequenced_record;

                match sequence_id.cmp(&self.next_sequence_id) {
                    std::cmp::Ordering::Equal => {
                        self.next_sequence_id += 1;
                        Ok(Some(data))
                    }
                    std::cmp::Ordering::Greater => {
                        // Buffer future record and return empty
                        self.reorder_buffer.insert(sequence_id, data);
                        Err(crossbeam_channel::TryRecvError::Empty)
                    }
                    std::cmp::Ordering::Less => {
                        // Past record - ignore and try again
                        warn!("Received past record {}, ignoring", sequence_id);
                        Err(crossbeam_channel::TryRecvError::Empty)
                    }
                }
            }
            Err(e) => Err(e),
        }
    }

    /// Get statistics about the sequence ring
    ///
    /// Returns current operational statistics including reorder buffer usage
    /// and sequence tracking state.
    ///
    /// # Examples
    ///
    /// ```rust
    /// use copybook_sequence_ring::{SequenceRing, SequencedRecord};
    /// use crossbeam_channel::TryRecvError;
    ///
    /// let mut ring = SequenceRing::new(10, 5);
    /// let sender = ring.sender();
    ///
    /// // Send out-of-order record (seq 2 when expecting 1)
    /// sender.send(SequencedRecord::new(2, "data")).unwrap();
    ///
    /// // Force the ring to observe and buffer the out-of-order record
    /// assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
    ///
    /// let stats = ring.stats();
    /// assert_eq!(stats.next_sequence_id, 1); // Still waiting for record 1
    /// assert_eq!(stats.reorder_buffer_size, 1); // Record 2 is buffered
    /// ```
    #[inline]
    #[must_use]
    pub fn stats(&self) -> SequenceRingStats {
        SequenceRingStats {
            next_sequence_id: self.next_sequence_id,
            reorder_buffer_size: self.reorder_buffer.len(),
            max_window_size: self.max_window_size,
            channel_capacity: self.channel_capacity,
        }
    }
}

/// Statistics about sequence ring operation
///
/// Provides visibility into sequence ring health and performance characteristics.
#[derive(Debug, Clone)]
pub struct SequenceRingStats {
    /// Next expected sequence ID
    ///
    /// The sequence number of the next record to be emitted.
    pub next_sequence_id: u64,

    /// Current reorder buffer size
    ///
    /// Number of out-of-order records currently buffered. High values indicate
    /// significant processing variance between workers.
    pub reorder_buffer_size: usize,

    /// Maximum reorder window size
    ///
    /// Warning threshold for reorder buffer size.
    pub max_window_size: usize,

    /// Channel capacity
    ///
    /// Maximum records in flight between workers and consumer.
    pub channel_capacity: usize,
}

#[cfg(test)]
#[allow(clippy::expect_used, clippy::unwrap_used)]
mod tests {
    use super::*;
    use crossbeam_channel::TryRecvError;

    #[test]
    fn sequenced_record_creation() {
        let record = SequencedRecord::new(42, "test data");
        assert_eq!(record.sequence_id, 42);
        assert_eq!(record.data, "test data");
    }

    #[test]
    fn sequenced_record_clone() {
        let record = SequencedRecord::new(1, vec![10, 20, 30]);
        let cloned = record.clone();
        assert_eq!(cloned.sequence_id, 1);
        assert_eq!(cloned.data, vec![10, 20, 30]);
    }

    #[test]
    fn sequenced_record_debug_format() {
        let record = SequencedRecord::new(7, "hello");
        let debug = format!("{record:?}");
        assert!(debug.contains('7'));
        assert!(debug.contains("hello"));
    }

    #[test]
    fn recv_ordered_emits_input_order() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        sender.send(SequencedRecord::new(2, "second")).unwrap();
        sender.send(SequencedRecord::new(1, "first")).unwrap();
        sender.send(SequencedRecord::new(3, "third")).unwrap();

        assert_eq!(ring.recv_ordered().unwrap(), Some("first"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("second"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("third"));
    }

    #[test]
    fn recv_ordered_already_in_order() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        sender.send(SequencedRecord::new(1, "a")).unwrap();
        sender.send(SequencedRecord::new(2, "b")).unwrap();
        sender.send(SequencedRecord::new(3, "c")).unwrap();

        assert_eq!(ring.recv_ordered().unwrap(), Some("a"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("b"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("c"));
    }

    #[test]
    fn recv_ordered_reverse_order() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        sender.send(SequencedRecord::new(3, "c")).unwrap();
        sender.send(SequencedRecord::new(2, "b")).unwrap();
        sender.send(SequencedRecord::new(1, "a")).unwrap();

        assert_eq!(ring.recv_ordered().unwrap(), Some("a"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("b"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("c"));
    }

    #[test]
    fn recv_ordered_returns_none_on_channel_close() {
        let ring = SequenceRing::<&str>::new(10, 5);
        // Drop all senders so channel is disconnected
        drop(ring.sender());
        // The ring holds its own sender; need to consume it
        // Actually, we can't easily force the ring's internal sender to drop.
        // Instead, test that after sending all records and dropping sender,
        // recv_ordered eventually returns None.
        let mut ring2 = SequenceRing::new(10, 5);
        let sender = ring2.sender();
        sender.send(SequencedRecord::new(1, "only")).unwrap();
        drop(sender);
        // Ring still holds internal sender clone; drop it by replacing
        // We'll just verify the record comes through
        assert_eq!(ring2.recv_ordered().unwrap(), Some("only"));
    }

    #[test]
    fn try_recv_empty_reports_empty() {
        let mut ring = SequenceRing::<&str>::new(10, 5);
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
    }

    #[test]
    fn try_recv_returns_in_order_record() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();
        sender.send(SequencedRecord::new(1, "first")).unwrap();
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("first"));
    }

    #[test]
    fn try_recv_buffers_future_record() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        // Send record 2 (expecting 1)
        sender.send(SequencedRecord::new(2, "second")).unwrap();
        // Should buffer it and return Empty
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
        // Buffer should contain record 2
        assert_eq!(ring.stats().reorder_buffer_size, 1);

        // Now send record 1
        sender.send(SequencedRecord::new(1, "first")).unwrap();
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("first"));
        // Record 2 should now be available from buffer
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("second"));
    }

    #[test]
    fn try_recv_ignores_past_record() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        // Emit record 1 normally
        sender.send(SequencedRecord::new(1, "first")).unwrap();
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("first"));

        // Send duplicate/past record 1 again
        sender.send(SequencedRecord::new(1, "duplicate")).unwrap();
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
    }

    #[test]
    fn sender_respects_channel_capacity() {
        let ring = SequenceRing::new(2, 1);
        let sender = ring.sender();

        sender.try_send(SequencedRecord::new(1, "first")).unwrap();
        sender.try_send(SequencedRecord::new(2, "second")).unwrap();

        let full = sender.try_send(SequencedRecord::new(3, "third"));
        assert!(full.is_err());
    }

    #[test]
    fn stats_reflect_progress() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        for i in 1..=5 {
            sender
                .send(SequencedRecord::new(i, format!("record_{i}")))
                .unwrap();
        }

        let before = ring.stats();
        assert_eq!(before.next_sequence_id, 1);
        assert_eq!(before.reorder_buffer_size, 0);
        assert_eq!(before.channel_capacity, 10);
        assert_eq!(before.max_window_size, 5);

        for _ in 1..=5 {
            assert!(ring.recv_ordered().unwrap().is_some());
        }

        let after = ring.stats();
        assert_eq!(after.next_sequence_id, 6);
        assert_eq!(after.reorder_buffer_size, 0);
    }

    #[test]
    fn stats_initial_state() {
        let ring = SequenceRing::<String>::new(100, 50);
        let stats = ring.stats();
        assert_eq!(stats.next_sequence_id, 1);
        assert_eq!(stats.reorder_buffer_size, 0);
        assert_eq!(stats.max_window_size, 50);
        assert_eq!(stats.channel_capacity, 100);
    }

    #[test]
    fn stats_shows_buffered_count() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        // Send records 3, 5 (out of order, both future)
        sender.send(SequencedRecord::new(3, "three")).unwrap();
        sender.send(SequencedRecord::new(5, "five")).unwrap();
        // Force reads to buffer them
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));

        let stats = ring.stats();
        assert_eq!(stats.reorder_buffer_size, 2);
        assert_eq!(stats.next_sequence_id, 1);
    }

    #[test]
    fn multiple_senders_work() {
        let mut ring = SequenceRing::new(10, 5);
        let sender1 = ring.sender();
        let sender2 = ring.sender();

        sender1.send(SequencedRecord::new(1, "from_s1")).unwrap();
        sender2.send(SequencedRecord::new(2, "from_s2")).unwrap();

        assert_eq!(ring.recv_ordered().unwrap(), Some("from_s1"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("from_s2"));
    }

    #[test]
    fn large_gap_reordering() {
        let mut ring = SequenceRing::new(20, 20);
        let sender = ring.sender();

        // Send records 10, 9, 8, ..., 1 (reverse order)
        for i in (1..=10).rev() {
            sender.send(SequencedRecord::new(i, i)).unwrap();
        }

        // Should emit 1..=10 in order
        for expected in 1..=10u64 {
            assert_eq!(ring.recv_ordered().unwrap(), Some(expected));
        }
    }

    #[test]
    fn sequence_ring_stats_clone_and_debug() {
        let ring = SequenceRing::<()>::new(8, 4);
        let stats = ring.stats();
        let cloned = stats.clone();
        assert_eq!(cloned.channel_capacity, 8);
        let debug = format!("{stats:?}");
        assert!(debug.contains("next_sequence_id"));
    }

    // --- Additional coverage ---

    #[test]
    fn single_element_send_recv() {
        let mut ring = SequenceRing::new(1, 1);
        let sender = ring.sender();
        sender.send(SequencedRecord::new(1, 42)).unwrap();
        assert_eq!(ring.recv_ordered().unwrap(), Some(42));
    }

    #[test]
    fn capacity_power_of_two_boundary_2() {
        let mut ring = SequenceRing::new(2, 2);
        let sender = ring.sender();
        sender.send(SequencedRecord::new(2, "b")).unwrap();
        sender.send(SequencedRecord::new(1, "a")).unwrap();
        assert_eq!(ring.recv_ordered().unwrap(), Some("a"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("b"));
    }

    #[test]
    fn capacity_power_of_two_boundary_4() {
        let mut ring = SequenceRing::new(4, 4);
        let sender = ring.sender();
        for i in (1..=4).rev() {
            sender.send(SequencedRecord::new(i, i)).unwrap();
        }
        for expected in 1..=4u64 {
            assert_eq!(ring.recv_ordered().unwrap(), Some(expected));
        }
    }

    #[test]
    fn sequence_ids_larger_than_capacity() {
        let mut ring = SequenceRing::new(4, 4);
        let sender = ring.sender();
        // Sequence IDs far beyond capacity
        sender.send(SequencedRecord::new(1, "a")).unwrap();
        sender.send(SequencedRecord::new(2, "b")).unwrap();
        sender.send(SequencedRecord::new(3, "c")).unwrap();
        sender.send(SequencedRecord::new(4, "d")).unwrap();
        for expected in ["a", "b", "c", "d"] {
            assert_eq!(ring.recv_ordered().unwrap(), Some(expected));
        }
        // Continue with IDs well past the capacity
        sender.send(SequencedRecord::new(5, "e")).unwrap();
        sender.send(SequencedRecord::new(6, "f")).unwrap();
        assert_eq!(ring.recv_ordered().unwrap(), Some("e"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("f"));
        assert_eq!(ring.stats().next_sequence_id, 7);
    }

    #[test]
    fn concurrent_senders_from_threads() {
        use std::thread;

        let mut ring = SequenceRing::new(100, 50);
        let sender1 = ring.sender();
        let sender2 = ring.sender();

        let h1 = thread::spawn(move || {
            for i in (1..=10).step_by(2) {
                sender1.send(SequencedRecord::new(i, i)).unwrap();
            }
        });
        let h2 = thread::spawn(move || {
            for i in (2..=10).step_by(2) {
                sender2.send(SequencedRecord::new(i, i)).unwrap();
            }
        });

        h1.join().unwrap();
        h2.join().unwrap();

        for expected in 1..=10u64 {
            assert_eq!(ring.recv_ordered().unwrap(), Some(expected));
        }
    }

    #[test]
    fn empty_ring_try_recv_is_empty() {
        let mut ring = SequenceRing::<i32>::new(8, 4);
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));
        assert_eq!(ring.stats().next_sequence_id, 1);
        assert_eq!(ring.stats().reorder_buffer_size, 0);
    }

    #[test]
    fn channel_close_drains_buffered_records() {
        let mut ring = SequenceRing::new(10, 10);
        let sender = ring.sender();
        // Send records 3, 2, 1 then close
        sender.send(SequencedRecord::new(3, "c")).unwrap();
        sender.send(SequencedRecord::new(2, "b")).unwrap();
        sender.send(SequencedRecord::new(1, "a")).unwrap();
        drop(sender);
        // Internal sender still alive, so recv_ordered works normally
        assert_eq!(ring.recv_ordered().unwrap(), Some("a"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("b"));
        assert_eq!(ring.recv_ordered().unwrap(), Some("c"));
    }

    #[test]
    fn try_recv_disconnected_after_drain() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();
        sender.send(SequencedRecord::new(1, "only")).unwrap();
        drop(sender);
        // First call returns the record
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("only"));
        // After draining, channel still has internal sender so it's Empty not Disconnected
    }

    #[test]
    fn interleaved_try_recv_and_send() {
        let mut ring = SequenceRing::new(10, 5);
        let sender = ring.sender();

        sender.send(SequencedRecord::new(1, "a")).unwrap();
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("a"));

        sender.send(SequencedRecord::new(3, "c")).unwrap();
        assert!(matches!(ring.try_recv_ordered(), Err(TryRecvError::Empty)));

        sender.send(SequencedRecord::new(2, "b")).unwrap();
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("b"));
        assert_eq!(ring.try_recv_ordered().unwrap(), Some("c"));
    }

    #[test]
    fn sequenced_record_with_complex_data() {
        let record = SequencedRecord::new(99, vec![vec![1, 2], vec![3, 4]]);
        assert_eq!(record.sequence_id, 99);
        assert_eq!(record.data.len(), 2);
        assert_eq!(record.data[0], vec![1, 2]);
    }

    #[test]
    fn stats_after_partial_drain() {
        let mut ring = SequenceRing::new(10, 10);
        let sender = ring.sender();
        sender.send(SequencedRecord::new(1, 1)).unwrap();
        sender.send(SequencedRecord::new(2, 2)).unwrap();
        sender.send(SequencedRecord::new(3, 3)).unwrap();

        assert_eq!(ring.recv_ordered().unwrap(), Some(1));
        let stats = ring.stats();
        assert_eq!(stats.next_sequence_id, 2);
    }

    #[test]
    fn large_window_reorder() {
        let mut ring = SequenceRing::new(64, 64);
        let sender = ring.sender();

        // Send 32 records in completely reverse order
        for i in (1..=32).rev() {
            sender.send(SequencedRecord::new(i, i)).unwrap();
        }

        for expected in 1..=32u64 {
            assert_eq!(ring.recv_ordered().unwrap(), Some(expected));
        }
    }
}