coordinode-lsm-tree 5.9.0

Embedded LSM-tree storage engine in pure Rust, no C/C++ dependency. MVCC snapshots, BuRR filters, zstd dictionary compression, columnar PAX blocks, AES-256-GCM at rest, self-healing per-block ECC, compaction on a near-full disk, no_std support.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
1641
1642
1643
1644
1645
1646
1647
1648
1649
1650
1651
1652
1653
use super::*;
use crate::{ValueType, value::InternalValue};
use test_log::test;

macro_rules! stream {
    ($($key:expr, $sub_key:expr, $value_type:expr),* $(,)?) => {{
        let mut values = Vec::new();
        let mut counters = std::collections::HashMap::new();

        $(
            #[expect(clippy::string_lit_as_bytes)]
            let key = $key.as_bytes();

            #[expect(clippy::string_lit_as_bytes)]
            let sub_key = $sub_key.as_bytes();

            let value_type = match $value_type {
                "V" => ValueType::Value,
                "T" => ValueType::Tombstone,
                "W" => ValueType::WeakTombstone,
                "M" => ValueType::MergeOperand,
                "I" => ValueType::Indirection,
                _ => panic!("Unknown value type"),
            };

            let counter = counters.entry($key).and_modify(|x| { *x -= 1 }).or_insert(999);
            values.push(InternalValue::from_components(key, sub_key, *counter, value_type));
        )*

        values
    }};
}

macro_rules! iter_closed {
    ($iter:expr) => {
        assert!($iter.next().is_none(), "iterator should be closed (done)");
    };
}

#[derive(Default)]
struct TrackCallback {
    items: Vec<InternalValue>,
}

impl DroppedKvCallback for TrackCallback {
    fn on_dropped(&mut self, kv: &InternalValue) {
        self.items.push(kv.clone());
    }
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_expired_callback_1() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "", "T",
      "a", "", "T",
    ];

    let mut my_watcher = TrackCallback::default();

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_000).with_drop_callback(&mut my_watcher);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    assert_eq!(
        [
            InternalValue::from_components("a", "", 998, ValueType::Tombstone),
            InternalValue::from_components("a", "", 997, ValueType::Tombstone),
        ],
        &*my_watcher.items,
    );

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_seqno_zeroing_1() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "3", "V",
      "a", "2", "V",
      "a", "1", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_000).zero_seqnos(true);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"3", 0, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
fn compaction_stream_queue_weak_tombstones() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "W",
      "a", "old", "V",
      "b", "", "W",
      "b", "old", "V",
      "c", "", "W",
      "c", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_050);

    iter_closed!(iter);
}

/// GC should not evict tombstones, unless they are covered up
#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_tombstone_no_gc() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "b", "", "T",
      "c", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_000_000);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_old_tombstone() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "", "T",
      "b", "", "T",
      "b", "", "T",
      "c", "", "T",
      "c", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 998);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 998, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"", 998, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"", 998, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_tombstone_overwrite_gc() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "val", "V",
      "a", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 999);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"val", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    // The tombstone at 998 is the newest version below the threshold, so the
    // fold keeps it: a read at snapshot 999 resolves to exactly this entry.
    // Here it happens to be observationally equal to dropping it, since every
    // older version goes too and an absent key reads the same as a deleted one.
    // The fold cannot tell those apart from one key's versions, and the rule
    // that can, keep the newest below the threshold, is the one that also holds
    // when that version is a value rather than a tombstone.
    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 998, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_bottom_level_tombstone_above_threshold_keeps_the_shadowed_value()
-> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "val", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // Threshold 0: nothing is collectable, so the bottom level may drop nothing.
    let mut iter = CompactionStream::new(iter, 0).evict_tombstones(true);

    // A read at snapshot 999 resolves to the value, not to the tombstone above
    // it. Dropping the pair because the level is the bottom would answer that
    // read with an absent key, which is indistinguishable from a genuine delete.
    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::Tombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"val", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
fn compaction_stream_bottom_level_tombstone_below_threshold_takes_the_key_with_it() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "val", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // Threshold 1000 puts the tombstone itself below the watermark, so it is the
    // newest version any servable snapshot resolves to, and it reads as absent.
    let mut iter = CompactionStream::new(iter, 1_000).evict_tombstones(true);

    iter_closed!(iter);
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_weak_tombstone_simple() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "W",
      "a", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 0);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::WeakTombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"old", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_weak_tombstone_no_gc() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "W",
      "a", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 998);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::WeakTombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"old", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_weak_tombstone_above_threshold_keeps_the_consumed_value() -> crate::Result<()>
{
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "W",
      "a", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // Threshold 999 records a floor of 998, so snapshot 999 is servable and
    // resolves to the value: the weak delete above it is not visible there yet.
    let mut iter = CompactionStream::new(iter, 999);

    // Annihilating the pair on the older sibling's seqno alone would answer that
    // read with an absent key. The pair leaves together only once the weak
    // tombstone ITSELF is below the watermark, which is the same condition the
    // plain-value fold states.
    assert_eq!(
        InternalValue::from_components(*b"a", *b"", 999, ValueType::WeakTombstone),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"old", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
fn compaction_stream_weak_tombstone_evict() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "W",
      "a", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // 1000 puts the weak tombstone itself below the watermark; at 999 the value
    // is still the answer to a servable snapshot (see the test above).
    let mut iter = CompactionStream::new(iter, 1_000);

    // NOTE: Weak tombstone is consumed because value is GC'ed

    iter_closed!(iter);
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_weak_tombstone_evict_next_value() -> crate::Result<()> {
    #[rustfmt::skip]
    let mut vec = stream![
      "a", "", "W",
      "a", "old", "V",
    ];
    vec.push(InternalValue::from_components(
        "b",
        "other",
        999,
        ValueType::Value,
    ));

    let iter = vec.iter().cloned().map(Ok);
    // 1000 puts the weak tombstone itself below the watermark, which is what
    // lets the pair leave together.
    let mut iter = CompactionStream::new(iter, 1_000);

    // NOTE: Weak tombstone is consumed because value is GC'ed

    assert_eq!(
        InternalValue::from_components(*b"b", *b"other", 999, ValueType::Value),
        iter.next().unwrap()?,
    );

    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_no_evict_simple() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "old", "V",
      "b", "old", "V",
      "c", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 0);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"old", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"old", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"old", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_no_evict_simple_multi_keys() -> crate::Result<()> {
    #[rustfmt::skip]
    let vec = stream![
      "a", "new", "V",
      "a", "old", "V",
      "b", "new", "V",
      "b", "old", "V",
      "c", "newnew", "V",
      "c", "new", "V",
      "c", "old", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 0);

    assert_eq!(
        InternalValue::from_components(*b"a", *b"new", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"a", *b"old", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"new", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"b", *b"old", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"newnew", 999, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"new", 998, ValueType::Value),
        iter.next().unwrap()?,
    );
    assert_eq!(
        InternalValue::from_components(*b"c", *b"old", 997, ValueType::Value),
        iter.next().unwrap()?,
    );
    iter_closed!(iter);

    Ok(())
}

#[test]
fn compaction_stream_filter_1() {
    struct Filter(&'static [u8]);
    impl StreamFilter for Filter {
        fn filter_item(&mut self, value: &InternalValue) -> crate::Result<StreamFilterVerdict> {
            if value.key.user_key == b"b" {
                Ok(StreamFilterVerdict::Drop)
            } else if value.value < self.0 {
                Ok(StreamFilterVerdict::Replace((
                    ValueType::Tombstone,
                    UserValue::empty(),
                )))
            } else {
                Ok(StreamFilterVerdict::Keep)
            }
        }
    }

    #[rustfmt::skip]
    let vec = stream![
        "a", "9", "V",
        "a", "8", "V",
        "a", "7", "V",
        // subsequent values will be filtered out
        "a", "6", "V",
        "a", "5", "V",
        // subsequent values below gc threshold after filter
        "a", "4", "V",

        // this value will be dropped without leaving a tombstone
        "b", "b", "V",
    ];

    let mut drop_cb = TrackCallback { items: vec![] };
    let iter = vec.iter().cloned().map(Ok);
    let iter = CompactionStream::new(iter, 995)
        .with_filter(Filter(b"7"))
        .with_drop_callback(&mut drop_cb);

    let out: Vec<_> = iter.map(Result::unwrap).collect();

    // Six entries, not five: every version at or above the threshold (999 down
    // to 995) plus the newest one below it (994). This expectation used to stop
    // at 995, which encoded the fold's older rule of discarding by the seqno of
    // the next-older sibling. That rule dropped exactly the version a read just
    // above the recorded retention floor resolves to.
    #[rustfmt::skip]
    assert_eq!(out, stream![
        "a", "9", "V",
        "a", "8", "V",
        "a", "7", "V",
        "a", "", "T",
        "a", "", "T",
        "a", "", "T",
    ]);

    let fc = InternalValue::from_components;

    #[rustfmt::skip]
    assert_eq!(drop_cb.items, [
        fc(b"a", b"6", 996, ValueType::Value),
        fc(b"a", b"5", 995, ValueType::Value),
        fc(b"a", b"4", 994, ValueType::Value),
        fc(b"b", b"b", 999, ValueType::Value),
    ]);
}

pub mod custom_mvcc {
    use super::*;
    use crate::io::{BE, ReadBytesExt, WriteBytesExt};
    use test_log::test;

    /// MVCC trailer size (anything but user key)
    const TRAILER_SIZE: usize = 10;

    // Our keys become a multi map of: <key>#<seqno>
    //
    // (type does not really matter for ordering, because key+seqno are unique anyway)
    fn kv(key: &[u8], seqno: SeqNo, value: &[u8], tomb: bool) -> InternalValue {
        InternalValue::from_components(
            {
                use std::io::Write;

                let len = key.len() + TRAILER_SIZE;

                let mut key_builder = unsafe { UserKey::builder_unzeroed(len) };
                let mut cursor = std::io::Cursor::new(&mut key_builder[..]);

                cursor.write_all(key).unwrap();
                cursor.write_u8(0).unwrap(); // Keys are variable size so we need a \0 delimiter
                cursor
                    .write_u64::<BE>(
                        // IMPORTANT: Invert the seqno for correct descending sort
                        !seqno,
                    )
                    .unwrap();
                cursor.write_u8(u8::from(tomb)).unwrap();

                debug_assert_eq!(len, usize::try_from(cursor.position()).unwrap());

                key_builder.freeze()
            },
            value,
            2_353, // does not matter for us
            ValueType::Value,
        )
    }

    struct Filter {
        /// The previous user key
        ///
        /// Note that the user key is NOT the full KV key
        /// because we embed MVCC information into the key (`user_key#seqno#type`).
        prev_user_key: Option<UserKey>,

        /// MVCC watermark we can safely delete if an item < watermark
        /// is covered by a newer version.
        mvcc_watermark: SeqNo,
    }

    impl StreamFilter for Filter {
        fn filter_item(&mut self, value: &InternalValue) -> crate::Result<StreamFilterVerdict> {
            let l = value.key.user_key.len();

            // User key len
            let ukl = l - TRAILER_SIZE;

            if let Some(prev) = &self.prev_user_key {
                let user_key = &value.key.user_key[..ukl];

                if prev == &user_key {
                    // We found another, older version of the previous key
                    let mut seqno = &value.key.user_key[(ukl + 1)..l - 1];
                    debug_assert_eq!(8, seqno.len());

                    // IMPORTANT: Invert the seqno back to normal value
                    let seqno = !seqno.read_u64::<BE>().unwrap();

                    if seqno < self.mvcc_watermark {
                        return Ok(StreamFilterVerdict::Drop);
                    }
                } else {
                    let user_key = &value.key.user_key.slice(..ukl);
                    self.prev_user_key = Some(user_key.clone());
                }
            } else {
                let user_key = &value.key.user_key.slice(..ukl);
                self.prev_user_key = Some(user_key.clone());
            }

            Ok(StreamFilterVerdict::Keep)
        }
    }

    #[test]
    fn compaction_filter_custom_mvcc() {
        let vec = vec![
            kv(b"abc", 4, b"c", false),
            kv(b"abc", 3, b"b", false),
            kv(b"abc", 2, b"a", false),
        ];

        let mut drop_cb = TrackCallback { items: vec![] };
        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 995)
            .with_filter(Filter {
                mvcc_watermark: 5,
                prev_user_key: None,
            })
            .with_drop_callback(&mut drop_cb);

        let out: Vec<_> = iter.map(Result::unwrap).collect();

        #[rustfmt::skip]
        assert_eq!(out, vec![
            kv(b"abc", 4, b"c", false),
        ]);
    }

    #[test]
    fn compaction_filter_custom_mvcc_multi_keys() {
        let vec = vec![
            kv(b"a", 4, b"c", false),
            kv(b"a", 3, b"b", false),
            kv(b"a", 2, b"a", false),
            //
            kv(b"b", 4, b"c", false),
            kv(b"b", 3, b"b", false),
            kv(b"b", 2, b"a", false),
            //
            kv(b"c", 1, b"c", false),
            //
            kv(b"d", 0, b"c", false),
        ];

        let mut drop_cb = TrackCallback { items: vec![] };
        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 995)
            .with_filter(Filter {
                mvcc_watermark: 3,
                prev_user_key: None,
            })
            .with_drop_callback(&mut drop_cb);

        let out: Vec<_> = iter.map(Result::unwrap).collect();

        #[rustfmt::skip]
        assert_eq!(out, vec![
            kv(b"a", 4, b"c", false),
            kv(b"a", 3, b"b", false),
            //
            kv(b"b", 4, b"c", false),
            kv(b"b", 3, b"b", false),
            //
            kv(b"c", 1, b"c", false),
            //
            kv(b"d", 0, b"c", false),
        ]);
    }
}

mod merge_operator_tests {
    use super::*;
    use std::sync::Arc;
    use test_log::test;

    /// Concatenation merge operator: joins all operands with ","
    struct ConcatMerge;

    impl crate::merge_operator::MergeOperator for ConcatMerge {
        fn merge(
            &self,
            _key: &[u8],
            base_value: Option<&[u8]>,
            operands: &[&[u8]],
        ) -> crate::Result<UserValue> {
            let mut result = match base_value {
                Some(b) => String::from_utf8_lossy(b).to_string(),
                None => String::new(),
            };
            for op in operands {
                if !result.is_empty() {
                    result.push(',');
                }
                result.push_str(&String::from_utf8_lossy(op));
            }
            Ok(result.into_bytes().into())
        }
    }

    fn merge_op() -> Arc<dyn crate::merge_operator::MergeOperator> {
        Arc::new(ConcatMerge)
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_operands_below_gc() -> crate::Result<()> {
        // All entries below gc_watermark=1000, no base → partial merge
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        // Partial merge (no base boundary) → stays MergeOperand
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op1,op2");
        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_with_base_below_gc() -> crate::Result<()> {
        // Merge operands + base value, all below gc threshold
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
            "a", "base", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::Value);
        assert_eq!(&*item.value, b"base,op1,op2");
        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_base_deleted_by_range_tombstone() -> crate::Result<()> {
        // op@999 and mid@998 operands above a base@997; a range tombstone over
        // the key at seqno 998 deletes the base (997 < 998), while the operands
        // survive (999, 998 are not below 998). The operands fold onto an empty
        // base, and the dropped base value reaches the callback.
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "a", "mid", "M",
            "a", "base", "V",
        ];

        let mut callback = TrackCallback::default();
        let cmp = crate::comparator::default_comparator();
        let rt = RangeTombstone::new(
            UserKey::from(b"a".as_ref()),
            UserKey::from(b"b".as_ref()),
            998,
        );

        let iter = vec.iter().cloned().map(Ok);
        {
            let mut iter = CompactionStream::new(iter, 1_000)
                .with_merge_operator(Some(merge_op()))
                .with_range_tombstone_application(vec![rt], cmp)
                .with_drop_callback(&mut callback);

            let item = iter.next().unwrap()?;
            assert_eq!(item.key.value_type, ValueType::Value);
            assert_eq!(&*item.value, b"mid,op");
            assert!(iter.next().is_none());
        }
        assert!(
            callback.items.iter().any(|kv| &*kv.value == b"base"),
            "the range-deleted base value must reach the drop callback"
        );

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_drops_operands_below_range_tombstone() -> crate::Result<()> {
        // M@100 is above the range tombstone; M@80 and the base V@70 are below
        // it (and deleted by it). Only M@100 survives, folding onto an empty
        // base, so the result is just that operand. Built with explicit seqnos
        // because the range tombstone must sit between the operands.
        let entries = vec![
            InternalValue::from_components(
                b"a".as_ref(),
                b"hi".as_ref(),
                100,
                ValueType::MergeOperand,
            ),
            InternalValue::from_components(
                b"a".as_ref(),
                b"lo".as_ref(),
                80,
                ValueType::MergeOperand,
            ),
            InternalValue::from_components(b"a".as_ref(), b"base".as_ref(), 70, ValueType::Value),
        ];

        let cmp = crate::comparator::default_comparator();
        let rt = RangeTombstone::new(
            UserKey::from(b"a".as_ref()),
            UserKey::from(b"b".as_ref()),
            90,
        );

        let iter = entries.into_iter().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000)
            .with_merge_operator(Some(merge_op()))
            .with_range_tombstone_application(vec![rt], cmp);

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::Value);
        assert_eq!(
            &*item.value, b"hi",
            "only the operand above the range tombstone survives"
        );
        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_with_tombstone_below_gc() -> crate::Result<()> {
        // Merge operand above tombstone → merge with no base
        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
            "a", "", "T",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::Value);
        assert_eq!(&*item.value, b"op1");
        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_above_gc_preserved() -> crate::Result<()> {
        // Entries above gc_watermark → NOT merged, preserved as-is
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 0) // gc_watermark=0, nothing expired
            .with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op2");

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op1");

        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_lone_operand_below_gc() -> crate::Result<()> {
        // Single merge operand (only entry for key) below gc → partial merge
        let vec = vec![
            InternalValue::from_components("a", "lone_op", 5, ValueType::MergeOperand),
            InternalValue::from_components("b", "regular", 6, ValueType::Value),
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        // Partial merge (no base boundary) → stays MergeOperand
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"lone_op");
        assert_eq!(&*item.key.user_key, b"a");

        let item = iter.next().unwrap()?;
        assert_eq!(&*item.key.user_key, b"b");
        assert_eq!(&*item.value, b"regular");

        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_last_item_operand() -> crate::Result<()> {
        // Last item in entire stream is a merge operand below gc
        let vec = vec![InternalValue::from_components(
            "z",
            "last",
            5,
            ValueType::MergeOperand,
        )];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        // Partial merge (no base boundary) → stays MergeOperand
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"last");

        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    fn compaction_merge_mixed_keys() -> crate::Result<()> {
        // Multiple keys, some with merge operands, some without
        let vec = vec![
            InternalValue::from_components("a", "val_a", 10, ValueType::Value),
            InternalValue::from_components("b", "op2", 9, ValueType::MergeOperand),
            InternalValue::from_components("b", "op1", 8, ValueType::MergeOperand),
            InternalValue::from_components("b", "base_b", 7, ValueType::Value),
            InternalValue::from_components("c", "val_c", 6, ValueType::Value),
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let out: Vec<_> = iter.map(Result::unwrap).collect();

        assert_eq!(out.len(), 3);
        assert_eq!(&*out[0].key.user_key, b"a");
        assert_eq!(&*out[0].value, b"val_a");
        assert_eq!(&*out[1].key.user_key, b"b");
        assert_eq!(&*out[1].value, b"base_b,op1,op2");
        assert_eq!(&*out[2].key.user_key, b"c");
        assert_eq!(&*out[2].value, b"val_c");

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_no_operator_passthrough() -> crate::Result<()> {
        // Without merge operator, MergeOperand entries pass through unchanged
        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000);

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op1");

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_with_weak_tombstone() -> crate::Result<()> {
        // Merge operand above weak tombstone → merge with no base
        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
            "a", "", "W",
            "a", "old_val", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::Value);
        assert_eq!(&*item.value, b"op1");
        assert!(iter.next().is_none());

        Ok(())
    }

    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_seqno_zeroing() -> crate::Result<()> {
        // Merged value should get seqno zeroed when below threshold
        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
            "a", "base", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000)
            .with_merge_operator(Some(merge_op()))
            .zero_seqnos(true);

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.seqno, 0);
        assert_eq!(&*item.value, b"base,op1");

        Ok(())
    }

    /// When merge operands sit above an Indirection base, compaction must
    /// preserve ALL entries unchanged — no operand may be dropped.
    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_indirection_base_preserves_all() -> crate::Result<()> {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
            "a", "blob_ptr", "I",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));

        // All three entries must be emitted unchanged
        let item = iter.next().unwrap()?;
        assert_eq!(&*item.key.user_key, b"a");
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op2");

        let item = iter.next().unwrap()?;
        assert_eq!(&*item.key.user_key, b"a");
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op1");

        let item = iter.next().unwrap()?;
        assert_eq!(&*item.key.user_key, b"a");
        assert_eq!(item.key.value_type, ValueType::Indirection);
        assert_eq!(&*item.value, b"blob_ptr");

        assert!(iter.next().is_none());
        Ok(())
    }

    /// Exact GC boundary: head.seqno == gc_watermark should NOT merge.
    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_at_exact_gc_boundary() -> crate::Result<()> {
        // gc_watermark=999; head.seqno=999 (NOT below threshold)
        // Entries should be preserved as-is
        let vec = vec![
            InternalValue::from_components("a", "op2", 999, ValueType::MergeOperand),
            InternalValue::from_components("a", "op1", 998, ValueType::MergeOperand),
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 999).with_merge_operator(Some(merge_op()));

        // head.seqno == gc_watermark → NOT below → preserved as MergeOperand
        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op2");

        Ok(())
    }

    /// DroppedKvCallback receives dropped merge operands during compaction.
    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_dropped_callback() -> crate::Result<()> {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
            "a", "base", "V",
        ];

        let mut callback = TrackCallback::default();

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000)
            .with_merge_operator(Some(merge_op()))
            .with_drop_callback(&mut callback);

        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::Value);
        assert_eq!(&*item.value, b"base,op1,op2");
        assert!(iter.next().is_none());

        // The base Value is consumed by merge (not dropped);
        // operands are consumed by merge (not dropped via callback).
        // DroppedKvCallback fires for entries DRAINED after base is found.
        // In this case there are no entries after the base, so callback
        // should have no items.
        assert!(callback.items.is_empty());

        Ok(())
    }

    /// Head above GC, peeked below GC: head must be preserved as MergeOperand.
    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_merge_head_above_gc_peeked_below() -> crate::Result<()> {
        // head.seqno=10 (above gc=7), peeked.seqno=5 (below gc=7)
        let vec = vec![
            InternalValue::from_components("a", "op_new", 10, ValueType::MergeOperand),
            InternalValue::from_components("a", "op_old", 5, ValueType::MergeOperand),
            InternalValue::from_components("a", "base", 2, ValueType::Value),
        ];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 7).with_merge_operator(Some(merge_op()));

        // Head is above GC → emit as-is (MergeOperand)
        let item = iter.next().unwrap()?;
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"op_new");

        // Remaining entries preserved for future merge resolution
        let item = iter.next().unwrap()?;
        assert_eq!(&*item.key.user_key, b"a");

        Ok(())
    }

    /// Merge operator error propagates correctly during compaction.
    #[test]
    fn compaction_merge_error_propagation() {
        struct FailMerge;
        impl crate::merge_operator::MergeOperator for FailMerge {
            fn merge(
                &self,
                _key: &[u8],
                _base_value: Option<&[u8]>,
                _operands: &[&[u8]],
            ) -> crate::Result<crate::UserValue> {
                Err(crate::Error::MergeOperator)
            }
        }

        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
            "a", "base", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let fail_op: Option<Arc<dyn crate::merge_operator::MergeOperator>> =
            Some(Arc::new(FailMerge));
        let mut iter = CompactionStream::new(iter, 1_000).with_merge_operator(fail_op);

        assert!(matches!(
            iter.next(),
            Some(Err(crate::Error::MergeOperator))
        ));
    }

    /// Complete merge (with base) emits Value; partial merge emits MergeOperand.
    #[test]
    fn compaction_merge_complete_vs_partial() -> crate::Result<()> {
        // Complete merge: operand + base → Value
        #[rustfmt::skip]
        let vec = stream![
            "a", "op1", "M",
            "a", "base", "V",
            "b", "op2", "M",
            "b", "op1", "M",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));
        let out: Vec<_> = iter.map(Result::unwrap).collect();

        assert_eq!(out.len(), 2);
        // "a": base found → complete merge → Value
        assert_eq!(out[0].key.value_type, ValueType::Value);
        assert_eq!(&*out[0].value, b"base,op1");
        // "b": no base → partial merge → MergeOperand
        assert_eq!(out[1].key.value_type, ValueType::MergeOperand);
        assert_eq!(&*out[1].value, b"op1,op2");

        Ok(())
    }

    /// Stream filter that replaces values preserves MergeOperand type.
    #[test]
    #[expect(clippy::unwrap_used, reason = "test assertion")]
    fn compaction_filter_preserves_merge_operand_type() -> crate::Result<()> {
        struct UpperFilter;
        impl StreamFilter for UpperFilter {
            fn filter_item(&mut self, _item: &InternalValue) -> crate::Result<StreamFilterVerdict> {
                Ok(StreamFilterVerdict::Replace((
                    ValueType::Value,
                    b"REPLACED".to_vec().into(),
                )))
            }
        }

        let vec = vec![InternalValue::from_components(
            "a",
            "op1",
            5,
            ValueType::MergeOperand,
        )];

        let iter = vec.iter().cloned().map(Ok);
        let mut iter = CompactionStream::new(iter, 1_000).with_filter(UpperFilter);

        let item = iter.next().unwrap()?;
        // Filter tried to set Value, but MergeOperand type must be preserved
        assert_eq!(item.key.value_type, ValueType::MergeOperand);
        assert_eq!(&*item.value, b"REPLACED");

        Ok(())
    }

    /// A merge resolution swallows the base inline, so the key's tail is
    /// already empty by the time the fold would drain it. The run still lost a
    /// version and has to say so, or a reopened tree admits the snapshot that
    /// resolved to the base and answers it with the merged entry's newer seqno.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_merge_fold_swallows_base_is_positive() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "a", "base", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        // Both versions below the watermark, so the fold runs and consumes the
        // base into the merged result.
        let iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert!(
            balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
            "the base folded into the merge result is collected history",
        );
    }

    /// The same shape with a single operand and no base: nothing is consumed
    /// beyond the head, so nothing was collected and the floor must not move.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_lone_merge_operand_is_zero() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "b", "vb", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
    }

    /// The tombstone a merge fold resolves against is consumed by the fold, and
    /// at the bottom level that is the same neutrality the plain fold already
    /// excuses: the output no longer carries the tombstone, and the key reads
    /// absent for every snapshot that used to resolve to it.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_merge_fold_over_a_bottom_level_tombstone_is_zero() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "a", "", "T",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000)
            .evict_tombstones(true)
            .with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
    }

    /// Off the bottom level the same fold is not neutral: a lower level may hold
    /// the version the tombstone was hiding, and dropping the tombstone without
    /// a floor resurrects it for the snapshots the floor would refuse.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_merge_fold_over_a_tombstone_off_the_bottom_level_is_positive() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "a", "", "T",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000).with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert!(
            balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
            "off the bottom level a folded-away tombstone is collected history",
        );
    }

    /// A value under the tombstone makes the fold collection even at the bottom
    /// level: a snapshot below the tombstone resolved to that value and no
    /// longer can, since the merged result carries the head's seqno.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_merge_fold_over_a_tombstone_hiding_a_value_is_positive() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op", "M",
            "a", "", "T",
            "a", "val", "V",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000)
            .evict_tombstones(true)
            .with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert!(
            balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
            "a value under the folded tombstone is collected history",
        );
    }

    /// An operand between the head and the tombstone is folded into one result
    /// carrying the head's seqno, so a snapshot that resolved to that operand
    /// alone loses it. The tombstone excuse covers the tombstone tail only.
    #[test]
    #[expect(clippy::expect_used, reason = "test assertion")]
    fn gc_balance_merge_fold_swallowing_an_operand_over_a_tombstone_is_positive() {
        #[rustfmt::skip]
        let vec = stream![
            "a", "op2", "M",
            "a", "op1", "M",
            "a", "", "T",
        ];

        let iter = vec.iter().cloned().map(Ok);
        let iter = CompactionStream::new(iter, 1_000)
            .evict_tombstones(true)
            .with_merge_operator(Some(merge_op()));
        let balance = iter.gc_balance();
        for item in iter {
            item.expect("stream must not error");
        }

        assert!(
            balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
            "an operand consumed into the merged result is collected history",
        );
    }
}

/// Regression: the "is the peeked entry a different key?" check used a bytewise
/// `>` on the user keys instead of key identity. Under a comparator whose order
/// differs from byte order (reverse-lexicographic here), a following DIFFERENT
/// key sorts bytewise-lower, so the old check classified it as "same key": a
/// `WeakTombstone` head then saw the other key's `Value` as its annihilation
/// partner and was dropped, resurrecting older versions below.
#[test]
#[expect(clippy::unwrap_used, reason = "test assertion")]
fn compaction_stream_custom_comparator_weak_tombstone_not_annihilated_across_keys()
-> crate::Result<()> {
    // Comparator-ascending order for reverse-lex: "b" sorts before "a".
    let vec = vec![
        InternalValue::from_components("b", "", 999, ValueType::WeakTombstone),
        InternalValue::from_components("a", "va", 998, ValueType::Value),
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_000);

    // The weak tombstone has NO same-key value after it — it must survive.
    let first = iter.next().unwrap()?;
    assert_eq!(first.key.value_type, ValueType::WeakTombstone);
    assert_eq!(&*first.key.user_key, b"b");

    let second = iter.next().unwrap()?;
    assert_eq!(second.key.value_type, ValueType::Value);
    assert_eq!(&*second.key.user_key, b"a");

    iter_closed!(iter);
    Ok(())
}

/// Runs the stream to exhaustion and reports how many watermark-driven drops
/// it counted.
#[expect(clippy::expect_used, reason = "test assertion")]
fn collected_count(vec: &[InternalValue], gc_watermark: u64) -> u64 {
    let iter = vec.iter().cloned().map(Ok);
    let iter = CompactionStream::new(iter, gc_watermark);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }
    balance.load(core::sync::atomic::Ordering::Relaxed)
}

#[test]
fn gc_balance_watermark_collects_nothing_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "new", "V",
      "a", "old", "V",
    ];

    // Threshold 998 leaves both versions at or above the watermark, so the
    // fold keeps them and nothing is collected.
    assert_eq!(collected_count(&vec, 998), 0);
}

#[test]
fn gc_balance_one_version_per_key_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "va", "V",
      "b", "vb", "V",
    ];

    // Nothing to fold at any watermark: each key has a single version, so a
    // run over this input must not claim it collected history.
    assert_eq!(collected_count(&vec, 1_000), 0);
    assert_eq!(collected_count(&vec, 0), 0);
}

#[test]
fn gc_balance_watermark_drops_a_version_is_positive() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "new", "V",
      "a", "old", "V",
    ];

    // Threshold 1000 puts both below the watermark, so the older one is
    // collected and the run has to say so.
    assert_eq!(collected_count(&vec, 1_000), 1);
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_lone_bottom_level_tombstone_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "b", "vb", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let iter = CompactionStream::new(iter, 0).evict_tombstones(true);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }

    // The tombstone shadows nothing, so dropping it answers every snapshot the
    // way keeping it would. That is not collected history and must not raise a
    // floor, least of all at a watermark of 0. The balance counts every
    // consumed version, so this arm has to excuse itself explicitly.
    assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_tombstone_only_chain_at_the_bottom_level_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // Both tombstones below the watermark at the bottom level: the eviction arm
    // takes the head and drains the rest of the chain.
    let iter = CompactionStream::new(iter, 1_000).evict_tombstones(true);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }

    // The key read as absent at every snapshot before the drop and reads absent
    // after it, exactly as for a lone tombstone. Dropping a whole chain of them
    // is the same neutrality and must not cost a floor.
    assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_tombstone_tail_under_an_emitted_head_at_the_bottom_level_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "val", "V",
      "a", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let iter = CompactionStream::new(iter, 1_000).evict_tombstones(true);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }

    // Every snapshot below the value read "absent" through the tombstone and
    // reads "absent" from nothing after the fold. Nothing observable changed,
    // so no floor is owed.
    assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_tombstone_tail_off_the_bottom_level_is_positive() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "val", "V",
      "a", "", "T",
    ];

    let iter = vec.iter().cloned().map(Ok);
    // NOT the bottom level: a lower level may still hold a version the drained
    // tombstone was hiding, so dropping it without a floor would resurrect that
    // version for the snapshots the floor refuses.
    let iter = CompactionStream::new(iter, 1_000);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }

    assert!(
        balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
        "off the bottom level a dropped tombstone is collected history",
    );
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_tombstone_chain_over_a_value_is_positive() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "", "T",
      "a", "", "T",
      "a", "val", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let iter = CompactionStream::new(iter, 1_000).evict_tombstones(true);
    let balance = iter.gc_balance();
    for item in iter {
        item.expect("stream must not error");
    }

    // A value anywhere under the chain makes the drop collection: a snapshot
    // below the oldest tombstone resolved to it and no longer can.
    assert!(
        balance.load(core::sync::atomic::Ordering::Relaxed) > 0,
        "a chain that also swallowed a value is collected history",
    );
}

#[test]
#[expect(clippy::expect_used, reason = "test assertion")]
fn gc_balance_abandoned_after_one_item_is_zero() {
    #[rustfmt::skip]
    let vec = stream![
      "a", "va", "V",
      "b", "vb", "V",
    ];

    let iter = vec.iter().cloned().map(Ok);
    let mut iter = CompactionStream::new(iter, 1_000);
    let balance = iter.gc_balance();

    // Take one and walk away, which is what a compaction stopped by its signal
    // does before installing what it wrote. The peek that looked ahead at "b"
    // must not leave that version on the balance: this run collected nothing.
    iter.next()
        .expect("first item")
        .expect("stream must not error");
    drop(iter);

    assert_eq!(balance.load(core::sync::atomic::Ordering::Relaxed), 0);
}