1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
// SPDX-License-Identifier: Apache-2.0
// Copyright (c) 2024-present, fjall-rs
// Copyright (c) 2026-present, Structured World Foundation
use super::Tree;
use crate::{
BlobIndirection, SeqNo, UserKey, UserValue, config::FilterPolicyEntry, fs::Fs,
table::multi_writer::MultiWriter,
};
use alloc::sync::Arc;
#[cfg(not(feature = "std"))]
use alloc::{string::ToString, vec::Vec};
use core::cmp::Ordering;
use crate::path::PathBuf;
pub const INITIAL_CANONICAL_LEVEL: usize = 1;
/// Bulk ingestion
///
/// Items NEED to be added in ascending key order.
///
/// Ingested data bypasses memtables and is written directly into new tables,
/// using the same table writer configuration that is used for flush and compaction.
pub struct Ingestion<'a> {
pub(crate) folder: PathBuf,
/// Level-routed filesystem backend for the target level.
pub(crate) level_fs: Arc<dyn Fs>,
tree: &'a Tree,
pub(crate) writer: MultiWriter,
seqno: SeqNo,
last_key: Option<UserKey>,
}
impl<'a> Ingestion<'a> {
/// Creates a new ingestion.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
pub fn new(tree: &'a Tree) -> crate::Result<Self> {
// Ingested tables are placed at L0 (via with_new_l0_run), so use
// the level-routed folder for level 0.
let (folder, level_fs) = tree.config.tables_folder_for_level(0);
log::debug!("Ingesting into tables in {}", folder.display());
let index_partitioning = tree
.config
.index_block_partitioning_policy
.get(INITIAL_CANONICAL_LEVEL);
let filter_partitioning = tree
.config
.filter_block_partitioning_policy
.get(INITIAL_CANONICAL_LEVEL);
// Ingested tables are an L0 run; their canonical config level is
// INITIAL_CANONICAL_LEVEL, the same level every per-level policy
// below is read at. The writer's level only feeds the per-block
// policy decisions (e.g. `PerLevel` kv-checksums) — `meta.initial_level`
// is write-only and placement is forced to L0 by `with_new_l0_run`
// regardless — so this keeps kv-checksum level-gating consistent with
// the compression / filter / restart policies applied to ingested
// tables.
#[expect(
clippy::cast_possible_truncation,
reason = "INITIAL_CANONICAL_LEVEL is 1, well within u8"
)]
let ingest_level = INITIAL_CANONICAL_LEVEL as u8;
// TODO: maybe create a PrepareMultiWriter that can be used by flush, ingest and compaction worker
let mut writer = MultiWriter::new(
folder.clone(),
tree.table_id_counter.clone(),
64 * 1_024 * 1_024,
ingest_level,
level_fs.clone(),
)?
.set_comparator(tree.config.comparator.clone())
.use_bloom_policy({
if tree.config.expect_point_read_hits {
crate::config::BloomConstructionPolicy::BitsPerKey(0.0)
} else if let FilterPolicyEntry::Bloom(p) =
tree.config.filter_policy.get(INITIAL_CANONICAL_LEVEL)
{
p
} else {
crate::config::BloomConstructionPolicy::BitsPerKey(0.0)
}
})
.use_data_block_size(
tree.config
.data_block_size_policy
.get(INITIAL_CANONICAL_LEVEL),
)
.use_data_block_hash_ratio(
tree.config
.data_block_hash_ratio_policy
.get(INITIAL_CANONICAL_LEVEL),
)
.use_data_block_compression(
tree.config
.data_block_compression_policy
.get(INITIAL_CANONICAL_LEVEL),
)
.use_index_block_compression(
tree.config
.index_block_compression_policy
.get(INITIAL_CANONICAL_LEVEL),
)
.use_data_block_restart_interval(
tree.config
.data_block_restart_interval_policy
.get(INITIAL_CANONICAL_LEVEL),
)
.use_index_block_restart_interval(
tree.config
.index_block_restart_interval_policy
.get(INITIAL_CANONICAL_LEVEL),
);
// One runtime-config snapshot for the whole ingestion writer setup, so
// a concurrent `update_runtime_config` can't leave the ingested SST
// with `seqno_in_index` from one snapshot and checksum settings from
// another. `Off` (default) emits no per-KV footer and leaves the
// data-block payload encoding unchanged; the index format follows the
// policy in force at ingestion.
let rc = tree.0.runtime_config.load_full();
if index_partitioning {
// Size-adaptive index: single-level for small SSTs, spill to
// partitioned only past the threshold (see flush path).
writer = writer.use_adaptive_index(rc.index_partition_spill_threshold);
}
if filter_partitioning {
writer = writer.use_partitioned_filter();
}
writer = writer.use_prefix_extractor(tree.config.prefix_extractor.clone());
writer = writer.use_encryption(tree.config.encryption.clone());
// ECC scheme from the same live snapshot as `seqno_in_index` /
// `kv_checksums` below, so an ingestion started after a scheme change
// writes its SST with the current scheme rather than the startup one.
writer = writer.use_page_ecc(tree.config.page_ecc, rc.ecc_scheme);
writer = writer.use_sync_mode(tree.config.sync_mode);
writer = writer.use_seqno_in_index(rc.seqno_in_index);
writer = writer.use_disable_cow_on_sst(rc.disable_cow_on_sst_files);
writer = writer.use_kv_checksums(rc.kv_checksums, rc.kv_checksum_algo);
#[cfg(zstd_any)]
{
writer = writer.use_zstd_dictionary(tree.config.zstd_dictionary.clone());
}
Ok(Self {
folder,
level_fs,
tree,
writer,
seqno: 0,
last_key: None,
})
}
/// Writes a key-value pair.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
pub(crate) fn write_indirection(
&mut self,
key: UserKey,
indirection: BlobIndirection,
) -> crate::Result<()> {
use crate::coding::Encode;
if let Some(prev) = &self.last_key {
assert!(
self.tree.config.comparator.compare(prev, &key) == Ordering::Less,
"next key in ingestion must be ordered after last key by configured comparator"
);
}
let cloned_key = key.clone();
self.writer.write(crate::InternalValue::from_components(
key,
indirection.encode_into_vec(),
self.seqno,
crate::ValueType::Indirection,
))?;
self.writer.register_blob(indirection);
// Remember the last user key to validate the next call's ordering
self.last_key = Some(cloned_key);
Ok(())
}
/// Writes a key-value pair.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
pub fn write(&mut self, key: UserKey, value: UserValue) -> crate::Result<()> {
if let Some(prev) = &self.last_key {
assert!(
self.tree.config.comparator.compare(prev, &key) == Ordering::Less,
"next key in ingestion must be ordered after last key by configured comparator"
);
}
self.writer.write(crate::InternalValue::from_components(
key.clone(),
value,
self.seqno,
crate::ValueType::Value,
))?;
// Remember the last user key to validate the next call's ordering
self.last_key = Some(key);
Ok(())
}
/// Writes a tombstone for a key.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
pub fn write_tombstone(&mut self, key: UserKey) -> crate::Result<()> {
if let Some(prev) = &self.last_key {
assert!(
self.tree.config.comparator.compare(prev, &key) == Ordering::Less,
"next key in ingestion must be ordered after last key by configured comparator"
);
}
self.writer.write(crate::InternalValue::from_components(
key.clone(),
crate::UserValue::empty(),
self.seqno,
crate::ValueType::Tombstone,
))?;
// Remember the last user key to validate the next call's ordering
self.last_key = Some(key);
Ok(())
}
/// Writes a weak tombstone for a key.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
pub fn write_weak_tombstone(&mut self, key: UserKey) -> crate::Result<()> {
if let Some(prev) = &self.last_key {
assert!(
self.tree.config.comparator.compare(prev, &key) == Ordering::Less,
"next key in ingestion must be ordered after last key by configured comparator"
);
}
self.writer.write(crate::InternalValue::from_components(
key.clone(),
crate::UserValue::empty(),
self.seqno,
crate::ValueType::WeakTombstone,
))?;
// Remember the last user key to validate the next call's ordering
self.last_key = Some(key);
Ok(())
}
/// Finishes the ingestion.
///
/// # Errors
///
/// Will return `Err` if an IO error occurs.
#[allow(clippy::significant_drop_tightening)]
pub fn finish(self) -> crate::Result<()> {
use crate::{AbstractTree, Table};
if self.last_key.is_none() {
log::trace!("No data written to Ingestion, returning early");
return Ok(());
}
// CRITICAL SECTION: Atomic flush + seqno allocation + registration
//
// We must ensure no concurrent writes interfere between flushing the
// active memtable and registering the ingested tables. The sequence is:
// 1. Acquire flush lock (prevents concurrent flushes)
// 2. Flush active memtable (ensures no pending writes)
// 3. Finish ingestion writer (creates table files)
// 4. Allocate next global seqno (atomic timestamp)
// 5. Recover tables with that seqno
// 6. Register version with same seqno
//
// Why not flush in new()?
// If we flushed in new(), there would be a race condition:
// new() -> flush -> [TIME PASSES + OTHER WRITES] -> finish() -> seqno
// The seqno would be disconnected from the flush, violating MVCC.
//
// By holding the flush lock throughout, we guarantee atomicity.
let flush_lock = self.tree.get_flush_lock();
// Flush any pending memtable writes to ensure ingestion sees a
// consistent snapshot and lookup order remains correct.
// We call rotate + flush directly because we already hold the lock.
self.tree.rotate_memtable();
self.tree.flush(&flush_lock, 0)?;
// Finalize the ingestion writer, writing all buffered data to disk.
let results = self.writer.finish()?;
log::info!("Finished ingestion writer");
// Acquire locks for version registration. We must hold both the
// compaction state lock and version history lock to safely modify
// the tree's version.
let mut _compaction_state = self.tree.compaction_state.lock();
let mut version_lock = self.tree.version_history.write();
// Allocate the next global sequence number. This seqno will be shared
// by all ingested tables and the version that registers them, ensuring
// consistent MVCC snapshots.
let global_seqno = self.tree.config.seqno.next();
// Recover all created tables, assigning them the global_seqno we just
// allocated. This ensures all ingested tables share the same sequence
// number, which is critical for MVCC correctness.
//
// We intentionally do NOT pin filter/index blocks here. Large ingests
// are typically placed in level 1, and pinning would increase memory
// pressure unnecessarily.
let created_tables = results
.into_iter()
.map(|(table_id, checksum)| -> crate::Result<Table> {
Table::recover(
self.folder.join(table_id.to_string()),
checksum,
global_seqno,
self.tree.id,
table_id,
self.tree.config.cache.clone(),
self.tree.config.descriptor_table.clone(),
self.level_fs.clone(),
false,
false,
self.tree.config.encryption.clone(),
#[cfg(zstd_any)]
self.tree.config.zstd_dictionary.clone(),
self.tree.config.comparator.clone(),
#[cfg(feature = "metrics")]
self.tree.metrics.clone(),
)
})
.collect::<crate::Result<Vec<_>>>()?;
// Upgrade the version with our ingested tables, using the global_seqno
// we allocated earlier. This ensures the version and all tables share
// the same sequence number.
//
// We use upgrade_version_with_seqno (instead of upgrade_version) because
// we need precise control over the seqno: it must match the seqno we
// already assigned to the recovered tables.
version_lock.upgrade_version_with_seqno(
&self.tree.config.path,
|current| {
let mut copy = current.clone();
let ctx =
crate::version::TransformContext::new(self.tree.config.comparator.as_ref());
copy.version = copy
.version
.with_new_l0_run(&created_tables, None, None, &ctx);
Ok(copy)
},
global_seqno,
&self.tree.config.visible_seqno,
&*self.tree.config.fs,
self.tree.0.runtime_config.load_full(),
self.tree.0.config.encryption.clone(),
)?;
// Perform maintenance on the version history (e.g., clean up old versions).
// We use gc_watermark=0 since ingestion doesn't affect sealed memtables.
if let Err(e) = version_lock.maintenance(&self.tree.config.path, 0, &*self.tree.config.fs) {
log::warn!("Version GC failed: {e:?}");
}
Ok(())
}
}