converge-ferrox-solver 0.5.0

Iron-forged OR-Tools and HiGHS solvers as Converge Suggestors
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
use async_trait::async_trait;
use converge_pack::{AgentEffect, Context, ContextKey, ProposedFact, Suggestor};
use ferrox_ortools_sys::OrtoolsStatus;
use ferrox_ortools_sys::safe::CpModel;
use std::collections::HashMap;
use tracing::warn;

use super::problem::{ConstraintKind, CpSatPlan, CpSatRequest};

const REQUEST_PREFIX: &str = "cpsat-request:";
const PLAN_PREFIX: &str = "cpsat-plan:";

pub struct CpSatSuggestor;

#[async_trait]
impl Suggestor for CpSatSuggestor {
    fn name(&self) -> &'static str {
        "CpSatSuggestor"
    }

    fn dependencies(&self) -> &[ContextKey] {
        &[ContextKey::Seeds]
    }

    fn complexity_hint(&self) -> Option<&'static str> {
        Some("NP-hard in general; CP-SAT DPLL+propagation+LNS; practical for n≤500 vars")
    }

    fn accepts(&self, ctx: &dyn Context) -> bool {
        ctx.get(ContextKey::Seeds)
            .iter()
            .any(|f| f.id().starts_with(REQUEST_PREFIX) && !plan_exists(ctx, request_id(f.id())))
    }

    async fn execute(&self, ctx: &dyn Context) -> AgentEffect {
        let mut proposals = Vec::new();

        for fact in ctx
            .get(ContextKey::Seeds)
            .iter()
            .filter(|f| f.id().starts_with(REQUEST_PREFIX))
        {
            let rid = request_id(fact.id());
            if plan_exists(ctx, rid) {
                continue;
            }

            match serde_json::from_str::<CpSatRequest>(fact.content()) {
                Ok(req) => {
                    let plan = solve_cp(&req);
                    let confidence = match plan.status.as_str() {
                        "optimal" => 1.0,
                        "feasible" => 0.7,
                        _ => 0.0,
                    };
                    proposals.push(
                        ProposedFact::new(
                            ContextKey::Strategies,
                            format!("{PLAN_PREFIX}{}", plan.request_id),
                            serde_json::to_string(&plan).unwrap_or_default(),
                            self.name(),
                        )
                        .with_confidence(confidence),
                    );
                }
                Err(e) => {
                    warn!(id = %fact.id(), error = %e, "malformed cpsat-request");
                }
            }
        }

        if proposals.is_empty() {
            AgentEffect::empty()
        } else {
            AgentEffect::with_proposals(proposals)
        }
    }
}

fn request_id(fact_id: &str) -> &str {
    fact_id.trim_start_matches(REQUEST_PREFIX)
}

fn plan_exists(ctx: &dyn Context, request_id: &str) -> bool {
    let plan_id = format!("{PLAN_PREFIX}{request_id}");
    ctx.get(ContextKey::Strategies)
        .iter()
        .any(|f| f.id() == plan_id.as_str())
}

#[allow(clippy::too_many_lines)]
pub fn solve_cp(req: &CpSatRequest) -> CpSatPlan {
    let mut model = CpModel::new();
    let mut name_to_idx: HashMap<String, i32> = HashMap::new();
    let mut bool_name_to_idx: HashMap<String, i32> = HashMap::new();
    let mut interval_name_to_idx: HashMap<String, i32> = HashMap::new();

    for var in &req.variables {
        let idx = if var.is_bool {
            let i = model.new_bool_var(&var.name);
            bool_name_to_idx.insert(var.name.clone(), i);
            i
        } else {
            model.new_int_var(var.lb, var.ub, &var.name)
        };
        name_to_idx.insert(var.name.clone(), idx);
    }

    for ivd in &req.interval_vars {
        if let (Some(&s), Some(&e)) = (
            name_to_idx.get(&ivd.start_var),
            name_to_idx.get(&ivd.end_var),
        ) {
            let idx = model.new_fixed_interval_var(s, ivd.duration, e, &ivd.name);
            interval_name_to_idx.insert(ivd.name.clone(), idx);
        } else {
            warn!(name = %ivd.name, "interval_var references unknown start/end variable");
        }
    }

    for ovd in &req.optional_interval_vars {
        match (
            name_to_idx.get(&ovd.start_var),
            name_to_idx.get(&ovd.end_var),
            bool_name_to_idx.get(&ovd.lit_var),
        ) {
            (Some(&s), Some(&e), Some(&lit)) => {
                let idx = model.new_optional_interval_var(s, ovd.duration, e, lit, &ovd.name);
                interval_name_to_idx.insert(ovd.name.clone(), idx);
            }
            _ => {
                warn!(name = %ovd.name, "optional_interval_var references unknown variable(s)");
            }
        }
    }

    for constraint in &req.constraints {
        match constraint {
            ConstraintKind::LinearLe { terms, rhs } => {
                let (vars, coeffs) = terms_to_vecs(terms, &name_to_idx);
                model.add_linear_le(&vars, &coeffs, *rhs);
            }
            ConstraintKind::LinearGe { terms, rhs } => {
                let (vars, coeffs) = terms_to_vecs(terms, &name_to_idx);
                model.add_linear_ge(&vars, &coeffs, *rhs);
            }
            ConstraintKind::LinearEq { terms, rhs } => {
                let (vars, coeffs) = terms_to_vecs(terms, &name_to_idx);
                model.add_linear_eq(&vars, &coeffs, *rhs);
            }
            ConstraintKind::AllDifferent { vars } => {
                let idxs: Vec<i32> = vars
                    .iter()
                    .filter_map(|v| name_to_idx.get(v).copied())
                    .collect();
                model.add_all_different(&idxs);
            }
            ConstraintKind::NoOverlap { intervals } => {
                let idxs: Vec<i32> = intervals
                    .iter()
                    .filter_map(|n| interval_name_to_idx.get(n).copied())
                    .collect();
                model.add_no_overlap(&idxs);
            }
        }
    }

    if let Some(obj_terms) = &req.objective_terms {
        let (vars, coeffs) = terms_to_vecs(obj_terms, &name_to_idx);
        if req.minimize {
            model.minimize(&vars, &coeffs);
        } else {
            model.maximize(&vars, &coeffs);
        }
    }

    let time_limit = req.time_limit_seconds.unwrap_or(60.0);
    let solution = model.solve(time_limit);

    let status = match solution.status() {
        OrtoolsStatus::Optimal => "optimal",
        OrtoolsStatus::Feasible => "feasible",
        OrtoolsStatus::Infeasible => "infeasible",
        OrtoolsStatus::Unbounded => "unbounded",
        _ => "error",
    };

    let assignments = if solution.status().is_success() {
        req.variables
            .iter()
            .filter_map(|v| {
                name_to_idx
                    .get(&v.name)
                    .map(|&idx| (v.name.clone(), solution.value(idx)))
            })
            .collect()
    } else {
        vec![]
    };

    let objective_value = if solution.status().is_success() && req.objective_terms.is_some() {
        Some(solution.objective_value())
    } else {
        None
    };

    CpSatPlan {
        request_id: req.id.clone(),
        status: status.to_string(),
        assignments,
        objective_value,
        wall_time_seconds: solution.wall_time(),
        solver: "cp-sat-v9.15".to_string(),
    }
}

fn terms_to_vecs(
    terms: &[crate::cp::problem::CpTerm],
    name_to_idx: &HashMap<String, i32>,
) -> (Vec<i32>, Vec<i64>) {
    terms
        .iter()
        .filter_map(|t| name_to_idx.get(&t.var).map(|&idx| (idx, t.coeff)))
        .unzip()
}

#[cfg(test)]
#[allow(
    clippy::cast_possible_wrap,
    clippy::mistyped_literal_suffixes,
    clippy::unreadable_literal,
    clippy::similar_names
)]
mod tests {
    use super::*;
    use crate::cp::problem::{CpTerm, CpVariable, IntervalVarDef, OptionalIntervalVarDef};
    use crate::test_support::MockContext;

    fn var(name: &str, lb: i64, ub: i64) -> CpVariable {
        CpVariable {
            name: name.into(),
            lb,
            ub,
            is_bool: false,
        }
    }

    fn bool_var(name: &str) -> CpVariable {
        CpVariable {
            name: name.into(),
            lb: 0,
            ub: 1,
            is_bool: true,
        }
    }

    fn term(var: &str, coeff: i64) -> CpTerm {
        CpTerm {
            var: var.into(),
            coeff,
        }
    }

    #[test]
    fn solves_n_queens_4() {
        // 4-queens via AllDifferent on row+col diagonals; ensures AllDifferent path covered.
        let n: i64 = 4;
        let mut variables = Vec::new();
        for i in 0..n {
            variables.push(var(&format!("q{i}"), 0, n - 1));
        }
        let constraints = vec![ConstraintKind::AllDifferent {
            vars: (0..n).map(|i| format!("q{i}")).collect(),
        }];
        let req = CpSatRequest {
            id: "queens".into(),
            variables,
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints,
            objective_terms: None,
            minimize: true,
            time_limit_seconds: Some(2.0),
        };
        let plan = solve_cp(&req);
        assert!(matches!(plan.status.as_str(), "optimal" | "feasible"));
        assert_eq!(plan.assignments.len(), 4);
        assert_eq!(plan.solver, "cp-sat-v9.15");
    }

    #[test]
    fn maximizes_simple_linear() {
        let req = CpSatRequest {
            id: "max".into(),
            variables: vec![var("x", 0, 10), var("y", 0, 10)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![ConstraintKind::LinearLe {
                terms: vec![term("x", 1), term("y", 1)],
                rhs: 8,
            }],
            objective_terms: Some(vec![term("x", 3), term("y", 2)]),
            minimize: false,
            time_limit_seconds: Some(2.0),
        };
        let plan = solve_cp(&req);
        assert_eq!(plan.status, "optimal");
        // optimal: maximize 3x+2y s.t. x+y<=8, x,y∈[0,10] → x=8, y=0, obj=24
        assert_eq!(plan.objective_value, Some(24));
    }

    #[test]
    fn detects_infeasible() {
        let req = CpSatRequest {
            id: "inf".into(),
            variables: vec![var("x", 0, 5)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![
                ConstraintKind::LinearGe {
                    terms: vec![term("x", 1)],
                    rhs: 10,
                },
                ConstraintKind::LinearLe {
                    terms: vec![term("x", 1)],
                    rhs: 5,
                },
            ],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(2.0),
        };
        let plan = solve_cp(&req);
        assert_eq!(plan.status, "infeasible");
        assert_eq!(plan.assignments.len(), 0);
    }

    #[test]
    fn linear_eq_constraint() {
        let req = CpSatRequest {
            id: "eq".into(),
            variables: vec![var("x", 0, 10), var("y", 0, 10)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![ConstraintKind::LinearEq {
                terms: vec![term("x", 1), term("y", 1)],
                rhs: 7,
            }],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(1.0),
        };
        let plan = solve_cp(&req);
        assert!(matches!(plan.status.as_str(), "optimal" | "feasible"));
        let map: HashMap<_, _> = plan.assignments.iter().cloned().collect();
        assert_eq!(map["x"] + map["y"], 7);
    }

    #[test]
    fn fixed_interval_no_overlap() {
        // Two fixed intervals on one machine; NoOverlap forces serial scheduling.
        let req = CpSatRequest {
            id: "iv".into(),
            variables: vec![
                var("s1", 0, 100),
                var("e1", 0, 100),
                var("s2", 0, 100),
                var("e2", 0, 100),
            ],
            interval_vars: vec![
                IntervalVarDef {
                    name: "iv1".into(),
                    start_var: "s1".into(),
                    duration: 5,
                    end_var: "e1".into(),
                },
                IntervalVarDef {
                    name: "iv2".into(),
                    start_var: "s2".into(),
                    duration: 7,
                    end_var: "e2".into(),
                },
            ],
            optional_interval_vars: vec![],
            constraints: vec![ConstraintKind::NoOverlap {
                intervals: vec!["iv1".into(), "iv2".into()],
            }],
            objective_terms: Some(vec![term("e2", 1)]),
            minimize: true,
            time_limit_seconds: Some(2.0),
        };
        let plan = solve_cp(&req);
        assert_eq!(plan.status, "optimal");
        // Minimising e2 alone: iv2 schedules first (0..7), iv1 after (7..12). e2 = 7.
        assert_eq!(plan.objective_value, Some(7));
        let map: HashMap<_, _> = plan.assignments.iter().cloned().collect();
        // Both intervals must be scheduled and non-overlapping.
        let (s1, e1, s2, e2) = (map["s1"], map["e1"], map["s2"], map["e2"]);
        assert_eq!(e1 - s1, 5);
        assert_eq!(e2 - s2, 7);
        assert!(e1 <= s2 || e2 <= s1, "intervals must not overlap");
    }

    #[test]
    fn optional_interval_uses_lit() {
        // Bool literal toggles whether the interval is active.
        let req = CpSatRequest {
            id: "ov".into(),
            variables: vec![bool_var("lit"), var("s", 0, 10), var("e", 0, 10)],
            interval_vars: vec![],
            optional_interval_vars: vec![OptionalIntervalVarDef {
                name: "ov1".into(),
                start_var: "s".into(),
                duration: 3,
                end_var: "e".into(),
                lit_var: "lit".into(),
            }],
            constraints: vec![],
            objective_terms: Some(vec![term("lit", 1)]),
            minimize: false,
            time_limit_seconds: Some(1.0),
        };
        let plan = solve_cp(&req);
        assert!(matches!(plan.status.as_str(), "optimal" | "feasible"));
    }

    #[test]
    fn ignores_unknown_var_references() {
        // interval_var references unknown start/end → warning, no panic.
        let req = CpSatRequest {
            id: "u".into(),
            variables: vec![var("s", 0, 10)],
            interval_vars: vec![IntervalVarDef {
                name: "iv".into(),
                start_var: "missing-start".into(),
                duration: 3,
                end_var: "missing-end".into(),
            }],
            optional_interval_vars: vec![OptionalIntervalVarDef {
                name: "ov".into(),
                start_var: "s".into(),
                duration: 3,
                end_var: "missing-end".into(),
                lit_var: "missing-lit".into(),
            }],
            constraints: vec![],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(0.5),
        };
        let plan = solve_cp(&req);
        // Solver still runs on the orphan var; no panic.
        assert!(matches!(
            plan.status.as_str(),
            "optimal" | "feasible" | "error"
        ));
    }

    #[test]
    fn no_objective_yields_no_objective_value() {
        let req = CpSatRequest {
            id: "nobj".into(),
            variables: vec![var("x", 0, 5)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(0.5),
        };
        let plan = solve_cp(&req);
        assert!(matches!(plan.status.as_str(), "optimal" | "feasible"));
        assert!(plan.objective_value.is_none());
    }

    #[tokio::test]
    async fn suggestor_emits_proposal() {
        let req = CpSatRequest {
            id: "s1".into(),
            variables: vec![var("x", 0, 5)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(0.5),
        };
        let body = serde_json::to_string(&req).unwrap();
        let ctx = MockContext::empty().with_seed("cpsat-request:s1", &body);
        let s = CpSatSuggestor;
        assert_eq!(s.name(), "CpSatSuggestor");
        assert_eq!(s.dependencies(), &[ContextKey::Seeds]);
        assert!(s.complexity_hint().is_some());
        assert!(s.accepts(&ctx));
        let eff = s.execute(&ctx).await;
        assert_eq!(eff.proposals().len(), 1);
    }

    #[tokio::test]
    async fn suggestor_skips_when_plan_present() {
        let req = CpSatRequest {
            id: "s2".into(),
            variables: vec![var("x", 0, 5)],
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints: vec![],
            objective_terms: None,
            minimize: false,
            time_limit_seconds: Some(0.5),
        };
        let body = serde_json::to_string(&req).unwrap();
        let ctx = MockContext::empty()
            .with_seed("cpsat-request:s2", &body)
            .with_strategy("cpsat-plan:s2", "{}");
        let s = CpSatSuggestor;
        assert!(!s.accepts(&ctx));
        let eff = s.execute(&ctx).await;
        assert_eq!(eff.proposals().len(), 0);
    }

    #[tokio::test]
    async fn suggestor_handles_malformed_seed() {
        let ctx = MockContext::empty().with_seed("cpsat-request:bad", "not json");
        let s = CpSatSuggestor;
        let eff = s.execute(&ctx).await;
        assert_eq!(eff.proposals().len(), 0);
    }

    /// Stress: 30-second budget on a hard 2D bin-packing-style assignment.
    /// 500 boolean items Ɨ 8 capacity rows with correlated coefficients —
    /// CP-SAT cannot prune via LP relaxation, so it explores the full tree.
    /// Designed to actually consume the 30 s budget.
    #[test]
    fn stress_30s_correlated_multi_knapsack() {
        let n: usize = 500;
        let bins: usize = 8;
        let mut state: u64 = 0xC0FFEE_BADCAFE;
        let step = |s: &mut u64| -> u64 {
            *s = s.wrapping_mul(6_364_136_223_846_793_005).wrapping_add(1);
            *s
        };
        // Strongly-correlated knapsack: value = weight + small constant — defeats
        // greedy/LP-relax bounds and forces deep CP-SAT search.
        let weights: Vec<i64> = (0..n)
            .map(|_| ((step(&mut state) >> 33) & 0xFF) as i64 + 50)
            .collect();
        let values: Vec<i64> = weights.iter().map(|&w| w + 10).collect();

        let variables: Vec<CpVariable> = (0..n).map(|i| bool_var(&format!("x{i}"))).collect();
        let mut constraints: Vec<ConstraintKind> = Vec::new();
        let total: i64 = weights.iter().sum();
        for b in 0..bins {
            // Per-bin capacity covers ~1/bins of the items but with overlapping
            // rotated weight subsets, creating cross-bin contention.
            let cap = total / (bins as i64) - 5;
            let terms: Vec<CpTerm> = (0..n)
                .map(|i| {
                    let w = weights[(i + b * 17) % n];
                    term(&format!("x{i}"), w)
                })
                .collect();
            constraints.push(ConstraintKind::LinearLe { terms, rhs: cap });
        }

        let obj: Vec<CpTerm> = (0..n).map(|i| term(&format!("x{i}"), values[i])).collect();

        let req = CpSatRequest {
            id: "stress".into(),
            variables,
            interval_vars: vec![],
            optional_interval_vars: vec![],
            constraints,
            objective_terms: Some(obj),
            minimize: false,
            time_limit_seconds: Some(30.0),
        };
        let started = std::time::Instant::now();
        let plan = solve_cp(&req);
        let elapsed = started.elapsed().as_secs_f64();
        assert!(
            matches!(plan.status.as_str(), "optimal" | "feasible"),
            "stress should yield a feasible solution, got {} in {elapsed:.1}s",
            plan.status
        );
        assert_eq!(plan.assignments.len(), n);
        assert!(plan.objective_value.unwrap() > 0);
    }
}