contextdb-server 0.3.2

Sync server for contextdb — NATS-based replication with conflict resolution
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
use contextdb_engine::Database;
use contextdb_engine::sync_types::{ConflictPolicies, ConflictPolicy};
use contextdb_server::protocol::{MessageType, PushResponse, WireApplyResult, encode};
use contextdb_server::{SyncClient, SyncServer};
use std::collections::HashMap;
use std::sync::Arc;
use testcontainers::core::{IntoContainerPort, Mount, WaitFor};
use testcontainers::runners::AsyncRunner;
use testcontainers::{ContainerAsync, GenericImage, ImageExt};

struct NatsFixture {
    _container: ContainerAsync<GenericImage>,
    nats_url: String,
    ws_url: String,
}

async fn start_nats() -> NatsFixture {
    let nats_conf = format!("{}/tests/nats.conf", env!("CARGO_MANIFEST_DIR"));

    let image = GenericImage::new("nats", "latest")
        .with_exposed_port(4222.tcp())
        .with_exposed_port(9222.tcp())
        .with_wait_for(WaitFor::message_on_stderr("Server is ready"));

    let request = image
        .with_mount(Mount::bind_mount(nats_conf, "/etc/nats/nats.conf"))
        .with_cmd(["--js", "--config", "/etc/nats/nats.conf"]);

    let container: ContainerAsync<GenericImage> = request.start().await.unwrap();

    let nats_port = container.get_host_port_ipv4(4222.tcp()).await.unwrap();
    let ws_port = container.get_host_port_ipv4(9222.tcp()).await.unwrap();

    NatsFixture {
        _container: container,
        nats_url: format!("nats://127.0.0.1:{nats_port}"),
        ws_url: format!("ws://127.0.0.1:{ws_port}"),
    }
}

struct RestrictedNatsFixture {
    _container: ContainerAsync<GenericImage>,
    _config_dir: tempfile::TempDir,
    nats_url: String,
}

async fn start_restricted_nats() -> RestrictedNatsFixture {
    let config_dir = tempfile::TempDir::new().unwrap();
    let nats_conf = config_dir.path().join("nats.conf");
    std::fs::write(
        &nats_conf,
        r#"
max_payload: 1048576

authorization {
  users = [
    {
      user: "sync"
      password: "sync"
      permissions: {
        subscribe: {
          deny: ["sync.>"]
        }
      }
    }
  ]
}

websocket {
  port: 9222
  no_tls: true
}
"#,
    )
    .unwrap();

    let image = GenericImage::new("nats", "latest")
        .with_exposed_port(4222.tcp())
        .with_exposed_port(9222.tcp())
        .with_wait_for(WaitFor::message_on_stderr("Server is ready"));

    let request = image
        .with_mount(Mount::bind_mount(
            nats_conf.to_string_lossy().into_owned(),
            "/etc/nats/nats.conf",
        ))
        .with_cmd(["--js", "--config", "/etc/nats/nats.conf"]);

    let container: ContainerAsync<GenericImage> = request.start().await.unwrap();
    let nats_port = container.get_host_port_ipv4(4222.tcp()).await.unwrap();

    RestrictedNatsFixture {
        _container: container,
        _config_dir: config_dir,
        nats_url: format!("nats://sync:sync@127.0.0.1:{nats_port}"),
    }
}

#[tokio::test]
async fn sync_round_trip_smoke() {
    let nats = start_nats().await;
    let edge = Arc::new(Database::open_memory());
    let server_db = Arc::new(Database::open_memory());
    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db,
        &nats.nats_url,
        "test_tenant",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });

    let client = SyncClient::new(edge, &nats.nats_url, "test_tenant");
    let _ = client.pull(&policies).await;
}

#[tokio::test]
async fn sync_00b_push_retries_malformed_reply_before_succeeding() {
    use contextdb_core::Value;
    use futures_util::StreamExt;
    use uuid::Uuid;

    let nats = start_nats().await;
    let edge = Arc::new(Database::open_memory());
    let empty = HashMap::new();
    edge.execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let responder = async_nats::connect(&nats.nats_url).await.unwrap();
    let mut sub = responder
        .subscribe(contextdb_server::subjects::push_subject("malformed-reply"))
        .await
        .unwrap();

    tokio::spawn(async move {
        let mut attempt = 0u32;
        while let Some(msg) = sub.next().await {
            attempt += 1;
            if let Some(reply) = msg.reply {
                let payload = if attempt == 1 {
                    vec![0x91]
                } else {
                    encode(
                        MessageType::PushResponse,
                        &PushResponse {
                            result: Some(WireApplyResult {
                                applied_rows: 1,
                                skipped_rows: 0,
                                conflicts: Vec::new(),
                                new_lsn: 2,
                            }),
                            error: None,
                        },
                    )
                    .unwrap()
                };
                responder.publish(reply, payload.into()).await.unwrap();
                if attempt >= 2 {
                    break;
                }
            }
        }
    });

    let client = SyncClient::new(edge.clone(), &nats.nats_url, "malformed-reply");
    let id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(id));
    p.insert("v".to_string(), Value::Text("retry".into()));
    edge.execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let result = client
        .push()
        .await
        .expect("push should retry malformed reply");
    assert_eq!(result.applied_rows, 1);
    assert!(client.push_watermark() > 0, "push watermark should advance");
}

/// I connected the sync server to a NATS account that denies its sync subscriptions,
/// and the server task stayed alive instead of panicking during bootstrap.
#[tokio::test]
async fn sync_00_server_bootstrap_survives_permission_denied_subscribe() {
    let nats = start_restricted_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db,
        &nats.nats_url,
        "bootstrap-denied",
        policies,
    ));
    let server_handle = server.clone();
    let handle = tokio::spawn(async move { server_handle.run().await });

    for _ in 0..10 {
        if handle.is_finished() {
            panic!("sync server finished early while bootstrap subscriptions were denied");
        }
        tokio::time::sleep(std::time::Duration::from_millis(50)).await;
    }

    handle.abort();
    let _ = handle.await;
}

// A1: Lazy connection and reuse
#[tokio::test]
async fn a1_lazy_connection_and_reuse() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let edge_db = Arc::new(Database::open_memory());
    let server_db = Arc::new(Database::open_memory());
    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);

    // Create table on both databases
    let empty = HashMap::new();
    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "reuse-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "reuse-test");

    // Before any call, should not be connected (lazy)
    assert!(
        !client.is_connected().await,
        "client must not be connected before first call"
    );

    // Push to trigger connection
    client.push().await.unwrap();

    // After push, should be connected (stored in Mutex)
    assert!(
        client.is_connected().await,
        "client must be connected after push (lazy connect + store)"
    );

    // Insert data and push again — reuses stored connection
    let id = Uuid::new_v4();
    let mut params = HashMap::new();
    params.insert("id".to_string(), Value::Uuid(id));
    params.insert("v".to_string(), Value::Text("hello".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &params)
        .unwrap();

    let result = client.push().await.unwrap();
    assert!(
        result.applied_rows > 0,
        "data must be delivered via reused connection"
    );

    // Verify server has the row
    let server_row = server_db
        .point_lookup("t", "id", &Value::Uuid(id), server_db.snapshot())
        .unwrap();
    assert!(
        server_row.is_some(),
        "server must have the row pushed by edge"
    );
}

// A2: Connection failure produces actionable error
#[tokio::test]
async fn a2_connection_failure_actionable_error() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let db = Arc::new(Database::open_memory());
    let empty = HashMap::new();
    db.execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    // Insert a row so changeset is non-empty
    let id = Uuid::new_v4();
    let mut params = HashMap::new();
    params.insert("id".to_string(), Value::Uuid(id));
    params.insert("v".to_string(), Value::Text("data".into()));
    db.execute("INSERT INTO t (id, v) VALUES ($id, $v)", &params)
        .unwrap();

    // Client pointing to unreachable port
    let client = SyncClient::new(db, "nats://localhost:19999", "no-server-registered");
    let result = client.push().await;

    assert!(result.is_err(), "push to unreachable NATS must fail");
    let err_msg = result.unwrap_err().to_string();
    assert!(
        err_msg.contains("19999"),
        "error must contain the NATS port '19999', got: {}",
        err_msg
    );
}

// A3: pull_default() uses runtime-configured policies
#[tokio::test]
async fn a3_pull_default_uses_configured_policies() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    // Create table on both
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    // Same PK, different values — conflict
    let id = Uuid::new_v4();
    let mut server_params = HashMap::new();
    server_params.insert("id".to_string(), Value::Uuid(id));
    server_params.insert("v".to_string(), Value::Text("server-value".into()));
    server_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &server_params)
        .unwrap();

    let mut edge_params = HashMap::new();
    edge_params.insert("id".to_string(), Value::Uuid(id));
    edge_params.insert("v".to_string(), Value::Text("edge-value".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &edge_params)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::ServerWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "pull-default-test",
        policies,
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "pull-default-test");

    // Configure EdgeWins — edge value should survive
    client.set_default_conflict_policy(ConflictPolicy::EdgeWins);
    client.pull_default().await.unwrap();

    // If pull_default hardcoded ServerWins, edge value would be overwritten
    let row = edge_db
        .point_lookup("t", "id", &Value::Uuid(id), edge_db.snapshot())
        .unwrap()
        .expect("row must exist after pull");
    let v = row.values.get("v").expect("column v must exist");
    assert_eq!(
        v,
        &Value::Text("edge-value".into()),
        "EdgeWins should keep edge value; if 'server-value', pull_default used hardcoded ServerWins"
    );
}

// A4: set_table_direction() blocks data on pull
#[tokio::test]
async fn a4_set_table_direction_blocks_pull() {
    use contextdb_core::Value;
    use contextdb_engine::sync_types::SyncDirection;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    // Create two tables on server
    server_db
        .execute("CREATE TABLE synced (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE blocked (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    // Insert data in both tables on server
    let synced_id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(synced_id));
    p.insert("v".to_string(), Value::Text("synced-data".into()));
    server_db
        .execute("INSERT INTO synced (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let blocked_id = Uuid::new_v4();
    let mut p2 = HashMap::new();
    p2.insert("id".to_string(), Value::Uuid(blocked_id));
    p2.insert("v".to_string(), Value::Text("blocked-data".into()));
    server_db
        .execute("INSERT INTO blocked (id, v) VALUES ($id, $v)", &p2)
        .unwrap();

    // Create tables on edge too
    edge_db
        .execute("CREATE TABLE synced (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    edge_db
        .execute("CREATE TABLE blocked (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "direction-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "direction-test");

    // Block the "blocked" table
    client.set_table_direction("blocked", SyncDirection::None);
    client.pull(&policies).await.unwrap();

    // "synced" row should appear on edge
    let synced_row = edge_db
        .point_lookup("synced", "id", &Value::Uuid(synced_id), edge_db.snapshot())
        .unwrap();
    assert!(
        synced_row.is_some(),
        "synced table row must appear on edge (default=Both)"
    );

    // "blocked" row should NOT appear on edge
    let blocked_rows = edge_db
        .scan_filter("blocked", edge_db.snapshot(), &|_| true)
        .unwrap();
    assert_eq!(
        blocked_rows.len(),
        0,
        "blocked table must have 0 rows on edge (direction=None). If >0, set_table_direction is a no-op"
    );
}

// A5: WebSocket transport
#[tokio::test]
async fn a5_websocket_transport() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "ws-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    // Edge connects via WebSocket
    let client = SyncClient::new(edge_db.clone(), &nats.ws_url, "ws-test");

    // Edge pushes a row over WebSocket
    let push_id = Uuid::new_v4();
    let mut params = HashMap::new();
    params.insert("id".to_string(), Value::Uuid(push_id));
    params.insert("v".to_string(), Value::Text("ws-push".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &params)
        .unwrap();
    client.push().await.unwrap();

    // Verify server received it
    let server_row = server_db
        .point_lookup("t", "id", &Value::Uuid(push_id), server_db.snapshot())
        .unwrap();
    assert!(
        server_row.is_some(),
        "server must receive row pushed via WebSocket"
    );

    // Server inserts a row, edge pulls over WebSocket
    let pull_id = Uuid::new_v4();
    let mut params2 = HashMap::new();
    params2.insert("id".to_string(), Value::Uuid(pull_id));
    params2.insert("v".to_string(), Value::Text("ws-pull".into()));
    server_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &params2)
        .unwrap();

    client.pull(&policies).await.unwrap();

    let edge_row = edge_db
        .point_lookup("t", "id", &Value::Uuid(pull_id), edge_db.snapshot())
        .unwrap();
    assert!(
        edge_row.is_some(),
        "edge must receive row pulled via WebSocket"
    );
}

// A6: reconnect() clears stored connection and re-establishes
#[tokio::test]
async fn a6_reconnect_clears_and_reestablishes() {
    let nats = start_nats().await;
    let edge_db = Arc::new(Database::open_memory());
    let server_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "reconnect-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    // Success path
    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "reconnect-test");
    client.push().await.unwrap(); // establishes connection
    assert!(client.is_connected().await, "must be connected after push");
    client.reconnect().await; // drops and re-establishes
    assert!(
        client.is_connected().await,
        "must be connected after reconnect to valid server"
    );
    client.push().await.unwrap(); // still works

    // Failure path: bad port
    let bad_db = Arc::new(Database::open_memory());
    let bad_client = SyncClient::new(bad_db, "nats://localhost:19999", "bad-port");
    bad_client.reconnect().await;
    assert!(
        !bad_client.is_connected().await,
        "reconnect to unreachable port must leave client disconnected"
    );
}

// A7: set_conflict_policy() per-table overrides default on pull
#[tokio::test]
async fn a7_per_table_conflict_policy_override() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    // Create two tables on both
    for db in [&server_db, &edge_db] {
        db.execute(
            "CREATE TABLE observations (id UUID PRIMARY KEY, v TEXT)",
            &empty,
        )
        .unwrap();
        db.execute(
            "CREATE TABLE decisions (id UUID PRIMARY KEY, v TEXT)",
            &empty,
        )
        .unwrap();
    }

    // Same PKs, different values — conflicts on both tables
    let obs_id = Uuid::new_v4();
    let dec_id = Uuid::new_v4();

    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(obs_id));
    p.insert("v".to_string(), Value::Text("server-obs".into()));
    server_db
        .execute("INSERT INTO observations (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(dec_id));
    p.insert("v".to_string(), Value::Text("server-dec".into()));
    server_db
        .execute("INSERT INTO decisions (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(obs_id));
    p.insert("v".to_string(), Value::Text("edge-obs".into()));
    edge_db
        .execute("INSERT INTO observations (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(dec_id));
    p.insert("v".to_string(), Value::Text("edge-dec".into()));
    edge_db
        .execute("INSERT INTO decisions (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::ServerWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "policy-override-test",
        policies,
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "policy-override-test");

    // Default = ServerWins, but observations = InsertIfNotExists (skip duplicates)
    client.set_default_conflict_policy(ConflictPolicy::ServerWins);
    client.set_conflict_policy("observations", ConflictPolicy::InsertIfNotExists);
    client.pull_default().await.unwrap();

    // Observations: InsertIfNotExists → edge value survives
    let obs_row = edge_db
        .point_lookup(
            "observations",
            "id",
            &Value::Uuid(obs_id),
            edge_db.snapshot(),
        )
        .unwrap()
        .expect("observation row must exist");
    let obs_v = obs_row.values.get("v").expect("column v must exist");
    assert_eq!(
        obs_v,
        &Value::Text("edge-obs".into()),
        "InsertIfNotExists should keep edge observation value"
    );

    // Decisions: ServerWins → server value overwrites
    let dec_row = edge_db
        .point_lookup("decisions", "id", &Value::Uuid(dec_id), edge_db.snapshot())
        .unwrap()
        .expect("decision row must exist");
    let dec_v = dec_row.values.get("v").expect("column v must exist");
    assert_eq!(
        dec_v,
        &Value::Text("server-dec".into()),
        "ServerWins should overwrite edge decision with server value"
    );
}

// A8: Pull watermark advances after successful pull
#[tokio::test]
async fn a8_pull_watermark_advances() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    // Insert 5 rows on server
    for i in 0..5 {
        let id = Uuid::new_v4();
        let mut p = HashMap::new();
        p.insert("id".to_string(), Value::Uuid(id));
        p.insert("v".to_string(), Value::Text(format!("row_{}", i)));
        server_db
            .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
            .unwrap();
    }

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "pull-wm-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "pull-wm-test");

    // First pull — gets 5 rows
    let result1 = client.pull(&policies).await.unwrap();
    assert_eq!(result1.applied_rows, 5, "first pull must apply 5 rows");
    assert_eq!(result1.skipped_rows, 0, "first pull must skip 0 rows");
    assert!(
        client.pull_watermark() > 0,
        "pull watermark must advance after first pull"
    );
    let prev_watermark = client.pull_watermark();

    // Insert 1 more row on server
    let id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(id));
    p.insert("v".to_string(), Value::Text("new-row".into()));
    server_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    // Second pull — should only get 1 new row
    let result2 = client.pull(&policies).await.unwrap();
    assert_eq!(result2.applied_rows, 1, "second pull must apply 1 row");
    assert_eq!(
        result2.skipped_rows, 0,
        "second pull must skip 0 rows — if >0, since_lsn is hardcoded to 0"
    );
    assert!(
        client.pull_watermark() > prev_watermark,
        "pull watermark must advance after second pull"
    );
}

// A9: RowDelete events are synced
#[tokio::test]
async fn a9_row_delete_events_synced() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::EdgeWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "rowdelete-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "rowdelete-test");

    // Insert row on edge and push to server
    let id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(id));
    p.insert("v".to_string(), Value::Text("exists".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();
    client.push().await.unwrap();

    // Verify server has the row
    let server_row = server_db
        .point_lookup("t", "id", &Value::Uuid(id), server_db.snapshot())
        .unwrap();
    assert!(
        server_row.is_some(),
        "server must have the row after initial push"
    );

    // Delete on edge
    let mut dp = HashMap::new();
    dp.insert("id".to_string(), Value::Uuid(id));
    edge_db
        .execute("DELETE FROM t WHERE id = $id", &dp)
        .unwrap();

    // Push the delete
    client.push().await.unwrap();

    // Server must reflect the delete
    let server_row_after = server_db
        .point_lookup("t", "id", &Value::Uuid(id), server_db.snapshot())
        .unwrap();
    assert!(
        server_row_after.is_none(),
        "server must NOT have the row after delete push. If still present, RowDelete is not emitted by changes_since()"
    );
}

#[tokio::test]
async fn a9_file_backed_row_delete_events_synced() {
    use contextdb_core::Value;
    use tempfile::TempDir;
    use uuid::Uuid;

    let tmp = TempDir::new().unwrap();
    let server_path = tmp.path().join("server.db");
    let edge_path = tmp.path().join("edge.db");
    let nats = start_nats().await;
    let server_db = Arc::new(Database::open(&server_path).unwrap());
    let edge_db = Arc::new(Database::open(&edge_path).unwrap());
    let empty = HashMap::new();

    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::EdgeWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "rowdelete-file-test",
        policies,
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "rowdelete-file-test");

    let id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(id));
    p.insert("v".to_string(), Value::Text("exists".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();
    client.push().await.unwrap();

    let mut dp = HashMap::new();
    dp.insert("id".to_string(), Value::Uuid(id));
    edge_db
        .execute("DELETE FROM t WHERE id = $id", &dp)
        .unwrap();
    client.push().await.unwrap();

    let server_row_after = server_db
        .point_lookup("t", "id", &Value::Uuid(id), server_db.snapshot())
        .unwrap();
    assert!(
        server_row_after.is_none(),
        "server must NOT have the row after file-backed delete push"
    );
}

// Fresh pull after insert+delete history must converge to the net state without conflicts.
#[tokio::test]
async fn a9_fresh_pull_after_delete_history_converges_without_conflict() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_a_db = Arc::new(Database::open_memory());
    let edge_b_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    for db in [&server_db, &edge_a_db, &edge_b_db] {
        db.execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
            .unwrap();
    }

    let policies = ConflictPolicies::uniform(ConflictPolicy::ServerWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "fresh-delete-history",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let edge_a = SyncClient::new(edge_a_db.clone(), &nats.nats_url, "fresh-delete-history");
    let edge_b = SyncClient::new(edge_b_db.clone(), &nats.nats_url, "fresh-delete-history");

    let keep_id = Uuid::new_v4();
    let delete_id = Uuid::new_v4();
    for (id, value) in [(keep_id, "keep"), (delete_id, "delete-me")] {
        let mut p = HashMap::new();
        p.insert("id".to_string(), Value::Uuid(id));
        p.insert("v".to_string(), Value::Text(value.into()));
        edge_a_db
            .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
            .unwrap();
    }
    edge_a.push().await.unwrap();

    let mut delete_params = HashMap::new();
    delete_params.insert("id".to_string(), Value::Uuid(delete_id));
    edge_a_db
        .execute("DELETE FROM t WHERE id = $id", &delete_params)
        .unwrap();
    edge_a.push().await.unwrap();

    let pull = edge_b.pull_default().await.unwrap();
    assert!(
        pull.conflicts.is_empty(),
        "fresh pull over insert+delete history must not report conflicts: {:?}",
        pull.conflicts
    );

    let rows = edge_b_db.scan("t", edge_b_db.snapshot()).unwrap();
    assert_eq!(rows.len(), 1, "fresh pull must converge to net row count");
    assert_eq!(
        rows[0].values.get("id"),
        Some(&Value::Uuid(keep_id)),
        "deleted row must not remain after fresh pull"
    );
}

#[tokio::test]
async fn a9_file_backed_fresh_pull_after_delete_history_converges_without_conflict() {
    use contextdb_core::Value;
    use tempfile::TempDir;
    use uuid::Uuid;

    let tmp = TempDir::new().unwrap();
    let server_path = tmp.path().join("server.db");
    let edge_a_path = tmp.path().join("edge-a.db");
    let edge_b_path = tmp.path().join("edge-b.db");
    let nats = start_nats().await;
    let server_db = Arc::new(Database::open(&server_path).unwrap());
    let edge_a_db = Arc::new(Database::open(&edge_a_path).unwrap());
    let edge_b_db = Arc::new(Database::open(&edge_b_path).unwrap());
    let empty = HashMap::new();

    for db in [&server_db, &edge_a_db, &edge_b_db] {
        db.execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
            .unwrap();
    }

    let policies = ConflictPolicies::uniform(ConflictPolicy::ServerWins);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "file-fresh-delete-history",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let edge_a = SyncClient::new(
        edge_a_db.clone(),
        &nats.nats_url,
        "file-fresh-delete-history",
    );
    let edge_b = SyncClient::new(
        edge_b_db.clone(),
        &nats.nats_url,
        "file-fresh-delete-history",
    );

    let keep_id = Uuid::new_v4();
    let delete_id = Uuid::new_v4();
    for (id, value) in [(keep_id, "keep"), (delete_id, "delete-me")] {
        let mut p = HashMap::new();
        p.insert("id".to_string(), Value::Uuid(id));
        p.insert("v".to_string(), Value::Text(value.into()));
        edge_a_db
            .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
            .unwrap();
    }
    edge_a.push().await.unwrap();

    let mut delete_params = HashMap::new();
    delete_params.insert("id".to_string(), Value::Uuid(delete_id));
    edge_a_db
        .execute("DELETE FROM t WHERE id = $id", &delete_params)
        .unwrap();
    edge_a.push().await.unwrap();

    let pull = edge_b.pull_default().await.unwrap();
    assert!(
        pull.conflicts.is_empty(),
        "file-backed fresh pull over insert+delete history must not report conflicts: {:?}",
        pull.conflicts
    );

    let rows = edge_b_db.scan("t", edge_b_db.snapshot()).unwrap();
    assert_eq!(rows.len(), 1, "fresh pull must converge to net row count");
    assert_eq!(
        rows[0].values.get("id"),
        Some(&Value::Uuid(keep_id)),
        "deleted row must not remain after fresh pull"
    );
}

// A10: Vector mapping survives failed row inserts (exact test code from plan)
#[tokio::test]
async fn a10_vector_mapping_survives_failed_inserts() {
    use contextdb_core::Value;
    use contextdb_engine::sync_types::*;
    use std::collections::HashMap;
    use uuid::Uuid;

    let server_db = Arc::new(Database::open_memory());

    // Create STATE MACHINE table: draft -> [active], active -> [done]
    let empty = HashMap::new();
    server_db
        .execute(
            "CREATE TABLE t (id UUID PRIMARY KEY, status TEXT, embedding VECTOR(3)) \
         STATE MACHINE (status: draft -> [active], active -> [done])",
            &empty,
        )
        .unwrap();

    // Pre-insert row B on server with status='active'
    let uuid_b = Uuid::new_v4();
    let mut params_b = HashMap::new();
    params_b.insert("id".to_string(), Value::Uuid(uuid_b));
    params_b.insert("status".to_string(), Value::Text("active".into()));
    server_db
        .execute(
            "INSERT INTO t (id, status) VALUES ($id, $status)",
            &params_b,
        )
        .unwrap();

    // Build ChangeSet manually: 3 rows + 3 vectors
    let uuid_a = Uuid::new_v4();
    let uuid_c = Uuid::new_v4();

    let edge_row_a: u64 = u64::MAX - 2;
    let edge_row_b: u64 = u64::MAX - 1;
    let edge_row_c: u64 = u64::MAX;

    let changeset = ChangeSet {
        rows: vec![
            RowChange {
                table: "t".to_string(),
                natural_key: NaturalKey {
                    column: "id".to_string(),
                    value: Value::Uuid(uuid_a),
                },
                values: {
                    let mut v = HashMap::new();
                    v.insert("id".to_string(), Value::Uuid(uuid_a));
                    v.insert("status".to_string(), Value::Text("draft".into()));
                    v.insert("embedding".to_string(), Value::Vector(vec![1.0, 0.0, 0.0]));
                    v
                },
                deleted: false,
                lsn: 10,
            },
            RowChange {
                table: "t".to_string(),
                natural_key: NaturalKey {
                    column: "id".to_string(),
                    value: Value::Uuid(uuid_b),
                },
                values: {
                    let mut v = HashMap::new();
                    v.insert("id".to_string(), Value::Uuid(uuid_b));
                    // INVALID: server has status='active', transitioning to 'draft' is not allowed
                    v.insert("status".to_string(), Value::Text("draft".into()));
                    v.insert("embedding".to_string(), Value::Vector(vec![0.0, 1.0, 0.0]));
                    v
                },
                deleted: false,
                lsn: 11,
            },
            RowChange {
                table: "t".to_string(),
                natural_key: NaturalKey {
                    column: "id".to_string(),
                    value: Value::Uuid(uuid_c),
                },
                values: {
                    let mut v = HashMap::new();
                    v.insert("id".to_string(), Value::Uuid(uuid_c));
                    v.insert("status".to_string(), Value::Text("draft".into()));
                    v.insert("embedding".to_string(), Value::Vector(vec![0.0, 0.0, 1.0]));
                    v
                },
                deleted: false,
                lsn: 12,
            },
        ],
        edges: Vec::new(),
        vectors: vec![
            VectorChange {
                row_id: edge_row_a,
                vector: vec![1.0, 0.0, 0.0],
                lsn: 10,
            },
            VectorChange {
                row_id: edge_row_b,
                vector: vec![0.0, 1.0, 0.0],
                lsn: 11,
            },
            VectorChange {
                row_id: edge_row_c,
                vector: vec![0.0, 0.0, 1.0],
                lsn: 12,
            },
        ],
        ddl: Vec::new(),
    };

    // EdgeWins forces upsert attempt on row B — which fails due to state machine
    let policies = ConflictPolicies {
        per_table: HashMap::new(),
        default: ConflictPolicy::EdgeWins,
    };
    let result = server_db.apply_changes(changeset, &policies).unwrap();

    // Row A and C applied, row B failed (state machine violation)
    assert_eq!(result.applied_rows, 2, "rows A and C should apply");
    assert_eq!(
        result.skipped_rows, 1,
        "row B should fail (invalid state transition)"
    );
    assert_eq!(result.conflicts.len(), 1, "one conflict from row B");

    // Verify row A's vector: search for [1.0, 0.0, 0.0] — must find with high similarity
    let search_a = server_db
        .query_vector(&[1.0, 0.0, 0.0], 1, None, server_db.snapshot())
        .unwrap();
    assert_eq!(search_a.len(), 1, "row A's vector must be findable");
    assert!(
        search_a[0].1 > 0.99,
        "row A's vector must have near-perfect cosine similarity, got {}",
        search_a[0].1
    );

    // KEY ASSERTION: Verify row C's vector is [0.0, 0.0, 1.0], NOT [0.0, 1.0, 0.0]
    let search_c = server_db
        .query_vector(&[0.0, 0.0, 1.0], 1, None, server_db.snapshot())
        .unwrap();
    assert_eq!(search_c.len(), 1, "row C's vector must be findable");
    assert!(
        search_c[0].1 > 0.99,
        "row C's vector must be [0.0, 0.0, 1.0] with near-perfect similarity, got {} \
         (if ~0.0, row C got row B's vector [0.0, 1.0, 0.0] due to vector_row_idx mismapping)",
        search_c[0].1
    );

    // Additional: verify [0.0, 1.0, 0.0] (row B's vector) is NOT attached to any row
    let search_b = server_db
        .query_vector(&[0.0, 1.0, 0.0], 1, None, server_db.snapshot())
        .unwrap();
    if !search_b.is_empty() {
        assert!(
            search_b[0].1 < 0.5,
            "row B's vector [0.0, 1.0, 0.0] should NOT be attached to any row with high similarity, \
             got {} — vector mismapping bug: B's vector landed on row C",
            search_b[0].1
        );
    }
}

// A11: Tenant ID with dots or wildcards is rejected
#[tokio::test]
async fn a11_tenant_id_validation() {
    use std::panic::{AssertUnwindSafe, catch_unwind};

    let db = Arc::new(Database::open_memory());

    // These must panic
    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncClient::new(db.clone(), "nats://x", "foo.bar")
    }));
    assert!(r.is_err(), "dot in tenant_id must panic");

    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncClient::new(db.clone(), "nats://x", "foo*")
    }));
    assert!(r.is_err(), "wildcard in tenant_id must panic");

    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncClient::new(db.clone(), "nats://x", "foo>")
    }));
    assert!(r.is_err(), "NATS multi-level wildcard must panic");

    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncClient::new(db.clone(), "nats://x", "")
    }));
    assert!(r.is_err(), "empty tenant_id must panic");

    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncClient::new(db.clone(), "nats://x", "foo bar")
    }));
    assert!(r.is_err(), "space in tenant_id must panic");

    // Same for SyncServer
    let policies = ConflictPolicies::uniform(ConflictPolicy::ServerWins);
    let r = catch_unwind(AssertUnwindSafe(|| {
        SyncServer::new(db.clone(), "nats://x", "foo.bar", policies.clone())
    }));
    assert!(r.is_err(), "SyncServer must also reject dots");

    // These must succeed (no panic)
    SyncClient::new(db.clone(), "nats://x", "valid-tenant");
    SyncClient::new(db.clone(), "nats://x", "tenant_123");
    SyncClient::new(db.clone(), "nats://x", "MyTenant");
}

// A12: NATS request timeout returns an error
#[tokio::test]
async fn a12_nats_request_timeout_returns_error() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let edge_db = Arc::new(Database::open_memory());
    let server_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let _server = SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "timeout-test",
        policies.clone(),
    );

    // Subscribe to push subject but never reply (simulating hung server)
    let nats_client = async_nats::connect(&nats.nats_url).await.unwrap();
    let _sub = nats_client
        .subscribe(contextdb_server::subjects::push_subject("timeout-test"))
        .await
        .unwrap();

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "timeout-test");

    // Insert data so push has something to send
    let id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(id));
    p.insert("v".to_string(), Value::Text("data".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    // Wrap in test-level timeout to prevent hanging in red state
    let result = tokio::time::timeout(std::time::Duration::from_secs(30), client.push()).await;

    match result {
        Ok(Err(_)) => {}
        Ok(Ok(_)) => panic!("push should have failed after NATS timeout with no fallback"),
        Err(_elapsed) => panic!("push hung — SYNC_TIMEOUT not firing"),
    }
}

// A13: Pull pagination fetches all pages (exact test code from plan)
#[tokio::test]
async fn a13_pull_pagination_fetches_all_pages() {
    use contextdb_core::Value;
    use contextdb_engine::sync_types::*;
    use std::collections::HashMap;
    use uuid::Uuid;

    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);

    // Create table on server and insert 1500 rows
    let empty = HashMap::new();
    server_db
        .execute(
            "CREATE TABLE t (id UUID PRIMARY KEY, data TEXT) IMMUTABLE",
            &empty,
        )
        .unwrap();

    // Insert 1500 rows via apply_changes (NOT execute) so all rows share ONE LSN.
    let mut rows = Vec::new();
    for i in 0..1500 {
        let id = Uuid::new_v4();
        let mut values = HashMap::new();
        values.insert("id".to_string(), Value::Uuid(id));
        values.insert("data".to_string(), Value::Text(format!("row_{}", i)));
        rows.push(RowChange {
            table: "t".to_string(),
            natural_key: NaturalKey {
                column: "id".to_string(),
                value: Value::Uuid(id),
            },
            values,
            deleted: false,
            lsn: 0,
        });
    }
    let changeset = ChangeSet {
        rows,
        edges: vec![],
        vectors: vec![],
        ddl: vec![],
    };
    let insert_policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    server_db
        .apply_changes(changeset, &insert_policies)
        .unwrap();

    // Start SyncServer on NATS
    let nats = start_nats().await;
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "pagination-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(500)).await;

    // Edge client connects via NATS (NOT local fallback)
    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "pagination-test");

    // Pull all data
    let result = client.pull(&policies).await.unwrap();

    // Verify NATS path was used, not local fallback
    assert!(
        client.is_connected().await,
        "NATS must be running for A13. local_pull does not paginate — \
         test is meaningless without NATS. Run: docker compose -f \
         crates/contextdb-server/tests/docker-compose.yml up -d"
    );

    // KEY ASSERTION: all 1500 rows must arrive, not just the first page
    assert_eq!(
        result.applied_rows, 1500,
        "all 1500 rows must arrive via pagination. Got {} — \
         if 500, the pagination loop is missing (stub behavior). \
         If 0, NATS connection failed (check docker-compose).",
        result.applied_rows
    );

    // Double-check: query edge_db directly
    let rows = edge_db
        .scan_filter("t", edge_db.snapshot(), &|_| true)
        .unwrap();
    assert_eq!(
        rows.len(),
        1500,
        "edge_db must have all 1500 rows after paginated pull"
    );

    assert_eq!(
        result.skipped_rows, 0,
        "no rows should be skipped on fresh edge"
    );
}

// A15: Concurrent push and pull on same client
#[tokio::test]
async fn a15_concurrent_push_and_pull() {
    use contextdb_core::Value;
    use uuid::Uuid;

    let nats = start_nats().await;
    let server_db = Arc::new(Database::open_memory());
    let edge_db = Arc::new(Database::open_memory());
    let empty = HashMap::new();

    // Create table on both
    server_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();
    edge_db
        .execute("CREATE TABLE t (id UUID PRIMARY KEY, v TEXT)", &empty)
        .unwrap();

    // Insert data on server (for pull to fetch)
    let server_id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(server_id));
    p.insert("v".to_string(), Value::Text("server-data".into()));
    server_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    let policies = ConflictPolicies::uniform(ConflictPolicy::InsertIfNotExists);
    let server = Arc::new(SyncServer::new(
        server_db.clone(),
        &nats.nats_url,
        "concurrent-client-test",
        policies.clone(),
    ));
    let server_handle = server.clone();
    tokio::spawn(async move { server_handle.run().await });
    tokio::time::sleep(std::time::Duration::from_millis(200)).await;

    let client = SyncClient::new(edge_db.clone(), &nats.nats_url, "concurrent-client-test");

    // Insert data on edge (for push to send)
    let edge_id = Uuid::new_v4();
    let mut p = HashMap::new();
    p.insert("id".to_string(), Value::Uuid(edge_id));
    p.insert("v".to_string(), Value::Text("edge-data".into()));
    edge_db
        .execute("INSERT INTO t (id, v) VALUES ($id, $v)", &p)
        .unwrap();

    // Run push and pull concurrently
    let (push_r, pull_r) = tokio::join!(client.push(), client.pull(&policies));

    assert!(push_r.is_ok(), "concurrent push must succeed");
    assert!(pull_r.is_ok(), "concurrent pull must succeed");
    assert!(
        client.push_watermark() > 0,
        "push watermark must be non-zero after concurrent ops"
    );
    assert!(
        client.pull_watermark() > 0,
        "pull watermark must be non-zero after concurrent ops"
    );
}