context-forge 0.6.2

//! Distillation: turning a raw conversation transcript into durable memory.
//!
//! This module defines the [`Distiller`] trait and the data types it
//! produces. The trait itself is always available (not feature-gated) so
//! that callers can implement their own distillers — for example, a remote
//! API client, a different local model runtime, or a test stub.
//!
//! The `OpenAiCompatDistiller` implementation in the `openai_compat`
//! submodule (behind the `distill-http` feature) talks to an
//! OpenAI-compatible chat completions endpoint such as Ollama or
//! llama-server. It is the only place in this crate that performs HTTP, and
//! only when that feature is enabled.

#[cfg(feature = "distill-http")]
pub mod openai_compat;

use std::collections::HashSet;
use std::fmt::Write as _;

use serde::{Deserialize, Serialize};

use crate::traits::Result;

/// The result of distilling a conversation transcript into durable memory.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct DistilledMemory {
    /// A summary of the conversation, intended to be under 150 words.
    pub summary: String,
    /// Individual facts worth remembering across future sessions.
    pub facts: Vec<Fact>,
}

/// A single distilled fact extracted from a transcript.
#[derive(Debug, Clone, Serialize, Deserialize)]
pub struct Fact {
    /// The category of this fact.
    pub kind: FactKind,
    /// One self-contained sentence describing the fact, understandable
    /// without the original transcript.
    pub text: String,
}

/// The category of a distilled [`Fact`].
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "lowercase")]
#[non_exhaustive]
pub enum FactKind {
    /// A decision that was made, and (ideally) why.
    Decision,
    /// A correction the user gave.
    Correction,
    /// A user preference.
    Preference,
    /// A state change ("X is now Y").
    State,
}

/// Maximum number of facts persisted from a single distillation. Excess
/// facts (untrusted model output) are dropped.
pub const MAX_FACTS: usize = 64;
/// Maximum character length of a single distilled fact's text. Longer text
/// is truncated on a `char` boundary.
pub const MAX_FACT_CHARS: usize = 2_048;
/// Maximum character length of a distilled summary. Longer text is
/// truncated on a `char` boundary.
pub const MAX_SUMMARY_CHARS: usize = 8_192;

/// Truncates `text` to at most `max_chars` Unicode scalar values, keeping
/// the beginning and dropping the tail. Truncation always lands on a `char`
/// boundary.
fn truncate_keep_start(text: &str, max_chars: usize) -> &str {
    match text.char_indices().nth(max_chars) {
        Some((byte_idx, _)) => &text[..byte_idx],
        None => text,
    }
}

/// Caps a [`DistilledMemory`] produced by an untrusted [`Distiller`] so that
/// it cannot persist unbounded data.
///
/// The summary is truncated to at most [`MAX_SUMMARY_CHARS`] characters, the
/// fact list is truncated to at most [`MAX_FACTS`] entries, and each
/// surviving fact's text is truncated to at most [`MAX_FACT_CHARS`]
/// characters. All truncation keeps the beginning of the text and is
/// silent: no error, no marker, no logging.
pub(crate) fn cap_distilled_memory(memory: DistilledMemory) -> DistilledMemory {
    let DistilledMemory { summary, mut facts } = memory;

    let summary = truncate_keep_start(&summary, MAX_SUMMARY_CHARS).to_owned();

    facts.truncate(MAX_FACTS);
    for fact in &mut facts {
        if fact.text.chars().count() > MAX_FACT_CHARS {
            fact.text = truncate_keep_start(&fact.text, MAX_FACT_CHARS).to_owned();
        }
    }

    DistilledMemory { summary, facts }
}

/// Reduces several [`DistilledMemory`] partial results — one per transcript
/// chunk — into a single [`DistilledMemory`].
///
/// Facts are concatenated in input order and deduplicated on
/// `(kind, normalized text)`, where normalization trims whitespace and
/// lowercases; the first occurrence of each duplicate is kept. Summaries are
/// joined with a blank line between them. The combined result is passed
/// through `cap_distilled_memory`, so the output is bounded the same way a
/// single distillation's output would be.
///
/// This is the pure, deterministic reduce: no model call, safe to call with
/// an empty `Vec` (returns an empty [`DistilledMemory`]) or a single-element
/// `Vec` (returns that element's content, capped).
#[must_use]
pub fn merge_distilled(parts: Vec<DistilledMemory>) -> DistilledMemory {
    let mut summaries = Vec::with_capacity(parts.len());
    let mut facts = Vec::new();
    let mut seen = HashSet::new();

    for part in parts {
        if !part.summary.is_empty() {
            summaries.push(part.summary);
        }
        for fact in part.facts {
            let key = (fact.kind, fact.text.trim().to_lowercase());
            if seen.insert(key) {
                // "insert into the seen-set, and only
                //keep this fact if that insert was new." One line does both the membership check and the recording
                facts.push(fact);
            }
        }
    }

    cap_distilled_memory(DistilledMemory {
        summary: summaries.join("\n\n"),
        facts,
    })
}

/// Splits `transcript` into chunks that each fit within `max_chars`.
///
/// Packing is line-aware: each chunk is filled with whole lines (a
/// transcript is one line per turn) up to `max_chars`, so a chunk only ever
/// cuts between turns, never mid-turn. A single line longer than
/// `max_chars` on its own is hard-split on `char` boundaries into one or
/// more chunks — this function is a strict size guarantee, not a hint, so
/// even a pathologically long line cannot produce an over-budget chunk.
///
/// `max_chars == 0` has no valid split (every chunk would have to be
/// empty), so it clamps to a single chunk containing the whole
/// `transcript` — the same behavior the crate had before chunking existed.
/// Debug builds panic via `debug_assert_ne!` so a misconfigured budget is
/// caught during development; release builds degrade silently, matching
/// `cap_distilled_memory`'s convention of never panicking on
/// untrusted/misconfigured input.
///
/// An empty `transcript` returns an empty `Vec` (zero chunks).
///
/// This is a pure, zero-copy split: the returned slices borrow from
/// `transcript`, and concatenating them in order reproduces `transcript`
/// exactly — no data is dropped, added, or copied.
#[must_use]
pub fn split_on_budget(transcript: &str, max_chars: usize) -> Vec<&str> {
    if transcript.is_empty() {
        return Vec::new();
    }

    if max_chars == 0 {
        debug_assert_ne!(
            max_chars, 0,
            "split_on_budget called with max_chars == 0; clamping to a single, unsplit chunk"
        );
        return vec![transcript];
    }

    let mut chunks = Vec::new();
    let mut chunk_start = 0usize;
    let mut consumed = 0usize;
    let mut chunk_chars = 0usize;

    for line in transcript.split_inclusive('\n') {
        let line_chars = line.chars().count();

        if line_chars > max_chars {
            if consumed > chunk_start {
                chunks.push(&transcript[chunk_start..consumed]);
            }
            chunks.extend(hard_split(line, max_chars));
            consumed += line.len();
            chunk_start = consumed;
            chunk_chars = 0;
            continue;
        }

        if chunk_chars + line_chars > max_chars && consumed > chunk_start {
            chunks.push(&transcript[chunk_start..consumed]);
            chunk_start = consumed;
            chunk_chars = 0;
        }

        consumed += line.len();
        chunk_chars += line_chars;
    }

    if consumed > chunk_start {
        chunks.push(&transcript[chunk_start..consumed]);
    }

    chunks
}

/// Hard-splits `line` into pieces of at most `max_chars` Unicode scalar
/// values each, on `char` boundaries. Used by [`split_on_budget`] when a
/// single line exceeds the chunk budget on its own.
fn hard_split(mut line: &str, max_chars: usize) -> Vec<&str> {
    let mut pieces = Vec::new();
    while !line.is_empty() {
        if let Some((byte_idx, _)) = line.char_indices().nth(max_chars) {
            pieces.push(&line[..byte_idx]);
            line = &line[byte_idx..];
        } else {
            pieces.push(line);
            break;
        }
    }
    pieces
}

/// Strategy used to reduce several partial [`DistilledMemory`] results —
/// one per transcript chunk — into a single result.
///
/// `Structural` is the default: deterministic, no extra model call, and
/// therefore no extra risk of re-introducing the prompt-size problem
/// chunking exists to fix. `Llm` is strictly opt-in — it can produce better
/// prose and more semantic deduplication, but it is a second, non-
/// deterministic pass that re-reads already-distilled output and could
/// silently drop a detail the first pass captured. Prefer `Structural`
/// unless you have a specific reason to accept that tradeoff.
#[derive(Debug, Clone, Copy, PartialEq, Eq, Default)]
pub enum ReduceStrategy {
    /// Merge partial results with [`merge_distilled`]. Deterministic, no
    /// model call.
    #[default]
    Structural,
    /// Render partial results back into text and call the distiller on
    /// them once more for a consolidated pass.
    Llm,
}

/// Renders partial distillation results back into a single transcript-like
/// string, for [`ReduceStrategy::Llm`]: each part's summary and facts are
/// listed in order, so a model reading the result can see everything every
/// chunk produced and consolidate it in one pass.
fn render_partials(parts: &[DistilledMemory]) -> String {
    let mut rendered = String::new();
    for (i, part) in parts.iter().enumerate() {
        let _ = writeln!(rendered, "Summary {}: {}", i + 1, part.summary);
        if !part.facts.is_empty() {
            rendered.push_str("Facts:\n");
            for fact in &part.facts {
                let _ = writeln!(rendered, "- [{:?}] {}", fact.kind, fact.text);
            }
        }
        rendered.push('\n');
    }
    rendered
}

/// Reduces `parts` — one [`DistilledMemory`] per transcript chunk — into a
/// single [`DistilledMemory`], using `strategy` to choose how.
///
/// An empty `parts` short-circuits to [`merge_distilled`]'s empty-`Vec`
/// behavior regardless of `strategy`: there is nothing for `inner` to
/// reduce, so there is nothing to call it with.
///
/// # Errors
///
/// Returns an error if `strategy` is [`ReduceStrategy::Llm`] and the call to
/// `inner.distill` fails.
fn reduce<D: Distiller>(
    parts: Vec<DistilledMemory>,
    inner: &D,
    strategy: ReduceStrategy,
) -> Result<DistilledMemory> {
    if parts.is_empty() {
        return Ok(merge_distilled(parts));
    }

    match strategy {
        ReduceStrategy::Structural => Ok(merge_distilled(parts)),
        ReduceStrategy::Llm => {
            let rendered = render_partials(&parts);
            inner.distill(&rendered)
        }
    }
}

/// Produces [`DistilledMemory`] from a raw conversation transcript.
///
/// Implementations must be thread-safe (`Send + Sync`) so a single
/// distiller instance can be shared across worker threads.
pub trait Distiller: Send + Sync {
    /// Distill `transcript` into a summary and a list of durable facts.
    ///
    /// # Security
    ///
    /// Implementations transmit `transcript` verbatim to the underlying
    /// model or service — no secret scrubbing is applied at this layer.
    /// [`ContextForge::distill_and_save`](crate::ContextForge::distill_and_save)
    /// is the only entry point that scrubs secrets (via
    /// [`scrub_secrets`](crate::scrub_secrets)) before a transcript reaches
    /// a [`Distiller`]; callers invoking [`Distiller::distill`] directly are
    /// responsible for scrubbing first.
    ///
    /// # Errors
    ///
    /// Returns an error if distillation fails (e.g. the backing model or
    /// service is unavailable, or its response cannot be parsed).
    fn distill(&self, transcript: &str) -> Result<DistilledMemory>;
}

/// A [`Distiller`] decorator that bounds the size of any single prompt sent
/// to `inner`.
///
/// A long transcript is split into chunks of at most `max_chunk_chars` (via
/// [`split_on_budget`]), each chunk is distilled independently through
/// `inner`, and the partial results are combined into one
/// [`DistilledMemory`] (via an internal `reduce` step, using the configured
/// [`ReduceStrategy`]). A transcript that already fits in one chunk — including
/// an empty transcript — is passed through to `inner` unchanged, with no
/// splitting or reducing.
///
/// `max_chunk_chars` is caller-supplied policy: this type has no opinion on
/// what a safe prompt size is for any particular model or host, only on how
/// to split, map, and reduce once a budget is given.
pub struct ChunkingDistiller<D: Distiller> {
    inner: D,
    max_chunk_chars: usize,
    reduce: ReduceStrategy,
}

impl<D: Distiller> ChunkingDistiller<D> {
    /// Wraps `inner`, splitting any transcript over `max_chunk_chars` into
    /// multiple distillation calls. Uses [`ReduceStrategy::Structural`] to
    /// combine the results; call [`Self::with_reduce_strategy`] to use
    /// [`ReduceStrategy::Llm`] instead.
    pub fn new(inner: D, max_chunk_chars: usize) -> Self {
        Self {
            inner,
            max_chunk_chars,
            reduce: ReduceStrategy::default(),
        }
    }

    /// Sets the [`ReduceStrategy`] used to combine chunk results.
    #[must_use]
    pub fn with_reduce_strategy(mut self, strategy: ReduceStrategy) -> Self {
        self.reduce = strategy;
        self
    }
}

impl<D: Distiller> Distiller for ChunkingDistiller<D> {
    /// # Errors
    ///
    /// Returns an error if any chunk's call to `inner.distill` fails, or if
    /// [`ReduceStrategy::Llm`] is used and the consolidating call fails. On
    /// error, no partial result is produced: chunks already distilled
    /// successfully before the failure are discarded, not saved or returned.
    fn distill(&self, transcript: &str) -> Result<DistilledMemory> {
        let chunks = split_on_budget(transcript, self.max_chunk_chars);
        if chunks.len() <= 1 {
            return self.inner.distill(transcript);
        }

        let parts = chunks
            .iter()
            .map(|chunk| self.inner.distill(chunk))
            .collect::<Result<Vec<_>>>()?;

        reduce(parts, &self.inner, self.reduce)
    }
}

#[cfg(test)]
mod tests {
    use super::{
        cap_distilled_memory, merge_distilled, reduce, split_on_budget, ChunkingDistiller,
        DistilledMemory, Distiller, Fact, FactKind, ReduceStrategy, MAX_FACTS, MAX_FACT_CHARS,
        MAX_SUMMARY_CHARS,
    };
    use crate::error::Error;
    use crate::traits::Result;

    fn fact(text: impl Into<String>) -> Fact {
        Fact {
            kind: FactKind::State,
            text: text.into(),
        }
    }

    #[test]
    fn cap_drops_excess_facts() {
        let facts = (0..MAX_FACTS + 50)
            .map(|i| fact(format!("fact {i}")))
            .collect();
        let memory = DistilledMemory {
            summary: "summary".to_owned(),
            facts,
        };

        let capped = cap_distilled_memory(memory);

        assert_eq!(capped.facts.len(), MAX_FACTS);
    }

    #[test]
    fn cap_truncates_long_fact_text() {
        let long_text = "a".repeat(MAX_FACT_CHARS + 1000);
        let memory = DistilledMemory {
            summary: "summary".to_owned(),
            facts: vec![fact(long_text.clone())],
        };

        let capped = cap_distilled_memory(memory);

        assert_eq!(capped.facts[0].text.chars().count(), MAX_FACT_CHARS);
        assert!(long_text.starts_with(&capped.facts[0].text));
    }

    #[test]
    fn cap_truncates_long_summary() {
        let long_summary = "b".repeat(MAX_SUMMARY_CHARS + 1000);
        let memory = DistilledMemory {
            summary: long_summary.clone(),
            facts: vec![],
        };

        let capped = cap_distilled_memory(memory);

        assert_eq!(capped.summary.chars().count(), MAX_SUMMARY_CHARS);
        assert!(long_summary.starts_with(&capped.summary));
    }

    #[test]
    fn cap_respects_char_boundaries() {
        let long_text = "é".repeat(MAX_FACT_CHARS + 10);
        let memory = DistilledMemory {
            summary: "🎉".repeat(MAX_SUMMARY_CHARS + 10),
            facts: vec![fact(long_text)],
        };

        let capped = cap_distilled_memory(memory);

        assert_eq!(capped.facts[0].text.chars().count(), MAX_FACT_CHARS);
        assert_eq!(capped.summary.chars().count(), MAX_SUMMARY_CHARS);
    }

    #[test]
    fn cap_leaves_compliant_memory_unchanged() {
        let memory = DistilledMemory {
            summary: "A short summary.".to_owned(),
            facts: vec![fact("A short fact.")],
        };

        let capped = cap_distilled_memory(memory.clone());

        assert_eq!(capped.summary, memory.summary);
        assert_eq!(capped.facts.len(), memory.facts.len());
        assert_eq!(capped.facts[0].text, memory.facts[0].text);
    }

    #[test]
    fn merge_empty_input_returns_empty_memory() {
        let merged = merge_distilled(vec![]);

        assert_eq!(merged.summary, "");
        assert!(merged.facts.is_empty());
    }

    #[test]
    fn merge_single_part_is_passthrough() {
        let part = DistilledMemory {
            summary: "A short summary.".to_owned(),
            facts: vec![fact("A short fact.")],
        };

        let merged = merge_distilled(vec![part.clone()]);

        assert_eq!(merged.summary, part.summary);
        assert_eq!(merged.facts.len(), 1);
        assert_eq!(merged.facts[0].text, part.facts[0].text);
    }

    #[test]
    fn merge_concatenates_facts_from_multiple_parts_in_order() {
        let part1 = DistilledMemory {
            summary: "First.".to_owned(),
            facts: vec![fact("Fact A")],
        };
        let part2 = DistilledMemory {
            summary: "Second.".to_owned(),
            facts: vec![fact("Fact B")],
        };

        let merged = merge_distilled(vec![part1, part2]);

        assert_eq!(merged.facts.len(), 2);
        assert_eq!(merged.facts[0].text, "Fact A");
        assert_eq!(merged.facts[1].text, "Fact B");
    }

    #[test]
    fn merge_dedups_facts_with_same_kind_and_normalized_text() {
        let part1 = DistilledMemory {
            summary: "First.".to_owned(),
            facts: vec![fact("We decided to roll back the deploy.")],
        };
        let part2 = DistilledMemory {
            summary: "Second.".to_owned(),
            // Same fact, different case and trailing whitespace.
            facts: vec![fact("we decided to roll back the deploy.  ")],
        };

        let merged = merge_distilled(vec![part1, part2]);

        // Only the first occurrence survives, with its original text intact.
        assert_eq!(merged.facts.len(), 1);
        assert_eq!(merged.facts[0].text, "We decided to roll back the deploy.");
    }

    #[test]
    fn merge_does_not_dedup_same_text_across_different_kinds() {
        let part = DistilledMemory {
            summary: "summary".to_owned(),
            facts: vec![
                Fact {
                    kind: FactKind::Decision,
                    text: "Same text.".to_owned(),
                },
                Fact {
                    kind: FactKind::State,
                    text: "Same text.".to_owned(),
                },
            ],
        };

        let merged = merge_distilled(vec![part]);

        // Different kind means a different dedup key, even with identical text.
        assert_eq!(merged.facts.len(), 2);
    }

    #[test]
    fn merge_joins_summaries_with_blank_line_then_caps() {
        // Exactly at the cap already, so nothing from the second summary
        // should survive truncation.
        let summary_a = "a".repeat(MAX_SUMMARY_CHARS);
        let summary_b = "b".repeat(1_000);
        let part1 = DistilledMemory {
            summary: summary_a.clone(),
            facts: vec![],
        };
        let part2 = DistilledMemory {
            summary: summary_b,
            facts: vec![],
        };

        let merged = merge_distilled(vec![part1, part2]);

        assert_eq!(merged.summary, summary_a);
        assert_eq!(merged.summary.chars().count(), MAX_SUMMARY_CHARS);
    }

    #[test]
    fn merge_caps_total_facts_at_max_facts() {
        let parts: Vec<DistilledMemory> = (0..MAX_FACTS + 20)
            .map(|i| DistilledMemory {
                summary: String::new(),
                facts: vec![fact(format!("fact number {i}"))],
            })
            .collect();

        let merged = merge_distilled(parts);

        assert_eq!(merged.facts.len(), MAX_FACTS);
    }

    #[test]
    #[should_panic(expected = "max_chars == 0")]
    fn split_on_budget_panics_in_debug_on_zero_budget() {
        let _ = split_on_budget("a\nb\n", 0);
    }

    #[test]
    fn split_on_budget_empty_transcript_returns_no_chunks() {
        let chunks = split_on_budget("", 60);

        assert!(chunks.is_empty());
    }

    #[test]
    fn split_on_budget_packs_lines_into_one_chunk_when_they_fit() {
        let transcript = "ab\ncde\nfg\n";
        let chunks = split_on_budget(transcript, 12);

        assert_eq!(chunks, vec!["ab\ncde\nfg\n"]);
        assert_eq!(chunks.concat(), transcript);
    }

    #[test]
    fn split_on_budget_flushes_before_exceeding_budget() {
        let transcript = "ab\ncdefghij\nklm\n";
        let chunks = split_on_budget(transcript, 10);

        assert_eq!(chunks, vec!["ab\n", "cdefghij\n", "klm\n"]);
        assert!(chunks.iter().all(|c| c.chars().count() <= 10));
        assert_eq!(chunks.concat(), transcript);
    }

    #[test]
    fn split_on_budget_hard_splits_oversized_single_line() {
        let transcript = "abcdefghij\n";
        let chunks = split_on_budget(transcript, 5);

        assert_eq!(chunks, vec!["abcde", "fghij", "\n"]);
        assert!(chunks.iter().all(|c| c.chars().count() <= 5));
        assert_eq!(chunks.concat(), transcript);
    }

    #[test]
    fn split_on_budget_flushes_pending_chunk_before_hard_splitting_oversized_line() {
        let transcript = format!("hi\n{}\nok\n", "c".repeat(13));
        let chunks = split_on_budget(&transcript, 5);

        assert_eq!(chunks, vec!["hi\n", "ccccc", "ccccc", "ccc\n", "ok\n"]);
        assert!(chunks.iter().all(|c| c.chars().count() <= 5));
        assert_eq!(chunks.concat(), transcript);
    }

    #[test]
    fn split_on_budget_reconstructs_transcript_without_trailing_newline() {
        let transcript = "a\nbb\nccc";
        let chunks = split_on_budget(transcript, 100);

        assert_eq!(chunks, vec!["a\nbb\nccc"]);
        assert_eq!(chunks.concat(), transcript);
    }

    /// A [`Distiller`] that panics if called, used to prove a code path
    /// under test never invokes the inner distiller at all.
    struct PanicIfCalledDistiller;

    impl Distiller for PanicIfCalledDistiller {
        fn distill(&self, _transcript: &str) -> Result<DistilledMemory> {
            panic!("inner.distill should not be called for this reduce strategy");
        }
    }

    /// A [`Distiller`] that records every transcript it was called with (in
    /// call order) and returns a fixed [`DistilledMemory`].
    struct RecordingDistiller {
        calls: std::sync::Mutex<Vec<String>>,
    }

    impl RecordingDistiller {
        fn new() -> Self {
            Self {
                calls: std::sync::Mutex::new(Vec::new()),
            }
        }
    }

    impl Distiller for RecordingDistiller {
        fn distill(&self, transcript: &str) -> Result<DistilledMemory> {
            self.calls.lock().unwrap().push(transcript.to_owned());
            Ok(DistilledMemory {
                summary: "Consolidated summary.".to_owned(),
                facts: vec![],
            })
        }
    }

    #[test]
    fn reduce_structural_never_calls_inner() {
        let parts = vec![
            DistilledMemory {
                summary: "First.".to_owned(),
                facts: vec![fact("Fact A")],
            },
            DistilledMemory {
                summary: "Second.".to_owned(),
                facts: vec![fact("Fact B")],
            },
        ];

        let result = reduce(
            parts.clone(),
            &PanicIfCalledDistiller,
            ReduceStrategy::Structural,
        )
        .expect("structural reduce does not call inner, so it cannot fail");

        assert_eq!(result.summary, merge_distilled(parts).summary);
    }

    #[test]
    fn reduce_empty_parts_returns_empty_without_calling_inner() {
        let result = reduce(vec![], &PanicIfCalledDistiller, ReduceStrategy::Llm)
            .expect("empty parts short-circuits before inner is ever called");

        assert_eq!(result.summary, "");
        assert!(result.facts.is_empty());
    }

    #[test]
    fn reduce_llm_calls_inner_exactly_once_with_rendered_partials() {
        let parts = vec![
            DistilledMemory {
                summary: "First chunk summary.".to_owned(),
                facts: vec![fact("Fact A")],
            },
            DistilledMemory {
                summary: "Second chunk summary.".to_owned(),
                facts: vec![Fact {
                    kind: FactKind::Decision,
                    text: "Fact B".to_owned(),
                }],
            },
        ];
        let distiller = RecordingDistiller::new();

        let result = reduce(parts, &distiller, ReduceStrategy::Llm).unwrap();

        let calls = distiller.calls.lock().unwrap();
        assert_eq!(calls.len(), 1, "inner.distill must be called exactly once");

        let rendered = &calls[0];
        assert!(rendered.contains("First chunk summary."));
        assert!(rendered.contains("Second chunk summary."));
        assert!(rendered.contains("[State] Fact A"));
        assert!(rendered.contains("[Decision] Fact B"));

        // The result is whatever the single consolidated call returned, not
        // a merge of the original parts.
        assert_eq!(result.summary, "Consolidated summary.");
    }

    /// A [`Distiller`] that records every transcript it was called with into
    /// a shared, externally observable list. Unlike [`RecordingDistiller`],
    /// the shared `Arc` lets a test keep inspecting calls after this stub
    /// has been moved into another type (e.g. [`ChunkingDistiller`], which
    /// takes ownership of its inner distiller).
    #[derive(Clone)]
    struct SharedRecordingDistiller {
        calls: std::sync::Arc<std::sync::Mutex<Vec<String>>>,
    }

    impl SharedRecordingDistiller {
        fn new() -> (Self, std::sync::Arc<std::sync::Mutex<Vec<String>>>) {
            let calls = std::sync::Arc::new(std::sync::Mutex::new(Vec::new()));
            (
                Self {
                    calls: calls.clone(),
                },
                calls,
            )
        }
    }

    impl Distiller for SharedRecordingDistiller {
        fn distill(&self, transcript: &str) -> Result<DistilledMemory> {
            self.calls.lock().unwrap().push(transcript.to_owned());
            Ok(DistilledMemory {
                summary: "stub summary".to_owned(),
                facts: vec![],
            })
        }
    }

    #[test]
    fn chunking_distiller_passthrough_calls_inner_once_with_original_transcript() {
        let (stub, calls) = SharedRecordingDistiller::new();
        let chunking = ChunkingDistiller::new(stub, 1_000);
        let transcript = "a short transcript, well under budget";

        chunking.distill(transcript).unwrap();

        let calls = calls.lock().unwrap();
        assert_eq!(calls.len(), 1);
        assert_eq!(calls[0], transcript);
    }

    #[test]
    fn chunking_distiller_empty_transcript_calls_inner_once_with_empty_string() {
        let (stub, calls) = SharedRecordingDistiller::new();
        let chunking = ChunkingDistiller::new(stub, 1_000);

        chunking.distill("").unwrap();

        let calls = calls.lock().unwrap();
        assert_eq!(calls.len(), 1);
        assert_eq!(calls[0], "");
    }

    /// A [`Distiller`] that returns content derived from its input
    /// transcript, so a multi-chunk test can verify each chunk was
    /// distilled independently (rather than, say, all chunks colliding on
    /// one fixed stub response).
    struct EchoDistiller;

    impl Distiller for EchoDistiller {
        fn distill(&self, transcript: &str) -> Result<DistilledMemory> {
            Ok(DistilledMemory {
                summary: format!("Summary of: {transcript}"),
                facts: vec![Fact {
                    kind: FactKind::State,
                    text: format!("Fact from: {transcript}"),
                }],
            })
        }
    }

    #[test]
    fn chunking_distiller_maps_each_chunk_and_merges_structurally() {
        // max_chunk_chars = 4 packs each 4-char line ("aaa\n", "bbb\n") into
        // its own chunk; see split_on_budget's own tests for this packing
        // rule. Default reduce strategy is Structural (merge_distilled).
        let transcript = "aaa\nbbb\n";
        let chunking = ChunkingDistiller::new(EchoDistiller, 4);

        let result = chunking.distill(transcript).unwrap();

        assert_eq!(result.facts.len(), 2);
        assert!(result.facts.iter().any(|f| f.text == "Fact from: aaa\n"));
        assert!(result.facts.iter().any(|f| f.text == "Fact from: bbb\n"));
        assert!(result.summary.contains("Summary of: aaa\n"));
        assert!(result.summary.contains("Summary of: bbb\n"));
    }

    /// A [`Distiller`] that fails for any transcript containing `trigger`,
    /// otherwise succeeds with a fixed result. Used to prove a single
    /// chunk's failure propagates instead of being silently dropped.
    struct FailsOnDistiller {
        trigger: &'static str,
    }

    impl Distiller for FailsOnDistiller {
        fn distill(&self, transcript: &str) -> Result<DistilledMemory> {
            if transcript.contains(self.trigger) {
                Err(Error::Distill("simulated chunk failure".to_owned()))
            } else {
                Ok(DistilledMemory {
                    summary: "ok".to_owned(),
                    facts: vec![],
                })
            }
        }
    }

    #[test]
    fn chunking_distiller_propagates_a_single_chunk_failure() {
        // Same packing as the merge test: "aaa\n" and "bbb\n" become two
        // chunks under max_chunk_chars = 4. The second chunk fails.
        let transcript = "aaa\nbbb\n";
        let chunking = ChunkingDistiller::new(FailsOnDistiller { trigger: "bbb" }, 4);

        let result = chunking.distill(transcript);

        assert!(result.is_err());
    }
}