1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
//! Skinned-mesh upload, per-frame joint upload, and helpers for VkContext.
//! Builds the per-(frame, object) joint storage buffers once at init;
//! per-frame `update_skinned_pose` + `upload_joint_matrices` keep the matrices
//! fresh from the gameplay-side pose update.
use ash::vk;
use concinnity_core::gfx::mesh_payload;
use concinnity_core::gfx::mesh_payload::SkinnedVertex;
use concinnity_core::gfx::render_types::*;
use concinnity_core::render::error::{RenderError, RenderResult};
use concinnity_core::render::geometry_repack;
use concinnity_core::render::rt_geom;
use concinnity_core::transform::IDENTITY;
use super::super::context::*;
use super::super::set_writes::SetWrites;
impl VkContext {
// Upload skinned-mesh geometry and the per-(frame, object) joint buffers.
pub(crate) fn upload_skinned(
&mut self,
vertices: &[SkinnedVertex],
indices: &[u32],
draw_objects: Vec<SkinnedDrawObject>,
) -> RenderResult<()> {
if draw_objects.is_empty() || vertices.is_empty() || indices.is_empty() {
return Ok(());
}
self.wait_idle();
let frames = self.frames_in_flight.max(1);
let n = draw_objects.len();
let vtx_bytes = bytemuck::cast_slice(vertices);
let idx_bytes = bytemuck::cast_slice(indices);
// The skin compute kernel reads the bind-pose VB as a storage buffer, so
// STORAGE_BUFFER is unconditional: the main-pass skinning fold runs
// whether or not the device is RT-capable.
//
// The IB's extra flags are genuinely RT-only: it is the skinned BLAS
// index input (device-addressed) and the hit shader's index SSBO,
// and nothing outside the RT path binds it as a buffer. Added whenever
// the device is RT-capable (not only when RT is on at launch) so a later
// live toggle finds the skinned IB already usable, mirroring how the
// static VB/IB gate their RT flags at init. Inert when RT is never built.
let skinned_ib_rt = if self.hw.rt_capable {
vk::BufferUsageFlags::STORAGE_BUFFER
| vk::BufferUsageFlags::SHADER_DEVICE_ADDRESS
| vk::BufferUsageFlags::ACCELERATION_STRUCTURE_BUILD_INPUT_READ_ONLY_KHR
} else {
vk::BufferUsageFlags::empty()
};
let skinned_vbuf = self.hw.alloc.create_buffer(
vtx_bytes.len() as u64,
vk::BufferUsageFlags::VERTEX_BUFFER
| vk::BufferUsageFlags::TRANSFER_DST
| vk::BufferUsageFlags::STORAGE_BUFFER,
vk::MemoryPropertyFlags::DEVICE_LOCAL,
)?;
// Never zero-length: the ray-traced hit path binds this as a storage
// buffer of index words and its descriptor takes the whole size.
let skinned_ibuf = self.hw.alloc.create_buffer(
rt_geom::skinned_index_buffer_bytes(indices.len()) as u64,
vk::BufferUsageFlags::INDEX_BUFFER | vk::BufferUsageFlags::TRANSFER_DST | skinned_ib_rt,
vk::MemoryPropertyFlags::DEVICE_LOCAL,
)?;
self.write_geometry_region(skinned_vbuf.buffer(), 0, vtx_bytes)?;
self.write_geometry_region(skinned_ibuf.buffer(), 0, idx_bytes)?;
// Per-(frame, object) joint storage buffers seeded with identity
// matrices so any not-yet-overwritten slot reads as identity.
let joint_buf_bytes = (MAX_JOINTS * std::mem::size_of::<[[f32; 4]; 4]>()) as u64;
let identity_seed: Vec<[[f32; 4]; 4]> = vec![IDENTITY; MAX_JOINTS];
let mut joint_buffers: Vec<Vec<super::super::allocator::PooledBuffer>> =
Vec::with_capacity(frames);
for _ in 0..frames {
let mut bufs: Vec<super::super::allocator::PooledBuffer> = Vec::with_capacity(n);
for _ in 0..n {
let buf = self.hw.alloc.create_buffer(
joint_buf_bytes,
vk::BufferUsageFlags::STORAGE_BUFFER,
vk::MemoryPropertyFlags::HOST_VISIBLE | vk::MemoryPropertyFlags::HOST_COHERENT,
)?;
buf.write_slice(0, &identity_seed);
bufs.push(buf);
}
joint_buffers.push(bufs);
}
self.state.skinned.joint_matrices = draw_objects
.iter()
.map(|o| vec![IDENTITY; o.joint_count.max(1)])
.collect();
self.skinned.vertex_buffer = skinned_vbuf;
self.skinned.vertex_buffer_bytes = vtx_bytes.len() as u64;
self.skinned.index_buffer = skinned_ibuf;
self.skinned.index_buffer_bytes = idx_bytes.len() as u64;
self.skinned.joint_buffers = joint_buffers;
self.state.skinned.draw_objects = draw_objects;
// A whole new skinned set: nothing in the model-history ring was written
// for these records.
let n_cull = self.cull_count();
self.state.model_history.get_mut().reset(n_cull);
// Morph targets are attached by a later `upload_skinned_morphs`; until
// then every object is morphless (a re-upload resets here).
self.skinned.morph_delta_unique = Vec::new();
self.skinned.morph_delta_buffers = vec![vk::Buffer::null(); n];
self.skinned.morph_target_counts = vec![0; n];
self.state.skinned.morph_weights = vec![Vec::new(); n];
self.skinned.morph_weight_buffers = Vec::new();
// GPU-driven main-pass skinning: build the `rt_skin` compute pipeline +
// per-frame deformed-vertex buffers + their descriptor sets, and set
// `self.state.draw.n_skinned` so `cull_count()` covers the skinned tail. Every
// skinned draw rides the GPU-driven pass, so a build failure is a
// startup error, as on Metal. Mirrors the DirectX `upload_skinned`.
self.build_main_skin(vertices.len())
.map_err(|e| e.context("skinned: main-pass skin fold build failed"))?;
Ok(())
}
// Replace a `SkinnedMesh` draw slot's vertex + index data in place.
// Driven by asset hot-reload (`cn debug` only). The shared skinned VB
// / IB were sized once at `upload_skinned` to hold every skinned
// mesh's geometry, so the new payload must fit within this slot's
// existing region (size-changing reloads route through
// `rebuild_skinned_geometry`). `vertex_base` is the slot's vertex
// offset *in vertices*; `indices` are mesh-relative and get rebased
// by `vertex_base` before being written into the shared IB.
// Mirrors `DxContext::update_skinned_mesh_geometry`. Reached only through
// the bin's `cn debug` runtime-mutation path (dead in the FFI lib, live in
// the bin).
pub(crate) fn update_skinned_mesh_geometry(
&mut self,
skinned_index: SkinnedIndex,
vertex_base: u32,
vertices: &[SkinnedVertex],
indices: &[u16],
) -> RenderResult<()> {
if self.skinned.vertex_buffer.is_null() || self.skinned.index_buffer.is_null() {
return Err(RenderError::Other(
"update_skinned_mesh_geometry: no skinned vertex/index buffer (was \
upload_skinned called?)"
.to_string(),
));
}
let write = geometry_repack::place_skinned_update(
&self.state.skinned.draw_objects,
skinned_index,
vertex_base,
vertices.len(),
indices,
self.skinned.vertex_buffer_bytes as usize,
)?;
self.wait_idle();
self.write_geometry_region(
self.skinned.vertex_buffer.buffer(),
write.vertex_offset,
bytemuck::cast_slice(vertices),
)?;
self.write_geometry_region(
self.skinned.index_buffer.buffer(),
write.index_offset,
bytemuck::cast_slice(&write.indices),
)?;
Ok(())
}
// Copy this frame's skinning matrices into the per-frame joint buffers.
pub(in crate::vulkan) fn upload_joint_matrices(&self, frame_idx: usize) {
let Some(frame_bufs) = self.skinned.joint_buffers.get(frame_idx) else {
return;
};
for (i, mats) in self.state.skinned.joint_matrices.iter().enumerate() {
let Some(dst) = frame_bufs.get(i) else {
continue;
};
let count = mats.len().min(MAX_JOINTS);
dst.write_slice(0, &mats[..count]);
}
}
// Attach morph-target buffers (`PayloadMorphs::packed_words`) to the skinned
// draw objects. `morphs[i]` pairs with draw object `i`; instance copies share
// their template's `Arc`, so each unique entry set becomes one device buffer. Allocates the per-frame
// weight buffers (one f32 per target per object) and re-points the main fold's
// skin descriptor-set morph bindings when any object carries morphs. Called
// once after `upload_skinned`. Mirrors the DirectX `upload_skinned_morphs`.
pub(in crate::vulkan) fn upload_skinned_morphs(
&mut self,
morphs: Vec<Option<std::sync::Arc<mesh_payload::PayloadMorphs>>>,
) -> RenderResult<()> {
use std::collections::HashMap;
let n = self.state.skinned.draw_objects.len();
let frames = self.frames_in_flight.max(1);
let mut delta_unique: Vec<super::super::allocator::PooledBuffer> = Vec::new();
let mut delta_buffers: Vec<vk::Buffer> = vec![vk::Buffer::null(); n];
let mut target_counts: Vec<u32> = vec![0; n];
let mut weights: Vec<Vec<f32>> = vec![Vec::new(); n];
let mut by_source: HashMap<usize, (vk::Buffer, u32)> = HashMap::new();
for (i, m) in morphs.iter().take(n).enumerate() {
let Some(data) = m else { continue };
let key = std::sync::Arc::as_ptr(data) as usize;
let (buf, count) = match by_source.get(&key) {
Some(e) => *e,
None => {
let words = data.packed_words();
let bytes: &[u8] = bytemuck::cast_slice(&words);
let pooled = self.hw.alloc.create_buffer(
bytes.len().max(4) as u64,
vk::BufferUsageFlags::STORAGE_BUFFER | vk::BufferUsageFlags::TRANSFER_DST,
vk::MemoryPropertyFlags::DEVICE_LOCAL,
)?;
let buf = pooled.buffer();
self.write_geometry_region(buf, 0, bytes)?;
let count = data.target_count() as u32;
delta_unique.push(pooled);
by_source.insert(key, (buf, count));
(buf, count)
}
};
delta_buffers[i] = buf;
target_counts[i] = count;
weights[i] = vec![0.0; count as usize];
}
// Per-(frame, object) host-mapped weight buffers, one f32 per target
// (>= 1 so every binding has a valid buffer), zero-seeded. Only allocated
// when some object carries morphs.
let mut weight_buffers: Vec<Vec<super::super::allocator::PooledBuffer>> = Vec::new();
if target_counts.iter().any(|&c| c > 0) {
for _ in 0..frames {
let mut bufs = Vec::with_capacity(n);
for &count in &target_counts {
let size = (count.max(1) as u64) * std::mem::size_of::<f32>() as u64;
let buf = self.hw.alloc.create_buffer(
size,
vk::BufferUsageFlags::STORAGE_BUFFER,
vk::MemoryPropertyFlags::HOST_VISIBLE
| vk::MemoryPropertyFlags::HOST_COHERENT,
)?;
buf.zero_bytes(0, size as usize);
bufs.push(buf);
}
weight_buffers.push(bufs);
}
}
// Re-point the main fold's skin descriptor sets' morph bindings (3 =
// deltas, 4 = weights). Morphless objects keep the dummy SSBO the
// `build_main_skin` write left. A no-op when the fold is inactive.
if let Some(skin) = self.skinned.skin.as_ref() {
let dummy = skin.morph_dummy;
for (f, frame_sets) in skin.sets.iter().enumerate() {
for (o, &set) in frame_sets.iter().enumerate() {
let delta_buf = match delta_buffers.get(o) {
Some(&b) if b != vk::Buffer::null() => b,
_ => dummy,
};
let weight_buf = match weight_buffers.get(f).and_then(|fb| fb.get(o)) {
Some(b) => b.buffer(),
None => dummy,
};
SetWrites::new(set)
.storage_buffer(3, delta_buf, vk::WHOLE_SIZE)
.storage_buffer(4, weight_buf, vk::WHOLE_SIZE)
.apply(&self.hw.device);
}
}
}
self.skinned.morph_delta_unique = delta_unique;
self.skinned.morph_delta_buffers = delta_buffers;
self.skinned.morph_target_counts = target_counts;
self.state.skinned.morph_weights = weights;
self.skinned.morph_weight_buffers = weight_buffers;
Ok(())
}
// Copy this frame's morph weights into the per-frame weight buffers the skin
// fold reads. Called alongside `upload_joint_matrices`. A no-op when no
// object carries morphs (the buffers are empty).
pub(in crate::vulkan) fn upload_morph_weights(&self, frame_idx: usize) {
let Some(frame_bufs) = self.skinned.morph_weight_buffers.get(frame_idx) else {
return;
};
for (i, w) in self.state.skinned.morph_weights.iter().enumerate() {
let (Some(dst), false) = (frame_bufs.get(i), w.is_empty()) else {
continue;
};
dst.write_slice(0, w);
}
}
}