commonware-runtime 2026.10.0

Execute asynchronous tasks with a configurable scheduler.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
//! Waiter identity and lifecycle state for tracked io_uring requests.
//!
//! A registration keeps one ID while queued, in flight, and awaiting result
//! consumption. A pending entry owns the request and its observer. Terminal
//! completion retains the result for a local observer, or recycles the slot
//! for forwarded, detached, and orphaned requests.
//!
//! Unfinished requests and outstanding operation SQEs are counted separately.
//! Retained results contribute to neither count, so a slow observer cannot hold
//! staging capacity. Driver queues and deadlines must also reject these results
//! even though their IDs still resolve in the slab.
//!
//! Observer wakers, detached publications, and owners ready for destruction are handed
//! to [`Deferred`]. The worker invokes callbacks after releasing its local borrow.

use super::{
    registration::Observation,
    request::{Request, RequestOutput},
    runtime::Deferred,
    slab::{Id, Slab},
    timeout::Tick,
};
use crate::Error;
use commonware_utils::{channel::oneshot, sync::OwnedAsyncMutexGuard};
use io_uring::squeue::Entry as SqueueEntry;
use std::{mem, task::Waker, time::Instant};

/// Kernel completion identity packed into an SQE's `user_data` field.
pub type UserData = u64;

/// Slab identity used for operation SQE/CQE `user_data`.
///
/// Userspace retains the full generation. Kernel `user_data` packs the index in
/// the low 32 bits and the low 32 generation bits in the high 32 bits.
/// An operation CQE cannot be stale because its slot cannot recycle before it
/// arrives, so completion lookup recovers the full identity from the live slot.
/// Cancellation acknowledgements use a separate token handled by the driver.
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
pub struct WaiterId(pub Id);

impl WaiterId {
    /// Encode this waiter id as `user_data` for the operation SQE/CQE.
    ///
    /// The packed generation wraps at 2^32. Userspace handles and queues must
    /// retain the full ID rather than using this truncated kernel identity.
    pub const fn user_data(self) -> UserData {
        ((self.0.generation & u32::MAX as UserData) << 32) | self.0.index as UserData
    }

    /// Decode the slot index and truncated generation from kernel `user_data`.
    const fn from_user_data(user_data: UserData) -> (u32, u32) {
        (user_data as u32, (user_data >> 32) as u32)
    }
}

/// Lifecycle state of a tracked request.
#[derive(Clone, Copy, Debug, PartialEq, Eq)]
pub enum WaiterState {
    /// Request is still tracked and has not transitioned to cancellation.
    Active {
        /// Absolute wheel tick by which the request must complete.
        ///
        /// If completion has not been observed by this tick, cancellation is
        /// requested. `None` means no wheel deadline has been installed yet,
        /// including requests that have no timeout.
        target_tick: Option<Tick>,
    },
    /// Cancellation was requested.
    ///
    /// The driver completes queued requests locally and schedules async cancel
    /// for in-flight requests. In-flight resources stay owned until the operation CQE.
    CancelRequested,
}

/// Destination of a logical request's terminal output.
pub enum Observer {
    /// Local observer whose result stays in the slot until consumed or dropped.
    ///
    /// The waker is absent until the future first installs one.
    /// Completion retains the result even if it races that installation.
    Local(Option<Waker>),
    /// Forwarded observer receiving its result through a channel.
    Forwarded(oneshot::Sender<Result<RequestOutput, Error>>),
    /// Independent sync completion sender, used outside the worker borrow.
    DetachedSync(oneshot::Sender<Result<(), Error>>),
    /// No caller remains, so terminal output is deferred for destruction.
    Orphaned,
}

/// State for one tracked logical request.
struct Waiter {
    /// Lifecycle state for the logical request stored in this slot.
    state: WaiterState,
    /// Whether the logical request currently has an operation SQE in flight.
    in_flight: bool,
    /// Result destination and any waker awaiting terminal completion.
    observer: Observer,
    /// The active request state machine.
    request: Request,
    /// Held across every SQE until terminal durability accounting finishes.
    durability: Option<OwnedAsyncMutexGuard<()>>,
}

/// One identity retained from registration through result consumption.
enum Entry {
    /// Queued or in-flight request that still owns its kernel resources.
    Pending(Waiter),
    /// Local result retained under the same ID until consumption or drop.
    Ready(RequestOutput),
    /// Temporary replacement while [`Waiters::finish`] splits owned state.
    ///
    /// Before returning, finish replaces this with Ready or removes the slot.
    Retiring,
}

/// Outcome produced when handling an operation CQE for a waiter.
pub enum CompletionOutcome {
    /// The logical request needs another SQE and should be placed back in the
    /// ready queue.
    Requeue(WaiterId),
    /// Terminal status the driver must pass to [`Waiters::finish`] for this ID.
    Complete(WaiterId, Result<(), Error>),
}

/// Tracks logical requests and the state needed to complete them.
pub struct Waiters {
    /// Pending requests and retained local results sharing one identity space.
    entries: Slab<Entry>,
    /// Unfinished logical requests, excluding retained results.
    pending: usize,
    /// Staged operation SQEs whose CQEs have not been consumed.
    in_flight: usize,
}

impl Waiters {
    /// Preallocate storage without imposing a request limit.
    pub fn new(capacity: usize) -> Self {
        Self {
            entries: Slab::with_capacity(capacity),
            pending: 0,
            in_flight: 0,
        }
    }

    /// Number of unfinished logical requests, excluding retained results.
    pub const fn len(&self) -> usize {
        self.pending
    }

    /// Whether all logical requests have finished, regardless of result consumption.
    pub const fn is_empty(&self) -> bool {
        self.pending == 0
    }

    /// Number of staged operation SQEs whose CQEs have not been consumed.
    ///
    /// Cancellation SQEs and completed results do not contribute to this count.
    pub const fn in_flight(&self) -> usize {
        self.in_flight
    }

    /// Insert a request and return its assigned id.
    ///
    /// The driver installs any deadline before staging the request. The slot
    /// remains occupied until a local result is consumed or dropped.
    pub fn insert(&mut self, request: Request, observer: Observer) -> WaiterId {
        let id = self.entries.insert_with(|id| {
            // Reserve the maximum index for cancellation and mailbox wake tokens.
            assert!(id.index < u32::MAX, "waiter slot index overflow");
            Entry::Pending(Waiter {
                state: WaiterState::Active { target_tick: None },
                in_flight: false,
                observer,
                request,
                durability: None,
            })
        });
        self.pending += 1;
        WaiterId(id)
    }

    /// Borrow an unfinished request, rejecting stale IDs and retained results.
    fn get(&self, id: WaiterId) -> Option<&Waiter> {
        match self.entries.get(id.0)? {
            Entry::Pending(waiter) => Some(waiter),
            _ => None,
        }
    }

    /// Mutably borrow an unfinished request, rejecting stale IDs and retained results.
    fn get_mut(&mut self, id: WaiterId) -> Option<&mut Waiter> {
        match self.entries.get_mut(id.0)? {
            Entry::Pending(waiter) => Some(waiter),
            _ => None,
        }
    }

    /// Return whether the ID refers to an unfinished request.
    pub fn is_pending(&self, id: WaiterId) -> bool {
        self.get(id).is_some()
    }

    /// Install an acquired permit before checking for a local terminal result.
    pub fn acquire_durability(
        &mut self,
        id: WaiterId,
        permit: OwnedAsyncMutexGuard<()>,
    ) -> Option<Result<(), Error>> {
        let waiter = self.get_mut(id).expect("durability waiter missing");
        assert!(
            waiter.durability.is_none(),
            "durability permit already held"
        );
        waiter.durability = Some(permit);
        waiter.request.prepare_durability()
    }

    /// Original absolute deadline of an unfinished request, if it has one.
    ///
    /// Stale IDs and retained results return `None`. Cancellation does not
    /// erase this deadline. Use [`Self::target_tick`] for active wheel tracking.
    pub fn deadline(&self, id: WaiterId) -> Option<Instant> {
        self.get(id).and_then(|waiter| waiter.request.deadline())
    }

    /// Deadline that still contributes to the wheel's active counts.
    ///
    /// Returns `None` before scheduling, after cancellation or completion, and
    /// for stale IDs. The driver removes the previous tick when cancelling.
    pub fn target_tick(&self, id: WaiterId) -> Option<Tick> {
        match self.get(id)?.state {
            WaiterState::Active { target_tick } => target_tick,
            WaiterState::CancelRequested => None,
        }
    }

    /// Record the tick after the driver schedules this request on its wheel.
    ///
    /// Panics unless the request is pending, active, and has no installed tick.
    pub fn set_deadline(&mut self, id: WaiterId, tick: Tick) {
        let waiter = self.get_mut(id).expect("deadline waiter missing");
        let WaiterState::Active { target_tick } = &mut waiter.state else {
            panic!("deadline installed on cancelled waiter");
        };
        assert!(target_tick.is_none(), "deadline installed twice");
        *target_tick = Some(tick);
    }

    /// Inspect or consume a result without running observer callbacks.
    ///
    /// A ready result is removed and its slot recycled. An unfinished request
    /// remains in place, returning whether its waker needs refreshing. Panics
    /// if the ID no longer belongs to a local observer.
    pub fn observe(&mut self, id: WaiterId, waker: &Waker) -> Observation<RequestOutput> {
        match self.entries.get(id.0).expect("live observer missing") {
            Entry::Ready(_) => {
                let Some(Entry::Ready(output)) = self.entries.remove(id.0) else {
                    unreachable!()
                };
                Observation::Ready(output)
            }
            Entry::Pending(waiter) => {
                let Observer::Local(current) = &waiter.observer else {
                    panic!("request has no local observer");
                };
                if current
                    .as_ref()
                    .is_some_and(|current| current.will_wake(waker))
                {
                    Observation::Pending
                } else {
                    Observation::Refresh
                }
            }
            Entry::Retiring => unreachable!(),
        }
    }

    /// Install a waker already cloned outside the worker borrow.
    ///
    /// Returns the previous waker for deferred destruction. Panics unless the
    /// request has a pending local observer.
    pub fn set_waker(&mut self, id: WaiterId, waker: Waker) -> Option<Waker> {
        let waiter = self.get_mut(id).expect("observer waiter missing");
        let Observer::Local(current) = &mut waiter.observer else {
            panic!("request has no local observer");
        };
        current.replace(waker)
    }

    /// Move local observation to a channel without moving the request.
    pub fn forward(
        &mut self,
        id: WaiterId,
        sender: oneshot::Sender<Result<RequestOutput, Error>>,
        deferred: &mut Deferred,
    ) {
        // Local cancellation can overtake this mailbox message and recycle the slot.
        match self.entries.get_mut(id.0) {
            Some(Entry::Pending(waiter)) if matches!(waiter.observer, Observer::Local(_)) => {
                let Observer::Local(waker) =
                    mem::replace(&mut waiter.observer, Observer::Forwarded(sender))
                else {
                    panic!("request has no local observer");
                };
                deferred.drops.extend(waker);
            }
            Some(Entry::Ready(_)) => {
                let Some(Entry::Ready(output)) = self.entries.remove(id.0) else {
                    unreachable!()
                };
                deferred.results.push((sender, Ok(output)));
            }
            _ => deferred.results.push((sender, Err(Error::Closed))),
        }
    }

    /// Detach local or forwarded observation, returning whether cancellation is needed.
    ///
    /// Pending writes and syncs keep running without their observer. Other
    /// newly orphaned requests return `true` so the driver can cancel them.
    /// A retained result is removed and deferred for destruction. Stale IDs,
    /// detached syncs, and already orphaned requests are left alone.
    pub fn orphan(&mut self, id: WaiterId, deferred: &mut Deferred) -> bool {
        match self.entries.get_mut(id.0) {
            Some(Entry::Pending(waiter)) => {
                match &waiter.observer {
                    Observer::Local(_) | Observer::Forwarded(_) => {}
                    _ => return false,
                }
                match mem::replace(&mut waiter.observer, Observer::Orphaned) {
                    Observer::Local(waker) => deferred.drops.extend(waker),
                    Observer::Forwarded(sender) => {
                        deferred.results.push((sender, Err(Error::Closed)));
                    }
                    _ => unreachable!(),
                }

                // The driver cancels eligible requests before processing more CQEs.
                !waiter.request.retains_on_orphan()
            }
            Some(Entry::Ready(_)) => {
                let Some(Entry::Ready(output)) = self.entries.remove(id.0) else {
                    unreachable!()
                };
                deferred.outputs.push(output);
                false
            }
            None => false,
            Some(Entry::Retiring) => unreachable!(),
        }
    }

    /// Remove local and forwarded observers, returning pending cancellation IDs.
    ///
    /// Writes and syncs remain owned until they finish. Detached sync senders
    /// stay installed. Surviving observers are notified of closure.
    pub fn close(&mut self, deferred: &mut Deferred) -> Vec<WaiterId> {
        let mut cancel = Vec::new();
        for index in 0..self.entries.slots() {
            let Some(id) = self.entries.id_at(index).map(WaiterId) else {
                continue;
            };

            // Take local wakers before orphaning so shared futures can notify surviving
            // observers. Callbacks run after the worker borrow is released.
            if let Some(waiter) = self.get_mut(id)
                && let Observer::Local(waker) = &mut waiter.observer
            {
                deferred.wakes.extend(waker.take());
            }

            // Orphaning reports closure to forwarded observers and releases retained
            // results. Writes and syncs keep running without requesting cancellation.
            if self.orphan(id, deferred) {
                cancel.push(id);
            }
        }
        cancel
    }

    /// Request cancellation for an active waiter.
    ///
    /// Returns `true` only when it first records a cancellation request.
    /// The driver must remove the old wheel tick and arrange local completion
    /// or a cancellation SQE. Stale IDs and completed results return `false`.
    pub fn cancel(&mut self, id: WaiterId) -> bool {
        let Some(waiter) = self.get_mut(id) else {
            return false;
        };
        match waiter.state {
            WaiterState::Active { .. } => {
                waiter.state = WaiterState::CancelRequested;
                true
            }
            WaiterState::CancelRequested => false,
        }
    }

    /// Split terminal ownership and retain a local result in the same slot.
    ///
    /// `result` is the terminal CQE status or an explicit local failure.
    /// Local output replaces the pending request. Forwarded, detached, and
    /// orphaned output leaves the slab, freeing its slot immediately.
    ///
    /// Returns any active tick the driver must remove from the wheel. Waking,
    /// detached publication, and resource destruction are deferred. Panics if
    /// the request is missing, already completed, or still has an SQE in flight.
    pub fn finish(
        &mut self,
        id: WaiterId,
        result: Result<(), Error>,
        deferred: &mut Deferred,
    ) -> Option<Tick> {
        // The kernel must be done with the request before we move or release
        // the resources referenced by its SQE.
        assert!(
            !self.get(id).expect("finished waiter missing").in_flight,
            "cannot finish kernel-visible request"
        );

        // Keep the identity occupied while separating the output from the
        // resources whose destruction must wait for the worker borrow to end.
        let entry = self.entries.get_mut(id.0).unwrap();
        let Entry::Pending(waiter) = mem::replace(entry, Entry::Retiring) else {
            unreachable!()
        };

        // A retained result must not keep the request counted as pending.
        self.pending -= 1;

        // The driver removes the wheel tick when cancelling. Other completions
        // still need to report it for removal.
        let tick = match waiter.state {
            WaiterState::Active { target_tick } => target_tick,
            WaiterState::CancelRequested => None,
        };

        // Permit waiters use only the driver's native wake source. Accounting
        // precedes their release. File and buffer owners remain deferred.
        let (output, resources) = waiter.request.complete(result);
        drop(waiter.durability);
        deferred.resources.push(resources);

        match waiter.observer {
            Observer::Local(waker) => {
                // The future still holds this ID and will consume the result
                // on a later poll.
                *entry = Entry::Ready(output);
                deferred.wakes.extend(waker);
            }
            Observer::DetachedSync(sender) => {
                // The receiver no longer needs the slot. Sending may wake user
                // code, so defer publication until the worker borrow ends.
                let RequestOutput::Sync(output) = output else {
                    panic!("sync observer received other request");
                };
                self.entries.remove(id.0);
                deferred.completions.push((sender, output));
            }
            Observer::Forwarded(sender) => {
                self.entries.remove(id.0);
                deferred.results.push((sender, Ok(output)));
            }
            Observer::Orphaned => {
                // Nobody will consume the result. Its buffers may run user code
                // when dropped, so defer their destruction after freeing the slot.
                self.entries.remove(id.0);
                deferred.outputs.push(output);
            }
        }
        tick
    }

    /// Stage the next SQE for a waiter.
    ///
    /// Marks the request in flight before returning the SQE. The driver retires
    /// cancelled requests before staging or at their operation CQE.
    /// Panics if the ID is not pending, is cancelled, or already has an SQE in flight.
    pub fn stage(&mut self, id: WaiterId) -> SqueueEntry {
        let waiter = self.get_mut(id).expect("stage called for untracked waiter");
        assert!(
            !waiter.in_flight,
            "stage called for waiter with op already in flight"
        );
        assert!(
            matches!(waiter.state, WaiterState::Active { .. }),
            "stage called for cancelled waiter"
        );
        assert!(
            waiter.request.durability().is_none() || waiter.durability.is_some(),
            "durability request staged without its permit"
        );

        // Construction can reject an invalid buffer range. Until it
        // succeeds, cleanup must remain able to finish the request locally.
        let sqe = waiter.request.build_sqe(id);
        waiter.in_flight = true;
        self.in_flight += 1;
        sqe
    }

    /// Process one operation CQE for a waiter.
    ///
    /// An operation CQE releases its in-flight count and updates progress in
    /// place. The driver then requeues or finishes the request. A cancelled
    /// request never requeues, returning its terminal result or `Error::Timeout`
    /// if another SQE would be needed.
    ///
    /// A missing entry or mismatched packed generation is an invariant failure.
    pub fn on_completion(&mut self, user_data: UserData, result: i32) -> CompletionOutcome {
        let (index, generation) = WaiterId::from_user_data(user_data);

        // The outstanding SQE keeps this slot occupied, even if the packed
        // generation has wrapped. Recover the full ID before returning it.
        let id = self
            .entries
            .id_at(index as usize)
            .map(WaiterId)
            .expect("operation CQE for missing waiter");
        assert_eq!(
            id.0.generation as u32, generation,
            "operation CQE for mismatched waiter generation"
        );
        let waiter = self
            .get_mut(id)
            .expect("operation CQE for completed waiter");

        // The operation CQE retires the currently in-flight SQE, regardless of
        // whether the request completes or is requeued for another one.
        assert!(waiter.in_flight);
        waiter.in_flight = false;

        let outcome = match waiter.request.on_cqe(waiter.state, result) {
            Some(result) => CompletionOutcome::Complete(id, result),
            None if matches!(waiter.state, WaiterState::CancelRequested) => {
                // Preserve terminal results above, but never issue a follow-up
                // SQE after cancellation, including for an orphaned file read.
                CompletionOutcome::Complete(id, Err(Error::Timeout))
            }
            None => CompletionOutcome::Requeue(id),
        };
        self.in_flight -= 1;
        outcome
    }

    /// Return whether a waiter currently has an operation SQE in flight.
    ///
    /// Returns `false` for stale IDs and retained results.
    pub fn is_in_flight(&self, id: WaiterId) -> bool {
        self.get(id).is_some_and(|waiter| waiter.in_flight)
    }
}

#[cfg(test)]
pub mod tests {
    use super::*;
    use crate::{
        IoBuf, IoBufMut, IoBufs,
        iouring::{
            request::{
                Cache, ConnectRequest, PollRequest, ReadAtRequest, RecvRequest, SendRequest,
                SyncRequest,
            },
            slab::tests::set_generation,
        },
        storage::{hold::Hold, iouring::Shared},
    };
    use commonware_utils::channel::oneshot::error::TryRecvError;
    use std::{
        fs::File,
        net::{SocketAddr, TcpListener},
        os::{fd::OwnedFd, unix::net::UnixStream},
        panic::{AssertUnwindSafe, catch_unwind},
        sync::{
            Arc, OnceLock,
            atomic::{AtomicUsize, Ordering},
        },
        task::Wake,
    };

    /// Counts deferred wake invocations without touching worker state.
    #[derive(Default)]
    struct Counter(
        /// Number of times the waker was invoked.
        AtomicUsize,
    );

    impl Wake for Counter {
        fn wake(self: Arc<Self>) {
            self.0.fetch_add(1, Ordering::Relaxed);
        }
    }

    /// Build a full waiter identity without registering a request.
    pub fn waiter_id(index: u32, generation: u64) -> WaiterId {
        WaiterId(Id { index, generation })
    }

    /// Share one directory hold across the simulated file requests in this process.
    fn make_file(file: File) -> Arc<Shared> {
        static HOLD: OnceLock<Arc<Hold>> = OnceLock::new();
        let hold = HOLD.get_or_init(|| {
            Hold::acquire(
                &std::env::temp_dir()
                    .join(format!("commonware_waiter_test_{}", std::process::id())),
            )
            .unwrap()
        });
        Shared::detached(file, hold.clone())
    }

    /// Build a socket descriptor for SQE construction without kernel submission.
    fn make_socket_fd() -> OwnedFd {
        let (socket, _peer) = UnixStream::pair().unwrap();
        socket.into()
    }

    /// Build a `Sync` request backed by a socket fd so waiter tests can
    /// exercise slot lifecycle without submitting kernel work.
    fn make_sync_request() -> Request {
        let file = make_file(File::from(make_socket_fd()));
        file.tracker.write();
        file.tracker.complete();
        Request::Sync(SyncRequest::new(file))
    }

    /// Build a send that needs five bytes of progress before completing.
    fn make_send_request() -> Request {
        Request::Send(SendRequest {
            fd: Arc::new(make_socket_fd()),
            write: IoBufs::from(IoBuf::from(b"hello")).into(),
            deadline: None,
        })
    }

    /// Build an exact recv that needs five bytes of progress before completing.
    fn make_recv_request() -> Request {
        Request::Recv(RecvRequest {
            fd: Arc::new(make_socket_fd()),
            buf: IoBufMut::with_capacity(5),
            offset: 0,
            len: 5,
            exact: true,
            deadline: None,
        })
    }

    /// Build a file read that needs five bytes of progress before completing.
    fn make_read_request() -> Request {
        Request::ReadAt(ReadAtRequest::new(
            make_file(File::from(make_socket_fd())),
            0,
            IoBufMut::zeroed(5),
            Cache::Enabled,
        ))
    }

    /// Build a connect with an address that remains valid across retries.
    fn make_connect_request() -> Request {
        Request::Connect(ConnectRequest {
            fd: Arc::new(make_socket_fd()),
            address: Box::new("127.0.0.1:1234".parse::<SocketAddr>().unwrap().into()),
            deadline: None,
        })
    }

    /// Build a single readiness observation on a listener.
    fn make_poll_request() -> Request {
        Request::Poll(PollRequest {
            fd: Arc::new(TcpListener::bind("127.0.0.1:0").unwrap()),
            deadline: None,
        })
    }

    /// Local observation before the future installs its first waker.
    fn observer() -> Observer {
        Observer::Local(None)
    }

    /// Supply the driver's permit step before staging a simulated request.
    fn stage(waiters: &mut Waiters, id: WaiterId) -> SqueueEntry {
        let waiter = waiters.get(id).unwrap();
        if waiter.durability.is_none()
            && let Some(mutex) = waiter.request.durability()
        {
            let permit = mutex.clone().try_lock_owned().unwrap();
            assert!(waiters.acquire_durability(id, permit).is_none());
        }
        waiters.stage(id)
    }

    /// Apply a terminal simulated CQE and finish its request.
    fn complete(
        waiters: &mut Waiters,
        id: WaiterId,
        result: i32,
        deferred: &mut Deferred,
    ) -> Option<Tick> {
        let CompletionOutcome::Complete(current, result) =
            waiters.on_completion(id.user_data(), result)
        else {
            panic!("expected terminal completion");
        };
        assert_eq!(current, id);
        waiters.finish(id, result, deferred)
    }

    /// Consume a local result, failing if the request is still pending.
    fn output(waiters: &mut Waiters, id: WaiterId) -> RequestOutput {
        let Observation::Ready(output) = waiters.observe(id, Waker::noop()) else {
            panic!("expected retained output");
        };
        output
    }

    #[test]
    fn test_user_data_encoding() {
        // All index bits survive, while only the low 32 generation bits reach the kernel.
        for (index, generation, encoded) in [
            (0, 0, 0),
            (0x89ab_cdef, 0x0123_4567, 0x0123_4567_89ab_cdef),
            (7, 1 << 31, 0x8000_0000_0000_0007),
            (7, 1 << 32, 7),
            (u32::MAX - 1, u64::MAX, u64::MAX - 1),
        ] {
            let id = waiter_id(index, generation);
            assert_eq!(id.user_data(), encoded);
            assert_eq!(
                WaiterId::from_user_data(encoded),
                (index, generation as u32)
            );
        }
    }

    #[test]
    fn test_cqe_resolves_full_generation_after_kernel_wrap() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let id = waiters.insert(make_sync_request(), observer());
        let last = WaiterId(set_generation(&mut waiters.entries, id.0, u32::MAX as u64));
        waiters.finish(last, Err(Error::Closed), &mut deferred);
        drop(output(&mut waiters, last));

        let current = waiters.insert(make_sync_request(), observer());
        assert_eq!(current.0.generation, 1 << 32);

        // Kernel generations wrap while userspace IDs retain the full generation.
        assert_eq!(current.user_data(), id.user_data());
        assert!(!waiters.is_pending(id));
        assert!(!waiters.cancel(id));
        stage(&mut waiters, current);

        // Neither a different generation nor a duplicate CQE can retire this SQE.
        assert!(
            catch_unwind(AssertUnwindSafe(|| {
                waiters.on_completion(last.user_data(), 0)
            }))
            .is_err()
        );
        assert_eq!(waiters.in_flight(), 1);
        assert!(matches!(
            waiters.on_completion(current.user_data(), -libc::EINTR),
            CompletionOutcome::Requeue(id) if id == current
        ));
        assert_eq!(waiters.in_flight(), 0);
        assert!(
            catch_unwind(AssertUnwindSafe(|| {
                waiters.on_completion(current.user_data(), 0)
            }))
            .is_err()
        );

        stage(&mut waiters, current);
        complete(&mut waiters, current, 0, &mut deferred);
        assert!(waiters.is_empty());
        assert!(matches!(
            output(&mut waiters, current),
            RequestOutput::Sync(Ok(()))
        ));
    }

    #[test]
    fn test_retained_result_does_not_count_as_pending_or_recycle_early() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        assert!(waiters.is_empty());

        let first = waiters.insert(make_sync_request(), observer());
        waiters.set_deadline(first, 5);
        assert_eq!(waiters.len(), 1);
        stage(&mut waiters, first);
        assert_eq!(complete(&mut waiters, first, 0, &mut deferred), Some(5));

        // The live result keeps its ID but must disappear from all I/O queries.
        assert!(waiters.is_empty());
        assert!(!waiters.is_pending(first));
        assert!(!waiters.is_in_flight(first));
        assert_eq!(waiters.target_tick(first), None);
        assert_eq!(waiters.deadline(first), None);
        assert!(!waiters.cancel(first));
        assert!(catch_unwind(AssertUnwindSafe(|| waiters.stage(first))).is_err());
        assert!(
            catch_unwind(AssertUnwindSafe(
                || waiters.on_completion(first.user_data(), 0)
            ))
            .is_err()
        );

        let second = waiters.insert(make_sync_request(), observer());
        assert_ne!(first.0.index, second.0.index);
        assert!(matches!(
            output(&mut waiters, first),
            RequestOutput::Sync(Ok(()))
        ));

        // Consuming the result makes the slot reusable, with a different identity.
        let reused = waiters.insert(make_sync_request(), observer());
        assert_eq!(reused.0.index, first.0.index);
        assert_ne!(reused, first);
        assert!(!waiters.orphan(first, &mut deferred));
        assert!(waiters.is_pending(reused));
    }

    #[test]
    fn test_exhausted_generation_retires_slot_after_result_consumption() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let id = waiters.insert(make_sync_request(), observer());
        let exhausted = WaiterId(set_generation(&mut waiters.entries, id.0, u64::MAX));

        stage(&mut waiters, exhausted);
        complete(&mut waiters, exhausted, 0, &mut deferred);
        drop(output(&mut waiters, exhausted));

        // Consumption cannot put an exhausted slot back on the free list.
        let next = waiters.insert(make_sync_request(), observer());
        assert_ne!(next.0.index, exhausted.0.index);
        assert_eq!(waiters.in_flight(), 0);
    }

    #[test]
    fn test_observer_refresh_and_completion_defer_waking() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let id = waiters.insert(make_sync_request(), observer());
        let counter = Arc::new(Counter::default());
        let waker = Waker::from(counter.clone());

        assert!(matches!(waiters.observe(id, &waker), Observation::Refresh));
        assert!(waiters.set_waker(id, waker.clone()).is_none());
        assert!(matches!(waiters.observe(id, &waker), Observation::Pending));

        let other = Waker::from(Arc::new(Counter::default()));
        assert!(matches!(waiters.observe(id, &other), Observation::Refresh));
        assert!(
            waiters
                .set_waker(id, other.clone())
                .unwrap()
                .will_wake(&waker)
        );
        assert!(waiters.set_waker(id, waker).unwrap().will_wake(&other));

        // Completion stores the result immediately, but waking is deferred.
        waiters.finish(id, Err(Error::Closed), &mut deferred);
        assert_eq!(counter.0.load(Ordering::Relaxed), 0);
        assert_eq!(deferred.wakes.len(), 1);

        deferred.wakes.pop().unwrap().wake();
        assert_eq!(counter.0.load(Ordering::Relaxed), 1);
        assert!(matches!(
            output(&mut waiters, id),
            RequestOutput::Sync(Err(Error::Closed))
        ));
    }

    #[test]
    fn test_cancellation_waits_for_operation_completion() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let id = waiters.insert(make_sync_request(), observer());
        waiters.set_deadline(id, 2);
        stage(&mut waiters, id);
        assert!(waiters.cancel(id));
        assert!(!waiters.cancel(id));

        // Cancellation cannot release resources before the operation's CQE.
        assert!(catch_unwind(AssertUnwindSafe(|| waiters.stage(id))).is_err());
        assert!(
            catch_unwind(AssertUnwindSafe(|| {
                waiters.finish(id, Err(Error::Closed), &mut deferred)
            }))
            .is_err()
        );
        assert_eq!(waiters.in_flight(), 1);

        assert_eq!(complete(&mut waiters, id, 0, &mut deferred), None);
        assert_eq!(waiters.in_flight(), 0);
        assert!(matches!(
            output(&mut waiters, id),
            RequestOutput::Sync(Ok(()))
        ));
    }

    #[test]
    fn test_invalid_ids() {
        let mut waiters = Waiters::new(1);

        for id in [waiter_id(0, 0), waiter_id(7, 0)] {
            assert!(!waiters.is_pending(id));
            assert!(!waiters.cancel(id));
            assert!(!waiters.is_in_flight(id));
            assert!(catch_unwind(AssertUnwindSafe(|| waiters.stage(id))).is_err());
            assert!(
                catch_unwind(AssertUnwindSafe(|| waiters.on_completion(id.user_data(), 0)))
                    .is_err()
            );
        }
    }

    #[test]
    fn test_failed_sqe_construction_keeps_request_unsubmitted() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let mut request = make_recv_request();
        let Request::Recv(recv) = &mut request else {
            unreachable!()
        };
        recv.len = 6;
        let id = waiters.insert(request, observer());

        // SQE construction rejects a target larger than the owned buffer.
        assert!(catch_unwind(AssertUnwindSafe(|| waiters.stage(id))).is_err());
        assert!(!waiters.is_in_flight(id));
        assert_eq!(waiters.in_flight(), 0);

        waiters.finish(id, Err(Error::RecvFailed), &mut deferred);
        assert!(matches!(
            output(&mut waiters, id),
            RequestOutput::Recv(Err((_, Error::RecvFailed)))
        ));
    }

    #[test]
    fn test_cancelled_network_requests_do_not_requeue() {
        for (request, progress, result) in [
            (make_send_request(), Some(2), -libc::EAGAIN),
            (make_send_request(), Some(2), 1),
            (make_recv_request(), Some(3), -libc::EINTR),
            (make_recv_request(), Some(3), 1),
            (make_connect_request(), None, -libc::EALREADY),
            (make_connect_request(), None, -libc::EAGAIN),
            (make_connect_request(), None, -libc::EINTR),
            (make_poll_request(), None, -libc::EINTR),
        ] {
            let mut waiters = Waiters::new(1);
            let mut deferred = Deferred::default();
            let id = waiters.insert(request, observer());
            stage(&mut waiters, id);

            // Exercise cancellation after earlier SQEs have made progress too.
            if let Some(progress) = progress {
                assert!(matches!(
                    waiters.on_completion(id.user_data(), progress),
                    CompletionOutcome::Requeue(current) if current == id
                ));
                stage(&mut waiters, id);
            }

            assert!(waiters.cancel(id));
            assert!(matches!(
                waiters.on_completion(id.user_data(), result),
                CompletionOutcome::Complete(current, Err(Error::Timeout)) if current == id
            ));
            assert_eq!(waiters.in_flight(), 0);

            // Cancellation still leaves a local result for the waiting future.
            waiters.finish(id, Err(Error::Timeout), &mut deferred);
            assert!(waiters.is_empty());
            assert!(matches!(
                output(&mut waiters, id),
                RequestOutput::Send(Err(Error::Timeout))
                    | RequestOutput::Recv(Err((_, Error::Timeout)))
                    | RequestOutput::Connect(Err(Error::Timeout))
                    | RequestOutput::Poll(Err(Error::Timeout))
            ));
        }
    }

    #[test]
    fn test_cancellation_preserves_terminal_results() {
        for (request, result) in [
            (make_send_request(), 5),
            (make_recv_request(), 5),
            (make_connect_request(), 0),
            (make_connect_request(), -libc::EISCONN),
            (make_poll_request(), libc::POLLIN as i32),
        ] {
            let mut waiters = Waiters::new(1);
            let id = waiters.insert(request, observer());
            stage(&mut waiters, id);
            assert!(waiters.cancel(id));

            // Cancellation can lose the race with a successful operation.
            assert!(matches!(
                waiters.on_completion(id.user_data(), result),
                CompletionOutcome::Complete(current, Ok(())) if current == id
            ));
            assert_eq!(waiters.in_flight(), 0);
        }

        let mut waiters = Waiters::new(1);
        let id = waiters.insert(make_send_request(), observer());
        stage(&mut waiters, id);
        assert!(waiters.cancel(id));

        // An operation's terminal error also takes precedence over Timeout.
        assert!(matches!(
            waiters.on_completion(id.user_data(), -libc::EPIPE),
            CompletionOutcome::Complete(current, Err(Error::SendFailed)) if current == id
        ));
        assert_eq!(waiters.in_flight(), 0);
    }

    #[test]
    fn test_orphaned_reads_and_sends_stop_before_staging_or_after_partial_completion() {
        let requests: [fn() -> Request; 3] =
            [make_send_request, make_recv_request, make_read_request];

        for request in requests {
            let mut waiters = Waiters::new(1);
            let mut deferred = Deferred::default();
            let id = waiters.insert(request(), observer());

            assert!(waiters.orphan(id, &mut deferred));
            assert!(waiters.cancel(id));

            // The driver retires queued cancellations without staging an SQE.
            assert_eq!(waiters.finish(id, Err(Error::Timeout), &mut deferred), None);
            assert!(waiters.is_empty());

            for result in [-libc::EAGAIN, 2] {
                let id = waiters.insert(request(), observer());
                stage(&mut waiters, id);
                assert!(waiters.orphan(id, &mut deferred));
                assert!(!waiters.orphan(id, &mut deferred));
                assert!(waiters.cancel(id));

                // Partial progress and retryable errors cannot revive a
                // request whose observer already requested cancellation.
                assert_eq!(complete(&mut waiters, id, result, &mut deferred), None);
                assert!(waiters.is_empty());
            }
        }
    }

    #[test]
    fn test_queued_timeout_retains_result_until_drop() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let deadline = Instant::now();
        let mut request = make_recv_request();
        let Request::Recv(recv) = &mut request else {
            unreachable!()
        };
        recv.deadline = Some(deadline);
        let id = waiters.insert(request, observer());
        assert_eq!(waiters.deadline(id), Some(deadline));
        assert_eq!(waiters.target_tick(id), None);

        // The driver installs a wheel tick separately from the request deadline.
        waiters.set_deadline(id, 7);
        assert_eq!(waiters.target_tick(id), Some(7));
        assert!(waiters.cancel(id));
        assert_eq!(waiters.target_tick(id), None);
        assert_eq!(waiters.deadline(id), Some(deadline));
        assert!(catch_unwind(AssertUnwindSafe(|| waiters.stage(id))).is_err());
        assert!(!waiters.is_in_flight(id));
        assert_eq!(waiters.finish(id, Err(Error::Timeout), &mut deferred), None);
        assert!(waiters.is_empty());
        assert!(!waiters.is_pending(id));

        // Dropping the future after completion releases its retained output.
        assert!(!waiters.orphan(id, &mut deferred));
        assert!(matches!(
            deferred.outputs.pop(),
            Some(RequestOutput::Recv(Err((_, Error::Timeout))))
        ));

        let next = waiters.insert(make_recv_request(), observer());
        assert_eq!(id.0.index, next.0.index);
        assert_ne!(id, next);
    }

    #[test]
    fn test_close_defers_local_and_forwarded_notifications() {
        // Register two pending reads and transfer one observer to a channel.
        // Distinct notification targets identify each shutdown path independently.
        let mut waiters = Waiters::new(2);
        let mut deferred = Deferred::default();
        let counter = Arc::new(Counter::default());
        let waker = Waker::from(counter.clone());
        let local = waiters.insert(make_recv_request(), observer());
        assert!(waiters.set_waker(local, waker.clone()).is_none());
        let forwarded = waiters.insert(make_recv_request(), observer());
        let (sender, mut receiver) = oneshot::channel();
        waiters.forward(forwarded, sender, &mut deferred);
        assert!(deferred.is_empty());

        // Closure detaches both observers and requests cancellation. Notifications
        // must remain deferred so callbacks cannot run under the worker borrow.
        let cancel = waiters.close(&mut deferred);
        assert_eq!(cancel.len(), 2);
        assert!(cancel.contains(&local));
        assert!(cancel.contains(&forwarded));
        assert_eq!(deferred.wakes.len(), 1);
        assert!(deferred.wakes[0].will_wake(&waker));
        assert!(deferred.drops.is_empty());
        assert_eq!(deferred.results.len(), 1);
        assert_eq!(counter.0.load(Ordering::Relaxed), 0);
        assert!(matches!(receiver.try_recv(), Err(TryRecvError::Empty)));

        // Run the deferred actions and verify each observer receives its notification.
        deferred.wakes.pop().unwrap().wake();
        assert_eq!(counter.0.load(Ordering::Relaxed), 1);
        let (sender, result) = deferred.results.pop().unwrap();
        assert!(sender.send(result).is_ok());
        assert!(matches!(receiver.try_recv(), Ok(Err(Error::Closed))));
        assert!(deferred.is_empty());
    }

    #[test]
    fn test_close_clears_results_and_keeps_unobserved_syncs() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let pending = waiters.insert(make_recv_request(), observer());
        let sync = waiters.insert(make_sync_request(), observer());
        let ready = waiters.insert(make_recv_request(), observer());
        waiters.finish(ready, Err(Error::Timeout), &mut deferred);

        let (sender, receiver) = oneshot::channel();
        let detached = waiters.insert(make_sync_request(), Observer::DetachedSync(sender));

        assert_eq!(waiters.close(&mut deferred), vec![pending]);
        assert!(!waiters.is_pending(ready));
        assert!(!waiters.orphan(sync, &mut deferred));
        assert_eq!(waiters.len(), 3);

        // Closing removes observers without cancelling committed sync work.
        stage(&mut waiters, sync);
        assert!(
            matches!(waiters.on_completion(sync.user_data(), -libc::EINTR), CompletionOutcome::Requeue(id) if id == sync)
        );
        stage(&mut waiters, sync);
        complete(&mut waiters, sync, 0, &mut deferred);

        stage(&mut waiters, detached);
        complete(&mut waiters, detached, 0, &mut deferred);

        assert!(waiters.cancel(pending));
        waiters.finish(pending, Err(Error::Timeout), &mut deferred);
        assert!(waiters.is_empty());
        assert_eq!(waiters.entries.len(), 0);

        // Detached results are published after leaving the worker borrow.
        let (sender, result) = deferred.completions.pop().unwrap();
        sender.send(result).unwrap();
        assert!(futures::executor::block_on(receiver).unwrap().is_ok());
    }

    #[test]
    fn test_growth_preserves_in_flight_identity_and_counts() {
        let mut waiters = Waiters::new(1);
        let mut deferred = Deferred::default();
        let first = waiters.insert(make_sync_request(), observer());
        stage(&mut waiters, first);

        // Growing the slab cannot change the identity already handed to the kernel.
        for _ in 0..64 {
            waiters.insert(make_sync_request(), observer());
        }
        assert_eq!(waiters.len(), 65);
        assert_eq!(waiters.in_flight(), 1);
        assert!(waiters.is_in_flight(first));

        complete(&mut waiters, first, 0, &mut deferred);
        assert_eq!(waiters.len(), 64);
        assert_eq!(waiters.in_flight(), 0);
    }
}