codegraph-ruby 0.1.2

Ruby parser for CodeGraph - extracts code entities and relationships from Ruby source files
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
//! AST visitor for extracting Ruby entities

use codegraph_parser_api::{
    CallRelation, ClassEntity, FunctionEntity, ImplementationRelation, ImportRelation,
    InheritanceRelation, Parameter, ParserConfig, TraitEntity,
};
use tree_sitter::Node;

pub struct RubyVisitor<'a> {
    pub source: &'a [u8],
    #[allow(dead_code)]
    pub config: ParserConfig,
    pub functions: Vec<FunctionEntity>,
    pub classes: Vec<ClassEntity>,
    pub traits: Vec<TraitEntity>,
    pub imports: Vec<ImportRelation>,
    pub calls: Vec<CallRelation>,
    pub inheritance: Vec<InheritanceRelation>,
    pub implementations: Vec<ImplementationRelation>,
    current_module: Option<String>,
    current_class: Option<String>,
    current_function: Option<String>,
}

impl<'a> RubyVisitor<'a> {
    pub fn new(source: &'a [u8], config: ParserConfig) -> Self {
        Self {
            source,
            config,
            functions: Vec::new(),
            classes: Vec::new(),
            traits: Vec::new(),
            imports: Vec::new(),
            calls: Vec::new(),
            inheritance: Vec::new(),
            implementations: Vec::new(),
            current_module: None,
            current_class: None,
            current_function: None,
        }
    }

    fn node_text(&self, node: Node) -> String {
        node.utf8_text(self.source).unwrap_or("").to_string()
    }

    pub fn visit_node(&mut self, node: Node) {
        let should_recurse = match node.kind() {
            "method" => {
                self.visit_method(node);
                false // Don't recurse, visit_method handles body
            }
            "singleton_method" => {
                self.visit_singleton_method(node);
                false
            }
            "class" => {
                self.visit_class(node);
                false // visit_class handles body itself
            }
            "singleton_class" => {
                self.visit_singleton_class(node);
                false
            }
            "module" => {
                self.visit_module(node);
                false // visit_module handles body itself
            }
            "call" => {
                self.visit_call(node);
                true // Recurse to find nested calls
            }
            _ => true, // Recurse into other nodes
        };

        if should_recurse {
            let mut cursor = node.walk();
            for child in node.children(&mut cursor) {
                self.visit_node(child);
            }
        }
    }

    fn visit_method(&mut self, node: Node) {
        let name = node
            .child_by_field_name("name")
            .map(|n| self.node_text(n))
            .unwrap_or_else(|| "method".to_string());

        let parameters = self.extract_parameters(node);
        let doc_comment = self.extract_doc_comment(node);

        // Determine visibility based on context
        let visibility = "public".to_string(); // Default in Ruby

        let func = FunctionEntity {
            name: name.clone(),
            signature: self.extract_method_signature(node),
            visibility,
            line_start: node.start_position().row + 1,
            line_end: node.end_position().row + 1,
            is_async: false,
            is_test: self.has_test_annotation(&name),
            is_static: false,
            is_abstract: false,
            parameters,
            return_type: None, // Ruby doesn't have return types
            doc_comment,
            attributes: Vec::new(),
            parent_class: self.current_class.clone(),
            complexity: None,
        };

        self.functions.push(func);

        // Set current function context and visit body to extract calls
        let previous_function = self.current_function.take();
        self.current_function = Some(name);

        // Look for body_statement (Ruby's method body node)
        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            if child.kind() == "body_statement" {
                self.visit_method_body(child);
                break;
            }
        }

        self.current_function = previous_function;
    }

    fn visit_singleton_method(&mut self, node: Node) {
        // Singleton methods: def self.method_name
        let name = node
            .child_by_field_name("name")
            .map(|n| self.node_text(n))
            .unwrap_or_else(|| "method".to_string());

        let parameters = self.extract_parameters(node);
        let doc_comment = self.extract_doc_comment(node);

        let func = FunctionEntity {
            name: name.clone(),
            signature: self.extract_method_signature(node),
            visibility: "public".to_string(),
            line_start: node.start_position().row + 1,
            line_end: node.end_position().row + 1,
            is_async: false,
            is_test: self.has_test_annotation(&name),
            is_static: true, // Singleton methods are class methods
            is_abstract: false,
            parameters,
            return_type: None,
            doc_comment,
            attributes: vec!["singleton".to_string()],
            parent_class: self.current_class.clone(),
            complexity: None,
        };

        self.functions.push(func);

        // Set current function context and visit body to extract calls
        let previous_function = self.current_function.take();
        self.current_function = Some(name);

        // Look for body_statement (Ruby's method body node)
        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            if child.kind() == "body_statement" {
                self.visit_method_body(child);
                break;
            }
        }

        self.current_function = previous_function;
    }

    fn visit_class(&mut self, node: Node) {
        let name = node
            .child_by_field_name("name")
            .map(|n| self.node_text(n))
            .unwrap_or_else(|| "Class".to_string());

        let qualified_name = self.qualify_name(&name);
        let doc_comment = self.extract_doc_comment(node);

        // Extract superclass
        let mut base_classes = Vec::new();
        if let Some(superclass) = node.child_by_field_name("superclass") {
            // The superclass node contains "< ClassName" - extract the constant
            let mut cursor = superclass.walk();
            for child in superclass.children(&mut cursor) {
                if child.kind() == "constant" || child.kind() == "scope_resolution" {
                    let parent_name = self.node_text(child);
                    base_classes.push(parent_name.clone());
                    self.inheritance.push(InheritanceRelation {
                        child: qualified_name.clone(),
                        parent: parent_name,
                        order: 0,
                    });
                    break;
                }
            }
        }

        let class_entity = ClassEntity {
            name: qualified_name.clone(),
            visibility: "public".to_string(),
            line_start: node.start_position().row + 1,
            line_end: node.end_position().row + 1,
            is_abstract: false,
            is_interface: false,
            base_classes,
            implemented_traits: Vec::new(),
            methods: Vec::new(),
            fields: Vec::new(),
            doc_comment,
            attributes: Vec::new(),
            type_parameters: Vec::new(),
        };

        self.classes.push(class_entity);

        // Set current class context for method extraction
        let previous_class = self.current_class.take();
        self.current_class = Some(qualified_name.clone());

        // Visit class body to extract methods and module inclusions
        if let Some(body) = node.child_by_field_name("body") {
            self.visit_class_body(body, &qualified_name);
        }

        self.current_class = previous_class;
    }

    fn visit_singleton_class(&mut self, node: Node) {
        // class << self - singleton class block
        // Visit body to extract class methods
        if let Some(body) = node.child_by_field_name("body") {
            let mut cursor = body.walk();
            for child in body.children(&mut cursor) {
                match child.kind() {
                    "method" => {
                        // Methods in singleton_class are class methods
                        self.visit_method(child);
                        // Mark the last added method as static
                        if let Some(last_func) = self.functions.last_mut() {
                            last_func.is_static = true;
                            last_func.attributes.push("singleton".to_string());
                        }
                    }
                    _ => self.visit_node(child),
                }
            }
        }
    }

    fn visit_class_body(&mut self, node: Node, class_name: &str) {
        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            match child.kind() {
                "method" => self.visit_method(child),
                "singleton_method" => self.visit_singleton_method(child),
                "singleton_class" => self.visit_singleton_class(child),
                "class" => self.visit_class(child), // Nested class
                "module" => self.visit_module(child), // Nested module
                "call" => {
                    // Check for include/extend/prepend
                    self.check_module_inclusion(child, class_name);
                    self.visit_call(child);
                }
                _ => self.visit_node(child),
            }
        }
    }

    fn check_module_inclusion(&mut self, node: Node, class_name: &str) {
        if let Some(method_node) = node.child_by_field_name("method") {
            let method_name = self.node_text(method_node);
            if method_name == "include" || method_name == "extend" || method_name == "prepend" {
                // Extract the module name from arguments
                if let Some(args) = node.child_by_field_name("arguments") {
                    let mut cursor = args.walk();
                    for arg in args.children(&mut cursor) {
                        if arg.kind() == "constant" || arg.kind() == "scope_resolution" {
                            let module_name = self.node_text(arg);
                            self.implementations.push(ImplementationRelation {
                                implementor: class_name.to_string(),
                                trait_name: module_name,
                            });
                        }
                    }
                }
            }
        }
    }

    fn visit_module(&mut self, node: Node) {
        let name = node
            .child_by_field_name("name")
            .map(|n| self.node_text(n))
            .unwrap_or_else(|| "Module".to_string());

        let qualified_name = self.qualify_name(&name);
        let doc_comment = self.extract_doc_comment(node);

        // Extract methods to determine required_methods
        let required_methods = Vec::new();

        let trait_entity = TraitEntity {
            name: qualified_name.clone(),
            visibility: "public".to_string(),
            line_start: node.start_position().row + 1,
            line_end: node.end_position().row + 1,
            required_methods,
            parent_traits: Vec::new(),
            doc_comment,
            attributes: Vec::new(),
        };

        self.traits.push(trait_entity);

        // Set current module context
        let previous_module = self.current_module.take();
        let previous_class = self.current_class.take();
        self.current_module = Some(qualified_name.clone());
        self.current_class = Some(qualified_name); // Modules can have methods

        // Visit module body to extract methods
        if let Some(body) = node.child_by_field_name("body") {
            let mut cursor = body.walk();
            for child in body.children(&mut cursor) {
                match child.kind() {
                    "method" => self.visit_method(child),
                    "singleton_method" => self.visit_singleton_method(child),
                    "class" => self.visit_class(child),
                    "module" => self.visit_module(child),
                    _ => self.visit_node(child),
                }
            }
        }

        self.current_module = previous_module;
        self.current_class = previous_class;
    }

    fn visit_call(&mut self, node: Node) {
        // Check for require/require_relative statements
        if let Some(method_node) = node.child_by_field_name("method") {
            let method_name = self.node_text(method_node);
            if method_name == "require" || method_name == "require_relative" {
                self.visit_require(node, &method_name);
                return;
            }
        }

        // Extract call relationship if we're inside a function
        if let Some(ref caller) = self.current_function.clone() {
            let callee = self.extract_callee_name(node);

            // Skip empty callees or self-references
            if !callee.is_empty() && callee != "self" {
                let call = CallRelation {
                    caller: caller.clone(),
                    callee,
                    call_site_line: node.start_position().row + 1,
                    is_direct: true,
                };
                self.calls.push(call);
            }
        }
    }

    fn visit_require(&mut self, node: Node, method_name: &str) {
        if let Some(args) = node.child_by_field_name("arguments") {
            let mut cursor = args.walk();
            for arg in args.children(&mut cursor) {
                if arg.kind() == "string" || arg.kind() == "string_content" {
                    let mut imported = self.node_text(arg);
                    // Remove quotes
                    imported = imported.trim_matches(|c| c == '\'' || c == '"').to_string();

                    let import = ImportRelation {
                        importer: self
                            .current_module
                            .clone()
                            .unwrap_or_else(|| "main".to_string()),
                        imported,
                        symbols: Vec::new(),
                        is_wildcard: false,
                        alias: None,
                    };

                    // Mark require_relative differently if needed
                    if method_name == "require_relative" {
                        // Could add attribute to distinguish
                    }

                    self.imports.push(import);
                }
            }
        }
    }

    fn extract_callee_name(&self, node: Node) -> String {
        // For a call node, extract the method being called
        if let Some(method_node) = node.child_by_field_name("method") {
            let method_name = self.node_text(method_node);

            // Check if there's a receiver
            if let Some(receiver) = node.child_by_field_name("receiver") {
                let receiver_text = self.node_text(receiver);
                if receiver_text != "self" {
                    return method_name; // Just return method name for instance calls
                }
            }
            return method_name;
        }
        String::new()
    }

    fn visit_method_body(&mut self, node: Node) {
        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            match child.kind() {
                "call" => {
                    self.visit_call(child);
                    self.visit_method_body(child);
                }
                "identifier" => {
                    // In Ruby, a bare identifier can be a method call
                    // Record it as a potential call if we're in a function context
                    if let Some(ref caller) = self.current_function.clone() {
                        let callee = self.node_text(child);
                        // Skip if it looks like a local variable (lowercase, no special chars)
                        // But simple method calls like `helper` are also lowercase, so we include them
                        if !callee.is_empty() && callee != "self" {
                            let call = CallRelation {
                                caller: caller.clone(),
                                callee,
                                call_site_line: child.start_position().row + 1,
                                is_direct: true,
                            };
                            self.calls.push(call);
                        }
                    }
                }
                _ => {
                    self.visit_method_body(child);
                }
            }
        }
    }

    fn extract_parameters(&self, node: Node) -> Vec<Parameter> {
        let mut params = Vec::new();
        if let Some(params_node) = node.child_by_field_name("parameters") {
            let mut cursor = params_node.walk();
            for child in params_node.children(&mut cursor) {
                match child.kind() {
                    "identifier" => {
                        params.push(Parameter::new(self.node_text(child)));
                    }
                    "optional_parameter" => {
                        if let Some(name_node) = child.child_by_field_name("name") {
                            let mut param = Parameter::new(self.node_text(name_node));
                            if let Some(value_node) = child.child_by_field_name("value") {
                                param = param.with_default(self.node_text(value_node));
                            }
                            params.push(param);
                        }
                    }
                    "splat_parameter" => {
                        // *args
                        let mut inner_cursor = child.walk();
                        for inner in child.children(&mut inner_cursor) {
                            if inner.kind() == "identifier" {
                                params.push(Parameter::new(self.node_text(inner)).variadic());
                            }
                        }
                    }
                    "hash_splat_parameter" => {
                        // **kwargs - treat as variadic
                        let mut inner_cursor = child.walk();
                        for inner in child.children(&mut inner_cursor) {
                            if inner.kind() == "identifier" {
                                params.push(Parameter::new(self.node_text(inner)).variadic());
                            }
                        }
                    }
                    "block_parameter" => {
                        // &block
                        let mut inner_cursor = child.walk();
                        for inner in child.children(&mut inner_cursor) {
                            if inner.kind() == "identifier" {
                                params.push(Parameter::new(self.node_text(inner)));
                            }
                        }
                    }
                    "keyword_parameter" => {
                        if let Some(name_node) = child.child_by_field_name("name") {
                            let mut param = Parameter::new(self.node_text(name_node));
                            if let Some(value_node) = child.child_by_field_name("value") {
                                param = param.with_default(self.node_text(value_node));
                            }
                            params.push(param);
                        }
                    }
                    _ => {}
                }
            }
        }
        params
    }

    fn extract_method_signature(&self, node: Node) -> String {
        self.node_text(node)
            .lines()
            .next()
            .unwrap_or("")
            .to_string()
    }

    fn extract_doc_comment(&self, node: Node) -> Option<String> {
        // Look for preceding comment node
        if let Some(prev) = node.prev_sibling() {
            if prev.kind() == "comment" {
                return Some(self.node_text(prev));
            }
        }
        None
    }

    fn has_test_annotation(&self, name: &str) -> bool {
        name.starts_with("test_") || name.starts_with("it_") || name.starts_with("should_")
    }

    fn qualify_name(&self, name: &str) -> String {
        if let Some(ref module) = self.current_module {
            format!("{}::{}", module, name)
        } else {
            name.to_string()
        }
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    fn parse_and_visit(source: &[u8]) -> RubyVisitor<'_> {
        use tree_sitter::Parser;

        let mut parser = Parser::new();
        parser.set_language(&tree_sitter_ruby::language()).unwrap();
        let tree = parser.parse(source, None).unwrap();

        let mut visitor = RubyVisitor::new(source, ParserConfig::default());
        visitor.visit_node(tree.root_node());
        visitor
    }

    #[allow(dead_code)]
    fn print_tree(node: tree_sitter::Node, source: &str, depth: usize) {
        let indent = "  ".repeat(depth);
        let text: String = node
            .utf8_text(source.as_bytes())
            .unwrap_or("")
            .chars()
            .take(40)
            .collect();
        eprintln!("{}{}: {:?}", indent, node.kind(), text);

        let mut cursor = node.walk();
        for child in node.children(&mut cursor) {
            print_tree(child, source, depth + 1);
        }
    }

    #[test]
    fn test_debug_tree_structure() {
        use tree_sitter::Parser;

        let mut parser = Parser::new();
        parser.set_language(&tree_sitter_ruby::language()).unwrap();

        let sources = [
            ("inheritance", "class Animal\nend\nclass Dog < Animal\nend"),
            ("method_calls", "class MyClass\n  def caller\n    helper\n    process\n  end\n  def helper\n  end\n  def process\n  end\nend"),
            ("singleton_method", "class Helper\n  def self.format(str)\n    str.strip\n  end\nend"),
        ];

        for (name, source) in sources {
            let tree = parser.parse(source.as_bytes(), None).unwrap();
            eprintln!("\n=== {} ===", name);
            print_tree(tree.root_node(), source, 0);
        }
    }

    #[test]
    fn test_visitor_basics() {
        let visitor = RubyVisitor::new(b"", ParserConfig::default());
        assert_eq!(visitor.functions.len(), 0);
        assert_eq!(visitor.classes.len(), 0);
        assert_eq!(visitor.traits.len(), 0);
    }

    #[test]
    fn test_visitor_method_extraction() {
        let source = b"def greet(name)\n  puts \"Hello, #{name}\"\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.functions.len(), 1);
        assert_eq!(visitor.functions[0].name, "greet");
    }

    #[test]
    fn test_visitor_class_extraction() {
        let source = b"class Person\n  attr_accessor :name\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.classes.len(), 1);
        assert_eq!(visitor.classes[0].name, "Person");
    }

    #[test]
    fn test_visitor_module_extraction() {
        let source = b"module Loggable\n  def log(msg)\n    puts msg\n  end\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.traits.len(), 1);
        assert_eq!(visitor.traits[0].name, "Loggable");
    }

    #[test]
    fn test_visitor_class_method_extraction() {
        let source = b"class Calculator\n  def add(a, b)\n    a + b\n  end\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.classes.len(), 1);
        assert_eq!(visitor.functions.len(), 1);
        assert_eq!(visitor.functions[0].name, "add");
        assert_eq!(
            visitor.functions[0].parent_class,
            Some("Calculator".to_string())
        );
    }

    #[test]
    fn test_visitor_require_extraction() {
        let source = b"require 'json'\nrequire_relative './helper'";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.imports.len(), 2);
        assert_eq!(visitor.imports[0].imported, "json");
        assert_eq!(visitor.imports[1].imported, "./helper");
    }

    #[test]
    fn test_visitor_inheritance() {
        let source = b"class Animal\nend\nclass Dog < Animal\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.classes.len(), 2);
        assert_eq!(visitor.inheritance.len(), 1);
        assert_eq!(visitor.inheritance[0].child, "Dog");
        assert_eq!(visitor.inheritance[0].parent, "Animal");
    }

    #[test]
    fn test_visitor_module_inclusion() {
        let source = b"module Walkable\nend\nclass Person\n  include Walkable\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.traits.len(), 1);
        assert_eq!(visitor.classes.len(), 1);
        assert!(visitor
            .implementations
            .iter()
            .any(|i| i.implementor == "Person" && i.trait_name == "Walkable"));
    }

    #[test]
    fn test_visitor_singleton_method() {
        let source = b"class Helper\n  def self.format(str)\n    str.strip\n  end\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.classes.len(), 1);
        assert_eq!(visitor.functions.len(), 1);
        assert!(visitor.functions[0].is_static);
    }

    #[test]
    fn test_visitor_method_call_extraction() {
        let source = b"
class MyClass
  def caller
    helper
    process
  end

  def helper
  end

  def process
  end
end
";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.classes.len(), 1);
        assert_eq!(visitor.functions.len(), 3);
        assert_eq!(visitor.calls.len(), 2);

        assert!(visitor
            .calls
            .iter()
            .any(|c| c.caller == "caller" && c.callee == "helper"));
        assert!(visitor
            .calls
            .iter()
            .any(|c| c.caller == "caller" && c.callee == "process"));
    }

    #[test]
    fn test_visitor_call_line_numbers() {
        let source = b"
class Test
  def caller
    helper
  end
  def helper
  end
end
";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.calls.len(), 1);
        assert_eq!(visitor.calls[0].caller, "caller");
        assert_eq!(visitor.calls[0].callee, "helper");
        assert_eq!(visitor.calls[0].call_site_line, 4);
        assert!(visitor.calls[0].is_direct);
    }

    #[test]
    fn test_visitor_optional_parameters() {
        let source = b"def greet(name, greeting = 'Hello')\n  puts \"#{greeting}, #{name}\"\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.functions.len(), 1);
        assert_eq!(visitor.functions[0].parameters.len(), 2);
    }

    #[test]
    fn test_visitor_nested_module() {
        let source = b"module Outer\n  module Inner\n    def method\n    end\n  end\nend";
        let visitor = parse_and_visit(source);

        assert_eq!(visitor.traits.len(), 2);
        assert!(visitor.traits.iter().any(|t| t.name == "Outer"));
        assert!(visitor.traits.iter().any(|t| t.name == "Outer::Inner"));
    }
}