codanna 0.9.19

Code Intelligence for Large Language Models
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
//! Language parser factory with configuration-based instantiation.
//!
//! Creates LanguageParser instances based on Language enum and Settings.
//! Validates language enablement and provides discovery of supported languages.

use super::{
    CBehavior, CParser, CSharpBehavior, CSharpParser, ClojureBehavior, ClojureParser, CppBehavior,
    CppParser, GdscriptBehavior, GdscriptParser, GoBehavior, GoParser, JavaBehavior, JavaParser,
    JavaScriptBehavior, JavaScriptParser, KotlinBehavior, KotlinParser, Language, LanguageBehavior,
    LanguageId, LanguageParser, LuaBehavior, LuaParser, PhpBehavior, PhpParser, PythonBehavior,
    PythonParser, RustBehavior, RustParser, SwiftBehavior, SwiftParser, TypeScriptBehavior,
    TypeScriptParser, get_registry,
};
use crate::{IndexError, IndexResult, Settings};
use std::sync::Arc;

/// A parser paired with its language-specific behavior
pub struct ParserWithBehavior {
    pub parser: Box<dyn LanguageParser>,
    pub behavior: Box<dyn LanguageBehavior>,
}

/// Parser factory that creates LanguageParser instances based on configuration.
///
/// Validates language support and configuration before instantiation.
/// Currently supports: Rust (full), Python/JS/TS (placeholder).
#[derive(Debug)]
pub struct ParserFactory {
    settings: Arc<Settings>,
}

impl ParserFactory {
    /// Creates factory instance with shared configuration.
    ///
    /// Args: settings - Arc-wrapped Settings for thread-safe access across parsing tasks.
    pub fn new(settings: Arc<Settings>) -> Self {
        Self { settings }
    }

    // ========== Registry-based methods (new approach) ==========

    /// Creates parser using the registry system
    ///
    /// This method uses the global language registry instead of hardcoded match statements.
    /// It will eventually replace create_parser() once migration is complete.
    #[must_use = "Parser creation may fail and should be handled"]
    pub fn create_parser_from_registry(
        &self,
        language_id: LanguageId,
    ) -> IndexResult<Box<dyn LanguageParser>> {
        let registry = get_registry();
        let registry = registry
            .lock()
            .map_err(|e| IndexError::General(format!("Failed to acquire registry lock: {e}")))?;

        registry
            .create_parser(language_id, &self.settings)
            .map_err(|e| IndexError::General(e.to_string()))
    }

    /// Creates parser with behavior using the registry system
    ///
    /// This method uses the global language registry instead of hardcoded match statements.
    /// It will eventually replace create_parser_with_behavior() once migration is complete.
    pub fn create_parser_with_behavior_from_registry(
        &self,
        language_id: LanguageId,
    ) -> IndexResult<ParserWithBehavior> {
        let registry = get_registry();
        let registry = registry
            .lock()
            .map_err(|e| IndexError::General(format!("Failed to acquire registry lock: {e}")))?;

        let (parser, behavior) = registry
            .create_parser_with_behavior(language_id, &self.settings)
            .map_err(|e| IndexError::General(e.to_string()))?;

        Ok(ParserWithBehavior { parser, behavior })
    }

    /// Checks if a language is enabled using the registry
    pub fn is_language_enabled_in_registry(&self, language_id: LanguageId) -> bool {
        let registry = get_registry();
        if let Ok(registry) = registry.lock() {
            registry.is_enabled(language_id, &self.settings)
        } else {
            false
        }
    }

    /// Get language by file extension using the registry
    pub fn get_language_for_extension(&self, extension: &str) -> Option<LanguageId> {
        let registry = get_registry();
        if let Ok(registry) = registry.lock() {
            registry
                .get_by_extension(extension)
                .filter(|def| def.is_enabled(&self.settings))
                .map(|def| def.id())
        } else {
            None
        }
    }

    // ========== Legacy methods (will be removed after migration) ==========

    /// Creates parser instance for the specified language.
    ///
    /// Validates language is enabled in configuration before creation.
    /// Returns ConfigError if language disabled, General error if unimplemented.
    #[must_use = "Parser creation may fail and should be handled"]
    pub fn create_parser(&self, language: Language) -> IndexResult<Box<dyn LanguageParser>> {
        // Validate language enablement before expensive parser creation
        let lang_key = language.config_key();
        if let Some(config) = self.settings.languages.get(lang_key) {
            if !config.enabled {
                return Err(IndexError::ConfigError {
                    reason: format!(
                        "Language {} is disabled in configuration. Enable it in your settings to use.",
                        language.name()
                    ),
                });
            }
        }

        match language {
            Language::Rust => {
                let parser = RustParser::new().map_err(IndexError::General)?;
                Ok(Box::new(parser))
            }
            Language::Python => {
                let parser = PythonParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::JavaScript => {
                // TODO: Implement JavaScriptParser
                Err(IndexError::General(format!(
                    "{} parser not yet implemented. Currently only Rust is supported.",
                    language.name()
                )))
            }
            Language::TypeScript => {
                // TODO: Implement TypeScriptParser
                Err(IndexError::General(format!(
                    "{} parser not yet implemented. Currently only Rust is supported.",
                    language.name()
                )))
            }
            Language::Php => {
                let parser = PhpParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Go => {
                let parser = GoParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::C => {
                let parser = CParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Cpp => {
                let parser = CppParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::CSharp => {
                let parser = CSharpParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Gdscript => {
                let parser = GdscriptParser::new().map_err(IndexError::General)?;
                Ok(Box::new(parser))
            }
            Language::Java => {
                let parser = JavaParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Kotlin => {
                let parser = KotlinParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Clojure => {
                let parser =
                    ClojureParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Lua => {
                let parser = LuaParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
            Language::Swift => {
                let parser = SwiftParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                Ok(Box::new(parser))
            }
        }
    }

    /// Checks if language is enabled in configuration.
    ///
    /// Returns false if language not found in settings (fail-safe default).
    pub fn is_language_enabled(&self, language: Language) -> bool {
        let lang_key = language.config_key();
        self.settings
            .languages
            .get(lang_key)
            .map(|config| config.enabled)
            .unwrap_or(false)
    }

    /// Creates a parser with its corresponding language behavior.
    ///
    /// This method pairs each parser with its language-specific behavior,
    /// enabling the removal of hardcoded language logic from indexing.
    pub fn create_parser_with_behavior(
        &self,
        language: Language,
    ) -> IndexResult<ParserWithBehavior> {
        // Validate language enablement
        let lang_key = language.config_key();
        if let Some(config) = self.settings.languages.get(lang_key) {
            if !config.enabled {
                return Err(IndexError::ConfigError {
                    reason: format!(
                        "Language {} is disabled in configuration. Enable it in your settings to use.",
                        language.name()
                    ),
                });
            }
        }

        // Create parser and behavior pair
        let result = match language {
            Language::Rust => {
                let parser = RustParser::new().map_err(IndexError::General)?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(RustBehavior::new()),
                }
            }
            Language::Python => {
                let parser = PythonParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(PythonBehavior::new()),
                }
            }
            Language::Php => {
                let parser = PhpParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(PhpBehavior::new()),
                }
            }
            Language::TypeScript => {
                let parser =
                    TypeScriptParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(TypeScriptBehavior::new()),
                }
            }
            Language::JavaScript => {
                let parser =
                    JavaScriptParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(JavaScriptBehavior::new()),
                }
            }
            Language::Go => {
                let parser = GoParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(GoBehavior::new()),
                }
            }
            Language::C => {
                let parser = CParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(CBehavior::new()),
                }
            }
            Language::Cpp => {
                let parser = CppParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(CppBehavior::new()),
                }
            }
            Language::CSharp => {
                let parser = CSharpParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(CSharpBehavior::new()),
                }
            }
            Language::Gdscript => {
                let parser = GdscriptParser::new().map_err(IndexError::General)?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(GdscriptBehavior::new()),
                }
            }
            Language::Java => {
                let parser = JavaParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(JavaBehavior::new()),
                }
            }
            Language::Kotlin => {
                let parser = KotlinParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(KotlinBehavior::new()),
                }
            }
            Language::Clojure => {
                let parser =
                    ClojureParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(ClojureBehavior::new()),
                }
            }
            Language::Lua => {
                let parser = LuaParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(LuaBehavior::new()),
                }
            }
            Language::Swift => {
                let parser = SwiftParser::new().map_err(|e| IndexError::General(e.to_string()))?;
                ParserWithBehavior {
                    parser: Box::new(parser),
                    behavior: Box::new(SwiftBehavior::new()),
                }
            }
        };

        Ok(result)
    }

    /// Create just the behavior for a language from registry
    pub fn create_behavior_from_registry(
        &self,
        language_id: LanguageId,
    ) -> Box<dyn LanguageBehavior> {
        let registry = get_registry();
        let registry = registry.lock().unwrap();

        if let Some(definition) = registry.get(language_id) {
            definition.create_behavior()
        } else {
            // Fallback to a default behavior if language not found
            // This shouldn't happen in practice
            Box::new(RustBehavior::new())
        }
    }

    /// Returns list of all enabled languages from configuration.
    ///
    /// Filters all supported languages against settings.languages map.
    pub fn enabled_languages(&self) -> Vec<Language> {
        vec![
            Language::C,
            Language::Clojure,
            Language::Cpp,
            Language::CSharp,
            Language::Gdscript,
            Language::Go,
            Language::Java,
            Language::JavaScript,
            Language::Kotlin,
            Language::Lua,
            Language::Php,
            Language::Python,
            Language::Rust,
            Language::Swift,
            Language::TypeScript,
        ]
        .into_iter()
        .filter(|&lang| self.is_language_enabled(lang))
        .collect()
    }
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_registry_based_parser_creation() {
        let mut settings = Settings::default();
        // Enable all languages for testing
        for (_, config) in settings.languages.iter_mut() {
            config.enabled = true;
        }
        let settings = Arc::new(settings);
        let factory = ParserFactory::new(settings.clone());

        // Test creating parser from registry
        let rust_id = LanguageId::new("rust");
        let parser = factory.create_parser_from_registry(rust_id);
        assert!(parser.is_ok(), "Should create Rust parser from registry");

        // Test creating parser with behavior from registry
        let python_id = LanguageId::new("python");
        let parser_with_behavior = factory.create_parser_with_behavior_from_registry(python_id);

        // Test creating parser with behavior for Go
        let go_id = LanguageId::new("go");

        if let Err(e) = &parser_with_behavior {
            eprintln!("Failed to create Python parser with behavior: {e}");
        }
        assert!(
            parser_with_behavior.is_ok(),
            "Should create Python parser with behavior from registry"
        );

        // Test checking if language is enabled
        assert!(factory.is_language_enabled_in_registry(rust_id));
        assert!(factory.is_language_enabled_in_registry(python_id));

        // Test getting language by extension
        assert_eq!(factory.get_language_for_extension("rs"), Some(rust_id));
        assert_eq!(factory.get_language_for_extension("py"), Some(python_id));
        assert_eq!(
            factory.get_language_for_extension("php"),
            Some(LanguageId::new("php"))
        );
        assert_eq!(factory.get_language_for_extension("go"), Some(go_id));
        assert_eq!(factory.get_language_for_extension("unknown"), None);
    }

    #[test]
    fn test_language_to_language_id_conversion() {
        // Test the transitional conversion method
        assert_eq!(Language::Rust.to_language_id(), LanguageId::new("rust"));
        assert_eq!(Language::Python.to_language_id(), LanguageId::new("python"));
        assert_eq!(Language::Php.to_language_id(), LanguageId::new("php"));
        assert_eq!(
            Language::JavaScript.to_language_id(),
            LanguageId::new("javascript")
        );
        assert_eq!(
            Language::TypeScript.to_language_id(),
            LanguageId::new("typescript")
        );
    }

    #[test]
    fn test_registry_legacy_parity() {
        let settings = Arc::new(Settings::default());
        let factory = ParserFactory::new(settings.clone());

        // Verify that both methods produce the same results for Rust
        let language = Language::Rust;
        let language_id = language.to_language_id();

        // Both should report enabled
        assert_eq!(
            factory.is_language_enabled(language),
            factory.is_language_enabled_in_registry(language_id),
            "Registry and legacy should agree on enabled status"
        );

        // Both should successfully create parsers
        let legacy_result = factory.create_parser(language);
        let registry_result = factory.create_parser_from_registry(language_id);

        assert!(legacy_result.is_ok());
        assert!(registry_result.is_ok());
    }

    #[test]
    fn test_create_rust_parser() {
        let settings = Arc::new(Settings::default());
        let factory = ParserFactory::new(settings);

        let parser = factory.create_parser(Language::Rust);
        assert!(parser.is_ok());

        let parser = parser.unwrap();
        assert_eq!(parser.language(), Language::Rust);
    }

    #[test]
    fn test_create_parser_with_behavior() {
        use crate::config::LanguageConfig;
        use indexmap::IndexMap;
        use std::collections::HashMap;

        // Create settings with all languages enabled
        let mut settings = Settings::default();
        let mut languages = IndexMap::new();

        // Enable Rust (already enabled by default, but be explicit)
        languages.insert(
            "rust".to_string(),
            LanguageConfig {
                enabled: true,
                extensions: vec!["rs".to_string()],
                parser_options: HashMap::new(),
                config_files: Vec::new(),
                projects: Vec::new(),
            },
        );

        // Enable Python
        languages.insert(
            "python".to_string(),
            LanguageConfig {
                enabled: true,
                extensions: vec!["py".to_string()],
                parser_options: HashMap::new(),
                config_files: Vec::new(),
                projects: Vec::new(),
            },
        );

        // Enable PHP
        languages.insert(
            "php".to_string(),
            LanguageConfig {
                enabled: true,
                extensions: vec!["php".to_string()],
                parser_options: HashMap::new(),
                config_files: Vec::new(),
                projects: Vec::new(),
            },
        );

        // Enable GDScript
        languages.insert(
            "gdscript".to_string(),
            LanguageConfig {
                enabled: true,
                extensions: vec!["gd".to_string()],
                parser_options: HashMap::new(),
                config_files: Vec::new(),
                projects: Vec::new(),
            },
        );

        settings.languages = languages;
        let factory = ParserFactory::new(Arc::new(settings));

        // Test Rust
        let result = factory.create_parser_with_behavior(Language::Rust);
        assert!(result.is_ok());
        let rust_pair = result.unwrap();
        assert_eq!(rust_pair.parser.language(), Language::Rust);
        assert_eq!(rust_pair.behavior.module_separator(), "::");

        // Test Python
        let result = factory.create_parser_with_behavior(Language::Python);
        assert!(result.is_ok());
        let python_pair = result.unwrap();
        assert_eq!(python_pair.parser.language(), Language::Python);
        assert_eq!(python_pair.behavior.module_separator(), ".");

        // Test PHP
        let result = factory.create_parser_with_behavior(Language::Php);
        assert!(result.is_ok());
        let php_pair = result.unwrap();
        assert_eq!(php_pair.parser.language(), Language::Php);
        assert_eq!(php_pair.behavior.module_separator(), "\\");

        // Test GDScript
        let result = factory.create_parser_with_behavior(Language::Gdscript);
        assert!(result.is_ok());
        let gd_pair = result.unwrap();
        assert_eq!(gd_pair.parser.language(), Language::Gdscript);
        assert_eq!(gd_pair.behavior.module_separator(), "/");
    }

    #[test]
    fn test_create_parser_with_behavior_disabled_language() {
        let mut settings = Settings::default();
        // Disable Rust
        if let Some(rust_config) = settings.languages.get_mut("rust") {
            rust_config.enabled = false;
        }

        let factory = ParserFactory::new(Arc::new(settings));
        let result = factory.create_parser_with_behavior(Language::Rust);

        assert!(result.is_err());
        if let Err(err) = result {
            assert!(
                matches!(err, IndexError::ConfigError { reason } if reason.contains("disabled"))
            );
        }
    }

    #[test]
    fn test_disabled_language() {
        let mut settings = Settings::default();
        // Disable Rust
        if let Some(rust_config) = settings.languages.get_mut("rust") {
            rust_config.enabled = false;
        }

        let factory = ParserFactory::new(Arc::new(settings));
        let result = factory.create_parser(Language::Rust);

        assert!(result.is_err());
        if let Err(err) = result {
            assert!(
                matches!(err, IndexError::ConfigError { reason } if reason.contains("disabled"))
            );
        }
    }

    #[test]
    fn test_enabled_languages() {
        let settings = Arc::new(Settings::default());
        let factory = ParserFactory::new(settings);

        let enabled = factory.enabled_languages();

        // Dynamically check that we have enabled languages from the registry
        // This test won't break when we add new languages
        assert!(
            !enabled.is_empty(),
            "Should have at least one enabled language"
        );

        // Verify core languages are still enabled (these should always be present)
        assert!(
            enabled.contains(&Language::Rust),
            "Rust should be enabled by default"
        );
        assert!(
            enabled.contains(&Language::Python),
            "Python should be enabled by default"
        );

        // Just verify we can get the count - don't hardcode it
        println!("Currently {} languages enabled by default", enabled.len());
    }

    #[test]
    fn test_create_python_parser() {
        use crate::config::LanguageConfig;
        use indexmap::IndexMap;
        use std::collections::HashMap;

        let mut settings = Settings::default();
        let mut languages = IndexMap::new();
        languages.insert(
            "python".to_string(),
            LanguageConfig {
                enabled: true,
                extensions: vec!["py".to_string()],
                parser_options: HashMap::new(),
                config_files: Vec::new(),
                projects: Vec::new(),
            },
        );
        settings.languages = languages;

        let factory = ParserFactory::new(Arc::new(settings));
        let parser = factory.create_parser(Language::Python);

        assert!(parser.is_ok());
        let parser = parser.unwrap();
        assert_eq!(parser.language(), Language::Python);
    }
}