use cobre_core::EntityId;
use parquet::arrow::arrow_reader::ParquetRecordBatchReaderBuilder;
use std::fs::File;
use std::path::Path;
use crate::LoadError;
use crate::parquet_helpers::{extract_required_float64, extract_required_int32};
#[derive(Debug, Clone, PartialEq)]
pub struct ExternalScenarioRow {
pub stage_id: i32,
pub scenario_id: i32,
pub hydro_id: EntityId,
pub value_m3s: f64,
}
pub fn parse_external_scenarios(path: &Path) -> Result<Vec<ExternalScenarioRow>, LoadError> {
let file = File::open(path).map_err(|e| LoadError::io(path, e))?;
let builder = ParquetRecordBatchReaderBuilder::try_new(file)
.map_err(|e| LoadError::parse(path, e.to_string()))?;
let reader = builder
.build()
.map_err(|e| LoadError::parse(path, e.to_string()))?;
let mut rows: Vec<ExternalScenarioRow> = Vec::new();
for batch_result in reader {
let batch = batch_result.map_err(|e| LoadError::parse(path, e.to_string()))?;
let stage_id_col = extract_required_int32(&batch, "stage_id", path)?;
let scenario_id_col = extract_required_int32(&batch, "scenario_id", path)?;
let hydro_id_col = extract_required_int32(&batch, "hydro_id", path)?;
let value_m3s_col = extract_required_float64(&batch, "value_m3s", path)?;
let n = batch.num_rows();
let base_idx = rows.len();
rows.reserve(n);
for i in 0..n {
let row_idx = base_idx + i;
let stage_id = stage_id_col.value(i);
let scenario_id = scenario_id_col.value(i);
let hydro_id = EntityId::from(hydro_id_col.value(i));
let value_m3s = value_m3s_col.value(i);
if scenario_id < 0 {
return Err(LoadError::SchemaError {
path: path.to_path_buf(),
field: format!("external_scenarios[{row_idx}].scenario_id"),
message: format!("scenario_id must be >= 0 (0-based), got {scenario_id}"),
});
}
if !value_m3s.is_finite() {
return Err(LoadError::SchemaError {
path: path.to_path_buf(),
field: format!("external_scenarios[{row_idx}].value_m3s"),
message: format!("value_m3s must be finite, got {value_m3s}"),
});
}
rows.push(ExternalScenarioRow {
stage_id,
scenario_id,
hydro_id,
value_m3s,
});
}
}
rows.sort_by(|a, b| {
a.stage_id
.cmp(&b.stage_id)
.then_with(|| a.scenario_id.cmp(&b.scenario_id))
.then_with(|| a.hydro_id.0.cmp(&b.hydro_id.0))
});
Ok(rows)
}
#[cfg(test)]
#[allow(
clippy::doc_markdown,
clippy::expect_used,
clippy::panic,
clippy::too_many_lines,
clippy::unwrap_used
)]
mod tests {
use super::*;
use arrow::array::{Float64Array, Int32Array};
use arrow::datatypes::{DataType, Field, Schema};
use arrow::record_batch::RecordBatch;
use parquet::arrow::ArrowWriter;
use std::sync::Arc;
use tempfile::NamedTempFile;
fn schema() -> Arc<Schema> {
Arc::new(Schema::new(vec![
Field::new("stage_id", DataType::Int32, false),
Field::new("scenario_id", DataType::Int32, false),
Field::new("hydro_id", DataType::Int32, false),
Field::new("value_m3s", DataType::Float64, false),
]))
}
fn write_parquet(batch: &RecordBatch) -> NamedTempFile {
let tmp = NamedTempFile::new().expect("tempfile");
let mut writer = ArrowWriter::try_new(tmp.reopen().expect("reopen"), batch.schema(), None)
.expect("ArrowWriter");
writer.write(batch).expect("write batch");
writer.close().expect("close writer");
tmp
}
fn make_batch(
stage_ids: &[i32],
scenario_ids: &[i32],
hydro_ids: &[i32],
values: &[f64],
) -> RecordBatch {
RecordBatch::try_new(
schema(),
vec![
Arc::new(Int32Array::from(stage_ids.to_vec())),
Arc::new(Int32Array::from(scenario_ids.to_vec())),
Arc::new(Int32Array::from(hydro_ids.to_vec())),
Arc::new(Float64Array::from(values.to_vec())),
],
)
.expect("valid batch")
}
#[test]
fn test_valid_12_rows_sorted_by_stage_scenario_hydro() {
let batch = make_batch(
&[1, 0, 0, 1, 0, 1, 1, 0, 0, 1, 1, 0], &[2, 0, 2, 0, 1, 1, 0, 0, 2, 2, 1, 1], &[2, 1, 1, 2, 2, 1, 1, 2, 2, 1, 2, 1], &[
120.0, 100.0, 110.0, 200.0, 105.0, 201.0, 205.0, 195.0, 115.0, 125.0, 210.0, 208.0,
],
);
let tmp = write_parquet(&batch);
let rows = parse_external_scenarios(tmp.path()).unwrap();
assert_eq!(rows.len(), 12);
for w in rows.windows(2) {
let a = &w[0];
let b = &w[1];
let cmp = a
.stage_id
.cmp(&b.stage_id)
.then_with(|| a.scenario_id.cmp(&b.scenario_id))
.then_with(|| a.hydro_id.0.cmp(&b.hydro_id.0));
assert!(cmp != std::cmp::Ordering::Greater);
}
assert_eq!(rows[0].stage_id, 0);
assert_eq!(rows[0].scenario_id, 0);
assert_eq!(rows[0].hydro_id, EntityId::from(1));
assert!((rows[0].value_m3s - 100.0).abs() < 1e-10);
}
#[test]
fn test_nan_value_rejected() {
let batch = make_batch(&[0], &[0], &[1], &[f64::NAN]);
let tmp = write_parquet(&batch);
let err = parse_external_scenarios(tmp.path()).unwrap_err();
match &err {
LoadError::SchemaError { field, message, .. } => {
assert!(
field.contains("value_m3s"),
"field should contain 'value_m3s', got: {field}"
);
assert!(
message.contains("finite"),
"message should mention 'finite', got: {message}"
);
}
other => panic!("expected SchemaError, got: {other:?}"),
}
}
#[test]
fn test_infinity_value_rejected() {
let batch = make_batch(&[0], &[0], &[1], &[f64::INFINITY]);
let tmp = write_parquet(&batch);
let err = parse_external_scenarios(tmp.path()).unwrap_err();
match &err {
LoadError::SchemaError { field, message, .. } => {
assert!(
field.contains("value_m3s"),
"field should contain 'value_m3s', got: {field}"
);
assert!(
message.contains("finite"),
"message should mention 'finite', got: {message}"
);
}
other => panic!("expected SchemaError, got: {other:?}"),
}
}
#[test]
fn test_negative_scenario_id_rejected() {
let batch = make_batch(&[0], &[-1], &[1], &[100.0]);
let tmp = write_parquet(&batch);
let err = parse_external_scenarios(tmp.path()).unwrap_err();
match &err {
LoadError::SchemaError { field, message, .. } => {
assert!(
field.contains("scenario_id"),
"field should contain 'scenario_id', got: {field}"
);
assert!(
message.contains('0'),
"message should mention >= 0, got: {message}"
);
}
other => panic!("expected SchemaError, got: {other:?}"),
}
}
#[test]
fn test_missing_hydro_id_column() {
let schema_no_hydro = Arc::new(Schema::new(vec![
Field::new("stage_id", DataType::Int32, false),
Field::new("scenario_id", DataType::Int32, false),
Field::new("value_m3s", DataType::Float64, false),
]));
let batch = RecordBatch::try_new(
schema_no_hydro,
vec![
Arc::new(Int32Array::from(vec![0_i32])),
Arc::new(Int32Array::from(vec![0_i32])),
Arc::new(Float64Array::from(vec![100.0_f64])),
],
)
.unwrap();
let tmp = write_parquet(&batch);
let err = parse_external_scenarios(tmp.path()).unwrap_err();
match &err {
LoadError::SchemaError { field, message, .. } => {
assert!(
field.contains("hydro_id"),
"field should contain 'hydro_id', got: {field}"
);
assert!(
message.contains("missing required column"),
"message should mention missing column, got: {message}"
);
}
other => panic!("expected SchemaError, got: {other:?}"),
}
}
#[test]
fn test_empty_parquet_returns_empty_vec() {
let batch = make_batch(&[], &[], &[], &[]);
let tmp = write_parquet(&batch);
let rows = parse_external_scenarios(tmp.path()).unwrap();
assert!(rows.is_empty());
}
#[test]
fn test_load_external_scenarios_none_returns_empty() {
let result = super::super::load_external_scenarios(None).unwrap();
assert!(result.is_empty(), "expected empty vec for None path");
}
#[test]
fn test_field_values_preserved() {
let batch = make_batch(&[3], &[7], &[42], &[288.75]);
let tmp = write_parquet(&batch);
let rows = parse_external_scenarios(tmp.path()).unwrap();
assert_eq!(rows.len(), 1);
let row = &rows[0];
assert_eq!(row.stage_id, 3);
assert_eq!(row.scenario_id, 7);
assert_eq!(row.hydro_id, EntityId::from(42));
assert!((row.value_m3s - 288.75).abs() < 1e-10);
}
#[test]
fn test_scenario_id_zero_is_valid() {
let batch = make_batch(&[0], &[0], &[1], &[150.0]);
let tmp = write_parquet(&batch);
let rows = parse_external_scenarios(tmp.path()).unwrap();
assert_eq!(rows.len(), 1);
assert_eq!(rows[0].scenario_id, 0);
}
}