cobble 0.1.0

A flexible embedded key-value storage engine for distributed systems as well as single-node applications.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
//! Row codec for SST files.
//!
//! This module provides efficient binary serialization for Key and Value types
//! in row-based SST storage format.
//!
//! ## Key Format
//! ```text
//! [group: u16][data: bytes]
//! ```
//! Note: The key's data length is stored by the SST block format, not in the key itself.
//!
//! ## Value Format (with optional columns)
//! The number of columns is stored in SST metadata, not in each value.
//! Each column can be optional (absent) within a value.
//! ```text
//! [presence_bitmap: variable][columns...]
//! ```
//!
//! Where:
//! - `presence_bitmap`: A bitmap where bit i indicates if column i is present.
//!   The bitmap size is `ceil(num_columns / 8)` bytes. Omitted when `num_columns == 1`.
//! - Non-last present column: `[value_type: u8][data_len: u32][data: bytes]`
//! - Last present column: `[value_type: u8][data: bytes]` (data_len is omitted and calculated from remaining bytes)

use crate::error::{Error, Result};
use crate::r#type::{Column, Key, RefColumn, RefKey, RefValue, Value, ValueType};
use bytes::{Buf, BufMut, Bytes, BytesMut};

/// Encodes a ValueType to a single byte.
pub(crate) fn encode_value_type(vt: &ValueType) -> u8 {
    vt.encode_tag()
}

/// Decodes a ValueType from a single byte.
pub(crate) fn decode_value_type(byte: u8) -> Result<ValueType> {
    ValueType::decode_tag(byte)
}

trait ColumnRef {
    fn value_type(&self) -> &ValueType;
    fn data(&self) -> &[u8];
}

impl ColumnRef for Column {
    fn value_type(&self) -> &ValueType {
        self.value_type()
    }

    fn data(&self) -> &[u8] {
        self.data()
    }
}

impl<'a> ColumnRef for RefColumn<'a> {
    fn value_type(&self) -> &ValueType {
        self.value_type()
    }

    fn data(&self) -> &[u8] {
        self.data()
    }
}

/// Encodes a Key to bytes.
///
/// Layout: `[group: u16][data: bytes]`
/// Note: The key's data length is stored by the SST block format, not encoded here.
pub(crate) fn encode_key(key: &Key) -> Bytes {
    let size = 2 + key.data().len();
    let mut buf = BytesMut::with_capacity(size);
    encode_key_ref_into(&RefKey::new(key.bucket(), key.data()), &mut buf);
    buf.freeze()
}

pub(crate) fn encode_key_ref_into(key: &RefKey<'_>, buf: &mut impl BufMut) {
    buf.put_u16_le(key.bucket());
    buf.put_slice(key.data());
}

/// Decodes a Key from bytes.
/// The full key data is provided (length is known from SST block format).
pub(crate) fn decode_key(data: &mut Bytes) -> Result<Key> {
    if data.len() < 2 {
        return Err(Error::IoError(format!(
            "Key data too small: expected at least 2 bytes, got {}",
            data.len()
        )));
    }

    let group = data.get_u16_le();
    let key_data = data.split_to(data.len());
    Ok(Key::new(group, key_data))
}

/// Returns the encoded size of a Key in bytes.
pub(crate) fn key_encoded_size(key: &Key) -> usize {
    2 + key.data().len()
}

/// Returns the size of the presence bitmap for the given number of columns.
///
/// Calculates `ceil(num_columns / 8)` to determine the number of bytes needed
/// for the bitmap, where each bit represents the presence of one column.
///
/// Optimization: When `num_columns == 1`, returns 0 since the bitmap is skipped.
/// A single-column value with no column present would be invalid anyway.
fn bitmap_size(num_columns: usize) -> usize {
    if num_columns <= 1 {
        0
    } else {
        num_columns.div_ceil(8)
    }
}

fn value_type_is_terminal(byte: u8) -> Result<bool> {
    Ok(ValueType::decode_tag(byte)?.is_terminal())
}

pub(crate) fn value_expired_at(data: &[u8]) -> Result<Option<u32>> {
    if data.len() < 4 {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least 4 bytes for expired_at, got {}",
            data.len()
        )));
    }
    let mut buf = data;
    let expired_at = buf.get_u32_le();
    if expired_at == 0 {
        Ok(None)
    } else {
        Ok(Some(expired_at))
    }
}

pub(crate) fn value_is_terminal(data: &[u8], num_columns: usize) -> Result<bool> {
    if data.len() < 4 {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least 4 bytes for expired_at, got {}",
            data.len()
        )));
    }
    let mut buf = &data[4..];
    let bmp_size = bitmap_size(num_columns);
    if buf.len() < bmp_size {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least {} bytes for bitmap, got {}",
            bmp_size,
            buf.len()
        )));
    }
    let bitmap = &buf[..bmp_size];
    buf = &buf[bmp_size..];

    if num_columns > 1 {
        for i in 0..num_columns {
            let is_present = (bitmap[i / 8] >> (i % 8)) & 1 == 1;
            if !is_present {
                return Ok(false);
            }
        }
    }

    for i in 0..num_columns {
        if buf.remaining() < 1 {
            return Err(Error::IoError(format!(
                "Column {} data corrupted: not enough bytes for value_type",
                i
            )));
        }
        let value_type = buf.get_u8();
        if !value_type_is_terminal(value_type)? {
            return Ok(false);
        }
        if i < num_columns.saturating_sub(1) {
            if buf.remaining() < 4 {
                return Err(Error::IoError(format!(
                    "Column {} data corrupted: not enough bytes for length",
                    i
                )));
            }
            let data_len = buf.get_u32_le() as usize;
            if buf.remaining() < data_len {
                return Err(Error::IoError(format!(
                    "Column {} data corrupted: expected {} bytes, got {}",
                    i,
                    data_len,
                    buf.remaining()
                )));
            }
            buf = &buf[data_len..];
        } else {
            buf = &buf[buf.len()..];
        }
    }

    Ok(true)
}

/// Encodes a Value to bytes with optional columns.
///
/// The number of columns is provided by the caller (from SST metadata).
/// Layout: `[expired_at: u32][presence_bitmap][present_columns...]`
///
/// - `presence_bitmap`: A bitmap indicating which columns are present.
///   (Omitted when `num_columns == 1` as a single absent column means invalid value)
/// - Each present column (except last): `[value_type: u8][data_len: u32][data: bytes]`
/// - Last present column: `[value_type: u8][data: bytes]` (data_len is omitted and calculated during decode)
///
/// # Arguments
/// * `value` - The Value to encode containing optional columns.
/// * `num_columns` - Total number of columns (from SST metadata).
pub(crate) fn encode_value(value: &Value, num_columns: usize) -> Bytes {
    let total_size = value_encoded_size_columns(value.columns(), num_columns);
    let mut buf = BytesMut::with_capacity(total_size);
    encode_value_columns_into(value.columns(), value.expired_at(), num_columns, &mut buf);
    buf.freeze()
}

pub(crate) fn encode_value_ref_into(
    value: &RefValue<'_>,
    num_columns: usize,
    buf: &mut impl BufMut,
) {
    encode_value_columns_into(value.columns(), value.expired_at(), num_columns, buf);
}

fn encode_value_columns_into<C: ColumnRef>(
    columns: &[Option<C>],
    expired_at: Option<u32>,
    num_columns: usize,
    buf: &mut impl BufMut,
) {
    let bmp_size = bitmap_size(num_columns);

    // Count present columns to identify the last one
    let present_count = columns
        .iter()
        .take(num_columns)
        .filter(|c| c.is_some())
        .count();

    // Write expiration timestamp (seconds since epoch, 0 if None)
    buf.put_u32_le(expired_at.unwrap_or(0));

    // Write presence bitmap (only if num_columns > 1)
    if bmp_size > 0 {
        let mut bitmap = vec![0u8; bmp_size];
        for (i, col_opt) in columns.iter().take(num_columns).enumerate() {
            if col_opt.is_some() {
                bitmap[i / 8] |= 1 << (i % 8);
            }
        }
        buf.put_slice(&bitmap);
    }

    // Write present columns (skip data_len for the last one)
    let mut present_idx = 0;
    for col in columns.iter().take(num_columns).flatten() {
        present_idx += 1;
        buf.put_u8(encode_value_type(col.value_type()));
        // Only write data_len if not the last present column
        if present_idx < present_count {
            buf.put_u32_le(col.data().len() as u32);
        }
        buf.put_slice(col.data());
    }
}

/// Decodes a Value from bytes with optional columns.
///
/// The number of columns is provided by the caller (from SST metadata).
/// The last present column's data_len is calculated from remaining bytes.
///
/// # Arguments
/// * `data` - The encoded value bytes.
/// * `num_columns` - Total number of columns (from SST metadata).
///
/// # Returns
/// A Value containing optional columns, where `None` indicates an absent column.
pub(crate) fn decode_value(data: &mut Bytes, num_columns: usize) -> Result<Value> {
    if data.len() < 4 {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least 4 bytes for expired_at, got {}",
            data.len()
        )));
    }
    let expired_at = data.get_u32_le();
    let bmp_size = bitmap_size(num_columns);

    if data.len() < bmp_size {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least {} bytes for bitmap, got {}",
            bmp_size,
            data.len()
        )));
    }

    let bitmap = data.split_to(bmp_size);
    let bitmap = bitmap.as_ref();

    // First pass: determine which columns are present and find the last one
    let mut presence = Vec::with_capacity(num_columns);
    let mut last_present_idx = None;
    for i in 0..num_columns {
        let is_present = if num_columns == 1 {
            true
        } else {
            (bitmap[i / 8] >> (i % 8)) & 1 == 1
        };
        presence.push(is_present);
        if is_present {
            last_present_idx = Some(i);
        }
    }

    // Second pass: decode columns
    let mut columns = Vec::with_capacity(num_columns);
    for (i, is_presence) in presence.iter().enumerate().take(num_columns) {
        if *is_presence {
            let is_last = Some(i) == last_present_idx;

            if is_last {
                // Last present column: data_len is not stored, use remaining bytes
                if data.remaining() < 1 {
                    return Err(Error::IoError(format!(
                        "Column {} data corrupted: not enough bytes for value_type",
                        i
                    )));
                }
                let value_type = decode_value_type(data.get_u8())?;
                let col_data = data.split_to(data.len());
                columns.push(Some(Column::new(value_type, col_data)));
            } else {
                // Non-last column: has data_len field
                if data.remaining() < 5 {
                    return Err(Error::IoError(format!(
                        "Column {} data corrupted: not enough bytes",
                        i
                    )));
                }

                let value_type = decode_value_type(data.get_u8())?;
                let data_len = data.get_u32_le() as usize;

                if data.remaining() < data_len {
                    return Err(Error::IoError(format!(
                        "Column {} data corrupted: expected {} bytes, got {}",
                        i,
                        data_len,
                        data.remaining()
                    )));
                }

                let col_data = data.split_to(data_len);
                columns.push(Some(Column::new(value_type, col_data)));
            }
        } else {
            columns.push(None);
        }
    }

    let expired_at = if expired_at == 0 {
        None
    } else {
        Some(expired_at)
    };
    Ok(Value::new_with_expired_at(columns, expired_at))
}

/// Decodes a Value but only materializes columns requested by `decode_columns`.
/// Columns not requested are skipped and returned as None, while their value types
/// can still update `terminal_columns` if provided.
pub(crate) fn decode_value_masked(
    data: &mut Bytes,
    num_columns: usize,
    decode_mask: &[u8],
    mut terminal_mask: Option<&mut [u8]>,
) -> Result<Value> {
    if data.len() < 4 {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least 4 bytes for expired_at, got {}",
            data.len()
        )));
    }
    let expired_at = data.get_u32_le();

    let mask_size = bitmap_size(num_columns).max(1);
    if decode_mask.len() < mask_size {
        return Err(Error::IoError(format!(
            "decode_mask length {} is less than required {}",
            decode_mask.len(),
            mask_size
        )));
    }

    let bmp_size = bitmap_size(num_columns);
    if data.len() < bmp_size {
        return Err(Error::IoError(format!(
            "Value data too small: expected at least {} bytes for bitmap, got {}",
            bmp_size,
            data.len()
        )));
    }

    let bitmap = data.split_to(bmp_size);
    let bitmap = bitmap.as_ref();
    let mut last_present_idx = None;
    if num_columns == 1 {
        last_present_idx = Some(0);
    } else if bmp_size > 0 {
        let last_byte_bits = (num_columns - 1) % 8 + 1;
        let last_byte_mask = (1u8 << last_byte_bits) - 1;
        for byte_idx in (0..bmp_size).rev() {
            let mut byte = bitmap[byte_idx];
            if byte_idx == bmp_size - 1 {
                byte &= last_byte_mask;
            }
            if byte == 0 {
                continue;
            }
            let leading = byte.leading_zeros() as usize;
            let bit = 7 - leading;
            last_present_idx = Some(byte_idx * 8 + bit);
            break;
        }
    }

    let mut columns = Vec::with_capacity(num_columns);
    for i in 0..num_columns {
        let is_presence = if num_columns == 1 {
            true
        } else {
            (bitmap[i / 8] >> (i % 8)) & 1 == 1
        };
        if is_presence {
            let is_last = Some(i) == last_present_idx;
            if data.remaining() < 1 {
                return Err(Error::IoError(format!(
                    "Column {} data corrupted: not enough bytes for value_type",
                    i
                )));
            }
            let value_type = decode_value_type(data.get_u8())?;
            if let Some(ref mut mask) = terminal_mask
                && value_type.is_terminal()
                && let Some(byte) = mask.get_mut(i / 8)
            {
                *byte |= 1 << (i % 8);
            }
            if is_last {
                if decode_mask[i / 8] & (1 << (i % 8)) != 0 {
                    let col_data = data.split_to(data.len());
                    columns.push(Some(Column::new(value_type, col_data)));
                } else {
                    data.advance(data.len());
                    columns.push(None);
                }
            } else {
                if data.remaining() < 4 {
                    return Err(Error::IoError(format!(
                        "Column {} data corrupted: not enough bytes for length",
                        i
                    )));
                }
                let data_len = data.get_u32_le() as usize;
                if data.remaining() < data_len {
                    return Err(Error::IoError(format!(
                        "Column {} data corrupted: expected {} bytes, got {}",
                        i,
                        data_len,
                        data.remaining()
                    )));
                }
                if decode_mask[i / 8] & (1 << (i % 8)) != 0 {
                    let col_data = data.split_to(data_len);
                    columns.push(Some(Column::new(value_type, col_data)));
                } else {
                    data.advance(data_len);
                    columns.push(None);
                }
            }
        } else {
            columns.push(None);
        }
    }

    let expired_at = if expired_at == 0 {
        None
    } else {
        Some(expired_at)
    };
    Ok(Value::new_with_expired_at(columns, expired_at))
}

/// Returns the encoded size of a Value in bytes.
///
/// Note: The last present column saves 4 bytes by omitting data_len.
///
/// # Arguments
/// * `value` - The Value containing optional columns.
/// * `num_columns` - Total number of columns (from SST metadata).
pub(crate) fn value_encoded_size(value: &Value, num_columns: usize) -> usize {
    value_encoded_size_columns(value.columns(), num_columns)
}

fn value_encoded_size_columns<C: ColumnRef>(columns: &[Option<C>], num_columns: usize) -> usize {
    let bmp_size = bitmap_size(num_columns);
    let present_count = columns
        .iter()
        .take(num_columns)
        .filter(|c| c.is_some())
        .count();

    // 4 bytes for expired_at + bitmap size (always include expired_at header)
    let mut size = 4 + bmp_size;
    for col in columns.iter().take(num_columns).flatten() {
        size += 1 + 4 + col.data().len(); // value_type + data_len + data
    }
    // Subtract 4 bytes for the last column's data_len if there's at least one present column
    if present_count > 0 {
        size -= 4;
    }
    size
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn test_encode_decode_key() {
        let key = Key::new(42, b"hello world".to_vec());
        let encoded = encode_key(&key);

        // Verify encoded size: 2 (group) + 11 (data) = 13
        assert_eq!(encoded.len(), 13);
        assert_eq!(key_encoded_size(&key), 13);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_key(&mut encoded_for_decode).unwrap();
        assert_eq!(decoded.bucket(), 42);
        assert_eq!(decoded.data().as_ref(), b"hello world");
    }

    #[test]
    fn test_key_empty_data() {
        let key = Key::new(0, Vec::new());
        let encoded = encode_key(&key);

        assert_eq!(encoded.len(), 2);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_key(&mut encoded_for_decode).unwrap();
        assert_eq!(decoded.bucket(), 0);
        assert_eq!(decoded.data().as_ref(), b"");
    }

    #[test]
    fn test_key_max_group() {
        let key = Key::new(u16::MAX, b"test".to_vec());
        let encoded = encode_key(&key);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_key(&mut encoded_for_decode).unwrap();
        assert_eq!(decoded.bucket(), u16::MAX);
        assert_eq!(decoded.data().as_ref(), b"test");
    }

    #[test]
    fn test_key_decode_too_small() {
        let mut encoded = Bytes::from_static(&[0]);
        let result = decode_key(&mut encoded);
        assert!(result.is_err());
    }

    #[test]
    fn test_value_type_encode_decode() {
        assert_eq!(encode_value_type(&ValueType::Put), 0b0000_0001);
        assert_eq!(encode_value_type(&ValueType::Delete), 0b0001_0001);
        assert_eq!(encode_value_type(&ValueType::Merge), 0b0000_0010);
        assert_eq!(encode_value_type(&ValueType::PutSeparated), 0b0000_0101);
        assert_eq!(encode_value_type(&ValueType::MergeSeparated), 0b0000_0110);
        assert_eq!(
            encode_value_type(&ValueType::MergeSeparatedArray),
            0b0000_1110
        );
        assert_eq!(
            encode_value_type(&ValueType::PutSeparatedArray),
            0b0000_1111
        );

        assert!(matches!(
            decode_value_type(0b0000_0001).unwrap(),
            ValueType::Put
        ));
        assert!(matches!(
            decode_value_type(0b0001_0001).unwrap(),
            ValueType::Delete
        ));
        assert!(matches!(
            decode_value_type(0b0000_0010).unwrap(),
            ValueType::Merge
        ));
        assert!(matches!(
            decode_value_type(0b0000_0101).unwrap(),
            ValueType::PutSeparated
        ));
        assert!(matches!(
            decode_value_type(0b0000_0110).unwrap(),
            ValueType::MergeSeparated
        ));
        assert!(matches!(
            decode_value_type(0b0000_1110).unwrap(),
            ValueType::MergeSeparatedArray
        ));
        assert!(matches!(
            decode_value_type(0b0000_1111).unwrap(),
            ValueType::PutSeparatedArray
        ));
    }

    #[test]
    fn test_value_type_decode_invalid() {
        assert!(decode_value_type(0).is_err());
        assert!(decode_value_type(0b0000_0011).is_err());
        assert!(decode_value_type(255).is_err());
    }

    #[test]
    fn test_encode_decode_value_all_present() {
        let col1 = Column::new(ValueType::Put, b"data1".to_vec());
        let col2 = Column::new(ValueType::Delete, b"data2".to_vec());
        let value = Value::new(vec![Some(col1), Some(col2)]);

        let encoded = encode_value(&value, 2);

        // Expired_at: 4 bytes
        // Bitmap size: 1 byte for 2 columns
        // Column 1: 1 + 4 + 5 = 10
        // Column 2 (last): 1 + 5 = 6 (data_len omitted)
        // Total: 4 + 1 + 10 + 6 = 21
        assert_eq!(encoded.len(), 21);
        assert_eq!(value_encoded_size(&value, 2), 21);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 2).unwrap();
        let cols = decoded.columns();
        assert_eq!(cols.len(), 2);

        assert!(cols[0].is_some());
        let c0 = cols[0].as_ref().unwrap();
        assert!(matches!(c0.value_type(), ValueType::Put));
        assert_eq!(c0.data().as_ref(), b"data1");

        assert!(cols[1].is_some());
        let c1 = cols[1].as_ref().unwrap();
        assert!(matches!(c1.value_type(), ValueType::Delete));
        assert_eq!(c1.data().as_ref(), b"data2");
    }

    #[test]
    fn test_encode_decode_value_with_optional() {
        let col1 = Column::new(ValueType::Put, b"present".to_vec());
        let value = Value::new(vec![Some(col1), None, None]);

        let encoded = encode_value(&value, 3);

        // Expired_at: 4 bytes
        // Bitmap size: 1 byte for 3 columns
        // Only column 0 is present (and is last): 1 + 7 = 8 (data_len omitted)
        // Total: 4 + 1 + 8 = 13
        assert_eq!(encoded.len(), 13);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 3).unwrap();
        let cols = decoded.columns();
        assert_eq!(cols.len(), 3);

        assert!(cols[0].is_some());
        assert_eq!(cols[0].as_ref().unwrap().data().as_ref(), b"present");

        assert!(cols[1].is_none());
        assert!(cols[2].is_none());
    }

    #[test]
    fn test_encode_decode_value_all_absent() {
        let value = Value::new(vec![None, None, None, None]);

        let encoded = encode_value(&value, 4);

        // Expired_at: 4 bytes
        // Bitmap size: 1 byte for 4 columns, no column data
        assert_eq!(encoded.len(), 5);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 4).unwrap();
        let cols = decoded.columns();
        assert_eq!(cols.len(), 4);
        assert!(cols.iter().all(|c| c.is_none()));
    }

    #[test]
    fn test_encode_decode_value_many_columns() {
        // Test with 16 columns (2 bytes bitmap)
        let col = Column::new(ValueType::Merge, b"x".to_vec());
        let mut columns: Vec<Option<Column>> = vec![None; 16];
        columns[0] = Some(col.clone());
        columns[8] = Some(col.clone());
        columns[15] = Some(col);
        let value = Value::new(columns);

        let encoded = encode_value(&value, 16);

        // Expired_at: 4 bytes
        // Bitmap size: 2 bytes for 16 columns
        // 2 non-last columns: 2 * (1 + 4 + 1) = 12
        // Last column (idx 15): 1 + 1 = 2 (data_len omitted)
        // Total: 4 + 2 + 12 + 2 = 20
        assert_eq!(encoded.len(), 20);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 16).unwrap();
        let cols = decoded.columns();
        assert_eq!(cols.len(), 16);

        assert!(cols[0].is_some());
        assert!(cols[1].is_none());
        assert!(cols[8].is_some());
        assert!(cols[15].is_some());
    }

    #[test]
    fn test_bitmap_size() {
        assert_eq!(bitmap_size(0), 0);
        assert_eq!(bitmap_size(1), 0); // Optimized: no bitmap for single column
        assert_eq!(bitmap_size(2), 1);
        assert_eq!(bitmap_size(8), 1);
        assert_eq!(bitmap_size(9), 2);
        assert_eq!(bitmap_size(16), 2);
        assert_eq!(bitmap_size(17), 3);
    }

    #[test]
    fn test_value_decode_too_small() {
        // For 2 columns, need at least 1 byte bitmap
        let mut encoded = Bytes::new();
        let result = decode_value(&mut encoded, 2);
        assert!(result.is_err());
    }

    #[test]
    fn test_single_column_no_bitmap() {
        // Single column optimization: no bitmap, column must be present
        // Also the last (and only) column, so data_len is omitted
        let col = Column::new(ValueType::Put, b"single".to_vec());
        let value = Value::new(vec![Some(col)]);

        let encoded = encode_value(&value, 1);

        // Expired_at: 4 bytes
        // No bitmap for single column, and data_len omitted (last column)
        // 1 (value_type) + 6 (data) = 7
        // Total: 4 + 7 = 11
        assert_eq!(encoded.len(), 11);
        assert_eq!(value_encoded_size(&value, 1), 11);

        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 1).unwrap();
        let cols = decoded.columns();
        assert_eq!(cols.len(), 1);
        assert!(cols[0].is_some());
        assert_eq!(cols[0].as_ref().unwrap().data().as_ref(), b"single");
    }

    #[test]
    fn test_large_data() {
        let large_data: Vec<u8> = (0..10000).map(|i| (i % 256) as u8).collect();

        let key = Key::new(1234, large_data.clone());
        let encoded_key = encode_key(&key);
        let mut encoded_key_for_decode = encoded_key.clone();
        let decoded_key = decode_key(&mut encoded_key_for_decode).unwrap();
        assert_eq!(decoded_key.bucket(), 1234);
        assert_eq!(decoded_key.data().as_ref(), large_data.as_slice());

        let col = Column::new(ValueType::Put, large_data.clone());
        let value = Value::new(vec![Some(col)]);
        let encoded = encode_value(&value, 1);
        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_value(&mut encoded_for_decode, 1).unwrap();
        let cols = decoded.columns();
        assert!(cols[0].is_some());
        assert_eq!(
            cols[0].as_ref().unwrap().data().as_ref(),
            large_data.as_slice()
        );
    }

    #[test]
    fn test_binary_data_with_nulls() {
        let binary_data = vec![0u8, 1, 0, 255, 0, 128, 0];

        let key = Key::new(100, binary_data.clone());
        let encoded = encode_key(&key);
        let mut encoded_for_decode = encoded.clone();
        let decoded = decode_key(&mut encoded_for_decode).unwrap();
        assert_eq!(decoded.data().as_ref(), binary_data.as_slice());
    }

    #[test]
    #[serial_test::serial(file)]
    fn test_sst_key_value_codec() {
        use crate::file::FileSystemRegistry;
        use crate::sst::iterator::{SSTIterator, SSTIteratorOptions};
        use crate::sst::writer::{SSTWriter, SSTWriterOptions};

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_test");
        let registry = FileSystemRegistry::new();
        let fs = registry
            .get_or_register("file:///tmp/sst_row_codec_test".to_string())
            .unwrap();

        // Define schema: 2 columns (name, email)
        let num_columns = 2;

        // Create test Key and Value using the codec
        let key1 = Key::new(1, b"user:1".to_vec());
        let value1 = Value::new(vec![
            Some(Column::new(ValueType::Put, b"Alice".to_vec())),
            Some(Column::new(ValueType::Put, b"alice@example.com".to_vec())),
        ]);

        let key2 = Key::new(1, b"user:2".to_vec());
        // user:2 has no email (optional column)
        let value2 = Value::new(vec![
            Some(Column::new(ValueType::Put, b"Bob".to_vec())),
            None,
        ]);

        let key3 = Key::new(2, b"order:100".to_vec());
        // order:100 is deleted (all columns absent)
        let value3 = Value::new(vec![None, None]);

        // Write SST file with encoded Key/Value
        {
            let writer_file = fs.open_write("codec_test.sst").unwrap();
            let mut writer = SSTWriter::new(
                writer_file,
                SSTWriterOptions {
                    bloom_filter_enabled: true,
                    ..SSTWriterOptions::default()
                },
            );

            writer
                .add(&encode_key(&key1), &encode_value(&value1, num_columns))
                .unwrap();
            writer
                .add(&encode_key(&key2), &encode_value(&value2, num_columns))
                .unwrap();
            writer
                .add(&encode_key(&key3), &encode_value(&value3, num_columns))
                .unwrap();

            writer.finish().unwrap();
        }

        // Read SST file and decode Key/Value
        {
            let reader_file = fs.open_read("codec_test.sst").unwrap();
            let mut iter = SSTIterator::with_cache(
                reader_file,
                0,
                SSTIteratorOptions {
                    bloom_filter_enabled: true,
                    ..SSTIteratorOptions::default()
                },
                None,
                None,
            )
            .unwrap();

            iter.seek_to_first().unwrap();

            // First entry: user:1 with name="Alice", email="alice@example.com"
            assert!(iter.valid());
            let (mut key_bytes, mut value_bytes) = iter.current().unwrap().unwrap();
            let decoded_key = decode_key(&mut key_bytes).unwrap();
            let decoded_value = decode_value(&mut value_bytes, num_columns).unwrap();
            let decoded_cols = decoded_value.columns();

            assert_eq!(decoded_key.bucket(), 1);
            assert_eq!(decoded_key.data().as_ref(), b"user:1");
            assert_eq!(decoded_cols.len(), 2);
            assert!(decoded_cols[0].is_some());
            assert_eq!(decoded_cols[0].as_ref().unwrap().data().as_ref(), b"Alice");
            assert!(decoded_cols[1].is_some());
            assert_eq!(
                decoded_cols[1].as_ref().unwrap().data().as_ref(),
                b"alice@example.com"
            );

            // Second entry: user:2 with name="Bob", email=None
            iter.next().unwrap();
            assert!(iter.valid());
            let (mut key_bytes, mut value_bytes) = iter.current().unwrap().unwrap();
            let decoded_key = decode_key(&mut key_bytes).unwrap();
            let decoded_value = decode_value(&mut value_bytes, num_columns).unwrap();
            let decoded_cols = decoded_value.columns();

            assert_eq!(decoded_key.bucket(), 1);
            assert_eq!(decoded_key.data().as_ref(), b"user:2");
            assert!(decoded_cols[0].is_some());
            assert_eq!(decoded_cols[0].as_ref().unwrap().data().as_ref(), b"Bob");
            assert!(decoded_cols[1].is_none());

            // Third entry: order:100 with all columns absent
            iter.next().unwrap();
            assert!(iter.valid());
            let (mut key_bytes, mut value_bytes) = iter.current().unwrap().unwrap();
            let decoded_key = decode_key(&mut key_bytes).unwrap();
            let decoded_value = decode_value(&mut value_bytes, num_columns).unwrap();
            let decoded_cols = decoded_value.columns();

            assert_eq!(decoded_key.bucket(), 2);
            assert_eq!(decoded_key.data().as_ref(), b"order:100");
            assert!(decoded_cols[0].is_none());
            assert!(decoded_cols[1].is_none());

            // No more entries
            iter.next().unwrap();
            assert!(!iter.valid());
        }

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_test");
    }

    #[test]
    #[serial_test::serial(file)]
    fn test_sst_key_value_codec_seek() {
        use crate::file::FileSystemRegistry;
        use crate::sst::iterator::{SSTIterator, SSTIteratorOptions};
        use crate::sst::writer::{SSTWriter, SSTWriterOptions};

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_seek_test");
        let registry = FileSystemRegistry::new();
        let fs = registry
            .get_or_register("file:///tmp/sst_row_codec_seek_test".to_string())
            .unwrap();

        let num_columns = 1;

        let key1 = Key::new(1, b"aaa".to_vec());
        let key2 = Key::new(1, b"bbb".to_vec());
        let key3 = Key::new(2, b"aaa".to_vec());

        let value = Value::new(vec![Some(Column::new(ValueType::Put, b"test".to_vec()))]);

        // Write SST file
        {
            let writer_file = fs.open_write("codec_seek_test.sst").unwrap();
            let mut writer = SSTWriter::new(
                writer_file,
                SSTWriterOptions {
                    bloom_filter_enabled: true,
                    ..SSTWriterOptions::default()
                },
            );

            writer
                .add(&encode_key(&key1), &encode_value(&value, num_columns))
                .unwrap();
            writer
                .add(&encode_key(&key2), &encode_value(&value, num_columns))
                .unwrap();
            writer
                .add(&encode_key(&key3), &encode_value(&value, num_columns))
                .unwrap();

            writer.finish().unwrap();
        }

        // Read and seek using encoded key
        {
            let reader_file = fs.open_read("codec_seek_test.sst").unwrap();
            let mut iter = SSTIterator::with_cache(
                reader_file,
                0,
                SSTIteratorOptions {
                    bloom_filter_enabled: true,
                    ..SSTIteratorOptions::default()
                },
                None,
                None,
            )
            .unwrap();

            // Seek to second key
            let seek_key = Key::new(1, b"bbb".to_vec());
            iter.seek(&encode_key(&seek_key)).unwrap();
            assert!(iter.valid());

            let (mut key_bytes, _) = iter.current().unwrap().unwrap();
            let decoded_key = decode_key(&mut key_bytes).unwrap();
            assert_eq!(decoded_key.bucket(), 1);
            assert_eq!(decoded_key.data().as_ref(), b"bbb");
        }

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_seek_test");
    }

    #[test]
    #[serial_test::serial(file)]
    fn test_sst_key_value_codec_multiple_blocks() {
        use crate::file::FileSystemRegistry;
        use crate::sst::iterator::{SSTIterator, SSTIteratorOptions};
        use crate::sst::writer::{SSTWriter, SSTWriterOptions};

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_blocks_test");
        let registry = FileSystemRegistry::new();
        let fs = registry
            .get_or_register("file:///tmp/sst_row_codec_blocks_test".to_string())
            .unwrap();

        let num_columns = 2;
        let num_entries = 50;

        // Write SST file with many entries across multiple blocks
        {
            let writer_file = fs.open_write("codec_blocks_test.sst").unwrap();
            let mut writer = SSTWriter::new(
                writer_file,
                SSTWriterOptions {
                    metrics: None,
                    block_size: 200, // Small block size to force multiple blocks
                    buffer_size: 8192,
                    num_columns,
                    bloom_filter_enabled: true,
                    bloom_bits_per_key: 10,
                    partitioned_index: false,
                    compression: crate::SstCompressionAlgorithm::None,
                },
            );

            for i in 0..num_entries {
                let key = Key::new(i as u16, format!("key{:04}", i).into_bytes());
                let col1 = Column::new(ValueType::Put, format!("val{:04}", i).into_bytes());
                let col2 = Column::new(ValueType::Merge, b"extra".to_vec());
                // Alternate: some entries have second column, some don't
                let value = if i % 2 == 0 {
                    Value::new(vec![Some(col1), Some(col2)])
                } else {
                    Value::new(vec![Some(col1), None])
                };
                writer
                    .add(&encode_key(&key), &encode_value(&value, num_columns))
                    .unwrap();
            }

            writer.finish().unwrap();
        }

        // Read and verify all entries
        {
            let reader_file = fs.open_read("codec_blocks_test.sst").unwrap();
            let mut iter = SSTIterator::with_cache(
                reader_file,
                0,
                SSTIteratorOptions {
                    bloom_filter_enabled: true,
                    ..SSTIteratorOptions::default()
                },
                None,
                None,
            )
            .unwrap();

            iter.seek_to_first().unwrap();

            let mut count = 0;
            while iter.valid() {
                let (mut key_bytes, mut value_bytes) = iter.current().unwrap().unwrap();
                let decoded_key = decode_key(&mut key_bytes).unwrap();
                let decoded_value = decode_value(&mut value_bytes, num_columns).unwrap();
                let decoded_cols = decoded_value.columns();

                assert_eq!(decoded_key.bucket(), count as u16);
                assert_eq!(
                    decoded_key.data().as_ref(),
                    format!("key{:04}", count).as_bytes()
                );

                assert!(decoded_cols[0].is_some());
                assert_eq!(
                    decoded_cols[0].as_ref().unwrap().data().as_ref(),
                    format!("val{:04}", count).as_bytes()
                );

                // Even entries have second column
                if count % 2 == 0 {
                    assert!(decoded_cols[1].is_some());
                } else {
                    assert!(decoded_cols[1].is_none());
                }

                count += 1;
                iter.next().unwrap();
            }

            assert_eq!(count, num_entries);
        }

        let _ = std::fs::remove_dir_all("/tmp/sst_row_codec_blocks_test");
    }
}