clippy 0.0.8

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64

use rustc::plugin::Registry;
use rustc::lint::*;
use rustc::middle::const_eval::lookup_const_by_id;
use rustc::middle::def::*;
use syntax::ast::*;
use syntax::ast_util::{is_comparison_binop, binop_to_string};
use syntax::ptr::P;
use syntax::codemap::Span;
use std::f64::consts as f64;
use utils::span_lint;

declare_lint! {
    pub APPROX_CONSTANT,
    Warn,
    "Warn if a user writes an approximate known constant in their code"
}

const KNOWN_CONSTS : &'static [(f64, &'static str)] = &[(f64::E, "E"), (f64::FRAC_1_PI, "FRAC_1_PI"), 
	(f64::FRAC_1_SQRT_2, "FRAC_1_SQRT_2"), (f64::FRAC_2_PI, "FRAC_2_PI"), 
	(f64::FRAC_2_SQRT_PI, "FRAC_2_SQRT_PI"), (f64::FRAC_PI_2, "FRAC_PI_2"), (f64::FRAC_PI_3, "FRAC_PI_3"),
	(f64::FRAC_PI_4, "FRAC_PI_4"), (f64::FRAC_PI_6, "FRAC_PI_6"), (f64::FRAC_PI_8, "FRAC_PI_8"), 
	(f64::LN_10, "LN_10"), (f64::LN_2, "LN_2"), (f64::LOG10_E, "LOG10_E"), (f64::LOG2_E, "LOG2_E"),
	(f64::PI, "PI"), (f64::SQRT_2, "SQRT_2")];

const EPSILON_DIVISOR : f64 = 8192f64; //TODO: test to find a good value

#[derive(Copy,Clone)]
pub struct ApproxConstant;

impl LintPass for ApproxConstant {
    fn get_lints(&self) -> LintArray {
        lint_array!(APPROX_CONSTANT)
    }
    
    fn check_expr(&mut self, cx: &Context, e: &Expr) {
		if let &ExprLit(ref lit) = &e.node {
			check_lit(cx, lit, e.span);
		}
    }
}

fn check_lit(cx: &Context, lit: &Lit, span: Span) {
	match &lit.node {
		&LitFloat(ref str, TyF32) => check_known_consts(cx, span, str, "f32"),
		&LitFloat(ref str, TyF64) => check_known_consts(cx, span, str, "f64"),
		&LitFloatUnsuffixed(ref str) => check_known_consts(cx, span, str, "f{32, 64}"),
		_ => ()
	}
}

fn check_known_consts(cx: &Context, span: Span, str: &str, module: &str) {
	if let Ok(value) = str.parse::<f64>() {
		for &(constant, name) in KNOWN_CONSTS {
			if within_epsilon(constant, value) {
				span_lint(cx, APPROX_CONSTANT, span, &format!(
					"Approximate value of {}::{} found, consider using it directly.", module, &name));
			}
		}
	}
}

fn within_epsilon(target: f64, value: f64) -> bool {
	f64::abs(value - target) < f64::abs((if target > value { target } else { value })) / EPSILON_DIVISOR
}