clippy 0.0.23

A bunch of helpful lints to avoid common pitfalls in Rust
1
2
3
4
5
6
7
8
9
10
11
12

#![feature(plugin)]
#![plugin(clippy)]

#[deny(needless_bool)]
fn main() {
    let x = true;
    if x { true } else { true }; //~ERROR this if-then-else expression will always return true
    if x { false } else { false }; //~ERROR this if-then-else expression will always return false
    if x { true } else { false }; //~ERROR you can reduce this if-then-else expression to just `x`
    if x { false } else { true }; //~ERROR you can reduce this if-then-else expression to just `!x`
    if x { x } else { false }; // would also be questionable, but we don't catch this yet
}