clippier 0.3.0

MoosicBox clippier package
Documentation 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252

#[cfg(feature = "git-diff")]
use clippier::git_diff::{
    build_external_dependency_map, find_packages_affected_by_external_deps,
    find_transitively_affected_external_deps,
};

use clippier::test_utils::test_resources::{load_cargo_lock_for_git_diff, load_test_workspace};

#[cfg(feature = "git-diff")]
#[switchy_async::test]
async fn test_build_external_dependency_map() {
    let (temp_dir, workspace_members) = load_test_workspace("basic");

    let external_dep_map = build_external_dependency_map(temp_dir.path(), &workspace_members)
        .expect("Failed to build external dependency map");

    insta::assert_debug_snapshot!(external_dep_map, @r###"
    {
        "reqwest": [
            "api",
            "client",
        ],
        "serde": [
            "api",
            "models",
        ],
        "tokio": [
            "api",
        ],
    }
    "###);
}

#[cfg(feature = "git-diff")]
#[switchy_async::test]
async fn test_end_to_end_external_dependency_analysis() {
    let (temp_dir, workspace_members) = load_test_workspace("basic");

    // Load the comprehensive Cargo.lock from test resources
    let cargo_lock = load_cargo_lock_for_git_diff("basic", "comprehensive");

    // Test scenario: pin-project-lite changes
    let directly_changed_deps = vec!["pin-project-lite".to_string()];
    let all_affected_external_deps =
        find_transitively_affected_external_deps(&cargo_lock, &directly_changed_deps);

    insta::assert_debug_snapshot!(all_affected_external_deps, @r###"
    [
        "api",
        "client",
        "pin-project-lite",
        "reqwest",
        "tokio",
    ]
    "###);

    // Build external dependency map
    let external_dep_map = build_external_dependency_map(temp_dir.path(), &workspace_members)
        .expect("Failed to build external dependency map");

    // Find workspace packages affected by the external dependency changes
    let affected_workspace_packages =
        find_packages_affected_by_external_deps(&external_dep_map, &all_affected_external_deps);

    insta::assert_debug_snapshot!(affected_workspace_packages, @r###"
    [
        "api",
        "client",
    ]
    "###);
}

#[cfg(feature = "git-diff")]
#[switchy_async::test]
async fn test_deep_transitive_dependency_change() {
    let (temp_dir, workspace_members) = load_test_workspace("basic");

    // Load the complex deep dependencies Cargo.lock from test resources
    let cargo_lock = load_cargo_lock_for_git_diff("deep-deps", "complex");

    // Test scenario: openssl-sys changes (affects multiple levels)
    let directly_changed_deps = vec!["openssl-sys".to_string()];
    let all_affected_external_deps =
        find_transitively_affected_external_deps(&cargo_lock, &directly_changed_deps);

    insta::assert_debug_snapshot!(all_affected_external_deps, @r###"
    [
        "my-http-client",
        "native-tls",
        "openssl",
        "openssl-sys",
        "reqwest",
    ]
    "###);

    // Build external dependency map
    let external_dep_map = build_external_dependency_map(temp_dir.path(), &workspace_members)
        .expect("Failed to build external dependency map");

    // Find workspace packages affected by the external dependency changes
    let affected_workspace_packages =
        find_packages_affected_by_external_deps(&external_dep_map, &all_affected_external_deps);

    // In this case, the basic workspace doesn't have my-http-client,
    // but it would be affected if we had a workspace with that package
    insta::assert_debug_snapshot!(affected_workspace_packages, @r###"
    [
        "api",
        "client",
    ]
    "###);
}

#[cfg(feature = "git-diff")]
#[switchy_async::test]
async fn test_multiple_level_dependency_changes() {
    let (temp_dir, workspace_members) = load_test_workspace("basic");

    // Load comprehensive Cargo.lock that includes multiple-level dependencies
    let cargo_lock = load_cargo_lock_for_git_diff("basic", "comprehensive");

    // Test scenario: multiple dependencies change at once
    let directly_changed_deps = vec!["serde".to_string(), "tokio".to_string()];
    let all_affected_external_deps =
        find_transitively_affected_external_deps(&cargo_lock, &directly_changed_deps);

    insta::assert_debug_snapshot!(all_affected_external_deps, @r###"
    [
        "api",
        "client",
        "models",
        "reqwest",
        "serde",
        "serde_json",
        "tokio",
    ]
    "###);

    // Build external dependency map
    let external_dep_map = build_external_dependency_map(temp_dir.path(), &workspace_members)
        .expect("Failed to build external dependency map");

    // Find workspace packages affected by the external dependency changes
    let affected_workspace_packages =
        find_packages_affected_by_external_deps(&external_dep_map, &all_affected_external_deps);

    insta::assert_debug_snapshot!(affected_workspace_packages, @r###"
    [
        "api",
        "client",
        "models",
    ]
    "###);
}

#[cfg(feature = "git-diff")]
#[switchy_async::test]
async fn test_no_transitive_impact() {
    let (temp_dir, workspace_members) = load_test_workspace("basic");

    // Create a test scenario where a dependency changes but doesn't affect workspace packages
    let cargo_lock = load_cargo_lock_for_git_diff("basic", "simple");

    // Test scenario: only external dependencies change, no workspace impact
    let directly_changed_deps = vec!["some-unrelated-crate".to_string()];
    let all_affected_external_deps =
        find_transitively_affected_external_deps(&cargo_lock, &directly_changed_deps);

    // Should only include the directly changed dependency since it doesn't exist in our cargo lock
    insta::assert_debug_snapshot!(all_affected_external_deps, @r###"
    [
        "some-unrelated-crate",
    ]
    "###);

    // Build external dependency map
    let external_dep_map = build_external_dependency_map(temp_dir.path(), &workspace_members)
        .expect("Failed to build external dependency map");

    // Find workspace packages affected by the external dependency changes
    let affected_workspace_packages =
        find_packages_affected_by_external_deps(&external_dep_map, &all_affected_external_deps);

    // Should be empty since the changed external dependency doesn't affect any workspace packages
    insta::assert_debug_snapshot!(affected_workspace_packages, @"[]");
}

#[switchy_async::test]
async fn test_git_submodules_with_chunking_and_spreading() {
    use clippier::{OutputType, handle_features_command};
    use clippier_test_utilities::test_resources::load_test_workspace;

    let (temp_dir, _) = load_test_workspace("git-submodules");

    let result = handle_features_command(
        temp_dir.path().to_str().unwrap(),
        None,
        None,
        None,
        Some(2),
        None,
        true,
        true,
        Some(12345),
        None,
        None,
        None,
        None,
        None,
        #[cfg(feature = "git-diff")]
        None,
        #[cfg(feature = "git-diff")]
        None,
        false,
        None,
        &[],
        &[],
        #[cfg(feature = "_transforms")]
        &[],
        #[cfg(feature = "_transforms")]
        false,
        #[cfg(feature = "_workspace")]
        None, // workspace_type filter
        OutputType::Json,
    )
    .await
    .unwrap();

    let parsed: serde_json::Value = serde_json::from_str(&result).unwrap();

    let with_submodules_entries: Vec<_> = parsed
        .as_array()
        .unwrap()
        .iter()
        .filter(|p| p["name"].as_str() == Some("with-submodules"))
        .collect();

    for entry in with_submodules_entries {
        assert_eq!(entry["gitSubmodules"].as_bool(), Some(true));
    }

    let without_submodules_entries: Vec<_> = parsed
        .as_array()
        .unwrap()
        .iter()
        .filter(|p| p["name"].as_str() == Some("without-submodules"))
        .collect();

    for entry in without_submodules_entries {
        assert!(entry.get("gitSubmodules").is_none() || entry["gitSubmodules"].is_null());
    }
}