claudette 0.7.0

//! Brownfield missions — session-scoped active workspace pointing at a
//! cloned external repo under `~/.claudette/missions/<slug>/`.
//!
//! T1 (already shipped) gave the brain the 5 brownfield tools (`git_clone`,
//! `gh_list_repo_issues`, `gh_pr_status`, `gh_fork`, `gh_create_pr`) but
//! every shell/git/file tool still ran in claudette's launch cwd — so once
//! a repo was cloned, the brain couldn't drive `git_status`/`commit`/`push`
//! against the new tree from the same session. T2 closes that gap by
//! introducing a single piece of session state, the **active mission**.
//! While a mission is active, `tools::active_cwd()` resolves to the mission
//! root and the cwd-routing primitive in git/shell/file_ops/search uses
//! that instead of the workspace cwd.
//!
//! Persistence: a JSON marker file at
//! `~/.claudette/missions/<slug>/.claudette-mission.json` survives restart
//! so missions are recoverable, but **auto-attach is intentionally not
//! done** on startup — the user opts in via `mission_attach` (deferred from
//! T2 first cut) when they want to resume.

use std::path::{Path, PathBuf};
use std::sync::atomic::{AtomicBool, Ordering};
use std::sync::{Mutex, OnceLock};

use serde::{Deserialize, Serialize};

/// On-disk marker filename, sat at the root of every mission tree.
pub const MARKER_FILENAME: &str = ".claudette-mission.json";

/// Pointer-file name under `~/.claudette/` that names the currently-active
/// non-ephemeral mission. Written by [`set_active`] on `/brownfield` /
/// `mission_attach`, removed by [`clear_active`], and consumed by
/// [`try_rehydrate_active_mission`] at REPL/TUI startup so missions survive
/// a process restart. Ephemeral missions are deliberately not persisted —
/// they're a per-process auto-bootstrap convenience tied to cwd-at-launch.
pub const ACTIVE_POINTER_FILENAME: &str = "active_mission.json";

/// One brownfield mission: a slug pointing at a cloned tree on disk.
///
/// `repo` is the canonical `owner/repo` form when the mission was started
/// from a GitHub URL (so `mission_submit` knows where to open the PR);
/// `None` for missions cloned from a non-GitHub remote, in which case
/// `mission_submit` will refuse with a clear error rather than guess.
#[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)]
pub struct Mission {
    pub slug: String,
    pub path: PathBuf,
    pub repo: Option<String>,
    pub created_at: i64,
    /// True for ephemeral missions auto-bootstrapped by `--forge` /
    /// `/forge` when run inside an existing git repo with no active
    /// mission (no clone, no on-disk marker). Set to false (the serde
    /// default) for `/brownfield` missions and missions loaded from a
    /// persisted marker — they survive across forge runs and are not
    /// auto-cleared on failure.
    #[serde(default)]
    pub ephemeral: bool,
}

/// Process-wide active-mission slot. `OnceLock<Mutex<…>>` rather than a
/// plain static so initialisation is lazy and lock acquisition is honest
/// about its potential to block (it won't, in practice — every callsite
/// holds the lock for microseconds).
fn active_slot() -> &'static Mutex<Option<Mission>> {
    static SLOT: OnceLock<Mutex<Option<Mission>>> = OnceLock::new();
    SLOT.get_or_init(|| Mutex::new(None))
}

/// Resolve `~/.claudette/missions/`. Mirrors the home-resolution pattern in
/// `crate::secrets::secrets_dir` and `tools::git::missions_root`.
#[must_use]
pub fn missions_root() -> PathBuf {
    let home = std::env::var("USERPROFILE")
        .or_else(|_| std::env::var("HOME"))
        .unwrap_or_else(|_| ".".to_string());
    PathBuf::from(home).join(".claudette").join("missions")
}

/// Validate a mission slug. Same rules as `git_clone`'s dest validator:
/// single path component, no `..`, no `/`, `\`, or `:` (Windows drive
/// prefix). Trims and returns the canonical form.
pub fn validate_slug(slug: &str) -> Result<String, String> {
    let trimmed = slug.trim();
    if trimmed.is_empty() {
        return Err("mission: empty slug".to_string());
    }
    if trimmed.contains("..") {
        return Err(format!("mission: slug may not contain '..' ({trimmed})"));
    }
    if trimmed.contains('/') || trimmed.contains('\\') {
        return Err(format!(
            "mission: slug must be a single directory name, not a path ({trimmed})"
        ));
    }
    if trimmed.contains(':') {
        return Err(format!("mission: slug may not contain ':' ({trimmed})"));
    }
    Ok(trimmed.to_string())
}

/// Snapshot the currently-active mission (clones out of the lock).
#[must_use]
pub fn active_mission() -> Option<Mission> {
    active_slot().lock().ok().and_then(|guard| guard.clone())
}

/// Return the cwd that subprocess-based tools (git, bash, etc.) should
/// run in. While a mission is active that's the mission root; otherwise
/// the process cwd (claudette's launch directory).
#[must_use]
pub fn active_cwd() -> PathBuf {
    if let Some(m) = active_mission() {
        return m.path;
    }
    std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."))
}

/// Make `mission` the active one. One mission at a time per session
/// (design pick #2): if another mission is already active, errors so the
/// caller can surface "exit current mission first" to the brain.
///
/// Side effect: non-ephemeral missions are written to the
/// `~/.claudette/active_mission.json` pointer file so the next REPL/TUI
/// process can rehydrate them via [`try_rehydrate_active_mission`].
/// Ephemeral missions are intentionally not persisted — they're a
/// per-process auto-bootstrap convenience.
pub fn set_active(mission: Mission) -> Result<(), String> {
    let mut guard = active_slot()
        .lock()
        .map_err(|_| "mission: active slot poisoned".to_string())?;
    if let Some(existing) = guard.as_ref() {
        return Err(format!(
            "mission: '{}' is already active — exit it first with mission_exit",
            existing.slug
        ));
    }
    if !mission.ephemeral {
        // Best-effort: if writing the pointer fails (read-only home, full
        // disk), we still install the in-memory slot. The worst case is a
        // restart not rehydrating — same as the pre-fix behaviour.
        let _ = write_active_pointer(&mission);
    }
    *guard = Some(mission);
    Ok(())
}

/// Clear the active mission. Returns the slug that was cleared (for
/// caller-side logging); `None` if nothing was active. Always removes the
/// pointer file, so a `clear_active` after a persisted mission also wipes
/// the on-disk rehydrate hint.
pub fn clear_active() -> Option<String> {
    let mut guard = active_slot().lock().ok()?;
    let taken = guard.take();
    remove_active_pointer();
    taken.map(|m| m.slug)
}

// ── Brownfield-failed-this-session sticky flag ────────────────────────────
//
// Set when `/brownfield` errors in the REPL (e.g. target already exists,
// network failure). Read by `run_forge_mission` before falling back to
// `try_bootstrap_local_mission`: if the user tried `/brownfield` and it
// failed, the cwd auto-bootstrap is refused so they can't accidentally
// operate forge on their dev repo. Cleared on the next successful
// `/brownfield`, on `/mission_exit` (the slash handler and the brain tool
// both clear it before calling `clear_active`), or by an explicit call to
// [`clear_brownfield_failed`]. Note that `clear_active` itself does NOT
// clear the flag — only the higher-level user-driven actions do, so a
// programmatic `clear_active` deep in the EphemeralMissionGuard's Drop
// path doesn't accidentally unpoison the session.
static BROWNFIELD_FAILED: AtomicBool = AtomicBool::new(false);

/// Mark that a `/brownfield` invocation failed in this process. Forge will
/// refuse to auto-bootstrap a cwd-rooted mission while this flag is set.
pub fn mark_brownfield_failed() {
    BROWNFIELD_FAILED.store(true, Ordering::SeqCst);
}

/// Whether the user has tried `/brownfield` and it failed this process.
#[must_use]
pub fn brownfield_failed_this_session() -> bool {
    BROWNFIELD_FAILED.load(Ordering::SeqCst)
}

/// Clear the sticky brownfield-failed flag. Called after a successful
/// `/brownfield` and on explicit `mission_exit`.
pub fn clear_brownfield_failed() {
    BROWNFIELD_FAILED.store(false, Ordering::SeqCst);
}

/// Attempt to bootstrap an ephemeral mission rooted at the git toplevel of
/// the current working directory. Used by `--forge` / `/forge` so the user
/// can invoke forge-mode against the repo they're already in without first
/// running `mission_start` / `/brownfield`.
///
/// Returns `Ok(Mission)` only when **all** of:
/// - cwd is inside a git working tree (`git rev-parse --show-toplevel`
///   succeeds with a non-empty path),
/// - that toplevel resolves under `$HOME` *or* any path in
///   `CLAUDETTE_WORKSPACE` (so out-of-home repos that the user has
///   explicitly opted into are allowed, but a system dir like `/etc/foo`
///   is not).
///
/// Returns `Err(reason)` for "no git repo here" / "outside permitted
/// roots" so the caller can surface a clear message about why auto-
/// bootstrap declined. Does NOT call `set_active` — the caller decides
/// whether to install the mission, since the slot is a process-wide
/// singleton and we want the install + clear-on-error pair to live at
/// the same level.
pub fn try_bootstrap_local_mission() -> Result<Mission, String> {
    let toplevel = match std::process::Command::new("git")
        .args(["rev-parse", "--show-toplevel"])
        .output()
    {
        Ok(out) if out.status.success() => {
            let raw = String::from_utf8_lossy(&out.stdout).trim().to_string();
            if raw.is_empty() {
                return Err("not inside a git working tree (empty toplevel)".to_string());
            }
            PathBuf::from(raw)
        }
        Ok(out) => {
            let stderr = String::from_utf8_lossy(&out.stderr);
            return Err(format!(
                "git rev-parse --show-toplevel failed: {}",
                stderr.trim().chars().take(160).collect::<String>()
            ));
        }
        Err(e) => return Err(format!("git not on PATH: {e}")),
    };

    // Permit only if the toplevel lives under $HOME or one of the
    // CLAUDETTE_WORKSPACE roots — the same envelope that `validate_read_path`
    // enforces for tool reads. This prevents `--forge` in `/etc` from
    // silently rooting a mission outside the safe surface.
    if !path_under_permitted_roots(&toplevel) {
        return Err(format!(
            "git repo at {} is outside $HOME and CLAUDETTE_WORKSPACE — \
             set CLAUDETTE_WORKSPACE=\"$(pwd)\" first if you intend forge \
             to operate on this tree",
            toplevel.display()
        ));
    }

    let slug = toplevel
        .file_name()
        .and_then(|s| s.to_str())
        .unwrap_or("local")
        .to_string();
    let now = std::time::SystemTime::now()
        .duration_since(std::time::UNIX_EPOCH)
        .ok()
        .and_then(|d| i64::try_from(d.as_secs()).ok())
        .unwrap_or(0);

    Ok(Mission {
        slug,
        path: toplevel,
        repo: None,
        created_at: now,
        ephemeral: true,
    })
}

/// Whether `path` is under `$HOME` or any `CLAUDETTE_WORKSPACE` root.
/// Pure helper — no side effects. Public to allow tests to assert the
/// auto-bootstrap envelope without spawning a git child process.
#[must_use]
pub fn path_under_permitted_roots(path: &Path) -> bool {
    let home = std::env::var("USERPROFILE")
        .or_else(|_| std::env::var("HOME"))
        .ok()
        .map(PathBuf::from);
    if let Some(home) = home {
        if path.starts_with(&home) {
            return true;
        }
    }
    if let Ok(ws) = std::env::var("CLAUDETTE_WORKSPACE") {
        #[cfg(unix)]
        let sep = ':';
        #[cfg(not(unix))]
        let sep = ';';
        for root in ws.split(sep).map(str::trim).filter(|s| !s.is_empty()) {
            if path.starts_with(root) {
                return true;
            }
        }
    }
    false
}

/// Path of the on-disk marker for a given mission tree.
#[must_use]
pub fn marker_path_for(mission_path: &Path) -> PathBuf {
    mission_path.join(MARKER_FILENAME)
}

/// Resolve `~/.claudette/active_mission.json` — the pointer file that
/// names the active non-ephemeral mission across process restarts.
#[must_use]
pub fn active_pointer_path() -> PathBuf {
    // Sibling of `missions/`, so derive from missions_root()'s parent
    // rather than re-resolving `$HOME`.
    let claudette_dir = missions_root()
        .parent()
        .map_or_else(|| PathBuf::from("."), Path::to_path_buf);
    claudette_dir.join(ACTIVE_POINTER_FILENAME)
}

/// Write the active-mission pointer file. Called by [`set_active`] for
/// non-ephemeral missions. Best-effort — disk errors are returned but
/// `set_active` ignores them (worst case: restart doesn't rehydrate).
pub fn write_active_pointer(mission: &Mission) -> Result<(), String> {
    let path = active_pointer_path();
    if let Some(parent) = path.parent() {
        if !parent.exists() {
            std::fs::create_dir_all(parent)
                .map_err(|e| format!("mission: create {} failed: {e}", parent.display()))?;
        }
    }
    let json = serde_json::to_string_pretty(mission)
        .map_err(|e| format!("mission: serialize active pointer: {e}"))?;
    std::fs::write(&path, json)
        .map_err(|e| format!("mission: write {} failed: {e}", path.display()))?;
    Ok(())
}

/// Remove the active-mission pointer file. Best-effort — missing-file
/// errors are swallowed.
pub fn remove_active_pointer() {
    let _ = std::fs::remove_file(active_pointer_path());
}

/// Outcome of [`try_rehydrate_active_mission`] — used by REPL/TUI startup
/// to print a clear banner about whether a mission was restored, why one
/// wasn't, or why the on-disk pointer was discarded.
#[derive(Debug, Clone, PartialEq, Eq)]
pub enum RehydrateOutcome {
    /// No pointer file existed — fresh start.
    None,
    /// Pointer loaded, validated, and installed as the active mission.
    Rehydrated(Mission),
    /// Pointer existed but was stale (path missing / not a git tree /
    /// malformed JSON). The pointer file has been removed.
    Cleared { reason: String, path: PathBuf },
}

/// Read `~/.claudette/active_mission.json` and install the named mission
/// as the active one if its tree still exists and looks like a git
/// working copy. Called once at REPL/TUI startup so non-ephemeral
/// missions survive process restart (F8a).
///
/// Stale pointers (path removed by the user, mission tree no longer a
/// git repo, malformed JSON) are auto-cleared rather than left to
/// poison subsequent runs.
pub fn try_rehydrate_active_mission() -> RehydrateOutcome {
    let path = active_pointer_path();
    if !path.exists() {
        return RehydrateOutcome::None;
    }
    let text = match std::fs::read_to_string(&path) {
        Ok(t) => t,
        Err(e) => {
            let _ = std::fs::remove_file(&path);
            return RehydrateOutcome::Cleared {
                reason: format!("read failed: {e}"),
                path,
            };
        }
    };
    let mission: Mission = match serde_json::from_str(&text) {
        Ok(m) => m,
        Err(e) => {
            let _ = std::fs::remove_file(&path);
            return RehydrateOutcome::Cleared {
                reason: format!("parse failed: {e}"),
                path,
            };
        }
    };
    if !mission.path.is_dir() {
        let _ = std::fs::remove_file(&path);
        return RehydrateOutcome::Cleared {
            reason: format!("mission tree {} no longer exists", mission.path.display()),
            path,
        };
    }
    if !mission.path.join(".git").exists() {
        let _ = std::fs::remove_file(&path);
        return RehydrateOutcome::Cleared {
            reason: format!("{} is not a git working tree", mission.path.display()),
            path,
        };
    }
    // Install. If the slot is already occupied (shouldn't happen at
    // startup, but be defensive), silently leave the existing one in
    // place and clear the pointer rather than erroring.
    match set_active(mission.clone()) {
        Ok(()) => RehydrateOutcome::Rehydrated(mission),
        Err(e) => {
            let _ = std::fs::remove_file(&path);
            RehydrateOutcome::Cleared {
                reason: format!("install failed: {e}"),
                path,
            }
        }
    }
}

/// Write the JSON marker into the mission tree. Called by `mission_start`
/// right after a successful clone so the mission is recoverable.
pub fn save_marker(mission: &Mission) -> Result<(), String> {
    let path = marker_path_for(&mission.path);
    let json = serde_json::to_string_pretty(mission)
        .map_err(|e| format!("mission: serialize marker: {e}"))?;
    std::fs::write(&path, json)
        .map_err(|e| format!("mission: write {} failed: {e}", path.display()))?;
    Ok(())
}

/// Add the mission-marker filename to the mission tree's
/// `.git/info/exclude` so `git add -A` (used by `mission_submit`) doesn't
/// pull it into commits. Using the per-repo exclude file — rather than the
/// tracked `.gitignore` — keeps the rule local to claudette's clone without
/// modifying anything the upstream repo owns.
///
/// Idempotent: if the line is already present (e.g. from a re-attach to an
/// existing tree), this is a no-op. Best-effort — if `.git/info/` doesn't
/// look like a normal git directory (e.g. a worktree pointer file rather
/// than a directory), the function returns Ok without touching anything;
/// the caller's `save_marker` step proceeds and the worst case is the
/// pre-fix behaviour of the marker landing in the PR.
pub fn add_marker_to_git_exclude(mission_path: &Path) -> Result<(), String> {
    let info_dir = mission_path.join(".git").join("info");
    if !info_dir.is_dir() {
        // Try to create it — fresh clones always have `.git/` as a real
        // directory, but `info/` is sometimes absent on minimal templates.
        // If creation fails (e.g. `.git` is a worktree pointer file),
        // silently skip: we'd rather leak the marker than fail mission
        // start over a cosmetic cleanup.
        if std::fs::create_dir_all(&info_dir).is_err() {
            return Ok(());
        }
    }
    let exclude_path = info_dir.join("exclude");
    let existing = std::fs::read_to_string(&exclude_path).unwrap_or_default();
    if existing
        .lines()
        .any(|l| l.trim() == MARKER_FILENAME || l.trim() == format!("/{MARKER_FILENAME}"))
    {
        return Ok(());
    }
    let mut updated = existing;
    if !updated.is_empty() && !updated.ends_with('\n') {
        updated.push('\n');
    }
    updated.push_str(MARKER_FILENAME);
    updated.push('\n');
    std::fs::write(&exclude_path, updated)
        .map_err(|e| format!("mission: write {} failed: {e}", exclude_path.display()))?;
    Ok(())
}

/// Read a marker JSON back into a `Mission`. Used by `mission_list` and
/// (later) `mission_attach`.
pub fn load_marker(mission_path: &Path) -> Result<Mission, String> {
    let path = marker_path_for(mission_path);
    let text = std::fs::read_to_string(&path)
        .map_err(|e| format!("mission: read {} failed: {e}", path.display()))?;
    serde_json::from_str(&text).map_err(|e| format!("mission: parse {}: {e}", path.display()))
}

/// Enumerate every mission whose marker survives under
/// `~/.claudette/missions/`. Directories without a marker are skipped
/// (see `list_orphan_slugs` to surface those separately).
pub fn list_missions() -> Result<Vec<Mission>, String> {
    let root = missions_root();
    if !root.exists() {
        return Ok(Vec::new());
    }
    let mut out = Vec::new();
    let read = std::fs::read_dir(&root)
        .map_err(|e| format!("mission: read {} failed: {e}", root.display()))?;
    for entry in read.flatten() {
        let p = entry.path();
        if !p.is_dir() {
            continue;
        }
        // Silently skip directories without a marker — listing should
        // never fail because of a single broken entry. `list_orphan_slugs`
        // gives the user a way to see what got skipped.
        if let Ok(m) = load_marker(&p) {
            out.push(m);
        }
    }
    out.sort_by(|a, b| a.slug.cmp(&b.slug));
    Ok(out)
}

/// Sibling to [`list_missions`]: directory names under
/// `~/.claudette/missions/` that are *not* recognised as missions
/// because they lack a valid `.claudette-mission.json` marker. Common
/// causes: pre-T2 `git_clone` calls (markers didn't exist yet),
/// half-finished clones, or unrelated user content the user dropped
/// into the missions root by hand. Surfaced via `mission_list` so the
/// brain can warn rather than silently ignore them.
pub fn list_orphan_slugs() -> Result<Vec<String>, String> {
    let root = missions_root();
    if !root.exists() {
        return Ok(Vec::new());
    }
    let mut out = Vec::new();
    let read = std::fs::read_dir(&root)
        .map_err(|e| format!("mission: read {} failed: {e}", root.display()))?;
    for entry in read.flatten() {
        let p = entry.path();
        if !p.is_dir() {
            continue;
        }
        if load_marker(&p).is_err() {
            if let Some(name) = p.file_name().and_then(|s| s.to_str()) {
                out.push(name.to_string());
            }
        }
    }
    out.sort();
    Ok(out)
}

#[cfg(test)]
mod tests {
    use super::*;

    #[test]
    fn path_under_permitted_roots_accepts_home_subpath() {
        let home = std::env::var("USERPROFILE")
            .or_else(|_| std::env::var("HOME"))
            .expect("HOME or USERPROFILE must be set for this test");
        let candidate = PathBuf::from(&home).join("subdir").join("repo");
        assert!(
            path_under_permitted_roots(&candidate),
            "{} should be permitted under {}",
            candidate.display(),
            home
        );
    }

    #[test]
    fn path_under_permitted_roots_rejects_system_dir() {
        let _guard = crate::test_env_lock();
        // Make sure CLAUDETTE_WORKSPACE doesn't sneak permission for us.
        let prev_ws = std::env::var("CLAUDETTE_WORKSPACE").ok();
        std::env::remove_var("CLAUDETTE_WORKSPACE");
        #[cfg(unix)]
        let bad = PathBuf::from("/etc/something");
        #[cfg(not(unix))]
        let bad = PathBuf::from("C:\\Windows\\System32");
        assert!(
            !path_under_permitted_roots(&bad),
            "{} must NOT be permitted",
            bad.display()
        );
        if let Some(v) = prev_ws {
            std::env::set_var("CLAUDETTE_WORKSPACE", v);
        }
    }

    #[test]
    fn path_under_permitted_roots_accepts_workspace_entry() {
        let _guard = crate::test_env_lock();
        let prev_ws = std::env::var("CLAUDETTE_WORKSPACE").ok();
        let root = std::env::temp_dir().join("claudette-workspace-root-test");
        std::fs::create_dir_all(&root).unwrap();
        std::env::set_var("CLAUDETTE_WORKSPACE", &root);
        let candidate = root.join("nested-repo");
        assert!(
            path_under_permitted_roots(&candidate),
            "{} should be permitted via CLAUDETTE_WORKSPACE",
            candidate.display()
        );
        match prev_ws {
            Some(v) => std::env::set_var("CLAUDETTE_WORKSPACE", v),
            None => std::env::remove_var("CLAUDETTE_WORKSPACE"),
        }
        let _ = std::fs::remove_dir_all(&root);
    }

    #[test]
    fn try_bootstrap_local_mission_in_this_repo_succeeds() {
        // We're running cargo test from inside the claudette repo itself,
        // which lives under D:\dev\claudette — but CI / dev-box paths
        // vary. As long as the cwd resolves to a git toplevel under HOME
        // or CLAUDETTE_WORKSPACE, this test should round-trip. If it
        // doesn't (e.g. running outside any git repo), we accept Err.
        match try_bootstrap_local_mission() {
            Ok(m) => {
                assert!(m.ephemeral, "auto-bootstrapped mission must be ephemeral");
                assert!(m.path.is_dir(), "bootstrap path must be a directory");
                assert!(m.path.join(".git").exists(), "must be a git repo");
                assert!(
                    m.repo.is_none(),
                    "ephemeral mission has no GH repo metadata"
                );
            }
            Err(why) => {
                // Acceptable when the test runner is not inside a git
                // toplevel under HOME — e.g. some sandboxed CI shapes.
                // Make sure the error message is informative.
                assert!(
                    !why.is_empty(),
                    "bootstrap error must have a non-empty reason"
                );
            }
        }
    }

    #[test]
    fn validate_slug_accepts_simple_name() {
        assert_eq!(
            validate_slug("django__issue-12345").unwrap(),
            "django__issue-12345"
        );
    }

    #[test]
    fn validate_slug_trims_whitespace() {
        assert_eq!(validate_slug("  hello  ").unwrap(), "hello");
    }

    #[test]
    fn validate_slug_rejects_traversal_and_separators() {
        for bad in ["..", "foo/../bar", "a/b", "a\\b", "C:\\evil", "", "   "] {
            assert!(validate_slug(bad).is_err(), "expected reject for `{bad}`");
        }
    }

    #[test]
    fn missions_root_under_home_or_userprofile() {
        let root = missions_root();
        let display = root.display().to_string();
        assert!(
            display.contains(".claudette") && display.ends_with("missions"),
            "unexpected missions_root: {display}"
        );
    }

    #[test]
    fn marker_round_trip() {
        // Round-trip a Mission through save_marker → load_marker. Uses a
        // temp dir under the OS temp root so we don't pollute the real
        // ~/.claudette/missions tree.
        let nanos = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map_or(0, |d| d.as_nanos());
        let tmp = std::env::temp_dir().join(format!("claudette-mission-test-{nanos}"));
        std::fs::create_dir_all(&tmp).unwrap();

        let mission = Mission {
            slug: "abcc-cleanup".to_string(),
            path: tmp.clone(),
            repo: Some("mrdushidush/agent-battle-command-center".to_string()),
            created_at: 1_700_000_000,
            ephemeral: false,
        };

        save_marker(&mission).expect("save_marker should succeed");
        let loaded = load_marker(&tmp).expect("load_marker should succeed");
        assert_eq!(loaded, mission);

        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn load_marker_errors_on_missing_file() {
        let nanos = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map_or(0, |d| d.as_nanos());
        let tmp = std::env::temp_dir().join(format!("claudette-mission-missing-{nanos}"));
        std::fs::create_dir_all(&tmp).unwrap();

        let err = load_marker(&tmp).expect_err("expected error on missing marker");
        assert!(err.contains("read") || err.contains("failed"), "got: {err}");

        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn list_missions_skips_dirs_without_markers() {
        // We can't easily redirect missions_root() in-process, so this test
        // just verifies the function runs cleanly and returns Ok for
        // whatever the real filesystem currently has — any listed entries
        // must have valid markers.
        let out = list_missions().expect("list_missions should not fail");
        for m in &out {
            assert!(!m.slug.is_empty(), "listed mission has empty slug");
        }
    }

    #[test]
    fn list_orphan_slugs_runs_cleanly() {
        // Same constraint as list_missions_skips_dirs_without_markers:
        // can't redirect missions_root() in-process, so just verify the
        // function returns Ok against the real filesystem and that
        // missions + orphans don't overlap.
        let orphans = list_orphan_slugs().expect("list_orphan_slugs should not fail");
        for s in &orphans {
            assert!(!s.is_empty(), "orphan with empty name");
        }
        let missions = list_missions().expect("list_missions should not fail");
        for m in &missions {
            assert!(
                !orphans.contains(&m.slug),
                "{} listed as both mission and orphan",
                m.slug
            );
        }
    }

    #[test]
    fn active_cwd_falls_back_to_process_cwd_when_no_mission() {
        // When nothing is active, active_cwd() must return the process cwd
        // — this is the fallback every cwd-routed tool relies on.
        // We don't mutate the active slot here because other tests may run
        // in parallel; instead we just snapshot and assert it's a real
        // directory the process can stat.
        if active_mission().is_none() {
            let cwd = active_cwd();
            assert!(
                cwd.is_dir(),
                "active_cwd fallback {} not a directory",
                cwd.display()
            );
        }
    }

    #[test]
    fn marker_path_for_appends_filename() {
        let p = Path::new("/tmp/foo");
        assert_eq!(marker_path_for(p), p.join(MARKER_FILENAME));
    }

    #[test]
    fn marker_filename_is_dotfile() {
        // Belt-and-braces: the marker is intentionally a dotfile so it
        // doesn't show up in `ls` of the cloned tree, doesn't get added
        // by accident via `git add <path>`, and is harmless if committed.
        assert!(MARKER_FILENAME.starts_with('.'));
    }

    fn unique_tmp(prefix: &str) -> PathBuf {
        // System clock granularity on Windows is ~15.6ms in some configs, so
        // nanos alone isn't unique under parallel `cargo test`. Add a
        // monotonic per-process counter as a second axis so collisions
        // across parallel test threads are impossible.
        use std::sync::atomic::{AtomicU64, Ordering};
        static COUNTER: AtomicU64 = AtomicU64::new(0);
        let nanos = std::time::SystemTime::now()
            .duration_since(std::time::UNIX_EPOCH)
            .map_or(0, |d| d.as_nanos());
        let seq = COUNTER.fetch_add(1, Ordering::Relaxed);
        std::env::temp_dir().join(format!("{prefix}-{nanos}-{seq}"))
    }

    #[test]
    fn add_marker_to_git_exclude_writes_into_fresh_repo() {
        let tmp = unique_tmp("claudette-exclude-fresh");
        std::fs::create_dir_all(tmp.join(".git").join("info")).unwrap();
        add_marker_to_git_exclude(&tmp).expect("should succeed");
        let body = std::fs::read_to_string(tmp.join(".git").join("info").join("exclude")).unwrap();
        assert!(
            body.lines().any(|l| l.trim() == MARKER_FILENAME),
            "marker not written into exclude file:\n{body}"
        );
        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn add_marker_to_git_exclude_preserves_existing_rules() {
        let tmp = unique_tmp("claudette-exclude-preserve");
        let info = tmp.join(".git").join("info");
        std::fs::create_dir_all(&info).unwrap();
        std::fs::write(info.join("exclude"), "# user rules\n*.log\nnotes/\n").unwrap();
        add_marker_to_git_exclude(&tmp).expect("should succeed");
        let body = std::fs::read_to_string(info.join("exclude")).unwrap();
        assert!(body.contains("*.log"), "preexisting rules dropped: {body}");
        assert!(body.contains("notes/"), "preexisting rules dropped: {body}");
        assert!(
            body.lines().any(|l| l.trim() == MARKER_FILENAME),
            "marker not appended: {body}"
        );
        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn add_marker_to_git_exclude_is_idempotent() {
        let tmp = unique_tmp("claudette-exclude-idem");
        std::fs::create_dir_all(tmp.join(".git").join("info")).unwrap();
        add_marker_to_git_exclude(&tmp).unwrap();
        add_marker_to_git_exclude(&tmp).unwrap();
        let body = std::fs::read_to_string(tmp.join(".git").join("info").join("exclude")).unwrap();
        let count = body.lines().filter(|l| l.trim() == MARKER_FILENAME).count();
        assert_eq!(count, 1, "marker line written more than once:\n{body}");
        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn add_marker_to_git_exclude_creates_info_dir_if_missing() {
        let tmp = unique_tmp("claudette-exclude-noinfo");
        // Make `.git` but not `.git/info`.
        std::fs::create_dir_all(tmp.join(".git")).unwrap();
        add_marker_to_git_exclude(&tmp).expect("should succeed");
        let body = std::fs::read_to_string(tmp.join(".git").join("info").join("exclude")).unwrap();
        assert!(body.lines().any(|l| l.trim() == MARKER_FILENAME));
        let _ = std::fs::remove_dir_all(&tmp);
    }

    #[test]
    fn brownfield_failed_flag_round_trips() {
        // Process-global state; another test could race us. Take the
        // env-lock to serialise even though we're touching an atomic.
        let _guard = crate::test_env_lock();
        // Snapshot then clear so we don't poison the rest of the suite.
        let prior = brownfield_failed_this_session();
        clear_brownfield_failed();
        assert!(!brownfield_failed_this_session());
        mark_brownfield_failed();
        assert!(brownfield_failed_this_session());
        clear_brownfield_failed();
        assert!(!brownfield_failed_this_session());
        if prior {
            mark_brownfield_failed();
        }
    }

    #[test]
    fn active_pointer_path_sits_under_claudette_home() {
        let p = active_pointer_path();
        let s = p.display().to_string();
        assert!(
            s.contains(".claudette") && s.ends_with(ACTIVE_POINTER_FILENAME),
            "unexpected active pointer path: {s}"
        );
    }

    /// Helper: build a fake mission tree (directory with `.git/`) under a
    /// temp dir so `try_rehydrate_active_mission`'s path-validation can
    /// pass against it. Returns the tree path so tests can clean it up.
    fn make_fake_git_tree(prefix: &str) -> PathBuf {
        let dir = unique_tmp(prefix);
        std::fs::create_dir_all(dir.join(".git")).unwrap();
        dir
    }

    /// Helper: redirect `~/.claudette/active_mission.json` to a fresh temp
    /// home by swapping `USERPROFILE` (Windows) / `HOME` (Unix), run the
    /// closure, then restore. Holds the env lock so parallel tests don't
    /// race us. Returns whatever the closure returns.
    fn with_temp_home<F, T>(f: F) -> T
    where
        F: FnOnce(&Path) -> T,
    {
        let _guard = crate::test_env_lock();
        #[cfg(windows)]
        let key = "USERPROFILE";
        #[cfg(not(windows))]
        let key = "HOME";
        let prev = std::env::var(key).ok();
        let tmp = unique_tmp("claudette-fakehome");
        std::fs::create_dir_all(&tmp).unwrap();
        std::env::set_var(key, &tmp);
        let out = f(&tmp);
        match prev {
            Some(v) => std::env::set_var(key, v),
            None => std::env::remove_var(key),
        }
        let _ = std::fs::remove_dir_all(&tmp);
        out
    }

    #[test]
    fn rehydrate_returns_none_when_pointer_missing() {
        with_temp_home(|_| {
            // No pointer file at all → None.
            let r = try_rehydrate_active_mission();
            assert_eq!(r, RehydrateOutcome::None);
        });
    }

    #[test]
    fn rehydrate_clears_pointer_when_mission_tree_missing() {
        with_temp_home(|home| {
            // Active slot must be empty for the round-trip to work.
            let _ = clear_active();
            let phantom = home.join("missions").join("ghost-repo");
            let mission = Mission {
                slug: "ghost-repo".to_string(),
                path: phantom,
                repo: Some("octocat/ghost".to_string()),
                created_at: 1,
                ephemeral: false,
            };
            write_active_pointer(&mission).expect("write should succeed");
            assert!(active_pointer_path().exists());

            let r = try_rehydrate_active_mission();
            match r {
                RehydrateOutcome::Cleared { reason, .. } => {
                    assert!(
                        reason.contains("no longer exists"),
                        "unexpected reason: {reason}"
                    );
                }
                other => panic!("expected Cleared, got {other:?}"),
            }
            assert!(
                !active_pointer_path().exists(),
                "stale pointer must be removed"
            );
            assert!(
                active_mission().is_none(),
                "no mission should have been installed"
            );
        });
    }

    #[test]
    fn rehydrate_clears_pointer_when_not_a_git_tree() {
        with_temp_home(|home| {
            let _ = clear_active();
            // Real directory, but no .git subdir.
            let bare = home.join("bare-dir");
            std::fs::create_dir_all(&bare).unwrap();
            let mission = Mission {
                slug: "bare".to_string(),
                path: bare,
                repo: None,
                created_at: 1,
                ephemeral: false,
            };
            write_active_pointer(&mission).expect("write should succeed");

            let r = try_rehydrate_active_mission();
            match r {
                RehydrateOutcome::Cleared { reason, .. } => {
                    assert!(
                        reason.contains("not a git working tree"),
                        "unexpected reason: {reason}"
                    );
                }
                other => panic!("expected Cleared, got {other:?}"),
            }
            assert!(active_mission().is_none());
        });
    }

    #[test]
    fn rehydrate_installs_valid_mission_and_round_trips() {
        with_temp_home(|_home| {
            let _ = clear_active();
            let tree = make_fake_git_tree("claudette-rehydrate-ok");
            let mission = Mission {
                slug: "rehydrate-ok".to_string(),
                path: tree.clone(),
                repo: Some("octocat/Hello-World".to_string()),
                created_at: 1_700_000_000,
                ephemeral: false,
            };
            write_active_pointer(&mission).expect("write should succeed");

            let r = try_rehydrate_active_mission();
            match r {
                RehydrateOutcome::Rehydrated(m) => assert_eq!(m.slug, "rehydrate-ok"),
                other => panic!("expected Rehydrated, got {other:?}"),
            }
            let active = active_mission().expect("active mission must be installed");
            assert_eq!(active.slug, "rehydrate-ok");
            assert_eq!(active.repo.as_deref(), Some("octocat/Hello-World"));

            // Cleanup: clear the slot so this doesn't leak into other
            // tests in the same process.
            let _ = clear_active();
            let _ = std::fs::remove_dir_all(&tree);
            assert!(
                !active_pointer_path().exists(),
                "clear_active must remove the pointer"
            );
        });
    }

    #[test]
    fn rehydrate_clears_pointer_on_malformed_json() {
        with_temp_home(|_home| {
            let _ = clear_active();
            let path = active_pointer_path();
            if let Some(parent) = path.parent() {
                std::fs::create_dir_all(parent).unwrap();
            }
            std::fs::write(&path, "{not valid json").unwrap();

            let r = try_rehydrate_active_mission();
            match r {
                RehydrateOutcome::Cleared { reason, .. } => {
                    assert!(reason.contains("parse failed"), "got: {reason}");
                }
                other => panic!("expected Cleared, got {other:?}"),
            }
            assert!(!path.exists(), "malformed pointer must be removed");
        });
    }

    #[test]
    fn set_active_persists_non_ephemeral_only() {
        with_temp_home(|_home| {
            let _ = clear_active();
            assert!(!active_pointer_path().exists());

            // Ephemeral missions are NOT persisted.
            let ephemeral = Mission {
                slug: "eph".to_string(),
                path: make_fake_git_tree("claudette-eph"),
                repo: None,
                created_at: 1,
                ephemeral: true,
            };
            set_active(ephemeral.clone()).unwrap();
            assert!(
                !active_pointer_path().exists(),
                "ephemeral mission must NOT write the pointer file"
            );
            let _ = clear_active();
            let _ = std::fs::remove_dir_all(&ephemeral.path);

            // Non-ephemeral missions ARE persisted.
            let persistent = Mission {
                slug: "stay".to_string(),
                path: make_fake_git_tree("claudette-stay"),
                repo: None,
                created_at: 1,
                ephemeral: false,
            };
            set_active(persistent.clone()).unwrap();
            assert!(
                active_pointer_path().exists(),
                "non-ephemeral mission must write the pointer file"
            );

            // Cleanup.
            let _ = clear_active();
            let _ = std::fs::remove_dir_all(&persistent.path);
            assert!(
                !active_pointer_path().exists(),
                "clear_active must remove the pointer"
            );
        });
    }
}