clatter 2.2.0

no_std compatible implementation of Noise protocol framework with Post-Quantum extensions
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
//! Hybrid (DH + PQ KEM) Noise handshake implementation

use core::fmt::Write;

use arrayvec::{ArrayString, ArrayVec};

use super::HandshakeInternals;
use crate::bytearray::ByteArray;
use crate::cipherstate::CipherStates;
use crate::constants::{MAX_PSKS, PSK_LEN};
use crate::error::{CipherResult, HandshakeError, HandshakeResult, PatternError};
use crate::handshakepattern::{HandshakePattern, HandshakeType, Token};
use crate::handshakestate::HandshakeStatus;
use crate::symmetricstate::SymmetricState;
use crate::traits::{Cipher, Dh, Handshaker, HandshakerInternal, Hash, Kem, Rng};
use crate::KeyPair;

/// Parameters for initializing a [`HybridHandshake`]
pub struct HybridHandshakeParams<'a, DH, EKEM, SKEM>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
{
    /// Handshake pattern (must be a hybrid pattern)
    pub pattern: HandshakePattern,
    /// True if we are the initiator
    pub initiator: bool,
    /// Optional prologue data for the handshake
    pub prologue: Option<&'a [u8]>,
    /// Our static DH keys
    pub s: Option<KeyPair<DH::PubKey, DH::PrivateKey>>,
    /// Our ephemeral DH keys - Shouldn't usually be provided manually
    pub e: Option<KeyPair<DH::PubKey, DH::PrivateKey>>,
    /// Peer public static DH key
    pub rs: Option<DH::PubKey>,
    /// Peer public ephemeral DH key - Shouldn't usually be provided manually
    pub re: Option<DH::PubKey>,
    /// Our static KEM keys
    pub s_kem: Option<KeyPair<SKEM::PubKey, SKEM::SecretKey>>,
    /// Our ephemeral KEM keys - Shouldn't usually be provided manually
    pub e_kem: Option<KeyPair<EKEM::PubKey, EKEM::SecretKey>>,
    /// Peer public static KEM key
    pub rs_kem: Option<SKEM::PubKey>,
    /// Peer public ephemeral KEM key - Shouldn't usually be provided manually
    pub re_kem: Option<EKEM::PubKey>,
}

impl<'a, DH, EKEM, SKEM> HybridHandshakeParams<'a, DH, EKEM, SKEM>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
{
    /// Create new handshake parameters
    ///
    /// # Arguments
    /// * `pattern` - Handshake pattern
    /// * `initiator` - True if we are the initiating party
    pub fn new(pattern: HandshakePattern, initiator: bool) -> Self {
        Self {
            pattern,
            initiator,
            prologue: None,
            s: None,
            e: None,
            rs: None,
            re: None,
            s_kem: None,
            e_kem: None,
            rs_kem: None,
            re_kem: None,
        }
    }

    /// Set handshake prologue bytes
    pub fn with_prologue(mut self, prologue: &'a [u8]) -> Self {
        self.prologue = Some(prologue);
        self
    }

    /// Set our static DH keys
    pub fn with_s(mut self, s: KeyPair<DH::PubKey, DH::PrivateKey>) -> Self {
        self.s = Some(s);
        self
    }

    /// Set our ephemeral DH keys
    pub fn with_e(mut self, e: KeyPair<DH::PubKey, DH::PrivateKey>) -> Self {
        self.e = Some(e);
        self
    }

    /// Set peer public static DH key
    pub fn with_rs(mut self, rs: DH::PubKey) -> Self {
        self.rs = Some(rs);
        self
    }

    /// Set peer public ephemeral DH key
    pub fn with_re(mut self, re: DH::PubKey) -> Self {
        self.re = Some(re);
        self
    }

    /// Set our static KEM keys
    pub fn with_s_kem(mut self, s_kem: KeyPair<SKEM::PubKey, SKEM::SecretKey>) -> Self {
        self.s_kem = Some(s_kem);
        self
    }

    /// Set our ephemeral KEM keys
    pub fn with_e_kem(mut self, e_kem: KeyPair<EKEM::PubKey, EKEM::SecretKey>) -> Self {
        self.e_kem = Some(e_kem);
        self
    }

    /// Set peer public static KEM key
    pub fn with_rs_kem(mut self, rs_kem: SKEM::PubKey) -> Self {
        self.rs_kem = Some(rs_kem);
        self
    }

    /// Set peer public ephemeral KEM key
    pub fn with_re_kem(mut self, re_kem: EKEM::PubKey) -> Self {
        self.re_kem = Some(re_kem);
        self
    }
}

/// Container for a pair of public keys used by the hybrid handshake
pub struct HybridPubKeyPair<D, K> {
    dh: D,
    kem: K,
}

impl<D, K> HybridPubKeyPair<D, K> {
    pub fn new(dh: D, kem: K) -> HybridPubKeyPair<D, K> {
        Self { dh, kem }
    }

    pub fn dh(&self) -> &D {
        &self.dh
    }

    pub fn kem(&self) -> &K {
        &self.kem
    }
}

/// True hybrid (NQ + PQ) Noise handshake
#[cfg(feature = "getrandom")]
pub type HybridHandshake<DH, EKEM, SKEM, C, H> =
    HybridHandshakeCore<DH, EKEM, SKEM, C, H, crate::crypto::rng::DefaultRng>;

/// True hybrid Noise handhsake core with a generic RNG provider
///
/// A handshake which combines both DH and KEM operations. This handshake type accepts handshake patterns with
/// both DH and KEM operations and mixes the results of both exchanges in a single *symmetric state* containing
/// the session keys and hash, achieving true hybrid security against quantum threats while preserving the
/// established safety guarantees of classic algorithms.
///
/// This handshake type accepts handshake patterns with both DH and KEM operations.
/// [`Token::E`]/[`Token::S`] will send/receive both DH and KEM ephemeral/static public keys.
#[derive(Clone)]
pub struct HybridHandshakeCore<DH, EKEM, SKEM, C, H, RNG>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
    C: Cipher,
    H: Hash,
    RNG: Rng,
{
    #[allow(clippy::type_complexity)]
    dh_internals:
        HandshakeInternals<C, H, RNG, DH::PrivateKey, DH::PubKey, DH::PrivateKey, DH::PubKey>,
    kem_s: Option<KeyPair<SKEM::PubKey, SKEM::SecretKey>>,
    kem_e: Option<KeyPair<EKEM::PubKey, EKEM::SecretKey>>,
    kem_rs: Option<SKEM::PubKey>,
    kem_re: Option<EKEM::PubKey>,
}

impl<DH, EKEM, SKEM, CIPHER, HASH, RNG> HybridHandshakeCore<DH, EKEM, SKEM, CIPHER, HASH, RNG>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
    CIPHER: Cipher,
    HASH: Hash,
    RNG: Rng,
{
    /// Initialize new hybrid handshake
    ///
    /// # Arguments
    /// * `params` - Handshake parameters
    ///
    /// # Generic parameters
    /// * `DH` - DH algorithm to use
    /// * `EKEM` - Ephemeral KEM algorithm to use
    /// * `SKEM` - Static KEM algorithm to use
    /// * `CIPHER` - Cipher algorithm to use
    /// * `HASH` - Hashing algorithm to use
    /// * `RNG` - RNG to use
    ///
    /// # Errors
    /// * [`HandshakeError::InvalidPattern`] if initialized with a non-hybrid pattern
    ///
    /// # Panics
    /// * If the handshake pattern contains invalid pre-shared keys
    pub fn new(params: HybridHandshakeParams<DH, EKEM, SKEM>) -> Result<Self, HandshakeError> {
        let HybridHandshakeParams {
            pattern,
            prologue,
            initiator,
            s,
            e,
            rs,
            re,
            s_kem,
            e_kem,
            rs_kem,
            re_kem,
        } = params;

        // Must be a hybrid pattern (has both DH and KEM)
        if pattern.get_type() != HandshakeType::HYBRID {
            return Err(HandshakeError::InvalidPattern(
                HandshakeType::HYBRID,
                pattern.get_type(),
            ));
        }

        // Initialize symmetric state and mix in prologue
        let mut ss = SymmetricState::new(&Self::build_name(&pattern));

        // Mix in prologue bytes if available
        if let Some(prologue_bytes) = prologue {
            ss.mix_hash(prologue_bytes);
        }

        // Mix in possible initiator pre-shared keys
        for pre_shared in pattern.get_initiator_pre_shared() {
            match pre_shared {
                Token::S => {
                    if initiator {
                        ss.mix_hash(
                            s.as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .public
                                .as_slice(),
                        );
                        ss.mix_hash(
                            s_kem
                                .as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .public
                                .as_slice(),
                        );
                    } else {
                        ss.mix_hash(
                            rs.as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .as_slice(),
                        );
                        ss.mix_hash(
                            rs_kem
                                .as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .as_slice(),
                        );
                    };
                }
                _ => {
                    panic!("Invalid pre-shared token in pattern");
                }
            }
        }

        // Mix in possible responder pre-shared keys
        for pre_shared in pattern.get_responder_pre_shared() {
            match pre_shared {
                Token::S => {
                    if initiator {
                        ss.mix_hash(
                            rs.as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .as_slice(),
                        );
                        ss.mix_hash(
                            rs_kem
                                .as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .as_slice(),
                        );
                    } else {
                        ss.mix_hash(
                            s.as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .public
                                .as_slice(),
                        );
                        ss.mix_hash(
                            s_kem
                                .as_ref()
                                .ok_or(HandshakeError::MissingMaterial)?
                                .public
                                .as_slice(),
                        );
                    };
                }
                Token::E => {
                    if initiator {
                        let re_bytes = re
                            .as_ref()
                            .ok_or(HandshakeError::MissingMaterial)?
                            .as_slice();
                        let re_kem_bytes = re_kem
                            .as_ref()
                            .ok_or(HandshakeError::MissingMaterial)?
                            .as_slice();
                        ss.mix_hash(re_bytes);
                        ss.mix_hash(re_kem_bytes);
                        if pattern.has_psk() {
                            ss.mix_key(re_bytes);
                            ss.mix_key(re_kem_bytes);
                        }
                    } else {
                        let e_bytes = e
                            .as_ref()
                            .ok_or(HandshakeError::MissingMaterial)?
                            .public
                            .as_slice();
                        let e_kem_bytes = e_kem
                            .as_ref()
                            .ok_or(HandshakeError::MissingMaterial)?
                            .public
                            .as_slice();
                        ss.mix_hash(e_bytes);
                        ss.mix_hash(e_kem_bytes);
                        if pattern.has_psk() {
                            ss.mix_key(e_bytes);
                            ss.mix_key(e_kem_bytes);
                        }
                    };
                }
                _ => {
                    panic!("Invalid pre-shared token in pattern");
                }
            }
        }

        let status = if initiator {
            HandshakeStatus::Send
        } else {
            HandshakeStatus::Receive
        };

        let dh_internals = HandshakeInternals {
            symmetricstate: ss,
            s,
            e,
            rs,
            re,
            pattern,
            initiator,
            status,
            initiator_pattern_index: 0,
            responder_pattern_index: 0,
            psks: ArrayVec::<[u8; PSK_LEN], MAX_PSKS>::new(),
            rng: RNG::default(),
            psk_applied: false,
            own_randomness_applied: false,
        };

        Ok(Self {
            dh_internals,
            kem_s: s_kem,
            kem_e: e_kem,
            kem_rs: rs_kem,
            kem_re: re_kem,
        })
    }

    fn dh(
        a: Option<&KeyPair<DH::PubKey, DH::PrivateKey>>,
        b: Option<&DH::PubKey>,
    ) -> HandshakeResult<DH::Output> {
        let a = a.ok_or(HandshakeError::MissingMaterial)?;
        let b = b.ok_or(HandshakeError::MissingMaterial)?;
        let out = DH::dh(&a.secret, b)?;
        Ok(out)
    }

    fn map_dh(&self, t: Token) -> HandshakeResult<DH::Output> {
        let out = match t {
            Token::EE => Self::dh(self.dh_internals.e.as_ref(), self.dh_internals.re.as_ref())?,
            Token::ES => {
                if self.is_initiator() {
                    Self::dh(self.dh_internals.e.as_ref(), self.dh_internals.rs.as_ref())?
                } else {
                    Self::dh(self.dh_internals.s.as_ref(), self.dh_internals.re.as_ref())?
                }
            }
            Token::SE => {
                if self.is_initiator() {
                    Self::dh(self.dh_internals.s.as_ref(), self.dh_internals.re.as_ref())?
                } else {
                    Self::dh(self.dh_internals.e.as_ref(), self.dh_internals.rs.as_ref())?
                }
            }
            Token::SS => Self::dh(self.dh_internals.s.as_ref(), self.dh_internals.rs.as_ref())?,
            _ => unreachable!(),
        };

        Ok(out)
    }
}

impl<DH, EKEM, SKEM, C, H, RNG> HandshakerInternal<C, H>
    for HybridHandshakeCore<DH, EKEM, SKEM, C, H, RNG>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
    C: Cipher,
    H: Hash,
    RNG: Rng,
{
    fn status(&self) -> HandshakeStatus {
        self.dh_internals.status()
    }

    fn set_error(&mut self) {
        self.dh_internals.set_error();
    }

    fn write_message_impl(&mut self, payload: &[u8], out: &mut [u8]) -> HandshakeResult<usize> {
        let out_len = payload.len() + self.get_next_message_overhead()?;

        let message = if self.is_initiator() {
            let p = self
                .dh_internals
                .pattern
                .get_initiator_pattern(self.dh_internals.initiator_pattern_index);
            self.dh_internals.initiator_pattern_index += 1;
            p
        } else {
            let p = self
                .dh_internals
                .pattern
                .get_responder_pattern(self.dh_internals.responder_pattern_index);
            self.dh_internals.responder_pattern_index += 1;
            p
        };

        let mut cur = 0_usize;
        for token in message {
            match *token {
                Token::E => {
                    // Generate both DH and KEM ephemeral keys if not present
                    if self.dh_internals.e.is_none() {
                        self.dh_internals.e = Some(DH::genkey_rng(&mut self.dh_internals.rng)?);
                    }
                    if self.kem_e.is_none() {
                        self.kem_e = Some(EKEM::genkey_rng(&mut self.dh_internals.rng)?);
                    }

                    // Send DH public key
                    let e_pub = &self.dh_internals.e.as_ref().unwrap().public;
                    self.dh_internals.symmetricstate.mix_hash(e_pub.as_slice());
                    if self.get_pattern().has_psk() {
                        self.dh_internals.symmetricstate.mix_key(e_pub.as_slice());
                    }
                    out[cur..cur + DH::PubKey::len()].copy_from_slice(e_pub.as_slice());
                    cur += DH::PubKey::len();

                    // Send KEM public key
                    let e_kem_pub = &self.kem_e.as_ref().unwrap().public;
                    self.dh_internals
                        .symmetricstate
                        .mix_hash(e_kem_pub.as_slice());
                    if self.get_pattern().has_psk() {
                        self.dh_internals
                            .symmetricstate
                            .mix_key(e_kem_pub.as_slice());
                    }
                    out[cur..cur + EKEM::PubKey::len()].copy_from_slice(e_kem_pub.as_slice());
                    cur += EKEM::PubKey::len();

                    // Sending E satisfies the requirement of applying self-chosen randomness
                    self.dh_internals.own_randomness_applied = true;
                }
                Token::S => {
                    if self.dh_internals.s.is_none() || self.kem_s.is_none() {
                        return Err(HandshakeError::MissingMaterial);
                    }

                    self.dh_internals.psk_validity_check()?;

                    let has_key = self.dh_internals.symmetricstate.has_key();

                    // Send DH static key
                    let dh_len = if has_key {
                        DH::PubKey::len() + C::tag_len()
                    } else {
                        DH::PubKey::len()
                    };
                    self.dh_internals.symmetricstate.encrypt_and_hash(
                        self.dh_internals.s.as_ref().unwrap().public.as_slice(),
                        &mut out[cur..cur + dh_len],
                    )?;
                    cur += dh_len;

                    // Send KEM static key
                    let kem_len = if has_key {
                        SKEM::PubKey::len() + C::tag_len()
                    } else {
                        SKEM::PubKey::len()
                    };
                    self.dh_internals.symmetricstate.encrypt_and_hash(
                        self.kem_s.as_ref().unwrap().public.as_slice(),
                        &mut out[cur..cur + kem_len],
                    )?;
                    cur += kem_len;
                }
                Token::Psk => {
                    if let Some(psk) = self.dh_internals.psks.pop_at(0) {
                        self.dh_internals.symmetricstate.mix_key_and_hash(&psk);
                    } else {
                        return Err(HandshakeError::PskMissing);
                    }
                    self.dh_internals.psk_applied = true;
                }
                t @ (Token::EE | Token::ES | Token::SE | Token::SS) => {
                    // Perform DH
                    let dh_result = self.map_dh(t)?;
                    self.dh_internals
                        .symmetricstate
                        .mix_key(dh_result.as_slice());
                }
                Token::Ekem => {
                    // Should have peer e
                    if self.kem_re.is_none() {
                        return Err(HandshakeError::MissingMaterial);
                    }

                    let re_kem_pk = self.kem_re.as_ref().unwrap();
                    let (ct, ss) =
                        EKEM::encapsulate(re_kem_pk.as_slice(), &mut self.dh_internals.rng)?;
                    self.dh_internals.symmetricstate.mix_hash(ct.as_slice());
                    self.dh_internals.symmetricstate.mix_key(ss.as_slice());
                    out[cur..cur + EKEM::Ct::len()].copy_from_slice(ct.as_slice());
                    cur += EKEM::Ct::len();

                    // Sending Ekem satisfies the requirement of applying self-chosen randomness
                    self.dh_internals.own_randomness_applied = true;
                }
                Token::Skem => {
                    // Should have peer s
                    if self.kem_rs.is_none() {
                        return Err(HandshakeError::MissingMaterial);
                    }

                    self.dh_internals.psk_validity_check()?;

                    let rs_kem_pk = self.kem_rs.as_ref().unwrap();
                    let len = if self.dh_internals.symmetricstate.has_key() {
                        SKEM::Ct::len() + C::tag_len()
                    } else {
                        SKEM::Ct::len()
                    };

                    let encrypt_out = &mut out[cur..cur + len];
                    let (ct, ss) =
                        SKEM::encapsulate(rs_kem_pk.as_slice(), &mut self.dh_internals.rng)?;
                    self.dh_internals
                        .symmetricstate
                        .encrypt_and_hash(ct.as_slice(), encrypt_out)?;
                    self.dh_internals
                        .symmetricstate
                        .mix_key_and_hash(ss.as_slice());
                    cur += len;

                    // Sending Skem satisfies the requirement of applying self-chosen randomness
                    self.dh_internals.own_randomness_applied = true;
                }
            }
        }

        if !payload.is_empty()
            && self.dh_internals.psk_applied
            && !self.dh_internals.own_randomness_applied
        {
            return Err(PatternError::PskValidityViolation.into());
        }

        self.dh_internals
            .symmetricstate
            .encrypt_and_hash(payload, &mut out[cur..out_len])?;

        self.dh_internals.update_hs_status();
        Ok(out_len)
    }

    fn read_message_impl(&mut self, message: &[u8], out: &mut [u8]) -> HandshakeResult<usize> {
        let out_len = message.len() - self.get_next_message_overhead()?;

        // Consume the next `n` bytes of message data
        let mut message = message;
        let mut get = |n| {
            let ret;
            (ret, message) = message.split_at(n);
            ret
        };

        let message_pattern = if self.dh_internals.initiator {
            let p = self
                .dh_internals
                .pattern
                .get_responder_pattern(self.dh_internals.responder_pattern_index);
            self.dh_internals.responder_pattern_index += 1;
            p
        } else {
            let p = self
                .dh_internals
                .pattern
                .get_initiator_pattern(self.dh_internals.initiator_pattern_index);
            self.dh_internals.initiator_pattern_index += 1;
            p
        };

        for token in message_pattern {
            match *token {
                Token::E => {
                    // Receive DH public key
                    let re = DH::PubKey::from_slice(get(DH::PubKey::len()));
                    self.dh_internals.symmetricstate.mix_hash(re.as_slice());
                    if self.get_pattern().has_psk() {
                        self.dh_internals.symmetricstate.mix_key(re.as_slice());
                    }
                    self.dh_internals.re = Some(re);

                    // Receive KEM public key
                    let re_kem = EKEM::PubKey::from_slice(get(EKEM::PubKey::len()));
                    self.dh_internals.symmetricstate.mix_hash(re_kem.as_slice());
                    if self.get_pattern().has_psk() {
                        self.dh_internals.symmetricstate.mix_key(re_kem.as_slice());
                    }
                    self.kem_re = Some(re_kem);
                }
                Token::S => {
                    let has_key = self.dh_internals.symmetricstate.has_key();

                    // Receive DH static key
                    let dh_len = if has_key {
                        DH::PubKey::len() + C::tag_len()
                    } else {
                        DH::PubKey::len()
                    };
                    let mut rs = DH::PubKey::new_zero();
                    self.dh_internals
                        .symmetricstate
                        .decrypt_and_hash(get(dh_len), rs.as_mut())?;
                    self.dh_internals.rs = Some(rs);

                    // Receive KEM static key
                    let kem_len = if has_key {
                        SKEM::PubKey::len() + C::tag_len()
                    } else {
                        SKEM::PubKey::len()
                    };
                    let mut rs_kem = SKEM::PubKey::new_zero();
                    self.dh_internals
                        .symmetricstate
                        .decrypt_and_hash(get(kem_len), rs_kem.as_mut())?;
                    self.kem_rs = Some(rs_kem);
                }
                Token::Psk => {
                    if let Some(psk) = self.dh_internals.psks.pop_at(0) {
                        self.dh_internals.symmetricstate.mix_key_and_hash(&psk);
                    } else {
                        return Err(HandshakeError::PskMissing);
                    }
                    self.dh_internals.psk_applied = true;
                }
                t @ (Token::EE | Token::ES | Token::SE | Token::SS) => {
                    // Perform DH
                    let dh_result = self.map_dh(t)?;
                    self.dh_internals
                        .symmetricstate
                        .mix_key(dh_result.as_slice());
                }
                Token::Ekem => {
                    let ct = get(EKEM::Ct::len());
                    self.dh_internals.symmetricstate.mix_hash(ct);
                    let ss = EKEM::decapsulate(ct, self.kem_e.as_ref().unwrap().secret.as_slice())?;
                    self.dh_internals.symmetricstate.mix_key(ss.as_slice());
                }
                Token::Skem => {
                    let len = if self.dh_internals.symmetricstate.has_key() {
                        SKEM::Ct::len() + C::tag_len()
                    } else {
                        SKEM::Ct::len()
                    };

                    let ct_enc = get(len);
                    let mut ct = SKEM::Ct::new_zero();
                    self.dh_internals
                        .symmetricstate
                        .decrypt_and_hash(ct_enc, ct.as_mut())?;
                    let ss = SKEM::decapsulate(
                        ct.as_slice(),
                        self.kem_s.as_ref().unwrap().secret.as_slice(),
                    )?;
                    self.dh_internals
                        .symmetricstate
                        .mix_key_and_hash(ss.as_slice());
                }
            }
        }

        self.dh_internals
            .symmetricstate
            .decrypt_and_hash(message, &mut out[..out_len])?;
        self.dh_internals.update_hs_status();

        Ok(out_len)
    }

    fn get_ciphers(&self) -> CipherResult<CipherStates<C>> {
        self.dh_internals.get_ciphers()
    }

    fn get_hash(&self) -> H::Output {
        self.dh_internals.get_hash()
    }

    fn mix_hash(&mut self, data: &[u8]) {
        self.dh_internals.symmetricstate.mix_hash(data)
    }

    fn mix_key_and_hash(&mut self, data: &[u8]) {
        self.dh_internals.symmetricstate.mix_key_and_hash(data)
    }

    fn get_pattern(&self) -> HandshakePattern {
        self.dh_internals.pattern.clone()
    }
}

impl<DH, EKEM, SKEM, C, H, RNG> Handshaker<C, H> for HybridHandshakeCore<DH, EKEM, SKEM, C, H, RNG>
where
    DH: Dh,
    EKEM: Kem,
    SKEM: Kem,
    C: Cipher,
    H: Hash,
    RNG: Rng,
{
    type E = HybridPubKeyPair<DH::PubKey, EKEM::PubKey>;
    type S = HybridPubKeyPair<DH::PubKey, SKEM::PubKey>;

    fn push_psk(&mut self, psk: &[u8]) {
        self.dh_internals.push_psk(psk);
    }

    fn is_write_turn(&self) -> bool {
        self.dh_internals.is_write_turn()
    }

    fn is_initiator(&self) -> bool {
        self.dh_internals.initiator
    }

    fn get_next_message_overhead(&self) -> HandshakeResult<usize> {
        let message = self.dh_internals.get_next_message()?;

        let mut overhead = 0;
        let mut has_key = self.dh_internals.has_key();
        let has_psk = self.get_pattern().has_psk();

        for &token in message {
            match token {
                Token::E => {
                    overhead += DH::PubKey::len();
                    overhead += EKEM::PubKey::len();
                    if has_psk {
                        has_key = true;
                    }
                }
                Token::S => {
                    overhead += DH::PubKey::len();
                    overhead += SKEM::PubKey::len();
                    if has_key {
                        overhead += C::tag_len() * 2; // One tag per key
                    }
                }
                Token::EE | Token::ES | Token::SE | Token::SS => {
                    has_key = true;
                }
                Token::Ekem => {
                    overhead += EKEM::Ct::len();
                    has_key = true;
                }
                Token::Skem => {
                    overhead += SKEM::Ct::len();
                    if has_key {
                        overhead += C::tag_len();
                    }
                    has_key = true;
                }
                Token::Psk => {
                    has_key = true;
                }
            }
        }

        if has_key {
            overhead += C::tag_len();
        }

        Ok(overhead)
    }

    fn build_name(pattern: &HandshakePattern) -> ArrayString<128> {
        let mut ret = ArrayString::new();

        if EKEM::name() == SKEM::name() {
            // If EKEM and SKEM are the same, use simpler naming
            write!(
                &mut ret,
                "Noise_{}_{}+{}_{}_{}",
                pattern.get_name(),
                DH::name(),
                EKEM::name(),
                C::name(),
                H::name()
            )
            .unwrap();
        } else {
            // If EKEM and SKEM are different, include both
            write!(
                &mut ret,
                "Noise_{}_{}+{}+{}_{}_{}",
                pattern.get_name(),
                DH::name(),
                EKEM::name(),
                SKEM::name(),
                C::name(),
                H::name()
            )
            .unwrap();
        }
        ret
    }

    fn get_remote_static(&self) -> Option<Self::S> {
        match (self.dh_internals.rs.as_ref(), self.kem_rs.as_ref()) {
            (Some(dh), Some(kem)) => Some(HybridPubKeyPair::new(dh.clone(), kem.clone())),
            _ => None,
        }
    }

    fn get_remote_ephemeral(&self) -> Option<Self::E> {
        match (self.dh_internals.re.as_ref(), self.kem_re.as_ref()) {
            (Some(dh), Some(kem)) => Some(HybridPubKeyPair::new(dh.clone(), kem.clone())),
            _ => None,
        }
    }

    fn get_state(&self) -> SymmetricState<C, H> {
        self.dh_internals.symmetricstate.clone()
    }

    fn get_state_mut(&mut self) -> &mut SymmetricState<C, H> {
        &mut self.dh_internals.symmetricstate
    }
}

#[cfg(test)]
mod tests {
    use crate::crypto::cipher::ChaChaPoly;
    use crate::crypto::dh::X25519;
    use crate::crypto::hash::Sha256;
    use crate::crypto::kem::rust_crypto_ml_kem;
    use crate::error::{HandshakeError, PatternError};
    use crate::handshakepattern::{HandshakePattern, Token};
    use crate::traits::Handshaker;

    type TestKem = rust_crypto_ml_kem::MlKem1024;

    #[test]
    fn psk_validity_violation_with_payload() {
        let pattern = HandshakePattern::new(
            "test",
            &[],
            &[],
            &[&[Token::Psk]],
            &[&[Token::Ekem, Token::E, Token::EE]],
        );

        let params = crate::handshakestate::hybrid::HybridHandshakeParams::new(pattern, true)
            .with_prologue(&[]);
        let mut handshake = crate::handshakestate::hybrid::HybridHandshakeCore::<
            X25519,
            TestKem,
            TestKem,
            ChaChaPoly,
            Sha256,
            crate::crypto::rng::DefaultRng,
        >::new(params)
        .unwrap();
        handshake.push_psk(&[0u8; 32]);

        let mut out = [0u8; 2048];
        let result = handshake.write_message(b"test payload", &mut out);
        assert!(matches!(
            result,
            Err(HandshakeError::Pattern(PatternError::PskValidityViolation))
        ));
    }

    #[test]
    fn psk_validity_ok_with_e_before_psk() {
        let pattern = HandshakePattern::new(
            "test",
            &[],
            &[],
            &[&[Token::E, Token::Psk]],
            &[&[Token::Ekem, Token::E, Token::EE]],
        );

        let params = crate::handshakestate::hybrid::HybridHandshakeParams::new(pattern, true)
            .with_prologue(&[]);
        let mut handshake = crate::handshakestate::hybrid::HybridHandshakeCore::<
            X25519,
            TestKem,
            TestKem,
            ChaChaPoly,
            Sha256,
            crate::crypto::rng::DefaultRng,
        >::new(params)
        .unwrap();
        handshake.push_psk(&[0u8; 32]);

        let mut out = [0u8; 2048];
        let result = handshake.write_message(b"test payload", &mut out);
        assert!(result.is_ok());
    }

    #[test]
    fn psk_validity_ok_with_e_after_psk() {
        let pattern = HandshakePattern::new(
            "test",
            &[],
            &[],
            &[&[Token::Psk, Token::E]],
            &[&[Token::Ekem, Token::E, Token::EE]],
        );

        let params = crate::handshakestate::hybrid::HybridHandshakeParams::new(pattern, true)
            .with_prologue(&[]);
        let mut handshake = crate::handshakestate::hybrid::HybridHandshakeCore::<
            X25519,
            TestKem,
            TestKem,
            ChaChaPoly,
            Sha256,
            crate::crypto::rng::DefaultRng,
        >::new(params)
        .unwrap();
        handshake.push_psk(&[0u8; 32]);

        let mut out = [0u8; 2048];
        let result = handshake.write_message(b"test payload", &mut out);
        assert!(result.is_ok());
    }

    #[test]
    fn psk_validity_ok_with_empty_payload() {
        let pattern = HandshakePattern::new(
            "test",
            &[],
            &[],
            &[&[Token::Psk]],
            &[&[Token::Ekem, Token::E, Token::EE]],
        );

        let params = crate::handshakestate::hybrid::HybridHandshakeParams::new(pattern, true)
            .with_prologue(&[]);
        let mut handshake = crate::handshakestate::hybrid::HybridHandshakeCore::<
            X25519,
            TestKem,
            TestKem,
            ChaChaPoly,
            Sha256,
            crate::crypto::rng::DefaultRng,
        >::new(params)
        .unwrap();

        handshake.push_psk(&[0u8; 32]);

        let mut out = [0u8; 2048];
        let result = handshake.write_message(&[], &mut out);
        assert!(result.is_ok());
    }
}