clash 0.7.1

Command Line Agent Safety Harness — permission policies for coding agents
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
use anyhow::{Context, Result};
use serde_json::json;
use tracing::{Level, instrument, warn};

use crate::agents::AgentKind;
use crate::settings::ClashSettings;
use crate::style;
use crate::ui;

#[derive(Default)]
struct InitActions {
    /// Whether a new policy file was created (false when one already existed).
    policy_created: bool,
    /// Whether the policy was reviewed/edited via the TUI (true even for existing policies).
    policy_reviewed: bool,
    plugin_installed: bool,
    statusline_installed: bool,
}

/// Command prefix used for all clash hooks installed into Claude Code settings.
const HOOK_CMD_PREFIX: &str = "clash hook";

/// Embedded agent plugin files — compiled into the binary so `clash init --agent <name>`
/// can install them without needing the source repo.
const OPENCODE_PLUGIN_TS: &str = include_str!("../../clash-opencode/plugin.ts");
const COPILOT_HOOKS_JSON: &str =
    include_str!("../../clash-copilot/.github/hooks/pre-tool-use.json");
const CODEX_HOOKS_TOML: &str = include_str!("../../clash-codex/hooks.toml");
const AMAZONQ_AGENT_JSON: &str = include_str!("../../clash-amazonq/agent.json");
const GEMINI_EXTENSION_JSON: &str = include_str!("../../clash-gemini-ext/gemini-extension.json");
const GEMINI_HOOKS_JSON: &str = include_str!("../../clash-gemini-ext/hooks/hooks.json");

/// Initialize clash at the chosen scope.
///
/// All agents share the same onboarding flow: agent selection (if not
/// specified), policy setup (interactive, quick, or project), then
/// agent-specific plugin installation.
/// Install just the agent plugin/hooks, skipping policy setup.
pub fn run_install(agent: Option<AgentKind>) -> Result<()> {
    let agent = match agent {
        Some(a) => a,
        None => *crate::dialog::select::<AgentKind>("Which coding agent are you installing for?")?,
    };

    let installed = install_agent_plugin(agent)?;
    if installed {
        println!();
        println!(
            "  Run: {}",
            style::bold(&format!("clash doctor --agent {agent}"))
        );
        println!("  to verify the setup is correct.");
    }
    Ok(())
}

/// Minimal init: install hooks/plugin only, no policy generation.
pub fn run_no_import(agent: Option<AgentKind>) -> Result<()> {
    let agent = match agent {
        Some(a) => a,
        None => *crate::dialog::select::<AgentKind>("Which coding agent are you using?")?,
    };

    install_agent_plugin(agent)?;

    if agent == AgentKind::Claude {
        if let Err(e) = super::statusline::install() {
            warn!(error = %e, "Could not install status line");
        }
    }

    println!();
    ui::success("Clash hooks installed.");
    println!();
    println!(
        "  Run {} to configure your policy.",
        style::bold("clash policy edit")
    );
    println!(
        "  Run {} to verify the setup.",
        style::bold(&format!("clash doctor --agent {agent}"))
    );

    Ok(())
}

#[instrument(level = Level::TRACE)]
pub fn run(agent: Option<AgentKind>) -> Result<()> {
    let agent = match agent {
        Some(a) => a,
        None => *crate::dialog::select::<AgentKind>("Which coding agent are you using?")?,
    };

    let mut actions = InitActions::default();

    // Check if a policy already exists *before* detection so we can adjust messaging.
    let existing_policy = {
        let p = ClashSettings::policy_file()?.with_extension("star");
        if p.exists() { Some(p) } else { None }
    };

    let (policy_path, created_new) = match detect_and_generate_policy(existing_policy.is_some())? {
        Some(policy_content) => {
            let path = write_detected_policy(&policy_content)?;
            (path, existing_policy.is_none())
        }
        None => ensure_starter_policy()?,
    };
    #[cfg(feature = "tui")]
    {
        let outcome = crate::tui::run_with_options(&policy_path, false, true)?;
        if outcome == crate::tui::TuiOutcome::Aborted {
            if created_new {
                let _ = std::fs::remove_file(&policy_path);
            }
            println!();
            ui::warn("Setup cancelled. Run `clash init` to try again.");
            return Ok(());
        }
    }
    #[cfg(not(feature = "tui"))]
    {
        let _ = &policy_path;
    }
    actions.policy_created = created_new;
    actions.policy_reviewed = true;

    actions.plugin_installed = install_agent_plugin(agent)?;
    if agent == AgentKind::Claude {
        if let Err(e) = super::statusline::install() {
            warn!(error = %e, "Could not install status line");
        } else {
            actions.statusline_installed = true;
        }
    }
    print_summary(&actions, agent);

    Ok(())
}

/// Run ecosystem detection and return a generated policy, or None if the user
/// declines or no ecosystems are detected.
///
/// When `has_existing_policy` is true, adjusts messaging to indicate the policy
/// will be regenerated rather than created fresh.
fn detect_and_generate_policy(has_existing_policy: bool) -> Result<Option<String>> {
    println!();
    let scan = crate::dialog::confirm(
        "Scan your project and command history to recommend sandboxes?",
        false,
    )?;
    if !scan {
        return Ok(None);
    }

    let cwd = std::env::current_dir().context("getting current directory")?;
    let observed = crate::cmd::from_trace::mine_binaries_from_history();
    let observed_refs: Vec<&str> = observed.iter().map(|s| s.as_str()).collect();
    let detected = crate::ecosystem::detect_ecosystems(&cwd, &observed_refs);

    if detected.is_empty() {
        ui::info("No ecosystems detected.");
        return Ok(None);
    }

    println!();
    ui::info("Detected ecosystems:");
    println!();
    for eco in &detected {
        let mut reasons = Vec::new();
        for m in eco.markers {
            if cwd.join(m).exists() {
                reasons.push(format!("found {m}"));
            }
        }
        for m in eco.dir_markers {
            if cwd.join(m).is_dir() {
                reasons.push(format!("found {m}/"));
            }
        }
        for bin in eco.binaries {
            if observed.contains(*bin) {
                reasons.push(format!("observed: {bin}"));
            }
        }
        let reason_str = if reasons.is_empty() {
            String::new()
        } else {
            format!("  ({})", reasons.join(", "))
        };
        ui::success(&format!("  {:<12}{}", eco.name, reason_str));
    }
    println!();

    let confirm_msg = if has_existing_policy {
        "Generate a new policy with these sandboxes? (replaces existing policy)"
    } else {
        "Include these sandboxes in your policy?"
    };
    let include = crate::dialog::confirm(confirm_msg, false)?;
    if !include {
        return Ok(None);
    }

    Ok(Some(crate::ecosystem::generate_policy(&detected)))
}

/// Write a detected/generated policy to the policy file location.
fn write_detected_policy(content: &str) -> Result<std::path::PathBuf> {
    let policy_path = ClashSettings::policy_file()?;
    let star_path = policy_path.with_extension("star");
    let dir = star_path
        .parent()
        .context("policy file path has no parent directory")?;
    std::fs::create_dir_all(dir).with_context(|| format!("failed to create {}", dir.display()))?;
    std::fs::write(&star_path, content)
        .with_context(|| format!("failed to write {}", star_path.display()))?;
    Ok(star_path)
}

/// Ensure a policy file exists, writing the starter template only if one
/// doesn't already exist. Returns `(path, created_new)`.
pub fn ensure_starter_policy() -> Result<(std::path::PathBuf, bool)> {
    let policy_path = ClashSettings::policy_file()?;
    let star_path = policy_path.with_extension("star");
    if star_path.exists() {
        return Ok((star_path, false));
    }
    let path = write_starter_policy()?;
    Ok((path, true))
}

/// Write the starter policy.star for onboarding.
///
/// Copies the embedded default policy template to `~/.clash/policy.star`.
pub fn write_starter_policy() -> Result<std::path::PathBuf> {
    let policy_path = ClashSettings::policy_file()?;
    let star_path = policy_path.with_extension("star");
    let dir = star_path
        .parent()
        .context("policy file path has no parent directory")?;
    std::fs::create_dir_all(dir).with_context(|| format!("failed to create {}", dir.display()))?;

    let source = include_str!("../default_policy.star");
    std::fs::write(&star_path, source)
        .with_context(|| format!("failed to write {}", star_path.display()))?;

    Ok(star_path)
}

// ---------------------------------------------------------------------------
// Agent plugin installation
// ---------------------------------------------------------------------------

/// Install the agent-specific plugin/hooks. Returns true if installation succeeded.
pub(crate) fn install_agent_plugin(agent: AgentKind) -> Result<bool> {
    println!();
    style::header(&format!("Installing {agent} plugin"));
    println!();

    match agent {
        AgentKind::Claude => install_claude_plugin(),
        AgentKind::Gemini => install_gemini_plugin(),
        AgentKind::Codex => install_codex_plugin(),
        AgentKind::AmazonQ => install_amazonq_plugin(),
        AgentKind::OpenCode => install_opencode_plugin(),
        AgentKind::Copilot => install_copilot_plugin(),
    }
}

fn install_claude_plugin() -> Result<bool> {
    let claude = claude_settings::ClaudeSettings::new();

    // Write hooks directly into ~/.claude/settings.json.
    // This is more reliable than the plugin marketplace flow, which requires
    // Claude Code to resolve plugin directories at runtime.
    claude
        .update(claude_settings::SettingsLevel::User, |settings| {
            let hooks = settings.hooks.get_or_insert_with(Default::default);
            install_clash_hook_config(hooks);
            settings.mark_clash_installed();
        })
        .context("writing clash hooks to Claude Code settings")?;

    ui::success("Clash hooks installed in Claude Code settings.");
    Ok(true)
}

/// Install clash hook commands into a `Hooks` config.
///
/// Public so `doctor.rs` can reuse it for the fix-up flow.
///
/// Each hook event gets a `clash hook <event>` command with a wildcard matcher.
/// Existing non-clash hooks are preserved.
pub fn install_clash_hook_config(hooks: &mut claude_settings::Hooks) {
    use claude_settings::{Hook, HookMatcher};

    let cmd_hook = |subcommand: &str| HookMatcher {
        matcher: String::new(),
        hooks: vec![Hook {
            hook_type: "command".into(),
            command: Some(format!("{HOOK_CMD_PREFIX} {subcommand}")),
            timeout: None,
        }],
    };

    let cmd_hook_matched = |subcommand: &str| HookMatcher {
        matcher: "*".into(),
        hooks: vec![Hook {
            hook_type: "command".into(),
            command: Some(format!("{HOOK_CMD_PREFIX} {subcommand}")),
            timeout: None,
        }],
    };

    // For config types that use HookConfig (matcher-based), merge with existing hooks.
    let merge_hook_config = |existing: &mut Option<claude_settings::HookConfig>,
                             subcommand: &str| {
        let clash_cmd = format!("{HOOK_CMD_PREFIX} {subcommand}");
        match existing {
            Some(config) => {
                // Check if clash hook is already present.
                let already_installed = match config {
                    claude_settings::HookConfig::Simple(map) => {
                        map.values().any(|v| v.contains(HOOK_CMD_PREFIX))
                    }
                    claude_settings::HookConfig::Matchers(matchers) => matchers.iter().any(|m| {
                        m.hooks.iter().any(|h| {
                            h.command
                                .as_deref()
                                .is_some_and(|c| c.contains(HOOK_CMD_PREFIX))
                        })
                    }),
                };
                if !already_installed {
                    *config = config.clone().insert("*", &clash_cmd);
                }
            }
            None => {
                *existing = Some(claude_settings::HookConfig::Matchers(vec![
                    cmd_hook_matched(subcommand),
                ]));
            }
        }
    };

    merge_hook_config(&mut hooks.pre_tool_use, "pre-tool-use");
    merge_hook_config(&mut hooks.post_tool_use, "post-tool-use");
    merge_hook_config(&mut hooks.permission_request, "permission-request");
    merge_hook_config(&mut hooks.notification, "notification");

    // SessionStart uses Vec<HookMatcher> directly (no matcher pattern needed).
    let session_already = hooks.session_start.as_ref().is_some_and(|matchers| {
        matchers.iter().any(|m| {
            m.hooks.iter().any(|h| {
                h.command
                    .as_deref()
                    .is_some_and(|c| c.contains(HOOK_CMD_PREFIX))
            })
        })
    });
    if !session_already {
        hooks
            .session_start
            .get_or_insert_with(Vec::new)
            .push(cmd_hook("session-start"));
    }
}

fn install_gemini_plugin() -> Result<bool> {
    let ext_dir = std::env::temp_dir().join("clash-gemini-ext");
    let hooks_dir = ext_dir.join("hooks");
    std::fs::create_dir_all(&hooks_dir)
        .context("failed to create hooks directory in temp extension")?;
    std::fs::write(ext_dir.join("gemini-extension.json"), GEMINI_EXTENSION_JSON)
        .context("failed to write gemini-extension.json")?;
    std::fs::write(hooks_dir.join("hooks.json"), GEMINI_HOOKS_JSON)
        .context("failed to write hooks/hooks.json")?;

    let output = std::process::Command::new("gemini")
        .args(["extensions", "install", &ext_dir.display().to_string()])
        .output();

    match output {
        Ok(o) if o.status.success() => {
            ui::success("Clash extension installed in Gemini CLI");
            Ok(true)
        }
        Ok(o) => {
            let stderr = String::from_utf8_lossy(&o.stderr);
            ui::warn(&format!(
                "Could not install Gemini extension: {stderr}\n  \
                 You can install it manually later:\n    \
                 gemini extensions install <path-to-extension-dir>"
            ));
            Ok(false)
        }
        Err(e) => {
            ui::warn(&format!(
                "Could not run gemini CLI: {e}\n  \
                 Install the Gemini CLI, then run:\n    \
                 clash init --agent gemini"
            ));
            Ok(false)
        }
    }
}

fn install_codex_plugin() -> Result<bool> {
    let codex_dir = dirs::home_dir()
        .context("could not determine home directory")?
        .join(".codex");
    std::fs::create_dir_all(&codex_dir)
        .with_context(|| format!("failed to create {}", codex_dir.display()))?;
    let dest = codex_dir.join("config.toml");
    let clash_hooks: toml::Value =
        toml::from_str(CODEX_HOOKS_TOML).context("failed to parse embedded Codex hooks TOML")?;
    if dest.exists() {
        let existing = std::fs::read_to_string(&dest)
            .with_context(|| format!("failed to read {}", dest.display()))?;
        let mut config: toml::Value = toml::from_str(&existing)
            .with_context(|| format!("failed to parse {}", dest.display()))?;
        // Merge clash hooks into the existing [hooks] table.
        let hooks_table = config
            .as_table_mut()
            .context("codex config is not a TOML table")?
            .entry("hooks")
            .or_insert_with(|| toml::Value::Table(toml::Table::new()));
        if let (Some(dst), Some(src)) = (
            hooks_table.as_table_mut(),
            clash_hooks.get("hooks").and_then(|h| h.as_table()),
        ) {
            for (key, value) in src {
                dst.insert(key.clone(), value.clone());
            }
        }
        std::fs::write(&dest, toml::to_string_pretty(&config)?)
            .with_context(|| format!("failed to write {}", dest.display()))?;
        ui::success(&format!("Clash hooks merged into {}", dest.display()));
    } else {
        std::fs::write(&dest, CODEX_HOOKS_TOML)
            .with_context(|| format!("failed to write {}", dest.display()))?;
        ui::success(&format!("Hooks config installed at {}", dest.display()));
    }
    Ok(true)
}

fn install_amazonq_plugin() -> Result<bool> {
    let amazonq_dir = dirs::home_dir()
        .context("could not determine home directory")?
        .join(".amazonq");
    std::fs::create_dir_all(&amazonq_dir)
        .with_context(|| format!("failed to create {}", amazonq_dir.display()))?;
    let dest = amazonq_dir.join("agent.json");
    let clash_hooks: serde_json::Value = serde_json::from_str(AMAZONQ_AGENT_JSON)
        .context("failed to parse embedded Amazon Q hooks JSON")?;
    if dest.exists() {
        let existing = std::fs::read_to_string(&dest)
            .with_context(|| format!("failed to read {}", dest.display()))?;
        let mut config: serde_json::Value = serde_json::from_str(&existing)
            .with_context(|| format!("failed to parse {}", dest.display()))?;
        // Merge clash hook arrays into the existing "hooks" object.
        let dst_hooks = config
            .as_object_mut()
            .context("amazonq config is not a JSON object")?
            .entry("hooks")
            .or_insert_with(|| json!({}));
        if let (Some(dst), Some(src)) = (
            dst_hooks.as_object_mut(),
            clash_hooks.get("hooks").and_then(|h| h.as_object()),
        ) {
            for (key, value) in src {
                dst.insert(key.clone(), value.clone());
            }
        }
        std::fs::write(&dest, serde_json::to_string_pretty(&config)?)
            .with_context(|| format!("failed to write {}", dest.display()))?;
        ui::success(&format!("Clash hooks merged into {}", dest.display()));
    } else {
        std::fs::write(&dest, AMAZONQ_AGENT_JSON)
            .with_context(|| format!("failed to write {}", dest.display()))?;
        ui::success(&format!("Hooks config installed at {}", dest.display()));
    }
    Ok(true)
}

fn install_opencode_plugin() -> Result<bool> {
    let plugins_dir = dirs::home_dir()
        .context("could not determine home directory")?
        .join(".opencode")
        .join("plugins");
    std::fs::create_dir_all(&plugins_dir)
        .context("failed to create ~/.opencode/plugins directory")?;
    let dest = plugins_dir.join("clash.ts");
    std::fs::write(&dest, OPENCODE_PLUGIN_TS)
        .with_context(|| format!("failed to write {}", dest.display()))?;
    ui::success(&format!("Plugin installed at {}", dest.display()));
    Ok(true)
}

fn install_copilot_plugin() -> Result<bool> {
    let hooks_dir = std::path::Path::new(".github/hooks");
    std::fs::create_dir_all(hooks_dir).context("failed to create .github/hooks directory")?;
    let dest = hooks_dir.join("pre-tool-use.json");
    std::fs::write(&dest, COPILOT_HOOKS_JSON)
        .with_context(|| format!("failed to write {}", dest.display()))?;
    ui::success(&format!("Hooks installed at {}", dest.display()));
    Ok(true)
}

// ---------------------------------------------------------------------------
// Summary
// ---------------------------------------------------------------------------

fn print_summary(actions: &InitActions, agent: AgentKind) {
    let any_action = actions.policy_created
        || actions.policy_reviewed
        || actions.plugin_installed
        || actions.statusline_installed;
    if !any_action {
        return;
    }

    println!();
    println!(
        "{}",
        style::bold("Setup complete! Here's what was configured:")
    );
    println!();

    if actions.policy_created {
        ui::success("Policy created");
    } else if actions.policy_reviewed {
        ui::success("Policy reviewed");
    }
    if actions.plugin_installed {
        ui::success(&format!("Clash plugin installed for {agent}"));
    }
    if actions.statusline_installed {
        ui::success("Status line installed");
    }

    println!();
    println!("{}:", style::bold("To undo"));
    println!(
        "  {}  {}",
        style::dim("clash uninstall"),
        style::dim("# remove everything")
    );
    if actions.policy_created {
        println!(
            "  {}  {}",
            style::dim("clash policy edit"),
            style::dim("# modify your policy")
        );
    }

    println!();
    println!("{}:", style::bold("Next steps"));
    println!(
        "  {}  {}",
        style::dim(&format!("clash doctor --agent {agent}")),
        style::dim("# verify the setup is correct")
    );
    println!(
        "  {}  {}",
        style::dim("clash policy show"),
        style::dim("# view the compiled policy")
    );
}

/// Remove clash hooks from a `Hooks` config, preserving non-clash hooks.
///
/// Returns `true` if any hooks were removed.
pub fn uninstall_clash_hooks(hooks: &mut claude_settings::Hooks) -> bool {
    let mut changed = false;
    changed |= remove_clash_from_config(&mut hooks.pre_tool_use);
    changed |= remove_clash_from_config(&mut hooks.post_tool_use);
    changed |= remove_clash_from_config(&mut hooks.permission_request);
    changed |= remove_clash_from_config(&mut hooks.notification);
    changed |= remove_clash_from_vec(&mut hooks.session_start);
    changed |= remove_clash_from_vec(&mut hooks.stop);
    changed
}

fn is_clash_hook(h: &claude_settings::Hook) -> bool {
    h.command
        .as_deref()
        .is_some_and(|c| c.contains(HOOK_CMD_PREFIX))
}

fn remove_clash_from_config(config: &mut Option<claude_settings::HookConfig>) -> bool {
    let Some(c) = config.take() else {
        return false;
    };
    match c {
        claude_settings::HookConfig::Simple(mut map) => {
            let before = map.len();
            map.retain(|_, v| !v.contains(HOOK_CMD_PREFIX));
            let removed = map.len() != before;
            if !map.is_empty() {
                *config = Some(claude_settings::HookConfig::Simple(map));
            }
            removed
        }
        claude_settings::HookConfig::Matchers(mut matchers) => {
            let before = matchers.len();
            for m in &mut matchers {
                m.hooks.retain(|h| !is_clash_hook(h));
            }
            matchers.retain(|m| !m.hooks.is_empty());
            let removed = matchers.len() != before;
            if !matchers.is_empty() {
                *config = Some(claude_settings::HookConfig::Matchers(matchers));
            }
            removed
        }
    }
}

fn remove_clash_from_vec(opt: &mut Option<Vec<claude_settings::HookMatcher>>) -> bool {
    let Some(mut v) = opt.take() else {
        return false;
    };
    let before = v.len();
    for m in &mut v {
        m.hooks.retain(|h| !is_clash_hook(h));
    }
    v.retain(|m| !m.hooks.is_empty());
    let removed = v.len() != before;
    if !v.is_empty() {
        *opt = Some(v);
    }
    removed
}

#[cfg(test)]
mod tests {
    #[test]
    fn detected_policy_compiles() {
        let ecosystems: Vec<&crate::ecosystem::EcosystemDef> = crate::ecosystem::ECOSYSTEMS
            .iter()
            .filter(|e| e.name == "rust" || e.name == "git")
            .collect();
        let starlark = crate::ecosystem::generate_policy(&ecosystems);
        let output = clash_starlark::evaluate(&starlark, "<test>", std::path::Path::new("."))
            .expect("detected policy must evaluate");
        crate::policy::compile::compile_to_tree(&output.json)
            .expect("detected policy must compile");
    }

    #[test]
    fn starter_policy_compiles() {
        use crate::settings::compile_default_policy_to_json;
        let json_str = compile_default_policy_to_json().expect("compile default policy");
        crate::policy::compile::compile_to_tree(&json_str)
            .expect("starter policy must compile without errors");
    }

    #[test]
    fn rust_sandbox_compiles() {
        let source = "load(\"@clash//rust.star\", \"rust_safe\", \"rust_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"cargo\", \"rustc\", \"rustup\"): {glob(\"**\"): allow(sandbox=rust_safe)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("rust sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("rust sandbox must compile");
    }

    #[test]
    fn python_sandbox_compiles() {
        let source = "load(\"@clash//python.star\", \"python_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"python\", \"python3\"): {glob(\"**\"): allow(sandbox=python_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("python sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("python sandbox must compile");
    }

    #[test]
    fn node_sandbox_compiles() {
        let source = "load(\"@clash//node.star\", \"node_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"node\", \"npm\"): {glob(\"**\"): allow(sandbox=node_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("node sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("node sandbox must compile");
    }

    #[test]
    fn go_sandbox_compiles() {
        let source = "load(\"@clash//go.star\", \"go_safe\", \"go_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {\"go\": {glob(\"**\"): allow(sandbox=go_safe)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("go sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("go sandbox must compile");
    }

    #[test]
    fn java_sandbox_compiles() {
        let source = "load(\"@clash//java.star\", \"java_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"gradle\", \"mvn\"): {glob(\"**\"): allow(sandbox=java_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("java sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("java sandbox must compile");
    }

    #[test]
    fn ruby_sandbox_compiles() {
        let source = "load(\"@clash//ruby.star\", \"ruby_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"ruby\", \"gem\", \"bundle\"): {glob(\"**\"): allow(sandbox=ruby_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("ruby sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("ruby sandbox must compile");
    }

    #[test]
    fn docker_sandbox_compiles() {
        let source = "load(\"@clash//docker.star\", \"docker_safe\", \"docker_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"docker\", \"podman\"): {glob(\"**\"): allow(sandbox=docker_safe)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("docker sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("docker sandbox must compile");
    }

    #[test]
    fn swift_sandbox_compiles() {
        let source = "load(\"@clash//swift.star\", \"swift_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"swift\", \"xcodebuild\"): {glob(\"**\"): allow(sandbox=swift_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("swift sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("swift sandbox must compile");
    }

    #[test]
    fn dotnet_sandbox_compiles() {
        let source = "load(\"@clash//dotnet.star\", \"dotnet_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"dotnet\", \"msbuild\"): {glob(\"**\"): allow(sandbox=dotnet_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("dotnet sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("dotnet sandbox must compile");
    }

    #[test]
    fn make_sandbox_compiles() {
        let source = "load(\"@clash//make.star\", \"make_full\")\n\npolicy(\"test\", {tool(\"Bash\"): {(\"make\", \"cmake\", \"just\"): {glob(\"**\"): allow(sandbox=make_full)}}})";
        let output = clash_starlark::evaluate(source, "<test>", std::path::Path::new("."))
            .expect("make sandbox starlark evaluation");
        crate::policy::compile::compile_to_tree(&output.json).expect("make sandbox must compile");
    }
}