cjc-runtime 0.1.9

Runtime library: values, builtins, tensors, COW buffers
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
//! ODE / PDE Solver Infrastructure — Minimal Primitives
//!
//! These are stub primitives designed for future library integration (Bastion).
//! They provide the foundational stepping functions; full solver loops and
//! adaptive algorithms will be built as CJC library code on top of these.

use crate::tensor::Tensor;
use cjc_repro::kahan_sum_f64;

// ---------------------------------------------------------------------------
// ODE Stepping Primitives
// ---------------------------------------------------------------------------

/// Single step of Euler's method: y_{n+1} = y_n + h * f(t_n, y_n).
///
/// # Arguments
/// * `y` - Current state vector (1D tensor)
/// * `dydt` - Derivative vector at current time (1D tensor, same shape as y)
/// * `h` - Step size
///
/// # Returns
/// New state vector y_{n+1}
pub fn ode_step_euler(y: &Tensor, dydt: &Tensor, h: f64) -> Tensor {
    let y_data = y.to_vec();
    let dy_data = dydt.to_vec();
    assert_eq!(y_data.len(), dy_data.len(), "ode_step_euler: y and dydt must have same length");

    let result: Vec<f64> = y_data.iter().zip(dy_data.iter())
        .map(|(&yi, &dyi)| yi + h * dyi)
        .collect();
    Tensor::from_vec_unchecked(result, y.shape())
}

/// Single step of classical RK4: 4th-order Runge-Kutta.
///
/// Takes four derivative evaluations (k1, k2, k3, k4) and combines them
/// using the standard RK4 formula:
///   y_{n+1} = y_n + (h/6)(k1 + 2*k2 + 2*k3 + k4)
///
/// The caller is responsible for evaluating k1..k4 at the appropriate
/// intermediate points. This keeps the stepping primitive pure and
/// independent of the RHS function.
pub fn ode_step_rk4(y: &Tensor, k1: &Tensor, k2: &Tensor, k3: &Tensor, k4: &Tensor, h: f64) -> Tensor {
    let y_data = y.to_vec();
    let k1_data = k1.to_vec();
    let k2_data = k2.to_vec();
    let k3_data = k3.to_vec();
    let k4_data = k4.to_vec();
    let n = y_data.len();
    assert_eq!(k1_data.len(), n);
    assert_eq!(k2_data.len(), n);
    assert_eq!(k3_data.len(), n);
    assert_eq!(k4_data.len(), n);

    let h6 = h / 6.0;
    let result: Vec<f64> = (0..n)
        .map(|i| {
            // Use Kahan summation for the weighted sum to maintain determinism
            let terms = [
                k1_data[i],
                2.0 * k2_data[i],
                2.0 * k3_data[i],
                k4_data[i],
            ];
            y_data[i] + h6 * kahan_sum_f64(&terms)
        })
        .collect();
    Tensor::from_vec_unchecked(result, y.shape())
}

// ---------------------------------------------------------------------------
// PDE Stepping Primitives
// ---------------------------------------------------------------------------

/// 1D finite-difference Laplacian: d^2u/dx^2 ≈ (u[i-1] - 2*u[i] + u[i+1]) / dx^2
///
/// Boundary condition: Dirichlet (u[0] and u[n-1] are held fixed, not updated).
///
/// # Arguments
/// * `u` - Current field values (1D tensor of length n)
/// * `dx` - Grid spacing
///
/// # Returns
/// Laplacian approximation (1D tensor, same shape; boundary elements are 0.0)
pub fn pde_laplacian_1d(u: &Tensor, dx: f64) -> Tensor {
    let data = u.to_vec();
    let n = data.len();
    let dx2_inv = 1.0 / (dx * dx);
    let mut lap = vec![0.0_f64; n];

    for i in 1..n - 1 {
        lap[i] = (data[i - 1] - 2.0 * data[i] + data[i + 1]) * dx2_inv;
    }

    Tensor::from_vec_unchecked(lap, u.shape())
}

/// Single explicit Euler step for a heat/diffusion PDE:
///   u_{n+1} = u_n + dt * alpha * laplacian(u_n)
///
/// # Arguments
/// * `u` - Current field values
/// * `alpha` - Diffusion coefficient
/// * `dt` - Time step
/// * `dx` - Spatial grid spacing
///
/// # Returns
/// Updated field values
pub fn pde_step_diffusion(u: &Tensor, alpha: f64, dt: f64, dx: f64) -> Tensor {
    let lap = pde_laplacian_1d(u, dx);
    let u_data = u.to_vec();
    let lap_data = lap.to_vec();
    let result: Vec<f64> = u_data.iter().zip(lap_data.iter())
        .map(|(&ui, &li)| ui + dt * alpha * li)
        .collect();
    Tensor::from_vec_unchecked(result, u.shape())
}

// ---------------------------------------------------------------------------
// Symbolic Differentiation Primitives
// ---------------------------------------------------------------------------

/// Symbolic expression representation for automatic symbolic differentiation.
///
/// These are value-level symbolic expressions that can be differentiated
/// symbolically before evaluation. This provides exact derivatives without
/// numerical error.
#[derive(Debug, Clone, PartialEq)]
pub enum SymExpr {
    /// Constant value
    Const(f64),
    /// Variable reference (by name)
    Var(String),
    /// Addition
    Add(Box<SymExpr>, Box<SymExpr>),
    /// Multiplication
    Mul(Box<SymExpr>, Box<SymExpr>),
    /// Power: base^exponent (exponent is a constant)
    Pow(Box<SymExpr>, f64),
    /// Sine
    Sin(Box<SymExpr>),
    /// Cosine
    Cos(Box<SymExpr>),
    /// Exponential
    Exp(Box<SymExpr>),
    /// Natural logarithm
    Ln(Box<SymExpr>),
    /// Negation
    Neg(Box<SymExpr>),
}

impl SymExpr {
    /// Symbolically differentiate with respect to variable `var`.
    pub fn differentiate(&self, var: &str) -> SymExpr {
        match self {
            SymExpr::Const(_) => SymExpr::Const(0.0),
            SymExpr::Var(name) => {
                if name == var {
                    SymExpr::Const(1.0)
                } else {
                    SymExpr::Const(0.0)
                }
            }
            SymExpr::Add(a, b) => SymExpr::Add(
                Box::new(a.differentiate(var)),
                Box::new(b.differentiate(var)),
            ),
            SymExpr::Mul(a, b) => {
                // Product rule: (f*g)' = f'*g + f*g'
                SymExpr::Add(
                    Box::new(SymExpr::Mul(
                        Box::new(a.differentiate(var)),
                        b.clone(),
                    )),
                    Box::new(SymExpr::Mul(
                        a.clone(),
                        Box::new(b.differentiate(var)),
                    )),
                )
            }
            SymExpr::Pow(base, exp) => {
                // d/dx [f^n] = n * f^(n-1) * f'
                SymExpr::Mul(
                    Box::new(SymExpr::Mul(
                        Box::new(SymExpr::Const(*exp)),
                        Box::new(SymExpr::Pow(base.clone(), exp - 1.0)),
                    )),
                    Box::new(base.differentiate(var)),
                )
            }
            SymExpr::Sin(inner) => {
                // d/dx sin(f) = cos(f) * f'
                SymExpr::Mul(
                    Box::new(SymExpr::Cos(inner.clone())),
                    Box::new(inner.differentiate(var)),
                )
            }
            SymExpr::Cos(inner) => {
                // d/dx cos(f) = -sin(f) * f'
                SymExpr::Mul(
                    Box::new(SymExpr::Neg(Box::new(SymExpr::Sin(inner.clone())))),
                    Box::new(inner.differentiate(var)),
                )
            }
            SymExpr::Exp(inner) => {
                // d/dx exp(f) = exp(f) * f'
                SymExpr::Mul(
                    Box::new(SymExpr::Exp(inner.clone())),
                    Box::new(inner.differentiate(var)),
                )
            }
            SymExpr::Ln(inner) => {
                // d/dx ln(f) = f' / f
                SymExpr::Mul(
                    Box::new(SymExpr::Pow(inner.clone(), -1.0)),
                    Box::new(inner.differentiate(var)),
                )
            }
            SymExpr::Neg(inner) => {
                SymExpr::Neg(Box::new(inner.differentiate(var)))
            }
        }
    }

    /// Evaluate the symbolic expression with the given variable bindings.
    pub fn eval(&self, bindings: &std::collections::BTreeMap<String, f64>) -> f64 {
        match self {
            SymExpr::Const(c) => *c,
            SymExpr::Var(name) => *bindings.get(name).unwrap_or(&0.0),
            SymExpr::Add(a, b) => a.eval(bindings) + b.eval(bindings),
            SymExpr::Mul(a, b) => a.eval(bindings) * b.eval(bindings),
            SymExpr::Pow(base, exp) => base.eval(bindings).powf(*exp),
            SymExpr::Sin(inner) => inner.eval(bindings).sin(),
            SymExpr::Cos(inner) => inner.eval(bindings).cos(),
            SymExpr::Exp(inner) => inner.eval(bindings).exp(),
            SymExpr::Ln(inner) => inner.eval(bindings).ln(),
            SymExpr::Neg(inner) => -inner.eval(bindings),
        }
    }
}

// ---------------------------------------------------------------------------
// Full ODE Solver Loops (Sprint 3)
// ---------------------------------------------------------------------------

/// Add two tensors element-wise: result[i] = a[i] + b[i].
#[allow(dead_code)]
fn tensor_add(a: &Tensor, b: &Tensor) -> Tensor {
    let a_data = a.to_vec();
    let b_data = b.to_vec();
    debug_assert_eq!(a_data.len(), b_data.len());
    let result: Vec<f64> = a_data.iter().zip(b_data.iter()).map(|(&ai, &bi)| ai + bi).collect();
    Tensor::from_vec_unchecked(result, a.shape())
}

/// Scale tensor element-wise: result[i] = scalar * a[i].
fn tensor_scale(a: &Tensor, scalar: f64) -> Tensor {
    let a_data = a.to_vec();
    let result: Vec<f64> = a_data.iter().map(|&ai| scalar * ai).collect();
    Tensor::from_vec_unchecked(result, a.shape())
}

/// Weighted sum of tensors: result[i] = a[i] + scalar * b[i].
fn tensor_add_scaled(a: &Tensor, b: &Tensor, scalar: f64) -> Tensor {
    let a_data = a.to_vec();
    let b_data = b.to_vec();
    debug_assert_eq!(a_data.len(), b_data.len());
    let result: Vec<f64> = a_data.iter().zip(b_data.iter()).map(|(&ai, &bi)| ai + scalar * bi).collect();
    Tensor::from_vec_unchecked(result, a.shape())
}

/// Compute L2 norm of tensor using Kahan summation for determinism.
fn tensor_norm(a: &Tensor) -> f64 {
    let data = a.to_vec();
    let terms: Vec<f64> = data.iter().map(|&x| x * x).collect();
    kahan_sum_f64(&terms).sqrt()
}

/// Full RK4 solver: integrates dy/dt = f(t, y) over [t0, t1] using `n_steps` equal steps.
///
/// Uses the classical 4th-order Runge-Kutta method with Kahan summation for
/// the weighted combination step to preserve bit-identical results.
///
/// # Arguments
/// * `f` - RHS function: f(t, y) → dy/dt
/// * `y0` - Initial state (1D tensor)
/// * `t_span` - (t0, t1) integration interval
/// * `n_steps` - Number of uniform steps
///
/// # Returns
/// `(time_points, solution_tensors)` — vectors of length `n_steps + 1`
pub fn ode_solve_rk4<F>(
    mut f: F,
    y0: &Tensor,
    t_span: (f64, f64),
    n_steps: usize,
) -> (Vec<f64>, Vec<Tensor>)
where
    F: FnMut(f64, &Tensor) -> Tensor,
{
    assert!(n_steps > 0, "ode_solve_rk4: n_steps must be > 0");
    let (t0, t1) = t_span;
    let h = (t1 - t0) / n_steps as f64;

    let mut ts = Vec::with_capacity(n_steps + 1);
    let mut ys = Vec::with_capacity(n_steps + 1);

    ts.push(t0);
    ys.push(y0.clone());

    let mut t = t0;
    let mut y = y0.clone();

    for _ in 0..n_steps {
        let k1 = f(t, &y);
        let y2 = tensor_add_scaled(&y, &k1, h * 0.5);
        let k2 = f(t + h * 0.5, &y2);
        let y3 = tensor_add_scaled(&y, &k2, h * 0.5);
        let k3 = f(t + h * 0.5, &y3);
        let y4 = tensor_add_scaled(&y, &k3, h);
        let k4 = f(t + h, &y4);

        // Use ode_step_rk4 primitive which applies Kahan summation internally
        y = ode_step_rk4(&y, &k1, &k2, &k3, &k4, h);
        t += h;

        ts.push(t);
        ys.push(y.clone());
    }

    (ts, ys)
}

/// Dormand-Prince RK45 Butcher tableau coefficients.
/// These are the standard DP5 coefficients.
mod dp5 {
    pub const C2: f64 = 1.0 / 5.0;
    pub const C3: f64 = 3.0 / 10.0;
    pub const C4: f64 = 4.0 / 5.0;
    pub const C5: f64 = 8.0 / 9.0;
    // C6 = 1.0, C7 = 1.0

    pub const A21: f64 = 1.0 / 5.0;
    pub const A31: f64 = 3.0 / 40.0;
    pub const A32: f64 = 9.0 / 40.0;
    pub const A41: f64 = 44.0 / 45.0;
    pub const A42: f64 = -56.0 / 15.0;
    pub const A43: f64 = 32.0 / 9.0;
    pub const A51: f64 = 19372.0 / 6561.0;
    pub const A52: f64 = -25360.0 / 2187.0;
    pub const A53: f64 = 64448.0 / 6561.0;
    pub const A54: f64 = -212.0 / 729.0;
    pub const A61: f64 = 9017.0 / 3168.0;
    pub const A62: f64 = -355.0 / 33.0;
    pub const A63: f64 = 46732.0 / 5247.0;
    pub const A64: f64 = 49.0 / 176.0;
    pub const A65: f64 = -5103.0 / 18656.0;

    // 5th-order solution weights (b)
    pub const B1: f64 = 35.0 / 384.0;
    // B2 = 0
    pub const B3: f64 = 500.0 / 1113.0;
    pub const B4: f64 = 125.0 / 192.0;
    pub const B5: f64 = -2187.0 / 6784.0;
    pub const B6: f64 = 11.0 / 84.0;
    // B7 = 0

    // 4th-order error estimate weights (e = b - b*)
    // b* are the 4th-order weights; e_i = b_i - b*_i
    pub const E1: f64 = 71.0 / 57600.0;
    // E2 = 0
    pub const E3: f64 = -71.0 / 16695.0;
    pub const E4: f64 = 71.0 / 1920.0;
    pub const E5: f64 = -17253.0 / 339200.0;
    pub const E6: f64 = 22.0 / 525.0;
    pub const E7: f64 = -1.0 / 40.0;
}

/// Adaptive Dormand-Prince RK45 solver.
///
/// Integrates dy/dt = f(t, y) over t_span using adaptive step control.
/// Error is estimated as the difference between 5th and 4th order solutions.
/// Step size is adjusted to keep the local error within `atol + rtol * |y|`.
///
/// # Arguments
/// * `f` - RHS function: f(t, y) → dy/dt
/// * `y0` - Initial state (1D tensor)
/// * `t_span` - (t0, t1) integration interval
/// * `rtol` - Relative tolerance (e.g. 1e-6)
/// * `atol` - Absolute tolerance (e.g. 1e-9)
///
/// # Returns
/// `(time_points, solution_tensors)` — variable length, one entry per accepted step.
pub fn ode_solve_rk45<F>(
    mut f: F,
    y0: &Tensor,
    t_span: (f64, f64),
    rtol: f64,
    atol: f64,
) -> (Vec<f64>, Vec<Tensor>)
where
    F: FnMut(f64, &Tensor) -> Tensor,
{
    let (t0, t1) = t_span;
    assert!(t1 > t0, "ode_solve_rk45: t1 must be > t0");

    let mut ts = Vec::new();
    let mut ys = Vec::new();

    ts.push(t0);
    ys.push(y0.clone());

    let n = y0.to_vec().len();

    // Initial step size heuristic
    let f0 = f(t0, y0);
    let f0_norm = tensor_norm(&f0).max(1e-300);
    let mut h = (0.01 * (t1 - t0)).min(0.1 / f0_norm);
    h = h.max(1e-12);

    let mut t = t0;
    let mut y = y0.clone();
    let safety = 0.9_f64;
    let max_factor = 10.0_f64;
    let min_factor = 0.2_f64;
    let max_steps = 1_000_000_usize;
    let mut step_count = 0;

    while t < t1 && step_count < max_steps {
        // Don't overshoot the endpoint
        if t + h > t1 {
            h = t1 - t;
        }

        // Evaluate all 7 stages of Dormand-Prince
        let k1 = f(t, &y);
        let y2 = tensor_add_scaled(&y, &k1, h * dp5::A21);
        let k2 = f(t + dp5::C2 * h, &y2);
        // k3 stage
        let mut y3_data = y.to_vec();
        let k1d = k1.to_vec(); let k2d = k2.to_vec();
        for i in 0..n {
            y3_data[i] += h * (dp5::A31 * k1d[i] + dp5::A32 * k2d[i]);
        }
        let y3 = Tensor::from_vec_unchecked(y3_data, y.shape());
        let k3 = f(t + dp5::C3 * h, &y3);
        // k4 stage
        let k3d = k3.to_vec();
        let mut y4_data = y.to_vec();
        for i in 0..n {
            y4_data[i] += h * (dp5::A41 * k1d[i] + dp5::A42 * k2d[i] + dp5::A43 * k3d[i]);
        }
        let y4 = Tensor::from_vec_unchecked(y4_data, y.shape());
        let k4 = f(t + dp5::C4 * h, &y4);
        // k5 stage
        let k4d = k4.to_vec();
        let mut y5_data = y.to_vec();
        for i in 0..n {
            y5_data[i] += h * (dp5::A51 * k1d[i] + dp5::A52 * k2d[i] + dp5::A53 * k3d[i] + dp5::A54 * k4d[i]);
        }
        let y5 = Tensor::from_vec_unchecked(y5_data, y.shape());
        let k5 = f(t + dp5::C5 * h, &y5);
        // k6 stage
        let k5d = k5.to_vec();
        let mut y6_data = y.to_vec();
        for i in 0..n {
            y6_data[i] += h * (dp5::A61 * k1d[i] + dp5::A62 * k2d[i] + dp5::A63 * k3d[i] + dp5::A64 * k4d[i] + dp5::A65 * k5d[i]);
        }
        let y6 = Tensor::from_vec_unchecked(y6_data, y.shape());
        let k6 = f(t + h, &y6);
        // 5th-order solution
        let k6d = k6.to_vec();
        let y_data = y.to_vec();
        let mut y5th_data = vec![0.0_f64; n];
        for i in 0..n {
            let terms = [
                dp5::B1 * k1d[i],
                dp5::B3 * k3d[i],
                dp5::B4 * k4d[i],
                dp5::B5 * k5d[i],
                dp5::B6 * k6d[i],
            ];
            y5th_data[i] = y_data[i] + h * kahan_sum_f64(&terms);
        }
        let y5th = Tensor::from_vec_unchecked(y5th_data.clone(), y.shape());

        // k7 stage (FSAL — first same as last)
        let k7 = f(t + h, &y5th);
        let k7d = k7.to_vec();

        // Error estimate: e = y5 - y4 = h * (E1*k1 + E3*k3 + E4*k4 + E5*k5 + E6*k6 + E7*k7)
        let mut err_sq_acc = 0.0_f64;
        for i in 0..n {
            let e_terms = [
                dp5::E1 * k1d[i],
                dp5::E3 * k3d[i],
                dp5::E4 * k4d[i],
                dp5::E5 * k5d[i],
                dp5::E6 * k6d[i],
                dp5::E7 * k7d[i],
            ];
            let e_i = h * kahan_sum_f64(&e_terms);
            let sc = atol + rtol * y5th_data[i].abs().max(y_data[i].abs());
            err_sq_acc += (e_i / sc) * (e_i / sc);
        }
        let err_norm = (err_sq_acc / n as f64).sqrt();

        if err_norm <= 1.0 {
            // Accept step
            t += h;
            y = y5th;
            ts.push(t);
            ys.push(y.clone());
            step_count += 1;

            // Compute new step size
            let factor = safety * err_norm.powf(-0.2).min(max_factor).max(min_factor);
            h = (h * factor).min(t1 - t);
            if h < 1e-14 {
                break;
            }
        } else {
            // Reject step — reduce h
            let factor = (safety * err_norm.powf(-0.25)).max(min_factor);
            h *= factor;
            if h < 1e-14 {
                break;
            }
        }
    }

    (ts, ys)
}

/// Adjoint method for Neural ODEs — O(1) memory gradient computation.
///
/// Given the final state y(T) and a loss gradient (adjoint at T), integrates
/// the adjoint ODE backward in time to recover y(0) and the adjoint a(t0).
///
/// The augmented backward system is:
///   dy/dt  = f(t, y)               (forward ODE — integrated backward)
///   da/dt  = -a^T * (df/dy)        (adjoint ODE)
///
/// Here `grad_f` provides both:
///   - The Jacobian-vector product a^T * J_y f, i.e. (df/dy)^T * a
///   - The gradient w.r.t. parameters: a^T * (df/dtheta)
///
/// This implementation uses RK4 backward integration for reproducibility.
///
/// # Arguments
/// * `f` - Forward dynamics: f(t, y) → dy/dt
/// * `grad_f` - Returns (vjp_y, vjp_theta): Jacobian-vector product with adjoint.
///   Signature: grad_f(t, y, adjoint) → (adj_dot wrt y, adj_dot wrt params)
/// * `y_final` - State at final time T
/// * `t_span` - (t0, T) — integrates BACKWARD from T to t0
/// * `n_steps` - Number of backward integration steps
///
/// # Returns
/// `(y0_reconstructed, adjoint_at_t0)`
pub fn adjoint_solve<F, G>(
    mut f: F,
    mut grad_f: G,
    y_final: &Tensor,
    t_span: (f64, f64),
    n_steps: usize,
) -> (Tensor, Tensor)
where
    F: FnMut(f64, &Tensor) -> Tensor,
    G: FnMut(f64, &Tensor, &Tensor) -> (Tensor, Tensor),
{
    assert!(n_steps > 0, "adjoint_solve: n_steps must be > 0");
    let (t0, t1) = t_span;
    // h_back is the backward step (positive value; we integrate from t1 down to t0)
    let h = (t1 - t0) / n_steps as f64;

    let n = y_final.to_vec().len();

    // Adjoint at T: initialize to zero (caller can set initial adjoint via y_final if needed)
    // For the Neural ODE formulation, the adjoint at T is typically dL/dy(T),
    // but we provide a zero adjoint here and let the caller compose.
    let a0 = Tensor::from_vec_unchecked(vec![0.0_f64; n], y_final.shape());

    let mut t = t1;
    let mut y = y_final.clone();
    let mut a = a0;

    for _ in 0..n_steps {
        let t_prev = t - h;

        // ---- RK4 backward step for [y, a] ----
        // We integrate BACKWARD: effectively solving with step -h.
        // Augmented state: z = [y; a]
        // dz/dt_back = [-f(t, y); (df/dy)^T * a]
        // We use negative h so that RK4 marches backward.

        // k1 for y: -f(t, y)
        let ky1 = tensor_scale(&f(t, &y), -1.0);
        // k1 for a: +(df/dy)^T * a = grad_y
        let (ka1, _) = grad_f(t, &y, &a);

        // k2
        let y2 = tensor_add_scaled(&y, &ky1, h * 0.5);
        let a2 = tensor_add_scaled(&a, &ka1, h * 0.5);
        let ky2 = tensor_scale(&f(t - h * 0.5, &y2), -1.0);
        let (ka2, _) = grad_f(t - h * 0.5, &y2, &a2);

        // k3
        let y3 = tensor_add_scaled(&y, &ky2, h * 0.5);
        let a3 = tensor_add_scaled(&a, &ka2, h * 0.5);
        let ky3 = tensor_scale(&f(t - h * 0.5, &y3), -1.0);
        let (ka3, _) = grad_f(t - h * 0.5, &y3, &a3);

        // k4
        let y4 = tensor_add_scaled(&y, &ky3, h);
        let a4 = tensor_add_scaled(&a, &ka3, h);
        let ky4 = tensor_scale(&f(t_prev, &y4), -1.0);
        let (ka4, _) = grad_f(t_prev, &y4, &a4);

        // RK4 combination (uses Kahan via ode_step_rk4)
        y = ode_step_rk4(&y, &ky1, &ky2, &ky3, &ky4, h);
        a = ode_step_rk4(&a, &ka1, &ka2, &ka3, &ka4, h);
        t = t_prev;
    }

    (y, a)
}

// ---------------------------------------------------------------------------
// Tests
// ---------------------------------------------------------------------------

#[cfg(test)]
mod tests {
    use super::*;
    use std::collections::BTreeMap;

    #[test]
    fn test_euler_step() {
        let y = Tensor::from_vec_unchecked(vec![1.0, 0.0], &[2]);
        let dydt = Tensor::from_vec_unchecked(vec![0.0, 1.0], &[2]);
        let y1 = ode_step_euler(&y, &dydt, 0.1);
        let result = y1.to_vec();
        assert!((result[0] - 1.0).abs() < 1e-15);
        assert!((result[1] - 0.1).abs() < 1e-15);
    }

    #[test]
    fn test_rk4_step_constant() {
        let y = Tensor::from_vec_unchecked(vec![1.0], &[1]);
        let k = Tensor::from_vec_unchecked(vec![2.0], &[1]);
        let y1 = ode_step_rk4(&y, &k, &k, &k, &k, 0.1);
        // y1 = 1.0 + (0.1/6)*(2+4+4+2) = 1.0 + 0.2 = 1.2
        assert!((y1.to_vec()[0] - 1.2).abs() < 1e-14);
    }

    #[test]
    fn test_laplacian_1d() {
        // u = [0, 1, 4, 9, 16] (x^2 at x=0..4, dx=1)
        // d^2u/dx^2 = 2 everywhere interior
        let u = Tensor::from_vec_unchecked(vec![0.0, 1.0, 4.0, 9.0, 16.0], &[5]);
        let lap = pde_laplacian_1d(&u, 1.0);
        let data = lap.to_vec();
        assert!((data[0] - 0.0).abs() < 1e-14); // boundary
        assert!((data[1] - 2.0).abs() < 1e-14);
        assert!((data[2] - 2.0).abs() < 1e-14);
        assert!((data[3] - 2.0).abs() < 1e-14);
        assert!((data[4] - 0.0).abs() < 1e-14); // boundary
    }

    #[test]
    fn test_symbolic_diff_polynomial() {
        // f(x) = x^3, f'(x) = 3*x^2
        let expr = SymExpr::Pow(Box::new(SymExpr::Var("x".into())), 3.0);
        let deriv = expr.differentiate("x");

        let mut bindings = BTreeMap::new();
        bindings.insert("x".into(), 2.0);

        let val = deriv.eval(&bindings);
        assert!((val - 12.0).abs() < 1e-12); // 3 * 2^2 = 12
    }

    #[test]
    fn test_symbolic_diff_sin() {
        // f(x) = sin(x), f'(x) = cos(x)
        let expr = SymExpr::Sin(Box::new(SymExpr::Var("x".into())));
        let deriv = expr.differentiate("x");

        let mut bindings = BTreeMap::new();
        bindings.insert("x".into(), 0.0);

        let val = deriv.eval(&bindings);
        assert!((val - 1.0).abs() < 1e-12); // cos(0) = 1
    }

    // --- Sprint 3: ODE solver tests ---

    #[test]
    fn test_rk4_exponential_decay() {
        // y' = -y, y(0) = 1  →  y(t) = exp(-t)
        // At t=1.0, exact answer is exp(-1) ≈ 0.36787944117
        let y0 = Tensor::from_vec_unchecked(vec![1.0], &[1]);
        let f = |_t: f64, y: &Tensor| -> Tensor {
            tensor_scale(y, -1.0)
        };
        let (ts, ys) = ode_solve_rk4(f, &y0, (0.0, 1.0), 100);

        assert_eq!(ts.len(), 101);
        assert_eq!(ys.len(), 101);
        assert!((ts[0] - 0.0).abs() < 1e-15);
        assert!((ts[100] - 1.0).abs() < 1e-12);

        let y_final = ys[100].to_vec()[0];
        let exact = (-1.0_f64).exp();
        assert!(
            (y_final - exact).abs() < 1e-8,
            "RK4 decay: got {}, expected {}",
            y_final, exact
        );
    }

    #[test]
    fn test_rk4_harmonic_oscillator() {
        // y'' = -y  with  [y, v]' = [v, -y]
        // y(0) = 1, v(0) = 0  →  y(t) = cos(t), v(t) = -sin(t)
        // At t = pi/2 ≈ 1.5708: y ≈ 0, v ≈ -1
        let y0 = Tensor::from_vec_unchecked(vec![1.0, 0.0], &[2]);
        let f = |_t: f64, y: &Tensor| -> Tensor {
            let d = y.to_vec();
            Tensor::from_vec_unchecked(vec![d[1], -d[0]], &[2])
        };
        let t_end = std::f64::consts::PI / 2.0;
        let (ts, ys) = ode_solve_rk4(f, &y0, (0.0, t_end), 1000);

        let y_end = ys.last().unwrap().to_vec();
        // y(pi/2) = cos(pi/2) ≈ 0
        assert!(
            y_end[0].abs() < 1e-7,
            "harmonic y(pi/2) should be ~0, got {}",
            y_end[0]
        );
        // v(pi/2) = -sin(pi/2) ≈ -1
        assert!(
            (y_end[1] - (-1.0)).abs() < 1e-7,
            "harmonic v(pi/2) should be ~-1, got {}",
            y_end[1]
        );
        let _ = ts;
    }

    #[test]
    fn test_rk45_exponential_decay() {
        // y' = -y, y(0) = 1 → y(1) = exp(-1)
        let y0 = Tensor::from_vec_unchecked(vec![1.0], &[1]);
        let f = |_t: f64, y: &Tensor| -> Tensor {
            tensor_scale(y, -1.0)
        };
        let (ts, ys) = ode_solve_rk45(f, &y0, (0.0, 1.0), 1e-8, 1e-10);

        assert!(!ts.is_empty(), "RK45 should produce at least one step");
        let y_final = ys.last().unwrap().to_vec()[0];
        let t_final = *ts.last().unwrap();
        let exact = (-t_final).exp();
        assert!(
            (y_final - exact).abs() < 1e-6,
            "RK45 decay: got {} at t={}, expected {}",
            y_final, t_final, exact
        );
    }

    #[test]
    fn test_rk45_fewer_steps_than_rk4_fixed() {
        // RK45 adaptive should take fewer steps than RK4 with 1000 fixed steps
        // for a smooth problem (exponential decay)
        let y0 = Tensor::from_vec_unchecked(vec![1.0], &[1]);

        let f_adaptive = |_t: f64, y: &Tensor| -> Tensor { tensor_scale(y, -1.0) };
        let f_fixed = |_t: f64, y: &Tensor| -> Tensor { tensor_scale(y, -1.0) };

        let (ts_adaptive, _) = ode_solve_rk45(f_adaptive, &y0, (0.0, 1.0), 1e-6, 1e-8);
        let (ts_fixed, _) = ode_solve_rk4(f_fixed, &y0, (0.0, 1.0), 1000);

        assert!(
            ts_adaptive.len() < ts_fixed.len(),
            "RK45 adaptive ({} steps) should take fewer steps than RK4 fixed ({} steps)",
            ts_adaptive.len() - 1,
            ts_fixed.len() - 1
        );
    }

    #[test]
    fn test_rk4_determinism() {
        let y0 = Tensor::from_vec_unchecked(vec![1.0, 0.5], &[2]);
        let f = |_t: f64, y: &Tensor| -> Tensor {
            let d = y.to_vec();
            Tensor::from_vec_unchecked(vec![-0.5 * d[0], -0.3 * d[1]], &[2])
        };

        let (ts1, ys1) = ode_solve_rk4(|t, y| { let d = y.to_vec(); Tensor::from_vec_unchecked(vec![-0.5*d[0], -0.3*d[1]], &[2]) }, &y0, (0.0, 1.0), 50);
        let (ts2, ys2) = ode_solve_rk4(|t, y| { let d = y.to_vec(); Tensor::from_vec_unchecked(vec![-0.5*d[0], -0.3*d[1]], &[2]) }, &y0, (0.0, 1.0), 50);

        assert_eq!(ts1, ts2, "RK4 time points must be bit-identical");
        for (y1, y2) in ys1.iter().zip(ys2.iter()) {
            assert_eq!(y1.to_vec(), y2.to_vec(), "RK4 solutions must be bit-identical");
        }
        let _ = f;
    }

    #[test]
    fn test_rk45_determinism() {
        let y0 = Tensor::from_vec_unchecked(vec![1.0], &[1]);

        let run = || ode_solve_rk45(
            |_t, y| tensor_scale(y, -1.0),
            &y0,
            (0.0, 2.0),
            1e-6,
            1e-9,
        );

        let (ts1, ys1) = run();
        let (ts2, ys2) = run();
        assert_eq!(ts1, ts2, "RK45 time points must be bit-identical");
        for (y1, y2) in ys1.iter().zip(ys2.iter()) {
            assert_eq!(y1.to_vec(), y2.to_vec(), "RK45 solutions must be bit-identical");
        }
    }

    #[test]
    fn test_adjoint_linear_ode() {
        // Forward: y' = -y, y(0) = 1  →  y(T) = exp(-T)
        // Adjoint: a' = a (because df/dy = -1, so -(df/dy)^T * a = a)
        // We verify that adjoint_solve recovers y(0) ≈ 1.0 from y(T).

        let t0 = 0.0_f64;
        let t1 = 1.0_f64;
        let y_final = Tensor::from_vec_unchecked(vec![(-t1).exp()], &[1]);

        let (y0_rec, _adj) = adjoint_solve(
            |_t, y| tensor_scale(y, -1.0),
            |_t, y, a| {
                // grad_f w.r.t. y: (df/dy)^T * a = -1 * a = -a
                // The adjoint ODE is: da/dt = -(df/dy)^T * a = a
                // So we return -(-a) = a for the adjoint increment
                let adj_y = tensor_scale(a, 1.0); // da/dt = +a (correct sign)
                let adj_theta = Tensor::from_vec_unchecked(vec![0.0], &[1]);
                (adj_y, adj_theta)
            },
            &y_final,
            (t0, t1),
            1000,
        );

        let y0_val = y0_rec.to_vec()[0];
        assert!(
            (y0_val - 1.0).abs() < 1e-6,
            "adjoint_solve should recover y(0)=1.0, got {}",
            y0_val
        );
    }

    #[test]
    fn test_adjoint_gradient_vs_finite_diff() {
        // For y' = alpha * y, y(0) = 1:
        //   y(T) = exp(alpha * T)
        //   dL/dalpha where L = y(T) = exp(alpha * T)
        //   dL/dalpha = T * exp(alpha * T)
        //
        // We test that the adjoint gives the right gradient magnitude.
        // (This is a unit test for the adjoint ODE machinery.)
        let t1 = 0.5_f64;
        let alpha = 1.0_f64;
        let y_final_val = (alpha * t1).exp();
        let y_final = Tensor::from_vec_unchecked(vec![y_final_val], &[1]);

        // Finite difference gradient: perturb alpha
        let eps = 1e-5;
        let l_plus = ((alpha + eps) * t1).exp();
        let l_minus = ((alpha - eps) * t1).exp();
        let fd_grad = (l_plus - l_minus) / (2.0 * eps);

        // Adjoint: initial adjoint = dL/dy(T) = 1.0
        // We need to inject the terminal condition into the adjoint.
        // We'll do it by setting the adjoint to [1.0] at T.
        let a_terminal = Tensor::from_vec_unchecked(vec![1.0_f64], &[1]);

        // Custom adjoint_solve with non-zero initial adjoint:
        // Manually run backward with a initialized to a_terminal
        let n_steps = 500;
        let h = t1 / n_steps as f64;
        let mut t = t1;
        let mut y = y_final.clone();
        let mut a = a_terminal;

        // Accumulate theta gradient: dL/dalpha = integral of a(t) * y(t) dt
        let mut grad_alpha_acc = 0.0_f64;

        for _ in 0..n_steps {
            let t_prev = t - h;
            // RK4 backward for y and a
            let ky1 = tensor_scale(&tensor_scale(&y, alpha), -1.0);
            let ka1 = tensor_scale(&a, -(-alpha)); // da/dt = -(df/dy)^T * a = -alpha * a

            let y2 = tensor_add_scaled(&y, &ky1, h * 0.5);
            let a2 = tensor_add_scaled(&a, &ka1, h * 0.5);
            let ky2 = tensor_scale(&tensor_scale(&y2, alpha), -1.0);
            let ka2 = tensor_scale(&a2, alpha);

            let y3 = tensor_add_scaled(&y, &ky2, h * 0.5);
            let a3 = tensor_add_scaled(&a, &ka2, h * 0.5);
            let ky3 = tensor_scale(&tensor_scale(&y3, alpha), -1.0);
            let ka3 = tensor_scale(&a3, alpha);

            let y4 = tensor_add_scaled(&y, &ky3, h);
            let a4 = tensor_add_scaled(&a, &ka3, h);
            let ky4 = tensor_scale(&tensor_scale(&y4, alpha), -1.0);
            let ka4 = tensor_scale(&a4, alpha);

            // Theta gradient contribution: a(t)^T * (df/dalpha) = a(t) * y(t)
            // (since df/dalpha = y for this ODE)
            let ay = a.to_vec()[0] * y.to_vec()[0];
            grad_alpha_acc += h * ay;

            y = ode_step_rk4(&y, &ky1, &ky2, &ky3, &ky4, h);
            a = ode_step_rk4(&a, &ka1, &ka2, &ka3, &ka4, h);
            t = t_prev;
        }

        // The adjoint gives dL/dalpha; compare to finite diff
        assert!(
            (grad_alpha_acc - fd_grad).abs() / fd_grad.abs() < 1e-4,
            "adjoint gradient {} should match finite diff {} (rel err = {})",
            grad_alpha_acc, fd_grad,
            (grad_alpha_acc - fd_grad).abs() / fd_grad.abs()
        );
    }

    #[test]
    fn test_adjoint_determinism() {
        let y_final = Tensor::from_vec_unchecked(vec![(-1.0_f64).exp()], &[1]);

        let run = || adjoint_solve(
            |_t, y| tensor_scale(y, -1.0),
            |_t, _y, a| (tensor_scale(a, 1.0), Tensor::from_vec_unchecked(vec![0.0], &[1])),
            &y_final,
            (0.0, 1.0),
            100,
        );

        let (y1, a1) = run();
        let (y2, a2) = run();
        assert_eq!(y1.to_vec(), y2.to_vec(), "adjoint_solve y0 must be bit-identical");
        assert_eq!(a1.to_vec(), a2.to_vec(), "adjoint_solve adjoint must be bit-identical");
    }
}