1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
//! NAT Type Identification and Traversal Analysis
//!
//! This module provides functionality to identify and analyze Network Address Translation (NAT)
//! configurations in network environments. It uses STUN servers to determine NAT behavior
//! and predict external address mappings for peer-to-peer connections.
//!
//! # Features
//!
//! - STUN-based NAT type detection (native only)
//! - Port and IP translation pattern analysis
//! - Predictive external address mapping
//! - IPv4 and IPv6 compatibility checks
//! - Multiple STUN server fallback support
//! - NAT traversal strategy determination

#[cfg(not(target_family = "wasm"))]
use crate::error::FirewallError;
use async_ip::IpAddressInfo;
use itertools::Itertools;
use serde::{Deserialize, Serialize};
use std::net::{IpAddr, SocketAddr};
use std::ops::Sub;

use crate::udp_traversal::hole_punch_config::AddrBand;

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub enum IpTranslation {
    /// The IP is the same
    Identity,
    /// The IP is translated, but, is invariant between outbound connections
    Constant { external: IpAddr },
    /// The IP is translated, and, is variant between outbound connections such that the NAT assigns
    /// an IP that is completely independent of the internal IP
    DeltaIndependentOffset {
        average_delta: i32,
        last_allocated_external_ip: IpAddr,
    },
    /// The IP is unpredictable
    #[default]
    Unpredictable,
}

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub enum PortTranslation {
    /// The port remains the same between internal:external mappings
    Identity,
    /// The port is translated by a constant delta between internal:external mappings
    DeltaConstantOffset { delta: i32 },
    /// The port is translated invariantly between internal:external mappings such that the NAT assigns
    /// a port that is completely independent of the internal port
    DeltaIndependentOffset {
        average_delta: i32,
        last_allocated_external_port: u16,
    },
    /// The port is unpredictable
    #[default]
    Unpredictable,
}

#[derive(Debug, Clone, Serialize, Deserialize, Default)]
pub struct NatType {
    pub ip_translation: IpTranslation,
    pub port_translation: PortTranslation,
    pub ip_info: Option<IpAddressInfo>,
    pub is_ipv6_enabled: bool,
}

impl NatType {
    pub fn offline() -> Self {
        Self {
            ip_translation: IpTranslation::Identity,
            port_translation: PortTranslation::Identity,
            ip_info: Some(IpAddressInfo::localhost()),
            is_ipv6_enabled: false,
        }
    }
}

pub struct SocketPair {
    pub internal: SocketAddr,
    pub external: SocketAddr,
}

pub const MAX_OCTET_DELTA: i32 = 5;

// Platform-appropriate IPv6 check
#[cfg(not(target_family = "wasm"))]
fn check_ipv6_enabled() -> bool {
    crate::socket_helpers::is_ipv6_enabled()
}

#[cfg(target_family = "wasm")]
fn check_ipv6_enabled() -> bool {
    false
}

impl NatType {
    /// Constructs a NatType from 3 socket pair observations. Pure math — no I/O.
    pub fn new(addr0: SocketPair, addr1: SocketPair, addr2: SocketPair) -> Self {
        let ip_translation = Self::get_ip_translation(&addr0, &addr1, &addr2);
        let port_translation = Self::get_port_translation(&addr0, &addr1, &addr2);
        Self {
            ip_translation,
            port_translation,
            ip_info: None,
            is_ipv6_enabled: check_ipv6_enabled(),
        }
    }

    /// Given a local socket address, predicts the external addresses. Returns None if unpredictable.
    /// Pure math — no I/O.
    pub(crate) fn predict(&self, internal_addr: &SocketAddr) -> Option<Vec<AddrBand>> {
        let mut bands = Vec::new();
        let internal_port = internal_addr.port();

        // These anticipated ports will be used for all ip translations
        let anticipated_ports = match self.port_translation {
            PortTranslation::Identity => vec![internal_port],
            PortTranslation::DeltaConstantOffset { delta } => {
                vec![Self::wrapping_port_add(internal_port, delta)]
            }
            PortTranslation::DeltaIndependentOffset {
                average_delta,
                last_allocated_external_port,
            } => {
                let mut ports = Vec::new();
                for i in average_delta..=(3 * average_delta) {
                    ports.push(Self::wrapping_port_add(last_allocated_external_port, i));
                }
                ports
            }
            PortTranslation::Unpredictable => return None,
        };

        // add the base IPs
        match self.ip_translation {
            IpTranslation::Identity => {
                let band = AddrBand {
                    necessary_ip: internal_addr.ip(),
                    anticipated_ports: anticipated_ports.clone(),
                };
                bands.push(band);
            }
            IpTranslation::Constant { external } => {
                let band = AddrBand {
                    necessary_ip: external,
                    anticipated_ports: anticipated_ports.clone(),
                };
                bands.push(band);
            }
            IpTranslation::DeltaIndependentOffset {
                average_delta,
                last_allocated_external_ip,
            } => {
                for i in average_delta..=(3 * average_delta) {
                    let next_ip = match last_allocated_external_ip {
                        IpAddr::V4(ip) => {
                            let mut octets = ip.octets();
                            octets[3] = octets[3].wrapping_add(i as u8);
                            IpAddr::from(octets)
                        }
                        IpAddr::V6(ip) => {
                            let mut octets = ip.octets();
                            octets[15] = octets[15].wrapping_add(i as u8);
                            IpAddr::from(octets)
                        }
                    };

                    let band = AddrBand {
                        necessary_ip: next_ip,
                        anticipated_ports: anticipated_ports.clone(),
                    };

                    bands.push(band);
                }
            }
            IpTranslation::Unpredictable => return None,
        }

        // finally, add the ipv6 band (if we have it)
        if let Some(ip_info) = &self.ip_info {
            if let Some(ext_ip) = &ip_info.external_ipv6 {
                let band = AddrBand {
                    necessary_ip: *ext_ip,
                    anticipated_ports: anticipated_ports.clone(),
                };
                bands.push(band);
            }

            // now, add the internal IP (potentially)
            if bands.iter().all(|r| r.necessary_ip != ip_info.internal_ip) {
                let band = AddrBand {
                    necessary_ip: ip_info.internal_ip,
                    anticipated_ports,
                };
                bands.push(band);
            }
        }

        // final case: nodes are on localhost
        // now, add the internal IP (potentially)
        if bands.iter().all(|r| {
            r.necessary_ip != internal_addr.ip() && !r.anticipated_ports.contains(&internal_port)
        }) {
            let band = AddrBand {
                necessary_ip: internal_addr.ip(),
                anticipated_ports: vec![internal_port],
            };
            bands.push(band);
        }

        Some(bands)
    }

    /// Given 3 socket addresses, determine the IP translation. Pure math.
    fn get_ip_translation(
        addr0: &SocketPair,
        addr1: &SocketPair,
        addr2: &SocketPair,
    ) -> IpTranslation {
        let ip0_internal = addr0.internal.ip();
        let ip0_external = addr0.external.ip();
        let ip1_internal = addr1.internal.ip();
        let ip1_external = addr1.external.ip();
        let ip2_internal = addr2.internal.ip();
        let ip2_external = addr2.external.ip();

        if ip0_internal == ip0_external
            && ip1_internal == ip1_external
            && ip2_internal == ip2_external
        {
            return IpTranslation::Identity;
        }

        if ip0_external == ip1_external && ip1_external == ip2_external {
            return IpTranslation::Constant {
                external: ip0_external,
            };
        }

        let last_octet_external0 = Self::last_octet(&ip0_external);
        let last_octet_external1 = Self::last_octet(&ip1_external);
        let last_octet_external2 = Self::last_octet(&ip2_external);

        let last_external_octets = &[
            last_octet_external0,
            last_octet_external1,
            last_octet_external2,
        ];
        let average_delta = average_delta(last_external_octets);
        if average_delta <= MAX_OCTET_DELTA as usize {
            let highest = *last_external_octets.iter().max().unwrap();

            let last_allocated_external_ip = if last_external_octets[0] == highest {
                ip0_external
            } else if last_external_octets[1] == highest {
                ip1_external
            } else {
                ip2_external
            };

            return IpTranslation::DeltaIndependentOffset {
                average_delta: average_delta as _,
                last_allocated_external_ip,
            };
        }

        IpTranslation::Unpredictable
    }

    fn get_port_translation(
        addr0: &SocketPair,
        addr1: &SocketPair,
        addr2: &SocketPair,
    ) -> PortTranslation {
        let port0_internal = addr0.internal.port();
        let port0_external = addr0.external.port();
        let port1_internal = addr1.internal.port();
        let port1_external = addr1.external.port();
        let port2_internal = addr2.internal.port();
        let port2_external = addr2.external.port();

        if port0_internal == port0_external
            && port1_internal == port1_external
            && port2_internal == port2_external
        {
            return PortTranslation::Identity;
        }

        let port0_delta = port0_external as i32 - port0_internal as i32;
        let port1_delta = port1_external as i32 - port1_internal as i32;
        let port2_delta = port2_external as i32 - port2_internal as i32;

        if port0_delta == port1_delta && port1_delta == port2_delta {
            return PortTranslation::DeltaConstantOffset { delta: port0_delta };
        }

        let port_external_octets = &[port0_external, port1_external, port2_external];

        let average_delta = average_delta(port_external_octets);
        if average_delta <= MAX_OCTET_DELTA as usize {
            let highest = *port_external_octets.iter().max().unwrap();

            let last_allocated_external_port = if port_external_octets[0] == highest {
                port0_external
            } else if port_external_octets[1] == highest {
                port1_external
            } else {
                port2_external
            };

            return PortTranslation::DeltaIndependentOffset {
                average_delta: average_delta as _,
                last_allocated_external_port,
            };
        }

        PortTranslation::Unpredictable
    }

    fn last_octet(ip: &IpAddr) -> u8 {
        match ip {
            IpAddr::V4(ip) => ip.octets()[3],
            IpAddr::V6(ip) => ip.octets()[15],
        }
    }

    fn wrapping_port_add(port: u16, delta: i32) -> u16 {
        let mut new_port = port.wrapping_add(delta as u16);
        if new_port < 1024 {
            new_port += 1024
        }

        new_port
    }
}

#[derive(Debug, Clone, Eq, PartialEq, Hash, Ord, PartialOrd, Serialize, Deserialize)]
pub enum TraversalTypeRequired {
    /// Use the linear hole punch subroutines in this crate
    Direct,
    /// direct p2p not possible
    TURN,
}

impl NatType {
    /// Returns the NAT traversal type required to access self and other, respectively
    pub fn traversal_type_required_with(
        &self,
        other: &NatType,
    ) -> (TraversalTypeRequired, TraversalTypeRequired) {
        let this = self.traversal_type_required();
        let other = other.traversal_type_required();
        (this, other)
    }

    pub fn traversal_type_required(&self) -> TraversalTypeRequired {
        if matches!(self.ip_translation, IpTranslation::Unpredictable)
            || matches!(self.port_translation, PortTranslation::Unpredictable)
        {
            TraversalTypeRequired::TURN
        } else {
            TraversalTypeRequired::Direct
        }
    }

    /// If either of the method required to reach the endpoints don't require TURN, then the connection will work since at least one of the addrs is predictable
    pub fn stun_compatible(&self, other_nat: &NatType) -> bool {
        let (this, other) = self.traversal_type_required_with(other_nat);
        this != TraversalTypeRequired::TURN || other != TraversalTypeRequired::TURN
    }

    pub fn ip_addr_info(&self) -> Option<&IpAddressInfo> {
        self.ip_info.as_ref()
    }

    pub fn is_ipv6_compatible(&self) -> bool {
        self.is_ipv6_enabled
    }
}

fn average_delta<T: Ord + Copy + Sized + Sub>(vals: impl AsRef<[T]>) -> usize
where
    usize: From<<T as Sub>::Output>,
{
    let vals = vals.as_ref().iter().copied().sorted().collect::<Vec<T>>();

    if vals.is_empty() {
        return 0;
    }

    let count = vals.len() as f32;

    let sum_diff: usize = vals
        .into_iter()
        .tuple_windows()
        .map(|(a, b)| usize::from(b - a))
        .sum();
    let average = sum_diff as f32 / (count - 1f32);
    average.abs() as usize
}

#[cfg(not(target_family = "wasm"))]
mod native {
    use super::*;
    use citadel_io::tokio::net::UdpSocket;
    use futures::stream::FuturesUnordered;
    use futures::StreamExt;
    use std::borrow::Cow;
    use std::sync::Arc;
    use std::time::Duration;
    use stun::client::ClientBuilder;
    use stun::message::{Getter, Message, BINDING_REQUEST};
    use stun::xoraddr::XorMappedAddress;

    const STUN_SERVERS: [&str; 3] = [
        "global.stun.twilio.com:3478",
        "stun1.l.google.com:19302",
        "stun4.l.google.com:19302",
    ];

    const V4_BIND_ADDR: &str = "0.0.0.0:0";
    pub const IDENTIFY_TIMEOUT: Duration = Duration::from_millis(3000);

    static LOCALHOST_TESTING_NAT_TYPE: citadel_io::Mutex<Option<NatType>> =
        citadel_io::Mutex::new(None);

    impl NatType {
        /// Identifies the NAT which the local node is behind. Timeout at the default (5s)
        #[cfg_attr(
            feature = "localhost-testing",
            tracing::instrument(level = "trace", target = "citadel", skip_all, ret, err(Debug))
        )]
        pub async fn identify(stun_servers: Option<Vec<String>>) -> Result<Self, FirewallError> {
            if cfg!(feature = "localhost-testing") {
                log::trace!(target: "citadel", "Localhost testing enabled, skipping STUN and using localhost NatType");
                return Ok(NatType::offline());
            }

            match Self::identify_timeout(IDENTIFY_TIMEOUT, stun_servers).await {
                Ok(nat_type) => Ok(nat_type),
                Err(err) => {
                    log::warn!(target: "citadel", "Unable to identify NAT type (will assume offline): {err:?}");
                    Ok(NatType::offline())
                }
            }
        }

        /// Identifies the NAT which the local node is behind
        pub async fn identify_timeout(
            _timeout: Duration,
            stun_servers: Option<Vec<String>>,
        ) -> Result<Self, FirewallError> {
            match citadel_io::time::timeout(_timeout, get_nat_type(stun_servers)).await {
                Ok(res) => res
                    .map_err(|err| FirewallError::firewall_hole_punch(err.to_string()))
                    .inspect(|nat_type| {
                        *LOCALHOST_TESTING_NAT_TYPE.lock() = Some(nat_type.clone());
                    }),

                Err(_elapsed) => Err(citadel_io::error!(
                    citadel_io::ErrorCode::FirewallNatIdentTimeout
                )),
            }
        }

        /// STUN-probes the *actual* hole-punch socket to learn its server-reflexive
        /// (external) address — the exact mapping the remote peer will target.
        ///
        /// Unlike [`NatType::identify`], which models the NAT from throwaway sockets and
        /// then *predicts* an external address, this observes the real mapping. That makes
        /// traversal succeed for endpoint-independent NATs that do not preserve the port
        /// (where prediction is impossible). The socket is probed un-connected, so it stays
        /// usable for the subsequent hole-punch barrage.
        ///
        /// Returns `None` when no server answers — the caller then relies solely on the
        /// predicted bands, preserving prior behavior. IPv6 sockets are skipped: IPv6 is
        /// typically un-NATed and is already covered by the `ip_info`-derived band.
        ///
        /// The caller decides *when* to probe (the hole-punch driver skips this under
        /// `localhost-testing`, where there are no real STUN servers); this function itself
        /// probes unconditionally so it stays unit-testable against a local STUN responder.
        pub async fn get_reflexive_addr(
            socket: &UdpSocket,
            stun_servers: Option<&[String]>,
        ) -> Option<SocketAddr> {
            // The probe socket is IPv4; an IPv6 socket cannot reach the IPv4 STUN servers.
            if !socket.local_addr().ok()?.is_ipv4() {
                return None;
            }

            let owned_default;
            let servers: &[String] = match stun_servers {
                Some(servers) if !servers.is_empty() => servers,
                _ => {
                    owned_default = STUN_SERVERS
                        .iter()
                        .map(|s| s.to_string())
                        .collect::<Vec<_>>();
                    &owned_default
                }
            };

            for server in servers {
                if let Some(addr) = stun_probe_socket(socket, server).await {
                    return Some(addr);
                }
            }

            None
        }
    }

    /// Sends a single STUN BINDING request from `socket` to `server` and returns the
    /// observed XOR-mapped (external) address. IPv4 only; bounded by a short timeout.
    async fn stun_probe_socket(socket: &UdpSocket, server: &str) -> Option<SocketAddr> {
        // Resolve to an IPv4 endpoint (the probe socket is IPv4).
        let server_addr = citadel_io::tokio::net::lookup_host(server)
            .await
            .ok()?
            .find(SocketAddr::is_ipv4)?;

        let mut request = Message::new();
        request
            .build(&[
                Box::<stun::agent::TransactionId>::default(),
                Box::new(BINDING_REQUEST),
            ])
            .ok()?;
        let transaction_id = request.transaction_id;

        socket.send_to(&request.raw, server_addr).await.ok()?;

        let recv = async {
            let mut buf = [0u8; 256];
            loop {
                let (len, from) = socket.recv_from(&mut buf).await.ok()?;
                if from != server_addr {
                    // Not the STUN server (e.g. a stray/early hole-punch packet); ignore.
                    continue;
                }

                let mut response = Message::new();
                response.raw = buf[..len].to_vec();
                if response.decode().is_err() || response.transaction_id != transaction_id {
                    continue;
                }

                let mut xor_addr = XorMappedAddress::default();
                if xor_addr.get_from(&response).is_err() {
                    continue;
                }

                return Some(SocketAddr::new(xor_addr.ip, xor_addr.port));
            }
        };

        citadel_io::time::timeout(Duration::from_millis(1500), recv)
            .await
            .ok()
            .flatten()
    }

    #[cfg_attr(
        feature = "localhost-testing",
        tracing::instrument(level = "trace", target = "citadel", skip_all, ret, err(Debug))
    )]
    async fn get_nat_type(stun_servers: Option<Vec<String>>) -> Result<NatType, anyhow::Error> {
        let stun_servers = if let Some(stun_servers) = &stun_servers {
            Cow::Owned(stun_servers.iter().map(|r| r.as_str()).collect())
        } else {
            Cow::Borrowed(&STUN_SERVERS as &[&str])
        };

        let nat_type = async move {
            let mut msg = Message::new();
            msg.build(&[
                Box::<stun::agent::TransactionId>::default(),
                Box::new(BINDING_REQUEST),
            ])?;

            let msg = &msg;

            let futures_unordered = FuturesUnordered::new();

            for server in stun_servers.iter() {
                let task = async move {
                    let udp_sck = UdpSocket::bind(V4_BIND_ADDR).await?;
                    let new_bind_addr = udp_sck.local_addr()?;
                    udp_sck.connect(server).await?;
                    let (handler_tx, mut handler_rx) =
                        citadel_io::tokio::sync::mpsc::unbounded_channel();
                    log::trace!(target: "citadel", "Connected to STUN server {server:?}");
                    let mut client = ClientBuilder::new().with_conn(Arc::new(udp_sck)).build()?;

                    client.send(msg, Some(Arc::new(handler_tx))).await?;

                    if let Some(event) = handler_rx.recv().await {
                        match event.event_body {
                            Ok(msg) => {
                                let mut xor_addr = XorMappedAddress::default();
                                xor_addr.get_from(&msg)?;
                                let natted_addr = SocketAddr::new(xor_addr.ip, xor_addr.port);

                                log::trace!(target: "citadel", "External ADDR: {natted_addr:?} | internal: {new_bind_addr:?}");

                                return Ok(Some((natted_addr, new_bind_addr)));
                            }
                            Err(err) => log::trace!(target: "citadel", "{err:?}"),
                        };
                    }

                    Ok(None)
                };

                futures_unordered.push(Box::pin(task));
            }

            let mut results = futures_unordered
                .collect::<Vec<Result<Option<(SocketAddr, SocketAddr)>, anyhow::Error>>>()
                .await;
            let first_natted_addr = results
                .pop()
                .ok_or_else(|| anyhow::Error::msg("First result not present"))??;
            let second_natted_addr = results
                .pop()
                .ok_or_else(|| anyhow::Error::msg("Second result not present"))??;
            let third_natted_addr = results
                .pop()
                .ok_or_else(|| anyhow::Error::msg("Third result not present"))??;

            match (first_natted_addr, second_natted_addr, third_natted_addr) {
                (
                    Some((addr_ext, addr_int)),
                    Some((addr2_ext, addr2_int)),
                    Some((addr3_ext, addr3_int)),
                ) => {
                    let pair0 = SocketPair {
                        internal: addr_int,
                        external: addr_ext,
                    };
                    let pair1 = SocketPair {
                        internal: addr2_int,
                        external: addr2_ext,
                    };
                    let pair2 = SocketPair {
                        internal: addr3_int,
                        external: addr3_ext,
                    };

                    let nat_type = NatType::new(pair0, pair1, pair2);
                    log::trace!(target: "citadel", "NAT type: {nat_type:?}");

                    Ok(nat_type)
                }

                _ => Err(anyhow::Error::msg("Unable to get all three STUN addrs")),
            }
        };

        let ip_info_future = async move {
            match citadel_io::time::timeout(
                Duration::from_millis(2000),
                async_ip::get_all_multi_concurrent(None),
            )
            .await
            {
                Ok(Ok(ip_info)) => Ok(Some(ip_info)),
                Ok(Err(err)) => Err(err),
                Err(_) => Ok(None),
            }
        };

        let (nat_type, ip_info) = citadel_io::tokio::join!(nat_type, ip_info_future);
        let mut nat_type = nat_type?;

        let ip_info = match ip_info {
            Ok(Some(ip_info)) => ip_info,
            Ok(None) => {
                log::warn!(target: "citadel", "Unable to get IP info. Defaulting to localhost");
                IpAddressInfo::localhost()
            }
            Err(err) => {
                log::warn!(target: "citadel", "Unable to get IP info: {err:?}");
                IpAddressInfo::localhost()
            }
        };

        nat_type.ip_info = Some(ip_info);

        log::info!(target: "citadel", "NAT Type: {nat_type:?}");

        Ok(nat_type)
    }
}

#[cfg(not(target_family = "wasm"))]
pub use native::IDENTIFY_TIMEOUT;

#[cfg(test)]
mod tests {
    use crate::nat_identification::{
        IpTranslation, NatType, PortTranslation, SocketPair, MAX_OCTET_DELTA,
    };
    use crate::udp_traversal::hole_punch_config::AddrBand;
    use citadel_io::tokio;
    use std::net::{IpAddr, SocketAddr};
    use std::str::FromStr;

    #[tokio::test]
    async fn test_identify() {
        citadel_logging::setup_log();
        let nat_type = NatType::identify(None).await.unwrap();
        let traversal_type = nat_type.traversal_type_required();
        log::trace!(target: "citadel", "NAT Type: {nat_type:?} | Reaching this node will require: {traversal_type:?} NAT traversal | Hypothetical connect scenario");
    }

    /// Exercises `get_reflexive_addr` (and `stun_probe_socket`) end-to-end against a local
    /// fake STUN responder over loopback — no real network — so the observe-the-real-mapping
    /// path is covered even though the hole-punch driver gates it off under localhost-testing.
    #[cfg(not(target_family = "wasm"))]
    #[tokio::test]
    async fn get_reflexive_addr_parses_local_stun_response() {
        use citadel_io::tokio::net::UdpSocket;
        use stun::message::{Message, BINDING_SUCCESS};
        use stun::xoraddr::XorMappedAddress;

        // The external address the fake STUN server will report back.
        let mapped = SocketAddr::from_str("203.0.113.9:51234").unwrap();

        // Fake STUN server: echoes the request's transaction id in a BINDING_SUCCESS carrying
        // an XOR-MAPPED-ADDRESS. `build()` clears attributes but preserves `transaction_id`,
        // and `XorMappedAddress` encodes against it, so the client can match and decode.
        let server = UdpSocket::bind("127.0.0.1:0").await.unwrap();
        let server_addr = server.local_addr().unwrap();
        let server_task = citadel_io::tokio::task::spawn(async move {
            let mut buf = [0u8; 256];
            let (len, from) = server.recv_from(&mut buf).await.unwrap();
            let mut request = Message::new();
            request.raw = buf[..len].to_vec();
            request.decode().unwrap();

            let mut response = Message::new();
            response.transaction_id = request.transaction_id;
            response
                .build(&[
                    Box::new(BINDING_SUCCESS),
                    Box::new(XorMappedAddress {
                        ip: mapped.ip(),
                        port: mapped.port(),
                    }),
                ])
                .unwrap();
            server.send_to(&response.raw, from).await.unwrap();
        });

        let client = UdpSocket::bind("127.0.0.1:0").await.unwrap();
        let observed = NatType::get_reflexive_addr(&client, Some(&[server_addr.to_string()])).await;
        server_task.await.unwrap();

        assert_eq!(
            observed,
            Some(mapped),
            "reflexive addr must match the STUN-reported mapping"
        );
    }

    /// An IPv6 probe socket is skipped (cannot reach the IPv4 STUN servers) and returns None
    /// without any network I/O.
    #[cfg(not(target_family = "wasm"))]
    #[tokio::test]
    async fn get_reflexive_addr_skips_ipv6_socket() {
        let socket = citadel_io::tokio::net::UdpSocket::bind("[::1]:0")
            .await
            .unwrap();
        let observed =
            NatType::get_reflexive_addr(&socket, Some(&["127.0.0.1:3478".to_string()])).await;
        assert_eq!(observed, None);
    }

    #[test]
    fn test_addr_translation_identification_identity_to_identity() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::Identity
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![AddrBand {
                necessary_ip: internal_addr.ip(),
                anticipated_ports: vec![30000]
            }]
        );
    }

    #[test]
    fn test_addr_translation_identification_identity_to_delta_constant_offset() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:10010").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:20010").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:30010").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::DeltaConstantOffset { delta: 10 }
        ));
        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![AddrBand {
                necessary_ip: internal_addr.ip(),
                anticipated_ports: vec![30010]
            }]
        );
    }

    #[test]
    // below the limit
    fn test_addr_translation_identification_identity_to_delta_independent_offset0() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:50000").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:50001").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:50002").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        let _average_delta = 1;
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::DeltaIndependentOffset {
                average_delta: _average_delta,
                last_allocated_external_port: 50002
            }
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![AddrBand {
                necessary_ip: internal_addr.ip(),
                anticipated_ports: vec![50003, 50004, 50005]
            }]
        );
    }

    #[test]
    // at the limit
    fn test_addr_translation_identification_identity_to_delta_independent_offset1() {
        let mappings = [
            50000,
            50000 + MAX_OCTET_DELTA as u16,
            50000 + 2 * MAX_OCTET_DELTA as u16,
        ];

        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[0])).unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[1])).unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[2])).unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        let _last_allocated_external_port = mappings[2];
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::DeltaIndependentOffset {
                average_delta: MAX_OCTET_DELTA,
                last_allocated_external_port: _last_allocated_external_port
            }
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![AddrBand {
                necessary_ip: internal_addr.ip(),
                anticipated_ports: (50015u16..=50025u16).collect()
            }]
        );
    }

    #[test]
    // above the limit
    fn test_addr_translation_identification_identity_to_delta_independent_offset2() {
        let mappings = [
            50000,
            50000 + 1u16 + MAX_OCTET_DELTA as u16,
            50000 + 2u16 + 2 * MAX_OCTET_DELTA as u16,
        ];

        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[0])).unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[1])).unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str(&format!("192.168.2.1:{}", mappings[2])).unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        let _last_allocated_external_port = mappings[2];
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::Unpredictable
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr);
        assert!(predicted_addrs.is_none());
    }

    #[test]
    fn test_addr_translation_identification_identity_to_unpredictable() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:10001").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:10500").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("192.168.2.1:16000").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        assert!(matches!(nat_type.ip_translation, IpTranslation::Identity));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::Unpredictable
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:10000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr);
        assert!(predicted_addrs.is_none());
    }

    #[test]
    fn test_addr_translation_identification_constant_to_identity() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("10.1.10.1:10000").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("10.1.10.1:20000").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("10.1.10.1:30000").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        let _external = IpAddr::from_str("10.1.10.1").unwrap();
        assert!(matches!(
            nat_type.ip_translation,
            IpTranslation::Constant {
                external: _external
            }
        ));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::Identity
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![AddrBand {
                necessary_ip: IpAddr::from_str("10.1.10.1").unwrap(),
                anticipated_ports: vec![30000]
            }]
        );
    }

    #[test]
    fn test_addr_translation_identification_delta_offset_to_identity() {
        let addr0 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:10000").unwrap(),
            external: SocketAddr::from_str("10.1.10.100:10000").unwrap(),
        };

        let addr1 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:20000").unwrap(),
            external: SocketAddr::from_str("10.1.10.101:20000").unwrap(),
        };

        let addr2 = SocketPair {
            internal: SocketAddr::from_str("192.168.2.1:30000").unwrap(),
            external: SocketAddr::from_str("10.1.10.102:30000").unwrap(),
        };

        let nat_type = NatType::new(addr0, addr1, addr2);
        let _last_allocated_external_ip = IpAddr::from_str("10.1.10.102").unwrap();
        assert!(matches!(
            nat_type.ip_translation,
            IpTranslation::DeltaIndependentOffset {
                average_delta: 1,
                last_allocated_external_ip: _last_allocated_external_ip
            }
        ));
        assert!(matches!(
            nat_type.port_translation,
            PortTranslation::Identity
        ));

        let internal_addr = SocketAddr::from_str("192.168.2.1:30000").unwrap();
        let predicted_addrs = nat_type.predict(&internal_addr).unwrap();
        assert_eq!(
            predicted_addrs,
            vec![
                AddrBand {
                    necessary_ip: IpAddr::from_str("10.1.10.103").unwrap(),
                    anticipated_ports: vec![30000]
                },
                AddrBand {
                    necessary_ip: IpAddr::from_str("10.1.10.104").unwrap(),
                    anticipated_ports: vec![30000],
                },
                AddrBand {
                    necessary_ip: IpAddr::from_str("10.1.10.105").unwrap(),
                    anticipated_ports: vec![30000],
                },
            ]
        );
    }
}

#[cfg(test)]
mod predicate_tests {
    use super::{IpTranslation, NatType, PortTranslation, TraversalTypeRequired};

    #[test]
    fn traversal_and_stun_predicates() {
        // Identity/Identity NAT is directly reachable.
        let direct = NatType::offline();
        assert_eq!(
            direct.traversal_type_required(),
            TraversalTypeRequired::Direct
        );
        assert!(direct.ip_addr_info().is_some());
        assert!(!direct.is_ipv6_compatible());

        // Unpredictable translation forces TURN.
        let turn = NatType {
            ip_translation: IpTranslation::Unpredictable,
            port_translation: PortTranslation::Unpredictable,
            ip_info: None,
            is_ipv6_enabled: true,
        };
        assert_eq!(turn.traversal_type_required(), TraversalTypeRequired::TURN);
        assert!(turn.ip_addr_info().is_none());
        assert!(turn.is_ipv6_compatible());

        // STUN works as long as at least one side is predictable.
        assert!(direct.stun_compatible(&direct));
        assert!(direct.stun_compatible(&turn));
        assert!(!turn.stun_compatible(&turn));

        let (a, b) = direct.traversal_type_required_with(&turn);
        assert_eq!(a, TraversalTypeRequired::Direct);
        assert_eq!(b, TraversalTypeRequired::TURN);
    }
}