citadel_crypt 0.13.0

Higher-level cryptographic library for the Citadel Protocol
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
use crate::misc::CryptError;
use crate::ordered_channel::OrderedChannel;
use crate::ratchets::ratchet_manager::{AttachedPayload, DefaultRatchetManager, RatchetMessage};
use crate::ratchets::Ratchet;
use citadel_io::tokio;
use citadel_types::prelude::SecrecyMode;
use futures::{SinkExt, Stream};
use serde::{Deserialize, Serialize};
use std::collections::VecDeque;
use std::pin::Pin;
use std::sync::atomic::AtomicBool;
use std::sync::Arc;
use std::task::{Context, Poll};
use tokio::sync::mpsc::UnboundedReceiver;

/// A messenger intended for use by the citadel_proto package for two nodes to use
/// for messaging. It enforces the secrecy mode such that:
/// [*] True Perfect Forward Secrecy: A message can only be sent if a new key is
/// ready for use. This uses head-of-line blocking, placing any messages into the queue
/// until a rekey is complete. This is best for pure messaging applications.
/// [*] Best effort mode: Messages will attempt to use an unused key, but, will re-use the
/// same key in order to not block. This is best for high-throughput applications.
///
/// This pattern bypasses the kernel executor for direct writing and reading from the
/// underlying stream at the application-layer
pub struct RatchetManagerMessengerLayer<E: Send + Sync + 'static, R: Ratchet, P: AttachedPayload> {
    sink: RatchetManagerMessengerLayerTx<E, R, P>,
    stream: RatchetManagerMessengerLayerRx<E, R, P>,
}

pub struct RatchetManagerMessengerLayerTx<E: Send + Sync + 'static, R: Ratchet, P: AttachedPayload>
{
    manager: DefaultRatchetManager<E, R, MessengerLayerOrderedMessage<P>>,
    is_active: Arc<AtomicBool>,
    secrecy_mode: SecrecyMode,
    enqueued_messages: Arc<tokio::sync::Mutex<VecDeque<MessengerLayerOrderedMessage<P>>>>,
    message_id: u64,
}

pub struct RatchetManagerMessengerLayerRx<E: Send + Sync + 'static, R: Ratchet, P: AttachedPayload>
{
    manager: DefaultRatchetManager<E, R, MessengerLayerOrderedMessage<P>>,
    rx: UnboundedReceiver<P>,
    is_active: Arc<AtomicBool>,
}

const ORDERING: std::sync::atomic::Ordering = std::sync::atomic::Ordering::Relaxed;

impl<E, R, P> RatchetManagerMessengerLayer<E, R, P>
where
    E: Send + Sync + 'static,
    R: Ratchet,
    P: AttachedPayload,
{
    pub fn new(
        manager: DefaultRatchetManager<E, R, MessengerLayerOrderedMessage<P>>,
        secrecy_mode: SecrecyMode,
        rekey_finished_tx: Option<tokio::sync::mpsc::UnboundedSender<R>>,
        is_active: Arc<AtomicBool>,
    ) -> Self {
        // The rx below will receive all messages that get sent via the ratchet manager layer
        // Some messages will "catch a ride" alongside a re-keying packet, others will be
        // standalone. This is not Pandora.
        let mut payload_rx = manager
            .take_payload_rx()
            .expect("Cannot pass a RatchetManager that has no payload receiver!");
        let mut on_rekey_finish_listener = manager
            .take_on_rekey_finished_event_listener()
            .expect("Cannot pass a RatchetManager that has no on_rekey listener!");
        let manager_clone = manager.clone();
        let is_active_bg = is_active.clone();
        let cid = manager.session_crypto_state.cid();
        let enqueued_messages = Arc::new(tokio::sync::Mutex::new(VecDeque::new()));
        let enqueued_messages_clone = enqueued_messages.clone();

        let (tx, rx) = tokio::sync::mpsc::unbounded_channel();

        let background_task = async move {
            // Each time a rekey finishes, we should check the local queue for any enqueued messages
            // to poll and send
            let rekey_task = async move {
                while let Some(next_ratchet) = on_rekey_finish_listener.recv().await {
                    if let Some(notify_on_finish_tx) = rekey_finished_tx.as_ref() {
                        if let Err(err) = notify_on_finish_tx.send(next_ratchet) {
                            log::warn!(target: "citadel", "Failed to notify on rekey finish: {err}");
                        }
                    }

                    // Check the latest item in the queue. Hold the lock to prevent race conditions locally
                    let mut lock = enqueued_messages_clone.lock().await;
                    log::trace!(target: "citadel", "RatchetManagerMessengerLayer (client: {cid}, mode: {secrecy_mode:?}): re-key finished. Queue size: {}", lock.len());
                    if let Some(last_item) = lock.pop_front() {
                        match manager_clone
                            .trigger_rekey_with_payload(Some(last_item), false)
                            .await
                        {
                            Ok(Some(message_not_sent)) => {
                                log::trace!(target: "citadel", "RatchetManagerMessengerLayer (client: {cid}, mode: {secrecy_mode:?}): NOT READY. Queue size: {}", lock.len());
                                lock.push_front(message_not_sent);
                            }

                            Ok(None) => {
                                // Successfully sent
                            }

                            Err(err) => {
                                log::error!(target: "citadel", "RatchetManager failed to trigger rekey: {err:?}");
                                break;
                            }
                        }
                    }
                }
            };

            let mut ordered_channel = OrderedChannel::new(tx);

            let ordered_receiver = async move {
                while let Some(message) = payload_rx.recv().await {
                    let id = message.id;
                    if let Err(err) = ordered_channel.on_packet_received(id, message.message) {
                        log::error!(target: "citadel", "RatchetManagerMessengerLayer (client: {cid}, mode: {secrecy_mode:?}): Failed to send message: {err:?}");
                        break;
                    }
                }
            };

            tokio::select! {
                _ = rekey_task => {}
                _ = ordered_receiver => {}
            }

            log::warn!(target: "citadel", "RatchetManagerMessengerLayer (client: {cid}, mode: {secrecy_mode:?}): background task ending");
            is_active_bg.store(false, ORDERING);
        };

        drop(tokio::task::spawn(background_task));

        Self {
            sink: RatchetManagerMessengerLayerTx {
                manager: manager.clone(),
                is_active: is_active.clone(),
                secrecy_mode,
                enqueued_messages,
                message_id: 0,
            },
            stream: RatchetManagerMessengerLayerRx {
                rx,
                is_active,
                manager,
            },
        }
    }

    pub fn split(
        self,
    ) -> (
        RatchetManagerMessengerLayerTx<E, R, P>,
        RatchetManagerMessengerLayerRx<E, R, P>,
    ) {
        (self.sink, self.stream)
    }
}

#[derive(Serialize, Deserialize)]
pub struct MessengerLayerOrderedMessage<P> {
    id: u64,
    pub message: P,
}

impl<E, R, P> RatchetManagerMessengerLayerTx<E, R, P>
where
    E: Send + Sync + 'static,
    R: Ratchet,
    P: AttachedPayload,
{
    pub async fn send(&mut self, message: impl Into<P>) -> Result<(), CryptError> {
        if !self.is_active.load(ORDERING) {
            return Err(CryptError::Encrypt(
                "Cannot send encrypted messages (stream died)".to_string(),
            ));
        }

        let message = MessengerLayerOrderedMessage {
            id: self.get_and_increment_message_id(),
            message: message.into(),
        };

        match self.secrecy_mode {
            SecrecyMode::BestEffort => {
                if let Some(message_not_sent) = self
                    .manager
                    .trigger_rekey_with_payload(Some(message), false)
                    .await?
                {
                    // Just send through channel
                    self.manager
                        .sender
                        .lock()
                        .await
                        .send(RatchetMessage::JustMessage(message_not_sent))
                        .await
                        .map_err(|_| {
                            CryptError::FatalError("Ratchet Manager's outbound stream died".into())
                        })
                } else {
                    // Success; this message will trigger a simultaneous rekey
                    Ok(())
                }
            }

            SecrecyMode::Perfect => {
                if let Some(message_not_sent) = self
                    .manager
                    .trigger_rekey_with_payload(Some(message), false)
                    .await?
                {
                    // We need to enqueue
                    self.enqueued_messages
                        .lock()
                        .await
                        .push_back(message_not_sent);
                } else {
                    // Success; this message will trigger a simultaneous rekey w/o enqueuing
                }

                Ok(())
            }
        }
    }

    fn get_and_increment_message_id(&mut self) -> u64 {
        let id = self.message_id;
        self.message_id += 1;
        id
    }
}

impl<E, R, P> Stream for RatchetManagerMessengerLayerRx<E, R, P>
where
    E: Send + Sync + 'static,
    R: Ratchet,
    P: AttachedPayload,
{
    type Item = P;

    fn poll_next(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Option<Self::Item>> {
        let this = self.get_mut();
        if !this.is_active.load(ORDERING) {
            return Poll::Ready(None);
        }

        this.rx.poll_recv(cx)
    }
}

impl<E, R, P> Drop for RatchetManagerMessengerLayerTx<E, R, P>
where
    E: Send + Sync + 'static,
    R: Ratchet,
    P: AttachedPayload,
{
    fn drop(&mut self) {
        self.is_active.store(false, ORDERING);
        let _ = self.manager.shutdown();
    }
}

impl<E, R, P> Drop for RatchetManagerMessengerLayerRx<E, R, P>
where
    E: Send + Sync + 'static,
    R: Ratchet,
    P: AttachedPayload,
{
    fn drop(&mut self) {
        self.is_active.store(false, ORDERING);
        let _ = self.manager.shutdown();
    }
}

#[cfg(test)]
mod tests {
    use std::sync::{atomic::AtomicBool, Arc};

    use citadel_io::tokio_stream::StreamExt;
    use citadel_types::crypto::SecrecyMode;

    pub use crate::ratchets::ratchet_manager::tests::*;
    use crate::ratchets::ratchet_manager::AttachedPayload;

    use super::{
        RatchetManagerMessengerLayer, RatchetManagerMessengerLayerRx,
        RatchetManagerMessengerLayerTx,
    };

    pub type TestRatchetManagerMessenger<R, P> =
        RatchetManagerMessengerLayer<futures::channel::mpsc::SendError, R, P>;
    pub type TestRatchetManagerMessengerRx<R, P> =
        RatchetManagerMessengerLayerRx<futures::channel::mpsc::SendError, R, P>;
    pub type TestRatchetManagerMessengerTx<R, P> =
        RatchetManagerMessengerLayerTx<futures::channel::mpsc::SendError, R, P>;

    fn create_messengers<R, P>(
        secrecy_mode: SecrecyMode,
    ) -> (
        TestRatchetManagerMessenger<R, P>,
        TestRatchetManagerMessenger<R, P>,
    )
    where
        R: Ratchet,
        P: AttachedPayload,
    {
        let (alice_manager, bob_manager) = create_ratchet_managers();

        let alice_messenger = RatchetManagerMessengerLayer::new(
            alice_manager,
            secrecy_mode,
            None,
            Arc::new(AtomicBool::new(true)),
        );

        let bob_messenger = RatchetManagerMessengerLayer::new(
            bob_manager,
            secrecy_mode,
            None,
            Arc::new(AtomicBool::new(true)),
        );

        (alice_messenger, bob_messenger)
    }

    /// Both nodes send a message, then receive a message. Determinate order
    async fn run_messenger_one_round_one_at_a_time<
        R: Ratchet,
        P: AttachedPayload + Clone + std::fmt::Debug + Eq,
    >(
        alice_messenger_tx: &mut TestRatchetManagerMessengerTx<R, P>,
        alice_messenger_rx: &mut TestRatchetManagerMessengerRx<R, P>,
        bob_messenger_tx: &mut TestRatchetManagerMessengerTx<R, P>,
        bob_messenger_rx: &mut TestRatchetManagerMessengerRx<R, P>,
        payload: P,
    ) {
        alice_messenger_tx.send(payload.clone()).await.unwrap();
        bob_messenger_tx.send(payload.clone()).await.unwrap();
        let alice_message_from_bob = alice_messenger_rx.next().await.unwrap();
        let bob_message_from_alice = bob_messenger_rx.next().await.unwrap();
        assert_eq!(alice_message_from_bob, payload.clone());
        assert_eq!(bob_message_from_alice, payload);
    }

    /// Both nodes send a message, then receive a message. As opposed to above, the nodes sending/receiving messages happens
    /// in parallel to give indeterminate ordering
    async fn run_messenger_round_racy<
        R: Ratchet,
        P: AttachedPayload + From<u64> + std::fmt::Debug + Eq + Clone,
    >(
        alice_messenger_tx: TestRatchetManagerMessengerTx<R, P>,
        alice_messenger_rx: TestRatchetManagerMessengerRx<R, P>,
        bob_messenger_tx: TestRatchetManagerMessengerTx<R, P>,
        bob_messenger_rx: TestRatchetManagerMessengerRx<R, P>,
        delay: Option<Duration>,
    ) {
        let (delay_alice, delay_bob) = generate_delay(delay);

        let send_task = |mut messenger_tx: TestRatchetManagerMessengerTx<R, P>,
                         mut messenger_rx: TestRatchetManagerMessengerRx<R, P>,
                         delay: Option<Duration>| async move {
            for x in 0..100u64 {
                if let Some(delay) = delay {
                    tokio::time::sleep(delay).await;
                }

                let payload = P::from(x);
                messenger_tx.send(payload.clone()).await.unwrap();

                let recv_payload = messenger_rx.next().await.unwrap();
                assert_eq!(recv_payload, payload);
            }
        };

        let alice_task = send_task(alice_messenger_tx, alice_messenger_rx, delay_alice);
        let bob_task = send_task(bob_messenger_tx, bob_messenger_rx, delay_bob);

        tokio::join!(alice_task, bob_task);
    }

    /// Both nodes send ALL messages as fast as possible, then receive ALL messages. This adds more indeterminate ordering
    /// than above
    async fn run_messenger_round_racy_contentious<
        R: Ratchet,
        P: AttachedPayload + From<u64> + std::fmt::Debug + Eq + Clone,
    >(
        alice_messenger_tx: TestRatchetManagerMessengerTx<R, P>,
        alice_messenger_rx: TestRatchetManagerMessengerRx<R, P>,
        bob_messenger_tx: TestRatchetManagerMessengerTx<R, P>,
        bob_messenger_rx: TestRatchetManagerMessengerRx<R, P>,
        delay: Option<Duration>,
    ) {
        let (delay_alice, delay_bob) = generate_delay(delay);

        let send_task = move |mut messenger_tx: TestRatchetManagerMessengerTx<R, P>,
                              mut messenger_rx: TestRatchetManagerMessengerRx<R, P>,
                              delay: Option<Duration>| async move {
            let cid = messenger_rx.manager.session_crypto_state.cid();
            for x in 0..100u64 {
                if let Some(delay) = delay {
                    tokio::time::sleep(delay).await;
                }

                let payload = P::from(x);
                messenger_tx.send(payload.clone()).await.unwrap();
            }

            for x in 0..100u64 {
                let received = messenger_rx.next().await.unwrap();
                let expected = P::from(x);
                log::trace!(target: "citadel", "[Messenger {cid}] recv: {received:?} | {received:?} must be equal to expected {expected:?}");
                assert_eq!(received, expected);
            }
        };

        let alice_task = send_task(alice_messenger_tx, alice_messenger_rx, delay_alice);
        let bob_task = send_task(bob_messenger_tx, bob_messenger_rx, delay_bob);

        tokio::join!(alice_task, bob_task);
    }

    fn generate_delay(delay: Option<Duration>) -> (Option<Duration>, Option<Duration>) {
        if let Some(delay) = delay {
            if rand::random::<u8>() % 2 == 0 {
                (Some(delay), None)
            } else {
                (None, Some(delay))
            }
        } else {
            (None, None)
        }
    }

    async fn messenger_racy<
        R: Ratchet,
        P: AttachedPayload + From<u64> + std::fmt::Debug + Eq + Clone,
    >(
        secrecy_mode: SecrecyMode,
        delay: Option<Duration>,
    ) {
        let (alice_manager, bob_manager) = create_messengers::<R, P>(secrecy_mode);
        let (alice_messenger_tx, alice_messenger_rx) = alice_manager.split();
        let (bob_messenger_tx, bob_messenger_rx) = bob_manager.split();

        run_messenger_round_racy::<R, P>(
            alice_messenger_tx,
            alice_messenger_rx,
            bob_messenger_tx,
            bob_messenger_rx,
            delay,
        )
        .await;
    }

    async fn messenger_racy_contentious<
        R: Ratchet,
        P: AttachedPayload + From<u64> + std::fmt::Debug + Eq + Clone,
    >(
        secrecy_mode: SecrecyMode,
        delay: Option<Duration>,
    ) {
        let (alice_manager, bob_manager) = create_messengers::<R, P>(secrecy_mode);
        let (alice_messenger_tx, alice_messenger_rx) = alice_manager.split();
        let (bob_messenger_tx, bob_messenger_rx) = bob_manager.split();

        run_messenger_round_racy_contentious::<R, P>(
            alice_messenger_tx,
            alice_messenger_rx,
            bob_messenger_tx,
            bob_messenger_rx,
            delay,
        )
        .await;
    }

    #[rstest]
    #[timeout(std::time::Duration::from_secs(60))]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_messenger_racy(
        #[values(SecrecyMode::BestEffort, SecrecyMode::Perfect)] secrecy_mode: SecrecyMode,
    ) {
        citadel_logging::setup_log();
        messenger_racy::<StackedRatchet, u64>(secrecy_mode, None).await;
    }

    #[rstest]
    #[timeout(std::time::Duration::from_secs(360))]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_messenger_racy_with_random_start_lag(
        #[values(0, 1, 10, 100, 500)] min_delay: u64,
        #[values(SecrecyMode::BestEffort, SecrecyMode::Perfect)] secrecy_mode: SecrecyMode,
    ) {
        citadel_logging::setup_log();
        messenger_racy::<StackedRatchet, u64>(secrecy_mode, Some(Duration::from_millis(min_delay)))
            .await;
    }

    #[rstest]
    #[timeout(std::time::Duration::from_secs(60))]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_messenger_racy_contentious(
        #[values(SecrecyMode::BestEffort, SecrecyMode::Perfect)] secrecy_mode: SecrecyMode,
    ) {
        citadel_logging::setup_log();
        messenger_racy_contentious::<StackedRatchet, u64>(secrecy_mode, None).await;
    }

    #[rstest]
    #[timeout(std::time::Duration::from_secs(360))]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_messenger_racy_contentious_with_random_start_lag(
        #[values(0, 1, 10, 100, 500)] min_delay: u64,
        #[values(SecrecyMode::BestEffort, SecrecyMode::Perfect)] secrecy_mode: SecrecyMode,
    ) {
        citadel_logging::setup_log();
        messenger_racy_contentious::<StackedRatchet, u64>(
            secrecy_mode,
            Some(Duration::from_millis(min_delay)),
        )
        .await;
    }

    #[rstest]
    #[timeout(std::time::Duration::from_secs(60))]
    #[tokio::test(flavor = "multi_thread")]
    async fn test_messenger_one_at_a_time() {
        citadel_logging::setup_log();
        let (alice_manager, bob_manager) =
            create_messengers::<StackedRatchet, _>(SecrecyMode::BestEffort);
        let (mut alice_messenger_tx, mut alice_messenger_rx) = alice_manager.split();
        let (mut bob_messenger_tx, mut bob_messenger_rx) = bob_manager.split();
        const ROUNDS: usize = 100;

        for x in 0..ROUNDS {
            run_messenger_one_round_one_at_a_time::<StackedRatchet, u64>(
                &mut alice_messenger_tx,
                &mut alice_messenger_rx,
                &mut bob_messenger_tx,
                &mut bob_messenger_rx,
                x as u64,
            )
            .await;
        }
    }
}