chroma-types 0.15.0

Chroma-provided crate for internal types used in the Chroma API.
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
use crate::{
    execution::plan::SearchPayload,
    operator::{Aggregate, GroupBy, QueryVector, Rank},
    CollectionMetadataUpdate, Metadata, MetadataValue, Schema, UpdateMetadata, UpdateMetadataValue,
    DOCUMENT_KEY, EMBEDDING_KEY,
};
use regex::Regex;
use std::collections::HashMap;
use std::str::FromStr;
use std::{net::IpAddr, sync::LazyLock};
use validator::ValidationError;

static ALNUM_RE: LazyLock<Regex> = LazyLock::new(|| {
    Regex::new(r"^[a-zA-Z0-9][a-zA-Z0-9._-]{1, 510}[a-zA-Z0-9]$")
        .expect("The alphanumeric regex should be valid")
});

static DP_RE: LazyLock<Regex> =
    LazyLock::new(|| Regex::new(r"\.\.").expect("The double period regex should be valid"));

pub(crate) fn validate_non_empty_collection_update_metadata(
    update: &CollectionMetadataUpdate,
) -> Result<(), ValidationError> {
    match update {
        CollectionMetadataUpdate::UpdateMetadata(metadata) => {
            validate_non_empty_metadata(metadata)?;
            validate_update_metadata(metadata)
        }
        CollectionMetadataUpdate::ResetMetadata => Ok(()),
    }
}

pub(crate) fn validate_non_empty_metadata<V>(
    metadata: &HashMap<String, V>,
) -> Result<(), ValidationError> {
    if metadata.is_empty() {
        Err(ValidationError::new("metadata").with_message("Metadata cannot be empty".into()))
    } else {
        Ok(())
    }
}

pub fn validate_name(name: impl AsRef<str>) -> Result<(), ValidationError> {
    let name_str = name.as_ref();

    // A topology is a valid name.  A database name prefixed with a topology is a valid name.  The
    // conjunction must be separated by a single `+` and not exceed the database name limits.
    // Thus, we recurse after validating no more plusses.
    if let Some((topo, name)) = name_str.split_once('+') {
        if name_str.len() > 512 {
            return Err(ValidationError::new("name").with_message(
                format!(
                    "Expected a name containing 3-512 characters. Got: {}",
                    name_str.len()
                )
                .into(),
            ));
        }
        if name.chars().any(|c| c == '+') {
            return Err(ValidationError::new("name").with_message(
                "Expected a name to contain at most one topology:  Got two `+` characters.".into(),
            ));
        }
        assert!(
            !topo.chars().any(|c| c == '+'),
            "split once should not bypass the split character"
        );
        validate_name(topo)?;
        validate_name(name)?;
        return Ok(());
    }

    if !ALNUM_RE.is_match(name_str) {
        return Err(ValidationError::new("name").with_message(format!("Expected a name containing 3-512 characters from [a-zA-Z0-9._-], starting and ending with a character in [a-zA-Z0-9]. Got: {name_str}").into()));
    }

    if DP_RE.is_match(name_str) {
        return Err(ValidationError::new("name").with_message(
            format!(
            "Expected a name that does not contains two consecutive periods (..). Got {name_str}"
        )
            .into(),
        ));
    }
    if IpAddr::from_str(name_str).is_ok() {
        return Err(ValidationError::new("name").with_message(
            format!("Expected a name that is not a valid ip address. Got {name_str}").into(),
        ));
    }
    Ok(())
}

/// Validate a single metadata key
fn validate_metadata_key(key: &str) -> Result<(), ValidationError> {
    if key.is_empty() {
        Err(ValidationError::new("metadata_key")
            .with_message("Metadata key cannot be empty".into()))
    } else if key.starts_with('#') || key.starts_with('$') {
        Err(ValidationError::new("metadata_key")
            .with_message(format!("Metadata key cannot start with '#' or '$': {}", key).into()))
    } else {
        Ok(())
    }
}

/// Validate metadata
pub fn validate_metadata(metadata: &Metadata) -> Result<(), ValidationError> {
    for (key, value) in metadata {
        validate_metadata_key(key)?;

        if let MetadataValue::SparseVector(sv) = value {
            sv.validate().map_err(|e| {
                ValidationError::new("sparse_vector")
                    .with_message(format!("Invalid sparse vector: {}", e).into())
            })?;
        }
    }
    Ok(())
}

/// Validate update metadata
pub fn validate_update_metadata(metadata: &UpdateMetadata) -> Result<(), ValidationError> {
    for (key, value) in metadata {
        validate_metadata_key(key)?;

        if let UpdateMetadataValue::SparseVector(sv) = value {
            sv.validate().map_err(|e| {
                ValidationError::new("sparse_vector")
                    .with_message(format!("Invalid sparse vector: {}", e).into())
            })?;
        }
    }
    Ok(())
}

/// Validate optional vector of optional metadata
pub fn validate_metadata_vec(metadatas: &[Option<Metadata>]) -> Result<(), ValidationError> {
    for (i, metadata_opt) in metadatas.iter().enumerate() {
        if let Some(metadata) = metadata_opt {
            validate_metadata(metadata).map_err(|_| {
                ValidationError::new("metadata")
                    .with_message(format!("Invalid metadata at index {}", i).into())
            })?;
        }
    }
    Ok(())
}

/// Validate optional vector of optional update metadata
pub fn validate_update_metadata_vec(
    metadatas: &[Option<UpdateMetadata>],
) -> Result<(), ValidationError> {
    for (i, metadata_opt) in metadatas.iter().enumerate() {
        if let Some(metadata) = metadata_opt {
            validate_update_metadata(metadata).map_err(|_| {
                ValidationError::new("metadata")
                    .with_message(format!("Invalid metadata at index {}", i).into())
            })?;
        }
    }
    Ok(())
}

/// Validate optional metadata (for CreateCollectionRequest)
pub fn validate_optional_metadata(metadata: &Metadata) -> Result<(), ValidationError> {
    // First check it's not empty
    validate_non_empty_metadata(metadata)?;
    // Then validate keys and sparse vectors
    validate_metadata(metadata)?;
    Ok(())
}

/// Validate rank operator for sparse vectors
pub fn validate_rank(rank: &Rank) -> Result<(), ValidationError> {
    for knn in rank.knn_queries() {
        if let QueryVector::Sparse(sv) = &knn.query {
            sv.validate().map_err(|e| {
                ValidationError::new("sparse_vector")
                    .with_message(format!("Invalid sparse vector in KNN query: {}", e).into())
            })?;
        }
    }
    Ok(())
}

/// Validate group_by operator
pub fn validate_group_by(group_by: &GroupBy) -> Result<(), ValidationError> {
    let has_keys = !group_by.keys.is_empty();
    let has_aggregate = group_by.aggregate.is_some();

    if has_keys != has_aggregate {
        return Err(ValidationError::new("group_by").with_message(
            "group_by keys and aggregate must both be specified or both be omitted".into(),
        ));
    }

    // Validate group_by keys: only metadata fields are allowed
    for key in &group_by.keys {
        match key {
            crate::operator::Key::MetadataField(_) => {}
            _ => {
                return Err(ValidationError::new("group_by").with_message(
                    "group_by keys must be metadata fields (cannot use #score, #document, #embedding, or #metadata)".into(),
                ));
            }
        }
    }

    match &group_by.aggregate {
        Some(Aggregate::MinK { keys, k }) | Some(Aggregate::MaxK { keys, k }) => {
            if keys.is_empty() {
                return Err(ValidationError::new("group_by")
                    .with_message("aggregate keys must not be empty".into()));
            }
            if *k == 0 {
                return Err(ValidationError::new("group_by")
                    .with_message("aggregate k must be greater than 0".into()));
            }
            // Validate aggregate keys: only metadata fields and score are allowed
            for key in keys {
                match key {
                    crate::operator::Key::MetadataField(_) | crate::operator::Key::Score => {}
                    _ => {
                        return Err(ValidationError::new("group_by").with_message(
                            "aggregate keys must be metadata fields or #score (cannot use #document, #embedding, or #metadata)".into(),
                        ));
                    }
                }
            }
        }
        None => {}
    }

    Ok(())
}

/// Validate SearchPayload
pub fn validate_search_payload(payload: &SearchPayload) -> Result<(), ValidationError> {
    if !payload.group_by.keys.is_empty() && payload.rank.expr.is_none() {
        return Err(ValidationError::new("group_by")
            .with_message("group_by requires rank expression to be specified".into()));
    }
    Ok(())
}

/// Validate schema
pub fn validate_schema(schema: &Schema) -> Result<(), ValidationError> {
    if schema
        .defaults
        .float_list
        .as_ref()
        .is_some_and(|vt| vt.vector_index.as_ref().is_some_and(|it| it.enabled))
    {
        return Err(ValidationError::new("schema").with_message("Vector index cannot be enabled by default. It can only be enabled on #embedding field.".into()));
    }
    if schema.defaults.float_list.as_ref().is_some_and(|vt| {
        vt.vector_index
            .as_ref()
            .is_some_and(|it| it.config.hnsw.is_some() && it.config.spann.is_some())
    }) {
        return Err(ValidationError::new("schema").with_message(
            "Both spann and hnsw config cannot be present at the same time.".into(),
        ));
    }
    if schema
        .defaults
        .sparse_vector
        .as_ref()
        .is_some_and(|vt| vt.sparse_vector_index.as_ref().is_some_and(|it| it.enabled))
    {
        return Err(ValidationError::new("schema").with_message("Sparse vector index cannot be enabled by default. Please enable sparse vector index on specific keys.".into()));
    }
    if schema
        .defaults
        .string
        .as_ref()
        .is_some_and(|vt| vt.fts_index.as_ref().is_some_and(|it| it.enabled))
    {
        return Err(ValidationError::new("schema").with_message("Full text search / regular expression index cannot be enabled by default. It can only be enabled on #document field.".into()));
    }
    for (key, config) in &schema.keys {
        // Validate that keys cannot start with # (except system keys)
        if key.starts_with('#') && key != DOCUMENT_KEY && key != EMBEDDING_KEY {
            return Err(ValidationError::new("schema").with_message(
                format!("key cannot begin with '#'. Keys starting with '#' are reserved for system use: {key}")
                    .into(),
            ));
        }

        if key == DOCUMENT_KEY
            && (config.boolean.is_some()
                || config.float.is_some()
                || config.int.is_some()
                || config.float_list.is_some()
                || config.sparse_vector.is_some())
        {
            return Err(ValidationError::new("schema").with_message(
                format!("Document field cannot have any value types other than string: {key}")
                    .into(),
            ));
        }
        if key == EMBEDDING_KEY
            && (config.boolean.is_some()
                || config.float.is_some()
                || config.int.is_some()
                || config.string.is_some()
                || config.sparse_vector.is_some())
        {
            return Err(ValidationError::new("schema").with_message(
                format!("Embedding field cannot have any value types other than float_list: {key}")
                    .into(),
            ));
        }
        if let Some(vit) = config
            .float_list
            .as_ref()
            .and_then(|vt| vt.vector_index.as_ref())
        {
            if vit.enabled && key != EMBEDDING_KEY {
                return Err(ValidationError::new("schema").with_message(
                    format!("Vector index can only be enabled on #embedding field: {key}").into(),
                ));
            }
            if vit
                .config
                .source_key
                .as_ref()
                .is_some_and(|key| key != DOCUMENT_KEY)
            {
                return Err(ValidationError::new("schema")
                    .with_message("Vector index can only source from #document".into()));
            }
        }
        if let Some(svit) = config
            .sparse_vector
            .as_ref()
            .and_then(|vt| vt.sparse_vector_index.as_ref())
        {
            if svit.enabled
                && svit.config.source_key.is_some()
                && svit.config.embedding_function.is_none()
            {
                return Err(ValidationError::new("schema").with_message(
                    "If source_key is provided then embedding_function must also be provided since there is no default embedding function.".into(),
                ));
            }
            // Validate source_key for sparse vector index
            if let Some(source_key) = &svit.config.source_key {
                if source_key.starts_with('#') && source_key != DOCUMENT_KEY {
                    return Err(ValidationError::new("schema").with_message(
                        "source_key cannot begin with '#'. The only valid key starting with '#' is Key.DOCUMENT or '#document'.".into(),
                    ));
                }
            }
        }
        if config
            .string
            .as_ref()
            .is_some_and(|vt| vt.fts_index.as_ref().is_some_and(|it| it.enabled))
            && key != DOCUMENT_KEY
        {
            return Err(ValidationError::new("schema").with_message(format!("Full text search / regular expression index can only be enabled on #document field: {key}").into()));
        }
        if config.string.as_ref().is_some_and(|vt| {
            vt.string_inverted_index
                .as_ref()
                .is_some_and(|it| it.enabled)
        }) && key == DOCUMENT_KEY
        {
            return Err(ValidationError::new("schema").with_message(
                format!("String inverted index can not be enabled on #document key: {key}").into(),
            ));
        }
    }
    if let Some(cmek) = &schema.cmek {
        if !cmek.validate_pattern() {
            return Err(ValidationError::new("schema")
                .with_message(format!("CMEK does not match expected pattern: {cmek:?}").into()));
        }
    }
    Ok(())
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::operator::Key;
    use crate::{MetadataValue, SparseVector};

    #[test]
    fn valid_simple_name() {
        assert!(validate_name("abc").is_ok());
        assert!(validate_name("my_collection").is_ok());
        assert!(validate_name("my-collection").is_ok());
        assert!(validate_name("my.collection").is_ok());
        assert!(validate_name("MyCollection123").is_ok());
    }

    #[test]
    fn invalid_simple_name_too_short() {
        assert!(validate_name("ab").is_err());
        assert!(validate_name("a").is_err());
        assert!(validate_name("").is_err());
    }

    #[test]
    fn invalid_simple_name_bad_start_or_end() {
        assert!(validate_name("_abc").is_err());
        assert!(validate_name("-abc").is_err());
        assert!(validate_name(".abc").is_err());
        assert!(validate_name("abc_").is_err());
        assert!(validate_name("abc-").is_err());
        assert!(validate_name("abc.").is_err());
    }

    #[test]
    fn invalid_simple_name_double_period() {
        assert!(validate_name("abc..def").is_err());
        assert!(validate_name("my..collection").is_err());
    }

    #[test]
    fn invalid_simple_name_ip_address() {
        assert!(validate_name("192.168.0.1").is_err());
        assert!(validate_name("127.0.0.1").is_err());
    }

    #[test]
    fn valid_topology_prefixed_name() {
        assert!(validate_name("topo+name").is_ok());
        assert!(validate_name("my_topology+my_collection").is_ok());
        assert!(validate_name("region1+database").is_ok());
        assert!(validate_name("abc+def").is_ok());
    }

    #[test]
    fn invalid_topology_prefixed_name_multiple_plus() {
        assert!(validate_name("a+b+c").is_err());
        assert!(validate_name("topo+name+extra").is_err());
        assert!(validate_name("one+two+three").is_err());
    }

    #[test]
    fn invalid_topology_prefixed_name_invalid_topology() {
        // Topology part must be valid (3+ chars, start/end with alnum)
        assert!(validate_name("ab+valid").is_err());
        assert!(validate_name("_bad+valid").is_err());
        assert!(validate_name("bad_+valid").is_err());
    }

    #[test]
    fn invalid_topology_prefixed_name_invalid_name() {
        // Name part must be valid (3+ chars, start/end with alnum)
        assert!(validate_name("valid+ab").is_err());
        assert!(validate_name("valid+_bad").is_err());
        assert!(validate_name("valid+bad_").is_err());
    }

    #[test]
    fn invalid_topology_prefixed_name_too_long() {
        // Total length exceeds 512
        let long_topo = "a".repeat(256);
        let long_name = "b".repeat(258);
        let too_long = format!("{}+{}", long_topo, long_name);
        assert!(too_long.len() > 512);
        assert!(validate_name(&too_long).is_err());
    }

    #[test]
    fn valid_topology_prefixed_name_at_limit() {
        // Total length exactly 512
        let topo = "a".repeat(255);
        let name = "b".repeat(256);
        let at_limit = format!("{}+{}", topo, name);
        assert_eq!(at_limit.len(), 512);
        assert!(validate_name(&at_limit).is_ok());
    }

    #[test]
    fn test_metadata_validation() {
        // Valid metadata
        let mut metadata = Metadata::new();
        metadata.insert("valid_key".to_string(), MetadataValue::Int(42));
        let sparse = SparseVector::new(vec![1, 2, 3], vec![0.1, 0.2, 0.3]).unwrap();
        metadata.insert("embedding".to_string(), MetadataValue::SparseVector(sparse));
        assert!(validate_metadata(&metadata).is_ok());

        // Invalid key starting with #
        let mut metadata = Metadata::new();
        metadata.insert("#embedding".to_string(), MetadataValue::Int(42));
        assert!(validate_metadata(&metadata).is_err());

        // Invalid key starting with #
        let mut metadata = Metadata::new();
        metadata.insert("#invalid".to_string(), MetadataValue::Int(42));
        assert!(validate_metadata(&metadata).is_err());

        // Invalid key starting with $
        let mut metadata = Metadata::new();
        metadata.insert("$invalid".to_string(), MetadataValue::Int(42));
        assert!(validate_metadata(&metadata).is_err());

        // Invalid empty key
        let mut metadata = Metadata::new();
        metadata.insert("".to_string(), MetadataValue::Int(42));
        assert!(validate_metadata(&metadata).is_err());

        // Invalid sparse vector (length mismatch)
        let mut metadata = Metadata::new();
        let invalid_sparse = SparseVector {
            indices: vec![1, 2],
            values: vec![0.1, 0.2, 0.3],
            tokens: None,
        };
        metadata.insert(
            "embedding".to_string(),
            MetadataValue::SparseVector(invalid_sparse),
        );
        assert!(validate_metadata(&metadata).is_err());
    }

    #[test]
    fn test_validate_group_by() {
        // Valid: both keys and aggregate present
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::Score],
                k: 3,
            }),
        };
        assert!(validate_group_by(&group_by).is_ok());

        // Valid: both empty
        let group_by = GroupBy {
            keys: vec![],
            aggregate: None,
        };
        assert!(validate_group_by(&group_by).is_ok());

        // Invalid: keys present, aggregate missing
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: None,
        };
        assert!(validate_group_by(&group_by).is_err());

        // Invalid: aggregate present, keys missing
        let group_by = GroupBy {
            keys: vec![],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::Score],
                k: 3,
            }),
        };
        assert!(validate_group_by(&group_by).is_err());

        // Invalid: aggregate k = 0
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::Score],
                k: 0,
            }),
        };
        assert!(validate_group_by(&group_by).is_err());

        // Invalid: aggregate keys empty
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: Some(Aggregate::MaxK { keys: vec![], k: 5 }),
        };
        assert!(validate_group_by(&group_by).is_err());

        // Invalid: group_by key must be metadata field (not #score)
        let group_by = GroupBy {
            keys: vec![Key::Score],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::Score],
                k: 3,
            }),
        };
        assert!(validate_group_by(&group_by).is_err());

        // Invalid: aggregate key cannot be #document
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::Document],
                k: 3,
            }),
        };
        assert!(validate_group_by(&group_by).is_err());

        // Valid: aggregate key can be metadata field
        let group_by = GroupBy {
            keys: vec![Key::field("category")],
            aggregate: Some(Aggregate::MinK {
                keys: vec![Key::field("date"), Key::Score],
                k: 3,
            }),
        };
        assert!(validate_group_by(&group_by).is_ok());
    }

    #[test]
    fn test_validate_search_payload() {
        use crate::operator::{QueryVector, RankExpr};

        // Valid: group_by with rank expression
        let payload = SearchPayload {
            rank: Rank {
                expr: Some(RankExpr::Knn {
                    query: QueryVector::Dense(vec![0.1, 0.2, 0.3]),
                    key: Key::Embedding,
                    limit: 100,
                    default: None,
                    return_rank: false,
                }),
            },
            group_by: GroupBy {
                keys: vec![Key::field("category")],
                aggregate: Some(Aggregate::MinK {
                    keys: vec![Key::Score],
                    k: 3,
                }),
            },
            ..Default::default()
        };
        assert!(validate_search_payload(&payload).is_ok());

        // Valid: no group_by, no rank
        let payload = SearchPayload::default();
        assert!(validate_search_payload(&payload).is_ok());

        // Valid: rank without group_by
        let payload = SearchPayload {
            rank: Rank {
                expr: Some(RankExpr::Knn {
                    query: QueryVector::Dense(vec![0.1, 0.2, 0.3]),
                    key: Key::Embedding,
                    limit: 100,
                    default: None,
                    return_rank: false,
                }),
            },
            ..Default::default()
        };
        assert!(validate_search_payload(&payload).is_ok());

        // Invalid: group_by without rank expression
        let payload = SearchPayload {
            rank: Rank { expr: None },
            group_by: GroupBy {
                keys: vec![Key::field("category")],
                aggregate: Some(Aggregate::MinK {
                    keys: vec![Key::Score],
                    k: 3,
                }),
            },
            ..Default::default()
        };
        assert!(validate_search_payload(&payload).is_err());
    }

    fn schema_with_sparse_key(
        schema: &mut Schema,
        key: &str,
        algorithm: crate::SparseIndexAlgorithm,
    ) {
        use crate::{SparseVectorIndexConfig, SparseVectorIndexType, SparseVectorValueType};
        schema
            .keys
            .entry(key.to_string())
            .or_default()
            .sparse_vector = Some(SparseVectorValueType {
            sparse_vector_index: Some(SparseVectorIndexType {
                enabled: true,
                config: SparseVectorIndexConfig {
                    embedding_function: None,
                    source_key: None,
                    bm25: None,
                    algorithm,
                },
            }),
        });
    }

    #[test]
    fn test_validate_schema_allows_multiple_sparse_keys() {
        use crate::{KnnIndex, SparseIndexAlgorithm};
        let mut schema = Schema::new_default(KnnIndex::Hnsw);
        schema_with_sparse_key(&mut schema, "sparse_a", SparseIndexAlgorithm::Wand);
        schema_with_sparse_key(&mut schema, "sparse_b", SparseIndexAlgorithm::MaxScore);
        assert!(validate_schema(&schema).is_ok());
    }

    #[test]
    fn test_validate_schema_rejects_default_sparse_index() {
        use crate::{
            KnnIndex, SparseIndexAlgorithm, SparseVectorIndexConfig, SparseVectorIndexType,
            SparseVectorValueType,
        };
        let mut schema = Schema::new_default(KnnIndex::Hnsw);
        schema.defaults.sparse_vector = Some(SparseVectorValueType {
            sparse_vector_index: Some(SparseVectorIndexType {
                enabled: true,
                config: SparseVectorIndexConfig {
                    embedding_function: None,
                    source_key: None,
                    bm25: None,
                    algorithm: SparseIndexAlgorithm::Wand,
                },
            }),
        });
        assert!(validate_schema(&schema).is_err());
    }

    fn sparse_rank_leaf(index: u32, key: &str) -> crate::operator::RankExpr {
        crate::operator::RankExpr::Knn {
            query: crate::operator::QueryVector::Sparse(
                SparseVector::new(vec![index], vec![1.0]).unwrap(),
            ),
            key: Key::field(key),
            limit: 10,
            default: None,
            return_rank: false,
        }
    }

    #[test]
    fn test_validate_rank_admits_multiple_sparse_leaves() {
        use crate::operator::RankExpr;
        // Distinct sparse keys plus a repeat of the first key — all valid.
        let rank = Rank {
            expr: Some(RankExpr::Summation(vec![
                sparse_rank_leaf(0, "sparse_a"),
                sparse_rank_leaf(1, "sparse_b"),
                sparse_rank_leaf(2, "sparse_a"),
            ])),
        };
        assert!(validate_rank(&rank).is_ok());
    }

    #[test]
    fn test_validate_rank_rejects_invalid_sparse_leaf() {
        use crate::operator::RankExpr;
        // One valid leaf, one with mismatched indices/values lengths.
        let bad = RankExpr::Knn {
            query: crate::operator::QueryVector::Sparse(SparseVector {
                indices: vec![0, 1],
                values: vec![1.0],
                tokens: None,
            }),
            key: Key::field("sparse_b"),
            limit: 10,
            default: None,
            return_rank: false,
        };
        let rank = Rank {
            expr: Some(RankExpr::Summation(vec![
                sparse_rank_leaf(0, "sparse_a"),
                bad,
            ])),
        };
        assert!(validate_rank(&rank).is_err());
    }
}