choreo-daemon 0.1.0

Agentic coding assistant — daemon, TUI, and bridges
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
use choreo_daemon::tools::Tool;
use choreo_daemon::tools::context::ToolContext;
use choreo_daemon::tools::subsession::{SpawnSubsession, SpawnSubsessionArgs};
use choreo_daemon::{ChildResult, DaemonCommand, SessionCommand};
use std::collections::HashSet;
use std::sync::Arc;
use std::sync::atomic::AtomicBool;
use std::sync::mpsc;
use std::thread;

mod common;

/// Verify that SpawnSubsession::execute correctly communicates with the
/// daemon to create a child session, sends the prompt via RunChildInput
/// user_text, and returns the child's output as a tool result.
#[ignore]
#[test]
fn spawn_subsession_happy_path() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();

    // ── Daemon handler thread ────────────────────────────────────────
    //
    // Intercepts DaemonCommand::CreateSession, sets up a mock child
    // session, and sends back the child session command channel so the
    // tool can interact with it.
    let daemon_handle = thread::spawn(move || {
        match daemon_rx.recv().unwrap() {
            DaemonCommand::CreateSession {
                title,
                parent_session_id,
                working_dir,
                reasoning_effort,
                selected_model,
                context_config: _,
                account_name,
                active_tool_groups,
                reply,
            } => {
                // Verify the tool forwarded the right config.
                assert_eq!(title.as_deref(), Some("test-sub"));
                assert_eq!(parent_session_id, Some(1));
                assert_eq!(working_dir, None);
                assert_eq!(reasoning_effort, None);
                assert_eq!(selected_model, None);
                assert_eq!(account_name, None);
                // With no explicit categories, the tool inherits from
                // ToolContext.active_tool_groups (empty in this test).
                assert!(active_tool_groups.is_empty());

                // Create a mock child session channel.
                let (child_tx, child_rx) = mpsc::channel::<SessionCommand>();
                let child_id = 42u64;

                // Reply to the tool with the child session sender.
                reply.send(Ok((child_id, child_tx))).unwrap();

                // ── Receive and verify RunChildInput with user_text ──
                match child_rx.recv().unwrap() {
                    SessionCommand::RunChildInput {
                        request_id,
                        user_text,
                        reply,
                    } => {
                        assert_eq!(request_id, 1);
                        assert_eq!(user_text.as_deref(), Some("work on this task"));
                        reply
                            .send(Ok(ChildResult {
                                output: "task output here".into(),
                                is_error: false,
                            }))
                            .unwrap();
                    }
                    _ => panic!("expected RunChildInput"),
                }
            }
            _ => panic!("expected CreateSession"),
        }
    });

    // ── Build ToolContext with a daemon channel ──────────────────────
    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: HashSet::new(),
        reasoning_effort: None,
        selected_model: None,
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    // ── Execute the tool ─────────────────────────────────────────────
    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "work on this task".into(),
            title: Some("test-sub".into()),
            categories: None,
        },
        None, // x_credentials
        None, // working_dir
        Some(&tool_ctx),
    );

    match result {
        Ok(output) => {
            assert!(
                output.contains("sub-session 42 result:"),
                "output should mention child session id: {output}",
            );
            assert!(
                output.contains("task output here"),
                "output should contain child result: {output}",
            );
        }
        Err(e) => panic!("SpawnSubsession::execute failed: {e}"),
    }

    daemon_handle.join().unwrap();
}

/// When the daemon rejects session creation, the tool should propagate the
/// error instead of panicking or hanging.
#[ignore]
#[test]
fn spawn_subsession_daemon_rejects_creation() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();

    let daemon_handle = thread::spawn(move || match daemon_rx.recv().unwrap() {
        DaemonCommand::CreateSession { reply, .. } => {
            reply
                .send(Err(std::io::Error::other("daemon is busy")))
                .unwrap();
        }
        _ => panic!("expected CreateSession"),
    });

    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: HashSet::new(),
        reasoning_effort: None,
        selected_model: None,
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "irrelevant".into(),
            title: None,
            categories: None,
        },
        None,
        None,
        Some(&tool_ctx),
    );

    match result {
        Err(e) => {
            let msg = e.to_string();
            assert!(
                msg.contains("daemon is busy"),
                "error should mention daemon rejection: {msg}",
            );
        }
        Ok(output) => panic!("expected error, got success: {output}"),
    }

    daemon_handle.join().unwrap();
}

/// When the daemon command channel is dropped before the tool sends its
/// command, the tool should surface a communication error.
#[ignore]
#[test]
fn spawn_subsession_daemon_disconnected() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();
    drop(daemon_rx);

    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: HashSet::new(),
        reasoning_effort: None,
        selected_model: None,
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "should not matter".into(),
            title: None,
            categories: None,
        },
        None,
        None,
        Some(&tool_ctx),
    );

    match result {
        Err(e) => {
            let msg = e.to_string();
            assert!(
                msg.contains("daemon communication failed"),
                "error should mention communication failure: {msg}",
            );
        }
        Ok(output) => panic!("expected error, got success: {output}"),
    }
}

/// When no ToolContext is provided, the tool should return an error rather
/// than panicking with unwrap/expect.
#[ignore]
#[test]
fn spawn_subsession_no_context() {
    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "irrelevant".into(),
            title: None,
            categories: None,
        },
        None,
        None,
        None,
    );

    match result {
        Err(e) => {
            let msg = e.to_string();
            assert!(
                msg.contains("no session context"),
                "error should mention missing context: {msg}",
            );
        }
        Ok(output) => panic!("expected error, got success: {output}"),
    }
}

/// Verify that categories are inherited from ToolContext when not specified
/// explicitly in the arguments.
#[ignore]
#[test]
fn spawn_subsession_inherits_categories() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();

    let daemon_handle = thread::spawn(move || {
        match daemon_rx.recv().unwrap() {
            DaemonCommand::CreateSession {
                active_tool_groups,
                reply,
                ..
            } => {
                // Should have inherited from ToolContext.
                let mut expected: Vec<String> =
                    ["core", "shell"].into_iter().map(String::from).collect();
                let mut actual = active_tool_groups.clone();
                expected.sort();
                actual.sort();
                assert_eq!(actual, expected, "should inherit active_tool_groups");

                let (child_tx, child_rx) = mpsc::channel::<SessionCommand>();
                reply.send(Ok((1u64, child_tx))).unwrap();

                // Drain child messages so the test thread can join.
                match child_rx.recv().unwrap() {
                    SessionCommand::RunChildInput { reply, .. } => {
                        reply
                            .send(Ok(ChildResult {
                                output: "ok".into(),
                                is_error: false,
                            }))
                            .unwrap();
                    }
                    _ => panic!("expected RunChildInput"),
                }
            }
            _ => panic!("expected CreateSession"),
        }
    });

    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: ["core", "shell"].into_iter().map(String::from).collect(),
        reasoning_effort: None,
        selected_model: None,
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "work".into(),
            title: None,
            categories: None, // inherit from ctx
        },
        None,
        None,
        Some(&tool_ctx),
    );

    assert!(result.is_ok(), "expected success: {result:?}");
    daemon_handle.join().unwrap();
}

/// Override categories via explicit argument — should take precedence over
/// ToolContext.active_tool_groups.
#[ignore]
#[test]
fn spawn_subsession_overrides_categories() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();

    let daemon_handle = thread::spawn(move || {
        match daemon_rx.recv().unwrap() {
            DaemonCommand::CreateSession {
                active_tool_groups,
                reply,
                ..
            } => {
                // Should use the explicit list, not the ctx default.
                let mut expected: Vec<String> = ["db"].into_iter().map(String::from).collect();
                let mut actual = active_tool_groups.clone();
                expected.sort();
                actual.sort();
                assert_eq!(actual, expected, "should use explicit categories");

                let (child_tx, child_rx) = mpsc::channel::<SessionCommand>();
                reply.send(Ok((1u64, child_tx))).unwrap();

                match child_rx.recv().unwrap() {
                    SessionCommand::RunChildInput { reply, .. } => {
                        reply
                            .send(Ok(ChildResult {
                                output: "ok".into(),
                                is_error: false,
                            }))
                            .unwrap();
                    }
                    _ => panic!("expected RunChildInput"),
                }
            }
            _ => panic!("expected CreateSession"),
        }
    });

    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: ["core", "shell"].into_iter().map(String::from).collect(),
        reasoning_effort: None,
        selected_model: None,
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "work".into(),
            title: None,
            categories: Some(vec!["db".into()]),
        },
        None,
        None,
        Some(&tool_ctx),
    );

    assert!(result.is_ok(), "expected success: {result:?}");
    daemon_handle.join().unwrap();
}

/// Verify that selected_model is inherited from ToolContext when creating a
/// child session.
#[ignore]
#[test]
fn spawn_subsession_inherits_selected_model() {
    let db = Arc::new(common::test_db());
    let (daemon_tx, daemon_rx) = mpsc::channel::<DaemonCommand>();

    let daemon_handle = thread::spawn(move || {
        match daemon_rx.recv().unwrap() {
            DaemonCommand::CreateSession {
                selected_model,
                reply,
                ..
            } => {
                // Should have inherited from ToolContext.
                assert_eq!(
                    selected_model.as_deref(),
                    Some("gpt-4o"),
                    "should inherit selected_model from ToolContext",
                );

                let (child_tx, child_rx) = mpsc::channel::<SessionCommand>();
                reply.send(Ok((1u64, child_tx))).unwrap();

                match child_rx.recv().unwrap() {
                    SessionCommand::RunChildInput { reply, .. } => {
                        reply
                            .send(Ok(ChildResult {
                                output: "ok".into(),
                                is_error: false,
                            }))
                            .unwrap();
                    }
                    _ => panic!("expected RunChildInput"),
                }
            }
            _ => panic!("expected CreateSession"),
        }
    });

    let tool_ctx = ToolContext {
        session_id: 1,
        db,
        daemon_tx,
        active_tool_groups: HashSet::new(),
        reasoning_effort: None,
        selected_model: Some("gpt-4o".into()),
        working_dir: None,
        cancelled: Arc::new(AtomicBool::new(false)),
        account_name: None,
    };

    let result = SpawnSubsession.execute(
        SpawnSubsessionArgs {
            prompt: "work".into(),
            title: None,
            categories: None,
        },
        None,
        None,
        Some(&tool_ctx),
    );

    assert!(result.is_ok(), "expected success: {result:?}");
    daemon_handle.join().unwrap();
}