changepacks-java 0.3.3

Java/Gradle project support for changepacks
Documentation
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
//! Batched Gradle project metadata discovery.
//!
//! Runs the Gradle wrapper once per wrapper root with a generated init script
//! that prints one prefixed JSON record per evaluated project, then parses those
//! records back into typed values. `finder.rs` owns project discovery and only
//! consumes [`get_gradle_metadata`] plus the resulting
//! [`GradleWrapperMetadata`] / [`GradleProperties`] values.

use anyhow::{Context, Result};
use std::{
    collections::{HashMap, hash_map::Entry},
    ffi::{OsStr, OsString},
    path::{Path, PathBuf},
};

use crate::finder::GradleCommandSpec;

macro_rules! gradle_metadata_prefix {
    () => {
        "__CHANGEPACKS_GRADLE_METADATA_V1__"
    };
}

pub(crate) const GRADLE_METADATA_PREFIX: &str = gradle_metadata_prefix!();

const GRADLE_METADATA_INIT_SCRIPT: &str = concat!(
    r#"import groovy.json.JsonOutput

gradle.projectsEvaluated { evaluatedGradle ->
    evaluatedGradle.rootProject.allprojects { project ->
        def record = [
            projectDir: project.projectDir.toPath().toAbsolutePath().normalize().toString(),
            projectPath: project.path,
            name: project.name,
            version: project.version == null ? null : project.version.toString(),
            aggregate: !project.childProjects.isEmpty(),
            hasPublishTask: project.tasks.findByName("publish") != null,
            hasPublishToMavenLocalTask: project.tasks.findByName("publishToMavenLocal") != null
        ]
        println(""#,
    gradle_metadata_prefix!(),
    r#"" + JsonOutput.toJson(record))
    }
}
"#
);

/// Project info obtained from batched Gradle metadata.
#[derive(Clone, Debug)]
pub(crate) struct GradleProperties {
    pub(crate) name: Option<String>,
    pub(crate) version: Option<String>,
    pub(crate) has_subprojects: bool,
    pub(crate) has_publish_task: bool,
    pub(crate) has_publish_to_maven_local_task: bool,
}

#[derive(Debug)]
pub(crate) struct GradleMetadataRecord {
    pub(crate) project_path: String,
    pub(crate) properties: GradleProperties,
}

#[derive(Debug)]
pub(crate) struct GradleWrapperMetadata {
    pub(crate) by_project_dir: HashMap<PathBuf, GradleMetadataRecord>,
    pub(crate) project_names_by_path: HashMap<String, String>,
}

/// Removes `field` from a Gradle metadata record and converts it with `extract`.
///
/// The three typed accessors below only differ in the accepted
/// `serde_json::Value` variants and in the type name quoted by the error, so the
/// shared missing-field and wrong-type reporting lives here. `extract` hands the
/// value back through `Err` when it does not match, which keeps the rejected
/// value available for the message without formatting it on the success path.
fn metadata_field<T>(
    fields: &mut serde_json::Map<String, serde_json::Value>,
    field: &str,
    expected: &str,
    extract: impl FnOnce(serde_json::Value) -> std::result::Result<T, serde_json::Value>,
) -> Result<T> {
    match fields.remove(field) {
        Some(value) => extract(value).map_err(|value| {
            anyhow::anyhow!("Gradle metadata field '{field}' must be {expected}, got {value:?}")
        }),
        None => Err(anyhow::anyhow!(
            "Gradle metadata record is missing required field '{field}'"
        )),
    }
}

fn required_metadata_string(
    fields: &mut serde_json::Map<String, serde_json::Value>,
    field: &str,
) -> Result<String> {
    metadata_field(fields, field, "a string", |value| match value {
        serde_json::Value::String(value) => Ok(value),
        other => Err(other),
    })
}

fn optional_metadata_string(
    fields: &mut serde_json::Map<String, serde_json::Value>,
    field: &str,
) -> Result<Option<String>> {
    metadata_field(fields, field, "a string or null", |value| match value {
        serde_json::Value::String(value) => Ok(Some(value)),
        serde_json::Value::Null => Ok(None),
        other => Err(other),
    })
}

fn required_metadata_bool(
    fields: &mut serde_json::Map<String, serde_json::Value>,
    field: &str,
) -> Result<bool> {
    metadata_field(fields, field, "a boolean", |value| match value {
        serde_json::Value::Bool(value) => Ok(value),
        other => Err(other),
    })
}

/// Trims a Gradle property and drops Gradle's `unspecified` sentinel.
///
/// The owned `String` is reused when it is already trimmed, which is the common
/// case, so only a value carrying surrounding whitespace pays for a new
/// allocation. An empty string is a legitimate value and is kept.
fn normalized_gradle_property(value: Option<String>) -> Option<String> {
    value.and_then(|mut value| {
        let trimmed = value.trim();
        if trimmed == "unspecified" {
            return None;
        }
        if trimmed.len() != value.len() {
            value = trimmed.to_owned();
        }
        Some(value)
    })
}

/// Parses one metadata record, returning its raw emitted directory alongside it.
///
/// The directory is only needed until [`get_gradle_metadata`] canonicalizes it
/// into the `by_project_dir` key, so it travels beside the record instead of
/// inside it and is dropped once the record is stored.
fn parse_gradle_metadata_record(json: &str) -> Result<(PathBuf, GradleMetadataRecord)> {
    let mut fields: serde_json::Map<String, serde_json::Value> =
        serde_json::from_str(json).context("invalid Gradle metadata JSON object")?;
    let project_dir = required_metadata_string(&mut fields, "projectDir")?;
    anyhow::ensure!(
        !project_dir.is_empty(),
        "Gradle metadata field 'projectDir' must not be empty"
    );
    let project_path = required_metadata_string(&mut fields, "projectPath")?;
    anyhow::ensure!(
        project_path.starts_with(':'),
        "Gradle metadata field 'projectPath' must be a qualified Gradle path"
    );
    let name = required_metadata_string(&mut fields, "name")?;
    let version = optional_metadata_string(&mut fields, "version")?;
    let has_subprojects = required_metadata_bool(&mut fields, "aggregate")?;
    let has_publish_task = required_metadata_bool(&mut fields, "hasPublishTask")?;
    let has_publish_to_maven_local_task =
        required_metadata_bool(&mut fields, "hasPublishToMavenLocalTask")?;

    Ok((
        PathBuf::from(project_dir),
        GradleMetadataRecord {
            project_path,
            properties: GradleProperties {
                name: normalized_gradle_property(Some(name)),
                version: normalized_gradle_property(version),
                has_subprojects,
                has_publish_task,
                has_publish_to_maven_local_task,
            },
        },
    ))
}

fn parse_gradle_metadata_records(output: &str) -> Result<Vec<(PathBuf, GradleMetadataRecord)>> {
    output
        .lines()
        .enumerate()
        .filter_map(|(line_index, line)| {
            line.strip_prefix(GRADLE_METADATA_PREFIX)
                .map(|record| (line_index, record))
        })
        .map(|(line_index, record)| {
            parse_gradle_metadata_record(record).map_err(|error| {
                anyhow::anyhow!(
                    "malformed Gradle metadata record at line {}: {error:#}",
                    line_index + 1
                )
            })
        })
        .collect()
}

fn gradle_metadata_args(init_script_path: &Path) -> Vec<OsString> {
    vec![
        OsString::from("-Dorg.gradle.configureondemand=false"),
        OsString::from("-Dorg.gradle.configuration-cache=false"),
        OsString::from("--init-script"),
        init_script_path.as_os_str().to_owned(),
        OsString::from("--quiet"),
        OsString::from("help"),
    ]
}

pub(crate) async fn get_gradle_metadata(
    gradlew: &Path,
    gradlew_dir: &Path,
    java_available: bool,
) -> Result<GradleWrapperMetadata> {
    anyhow::ensure!(
        java_available,
        "Java is required for Gradle projects but JAVA_HOME is not set and 'java' was not found on PATH.\n\
         Please set the JAVA_HOME environment variable or add java to your PATH."
    );

    let init_script = tempfile::Builder::new()
        .prefix("changepacks-gradle-metadata-")
        .suffix(".gradle")
        .tempfile()
        .context("Failed to create temporary Gradle metadata init script")?;
    let init_script_path = init_script.path().to_path_buf();
    tokio::fs::write(&init_script_path, GRADLE_METADATA_INIT_SCRIPT)
        .await
        .with_context(|| {
            format!(
                "Failed to write temporary Gradle metadata init script '{}'",
                init_script_path.display()
            )
        })?;

    let args = gradle_metadata_args(&init_script_path);
    let command_spec = GradleCommandSpec::new(gradlew, gradlew_dir, args);
    let output_result = command_spec.command().output().await;
    let cleanup_failure = init_script.close().err().map(|error| {
        format!(
            "failed to remove temporary Gradle metadata init script '{}': {error}",
            init_script_path.display()
        )
    });
    let cleanup_suffix = cleanup_failure
        .as_deref()
        .map_or_else(String::new, |failure| format!("; additionally, {failure}"));
    let output = match output_result {
        Ok(output) => output,
        Err(error) => {
            return Err(anyhow::anyhow!(
                "Failed to execute Gradle metadata discovery for wrapper root '{}' (gradlew: '{}'): {error}{cleanup_suffix}",
                gradlew_dir.display(),
                gradlew.display(),
            ));
        }
    };

    if !output.status.success() {
        let stderr = String::from_utf8_lossy(&output.stderr);
        let stderr_trimmed = stderr.trim();
        return Err(anyhow::anyhow!(
            "Gradle metadata discovery failed for wrapper root '{}' using '{}' with status {}{}{}",
            gradlew_dir.display(),
            gradlew.display(),
            output.status,
            if stderr_trimmed.is_empty() {
                String::new()
            } else {
                format!("; stderr: {stderr_trimmed}")
            },
            cleanup_suffix
        ));
    }

    if let Some(cleanup_failure) = cleanup_failure {
        return Err(anyhow::anyhow!(
            "Temporary Gradle metadata init-script cleanup failed: {cleanup_failure}"
        ));
    }

    let stdout = String::from_utf8_lossy(&output.stdout);
    let records = parse_gradle_metadata_records(&stdout).map_err(|error| {
        anyhow::anyhow!(
            "Failed to parse Gradle metadata emitted by '{}' for wrapper root '{}': {error:#}",
            gradlew.display(),
            gradlew_dir.display()
        )
    })?;
    // Every record needs its directory canonicalized before the purely CPU-bound
    // duplicate detection below can run, and `tokio::fs::canonicalize` is a
    // blocking syscall dispatched to the blocking pool. Awaiting one per record
    // inside the merge loop serializes those syscalls across every subproject of
    // a multi-project build, so they are issued together here instead. The
    // results are then inspected in record order and the first failing one is
    // reported, keeping error selection tied to emission order rather than to
    // whichever syscall happened to fail first.
    let canonicalized = futures::future::join_all(
        records
            .iter()
            .map(|(raw_dir, _)| tokio::fs::canonicalize(raw_dir)),
    )
    .await;
    let mut normalized_dirs = Vec::with_capacity(canonicalized.len());
    for ((raw_dir, record), normalized_dir) in records.iter().zip(canonicalized) {
        normalized_dirs.push(normalized_dir.with_context(|| {
            format!(
                "Failed to normalize Gradle metadata directory '{}' for project '{}' emitted by '{}'",
                raw_dir.display(),
                record.project_path,
                gradlew.display()
            )
        })?);
    }

    let mut by_project_dir: HashMap<PathBuf, GradleMetadataRecord> =
        HashMap::with_capacity(records.len());
    let mut project_names_by_path = HashMap::with_capacity(records.len());
    for ((_raw_dir, record), normalized_dir) in records.into_iter().zip(normalized_dirs) {
        let project_path = record.project_path.clone();
        let project_name = record
            .properties
            .name
            .clone()
            .or_else(|| {
                normalized_dir
                    .file_name()
                    .and_then(OsStr::to_str)
                    .map(str::to_owned)
            })
            .with_context(|| {
                format!(
                    "Gradle metadata project '{}' from '{}' has no usable evaluated project name",
                    project_path,
                    gradlew.display()
                )
            })?;
        match project_names_by_path.entry(project_path) {
            Entry::Occupied(previous) => {
                return Err(anyhow::anyhow!(
                    "Duplicate Gradle metadata project path '{}' from '{}': projects '{}' and '{}'",
                    previous.key(),
                    gradlew.display(),
                    previous.get(),
                    project_name
                ));
            }
            Entry::Vacant(slot) => {
                slot.insert(project_name);
            }
        }
        match by_project_dir.entry(normalized_dir) {
            Entry::Occupied(previous) => {
                return Err(anyhow::anyhow!(
                    "Duplicate Gradle metadata records for normalized directory '{}' from '{}': projects '{}' and '{}'",
                    previous.key().display(),
                    gradlew.display(),
                    previous.get().project_path,
                    record.project_path
                ));
            }
            Entry::Vacant(slot) => {
                slot.insert(record);
            }
        }
    }

    Ok(GradleWrapperMetadata {
        by_project_dir,
        project_names_by_path,
    })
}

#[cfg(test)]
mod tests {
    use super::*;
    use rstest::rstest;

    #[test]
    fn test_gradle_metadata_init_script_reports_publish_task_availability() {
        assert!(
            GRADLE_METADATA_INIT_SCRIPT
                .contains("hasPublishTask: project.tasks.findByName(\"publish\") != null")
        );
        assert!(GRADLE_METADATA_INIT_SCRIPT.contains(
            "hasPublishToMavenLocalTask: project.tasks.findByName(\"publishToMavenLocal\") != null"
        ));
    }

    #[test]
    fn test_parse_gradle_metadata_records_handles_spaces_unicode_and_unrelated_output() {
        let output = concat!(
            "Gradle configuration output\n",
            "unrelated __CHANGEPACKS_GRADLE_METADATA_V1__{not a record}\n",
            "__CHANGEPACKS_GRADLE_METADATA_V1__{\"projectDir\":\"C:\\\\repo with spaces\\\\모듈\",",
            "\"projectPath\":\":module one:유니코드\",\"name\":\"이름 with spaces\",",
            "\"version\":\"1.2.3-β\",\"aggregate\":false,",
            "\"hasPublishTask\":true,\"hasPublishToMavenLocalTask\":false}\n",
            "> Task :help\n",
        );

        let records = parse_gradle_metadata_records(output).unwrap();

        assert_eq!(records.len(), 1);
        let (raw_dir, record) = &records[0];
        assert_eq!(*raw_dir, PathBuf::from(r"C:\repo with spaces\모듈"));
        assert_eq!(record.project_path, ":module one:유니코드");
        assert_eq!(record.properties.name.as_deref(), Some("이름 with spaces"));
        assert_eq!(record.properties.version.as_deref(), Some("1.2.3-β"));
        assert!(!record.properties.has_subprojects);
        assert!(record.properties.has_publish_task);
        assert!(!record.properties.has_publish_to_maven_local_task);
    }

    #[test]
    fn test_parse_gradle_metadata_records_ignores_unknown_protocol_versions() {
        let output = concat!(
            "__CHANGEPACKS_GRADLE_METADATA_V0__{not current metadata}\n",
            "__CHANGEPACKS_GRADLE_METADATA_V2__{not current metadata}\n",
            "ordinary __CHANGEPACKS_GRADLE_METADATA_V1__{not line-prefixed metadata}\n",
        );

        assert!(parse_gradle_metadata_records(output).unwrap().is_empty());
    }

    #[test]
    fn test_parse_gradle_metadata_records_rejects_missing_publish_task_field() {
        let output = concat!(
            "__CHANGEPACKS_GRADLE_METADATA_V1__{\"projectDir\":\"/repo\",",
            "\"projectPath\":\":\",\"name\":\"root\",\"version\":\"1.0.0\",",
            "\"aggregate\":false,\"hasPublishToMavenLocalTask\":true}\n",
        );

        let error = parse_gradle_metadata_records(output).unwrap_err();

        assert!(error.to_string().contains("line 1"));
        assert!(error.to_string().contains("hasPublishTask"));
    }

    #[test]
    fn test_parse_gradle_metadata_records_rejects_non_boolean_local_publish_task_field() {
        let output = concat!(
            "__CHANGEPACKS_GRADLE_METADATA_V1__{\"projectDir\":\"/repo\",",
            "\"projectPath\":\":\",\"name\":\"root\",\"version\":\"1.0.0\",",
            "\"aggregate\":false,\"hasPublishTask\":true,",
            "\"hasPublishToMavenLocalTask\":\"yes\"}\n",
        );

        let error = parse_gradle_metadata_records(output).unwrap_err();

        assert!(error.to_string().contains("line 1"));
        assert!(error.to_string().contains("hasPublishToMavenLocalTask"));
        assert!(error.to_string().contains("must be a boolean"));
    }

    #[test]
    fn test_metadata_field_accessors_report_exact_type_and_missing_wording() {
        let mut fields: serde_json::Map<String, serde_json::Value> =
            serde_json::from_str(r#"{"name":7,"version":true,"aggregate":"yes"}"#).unwrap();

        assert_eq!(
            required_metadata_string(&mut fields, "name")
                .unwrap_err()
                .to_string(),
            "Gradle metadata field 'name' must be a string, got Number(7)"
        );
        assert_eq!(
            optional_metadata_string(&mut fields, "version")
                .unwrap_err()
                .to_string(),
            "Gradle metadata field 'version' must be a string or null, got Bool(true)"
        );
        assert_eq!(
            required_metadata_bool(&mut fields, "aggregate")
                .unwrap_err()
                .to_string(),
            "Gradle metadata field 'aggregate' must be a boolean, got String(\"yes\")"
        );
        assert_eq!(
            required_metadata_string(&mut fields, "name")
                .unwrap_err()
                .to_string(),
            "Gradle metadata record is missing required field 'name'"
        );
        assert!(fields.is_empty());
    }

    #[test]
    fn test_parse_gradle_metadata_records_rejects_malformed_prefixed_record() {
        let output = concat!(
            "ordinary output\n",
            "__CHANGEPACKS_GRADLE_METADATA_V1__{\"projectDir\":\"/repo\",\"aggregate\":wat}\n",
        );

        let error = parse_gradle_metadata_records(output).unwrap_err();

        assert!(error.to_string().contains("line 2"));
        assert!(
            error
                .to_string()
                .contains("malformed Gradle metadata record")
        );
    }

    /// The two guards below reject records that are structurally well formed -
    /// every field present with the right JSON type - but semantically unusable:
    /// an empty `projectDir` would canonicalize against the process working
    /// directory instead of the emitting project, and an unqualified
    /// `projectPath` would never match the `:`-rooted paths the rest of the
    /// crate keys on. Each case keeps every other field valid so only the guard
    /// under test can fire.
    #[rstest]
    #[case::empty_project_dir(
        concat!(
            r#"{"projectDir":"","projectPath":":module","name":"module","#,
            r#""version":"1.0.0","aggregate":false,"hasPublishTask":true,"#,
            r#""hasPublishToMavenLocalTask":true}"#
        ),
        "Gradle metadata field 'projectDir' must not be empty"
    )]
    #[case::unqualified_project_path(
        concat!(
            r#"{"projectDir":"/repo","projectPath":"module","name":"module","#,
            r#""version":"1.0.0","aggregate":false,"hasPublishTask":true,"#,
            r#""hasPublishToMavenLocalTask":true}"#
        ),
        "Gradle metadata field 'projectPath' must be a qualified Gradle path"
    )]
    fn test_parse_gradle_metadata_record_rejects_semantically_invalid_fields(
        #[case] json: &str,
        #[case] expected: &str,
    ) {
        let error = parse_gradle_metadata_record(json).unwrap_err();
        let message = format!("{error:#}");

        assert!(message.contains(expected), "{message}");
    }

    /// Every semantic guard in `parse_gradle_metadata_record` is pinned by the
    /// tests above, but the syntactic guard that turns a `serde_json` failure
    /// into `invalid Gradle metadata JSON object` was not. Gradle stdout is the
    /// least controllable input this crate parses, so a prefixed line that is
    /// valid JSON but not an object, or is truncated mid-object, is a realistic
    /// failure whose wording callers see.
    #[rstest]
    #[case::json_array("[1,2]")]
    #[case::truncated_object(r#"{"projectDir":"/repo""#)]
    #[case::json_null("null")]
    fn test_parse_gradle_metadata_record_rejects_non_object_json(#[case] json: &str) {
        let error = parse_gradle_metadata_record(json).unwrap_err();
        let message = format!("{error:#}");

        assert!(
            message.contains("invalid Gradle metadata JSON object"),
            "{message}"
        );
    }

    #[test]
    fn test_parse_gradle_metadata_records_reports_non_object_json_with_line_index() {
        let output = concat!(
            "ordinary output\n",
            "__CHANGEPACKS_GRADLE_METADATA_V1__[1,2]\n",
        );

        let error = parse_gradle_metadata_records(output).unwrap_err();
        let message = format!("{error:#}");

        assert!(
            message.contains("malformed Gradle metadata record at line 2"),
            "{message}"
        );
        assert!(
            message.contains("invalid Gradle metadata JSON object"),
            "{message}"
        );
    }

    #[rstest]
    #[case(None, None)]
    #[case(Some("1.0"), Some("1.0"))]
    #[case(Some("  1.0  "), Some("1.0"))]
    #[case(Some("\t1.0\n"), Some("1.0"))]
    #[case(Some("unspecified"), None)]
    #[case(Some("  unspecified  "), None)]
    #[case(Some(""), Some(""))]
    #[case(Some("   "), Some(""))]
    #[case(Some("unspecified-core"), Some("unspecified-core"))]
    fn test_normalized_gradle_property(
        #[case] input: Option<&str>,
        #[case] expected: Option<&str>,
    ) {
        assert_eq!(
            normalized_gradle_property(input.map(str::to_owned)).as_deref(),
            expected
        );
    }

    #[test]
    fn test_normalized_gradle_property_reuses_already_trimmed_allocation() {
        let value = String::from("1.0.0");
        let original_ptr = value.as_ptr();

        let normalized = normalized_gradle_property(Some(value)).unwrap();

        assert_eq!(normalized, "1.0.0");
        assert_eq!(normalized.as_ptr(), original_ptr);
    }

    /// The guard rejects the call before any temporary file is created or any
    /// process is spawned, so this test stays portable and touches neither the
    /// filesystem nor a Gradle wrapper even though the paths below do not exist.
    #[tokio::test]
    async fn test_get_gradle_metadata_rejects_unavailable_java() {
        let error = get_gradle_metadata(Path::new("gradlew"), Path::new("."), false)
            .await
            .unwrap_err();

        let message = error.to_string();
        assert!(message.contains("Java is required"), "{message}");
        assert!(message.contains("JAVA_HOME"), "{message}");
    }

    /// Gradle emits `null` for a project that never set a version, so the
    /// `Null` arm is a legitimate wire value and must answer `Ok(None)` rather
    /// than falling through to the wrong-type error the sibling arms produce.
    /// The field is still consumed, exactly as the accepted-string arm does.
    #[test]
    fn test_optional_metadata_string_accepts_json_null() {
        let mut fields: serde_json::Map<String, serde_json::Value> =
            serde_json::from_str(r#"{"version":null}"#).unwrap();

        assert_eq!(
            optional_metadata_string(&mut fields, "version").unwrap(),
            None
        );
        assert!(fields.is_empty());
    }

    /// End-to-end companion to the accessor test above: a record whose
    /// `version` is JSON `null` parses successfully and yields a versionless
    /// project, instead of being rejected as malformed.
    #[test]
    fn test_parse_gradle_metadata_record_accepts_null_version() {
        let (raw_dir, record) = parse_gradle_metadata_record(concat!(
            r#"{"projectDir":"/repo","projectPath":":","name":"root","version":null,"#,
            r#""aggregate":false,"hasPublishTask":true,"hasPublishToMavenLocalTask":true}"#
        ))
        .unwrap();

        assert_eq!(raw_dir, PathBuf::from("/repo"));
        assert_eq!(record.project_path, ":");
        assert_eq!(record.properties.name.as_deref(), Some("root"));
        assert_eq!(record.properties.version, None);
    }

    /// Write a wrapper that deletes the `--init-script` file it was handed and
    /// then exits successfully, leaving nothing for changepacks' own temporary
    /// file cleanup to remove. The script matches the init script by its
    /// `.gradle` extension rather than by argument position, so it stays
    /// correct if the surrounding argument list is reordered.
    fn create_init_script_deleting_gradlew(dir: &Path) -> PathBuf {
        if cfg!(windows) {
            let gradlew = dir.join("gradlew.bat");
            std::fs::write(
                &gradlew,
                "@echo off\r\nfor %%A in (%*) do if /i \"%%~xA\"==\".gradle\" del /q \"%%~A\"\r\nexit /b 0\r\n",
            )
            .unwrap();
            gradlew
        } else {
            let gradlew = dir.join("gradlew");
            std::fs::write(
                &gradlew,
                "#!/bin/sh\nfor arg in \"$@\"; do case $arg in *.gradle) rm -f \"$arg\" ;; esac; done\nexit 0\n",
            )
            .unwrap();
            #[cfg(unix)]
            {
                use std::os::unix::fs::PermissionsExt;

                std::fs::set_permissions(&gradlew, std::fs::Permissions::from_mode(0o755)).unwrap();
            }
            gradlew
        }
    }

    /// A wrapper root that does not exist makes the spawn itself fail, which is
    /// a different failure from a wrapper that runs and exits non-zero: only
    /// this path produces the "Failed to execute" wording, and it must still
    /// name both the wrapper root and the wrapper. Cleanup succeeds here, so
    /// the message must carry no `additionally,` suffix.
    #[tokio::test]
    async fn test_get_gradle_metadata_reports_wrapper_spawn_failure() {
        let temp_dir = tempfile::TempDir::new().unwrap();
        let missing_root = temp_dir.path().join("never-created");
        let gradlew = missing_root.join("gradlew");

        let error = get_gradle_metadata(&gradlew, &missing_root, true)
            .await
            .unwrap_err();
        let message = error.to_string();

        assert!(
            message.contains("Failed to execute Gradle metadata discovery for wrapper root"),
            "{message}"
        );
        assert!(
            message.contains(&missing_root.display().to_string()),
            "{message}"
        );
        assert!(
            message.contains(&gradlew.display().to_string()),
            "{message}"
        );
        assert!(!message.contains("additionally,"), "{message}");

        temp_dir.close().unwrap();
    }

    /// The init script is a temporary file changepacks owns for the duration of
    /// one wrapper invocation. When it can no longer be removed the run is a
    /// failure even though Gradle exited zero, because a leaked init script
    /// would be re-applied to unrelated builds. The report names the cleanup
    /// step and the file it could not remove.
    #[tokio::test]
    async fn test_get_gradle_metadata_reports_init_script_cleanup_failure() {
        let temp_dir = tempfile::TempDir::new().unwrap();
        let gradlew = create_init_script_deleting_gradlew(temp_dir.path());

        let error = get_gradle_metadata(&gradlew, temp_dir.path(), true)
            .await
            .unwrap_err();
        let message = error.to_string();

        assert!(
            message.contains("Temporary Gradle metadata init-script cleanup failed"),
            "{message}"
        );
        assert!(
            message.contains("failed to remove temporary Gradle metadata init script"),
            "{message}"
        );
        assert!(
            message.contains("changepacks-gradle-metadata-"),
            "{message}"
        );

        temp_dir.close().unwrap();
    }
}