cha-core 0.6.5

Core analysis engine for Cha — pluggable code smell detection
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84

mod common;

use cha_core::plugins::*;
use cha_core::*;
use common::*;

#[test]
fn middle_man_triggers() {
    let c = ClassInfo {
        name: "Proxy".into(),
        start_line: 1,
        end_line: 10,
        method_count: 4,
        line_count: 10,
        is_exported: false,
        delegating_method_count: 3,
        field_count: 0,
        field_names: vec![],
        field_types: vec![],
        has_behavior: false,
        is_interface: false,
        parent_name: None,
        override_count: 0,
        self_call_count: 0,
        has_listener_field: false,
        has_notify_method: false,
    };
    let model = make_model(vec![], vec![c], vec![], 10);
    let findings = analyze(&MiddleManAnalyzer::default(), &model);
    assert_eq!(findings.len(), 1);
    assert_eq!(findings[0].smell_name, "middle_man");
}

#[test]
fn middle_man_below_ratio() {
    let c = ClassInfo {
        name: "Mixed".into(),
        start_line: 1,
        end_line: 10,
        method_count: 4,
        line_count: 10,
        is_exported: false,
        delegating_method_count: 1,
        field_count: 0,
        field_names: vec![],
        field_types: vec![],
        has_behavior: false,
        is_interface: false,
        parent_name: None,
        override_count: 0,
        self_call_count: 0,
        has_listener_field: false,
        has_notify_method: false,
    };
    let model = make_model(vec![], vec![c], vec![], 10);
    let findings = analyze(&MiddleManAnalyzer::default(), &model);
    assert!(findings.is_empty());
}

#[test]
fn middle_man_too_few_methods() {
    let c = ClassInfo {
        name: "Tiny".into(),
        start_line: 1,
        end_line: 5,
        method_count: 2,
        line_count: 5,
        is_exported: false,
        delegating_method_count: 2,
        field_count: 0,
        field_names: vec![],
        field_types: vec![],
        has_behavior: false,
        is_interface: false,
        parent_name: None,
        override_count: 0,
        self_call_count: 0,
        has_listener_field: false,
        has_notify_method: false,
    };
    let model = make_model(vec![], vec![c], vec![], 5);
    let findings = analyze(&MiddleManAnalyzer::default(), &model);
    assert!(findings.is_empty());
}